)]}'
{"neutron/db/l3_agentschedulers_db.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"93d0e1dcd2a2fd7d937da9fba997f46f1ed47917","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        try:"},{"line_number":110,"context_line":"            agents_back_online \u003d set()"},{"line_number":111,"context_line":"            for binding in down_bindings:"},{"line_number":112,"context_line":"                if binding.l3_agent_id in agents_back_online:"},{"line_number":113,"context_line":"                    continue"},{"line_number":114,"context_line":"                else:"},{"line_number":115,"context_line":"                    agent \u003d self._get_agent(context, binding.l3_agent_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_fce740aa","line":112,"updated":"2015-12-03 23:41:57.000000000","message":"What if the agent goes back down?","commit_id":"9ec466cd42de94c2fad091edfd7583a5f47eb87a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"de26f6efb29b697cd52ebbd9ff0824c1c187463e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        try:"},{"line_number":110,"context_line":"            agents_back_online \u003d set()"},{"line_number":111,"context_line":"            for binding in down_bindings:"},{"line_number":112,"context_line":"                if binding.l3_agent_id in agents_back_online:"},{"line_number":113,"context_line":"                    continue"},{"line_number":114,"context_line":"                else:"},{"line_number":115,"context_line":"                    agent \u003d self._get_agent(context, binding.l3_agent_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_7204c914","line":112,"in_reply_to":"7a740942_fce740aa","updated":"2015-12-04 07:53:53.000000000","message":"Then It should be caught by the next iteration of the periodic job (current iteration will be finished soon if it\u0027s only one agent that went offline, which I think is the most common case).To me it seems a fair trade off comparing to fetching agent from db for each binding.","commit_id":"9ec466cd42de94c2fad091edfd7583a5f47eb87a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"93d0e1dcd2a2fd7d937da9fba997f46f1ed47917","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            for binding in down_bindings:"},{"line_number":112,"context_line":"                if binding.l3_agent_id in agents_back_online:"},{"line_number":113,"context_line":"                    continue"},{"line_number":114,"context_line":"                else:"},{"line_number":115,"context_line":"                    agent \u003d self._get_agent(context, binding.l3_agent_id)"},{"line_number":116,"context_line":"                    if agent.is_active:"},{"line_number":117,"context_line":"                        agents_back_online.add(binding.l3_agent_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_1c880ce7","line":114,"updated":"2015-12-03 23:41:57.000000000","message":"nit:  No need for else and extra indent.","commit_id":"9ec466cd42de94c2fad091edfd7583a5f47eb87a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"de26f6efb29b697cd52ebbd9ff0824c1c187463e","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            for binding in down_bindings:"},{"line_number":112,"context_line":"                if binding.l3_agent_id in agents_back_online:"},{"line_number":113,"context_line":"                    continue"},{"line_number":114,"context_line":"                else:"},{"line_number":115,"context_line":"                    agent \u003d self._get_agent(context, binding.l3_agent_id)"},{"line_number":116,"context_line":"                    if agent.is_active:"},{"line_number":117,"context_line":"                        agents_back_online.add(binding.l3_agent_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_325c0125","line":114,"in_reply_to":"7a740942_1c880ce7","updated":"2015-12-04 07:53:53.000000000","message":"true, will remove if respin is needed","commit_id":"9ec466cd42de94c2fad091edfd7583a5f47eb87a"}]}
