)]}'
{"quantum/plugins/nicira/nicira_nvp_plugin/QuantumPlugin.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"193c69645ee3827b8475039f2c805e468117384c","unresolved":false,"context_lines":[{"line_number":1941,"context_line":"                port_qry.filter_by(fixed_port_id\u003dfip[\u0027port_id\u0027]).one()"},{"line_number":1942,"context_line":"                raise l3.FloatingIPPortAlreadyAssociated("},{"line_number":1943,"context_line":"                    port_id\u003dfip[\u0027port_id\u0027],"},{"line_number":1944,"context_line":"                    fip_id\u003dfloatingip_db[\u0027id\u0027],"},{"line_number":1945,"context_line":"                    floating_ip_address\u003dfloatingip_db[\u0027floating_ip_address\u0027],"},{"line_number":1946,"context_line":"                    fixed_ip\u003dfloatingip_db[\u0027fixed_ip_address\u0027],"},{"line_number":1947,"context_line":"                    net_id\u003dfloatingip_db[\u0027floating_network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F0y8%3D","line":1944,"updated":"2013-03-26 02:29:09.000000000","message":"Looks good my one thought is if we should replace [\u0027 with .get( so to avoid raising a KeyError. What do you think?","commit_id":"6f752c0125ab1c6a5422c7ddb9c0061eda6fae17"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":1941,"context_line":"                port_qry.filter_by(fixed_port_id\u003dfip[\u0027port_id\u0027]).one()"},{"line_number":1942,"context_line":"                raise l3.FloatingIPPortAlreadyAssociated("},{"line_number":1943,"context_line":"                    port_id\u003dfip[\u0027port_id\u0027],"},{"line_number":1944,"context_line":"                    fip_id\u003dfloatingip_db[\u0027id\u0027],"},{"line_number":1945,"context_line":"                    floating_ip_address\u003dfloatingip_db[\u0027floating_ip_address\u0027],"},{"line_number":1946,"context_line":"                    fixed_ip\u003dfloatingip_db[\u0027fixed_ip_address\u0027],"},{"line_number":1947,"context_line":"                    net_id\u003dfloatingip_db[\u0027floating_network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F0Yo%3D","line":1944,"in_reply_to":"AAAAOH%2F%2F0y8%3D","updated":"2013-03-26 12:17:35.000000000","message":"Since these four keys are defined in FloatingIP model, KeyError is never raised in this case. I think either looks okay.","commit_id":"6f752c0125ab1c6a5422c7ddb9c0061eda6fae17"}]}