)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"f9a4dabcf1849bbf389831e578be07b07a3da5d6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from neutron because all ports are already active."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"WIP: tests to be fixed/added"},{"line_number":16,"context_line":"Closes-Bug: #1522824"},{"line_number":17,"context_line":"Change-Id: I2df34d7ccf7bd45a8d7e992a1c394453f0956612"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_7439d940","line":16,"updated":"2015-12-06 19:51:26.000000000","message":"Can we add Related-Bug: #1450504?","commit_id":"196661f2b892e1a98f85d24e8019898fd4a14dec"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3d3569bc6ae954bf7d2d875e9e6df824eebc5590","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from neutron because all ports are already active."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"WIP: tests to be fixed/added"},{"line_number":16,"context_line":"Closes-Bug: #1522824"},{"line_number":17,"context_line":"Change-Id: I2df34d7ccf7bd45a8d7e992a1c394453f0956612"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_872a0a7d","line":16,"in_reply_to":"7a740942_7439d940","updated":"2015-12-07 08:09:59.000000000","message":"I guess you mean 1450604, will add as related bug","commit_id":"196661f2b892e1a98f85d24e8019898fd4a14dec"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"758c616af4ed8fee64607e3ec0babfae3c11f7c3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to set PENDING_BUILD status for the port as in fact agent needs to"},{"line_number":11,"context_line":"process it before we can say this port is actual and active."},{"line_number":12,"context_line":"This fixes the bug when nova thinks it should not wait for any events"},{"line_number":13,"context_line":"from neutron because all ports are already active."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"ApiImpact"},{"line_number":16,"context_line":"New port status added: PENDING_BUILD"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a7e1126_6f2442c4","line":13,"updated":"2015-12-21 13:22:03.000000000","message":"can you explain how non agent based mech drivers are supposed to deal with the state?","commit_id":"3d0b0889dc580197121a09afd7fa55cab5b0e05c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"858ae798faed555b37e4bc27ac6388b50c38123d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to set PENDING_BUILD status for the port as in fact agent needs to"},{"line_number":11,"context_line":"process it before we can say this port is actual and active."},{"line_number":12,"context_line":"This fixes the bug when nova thinks it should not wait for any events"},{"line_number":13,"context_line":"from neutron because all ports are already active."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"ApiImpact"},{"line_number":16,"context_line":"New port status added: PENDING_BUILD"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a7e1126_86507433","line":13,"in_reply_to":"3a7e1126_60d0cff6","updated":"2015-12-21 14:32:21.000000000","message":"makes sense to me","commit_id":"3d0b0889dc580197121a09afd7fa55cab5b0e05c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"610b54f65ee086098385015e290198efdae7e674","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to set PENDING_BUILD status for the port as in fact agent needs to"},{"line_number":11,"context_line":"process it before we can say this port is actual and active."},{"line_number":12,"context_line":"This fixes the bug when nova thinks it should not wait for any events"},{"line_number":13,"context_line":"from neutron because all ports are already active."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"ApiImpact"},{"line_number":16,"context_line":"New port status added: PENDING_BUILD"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a7e1126_aaea1872","line":13,"in_reply_to":"3a7e1126_6f2442c4","updated":"2015-12-21 13:36:28.000000000","message":"Well, logically they should do the same: once update is actually applied set port back to ACTIVE state. Wondering if this can be done in either precommit or postcommit.","commit_id":"3d0b0889dc580197121a09afd7fa55cab5b0e05c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"bad85efac6820d46b086810a995ac003bb494ea0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to set PENDING_BUILD status for the port as in fact agent needs to"},{"line_number":11,"context_line":"process it before we can say this port is actual and active."},{"line_number":12,"context_line":"This fixes the bug when nova thinks it should not wait for any events"},{"line_number":13,"context_line":"from neutron because all ports are already active."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"ApiImpact"},{"line_number":16,"context_line":"New port status added: PENDING_BUILD"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a7e1126_60d0cff6","line":13,"in_reply_to":"3a7e1126_aaea1872","updated":"2015-12-21 14:19:32.000000000","message":"in that case how about allowing UTs overriding the expected status,\nsimilarly to port_create_status?","commit_id":"3d0b0889dc580197121a09afd7fa55cab5b0e05c"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1f8543faf086d1a6df069292f649b6af47131f04","unresolved":false,"context_lines":[{"line_number":1208,"context_line":"                context, original_port, updated_port)"},{"line_number":1209,"context_line":"            if original_port[\u0027admin_state_up\u0027] !\u003d ("},{"line_number":1210,"context_line":"                    updated_port[\u0027admin_state_up\u0027]):"},{"line_number":1211,"context_line":"                need_port_update_notify \u003d True"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"            if need_port_update_notify:"},{"line_number":1214,"context_line":"                status_update \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_2c8f56cd","line":1211,"updated":"2015-12-07 20:01:53.000000000","message":"nit:  Would prefer this used \u0027|\u003d\u0027 for consistency with all of the others.  But, the original was like this so I could go either way in this patch.\n\n  need_port_update_notify |\u003d original_port[\u0027admin_state_up\u0027] !\u003d (\n      updated_port[\u0027admin_state_up\u0027])","commit_id":"d082199a18694eeb2b9da78fababc0abb58cc2e1"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"d30f9783c5bb08b4663c74b605df0c15ebdb07d6","unresolved":false,"context_lines":[{"line_number":1211,"context_line":"                need_port_update_notify \u003d True"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"            if need_port_update_notify:"},{"line_number":1214,"context_line":"                status_update \u003d {"},{"line_number":1215,"context_line":"                    attributes.PORT:"},{"line_number":1216,"context_line":"                        {\u0027status\u0027: const.PORT_STATUS_PENDING_BUILD}}"},{"line_number":1217,"context_line":"                super(Ml2Plugin, self).update_port(context, id, status_update)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_fce195d1","line":1214,"updated":"2015-12-14 18:59:50.000000000","message":"In this case what happens if a port[\u0027admin_state_up\u0027] changes from False to True.\nDoes that mean that we need to change the port status to PORT_STATUS_PENDING_BUILD.\nJust to clarify.","commit_id":"3d0b0889dc580197121a09afd7fa55cab5b0e05c"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"abec2a55e50fb50d64672094decbf06e3a1dd1bc","unresolved":false,"context_lines":[{"line_number":1211,"context_line":"                need_port_update_notify \u003d True"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"            if need_port_update_notify:"},{"line_number":1214,"context_line":"                status_update \u003d {"},{"line_number":1215,"context_line":"                    attributes.PORT:"},{"line_number":1216,"context_line":"                        {\u0027status\u0027: const.PORT_STATUS_PENDING_BUILD}}"},{"line_number":1217,"context_line":"                super(Ml2Plugin, self).update_port(context, id, status_update)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_7f16b7f2","line":1214,"in_reply_to":"5a710552_34a5da03","updated":"2015-12-15 18:05:31.000000000","message":"Yes got your point. I exactly noticed this behavior where it takes a while for the status to be \"ACTIVE\" when I change the \"admin_state_up\" from false to true.","commit_id":"3d0b0889dc580197121a09afd7fa55cab5b0e05c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a2d87f0ace9235e00e557aba24afae989e255afc","unresolved":false,"context_lines":[{"line_number":1211,"context_line":"                need_port_update_notify \u003d True"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"            if need_port_update_notify:"},{"line_number":1214,"context_line":"                status_update \u003d {"},{"line_number":1215,"context_line":"                    attributes.PORT:"},{"line_number":1216,"context_line":"                        {\u0027status\u0027: const.PORT_STATUS_PENDING_BUILD}}"},{"line_number":1217,"context_line":"                super(Ml2Plugin, self).update_port(context, id, status_update)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_34a5da03","line":1214,"in_reply_to":"5a710552_fce195d1","updated":"2015-12-15 07:35:46.000000000","message":"The idea is that if agent needs to be notified, it means that actual port state is not in sync with DB, so we\u0027re putting port in PENDING_BUILD status meaning it\u0027s pending processing. If \u0027admin_state_up\u0027 changes to False the agent will put port into DOWN state after processing.","commit_id":"3d0b0889dc580197121a09afd7fa55cab5b0e05c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"033a322f52f8ea2cf4b80056c80c6d354490d9e4","unresolved":false,"context_lines":[{"line_number":1201,"context_line":"                status_update \u003d {"},{"line_number":1202,"context_line":"                    attributes.PORT:"},{"line_number":1203,"context_line":"                        {\u0027status\u0027: const.PORT_STATUS_PENDING_BUILD}}"},{"line_number":1204,"context_line":"                super(Ml2Plugin, self).update_port(context, id, status_update)"},{"line_number":1205,"context_line":"            # For DVR router interface ports we need to retrieve the"},{"line_number":1206,"context_line":"            # DVRPortbinding context instead of the normal port context."},{"line_number":1207,"context_line":"            # The normal Portbinding context does not have the status"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_f6d53b1b","line":1204,"updated":"2016-01-07 06:50:55.000000000","message":"I think the mech context that is passed to the drivers will need to be updated as well. Otherwise this status will be completely hidden from them.","commit_id":"58613e4a368eae14b9e700be33cfe34e80b0f48c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"19628a220f8436cef905f4be524e53076ca40f23","unresolved":false,"context_lines":[{"line_number":1201,"context_line":"                status_update \u003d {"},{"line_number":1202,"context_line":"                    attributes.PORT:"},{"line_number":1203,"context_line":"                        {\u0027status\u0027: const.PORT_STATUS_PENDING_BUILD}}"},{"line_number":1204,"context_line":"                super(Ml2Plugin, self).update_port(context, id, status_update)"},{"line_number":1205,"context_line":"            # For DVR router interface ports we need to retrieve the"},{"line_number":1206,"context_line":"            # DVRPortbinding context instead of the normal port context."},{"line_number":1207,"context_line":"            # The normal Portbinding context does not have the status"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_d63c9731","line":1204,"in_reply_to":"da6ed579_b620034b","updated":"2016-01-12 10:57:55.000000000","message":"So I\u0027m wondering if any mech driver might be interested in PENDING_BUILD status as it basically says nothing. I tend to not update mech context here. Thoughts?","commit_id":"58613e4a368eae14b9e700be33cfe34e80b0f48c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cc95147cdb4caca0a7d068d4423a9e40b57bf8f9","unresolved":false,"context_lines":[{"line_number":1201,"context_line":"                status_update \u003d {"},{"line_number":1202,"context_line":"                    attributes.PORT:"},{"line_number":1203,"context_line":"                        {\u0027status\u0027: const.PORT_STATUS_PENDING_BUILD}}"},{"line_number":1204,"context_line":"                super(Ml2Plugin, self).update_port(context, id, status_update)"},{"line_number":1205,"context_line":"            # For DVR router interface ports we need to retrieve the"},{"line_number":1206,"context_line":"            # DVRPortbinding context instead of the normal port context."},{"line_number":1207,"context_line":"            # The normal Portbinding context does not have the status"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_6fc3108a","line":1204,"in_reply_to":"fa69d971_f6d53b1b","updated":"2016-01-11 07:13:22.000000000","message":"Done","commit_id":"58613e4a368eae14b9e700be33cfe34e80b0f48c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"361d6e01ab319a0f593e38d2509a6f13a4c5512c","unresolved":false,"context_lines":[{"line_number":1201,"context_line":"                status_update \u003d {"},{"line_number":1202,"context_line":"                    attributes.PORT:"},{"line_number":1203,"context_line":"                        {\u0027status\u0027: const.PORT_STATUS_PENDING_BUILD}}"},{"line_number":1204,"context_line":"                super(Ml2Plugin, self).update_port(context, id, status_update)"},{"line_number":1205,"context_line":"            # For DVR router interface ports we need to retrieve the"},{"line_number":1206,"context_line":"            # DVRPortbinding context instead of the normal port context."},{"line_number":1207,"context_line":"            # The normal Portbinding context does not have the status"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_b620034b","line":1204,"in_reply_to":"fa69d971_f6d53b1b","updated":"2016-01-12 10:53:31.000000000","message":"Looks like l2pop mech driver needs to know port status before update: active or down. Setting status to PENDING_BUILD in mech context breaks it. Need to handle it somehow..","commit_id":"58613e4a368eae14b9e700be33cfe34e80b0f48c"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"da675295dff251967ec00676e31faef075f8d69c","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"                    updated_port[\u0027admin_state_up\u0027]):"},{"line_number":1198,"context_line":"                need_port_update_notify \u003d True"},{"line_number":1199,"context_line":""},{"line_number":1200,"context_line":"            if need_port_update_notify:"},{"line_number":1201,"context_line":"                status_update \u003d {"},{"line_number":1202,"context_line":"                    attributes.PORT:"},{"line_number":1203,"context_line":"                        {\u0027status\u0027: const.PORT_STATUS_PENDING_BUILD}}"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_274b32b2","line":1200,"updated":"2016-01-13 14:28:06.000000000","message":"I think we should change the port status only if the host changed. That\u0027s the only case when the port is actually being built. The flag need_port_update_notify is True in many cases, that don\u0027t always imply that the port is not ready, e.g. a change in allowed address pair.","commit_id":"96fbcbc5839235e78b09e40671c6d4a1796d9ccd"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"dfeb91a6a79d20d5b2ea1b0086038ade8ee115ac","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"                    updated_port[\u0027admin_state_up\u0027]):"},{"line_number":1198,"context_line":"                need_port_update_notify \u003d True"},{"line_number":1199,"context_line":""},{"line_number":1200,"context_line":"            if need_port_update_notify:"},{"line_number":1201,"context_line":"                status_update \u003d {"},{"line_number":1202,"context_line":"                    attributes.PORT:"},{"line_number":1203,"context_line":"                        {\u0027status\u0027: const.PORT_STATUS_PENDING_BUILD}}"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_448e247a","line":1200,"in_reply_to":"da6ed579_274b32b2","updated":"2016-01-14 14:49:04.000000000","message":"Do you mean that agent will not send update_device_up in other cases? Otherwise I\u0027d like to be generic here and avoid extra checks: if we need to notify agent then agent needs to do some processing, which means that port on agent is not in sync with the server.","commit_id":"96fbcbc5839235e78b09e40671c6d4a1796d9ccd"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"0202f98030a3e33f5cbd0d0d679e010591a14722","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"                    updated_port[\u0027admin_state_up\u0027]):"},{"line_number":1198,"context_line":"                need_port_update_notify \u003d True"},{"line_number":1199,"context_line":""},{"line_number":1200,"context_line":"            if need_port_update_notify:"},{"line_number":1201,"context_line":"                status_update \u003d {"},{"line_number":1202,"context_line":"                    attributes.PORT:"},{"line_number":1203,"context_line":"                        {\u0027status\u0027: const.PORT_STATUS_PENDING_BUILD}}"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_527c66eb","line":1200,"in_reply_to":"da6ed579_448e247a","updated":"2016-01-15 12:32:28.000000000","message":"can\u0027t talk for all the agents, anyway the ovs agent sends an update_device_up when it finishes processing the updated port. I am just wondering if it\u0027s correct to change the state of the port to BUILD even if the port is actually active and only some configuration has changed. With this code the port might be in BUILD status but the corresponding instance is shown as active, that\u0027s a contradiction don\u0027t you think?","commit_id":"96fbcbc5839235e78b09e40671c6d4a1796d9ccd"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"043da34ad8ace0277881da130a43d29b89b6c092","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"                    updated_port[\u0027admin_state_up\u0027]):"},{"line_number":1198,"context_line":"                need_port_update_notify \u003d True"},{"line_number":1199,"context_line":""},{"line_number":1200,"context_line":"            if need_port_update_notify:"},{"line_number":1201,"context_line":"                status_update \u003d {"},{"line_number":1202,"context_line":"                    attributes.PORT:"},{"line_number":1203,"context_line":"                        {\u0027status\u0027: const.PORT_STATUS_PENDING_BUILD}}"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_898ab062","line":1200,"in_reply_to":"da6ed579_527c66eb","updated":"2016-01-15 12:58:29.000000000","message":"Well, BUILD status does not mean that port is not active, it just means that new port config is about to be applied (port device is not in sync with logical config). Port will be set to BUILD state anyway when agent requests device details from server, so this patch only sets it a bit earlier, which is the primary goal of the patch.","commit_id":"96fbcbc5839235e78b09e40671c6d4a1796d9ccd"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"da675295dff251967ec00676e31faef075f8d69c","unresolved":false,"context_lines":[{"line_number":1201,"context_line":"                status_update \u003d {"},{"line_number":1202,"context_line":"                    attributes.PORT:"},{"line_number":1203,"context_line":"                        {\u0027status\u0027: const.PORT_STATUS_PENDING_BUILD}}"},{"line_number":1204,"context_line":"                super(Ml2Plugin, self).update_port(context, id, status_update)"},{"line_number":1205,"context_line":"                mech_context.current[\u0027status\u0027] \u003d ("},{"line_number":1206,"context_line":"                    const.PORT_STATUS_PENDING_BUILD)"},{"line_number":1207,"context_line":"            # For DVR router interface ports we need to retrieve the"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_164d013e","line":1204,"updated":"2016-01-13 14:28:06.000000000","message":"shouldn\u0027t you call update_port_status here?","commit_id":"96fbcbc5839235e78b09e40671c6d4a1796d9ccd"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"dfeb91a6a79d20d5b2ea1b0086038ade8ee115ac","unresolved":false,"context_lines":[{"line_number":1201,"context_line":"                status_update \u003d {"},{"line_number":1202,"context_line":"                    attributes.PORT:"},{"line_number":1203,"context_line":"                        {\u0027status\u0027: const.PORT_STATUS_PENDING_BUILD}}"},{"line_number":1204,"context_line":"                super(Ml2Plugin, self).update_port(context, id, status_update)"},{"line_number":1205,"context_line":"                mech_context.current[\u0027status\u0027] \u003d ("},{"line_number":1206,"context_line":"                    const.PORT_STATUS_PENDING_BUILD)"},{"line_number":1207,"context_line":"            # For DVR router interface ports we need to retrieve the"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_beea8c72","line":1204,"in_reply_to":"da6ed579_164d013e","updated":"2016-01-14 14:49:04.000000000","message":"update_port_status() will call update_port_postcommit() which should not be called inside a transaction. I will consider moving it outside though","commit_id":"96fbcbc5839235e78b09e40671c6d4a1796d9ccd"}]}
