)]}'
{"neutron/tests/unit/agent/common/test_ovs_lib.py":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"ec725536049356058463c43b225f380347adbc3b","unresolved":false,"context_lines":[{"line_number":779,"context_line":""},{"line_number":780,"context_line":"    def test_create_dscp_mark_for_port(self):"},{"line_number":781,"context_line":"        port \u003d 999"},{"line_number":782,"context_line":"        dscp_mark \u003d 104"},{"line_number":783,"context_line":"        self.br.create_dscp_mark_for_port(port, dscp_mark)"},{"line_number":784,"context_line":"        expected \u003d ["},{"line_number":785,"context_line":"            self.br.add_flow(priority\u003d5, in_port\u003dport,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_7938d03d","line":782,"updated":"2015-12-07 15:13:24.000000000","message":"The current DSCP code won\u0027t raise an exception if you put in a value outside it\u0027s range (0-63)\nThe DSCP value will simply not be set by ovs.\nI can add this now.\nShould the tests try a value within the range and 2 outside the range (above and below)?","commit_id":"2266bf7d7d4c3c7863bdc81139734a3e458668bf"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"9fd1d100fbc8d509b8f057a9ea5cdb21aad9c581","unresolved":false,"context_lines":[{"line_number":779,"context_line":""},{"line_number":780,"context_line":"    def test_create_dscp_mark_for_port(self):"},{"line_number":781,"context_line":"        port \u003d 999"},{"line_number":782,"context_line":"        dscp_mark \u003d 104"},{"line_number":783,"context_line":"        self.br.create_dscp_mark_for_port(port, dscp_mark)"},{"line_number":784,"context_line":"        expected \u003d ["},{"line_number":785,"context_line":"            self.br.add_flow(priority\u003d5, in_port\u003dport,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_6f5a3e2c","line":782,"in_reply_to":"7a740942_7938d03d","updated":"2015-12-07 15:36:53.000000000","message":"If you\u0027re using mod_nw_tos, then you should be using multiples of 4 between 0 and 255.  Please see: http://openvswitch.org/support/dist-docs/ovs-ofctl.8.txt - quoted below:\n\n\"  mod_nw_tos:tos\n                     Sets the DSCP bits in the IPv4 ToS/DSCP or  IPv6  traffic\n                     class field to tos, which must be a multiple of 4 between\n                     0 and 255.  This action does not  modify  the  two  least\n                     significant bits of the ToS field (the ECN bits).\"\n\nAnd in reality, not every multiple of 4 between 0 and 255 is valid, per this chart.  Valid values are in the \"ToS (dec)\" column. http://bytesolutions.com/Support/Knowledgebase/KB_Viewer/ArticleId/34/DSCP-TOS-CoS-Presidence-conversion-chart.aspx\n\nThe only valid values are: 0, 32, 40, 48, 56, 64, 72, 80, 88, 96, 104, 112, 120, 128, 136, 144, 152, 160, 184, 192, 224.  And I think it might be debatable that 192 and 224 are valid uses within a Neutron context.  I think we should in the DSCP code check to see if a valid ToS number is being supplied and return an error to the user if an invalid value is supplied.","commit_id":"2266bf7d7d4c3c7863bdc81139734a3e458668bf"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"1a797a5ef06b752088b5b84aa29bfc31f49362a6","unresolved":false,"context_lines":[{"line_number":779,"context_line":""},{"line_number":780,"context_line":"    def test_create_dscp_mark_for_port(self):"},{"line_number":781,"context_line":"        port \u003d 999"},{"line_number":782,"context_line":"        dscp_mark \u003d 26"},{"line_number":783,"context_line":"        self.br.create_dscp_mark_for_port(port, dscp_mark)"},{"line_number":784,"context_line":"        expected \u003d ["},{"line_number":785,"context_line":"            self._get_port_ofport(port),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_07f79e8b","line":782,"updated":"2015-12-08 16:21:14.000000000","message":"26 isn\u0027t divisible by 4, it will need to be bit shifted 2 to the left.\nif 26 is the value you want to write over the whole ToS you will need to strip the last 2 bits and apply them with another action.\nie.\n\ntos \u003d 26\n\ndscp_mark \u003d tos\u00260xFC\n\necn_mark \u003d tos\u00260x03\n\nself.br.add_flow(priority\u003d1, in_port\u003dport,\nactions\u003d\u0027mod_nw_tos:%s,mod_nw_ecn:%s,normal\u0027 % dscp_mark,\n%ecn_mark)","commit_id":"366e2a9ecd31efc8ab943189470fad88edf199bc"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"971ae8b9d2afd4302f7ab923925aacc20abdfd1e","unresolved":false,"context_lines":[{"line_number":779,"context_line":""},{"line_number":780,"context_line":"    def test_create_dscp_mark_for_port(self):"},{"line_number":781,"context_line":"        port \u003d 999"},{"line_number":782,"context_line":"        dscp_mark \u003d 26"},{"line_number":783,"context_line":"        self.br.create_dscp_mark_for_port(port, dscp_mark)"},{"line_number":784,"context_line":"        expected \u003d ["},{"line_number":785,"context_line":"            self._get_port_ofport(port),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_cb4d1cc5","line":782,"in_reply_to":"7a740942_07f79e8b","updated":"2015-12-08 18:13:41.000000000","message":"Bah, humbug, that was a typo.  I meant to type \u002724\u0027.","commit_id":"366e2a9ecd31efc8ab943189470fad88edf199bc"}],"neutron/tests/unit/objects/qos/test_policy.py":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"fcd511d682c270733f3f4ae9b111dc86a3ab6871","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.model_map \u003d {"},{"line_number":39,"context_line":"            self._test_class.db_model: self.db_objs,"},{"line_number":40,"context_line":"            rule.QosBandwidthLimitRule.db_model: self.db_qos_bandwidth_rules,"},{"line_number":41,"context_line":"            rule.QosDscpMarkRule.db_model: self.db_qos_dscp_rules}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def fake_get_objects(self, context, model, **kwargs):"},{"line_number":44,"context_line":"        return self.model_map[model]"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_ffda6be7","line":41,"range":{"start_line":41,"start_character":17,"end_line":41,"end_character":32},"updated":"2015-12-18 13:01:16.000000000","message":"The rule name has been updated to QosDscpMarkingRule to fall more inline with the original spec.","commit_id":"6a296a115622f348b7106a487235a6b860cc194c"}]}
