)]}'
{"neutron/db/l3_dvrscheduler_db.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2a82a84d2eaec253b2377ca31576b8a7f540f419","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    the state of the router and the Compute Nodes."},{"line_number":99,"context_line":"    \"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def schedule_or_update_dvr_for_service_port(self, context, port):"},{"line_number":102,"context_line":"        \"\"\"Update or schedule a dvr router for service port."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        When a new dvr serviceable port is created, this function will"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_9e01edb1","line":101,"updated":"2015-12-07 11:59:50.000000000","message":"consider just \u0027dvr_handle_new_port\u0027","commit_id":"57fca7ff2c666514d04a673ab22c6034d5036f3f"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"f872f684ae58fd8f95ae1ddb48d51527e43c8a64","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    the state of the router and the Compute Nodes."},{"line_number":99,"context_line":"    \"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def schedule_or_update_dvr_for_service_port(self, context, port):"},{"line_number":102,"context_line":"        \"\"\"Update or schedule a dvr router for service port."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        When a new dvr serviceable port is created, this function will"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_b625cc09","line":101,"in_reply_to":"7a740942_3b3f9525","updated":"2015-12-07 23:38:25.000000000","message":"Done","commit_id":"57fca7ff2c666514d04a673ab22c6034d5036f3f"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"822ed2201e64c450618f9c3cccf261647e195c18","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    the state of the router and the Compute Nodes."},{"line_number":99,"context_line":"    \"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def schedule_or_update_dvr_for_service_port(self, context, port):"},{"line_number":102,"context_line":"        \"\"\"Update or schedule a dvr router for service port."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        When a new dvr serviceable port is created, this function will"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_3b3f9525","line":101,"in_reply_to":"7a740942_5577d0d2","updated":"2015-12-07 17:39:25.000000000","message":"My consern is that current name is not accurate: the method schedules router to l3 agent on compute node where new port is bound if it is required and sends notification to that l3 agent (in particular \u0027_or_\u0027 is not accurate).Since it is hard to come up with a short name to describe full method functionality I thought it would make semse to name it just dvr_handle_new_port (which is what function actually does) and give more details in description.","commit_id":"57fca7ff2c666514d04a673ab22c6034d5036f3f"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"67fbec440dd9994fe1b12c0cd381b8486f52dcc4","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    the state of the router and the Compute Nodes."},{"line_number":99,"context_line":"    \"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def schedule_or_update_dvr_for_service_port(self, context, port):"},{"line_number":102,"context_line":"        \"\"\"Update or schedule a dvr router for service port."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        When a new dvr serviceable port is created, this function will"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_5577d0d2","line":101,"in_reply_to":"7a740942_9e01edb1","updated":"2015-12-07 17:08:22.000000000","message":"I still think the function name kind of provides the real functionality rather than saying \"handles\" new_port.\n\nPlease let me know if you have any issues if I continue with this function name. If you think it is a blocker I will change it.","commit_id":"57fca7ff2c666514d04a673ab22c6034d5036f3f"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2a82a84d2eaec253b2377ca31576b8a7f540f419","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    \"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def schedule_or_update_dvr_for_service_port(self, context, port):"},{"line_number":102,"context_line":"        \"\"\"Update or schedule a dvr router for service port."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        When a new dvr serviceable port is created, this function will"},{"line_number":105,"context_line":"        check for the port\u0027s host binding and scheduled routers on the"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_5eb865c8","line":102,"updated":"2015-12-07 11:59:50.000000000","message":"\u0027Handle new dvr serviceable port creation\u0027","commit_id":"57fca7ff2c666514d04a673ab22c6034d5036f3f"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"f872f684ae58fd8f95ae1ddb48d51527e43c8a64","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    \"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def schedule_or_update_dvr_for_service_port(self, context, port):"},{"line_number":102,"context_line":"        \"\"\"Update or schedule a dvr router for service port."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        When a new dvr serviceable port is created, this function will"},{"line_number":105,"context_line":"        check for the port\u0027s host binding and scheduled routers on the"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_561ee8bb","line":102,"in_reply_to":"7a740942_5eb865c8","updated":"2015-12-07 23:38:25.000000000","message":"Done","commit_id":"57fca7ff2c666514d04a673ab22c6034d5036f3f"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"67fbec440dd9994fe1b12c0cd381b8486f52dcc4","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    \"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def schedule_or_update_dvr_for_service_port(self, context, port):"},{"line_number":102,"context_line":"        \"\"\"Update or schedule a dvr router for service port."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        When a new dvr serviceable port is created, this function will"},{"line_number":105,"context_line":"        check for the port\u0027s host binding and scheduled routers on the"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_555ef044","line":102,"in_reply_to":"7a740942_5eb865c8","updated":"2015-12-07 17:08:22.000000000","message":"this should align with the function name and I will stick to that.","commit_id":"57fca7ff2c666514d04a673ab22c6034d5036f3f"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2a82a84d2eaec253b2377ca31576b8a7f540f419","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def schedule_or_update_dvr_for_service_port(self, context, port):"},{"line_number":102,"context_line":"        \"\"\"Update or schedule a dvr router for service port."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        When a new dvr serviceable port is created, this function will"},{"line_number":105,"context_line":"        check for the port\u0027s host binding and scheduled routers on the"},{"line_number":106,"context_line":"        host."},{"line_number":107,"context_line":"        If the routers are already scheduled in the given host, this will"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_7ebd21b6","line":104,"updated":"2015-12-07 11:59:50.000000000","message":"This will schedule a dvr router to new compute node if needed and notify l3 agent on than node.","commit_id":"57fca7ff2c666514d04a673ab22c6034d5036f3f"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"f872f684ae58fd8f95ae1ddb48d51527e43c8a64","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def schedule_or_update_dvr_for_service_port(self, context, port):"},{"line_number":102,"context_line":"        \"\"\"Update or schedule a dvr router for service port."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        When a new dvr serviceable port is created, this function will"},{"line_number":105,"context_line":"        check for the port\u0027s host binding and scheduled routers on the"},{"line_number":106,"context_line":"        host."},{"line_number":107,"context_line":"        If the routers are already scheduled in the given host, this will"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_167b80f6","line":104,"in_reply_to":"7a740942_7ebd21b6","updated":"2015-12-07 23:38:25.000000000","message":"Done","commit_id":"57fca7ff2c666514d04a673ab22c6034d5036f3f"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"67fbec440dd9994fe1b12c0cd381b8486f52dcc4","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def schedule_or_update_dvr_for_service_port(self, context, port):"},{"line_number":102,"context_line":"        \"\"\"Update or schedule a dvr router for service port."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        When a new dvr serviceable port is created, this function will"},{"line_number":105,"context_line":"        check for the port\u0027s host binding and scheduled routers on the"},{"line_number":106,"context_line":"        host."},{"line_number":107,"context_line":"        If the routers are already scheduled in the given host, this will"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_552590be","line":104,"in_reply_to":"7a740942_7ebd21b6","updated":"2015-12-07 17:08:22.000000000","message":"Yes I will change it.","commit_id":"57fca7ff2c666514d04a673ab22c6034d5036f3f"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3c53ebad0683e0bc6bdddc0b33ac45b113a3eaec","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                    context, router_id, l3_agent_on_host[\u0027id\u0027]):"},{"line_number":119,"context_line":"                self.schedule_router("},{"line_number":120,"context_line":"                    context, router_id, candidates\u003d[l3_agent_on_host])"},{"line_number":121,"context_line":"            LOG.debug(\u0027DVR: Handle new service_port :\u0027"},{"line_number":122,"context_line":"                      \u0027%s \u0027, router_id)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.l3_rpc_notifier.routers_updated_on_host("},{"line_number":125,"context_line":"            context, router_ids, port_host)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_76604436","line":122,"range":{"start_line":121,"start_character":12,"end_line":122,"end_character":39},"updated":"2015-12-17 08:25:50.000000000","message":"doesn\u0027t it fit in one line?","commit_id":"b9d191d14ea0846b89d0a7f64a2a0a60810f7b2a"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"bc8635fd6ea9cd1dc18049425e8bbaba9f1916a0","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                self.schedule_router("},{"line_number":120,"context_line":"                    context, router_id, candidates\u003d[l3_agent_on_host])"},{"line_number":121,"context_line":"            LOG.debug(\u0027DVR: Handle new service_port :\u0027"},{"line_number":122,"context_line":"                      \u0027%s \u0027, router_id)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.l3_rpc_notifier.routers_updated_on_host("},{"line_number":125,"context_line":"            context, router_ids, port_host)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_e248078a","line":122,"range":{"start_line":122,"start_character":24,"end_line":122,"end_character":25},"updated":"2015-12-17 03:28:28.000000000","message":"nit:\n\n\nLOG.debug(\u0027DVR: Handle new service_port: \u0027\n          \u0027%s\u0027, router_id)","commit_id":"b9d191d14ea0846b89d0a7f64a2a0a60810f7b2a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8f21a2d0903f6ca65d0f3ac1263796beb5949ac4","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                    context, router_id, l3_agent_on_host[\u0027id\u0027]):"},{"line_number":119,"context_line":"                self.schedule_router("},{"line_number":120,"context_line":"                    context, router_id, candidates\u003d[l3_agent_on_host])"},{"line_number":121,"context_line":"            LOG.debug(\u0027DVR: Handle new service_port :\u0027"},{"line_number":122,"context_line":"                      \u0027%s \u0027, router_id)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.l3_rpc_notifier.routers_updated_on_host("},{"line_number":125,"context_line":"            context, router_ids, port_host)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_d37c8674","line":122,"range":{"start_line":121,"start_character":12,"end_line":122,"end_character":39},"in_reply_to":"3a7e1126_76604436","updated":"2015-12-17 14:29:30.000000000","message":"I\u0027ll change this to:\n\nLOG.debug(\u0027DVR: Handle new service_port on router: %s\u0027, router_id)\n\nTo keep this change moving along.","commit_id":"b9d191d14ea0846b89d0a7f64a2a0a60810f7b2a"}]}
