)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"be4c8378913776c4716cc764a2d342bfc47b605d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean M. Collins \u003csean@coreitpro.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-07 14:22:12 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Display binding errors at ERROR level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It\u0027s an informative message and will help operators determine that an"},{"line_number":10,"context_line":"agent is misconfigured without having to increase the logging level to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_e78087c2","line":7,"updated":"2015-12-07 20:16:48.000000000","message":"I tried making that change here:\nhttps://review.openstack.org/#/c/125115/\n\nBack then I changed ML2\u0027s binding error log to ERROR, but kept the individual agents at DEBUG. The reason is that ML2 as you know supports having multiple mech drivers, and more than one agent on a machine, so you could have one mech driver fail and then the next one would succeed. The first mech driver\u0027s failure could be expected, in which case it isn\u0027t really an error. I can\u0027t think of an example off the top of my head where you\u0027d have two agents and two mech drivers, and they\u0027d actually differ on network_type or bridge_mappings. If you have SRIOV and OVS on a machine (Which is actually useful and done a lot) ML2 would bind according to vnic_type and wouldn\u0027t even try to look at network_type or bridge_mappings.\n\nWhat I\u0027m trying to say with so many words, is that we\u0027d need to find a way to differentiate between expected and unexpected binding failures.","commit_id":"e602e13112b57850d65ef24c6df1bdfdb5441740"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"fbeeb6af9a07a7142e06ae9f65323329130dabb5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean M. Collins \u003csean@coreitpro.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-07 14:22:12 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Display binding errors at ERROR level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It\u0027s an informative message and will help operators determine that an"},{"line_number":10,"context_line":"agent is misconfigured without having to increase the logging level to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa69d971_1694b640","line":7,"updated":"2016-01-06 13:15:55.000000000","message":"Yes, unfortunately this is completely benign in multi-segment networks as well. I think perhaps we will need a larger change where check_segment_for_agent returns more than a boolean to also include the reason as well. Then when all of them fail, the reasons can be dumped out to the error log.","commit_id":"e602e13112b57850d65ef24c6df1bdfdb5441740"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"037a18a6bc17b212ef7f88d5ab6e24271aebc395","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean M. Collins \u003csean@coreitpro.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-07 14:22:12 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Display binding errors at ERROR level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It\u0027s an informative message and will help operators determine that an"},{"line_number":10,"context_line":"agent is misconfigured without having to increase the logging level to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_71b44e34","line":7,"in_reply_to":"7a740942_e78087c2","updated":"2015-12-07 23:54:25.000000000","message":"I agree with Assaf.","commit_id":"e602e13112b57850d65ef24c6df1bdfdb5441740"}],"neutron/plugins/ml2/drivers/mech_agent.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"07a8bc0607d4bace1c3396b4e5c13d944ff1b355","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        network_type \u003d segment[api.NETWORK_TYPE]"},{"line_number":186,"context_line":"        if network_type not in allowed_network_types:"},{"line_number":187,"context_line":"            LOG.error("},{"line_number":188,"context_line":"                \u0027Network %(network_id)s is of type %(network_type)s \u0027"},{"line_number":189,"context_line":"                \u0027but agent %(agent)s or mechanism driver only \u0027"},{"line_number":190,"context_line":"                \u0027support %(allowed_network_types)s.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_09b84c29","line":187,"updated":"2015-12-07 19:16:12.000000000","message":"this is missing _LE hint","commit_id":"efb28aa9b9efb93ce0d6dc8fbc559b5ae1d6bcaf"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"7caf005a7ac6366751816c65dd9b719fb8722220","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        network_type \u003d segment[api.NETWORK_TYPE]"},{"line_number":186,"context_line":"        if network_type not in allowed_network_types:"},{"line_number":187,"context_line":"            LOG.error("},{"line_number":188,"context_line":"                \u0027Network %(network_id)s is of type %(network_type)s \u0027"},{"line_number":189,"context_line":"                \u0027but agent %(agent)s or mechanism driver only \u0027"},{"line_number":190,"context_line":"                \u0027support %(allowed_network_types)s.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_09c36c39","line":187,"in_reply_to":"7a740942_09b84c29","updated":"2015-12-07 19:22:49.000000000","message":"Done","commit_id":"efb28aa9b9efb93ce0d6dc8fbc559b5ae1d6bcaf"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"07a8bc0607d4bace1c3396b4e5c13d944ff1b355","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        if network_type in [p_constants.TYPE_FLAT, p_constants.TYPE_VLAN]:"},{"line_number":198,"context_line":"            physnet \u003d segment[api.PHYSICAL_NETWORK]"},{"line_number":199,"context_line":"            if not self.physnet_in_mappings(physnet, mappings):"},{"line_number":200,"context_line":"                LOG.error("},{"line_number":201,"context_line":"                    \u0027Network %(network_id)s is connected to physical \u0027"},{"line_number":202,"context_line":"                    \u0027network %(physnet)s, but agent %(agent)s reported \u0027"},{"line_number":203,"context_line":"                    \u0027physical networks %(mappings)s. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_897afc75","line":200,"updated":"2015-12-07 19:16:12.000000000","message":"ditto","commit_id":"efb28aa9b9efb93ce0d6dc8fbc559b5ae1d6bcaf"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"7caf005a7ac6366751816c65dd9b719fb8722220","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        if network_type in [p_constants.TYPE_FLAT, p_constants.TYPE_VLAN]:"},{"line_number":198,"context_line":"            physnet \u003d segment[api.PHYSICAL_NETWORK]"},{"line_number":199,"context_line":"            if not self.physnet_in_mappings(physnet, mappings):"},{"line_number":200,"context_line":"                LOG.error("},{"line_number":201,"context_line":"                    \u0027Network %(network_id)s is connected to physical \u0027"},{"line_number":202,"context_line":"                    \u0027network %(physnet)s, but agent %(agent)s reported \u0027"},{"line_number":203,"context_line":"                    \u0027physical networks %(mappings)s. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_29c0a829","line":200,"in_reply_to":"7a740942_897afc75","updated":"2015-12-07 19:22:49.000000000","message":"Done","commit_id":"efb28aa9b9efb93ce0d6dc8fbc559b5ae1d6bcaf"}]}
