)]}'
{"neutron/cmd/netns_cleanup.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"59eee6e97cc620b49865df499a2b3c22c9773c1b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    return force or ip.namespace_is_empty()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"def unplug_device(conf, device):"},{"line_number":115,"context_line":"    try:"},{"line_number":116,"context_line":"        device.set_log_fail_as_error(False)"},{"line_number":117,"context_line":"        device.link.delete()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_91c69a98","line":114,"updated":"2015-12-07 23:56:14.000000000","message":"nothing ensures log_fail_as_error is True before unplug_device call","commit_id":"0950e51063fdfb311ceea39d1d5260ea3b001f9f"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7258d969954f296a2a7c020e3523ee5e108eb07e","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    return force or ip.namespace_is_empty()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"def unplug_device(conf, device):"},{"line_number":115,"context_line":"    try:"},{"line_number":116,"context_line":"        device.set_log_fail_as_error(False)"},{"line_number":117,"context_line":"        device.link.delete()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_918bfac2","line":114,"in_reply_to":"7a740942_313326ad","updated":"2015-12-08 00:11:48.000000000","message":"\"In the current code it\u0027s freshly constructed and returned from the call to get_devices\": it assumes how the method is used in neutron. If in the future this method is used in a different context then the assumption could become False and for sure no one will update log_fail_as_error management in unplug_device","commit_id":"0950e51063fdfb311ceea39d1d5260ea3b001f9f"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"dee2002d4b9bcb97f521fe0f60e843ebe1e3bfa4","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    return force or ip.namespace_is_empty()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"def unplug_device(conf, device):"},{"line_number":115,"context_line":"    try:"},{"line_number":116,"context_line":"        device.set_log_fail_as_error(False)"},{"line_number":117,"context_line":"        device.link.delete()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_d7fbb279","line":114,"in_reply_to":"7a740942_37f0f6fd","updated":"2015-12-08 01:10:55.000000000","message":"exactly, iirc, ip_lib already uses this in exists()","commit_id":"0950e51063fdfb311ceea39d1d5260ea3b001f9f"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"9e3cc0f8ce85d7f231d9dfff4e496bfb98bf9982","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    return force or ip.namespace_is_empty()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"def unplug_device(conf, device):"},{"line_number":115,"context_line":"    try:"},{"line_number":116,"context_line":"        device.set_log_fail_as_error(False)"},{"line_number":117,"context_line":"        device.link.delete()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_37f0f6fd","line":114,"in_reply_to":"7a740942_918bfac2","updated":"2015-12-08 00:55:16.000000000","message":"OK, I don\u0027t fully understand your point - You\u0027re saying the previous value should be set at the end of the function instead of blindly setting it to True?","commit_id":"0950e51063fdfb311ceea39d1d5260ea3b001f9f"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"cd94cd231a3d7549702c900263d4ca8989c63ff9","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    return force or ip.namespace_is_empty()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"def unplug_device(conf, device):"},{"line_number":115,"context_line":"    try:"},{"line_number":116,"context_line":"        device.set_log_fail_as_error(False)"},{"line_number":117,"context_line":"        device.link.delete()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_313326ad","line":114,"in_reply_to":"7a740942_91c69a98","updated":"2015-12-07 23:58:48.000000000","message":"You\u0027re talking about future proofing? I don\u0027t know how we could do that. In the current code it\u0027s freshly constructed and returned from the call to get_devices, so it\u0027s gonna be True.","commit_id":"0950e51063fdfb311ceea39d1d5260ea3b001f9f"}]}
