)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2c7eb175f37f270862f3ff94286de34586966e64","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the new port to kernel. Even if the port is updated in ovs db and can"},{"line_number":12,"context_line":"be found on br-int, system can\u0027t see the new port. This will break"},{"line_number":13,"context_line":"the following actions, which will manipulate the new port by ip"},{"line_number":14,"context_line":"commands. Not sure if it is a bug in OVS."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The problem here will break the scenario that namespace is deleted"},{"line_number":17,"context_line":"unexpectedly, and l3-agent trys to rebuild the namespace at restart."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_74a15cf7","line":14,"updated":"2015-12-08 22:58:55.000000000","message":"You should determine this.  Either open a bug with ovs or start a thread on the ovs-dev mailing list to determine this.  Maybe they have a better idea for this use case.  Either way, please reference it here.","commit_id":"397a6207cc6639a5bcc3391c2773395d243bc953"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"2fe91fc707d113263fb9f6bb8ddde1c68734a7d0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the new port to kernel. Even if the port is updated in ovs db and can"},{"line_number":12,"context_line":"be found on br-int, system can\u0027t see the new port. This will break"},{"line_number":13,"context_line":"the following actions, which will manipulate the new port by ip"},{"line_number":14,"context_line":"commands. Not sure if it is a bug in OVS."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The problem here will break the scenario that namespace is deleted"},{"line_number":17,"context_line":"unexpectedly, and l3-agent trys to rebuild the namespace at restart."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a710552_8f9d555b","line":14,"in_reply_to":"7a740942_74a15cf7","updated":"2015-12-16 07:14:08.000000000","message":"I just send the mail to ovs-discuss mailing list, will post the link to mail list in next patch.","commit_id":"397a6207cc6639a5bcc3391c2773395d243bc953"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2c7eb175f37f270862f3ff94286de34586966e64","unresolved":false,"context_lines":[{"line_number":14,"context_line":"commands. Not sure if it is a bug in OVS."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The problem here will break the scenario that namespace is deleted"},{"line_number":17,"context_line":"unexpectedly, and l3-agent trys to rebuild the namespace at restart."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Separating replace_port to two commands: del-port and add-port,"},{"line_number":20,"context_line":"matches the original logic and has been verified that it can resolve"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_697f45e0","line":17,"updated":"2015-12-08 22:58:55.000000000","message":"*tries","commit_id":"397a6207cc6639a5bcc3391c2773395d243bc953"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"2fe91fc707d113263fb9f6bb8ddde1c68734a7d0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"commands. Not sure if it is a bug in OVS."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The problem here will break the scenario that namespace is deleted"},{"line_number":17,"context_line":"unexpectedly, and l3-agent trys to rebuild the namespace at restart."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Separating replace_port to two commands: del-port and add-port,"},{"line_number":20,"context_line":"matches the original logic and has been verified that it can resolve"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a710552_0faac570","line":17,"in_reply_to":"7a740942_697f45e0","updated":"2015-12-16 07:14:08.000000000","message":"Done","commit_id":"397a6207cc6639a5bcc3391c2773395d243bc953"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2c7eb175f37f270862f3ff94286de34586966e64","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def replace_port(self, port_name, *interface_attr_tuples):"},{"line_number":232,"context_line":"        \"\"\"Replace existing port or create it, and configure port interface.\"\"\""},{"line_number":233,"context_line":"        self.ovsdb.del_port(port_name).execute()"},{"line_number":234,"context_line":"        with self.ovsdb.transaction() as txn:"},{"line_number":235,"context_line":"            txn.add(self.ovsdb.add_port(self.br_name, port_name,"},{"line_number":236,"context_line":"                                        may_exist\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_89dab115","line":233,"updated":"2015-12-08 22:58:55.000000000","message":"It might not be obvious to future code readers why this command is outside the transaction.  At last a note should be added.  On the other hand, is there an explicit \"flush\" or something in an ovs transaction.  It might be clearer if the only change here was a flush between the two commands with a note about why that has to be there.","commit_id":"397a6207cc6639a5bcc3391c2773395d243bc953"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"2fe91fc707d113263fb9f6bb8ddde1c68734a7d0","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def replace_port(self, port_name, *interface_attr_tuples):"},{"line_number":232,"context_line":"        \"\"\"Replace existing port or create it, and configure port interface.\"\"\""},{"line_number":233,"context_line":"        self.ovsdb.del_port(port_name).execute()"},{"line_number":234,"context_line":"        with self.ovsdb.transaction() as txn:"},{"line_number":235,"context_line":"            txn.add(self.ovsdb.add_port(self.br_name, port_name,"},{"line_number":236,"context_line":"                                        may_exist\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_cff27d6f","line":233,"in_reply_to":"7a740942_89dab115","updated":"2015-12-16 07:14:08.000000000","message":"I will add a note here, but I don\u0027t think there is a flush in the transaction. Per my understanding, the transaction here is a cmd factory, only one commit will be send out with its exit.","commit_id":"397a6207cc6639a5bcc3391c2773395d243bc953"}]}
