)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"d305de109ed2090049fdf843e09ed7277f0492d5","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I8cda00c1e7caffc4dfb20a817a11c60736855bb5"},{"line_number":19,"context_line":"Closes-Bug: #1523780"},{"line_number":20,"context_line":"Closes-Bug: #1367157"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_2ae621e8","line":20,"range":{"start_line":20,"start_character":1,"end_line":20,"end_character":20},"updated":"2015-12-08 16:22:34.000000000","message":"You should use Related-Bug here.","commit_id":"38479267ee49990d3a9ac0fcdce9801e01168e4b"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"145f2fb19b2f714c3e9dc5ae305202abe366442e","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I8cda00c1e7caffc4dfb20a817a11c60736855bb5"},{"line_number":19,"context_line":"Closes-Bug: #1523780"},{"line_number":20,"context_line":"Closes-Bug: #1367157"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_f7846bd3","line":20,"in_reply_to":"7a740942_2ae621e8","updated":"2015-12-09 01:46:17.000000000","message":"Done","commit_id":"38479267ee49990d3a9ac0fcdce9801e01168e4b"}],"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"6ea1f105da64ac9ca4703831729ec04d7a98094d","unresolved":false,"context_lines":[{"line_number":509,"context_line":"                LOG.info(_LI(\"HA network %s can not be deleted.\"),"},{"line_number":510,"context_line":"                         ha_network.network_id)"},{"line_number":511,"context_line":"            except n_exc.NetworkInUse:"},{"line_number":512,"context_line":"                LOG.info(_LI(\"HA network %s was still in use.\"),"},{"line_number":513,"context_line":"                         ha_network.network_id)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    def _unbind_ha_router(self, context, router_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_1fe065f9","line":512,"updated":"2015-12-08 08:08:32.000000000","message":"My English tell me that it should be \"HA network %s is still in use.\" here.\n\nBesides, related UT may needs update at [1], according to the actual exception you get.\n\n[1]  https://github.com/openstack/neutron/blob/7a5ebc171f9ff342d7526808b1063b58cc631fec/neutron/tests/unit/db/test_l3_hamode_db.py#L621","commit_id":"1b1c70a8c9ee6314d634c1eebca0775441339b0b"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"88bde89573e5c741c35b0b753d54859ae6848fec","unresolved":false,"context_lines":[{"line_number":509,"context_line":"                LOG.info(_LI(\"HA network %s can not be deleted.\"),"},{"line_number":510,"context_line":"                         ha_network.network_id)"},{"line_number":511,"context_line":"            except n_exc.NetworkInUse:"},{"line_number":512,"context_line":"                LOG.info(_LI(\"HA network %s is still in use.\"),"},{"line_number":513,"context_line":"                         ha_network.network_id)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    def _unbind_ha_router(self, context, router_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_d3d6434e","line":512,"updated":"2015-12-08 14:28:17.000000000","message":"This should be DEBUG level. The operator doesn\u0027t have any use of this information, it\u0027s only potentially useful for developers.","commit_id":"38479267ee49990d3a9ac0fcdce9801e01168e4b"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"145f2fb19b2f714c3e9dc5ae305202abe366442e","unresolved":false,"context_lines":[{"line_number":509,"context_line":"                LOG.info(_LI(\"HA network %s can not be deleted.\"),"},{"line_number":510,"context_line":"                         ha_network.network_id)"},{"line_number":511,"context_line":"            except n_exc.NetworkInUse:"},{"line_number":512,"context_line":"                LOG.info(_LI(\"HA network %s is still in use.\"),"},{"line_number":513,"context_line":"                         ha_network.network_id)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    def _unbind_ha_router(self, context, router_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_b76b431d","line":512,"in_reply_to":"7a740942_d3d6434e","updated":"2015-12-09 01:46:17.000000000","message":"Done","commit_id":"38479267ee49990d3a9ac0fcdce9801e01168e4b"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"731540dad5931585ff6751d4bdeec319557640c8","unresolved":false,"context_lines":[{"line_number":509,"context_line":"                except (n_exc.NetworkNotFound,"},{"line_number":510,"context_line":"                        orm.exc.ObjectDeletedError):"},{"line_number":511,"context_line":"                    LOG.debug(\"HA network %s was already deleted.\","},{"line_number":512,"context_line":"                              ha_network.network_id)"},{"line_number":513,"context_line":"                except sa.exc.InvalidRequestError:"},{"line_number":514,"context_line":"                    LOG.info(_LI(\"HA network %s can not be deleted.\"),"},{"line_number":515,"context_line":"                             ha_network.network_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_f3049f18","line":512,"updated":"2015-12-14 07:11:14.000000000","message":"Exception ObjectDeletedError raised from the log param ha_network.network_id. Next patch will change here.","commit_id":"22d675ad4bc2937e353ef6a806b2a2f1d395bf35"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5aea03808bbc39fa572db37bf05e4d7e600a6a54","unresolved":false,"context_lines":[{"line_number":498,"context_line":"                # in HA network creation. So here put this deleting HA network"},{"line_number":499,"context_line":"                # procedure under \u0027if ha_network\u0027 block."},{"line_number":500,"context_line":"                try:"},{"line_number":501,"context_line":"                    if not self._ha_routers_present(context,"},{"line_number":502,"context_line":"                                                    router_db.tenant_id):"},{"line_number":503,"context_line":"                        self._delete_ha_network(context, ha_network)"},{"line_number":504,"context_line":"                        LOG.info(_LI(\"HA network %(network)s was deleted as \""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_7a44e245","line":501,"updated":"2015-12-14 17:06:24.000000000","message":"Is _ha_routers_present() expected to raise any of these exceptions? If not, it should be outside the try clause.","commit_id":"4843d809668ec15498a117b8b4f9ba064931b6eb"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6f04a8d5b3260136518b64fa0cdcb483930e5da3","unresolved":false,"context_lines":[{"line_number":498,"context_line":"                # in HA network creation. So here put this deleting HA network"},{"line_number":499,"context_line":"                # procedure under \u0027if ha_network\u0027 block."},{"line_number":500,"context_line":"                try:"},{"line_number":501,"context_line":"                    if not self._ha_routers_present(context,"},{"line_number":502,"context_line":"                                                    router_db.tenant_id):"},{"line_number":503,"context_line":"                        self._delete_ha_network(context, ha_network)"},{"line_number":504,"context_line":"                        LOG.info(_LI(\"HA network %(network)s was deleted as \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_a08cd435","line":501,"in_reply_to":"7a740942_7a44e245","updated":"2015-12-18 08:59:05.000000000","message":"Done","commit_id":"4843d809668ec15498a117b8b4f9ba064931b6eb"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5aea03808bbc39fa572db37bf05e4d7e600a6a54","unresolved":false,"context_lines":[{"line_number":501,"context_line":"                    if not self._ha_routers_present(context,"},{"line_number":502,"context_line":"                                                    router_db.tenant_id):"},{"line_number":503,"context_line":"                        self._delete_ha_network(context, ha_network)"},{"line_number":504,"context_line":"                        LOG.info(_LI(\"HA network %(network)s was deleted as \""},{"line_number":505,"context_line":"                                     \"no HA routers are present in tenant \""},{"line_number":506,"context_line":"                                     \"%(tenant)s.\"),"},{"line_number":507,"context_line":"                                 {\u0027network\u0027: ha_network.network_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_bac1ea81","line":504,"updated":"2015-12-14 17:06:24.000000000","message":"Nit: This log statement could go in the else block of the try clause. (This is an opinion on style and readability, so feel free to ignore.)","commit_id":"4843d809668ec15498a117b8b4f9ba064931b6eb"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6f04a8d5b3260136518b64fa0cdcb483930e5da3","unresolved":false,"context_lines":[{"line_number":501,"context_line":"                    if not self._ha_routers_present(context,"},{"line_number":502,"context_line":"                                                    router_db.tenant_id):"},{"line_number":503,"context_line":"                        self._delete_ha_network(context, ha_network)"},{"line_number":504,"context_line":"                        LOG.info(_LI(\"HA network %(network)s was deleted as \""},{"line_number":505,"context_line":"                                     \"no HA routers are present in tenant \""},{"line_number":506,"context_line":"                                     \"%(tenant)s.\"),"},{"line_number":507,"context_line":"                                 {\u0027network\u0027: ha_network.network_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_c3048ac1","line":504,"in_reply_to":"7a740942_bac1ea81","updated":"2015-12-18 08:59:05.000000000","message":"Done","commit_id":"4843d809668ec15498a117b8b4f9ba064931b6eb"}],"neutron/tests/unit/db/test_l3_hamode_db.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"d305de109ed2090049fdf843e09ed7277f0492d5","unresolved":false,"context_lines":[{"line_number":635,"context_line":"            self.assertIn(\u0027HA network tenant %s\u0027 % router1[\u0027tenant_id\u0027],"},{"line_number":636,"context_line":"                          nets_after)"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def test_ha_network_is_not_deleted_if_network_in_use(self):"},{"line_number":639,"context_line":"        router1 \u003d self._create_router()"},{"line_number":640,"context_line":"        nets_before \u003d [net[\u0027name\u0027] for net in"},{"line_number":641,"context_line":"                       self.core_plugin.get_networks(self.admin_ctx)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_0a7b2529","line":638,"updated":"2015-12-08 16:22:34.000000000","message":"I think we should try to avoid duplication here, as this test is different from the one above only with exception that is raised. So please try to avoid it, make a help function at list and pass exception type there.","commit_id":"38479267ee49990d3a9ac0fcdce9801e01168e4b"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"145f2fb19b2f714c3e9dc5ae305202abe366442e","unresolved":false,"context_lines":[{"line_number":635,"context_line":"            self.assertIn(\u0027HA network tenant %s\u0027 % router1[\u0027tenant_id\u0027],"},{"line_number":636,"context_line":"                          nets_after)"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def test_ha_network_is_not_deleted_if_network_in_use(self):"},{"line_number":639,"context_line":"        router1 \u003d self._create_router()"},{"line_number":640,"context_line":"        nets_before \u003d [net[\u0027name\u0027] for net in"},{"line_number":641,"context_line":"                       self.core_plugin.get_networks(self.admin_ctx)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_ba66caea","line":638,"in_reply_to":"7a740942_0a7b2529","updated":"2015-12-09 01:46:17.000000000","message":"OK, done.","commit_id":"38479267ee49990d3a9ac0fcdce9801e01168e4b"}]}
