)]}'
{"requirements.txt":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"19b81b675981053738a67055243336ed1ea481a2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"oslo.service\u003e\u003d0.12.0 # Apache-2.0"},{"line_number":40,"context_line":"oslo.utils\u003e\u003d2.8.0 # Apache-2.0"},{"line_number":41,"context_line":"oslo.versionedobjects\u003e\u003d0.13.0"},{"line_number":42,"context_line":"ovs\u003e\u003d2.4.0 # Apache-2.0"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"python-novaclient!\u003d2.33.0,\u003e\u003d2.29.0"}],"source_content_type":"text/plain","patch_set":1,"id":"7a740942_9d59ac37","line":42,"updated":"2015-12-08 13:48:11.000000000","message":"two issues here:\n1. this should be the same that is https://github.com/openstack/requirements/blob/master/global-requirements.txt#L115\n2. why do we need this dependency here - say for example i am not using the ovs.\nConsider adding it to the test-requirements","commit_id":"66b9b952adccd5d5e4521d06fcf79b74e928042b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"49d027d7d5175080fce3f6369c57185e6d17e824","unresolved":false,"context_lines":[{"line_number":39,"context_line":"oslo.service\u003e\u003d0.12.0 # Apache-2.0"},{"line_number":40,"context_line":"oslo.utils\u003e\u003d2.8.0 # Apache-2.0"},{"line_number":41,"context_line":"oslo.versionedobjects\u003e\u003d0.13.0"},{"line_number":42,"context_line":"ovs\u003e\u003d2.4.0 # Apache-2.0"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"python-novaclient!\u003d2.33.0,\u003e\u003d2.29.0"}],"source_content_type":"text/plain","patch_set":1,"id":"da6ed579_eec0ae7e","line":42,"in_reply_to":"7a740942_3d509f0a","updated":"2016-01-13 03:53:45.000000000","message":"If it\u0027s in global requirements, then we should get it matched here and let the bot do the work for us. As for the optional dependency. We have plenty of optional deps here, like ryu.","commit_id":"66b9b952adccd5d5e4521d06fcf79b74e928042b"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"fc997ac00681deb60cb0e458637ea35d16d45246","unresolved":false,"context_lines":[{"line_number":39,"context_line":"oslo.service\u003e\u003d0.12.0 # Apache-2.0"},{"line_number":40,"context_line":"oslo.utils\u003e\u003d2.8.0 # Apache-2.0"},{"line_number":41,"context_line":"oslo.versionedobjects\u003e\u003d0.13.0"},{"line_number":42,"context_line":"ovs\u003e\u003d2.4.0 # Apache-2.0"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"python-novaclient!\u003d2.33.0,\u003e\u003d2.29.0"}],"source_content_type":"text/plain","patch_set":1,"id":"7a740942_f17fb7dd","line":42,"in_reply_to":"7a740942_9d59ac37","updated":"2015-12-08 15:02:16.000000000","message":"It doesn\u0027t belong in test-requirements because it isn\u0027t testing-specific. This is a requirement for code that ships in this tree, so the requirement goes here. It is the job of packagers to break neutron up into multiple pieces with minimized requirements.","commit_id":"66b9b952adccd5d5e4521d06fcf79b74e928042b"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"eb89bb7d3b8055318eb250ae0102f7ca674b2abe","unresolved":false,"context_lines":[{"line_number":39,"context_line":"oslo.service\u003e\u003d0.12.0 # Apache-2.0"},{"line_number":40,"context_line":"oslo.utils\u003e\u003d2.8.0 # Apache-2.0"},{"line_number":41,"context_line":"oslo.versionedobjects\u003e\u003d0.13.0"},{"line_number":42,"context_line":"ovs\u003e\u003d2.4.0 # Apache-2.0"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"python-novaclient!\u003d2.33.0,\u003e\u003d2.29.0"}],"source_content_type":"text/plain","patch_set":1,"id":"7a740942_3d509f0a","line":42,"in_reply_to":"7a740942_a4ef9d1c","updated":"2015-12-08 21:04:44.000000000","message":"That seems very odd to me. The whole point of requirements.txt is to describe all of the requirements for the entire python package when installing via pip. There is no support for \"optional\" requirements.  That is what packaging is for. Who, in production, installs Neutron via pip?\n\nOne could make the argument that the OVS stuff doesn\u0027t belong in the tree at all, I guess. But if it is there, then I very firmly believe that requirements.txt is where the dependcy for it belongs.","commit_id":"66b9b952adccd5d5e4521d06fcf79b74e928042b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"41f9c7d4b52270d342b2196dd330449045d6606f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"oslo.service\u003e\u003d0.12.0 # Apache-2.0"},{"line_number":40,"context_line":"oslo.utils\u003e\u003d2.8.0 # Apache-2.0"},{"line_number":41,"context_line":"oslo.versionedobjects\u003e\u003d0.13.0"},{"line_number":42,"context_line":"ovs\u003e\u003d2.4.0 # Apache-2.0"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"python-novaclient!\u003d2.33.0,\u003e\u003d2.29.0"}],"source_content_type":"text/plain","patch_set":1,"id":"7a740942_a4ef9d1c","line":42,"in_reply_to":"7a740942_f17fb7dd","updated":"2015-12-08 19:03:23.000000000","message":"i do not agree with that. the ovs should not be part of these requirements","commit_id":"66b9b952adccd5d5e4521d06fcf79b74e928042b"}]}
