)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"change_message_id":"85746ec924fb61f2b44c13011684b510da61a79f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add systemd notification after reporting initial state"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a notification for systemd after the agent has reported"},{"line_number":10,"context_line":"its initials tate to the Neutron server. This enables configuring"},{"line_number":11,"context_line":"orderly startup of services that are dependent on the server having a"},{"line_number":12,"context_line":"healthy openvswitch agent running."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_a3430cae","line":10,"updated":"2015-12-08 22:04:35.000000000","message":"Initial state*","commit_id":"be7977b5eb6b39d6c9085272cb3ef861f03d4cef"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e7670f9b0c46508619ec2ab761f1015e8fc69ef0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds a notification for systemd after the agent has reported"},{"line_number":10,"context_line":"its initial state to the Neutron server. This enables configuring"},{"line_number":11,"context_line":"orderly startup of services that are dependent on the server having a"},{"line_number":12,"context_line":"healthy openvswitch agent running."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8d08f1b2ae196b1e48f9d91e06966687c0a8bd43"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_f4a1cc94","line":12,"updated":"2015-12-08 23:10:56.000000000","message":"would you want this to be backported? If so, this would benefit from a bug report.","commit_id":"bcaa85c09da7359b361f4c0deb17463f0b5e9706"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"fd16c1a3d537539bc99b0bcdb27f8c72bbfdf0bc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds a notification for systemd after the agent has reported"},{"line_number":10,"context_line":"its initial state to the Neutron server. This enables configuring"},{"line_number":11,"context_line":"orderly startup of services that are dependent on the server having a"},{"line_number":12,"context_line":"healthy openvswitch agent running."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8d08f1b2ae196b1e48f9d91e06966687c0a8bd43"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_ba601502","line":12,"in_reply_to":"7a740942_086466b6","updated":"2015-12-14 14:27:51.000000000","message":"Other services use the oslo service framework to launch services, in that case we may need to fix oslo service itself, because it\u0027s launcher will notify systemd rightaway (as the new process goes up), regardless of what we intend to do (waiting for first heartbeat)","commit_id":"bcaa85c09da7359b361f4c0deb17463f0b5e9706"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"001e4f587f7dd9afccd74658fb31eb2a2f78958b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds a notification for systemd after the agent has reported"},{"line_number":10,"context_line":"its initial state to the Neutron server. This enables configuring"},{"line_number":11,"context_line":"orderly startup of services that are dependent on the server having a"},{"line_number":12,"context_line":"healthy openvswitch agent running."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8d08f1b2ae196b1e48f9d91e06966687c0a8bd43"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_086466b6","line":12,"in_reply_to":"7a740942_259e2b63","updated":"2015-12-09 09:40:46.000000000","message":"yes, this should be generic for all agents","commit_id":"bcaa85c09da7359b361f4c0deb17463f0b5e9706"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"55dc26c03a4a35ee59de3d077449db37a64033ac","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds a notification for systemd after the agent has reported"},{"line_number":10,"context_line":"its initial state to the Neutron server. This enables configuring"},{"line_number":11,"context_line":"orderly startup of services that are dependent on the server having a"},{"line_number":12,"context_line":"healthy openvswitch agent running."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8d08f1b2ae196b1e48f9d91e06966687c0a8bd43"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_259e2b63","line":12,"in_reply_to":"7a740942_ef11f552","updated":"2015-12-09 09:27:31.000000000","message":"Maybe the bug should be generic and include all agents, not just ovs. I feel that we\u0027ll need oslo patches for that.","commit_id":"bcaa85c09da7359b361f4c0deb17463f0b5e9706"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"62a363d37603ed50bead3f3fcc300f7fa04404a8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds a notification for systemd after the agent has reported"},{"line_number":10,"context_line":"its initial state to the Neutron server. This enables configuring"},{"line_number":11,"context_line":"orderly startup of services that are dependent on the server having a"},{"line_number":12,"context_line":"healthy openvswitch agent running."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8d08f1b2ae196b1e48f9d91e06966687c0a8bd43"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_ef11f552","line":12,"in_reply_to":"7a740942_f4a1cc94","updated":"2015-12-08 23:20:33.000000000","message":"Good point. Will fix.","commit_id":"bcaa85c09da7359b361f4c0deb17463f0b5e9706"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"90560965ea472cbdb0803986131806951f89c4bc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"orderly startup of services that are dependent on the server having a"},{"line_number":12,"context_line":"healthy openvswitch agent running."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related-Bug: #1525901"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I8d08f1b2ae196b1e48f9d91e06966687c0a8bd43"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a740942_bacc956a","line":14,"updated":"2015-12-14 14:23:46.000000000","message":"related or resolves?","commit_id":"1ec5f4d39b10a3dcd9e6ff5e9c2f32a4cf642086"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fcc8195bf206fa8d599f85b238c0e286aef439d0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"orderly startup of services that are dependent on the server having a"},{"line_number":12,"context_line":"healthy openvswitch agent running."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related-Bug: #1525901"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I8d08f1b2ae196b1e48f9d91e06966687c0a8bd43"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a740942_9db75320","line":14,"in_reply_to":"7a740942_bacc956a","updated":"2015-12-14 14:34:10.000000000","message":"I believe other agents will need to be fixed as well.","commit_id":"1ec5f4d39b10a3dcd9e6ff5e9c2f32a4cf642086"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"451ab2033eb0c624f61705e07f9de42e1095c78d","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                LOG.info(_LI(\u0027Agent has just been revived. \u0027"},{"line_number":318,"context_line":"                             \u0027Doing a full sync.\u0027))"},{"line_number":319,"context_line":"                self.fullsync \u003d True"},{"line_number":320,"context_line":"            self.use_call \u003d False"},{"line_number":321,"context_line":"            self.agent_state.pop(\u0027start_flag\u0027, None)"},{"line_number":322,"context_line":"        except Exception:"},{"line_number":323,"context_line":"            LOG.exception(_LE(\"Failed reporting state!\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_d47ff012","side":"PARENT","line":320,"updated":"2015-12-08 23:09:40.000000000","message":"are you sure you wanted to get rid of this line?","commit_id":"7a5ebc171f9ff342d7526808b1063b58cc631fec"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"55dc26c03a4a35ee59de3d077449db37a64033ac","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                LOG.info(_LI(\u0027Agent has just been revived. \u0027"},{"line_number":318,"context_line":"                             \u0027Doing a full sync.\u0027))"},{"line_number":319,"context_line":"                self.fullsync \u003d True"},{"line_number":320,"context_line":"            self.use_call \u003d False"},{"line_number":321,"context_line":"            self.agent_state.pop(\u0027start_flag\u0027, None)"},{"line_number":322,"context_line":"        except Exception:"},{"line_number":323,"context_line":"            LOG.exception(_LE(\"Failed reporting state!\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_451497e7","side":"PARENT","line":320,"in_reply_to":"7a740942_0f080127","updated":"2015-12-09 09:27:31.000000000","message":"Removal was missed in https://review.openstack.org/#/c/232661/15/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py","commit_id":"7a5ebc171f9ff342d7526808b1063b58cc631fec"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"62a363d37603ed50bead3f3fcc300f7fa04404a8","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                LOG.info(_LI(\u0027Agent has just been revived. \u0027"},{"line_number":318,"context_line":"                             \u0027Doing a full sync.\u0027))"},{"line_number":319,"context_line":"                self.fullsync \u003d True"},{"line_number":320,"context_line":"            self.use_call \u003d False"},{"line_number":321,"context_line":"            self.agent_state.pop(\u0027start_flag\u0027, None)"},{"line_number":322,"context_line":"        except Exception:"},{"line_number":323,"context_line":"            LOG.exception(_LE(\"Failed reporting state!\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_0f080127","side":"PARENT","line":320,"in_reply_to":"7a740942_d47ff012","updated":"2015-12-08 23:20:33.000000000","message":"AFAICT, the use_call used to be set to True in __init__ to be passed as the third argument to the above report_state rpc call on the first time it was called, and then set to False. The code now seems to be hard-code to True in the third argument and I don\u0027t see another reference to this data member anywhere else.","commit_id":"7a5ebc171f9ff342d7526808b1063b58cc631fec"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"001e4f587f7dd9afccd74658fb31eb2a2f78958b","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            if self.agent_state.pop(\u0027start_flag\u0027, None):"},{"line_number":323,"context_line":"                # On initial start, we notify systemd after initialization"},{"line_number":324,"context_line":"                # is complete."},{"line_number":325,"context_line":"                systemd.notify_once()"},{"line_number":326,"context_line":"        except Exception:"},{"line_number":327,"context_line":"            LOG.exception(_LE(\"Failed reporting state!\"))"},{"line_number":328,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_28f042c8","line":325,"updated":"2015-12-09 09:40:46.000000000","message":"why is this done in the agent _report state method? why not just when the service starts then it will be generic","commit_id":"bcaa85c09da7359b361f4c0deb17463f0b5e9706"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2c6401df908907f1c2d230d974c8699971cb55c6","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            if self.agent_state.pop(\u0027start_flag\u0027, None):"},{"line_number":323,"context_line":"                # On initial start, we notify systemd after initialization"},{"line_number":324,"context_line":"                # is complete."},{"line_number":325,"context_line":"                systemd.notify_once()"},{"line_number":326,"context_line":"        except Exception:"},{"line_number":327,"context_line":"            LOG.exception(_LE(\"Failed reporting state!\"))"},{"line_number":328,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_08954631","line":325,"in_reply_to":"7a740942_28f042c8","updated":"2015-12-09 09:42:19.000000000","message":"Define when you consider service started","commit_id":"bcaa85c09da7359b361f4c0deb17463f0b5e9706"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"90560965ea472cbdb0803986131806951f89c4bc","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                LOG.info(_LI(\u0027Agent has just been revived. \u0027"},{"line_number":318,"context_line":"                             \u0027Doing a full sync.\u0027))"},{"line_number":319,"context_line":"                self.fullsync \u003d True"},{"line_number":320,"context_line":"            self.use_call \u003d False"},{"line_number":321,"context_line":"            self.agent_state.pop(\u0027start_flag\u0027, None)"},{"line_number":322,"context_line":"        except Exception:"},{"line_number":323,"context_line":"            LOG.exception(_LE(\"Failed reporting state!\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_1a360951","side":"PARENT","line":320,"updated":"2015-12-14 14:23:46.000000000","message":"Why do we move way from stopping \"call\" heartbeats after fist one?","commit_id":"7a5ebc171f9ff342d7526808b1063b58cc631fec"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"3dcb2c643a8f45758ecee6029a4043fe68603943","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                LOG.info(_LI(\u0027Agent has just been revived. \u0027"},{"line_number":318,"context_line":"                             \u0027Doing a full sync.\u0027))"},{"line_number":319,"context_line":"                self.fullsync \u003d True"},{"line_number":320,"context_line":"            self.use_call \u003d False"},{"line_number":321,"context_line":"            self.agent_state.pop(\u0027start_flag\u0027, None)"},{"line_number":322,"context_line":"        except Exception:"},{"line_number":323,"context_line":"            LOG.exception(_LE(\"Failed reporting state!\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_1ad289d1","side":"PARENT","line":320,"in_reply_to":"7a740942_1a360951","updated":"2015-12-14 14:24:42.000000000","message":"May be use call is unused now? :)","commit_id":"7a5ebc171f9ff342d7526808b1063b58cc631fec"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fcc8195bf206fa8d599f85b238c0e286aef439d0","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                LOG.info(_LI(\u0027Agent has just been revived. \u0027"},{"line_number":318,"context_line":"                             \u0027Doing a full sync.\u0027))"},{"line_number":319,"context_line":"                self.fullsync \u003d True"},{"line_number":320,"context_line":"            self.use_call \u003d False"},{"line_number":321,"context_line":"            self.agent_state.pop(\u0027start_flag\u0027, None)"},{"line_number":322,"context_line":"        except Exception:"},{"line_number":323,"context_line":"            LOG.exception(_LE(\"Failed reporting state!\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_bde9efe7","side":"PARENT","line":320,"in_reply_to":"7a740942_1ad289d1","updated":"2015-12-14 14:34:10.000000000","message":"See comments in PS2 :)","commit_id":"7a5ebc171f9ff342d7526808b1063b58cc631fec"}]}
