)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"5288199e353ce8804178dacb836b6a15b738745a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bo Chi \u003cshcbo@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-10 10:09:26 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check or extra `0`s in ip addr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If use ip addr that has extra `0`s like 10.0.0.011, it will be stored"},{"line_number":10,"context_line":"as a wrong value. This patch will treat such addrs as invalid and give"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a740942_144beab1","line":7,"updated":"2015-12-10 07:30:44.000000000","message":"or ?  or  \n\nfor?","commit_id":"861615009a8ba3a9f5a6000cb94a4333d578205b"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"f45ba7f4f81dbf64358d6f4d190b5337badef71f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bo Chi \u003cshcbo@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-10 10:09:26 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check or extra `0`s in ip addr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If use ip addr that has extra `0`s like 10.0.0.011, it will be stored"},{"line_number":10,"context_line":"as a wrong value. This patch will treat such addrs as invalid and give"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a740942_2ff9efc8","line":7,"in_reply_to":"7a740942_144beab1","updated":"2015-12-10 07:34:27.000000000","message":"Done","commit_id":"861615009a8ba3a9f5a6000cb94a4333d578205b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"5288199e353ce8804178dacb836b6a15b738745a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If use ip addr that has extra `0`s like 10.0.0.011, it will be stored"},{"line_number":10,"context_line":"as a wrong value. This patch will treat such addrs as invalid and give"},{"line_number":11,"context_line":"a recommanded value."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3163ba13468c47d385585221d2167fbe31d24010"},{"line_number":14,"context_line":"Closes-Bug: #1524220"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a740942_f4e41ead","line":11,"updated":"2015-12-10 07:30:44.000000000","message":"recommended","commit_id":"861615009a8ba3a9f5a6000cb94a4333d578205b"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"f45ba7f4f81dbf64358d6f4d190b5337badef71f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If use ip addr that has extra `0`s like 10.0.0.011, it will be stored"},{"line_number":10,"context_line":"as a wrong value. This patch will treat such addrs as invalid and give"},{"line_number":11,"context_line":"a recommanded value."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3163ba13468c47d385585221d2167fbe31d24010"},{"line_number":14,"context_line":"Closes-Bug: #1524220"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a740942_4ff6bbd8","line":11,"in_reply_to":"7a740942_f4e41ead","updated":"2015-12-10 07:34:27.000000000","message":"Done","commit_id":"861615009a8ba3a9f5a6000cb94a4333d578205b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"db4a736484c895574691dee3f0875263abe99757","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bo Chi \u003cshcbo@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-11 08:37:34 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check for preceding `0`s in IPv4 addr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If use IPv4 addr that has preceding `0`s like 10.0.0.011, it will be"},{"line_number":10,"context_line":"stored as a wrong value. This patch will treat such addr as invalid"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a710552_c2ce30b4","line":7,"updated":"2015-12-14 19:46:37.000000000","message":"preceding -\u003e leading","commit_id":"6ee14dc7aa956d30788aff46783113657c4bf328"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"3c82b54b5426c9e7df945089930ca31661612fa2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bo Chi \u003cshcbo@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-11 08:37:34 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check for preceding `0`s in IPv4 addr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If use IPv4 addr that has preceding `0`s like 10.0.0.011, it will be"},{"line_number":10,"context_line":"stored as a wrong value. This patch will treat such addr as invalid"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a710552_78935afb","line":7,"in_reply_to":"5a710552_c2ce30b4","updated":"2015-12-15 08:06:23.000000000","message":"Done","commit_id":"6ee14dc7aa956d30788aff46783113657c4bf328"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"db4a736484c895574691dee3f0875263abe99757","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If use IPv4 addr that has preceding `0`s like 10.0.0.011, it will be"},{"line_number":10,"context_line":"stored as a wrong value. This patch will treat such addr as invalid"},{"line_number":11,"context_line":"and give a recommended value."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"},{"line_number":14,"context_line":"Change-Id: I3163ba13468c47d385585221d2167fbe31d24010"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a710552_62e73c13","line":11,"updated":"2015-12-14 19:46:37.000000000","message":"Suggested rewording (if I understand the issue correctly):\n\nIn IP addresses a leading \u00270\u0027 may be interpreted as an octal number, e.g. 011 octal is 9 decimal. Users who are not familiar with or not expecting octal interpretation will not get the address they intended. Since there is no standard around this we reject leading \u00270\u0027s to avoid ambiguity.","commit_id":"6ee14dc7aa956d30788aff46783113657c4bf328"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"3c82b54b5426c9e7df945089930ca31661612fa2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If use IPv4 addr that has preceding `0`s like 10.0.0.011, it will be"},{"line_number":10,"context_line":"stored as a wrong value. This patch will treat such addr as invalid"},{"line_number":11,"context_line":"and give a recommended value."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"},{"line_number":14,"context_line":"Change-Id: I3163ba13468c47d385585221d2167fbe31d24010"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a710552_989086ee","line":11,"in_reply_to":"5a710552_62e73c13","updated":"2015-12-15 08:06:23.000000000","message":"Done","commit_id":"6ee14dc7aa956d30788aff46783113657c4bf328"}],"neutron/api/v2/attributes.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b175ef7c341742679df84559a1ab6b36438a9812","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    msg \u003d None"},{"line_number":208,"context_line":"    try:"},{"line_number":209,"context_line":"        ip \u003d netaddr.IPAddress(_validate_no_whitespace(data),"},{"line_number":210,"context_line":"                         flags\u003dnetaddr.core.ZEROFILL)"},{"line_number":211,"context_line":"        # The followings are quick checks for IPv6 (has \u0027:\u0027) and"},{"line_number":212,"context_line":"        # IPv4.  (has 3 periods like \u0027xx.xx.xx.xx\u0027)"},{"line_number":213,"context_line":"        # It also checks extra \u00270\u0027s in ipv4 addr, such as \u002710.0.0.011\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_3a8b6120","line":210,"updated":"2015-12-10 12:11:04.000000000","message":"the indentation here is dodgy\n\nit may be worthwhile adding a comment that this is only applicable to IPv4.\n\nCan you please add ina  test for IPv6 showing that it works when there are zeros","commit_id":"8c57bdd37f7716e4b917137017a0679be842032b"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"ea564bc068160da85408fe01f1a56583624bbecc","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    msg \u003d None"},{"line_number":208,"context_line":"    try:"},{"line_number":209,"context_line":"        ip \u003d netaddr.IPAddress(_validate_no_whitespace(data),"},{"line_number":210,"context_line":"                         flags\u003dnetaddr.core.ZEROFILL)"},{"line_number":211,"context_line":"        # The followings are quick checks for IPv6 (has \u0027:\u0027) and"},{"line_number":212,"context_line":"        # IPv4.  (has 3 periods like \u0027xx.xx.xx.xx\u0027)"},{"line_number":213,"context_line":"        # It also checks extra \u00270\u0027s in ipv4 addr, such as \u002710.0.0.011\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_5b5ba5f6","line":210,"in_reply_to":"7a740942_3a8b6120","updated":"2015-12-11 03:23:16.000000000","message":"Done","commit_id":"8c57bdd37f7716e4b917137017a0679be842032b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b175ef7c341742679df84559a1ab6b36438a9812","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        #   \u003e\u003e\u003e"},{"line_number":225,"context_line":"        if \u0027:\u0027 not in data and data.count(\u0027.\u0027) !\u003d 3:"},{"line_number":226,"context_line":"            raise ValueError()"},{"line_number":227,"context_line":"        if (ip.version \u003d\u003d 4 and str(ip) !\u003d data):"},{"line_number":228,"context_line":"            msg \u003d _(\"\u0027%(data)s\u0027 isn\u0027t a recognized IP address,\""},{"line_number":229,"context_line":"                    \" \u0027%(ip)s\u0027 is recommended\") % {\"data\": data, \"ip\": ip}"},{"line_number":230,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_da981d6d","line":227,"updated":"2015-12-10 12:11:04.000000000","message":"you do not need the brackets here","commit_id":"8c57bdd37f7716e4b917137017a0679be842032b"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"ea564bc068160da85408fe01f1a56583624bbecc","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        #   \u003e\u003e\u003e"},{"line_number":225,"context_line":"        if \u0027:\u0027 not in data and data.count(\u0027.\u0027) !\u003d 3:"},{"line_number":226,"context_line":"            raise ValueError()"},{"line_number":227,"context_line":"        if (ip.version \u003d\u003d 4 and str(ip) !\u003d data):"},{"line_number":228,"context_line":"            msg \u003d _(\"\u0027%(data)s\u0027 isn\u0027t a recognized IP address,\""},{"line_number":229,"context_line":"                    \" \u0027%(ip)s\u0027 is recommended\") % {\"data\": data, \"ip\": ip}"},{"line_number":230,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_fb72917b","line":227,"in_reply_to":"7a740942_da981d6d","updated":"2015-12-11 03:23:16.000000000","message":"Done","commit_id":"8c57bdd37f7716e4b917137017a0679be842032b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b175ef7c341742679df84559a1ab6b36438a9812","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            raise ValueError()"},{"line_number":227,"context_line":"        if (ip.version \u003d\u003d 4 and str(ip) !\u003d data):"},{"line_number":228,"context_line":"            msg \u003d _(\"\u0027%(data)s\u0027 isn\u0027t a recognized IP address,\""},{"line_number":229,"context_line":"                    \" \u0027%(ip)s\u0027 is recommended\") % {\"data\": data, \"ip\": ip}"},{"line_number":230,"context_line":"    except Exception:"},{"line_number":231,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid IP address\") % data"},{"line_number":232,"context_line":"    if msg:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_1aba25e2","line":229,"updated":"2015-12-10 12:11:04.000000000","message":"please put the space at the end of the sentence","commit_id":"8c57bdd37f7716e4b917137017a0679be842032b"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"ea564bc068160da85408fe01f1a56583624bbecc","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            raise ValueError()"},{"line_number":227,"context_line":"        if (ip.version \u003d\u003d 4 and str(ip) !\u003d data):"},{"line_number":228,"context_line":"            msg \u003d _(\"\u0027%(data)s\u0027 isn\u0027t a recognized IP address,\""},{"line_number":229,"context_line":"                    \" \u0027%(ip)s\u0027 is recommended\") % {\"data\": data, \"ip\": ip}"},{"line_number":230,"context_line":"    except Exception:"},{"line_number":231,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid IP address\") % data"},{"line_number":232,"context_line":"    if msg:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_1b6e7d96","line":229,"in_reply_to":"7a740942_1aba25e2","updated":"2015-12-11 03:23:16.000000000","message":"Done","commit_id":"8c57bdd37f7716e4b917137017a0679be842032b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b175ef7c341742679df84559a1ab6b36438a9812","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid IP address\") % data"},{"line_number":232,"context_line":"    if msg:"},{"line_number":233,"context_line":"        LOG.debug(msg)"},{"line_number":234,"context_line":"    return msg"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def _validate_ip_pools(data, valid_values\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_bac5113e","line":234,"updated":"2015-12-10 12:11:04.000000000","message":"why the change here?","commit_id":"8c57bdd37f7716e4b917137017a0679be842032b"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"ea564bc068160da85408fe01f1a56583624bbecc","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid IP address\") % data"},{"line_number":232,"context_line":"    if msg:"},{"line_number":233,"context_line":"        LOG.debug(msg)"},{"line_number":234,"context_line":"    return msg"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def _validate_ip_pools(data, valid_values\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_3bb499f0","line":234,"in_reply_to":"7a740942_bac5113e","updated":"2015-12-11 03:23:16.000000000","message":"it doesn\u0027t raise an exception if there\u0027re preceding zeros, in order to print different msg, so I moved Log.debug out of `except` block.\n\nIt\u0027s similar to _validate_subnet","commit_id":"8c57bdd37f7716e4b917137017a0679be842032b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"db4a736484c895574691dee3f0875263abe99757","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                               flags\u003dnetaddr.core.ZEROFILL)"},{"line_number":213,"context_line":"        # The followings are quick checks for IPv6 (has \u0027:\u0027) and"},{"line_number":214,"context_line":"        # IPv4.  (has 3 periods like \u0027xx.xx.xx.xx\u0027)"},{"line_number":215,"context_line":"        # It also checks extra \u00270\u0027s in IPv4 addr, such as \u002710.0.0.011\u0027"},{"line_number":216,"context_line":"        # NOTE(yamamoto): netaddr uses libraries provided by the underlying"},{"line_number":217,"context_line":"        # platform to convert addresses.  For example, inet_aton(3)."},{"line_number":218,"context_line":"        # Some platforms, including NetBSD and OS X, have inet_aton"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_dca059a8","line":215,"updated":"2015-12-14 19:46:37.000000000","message":"extra -\u003e leading\n\nPlease add the following:\n\n # A leading \u00270\u0027 may be interpreted as an octal number,\n # e.g. 011 octal is 9 decimal. Since there is no standard\n # around this we reject leading \u00270\u0027s to avoid ambiguity.","commit_id":"6ee14dc7aa956d30788aff46783113657c4bf328"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"7f08e03aa4624b18f4a6882a50d6b2e49c9aefe3","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                               flags\u003dnetaddr.core.ZEROFILL)"},{"line_number":213,"context_line":"        # The followings are quick checks for IPv6 (has \u0027:\u0027) and"},{"line_number":214,"context_line":"        # IPv4.  (has 3 periods like \u0027xx.xx.xx.xx\u0027)"},{"line_number":215,"context_line":"        # It also checks extra \u00270\u0027s in IPv4 addr, such as \u002710.0.0.011\u0027"},{"line_number":216,"context_line":"        # NOTE(yamamoto): netaddr uses libraries provided by the underlying"},{"line_number":217,"context_line":"        # platform to convert addresses.  For example, inet_aton(3)."},{"line_number":218,"context_line":"        # Some platforms, including NetBSD and OS X, have inet_aton"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_dacb6671","line":215,"in_reply_to":"5a710552_dca059a8","updated":"2015-12-15 03:48:27.000000000","message":"+1","commit_id":"6ee14dc7aa956d30788aff46783113657c4bf328"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"3c82b54b5426c9e7df945089930ca31661612fa2","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                               flags\u003dnetaddr.core.ZEROFILL)"},{"line_number":213,"context_line":"        # The followings are quick checks for IPv6 (has \u0027:\u0027) and"},{"line_number":214,"context_line":"        # IPv4.  (has 3 periods like \u0027xx.xx.xx.xx\u0027)"},{"line_number":215,"context_line":"        # It also checks extra \u00270\u0027s in IPv4 addr, such as \u002710.0.0.011\u0027"},{"line_number":216,"context_line":"        # NOTE(yamamoto): netaddr uses libraries provided by the underlying"},{"line_number":217,"context_line":"        # platform to convert addresses.  For example, inet_aton(3)."},{"line_number":218,"context_line":"        # Some platforms, including NetBSD and OS X, have inet_aton"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_18401656","line":215,"in_reply_to":"5a710552_dca059a8","updated":"2015-12-15 08:06:23.000000000","message":"Done","commit_id":"6ee14dc7aa956d30788aff46783113657c4bf328"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"db4a736484c895574691dee3f0875263abe99757","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        if \u0027:\u0027 not in data and data.count(\u0027.\u0027) !\u003d 3:"},{"line_number":228,"context_line":"            raise ValueError()"},{"line_number":229,"context_line":"        if ip.version \u003d\u003d 4 and str(ip) !\u003d data:"},{"line_number":230,"context_line":"            msg \u003d _(\"\u0027%(data)s\u0027 isn\u0027t a recognized IP address, \""},{"line_number":231,"context_line":"                    \"\u0027%(ip)s\u0027 is recommended\") % {\"data\": data, \"ip\": ip}"},{"line_number":232,"context_line":"    except Exception:"},{"line_number":233,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid IP address\") % data"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_76c4e191","line":230,"updated":"2015-12-14 19:46:37.000000000","message":"Nit: maybe \"accepted\" is better than \"recognized\" here?","commit_id":"6ee14dc7aa956d30788aff46783113657c4bf328"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"3c82b54b5426c9e7df945089930ca31661612fa2","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        if \u0027:\u0027 not in data and data.count(\u0027.\u0027) !\u003d 3:"},{"line_number":228,"context_line":"            raise ValueError()"},{"line_number":229,"context_line":"        if ip.version \u003d\u003d 4 and str(ip) !\u003d data:"},{"line_number":230,"context_line":"            msg \u003d _(\"\u0027%(data)s\u0027 isn\u0027t a recognized IP address, \""},{"line_number":231,"context_line":"                    \"\u0027%(ip)s\u0027 is recommended\") % {\"data\": data, \"ip\": ip}"},{"line_number":232,"context_line":"    except Exception:"},{"line_number":233,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid IP address\") % data"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_b82542c3","line":230,"in_reply_to":"5a710552_76c4e191","updated":"2015-12-15 08:06:23.000000000","message":"Done","commit_id":"6ee14dc7aa956d30788aff46783113657c4bf328"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"603d7fe0a2d50b9b6c66d67d08290983ef885d17","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        if \u0027:\u0027 not in data and data.count(\u0027.\u0027) !\u003d 3:"},{"line_number":227,"context_line":"            raise ValueError()"},{"line_number":228,"context_line":"        # A leading \u00270\u0027 in IPv4 address may be interpreted as an octal number,"},{"line_number":229,"context_line":"        # e.g. 011 octal is 9 decimal. Since there is no standard around this,"},{"line_number":230,"context_line":"        # we reject leading \u00270\u0027s to avoid ambiguity."},{"line_number":231,"context_line":"        if ip.version \u003d\u003d 4 and str(ip) !\u003d data:"},{"line_number":232,"context_line":"            msg \u003d _(\"\u0027%(data)s\u0027 isn\u0027t a accepted IP address, \""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a710552_fd740ed0","line":229,"updated":"2015-12-15 10:27:46.000000000","message":"no standard around \u003d\u003e this does not make sense. Can you please consider:\nno standard work around for","commit_id":"c4a4f053e87a3e7b1e5f36c12547ca5f63c614d6"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"ae3c276e9189b55ffb8b68be9ba2d401a130adce","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        if \u0027:\u0027 not in data and data.count(\u0027.\u0027) !\u003d 3:"},{"line_number":227,"context_line":"            raise ValueError()"},{"line_number":228,"context_line":"        # A leading \u00270\u0027 in IPv4 address may be interpreted as an octal number,"},{"line_number":229,"context_line":"        # e.g. 011 octal is 9 decimal. Since there is no standard around this,"},{"line_number":230,"context_line":"        # we reject leading \u00270\u0027s to avoid ambiguity."},{"line_number":231,"context_line":"        if ip.version \u003d\u003d 4 and str(ip) !\u003d data:"},{"line_number":232,"context_line":"            msg \u003d _(\"\u0027%(data)s\u0027 isn\u0027t a accepted IP address, \""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a710552_85e8087e","line":229,"in_reply_to":"5a710552_fd740ed0","updated":"2015-12-15 14:38:17.000000000","message":"This wording is my fault. I meant to say there is no standard out there saying that values with leading zeros in IP addresses must be interpreted as octal. Some platforms/libraries/utilities treat them as decimal.","commit_id":"c4a4f053e87a3e7b1e5f36c12547ca5f63c614d6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"603d7fe0a2d50b9b6c66d67d08290983ef885d17","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            raise ValueError()"},{"line_number":228,"context_line":"        # A leading \u00270\u0027 in IPv4 address may be interpreted as an octal number,"},{"line_number":229,"context_line":"        # e.g. 011 octal is 9 decimal. Since there is no standard around this,"},{"line_number":230,"context_line":"        # we reject leading \u00270\u0027s to avoid ambiguity."},{"line_number":231,"context_line":"        if ip.version \u003d\u003d 4 and str(ip) !\u003d data:"},{"line_number":232,"context_line":"            msg \u003d _(\"\u0027%(data)s\u0027 isn\u0027t a accepted IP address, \""},{"line_number":233,"context_line":"                    \"\u0027%(ip)s\u0027 is recommended\") % {\"data\": data, \"ip\": ip}"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a710552_bd7e86ac","line":230,"updated":"2015-12-15 10:27:46.000000000","message":"we reject \u003d\u003e hence we reject","commit_id":"c4a4f053e87a3e7b1e5f36c12547ca5f63c614d6"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"481bc873618016ed8c678a832e17f24f88637e2f","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            raise ValueError()"},{"line_number":228,"context_line":"        # A leading \u00270\u0027 in IPv4 address may be interpreted as an octal number,"},{"line_number":229,"context_line":"        # e.g. 011 octal is 9 decimal. Since there is no standard around this,"},{"line_number":230,"context_line":"        # we reject leading \u00270\u0027s to avoid ambiguity."},{"line_number":231,"context_line":"        if ip.version \u003d\u003d 4 and str(ip) !\u003d data:"},{"line_number":232,"context_line":"            msg \u003d _(\"\u0027%(data)s\u0027 isn\u0027t a accepted IP address, \""},{"line_number":233,"context_line":"                    \"\u0027%(ip)s\u0027 is recommended\") % {\"data\": data, \"ip\": ip}"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a710552_f24acb82","line":230,"in_reply_to":"5a710552_bd7e86ac","updated":"2015-12-16 02:47:56.000000000","message":"Done","commit_id":"c4a4f053e87a3e7b1e5f36c12547ca5f63c614d6"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"39b08d8900c20d3f383afd6ffae717f755138b07","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        # whether IP address with leading \u00270\u0027s should be interpreted as octal"},{"line_number":231,"context_line":"        # or decimal, hence we reject leading \u00270\u0027s to avoid ambiguity."},{"line_number":232,"context_line":"        if ip.version \u003d\u003d 4 and str(ip) !\u003d data:"},{"line_number":233,"context_line":"            msg \u003d _(\"\u0027%(data)s\u0027 isn\u0027t a accepted IP address, \""},{"line_number":234,"context_line":"                    \"\u0027%(ip)s\u0027 is recommended\") % {\"data\": data, \"ip\": ip}"},{"line_number":235,"context_line":"    except Exception:"},{"line_number":236,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid IP address\") % data"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a710552_cb7116aa","line":233,"updated":"2015-12-16 04:04:02.000000000","message":"isn\u0027t a -\u003e is not an","commit_id":"fb8c9fb094118723a728002552f877261d29bf7b"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"84b09174cbbfd34cae75ecbbfb859c429e184937","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        # whether IP address with leading \u00270\u0027s should be interpreted as octal"},{"line_number":231,"context_line":"        # or decimal, hence we reject leading \u00270\u0027s to avoid ambiguity."},{"line_number":232,"context_line":"        if ip.version \u003d\u003d 4 and str(ip) !\u003d data:"},{"line_number":233,"context_line":"            msg \u003d _(\"\u0027%(data)s\u0027 isn\u0027t a accepted IP address, \""},{"line_number":234,"context_line":"                    \"\u0027%(ip)s\u0027 is recommended\") % {\"data\": data, \"ip\": ip}"},{"line_number":235,"context_line":"    except Exception:"},{"line_number":236,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid IP address\") % data"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a710552_4b73e615","line":233,"in_reply_to":"5a710552_cb7116aa","updated":"2015-12-16 04:23:16.000000000","message":"Done","commit_id":"fb8c9fb094118723a728002552f877261d29bf7b"}],"neutron/tests/unit/api/v2/test_attributes.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"db4a736484c895574691dee3f0875263abe99757","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            ip_addr \u003d \u0027111.1.1.1%s\u0027 % ws"},{"line_number":271,"context_line":"            msg \u003d attributes._validate_ip_address(ip_addr)"},{"line_number":272,"context_line":"            self.assertEqual(\"\u0027%s\u0027 is not a valid IP address\" % ip_addr, msg)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        ip_addr \u003d \u00271.1.1.01\u0027"},{"line_number":275,"context_line":"        msg \u003d attributes._validate_ip_address(ip_addr)"},{"line_number":276,"context_line":"        self.assertEqual(\"\u0027%(data)s\u0027 isn\u0027t a recognized IP address,\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_dc2a99e7","line":273,"updated":"2015-12-14 19:46:37.000000000","message":"Nit: too many tests in one test case. I\u0027d like to see a new test case here that checks .01, .011, and .09 to prevent octal regressions.","commit_id":"6ee14dc7aa956d30788aff46783113657c4bf328"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"926347c66e952b7d68ca80072fbeefb39fc21409","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            ip_addr \u003d \u0027111.1.1.1%s\u0027 % ws"},{"line_number":271,"context_line":"            msg \u003d attributes._validate_ip_address(ip_addr)"},{"line_number":272,"context_line":"            self.assertEqual(\"\u0027%s\u0027 is not a valid IP address\" % ip_addr, msg)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        ip_addr \u003d \u00271.1.1.01\u0027"},{"line_number":275,"context_line":"        msg \u003d attributes._validate_ip_address(ip_addr)"},{"line_number":276,"context_line":"        self.assertEqual(\"\u0027%(data)s\u0027 isn\u0027t a recognized IP address,\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_13aa39d5","line":273,"in_reply_to":"5a710552_ba68dabb","updated":"2015-12-15 05:31:39.000000000","message":"The validation could be done in other ways. Tests should not assume how something is done, they should check for expected behavior.","commit_id":"6ee14dc7aa956d30788aff46783113657c4bf328"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"7f08e03aa4624b18f4a6882a50d6b2e49c9aefe3","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            ip_addr \u003d \u0027111.1.1.1%s\u0027 % ws"},{"line_number":271,"context_line":"            msg \u003d attributes._validate_ip_address(ip_addr)"},{"line_number":272,"context_line":"            self.assertEqual(\"\u0027%s\u0027 is not a valid IP address\" % ip_addr, msg)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        ip_addr \u003d \u00271.1.1.01\u0027"},{"line_number":275,"context_line":"        msg \u003d attributes._validate_ip_address(ip_addr)"},{"line_number":276,"context_line":"        self.assertEqual(\"\u0027%(data)s\u0027 isn\u0027t a recognized IP address,\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_ba68dabb","line":273,"in_reply_to":"5a710552_dc2a99e7","updated":"2015-12-15 03:48:27.000000000","message":"But indeed, by using \"flags\u003dnetaddr.core.ZEROFILL\", \u00270X\u0027 even \u002700X‘ are all the same case.","commit_id":"6ee14dc7aa956d30788aff46783113657c4bf328"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"3c82b54b5426c9e7df945089930ca31661612fa2","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            ip_addr \u003d \u0027111.1.1.1%s\u0027 % ws"},{"line_number":271,"context_line":"            msg \u003d attributes._validate_ip_address(ip_addr)"},{"line_number":272,"context_line":"            self.assertEqual(\"\u0027%s\u0027 is not a valid IP address\" % ip_addr, msg)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        ip_addr \u003d \u00271.1.1.01\u0027"},{"line_number":275,"context_line":"        msg \u003d attributes._validate_ip_address(ip_addr)"},{"line_number":276,"context_line":"        self.assertEqual(\"\u0027%(data)s\u0027 isn\u0027t a recognized IP address,\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_d717b8eb","line":273,"in_reply_to":"5a710552_dc2a99e7","updated":"2015-12-15 08:06:23.000000000","message":"Done","commit_id":"6ee14dc7aa956d30788aff46783113657c4bf328"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"926347c66e952b7d68ca80072fbeefb39fc21409","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        ip_addr \u003d \u00271\u0027 * 59"},{"line_number":291,"context_line":"        with mock.patch(\u0027netaddr.IPAddress\u0027) as ip_address_cls:"},{"line_number":292,"context_line":"            msg \u003d attributes._validate_ip_address(ip_addr)"},{"line_number":293,"context_line":"        ip_address_cls.assert_called_once_with(ip_addr,"},{"line_number":294,"context_line":"                                               flags\u003dnetaddr.core.ZEROFILL)"},{"line_number":295,"context_line":"        self.assertEqual(\"\u0027%s\u0027 is not a valid IP address\" % ip_addr, msg)"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_93b6293c","line":293,"updated":"2015-12-15 05:31:39.000000000","message":"This assert is pointless and should be removed IMO.","commit_id":"6ee14dc7aa956d30788aff46783113657c4bf328"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"3c82b54b5426c9e7df945089930ca31661612fa2","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        ip_addr \u003d \u00271\u0027 * 59"},{"line_number":291,"context_line":"        with mock.patch(\u0027netaddr.IPAddress\u0027) as ip_address_cls:"},{"line_number":292,"context_line":"            msg \u003d attributes._validate_ip_address(ip_addr)"},{"line_number":293,"context_line":"        ip_address_cls.assert_called_once_with(ip_addr,"},{"line_number":294,"context_line":"                                               flags\u003dnetaddr.core.ZEROFILL)"},{"line_number":295,"context_line":"        self.assertEqual(\"\u0027%s\u0027 is not a valid IP address\" % ip_addr, msg)"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_97bff0cf","line":293,"in_reply_to":"5a710552_93b6293c","updated":"2015-12-15 08:06:23.000000000","message":"what about I leave it in this patch, and remove it in a new patch?","commit_id":"6ee14dc7aa956d30788aff46783113657c4bf328"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"ae3c276e9189b55ffb8b68be9ba2d401a130adce","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            ip_addr \u003d \u0027111.1.1.1%s\u0027 % ws"},{"line_number":271,"context_line":"            msg \u003d attributes._validate_ip_address(ip_addr)"},{"line_number":272,"context_line":"            self.assertEqual(\"\u0027%s\u0027 is not a valid IP address\" % ip_addr, msg)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def test_validate_ip_address_with_leading_zero(self):"},{"line_number":275,"context_line":"        ip_addr \u003d \u00271.1.1.01\u0027"},{"line_number":276,"context_line":"        expected_msg \u003d (\"\u0027%(data)s\u0027 isn\u0027t a accepted IP address, \""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a710552_0bbc2204","line":273,"updated":"2015-12-15 14:38:17.000000000","message":"Lines 237-295 all have the same pattern. In a follow-up patch maybe put all invalid values in a list then loop over it with asserts.","commit_id":"c4a4f053e87a3e7b1e5f36c12547ca5f63c614d6"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"481bc873618016ed8c678a832e17f24f88637e2f","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            ip_addr \u003d \u0027111.1.1.1%s\u0027 % ws"},{"line_number":271,"context_line":"            msg \u003d attributes._validate_ip_address(ip_addr)"},{"line_number":272,"context_line":"            self.assertEqual(\"\u0027%s\u0027 is not a valid IP address\" % ip_addr, msg)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def test_validate_ip_address_with_leading_zero(self):"},{"line_number":275,"context_line":"        ip_addr \u003d \u00271.1.1.01\u0027"},{"line_number":276,"context_line":"        expected_msg \u003d (\"\u0027%(data)s\u0027 isn\u0027t a accepted IP address, \""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a710552_55b5c92e","line":273,"in_reply_to":"5a710552_0bbc2204","updated":"2015-12-16 02:47:56.000000000","message":"OK, I will change these in a follow-up patch :)","commit_id":"c4a4f053e87a3e7b1e5f36c12547ca5f63c614d6"}]}
