)]}'
{"neutron/db/l3_agentschedulers_db.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6decd39066634b177acc7de3d35912b6c2a16afa","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                    active, l3_agent)]"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    def check_dvr_serviceable_ports_on_host("},{"line_number":460,"context_line":"            self, context, host, subnet_ids, except_port\u003dNone):"},{"line_number":461,"context_line":"        \"\"\""},{"line_number":462,"context_line":"        This function checks for existence of dvr serviceable"},{"line_number":463,"context_line":"        ports on the host, running the input l3agent."}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_a9172da2","line":460,"updated":"2015-12-23 11:51:50.000000000","message":"can you please add a docstring explaining what all of the parameters are\n\nthe name except_port here was/is cryptic","commit_id":"f1ff4809b26c68a13bb9e8c23c989c4afb002a0b"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e2466b83202c161314b317c0784d9fa5593df03f","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                    active, l3_agent)]"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    def check_dvr_serviceable_ports_on_host("},{"line_number":460,"context_line":"            self, context, host, subnet_ids, except_port\u003dNone):"},{"line_number":461,"context_line":"        \"\"\""},{"line_number":462,"context_line":"        This function checks for existence of dvr serviceable"},{"line_number":463,"context_line":"        ports on the host, running the input l3agent."}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_d1549b55","line":460,"in_reply_to":"1a7b0d38_a9172da2","updated":"2015-12-23 12:07:55.000000000","message":"I thought its name and usage is quite self-documented, but I\u0027m ready to add an explanation if you think it\u0027s needed","commit_id":"f1ff4809b26c68a13bb9e8c23c989c4afb002a0b"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ae89d012edb6f2ca8df0e613107d0e4ab6d60d2c","unresolved":false,"context_lines":[{"line_number":461,"context_line":"        \"\"\"Check for existence of dvr serviceable ports on host"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        :param context: request context"},{"line_number":464,"context_line":"        :param host: host to look ports on"},{"line_number":465,"context_line":"        :param subnet_ids: IDs of subnets to look ports on"},{"line_number":466,"context_line":"        :param except_port: ID of the port to ignore (used when checking if"},{"line_number":467,"context_line":"        DVR router should be removed from host before actual port remove)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_6b02b040","line":464,"range":{"start_line":464,"start_character":33,"end_line":464,"end_character":34},"updated":"2016-01-12 05:05:21.000000000","message":"nit: add \"for\" here?","commit_id":"56eb877d250794a38bcf4f6b94aee1add4723ae0"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ae89d012edb6f2ca8df0e613107d0e4ab6d60d2c","unresolved":false,"context_lines":[{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        :param context: request context"},{"line_number":464,"context_line":"        :param host: host to look ports on"},{"line_number":465,"context_line":"        :param subnet_ids: IDs of subnets to look ports on"},{"line_number":466,"context_line":"        :param except_port: ID of the port to ignore (used when checking if"},{"line_number":467,"context_line":"        DVR router should be removed from host before actual port remove)"},{"line_number":468,"context_line":"        :return:"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_eb9460e9","line":465,"range":{"start_line":465,"start_character":49,"end_line":465,"end_character":50},"updated":"2016-01-12 05:05:21.000000000","message":"ditto?","commit_id":"56eb877d250794a38bcf4f6b94aee1add4723ae0"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ae89d012edb6f2ca8df0e613107d0e4ab6d60d2c","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        :param subnet_ids: IDs of subnets to look ports on"},{"line_number":466,"context_line":"        :param except_port: ID of the port to ignore (used when checking if"},{"line_number":467,"context_line":"        DVR router should be removed from host before actual port remove)"},{"line_number":468,"context_line":"        :return:"},{"line_number":469,"context_line":"        \"\"\""},{"line_number":470,"context_line":"        # db query will return ports for all subnets if subnet_ids is empty,"},{"line_number":471,"context_line":"        # so need to check first"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_0b68d4f4","line":468,"range":{"start_line":468,"start_character":15,"end_line":468,"end_character":16},"updated":"2016-01-12 05:05:21.000000000","message":"nit:  True if???  False if???  What is the return value?  You were doing so well adding documentation here, why stop?  :)","commit_id":"56eb877d250794a38bcf4f6b94aee1add4723ae0"}],"neutron/db/l3_dvrscheduler_db.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6decd39066634b177acc7de3d35912b6c2a16afa","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        for router_id in router_ids:"},{"line_number":172,"context_line":"            subnet_ids \u003d self.get_subnet_ids_on_router(admin_context,"},{"line_number":173,"context_line":"                                                       router_id)"},{"line_number":174,"context_line":"            if self.check_dvr_serviceable_ports_on_host("},{"line_number":175,"context_line":"                    admin_context, port_host, subnet_ids, except_port\u003dport_id):"},{"line_number":176,"context_line":"                continue"},{"line_number":177,"context_line":"            filter_rtr \u003d {\u0027device_id\u0027: [router_id],"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_71a047f5","line":174,"updated":"2015-12-23 11:51:50.000000000","message":"maybe unrelated to this patch - why not do the search with the router filter below here if possible?","commit_id":"f1ff4809b26c68a13bb9e8c23c989c4afb002a0b"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e2466b83202c161314b317c0784d9fa5593df03f","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        for router_id in router_ids:"},{"line_number":172,"context_line":"            subnet_ids \u003d self.get_subnet_ids_on_router(admin_context,"},{"line_number":173,"context_line":"                                                       router_id)"},{"line_number":174,"context_line":"            if self.check_dvr_serviceable_ports_on_host("},{"line_number":175,"context_line":"                    admin_context, port_host, subnet_ids, except_port\u003dport_id):"},{"line_number":176,"context_line":"                continue"},{"line_number":177,"context_line":"            filter_rtr \u003d {\u0027device_id\u0027: [router_id],"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_f17437d0","line":174,"in_reply_to":"1a7b0d38_71a047f5","updated":"2015-12-23 12:07:55.000000000","message":"Not sure I got the idea but it indeed seems unrelated","commit_id":"f1ff4809b26c68a13bb9e8c23c989c4afb002a0b"}]}