)]}'
{"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ef0e4d5f153049ae138a1cd8ac754de9aa204d91","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                        snat_binding and"},{"line_number":377,"context_line":"                        snat_binding.l3_agent_id \u003d\u003d l3_agent[\u0027id\u0027])"},{"line_number":378,"context_line":"                    if (not is_this_snat_agent and"},{"line_number":379,"context_line":"                        not plugin.check_dvr_serviceable_ports_on_host("},{"line_number":380,"context_line":"                            context, l3_agent[\u0027host\u0027], subnet_ids)):"},{"line_number":381,"context_line":"                        plugin.remove_router_from_l3_agent("},{"line_number":382,"context_line":"                            context, l3_agent[\u0027id\u0027], router[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"da6ed579_e93dd6bb","line":379,"updated":"2016-01-13 20:45:08.000000000","message":"nit: can you change this to not have a double \"not\"?  Or maybe just:\n\nif snat_binding and snat_binding.l3_agent_id \u003d\u003d l3_agent[\u0027id\u0027]:\n    continue","commit_id":"1598930470156a8bfdda9851c10de8dc22618ddd"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"6ab99a86b35252badee7a7616b6769d340d0710a","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                        snat_binding and"},{"line_number":377,"context_line":"                        snat_binding.l3_agent_id \u003d\u003d l3_agent[\u0027id\u0027])"},{"line_number":378,"context_line":"                    if (not is_this_snat_agent and"},{"line_number":379,"context_line":"                        not plugin.check_dvr_serviceable_ports_on_host("},{"line_number":380,"context_line":"                            context, l3_agent[\u0027host\u0027], subnet_ids)):"},{"line_number":381,"context_line":"                        plugin.remove_router_from_l3_agent("},{"line_number":382,"context_line":"                            context, l3_agent[\u0027id\u0027], router[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"da6ed579_962d4400","line":379,"in_reply_to":"da6ed579_e93dd6bb","updated":"2016-01-14 12:06:44.000000000","message":"Done","commit_id":"1598930470156a8bfdda9851c10de8dc22618ddd"}],"neutron/db/l3_dvrscheduler_db.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"5aff3fea6f30f1e62efc10e5b26739cc3e3f528d","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        agent \u003d self._get_agent_by_type_and_host("},{"line_number":186,"context_line":"            context, n_const.AGENT_TYPE_L3, port_host)"},{"line_number":187,"context_line":"        removed_router_info \u003d []"},{"line_number":188,"context_line":"        for router_id in router_ids:"},{"line_number":189,"context_line":"            snat_binding \u003d context.session.query("},{"line_number":190,"context_line":"                CentralizedSnatL3AgentBinding).filter_by("},{"line_number":191,"context_line":"                    router_id\u003drouter_id).first()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_221b1d1d","line":188,"range":{"start_line":188,"start_character":35,"end_line":188,"end_character":36},"updated":"2015-12-17 21:29:15.000000000","message":"Is it possible to create a function to get the snat_bindings with filter?","commit_id":"bd92818703b4c0d19f2e90399119817f90d37e8a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"446b191a4a349f98e7953ab319ea4ab41e66eb79","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        agent \u003d self._get_agent_by_type_and_host("},{"line_number":186,"context_line":"            context, n_const.AGENT_TYPE_L3, port_host)"},{"line_number":187,"context_line":"        removed_router_info \u003d []"},{"line_number":188,"context_line":"        for router_id in router_ids:"},{"line_number":189,"context_line":"            snat_binding \u003d context.session.query("},{"line_number":190,"context_line":"                CentralizedSnatL3AgentBinding).filter_by("},{"line_number":191,"context_line":"                    router_id\u003drouter_id).first()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_6313560e","line":188,"range":{"start_line":188,"start_character":35,"end_line":188,"end_character":36},"in_reply_to":"3a7e1126_221b1d1d","updated":"2015-12-18 08:30:28.000000000","message":"This is just one statement so I don\u0027t think it deserves a separate method","commit_id":"bd92818703b4c0d19f2e90399119817f90d37e8a"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"c3d5c0aa2aa807177971abfcb19a359678da39c1","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        agent \u003d self._get_agent_by_type_and_host("},{"line_number":186,"context_line":"            context, n_const.AGENT_TYPE_L3, port_host)"},{"line_number":187,"context_line":"        removed_router_info \u003d []"},{"line_number":188,"context_line":"        for router_id in router_ids:"},{"line_number":189,"context_line":"            snat_binding \u003d context.session.query("},{"line_number":190,"context_line":"                CentralizedSnatL3AgentBinding).filter_by("},{"line_number":191,"context_line":"                    router_id\u003drouter_id).first()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_97ce2682","line":188,"range":{"start_line":188,"start_character":35,"end_line":188,"end_character":36},"in_reply_to":"3a7e1126_6313560e","updated":"2016-01-12 07:26:22.000000000","message":"What about return the agent id that hosts snat? It appears 2 times in this patch, looks like a useful method.","commit_id":"bd92818703b4c0d19f2e90399119817f90d37e8a"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"68d379cb309e0fd09af4d287800b34ed1f1ec043","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        for router_id in router_ids:"},{"line_number":195,"context_line":"            snat_binding \u003d context.session.query("},{"line_number":196,"context_line":"                CentralizedSnatL3AgentBinding).filter_by("},{"line_number":197,"context_line":"                    router_id\u003drouter_id).first()"},{"line_number":198,"context_line":"            if snat_binding and snat_binding.l3_agent_id \u003d\u003d agent.id:"},{"line_number":199,"context_line":"                # not removing from the agent hosting SNAT for the router"},{"line_number":200,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_5a90d395","line":197,"updated":"2016-01-12 08:00:10.000000000","message":"nit:\nThe query here is OK for common case, if a subnet just attached to one router as interface, then get_dvr_routers_by_portid will return only one router.\nBut for multiple routers case, query filter_by l3_agent_id seems better.","commit_id":"cb7171b2b8d80997342791308885c50b0dec06c2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"66c23466712cedef43d559244745b6cc97309a49","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        for router_id in router_ids:"},{"line_number":195,"context_line":"            snat_binding \u003d context.session.query("},{"line_number":196,"context_line":"                CentralizedSnatL3AgentBinding).filter_by("},{"line_number":197,"context_line":"                    router_id\u003drouter_id).first()"},{"line_number":198,"context_line":"            if snat_binding and snat_binding.l3_agent_id \u003d\u003d agent.id:"},{"line_number":199,"context_line":"                # not removing from the agent hosting SNAT for the router"},{"line_number":200,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_8bd11bfe","line":197,"in_reply_to":"da6ed579_5a90d395","updated":"2016-01-12 09:42:11.000000000","message":"filtering by agent_id makes sense, thanks.","commit_id":"cb7171b2b8d80997342791308885c50b0dec06c2"}],"neutron/tests/functional/services/l3_router/test_l3_dvr_router_plugin.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"823e0f87898847b90a2bc16c1c9ccf743df14436","unresolved":false,"context_lines":[{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    def test_remove_router_interface_router_remove_from_agent(self):"},{"line_number":544,"context_line":"        \"\"\"Check that dvr router is not removed from l3 agent hosting"},{"line_number":545,"context_line":"        SNAT for it on router interface removal\"\"\""},{"line_number":546,"context_line":"        router \u003d self._create_router()"},{"line_number":547,"context_line":"        kwargs \u003d {\u0027arg_list\u0027: (external_net.EXTERNAL,),"},{"line_number":548,"context_line":"                  external_net.EXTERNAL: True}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_930cb695","line":545,"updated":"2015-12-15 21:51:03.000000000","message":"docstring \"\"\" should end on a newline.","commit_id":"60e9cfbcbde0c91fa8d3577586212eb630f1a947"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"823e0f87898847b90a2bc16c1c9ccf743df14436","unresolved":false,"context_lines":[{"line_number":576,"context_line":""},{"line_number":577,"context_line":"    def test_router_is_not_removed_from_snat_agent_on_dhcp_port_deletion(self):"},{"line_number":578,"context_line":"        \"\"\"Check that dvr router is not removed from l3 agent hosting"},{"line_number":579,"context_line":"        SNAT for it on DHCP port removal\"\"\""},{"line_number":580,"context_line":"        router \u003d self._create_router()"},{"line_number":581,"context_line":"        kwargs \u003d {\u0027arg_list\u0027: (external_net.EXTERNAL,),"},{"line_number":582,"context_line":"                  external_net.EXTERNAL: True}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_d379defd","line":579,"updated":"2015-12-15 21:51:03.000000000","message":"ditto.","commit_id":"60e9cfbcbde0c91fa8d3577586212eb630f1a947"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"dab7bb953019bcbb66e2f572f5436ac388e53bd8","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        self._test_router_remove_from_agent_on_vm_port_deletion("},{"line_number":561,"context_line":"            non_admin_port\u003dTrue)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    def test_remove_router_interface_router_remove_from_agent(self):"},{"line_number":564,"context_line":"        \"\"\"Check that dvr router is not removed from l3 agent hosting"},{"line_number":565,"context_line":"        SNAT for it on router interface removal"},{"line_number":566,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_7748525c","line":563,"updated":"2016-01-12 07:27:20.000000000","message":"Should the name of this method change? I think you mean, router not removed from agent.","commit_id":"cb7171b2b8d80997342791308885c50b0dec06c2"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"68d379cb309e0fd09af4d287800b34ed1f1ec043","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        self._test_router_remove_from_agent_on_vm_port_deletion("},{"line_number":561,"context_line":"            non_admin_port\u003dTrue)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    def test_remove_router_interface_router_remove_from_agent(self):"},{"line_number":564,"context_line":"        \"\"\"Check that dvr router is not removed from l3 agent hosting"},{"line_number":565,"context_line":"        SNAT for it on router interface removal"},{"line_number":566,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_3a639fb3","line":563,"in_reply_to":"da6ed579_7748525c","updated":"2016-01-12 08:00:10.000000000","message":"+1","commit_id":"cb7171b2b8d80997342791308885c50b0dec06c2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"66c23466712cedef43d559244745b6cc97309a49","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        self._test_router_remove_from_agent_on_vm_port_deletion("},{"line_number":561,"context_line":"            non_admin_port\u003dTrue)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    def test_remove_router_interface_router_remove_from_agent(self):"},{"line_number":564,"context_line":"        \"\"\"Check that dvr router is not removed from l3 agent hosting"},{"line_number":565,"context_line":"        SNAT for it on router interface removal"},{"line_number":566,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_71693a8b","line":563,"in_reply_to":"da6ed579_7748525c","updated":"2016-01-12 09:42:11.000000000","message":"Done","commit_id":"cb7171b2b8d80997342791308885c50b0dec06c2"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"dab7bb953019bcbb66e2f572f5436ac388e53bd8","unresolved":false,"context_lines":[{"line_number":594,"context_line":"                self.assertEqual(1, len(agents[\u0027agents\u0027]))"},{"line_number":595,"context_line":"                self.assertFalse(l3_notifier.router_removed_from_agent.called)"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    def test_router_is_not_removed_from_snat_agent_on_dhcp_port_deletion(self):"},{"line_number":598,"context_line":"        \"\"\"Check that dvr router is not removed from l3 agent hosting"},{"line_number":599,"context_line":"        SNAT for it on DHCP port removal"},{"line_number":600,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_3763bab3","line":597,"updated":"2016-01-12 07:27:20.000000000","message":"I think the 2 test case can be one, first, dhcp port and router interface are added. Then the dhcp port is deleted, router will not be removed from agent, then the router interface is deleted, router will not be removed from agent.","commit_id":"cb7171b2b8d80997342791308885c50b0dec06c2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"66c23466712cedef43d559244745b6cc97309a49","unresolved":false,"context_lines":[{"line_number":594,"context_line":"                self.assertEqual(1, len(agents[\u0027agents\u0027]))"},{"line_number":595,"context_line":"                self.assertFalse(l3_notifier.router_removed_from_agent.called)"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    def test_router_is_not_removed_from_snat_agent_on_dhcp_port_deletion(self):"},{"line_number":598,"context_line":"        \"\"\"Check that dvr router is not removed from l3 agent hosting"},{"line_number":599,"context_line":"        SNAT for it on DHCP port removal"},{"line_number":600,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_31d8a253","line":597,"in_reply_to":"da6ed579_3763bab3","updated":"2016-01-12 09:42:11.000000000","message":"I\u0027d like to avoid testing several use cases with one test.","commit_id":"cb7171b2b8d80997342791308885c50b0dec06c2"}]}
