)]}'
{"neutron/cmd/sanity/checks.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"4c805b5cfbf1c0ea1c46421c0450f185bf6fefd7","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        except RuntimeError as e:"},{"line_number":101,"context_line":"            LOG.exception(_LE(\"Exception while checking supported feature via \""},{"line_number":102,"context_line":"                              \"%(command)s. %(Exception)s:\"),"},{"line_number":103,"context_line":"                          {\u0027command\u0027: full_args, \u0027Exception\u0027: e})"},{"line_number":104,"context_line":"            return False"},{"line_number":105,"context_line":"        except Exception:"},{"line_number":106,"context_line":"            LOG.exception(_LE(\"Unexpected exception while checking supported\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_67ace035","line":103,"updated":"2015-12-15 23:26:25.000000000","message":"One of the features of LOG.exception is that you don\u0027t have to pass the exception.  So,\n\n  except RuntimeError as e:\n\nbecomes this:\n\n  except RuntimeError:\n\nAnd you remove the %(Exception) part from the message.  It should become cleaner.","commit_id":"6545c43e7705edc35bf49e66b3a06f29e8e3dc94"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8828f105d56a77cdd65cb63a382f7bafedfdcb6b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        try:"},{"line_number":99,"context_line":"            agent_utils.execute(full_args, run_as_root\u003dTrue)"},{"line_number":100,"context_line":"        except RuntimeError as e:"},{"line_number":101,"context_line":"            LOG.warn(_LW(\"Exception while checking supported feature via \""},{"line_number":102,"context_line":"                         \"%(command)s. Exception: %(exception)s\"),"},{"line_number":103,"context_line":"                     {\u0027command\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":104,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_b659865c","line":101,"updated":"2016-01-04 18:10:17.000000000","message":"LOG.warning is recommended.\n\nhttps://review.openstack.org/#/c/262257/ replaces LOG.warn with LOG.warning, so could you use LOG.warning instead?","commit_id":"ec467b154ef9f6b731113090732397ef28213bd0"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"51b25c5b9053b875af0227d813defe66e0da2aaa","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        try:"},{"line_number":99,"context_line":"            agent_utils.execute(full_args, run_as_root\u003dTrue)"},{"line_number":100,"context_line":"        except RuntimeError as e:"},{"line_number":101,"context_line":"            LOG.warn(_LW(\"Exception while checking supported feature via \""},{"line_number":102,"context_line":"                         \"%(command)s. Exception: %(exception)s\"),"},{"line_number":103,"context_line":"                     {\u0027command\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":104,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_e1e2c52e","line":101,"in_reply_to":"fa69d971_b659865c","updated":"2016-01-05 01:47:22.000000000","message":"Thanks, I will fix in next patch.","commit_id":"ec467b154ef9f6b731113090732397ef28213bd0"}]}
