)]}'
{"neutron/db/agentschedulers_db.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"a71140f63bd9669c0848543b593cef88a5f75fb4","unresolved":false,"context_lines":[{"line_number":465,"context_line":"    \"\"\"Mixin class to add availability_zone supported DHCP agent scheduler.\"\"\""},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    def get_network_availability_zones(self, network):"},{"line_number":468,"context_line":"        zones \u003d {agent.availability_zone for agent in network.dhcp_agents}"},{"line_number":469,"context_line":"        return list(zones)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_5c197678","line":468,"updated":"2015-12-16 00:59:18.000000000","message":"You can probably get rid of the \u0027zones\u0027 temp var.","commit_id":"57964df5c6e4d590516ae7eb1783f694fa24f501"}],"neutron/db/availability_zone/network.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"35313348abb5a923ff5fdf0d41e81032b54b840a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        net_res[az_ext.AZ_HINTS] \u003d az_ext.convert_az_string_to_list("},{"line_number":30,"context_line":"            net_db[az_ext.AZ_HINTS])"},{"line_number":31,"context_line":"        net_res[az_ext.AVAILABILITY_ZONES] \u003d ("},{"line_number":32,"context_line":"            self.get_network_availability_zones(net_db[\u0027id\u0027]))"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    common_db_mixin.CommonDbMixin.register_dict_extend_funcs("},{"line_number":35,"context_line":"        attributes.NETWORKS, [\u0027_extend_availability_zone\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_da239656","side":"PARENT","line":32,"updated":"2015-12-14 17:16:40.000000000","message":"if this is no longer used, and it\u0027s the culprit to the performance penalty should we delete? But as it\u0027s being suggested, since it looks like this is the only place where it\u0027s used, would it make sense to take Itsuro\u0027s suggestion into account and modify the signature in the process?","commit_id":"dbc541be5428e092315ed3b51fa2295a5ea49068"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"781dd5321233c46f4cf74cdd554aa2e0648ee995","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def _extend_availability_zone(self, net_res, net_db):"},{"line_number":29,"context_line":"        net_res[az_ext.AZ_HINTS] \u003d az_ext.convert_az_string_to_list("},{"line_number":30,"context_line":"            net_db[az_ext.AZ_HINTS])"},{"line_number":31,"context_line":"        zones \u003d {agent.availability_zone for agent in net_db.dhcp_agents}"},{"line_number":32,"context_line":"        net_res[az_ext.AVAILABILITY_ZONES] \u003d list(zones)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    common_db_mixin.CommonDbMixin.register_dict_extend_funcs("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_e575b8f9","line":31,"updated":"2015-12-14 03:03:15.000000000","message":"Here is the only place that uses \"get_network_availability_zones\", will you consider clean up it in this patch?","commit_id":"fd04e4bd664bf1bf31541034bb98967ffca1cf27"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"83b1a988d04fab800d4fe28434d539e4547f3d22","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def _extend_availability_zone(self, net_res, net_db):"},{"line_number":29,"context_line":"        net_res[az_ext.AZ_HINTS] \u003d az_ext.convert_az_string_to_list("},{"line_number":30,"context_line":"            net_db[az_ext.AZ_HINTS])"},{"line_number":31,"context_line":"        zones \u003d {agent.availability_zone for agent in net_db.dhcp_agents}"},{"line_number":32,"context_line":"        net_res[az_ext.AVAILABILITY_ZONES] \u003d list(zones)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    common_db_mixin.CommonDbMixin.register_dict_extend_funcs("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_eb4ca9c9","line":31,"in_reply_to":"7a740942_304220af","updated":"2015-12-14 04:46:25.000000000","message":"the way the get_network_availability_zones is written, it only takes an ID so it can\u0027t be optimized at that point. We would need to change the interface to that.","commit_id":"fd04e4bd664bf1bf31541034bb98967ffca1cf27"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"a920814f1cffdbd65c611822a1e53450f164053a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def _extend_availability_zone(self, net_res, net_db):"},{"line_number":29,"context_line":"        net_res[az_ext.AZ_HINTS] \u003d az_ext.convert_az_string_to_list("},{"line_number":30,"context_line":"            net_db[az_ext.AZ_HINTS])"},{"line_number":31,"context_line":"        zones \u003d {agent.availability_zone for agent in net_db.dhcp_agents}"},{"line_number":32,"context_line":"        net_res[az_ext.AVAILABILITY_ZONES] \u003d list(zones)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    common_db_mixin.CommonDbMixin.register_dict_extend_funcs("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_304220af","line":31,"in_reply_to":"7a740942_e575b8f9","updated":"2015-12-14 03:44:10.000000000","message":"I think network_availability_zone extension does not assume agent based implementation though current implementation is only for agent based.\nI think this performance improvement code should be into get_network_availability_zone (db/agentshedulers_db.py).","commit_id":"fd04e4bd664bf1bf31541034bb98967ffca1cf27"}],"neutron/db/models_v2.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"781dd5321233c46f4cf74cdd554aa2e0648ee995","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                                    backref\u003d\u0027network\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":268,"context_line":"                                    cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":269,"context_line":"    availability_zone_hints \u003d sa.Column(sa.String(255))"},{"line_number":270,"context_line":"    dhcp_agents \u003d orm.relationship(\u0027Agent\u0027, lazy\u003d\u0027joined\u0027, viewonly\u003dTrue,"},{"line_number":271,"context_line":"                                   secondary\u003d\u0027networkdhcpagentbindings\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_c5bbdcc2","line":270,"updated":"2015-12-14 03:03:15.000000000","message":"Why not use \"agents_db.Agent\" here?","commit_id":"fd04e4bd664bf1bf31541034bb98967ffca1cf27"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"69bca04d611fc3478a3abc1d55e7852ce4907bbc","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                                    backref\u003d\u0027network\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":268,"context_line":"                                    cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":269,"context_line":"    availability_zone_hints \u003d sa.Column(sa.String(255))"},{"line_number":270,"context_line":"    dhcp_agents \u003d orm.relationship(\u0027Agent\u0027, lazy\u003d\u0027joined\u0027, viewonly\u003dTrue,"},{"line_number":271,"context_line":"                                   secondary\u003d\u0027networkdhcpagentbindings\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_1d17fc45","line":270,"in_reply_to":"7a740942_6b58b98a","updated":"2015-12-14 05:01:38.000000000","message":"Thanks for your explanation.","commit_id":"fd04e4bd664bf1bf31541034bb98967ffca1cf27"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"83b1a988d04fab800d4fe28434d539e4547f3d22","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                                    backref\u003d\u0027network\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":268,"context_line":"                                    cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":269,"context_line":"    availability_zone_hints \u003d sa.Column(sa.String(255))"},{"line_number":270,"context_line":"    dhcp_agents \u003d orm.relationship(\u0027Agent\u0027, lazy\u003d\u0027joined\u0027, viewonly\u003dTrue,"},{"line_number":271,"context_line":"                                   secondary\u003d\u0027networkdhcpagentbindings\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_6b58b98a","line":270,"in_reply_to":"7a740942_c5bbdcc2","updated":"2015-12-14 04:46:25.000000000","message":"would lead to a circular import:\nhttps://github.com/openstack/neutron/blob/851464bbabd8eca3295256ca74f16d8b0b85a8b6/neutron/db/agents_db.py#L35","commit_id":"fd04e4bd664bf1bf31541034bb98967ffca1cf27"}]}