)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"383151ca7f8851f67c0525b2a17a6d201827547b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This will lead to RPC message is too big so that DHCP agent process"},{"line_number":14,"context_line":"will time out for waiting for the reply message."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1525753"},{"line_number":17,"context_line":"Change-Id: Icef63f0363a66449cf27180c966ae664e4390052"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a710552_f4a3d29c","line":15,"updated":"2015-12-15 07:59:33.000000000","message":"I can understand this issue but I cannot do solution about the patch from Message. Could you elaborate?","commit_id":"a58334d121b45fb9d4864b502be0e3fff0a22570"}],"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"fb3a6f95a1f795fbe23621b98e19e08a4c1bee7a","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                    LOG.exception(_LE(\u0027Unable to sync network state on \u0027"},{"line_number":159,"context_line":"                                      \u0027deleted network %s\u0027), deleted_id)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            for network in active_networks:"},{"line_number":162,"context_line":"                if (not only_nets or  # specifically resync all"},{"line_number":163,"context_line":"                        network.id not in known_network_ids or  # missing net"},{"line_number":164,"context_line":"                        network.id in only_nets):  # specific network to sync"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_b09db0bd","line":161,"updated":"2015-12-14 03:28:42.000000000","message":"I think you want to use \"active_network_ids\" here.","commit_id":"43e4b5510e3df925da69ec0b5ba3e838c40f4b82"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"55ebbd895fa9432472a23c1466be45cc2fac4f47","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            for network in active_network_ids:"},{"line_number":162,"context_line":"                if (not only_nets or  # specifically resync all"},{"line_number":163,"context_line":"                        network.id not in known_network_ids or  # missing net"},{"line_number":164,"context_line":"                        network.id in only_nets):  # specific network to sync"},{"line_number":165,"context_line":"                    pool.spawn(self.safe_configure_dhcp_for_network, network)"},{"line_number":166,"context_line":"            pool.waitall()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_ab62213c","line":163,"updated":"2015-12-14 04:54:08.000000000","message":"will the network here still have \"id\"?","commit_id":"a426362f31248e0cc593ded169c4c852eee54804"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"383151ca7f8851f67c0525b2a17a6d201827547b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# Number of networks to fetch from server at a time on resync."},{"line_number":44,"context_line":"# Needed to reduce load on server side and to speed up resync on agent side."},{"line_number":45,"context_line":"SYNC_NETWORKS_MAX_CHUNK_SIZE \u003d 256"},{"line_number":46,"context_line":"SYNC_NETWORKS_MIN_CHUNK_SIZE \u003d 32"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class DhcpAgent(manager.Manager):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_f73af4cc","line":46,"updated":"2015-12-15 07:59:33.000000000","message":"Should this is option which users can set?","commit_id":"a58334d121b45fb9d4864b502be0e3fff0a22570"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"383151ca7f8851f67c0525b2a17a6d201827547b","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            for i in range(0, len(active_network_ids),"},{"line_number":168,"context_line":"                           self.sync_networks_chunk_size):"},{"line_number":169,"context_line":"                networks \u003d self.plugin_rpc.get_networks_list_info("},{"line_number":170,"context_line":"                    active_network_ids[i: i + self.size])"},{"line_number":171,"context_line":"                for network in networks:"},{"line_number":172,"context_line":"                    if (not only_nets or  # specifically resync all"},{"line_number":173,"context_line":"                        network.id not in known_network_ids or  # missing net"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_5449868a","line":170,"updated":"2015-12-15 07:59:33.000000000","message":"What is self.size?","commit_id":"a58334d121b45fb9d4864b502be0e3fff0a22570"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"383151ca7f8851f67c0525b2a17a6d201827547b","unresolved":false,"context_lines":[{"line_number":454,"context_line":"        \"\"\"Make a remote process call to retrieve network info.\"\"\""},{"line_number":455,"context_line":"        cctxt \u003d self.client.prepare()"},{"line_number":456,"context_line":"        networks \u003d cctxt.call(self.context, \u0027get_networks_list_info\u0027,"},{"line_number":457,"context_line":"                             network_ids\u003dnetwork_ids, host\u003dself.host)"},{"line_number":458,"context_line":"        return [dhcp.NetModel(self.use_namespaces, n) for n in networks]"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def update_dhcp_port(self, port_id, port):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_b4030ab8","line":457,"updated":"2015-12-15 07:59:33.000000000","message":"indent issue","commit_id":"a58334d121b45fb9d4864b502be0e3fff0a22570"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"4a717abdd12b073c202871299bed1b88da82c1ac","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            for i in range(0, len(active_network_ids),"},{"line_number":168,"context_line":"                           self.sync_networks_chunk_size):"},{"line_number":169,"context_line":"                networks \u003d self.plugin_rpc.get_networks_list_info("},{"line_number":170,"context_line":"                list(active_network_ids)[i:i + self.sync_networks_chunk_size])"},{"line_number":171,"context_line":"                for network in networks:"},{"line_number":172,"context_line":"                    if (not only_nets or  # specifically resync all"},{"line_number":173,"context_line":"                        network.id not in known_network_ids or  # missing net"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a710552_eb1769eb","line":170,"updated":"2015-12-15 09:38:49.000000000","message":"you need indention here.","commit_id":"231fc9bed4413f261b87f25e42cee72a6f75cfb7"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"4a717abdd12b073c202871299bed1b88da82c1ac","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        except oslo_messaging.MessagingTimeout:"},{"line_number":180,"context_line":"            if self.sync_networks_chunk_size \u003e SYNC_NETWORKS_MIN_CHUNK_SIZE:"},{"line_number":181,"context_line":"                self.sync_networks_chunk_size /\u003d 2"},{"line_number":182,"context_line":"                raise"},{"line_number":183,"context_line":"        except Exception as e:"},{"line_number":184,"context_line":"            if only_nets:"},{"line_number":185,"context_line":"                for network_id in only_nets:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a710552_46579402","line":182,"updated":"2015-12-15 09:38:49.000000000","message":"You should not raise exception here, the code [1] you reference can raise because there is a handler outside the method.\n\nIf sync_state raise exception here, the sync task for dhcp agent will exit.\n\n[1] https://review.openstack.org/#/c/234067/","commit_id":"231fc9bed4413f261b87f25e42cee72a6f75cfb7"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"4a717abdd12b073c202871299bed1b88da82c1ac","unresolved":false,"context_lines":[{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def get_networks_list_info(self, network_ids):"},{"line_number":454,"context_line":"        \"\"\"Make a remote process call to retrieve network info.\"\"\""},{"line_number":455,"context_line":"        cctxt \u003d self.client.prepare()"},{"line_number":456,"context_line":"        networks \u003d cctxt.call(self.context, \u0027get_networks_list_info\u0027,"},{"line_number":457,"context_line":"                             network_ids\u003dnetwork_ids, host\u003dself.host)"},{"line_number":458,"context_line":"        return [dhcp.NetModel(self.use_namespaces, n) for n in networks]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a710552_c0936cf9","line":455,"updated":"2015-12-15 09:38:49.000000000","message":"A version is preferred.","commit_id":"231fc9bed4413f261b87f25e42cee72a6f75cfb7"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"a9e6db730e6ea672425ab9fc8cdf03bef450ad38","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                                   network)"},{"line_number":177,"context_line":"            pool.waitall()"},{"line_number":178,"context_line":"            LOG.info(_LI(\u0027Synchronizing state complete\u0027))"},{"line_number":179,"context_line":"        except oslo_messaging.MessagingTimeout:"},{"line_number":180,"context_line":"            if self.sync_nets_chunk_size \u003e SYNC_NETWORKS_MIN_CHUNK_SIZE:"},{"line_number":181,"context_line":"                self.sync_nets_chunk_size /\u003d 2"},{"line_number":182,"context_line":"            LOG.info(_LI(\u0027Synchronizing fail complete so reduce chunk \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_8e2b4530","line":179,"updated":"2015-12-15 13:44:05.000000000","message":"I think this should be totally removed.\nMessaging timeout may indicate various issues, more frequently - an issue with messaging layer rather than a timeout on a server side.\n\nWe don\u0027t need to adjust chunk size. \nI\u0027d lower the constant to 50-100 networks per chunk or make it configurable.","commit_id":"dbc2dfc81168e8a614bf16c8c0e3c41ab1637fd8"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7fde589c10a9a36cf562a166e7dc857350873c24","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            pool.waitall()"},{"line_number":178,"context_line":"            LOG.info(_LI(\u0027Synchronizing state complete\u0027))"},{"line_number":179,"context_line":"        except oslo_messaging.MessagingTimeout:"},{"line_number":180,"context_line":"            if self.sync_nets_chunk_size \u003e SYNC_NETWORKS_MIN_CHUNK_SIZE:"},{"line_number":181,"context_line":"                self.sync_nets_chunk_size /\u003d 2"},{"line_number":182,"context_line":"            LOG.info(_LI(\u0027Synchronizing fail complete so reduce chunk \u0027"},{"line_number":183,"context_line":"                         \u0027size to %s\u0027), self.sync_nets_chunk_size)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a710552_ad38673e","line":180,"updated":"2015-12-16 00:16:43.000000000","message":"The following property:\n\n self.sync_nets_chunk_size \u003e\u003d SYNC_NETWORKS_MIN_CHUNK_SIZE\n\nis ensured only because of SYNC_NETWORKS_MIN/MAX_CHUNK_SIZE","commit_id":"5ac37db591b5b715920e30380f7aad58a9df7742"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7fde589c10a9a36cf562a166e7dc857350873c24","unresolved":false,"context_lines":[{"line_number":456,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.1\u0027)"},{"line_number":457,"context_line":"        networks \u003d cctxt.call(self.context, \u0027get_networks_list_info\u0027,"},{"line_number":458,"context_line":"                             network_ids\u003dnetwork_ids, host\u003dself.host)"},{"line_number":459,"context_line":"        return [dhcp.NetModel(self.use_namespaces, n) for n in networks]"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    def update_dhcp_port(self, port_id, port):"},{"line_number":462,"context_line":"        \"\"\"Make a remote process call to update the dhcp port.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a710552_ad8627d9","line":459,"updated":"2015-12-16 00:16:43.000000000","message":"use_namespaces no more exists","commit_id":"5ac37db591b5b715920e30380f7aad58a9df7742"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e3003e45027519d6a9ae43a5a1587c42eb1329a5","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        except oslo_messaging.MessagingTimeout:"},{"line_number":180,"context_line":"            if self.sync_nets_chunk_size \u003e\u003d SYNC_NETWORKS_MIN_CHUNK_SIZE:"},{"line_number":181,"context_line":"                self.sync_nets_chunk_size /\u003d 2"},{"line_number":182,"context_line":"            LOG.info(_LI(\u0027Synchronizing fail complete so reduce chunk \u0027"},{"line_number":183,"context_line":"                         \u0027size to %s\u0027), self.sync_nets_chunk_size)"},{"line_number":184,"context_line":"        except Exception as e:"},{"line_number":185,"context_line":"            if only_nets:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_ff5e14e8","line":182,"updated":"2015-12-16 01:46:03.000000000","message":"The log level here might not be sufficient. After all, it is in an exception here.","commit_id":"a67ad2d94719d2d1bd901103a7d094eaec89acb9"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"fbcdb4143d61887dc2a0f5fa6759c0e634b246c8","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        except oslo_messaging.MessagingTimeout:"},{"line_number":180,"context_line":"            if self.sync_nets_chunk_size \u003e\u003d SYNC_NETWORKS_MIN_CHUNK_SIZE:"},{"line_number":181,"context_line":"                self.sync_nets_chunk_size /\u003d 2"},{"line_number":182,"context_line":"            LOG.info(_LI(\u0027Synchronizing fail complete so reduce chunk \u0027"},{"line_number":183,"context_line":"                         \u0027size to %s\u0027), self.sync_nets_chunk_size)"},{"line_number":184,"context_line":"        except Exception as e:"},{"line_number":185,"context_line":"            if only_nets:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_3f59fc5a","line":182,"in_reply_to":"5a710552_ff5e14e8","updated":"2015-12-16 02:05:35.000000000","message":"Done","commit_id":"a67ad2d94719d2d1bd901103a7d094eaec89acb9"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"523cb5f8a6d7d4ced53b8913643905d2e25b8882","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            pool.waitall()"},{"line_number":178,"context_line":"            LOG.info(_LI(\u0027Synchronizing state complete\u0027))"},{"line_number":179,"context_line":"        except oslo_messaging.MessagingTimeout:"},{"line_number":180,"context_line":"            if self.sync_nets_chunk_size \u003e\u003d SYNC_NETWORKS_MIN_CHUNK_SIZE:"},{"line_number":181,"context_line":"                self.sync_nets_chunk_size /\u003d 2"},{"line_number":182,"context_line":"            LOG.exception(_LE(\u0027Synchronizing fail complete so reduce chunk \u0027"},{"line_number":183,"context_line":"                         \u0027size to %s\u0027), self.sync_nets_chunk_size)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a710552_18a76d50","line":180,"updated":"2015-12-16 08:24:18.000000000","message":"I\u0027m going to repeat my comment from ps #5: this mechanism should be removed. Not to say it is implemented incorrectly.\n\nJust chose fair size of the chunk and keep it constant.","commit_id":"ff4089fb781c5f03a240f34d1cc4ffedff74e417"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9adfc1ea9a7bb9aa01afd3f6b57fe18f79cf0d28","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# Number of networks to fetch from server at a time on resync."},{"line_number":44,"context_line":"# Needed to reduce load on server side and to speed up resync on agent side."},{"line_number":45,"context_line":"SYNC_NETWORKS_MAX_CHUNK_SIZE \u003d 256"},{"line_number":46,"context_line":"SYNC_NETWORKS_MIN_CHUNK_SIZE \u003d 32"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class DhcpAgent(manager.Manager):"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a710552_80be71d2","line":46,"updated":"2015-12-16 13:44:44.000000000","message":"I think that we should enable operators to set these parameters as I mentioned in PS3.","commit_id":"9fed9afeb50e3b783eebbc8dc36cf0b615297765"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"f3aa72f5addf6f4515b2025f4094feb8097e846d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                                      \u0027deleted network %s\u0027), deleted_id)"},{"line_number":162,"context_line":"            for i in range(0, len(active_network_ids),"},{"line_number":163,"context_line":"                           self.sync_nets_size):"},{"line_number":164,"context_line":"                filters \u003d list(active_network_ids)[i:i + self.sync_nets_size]"},{"line_number":165,"context_line":"                networks \u003d self.plugin_rpc.get_active_networks_info("},{"line_number":166,"context_line":"                    filters\u003dfilters)"},{"line_number":167,"context_line":"                for network in networks:"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a7e1126_7d027840","line":164,"range":{"start_line":164,"start_character":16,"end_line":164,"end_character":23},"updated":"2015-12-17 04:29:59.000000000","message":"Brian\u0027s has mentioned it in patch 12.\n\nI would bring it out more specific here. \n\nThe filters should be an object to carry filter(S), the right usage here should be filters \u003d {network_ids: \u003cids\u003e}\n\nOr you just want to pass network_ids, you can change name from filters to network_ids","commit_id":"c487e04dae18a6f5fba0c63d3c44539ae6f2f7a6"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"534c71e6cbd97a6bdce65490769a0aae11767c9e","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                                      \u0027deleted network %s\u0027), deleted_id)"},{"line_number":162,"context_line":"            for i in range(0, len(active_network_ids),"},{"line_number":163,"context_line":"                           self.sync_nets_size):"},{"line_number":164,"context_line":"                filters \u003d list(active_network_ids)[i:i + self.sync_nets_size]"},{"line_number":165,"context_line":"                networks \u003d self.plugin_rpc.get_active_networks_info("},{"line_number":166,"context_line":"                    filters\u003dfilters)"},{"line_number":167,"context_line":"                for network in networks:"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a7e1126_f82af6e6","line":164,"range":{"start_line":164,"start_character":16,"end_line":164,"end_character":23},"in_reply_to":"3a7e1126_7d027840","updated":"2015-12-17 04:43:55.000000000","message":"thx for your advice. i have uploaded the latest patch by your comments.","commit_id":"c487e04dae18a6f5fba0c63d3c44539ae6f2f7a6"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"f3aa72f5addf6f4515b2025f4094feb8097e846d","unresolved":false,"context_lines":[{"line_number":443,"context_line":"            return dhcp.DictModel(port)"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    def get_active_network_ids(self):"},{"line_number":446,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.1\u0027)"},{"line_number":447,"context_line":"        return cctxt.call(self.context, \u0027get_active_network_ids\u0027,"},{"line_number":448,"context_line":"                          host\u003dself.host)"},{"line_number":449,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3a7e1126_9d516465","line":446,"range":{"start_line":446,"start_character":21,"end_line":446,"end_character":27},"updated":"2015-12-17 04:29:59.000000000","message":"If it is a new method here, the version should be a new one and update the comment at line 409.","commit_id":"c487e04dae18a6f5fba0c63d3c44539ae6f2f7a6"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"19958976d2baddb284a3404b84334dbb37490893","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            LOG.info(_LI(\u0027Synchronizing state complete\u0027))"},{"line_number":176,"context_line":"        except oslo_messaging.MessagingTimeout:"},{"line_number":177,"context_line":"            if self.sync_nets_size \u003e\u003d self.sync_nets_min_size:"},{"line_number":178,"context_line":"                self.sync_nets_size /\u003d 2"},{"line_number":179,"context_line":"            LOG.exception(_LE(\u0027Synchronizing fail complete so reduce chunk \u0027"},{"line_number":180,"context_line":"                         \u0027size to %s\u0027), self.sync_nets_size)"},{"line_number":181,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a7e1126_ade4163b","line":178,"range":{"start_line":178,"start_character":16,"end_line":178,"end_character":40},"updated":"2015-12-17 15:20:51.000000000","message":"1, In config, you don\u0027t mentioned the relation between max size and min size, so if a user set max\u003d120, min\u003d40, then it\u0027s possible the sysc_net_size go smaller than min size. If that, the min size will no longer be the min size.\n\n2, Not sure if I missed something, where is the place sync_nets_size can grown up?","commit_id":"c9c8536c43a743289f096a0990cdd3d3dce7327a"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"19958976d2baddb284a3404b84334dbb37490893","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            if self.sync_nets_size \u003e\u003d self.sync_nets_min_size:"},{"line_number":178,"context_line":"                self.sync_nets_size /\u003d 2"},{"line_number":179,"context_line":"            LOG.exception(_LE(\u0027Synchronizing fail complete so reduce chunk \u0027"},{"line_number":180,"context_line":"                         \u0027size to %s\u0027), self.sync_nets_size)"},{"line_number":181,"context_line":"        except Exception as e:"},{"line_number":182,"context_line":"            if only_nets:"},{"line_number":183,"context_line":"                for network_id in only_nets:"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a7e1126_eb3a06cd","line":180,"range":{"start_line":180,"start_character":59,"end_line":180,"end_character":60},"updated":"2015-12-17 15:20:51.000000000","message":"Previous version here, there is only one except block with schedule_resync will be called inside. Now we have two except blocks here, and seems the first one which catches Timeout will stop schedule_resync been called ? And I don\u0027t think that fit previous processing flow.","commit_id":"c9c8536c43a743289f096a0990cdd3d3dce7327a"},{"author":{"_account_id":19575,"name":"carl","email":"gsl0610@163.com","username":"carlgao"},"change_message_id":"14cde957fc76c12f1a6f1bd0eaa1aacc458ea171","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            pool.waitall()"},{"line_number":174,"context_line":"            LOG.info(_LI(\u0027Synchronizing state complete\u0027))"},{"line_number":175,"context_line":"        except oslo_messaging.MessagingTimeout:"},{"line_number":176,"context_line":"            LOG.exception(_LE(\u0027Synchronizing networks from neutron server \u0027"},{"line_number":177,"context_line":"                         \u0027fail complete. Please reconfig the configuration \u0027"},{"line_number":178,"context_line":"                         \u0027named sync_networks_max_chunk_size in the dhcp \u0027"},{"line_number":179,"context_line":"                         \u0027configure file.\u0027))"},{"line_number":180,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a7e1126_bd4cfd70","line":177,"range":{"start_line":176,"start_character":31,"end_line":177,"end_character":39},"updated":"2015-12-18 14:11:27.000000000","message":"Synchronizing networks from neutron server fail to complete.       \nCould you show the error info in this exception? e.g. timeout?","commit_id":"f47cebd4730c3ecf4b69cc8e7cccaf9652f85409"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"ed6d2b51c4563390bac9815f4e60ab4d4c7853c0","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            LOG.exception(_LE(\u0027Synchronizing networks from neutron server \u0027"},{"line_number":177,"context_line":"                         \u0027fail complete. Please reconfig the configuration \u0027"},{"line_number":178,"context_line":"                         \u0027named sync_networks_max_chunk_size in the dhcp \u0027"},{"line_number":179,"context_line":"                         \u0027configure file.\u0027))"},{"line_number":180,"context_line":"        except Exception as e:"},{"line_number":181,"context_line":"            if only_nets:"},{"line_number":182,"context_line":"                for network_id in only_nets:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a7e1126_5530739e","line":179,"range":{"start_line":179,"start_character":40,"end_line":179,"end_character":44},"updated":"2015-12-17 16:24:14.000000000","message":"Please go check https://review.openstack.org/#/c/234067/12/neutron/agent/l3/agent.py L584. Seems need raise here. Or you can make sure that changing you added here will not stop resync?","commit_id":"f47cebd4730c3ecf4b69cc8e7cccaf9652f85409"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"ff19e32d1769f4fe1b37c513a4f8f0fb35fffcbd","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            LOG.exception(_LE(\u0027Synchronizing networks from neutron server \u0027"},{"line_number":177,"context_line":"                         \u0027fail complete. Please reconfig the configuration \u0027"},{"line_number":178,"context_line":"                         \u0027named sync_networks_max_chunk_size in the dhcp \u0027"},{"line_number":179,"context_line":"                         \u0027configure file.\u0027))"},{"line_number":180,"context_line":"        except Exception as e:"},{"line_number":181,"context_line":"            if only_nets:"},{"line_number":182,"context_line":"                for network_id in only_nets:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a7e1126_5e139666","line":179,"range":{"start_line":179,"start_character":40,"end_line":179,"end_character":44},"in_reply_to":"3a7e1126_52b70d86","updated":"2015-12-19 05:59:27.000000000","message":"I\u0027ve explained my concern at PS-14 L180.","commit_id":"f47cebd4730c3ecf4b69cc8e7cccaf9652f85409"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"bad1372bda8faba62e4e82ef706bb98b8315354f","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            LOG.exception(_LE(\u0027Synchronizing networks from neutron server \u0027"},{"line_number":177,"context_line":"                         \u0027fail complete. Please reconfig the configuration \u0027"},{"line_number":178,"context_line":"                         \u0027named sync_networks_max_chunk_size in the dhcp \u0027"},{"line_number":179,"context_line":"                         \u0027configure file.\u0027))"},{"line_number":180,"context_line":"        except Exception as e:"},{"line_number":181,"context_line":"            if only_nets:"},{"line_number":182,"context_line":"                for network_id in only_nets:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a7e1126_52b70d86","line":179,"range":{"start_line":179,"start_character":40,"end_line":179,"end_character":44},"in_reply_to":"3a7e1126_5530739e","updated":"2015-12-18 02:19:49.000000000","message":"to be honest, i think there should be reduce \"sync_networks_max_chunk_size\", just like https://review.openstack.org/#/c/234067/12/neutron/agent/l3/agent.py L574 does","commit_id":"f47cebd4730c3ecf4b69cc8e7cccaf9652f85409"}],"neutron/agent/dhcp/config.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"f3aa72f5addf6f4515b2025f4094feb8097e846d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"               default\u003d256,"},{"line_number":62,"context_line":"               help\u003d_(\u0027Max number of networks to fetch from neutron server \u0027"},{"line_number":63,"context_line":"                      \u0027at a time on sync. This value needed to reduce load \u0027"},{"line_number":64,"context_line":"                      \u0027to speed up resync on agent side.\u0027)),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027sync_networks_min_chunk_size\u0027,"},{"line_number":66,"context_line":"               default\u003d32,"},{"line_number":67,"context_line":"               help\u003d_(\u0027Min number of networks to sync from neutron server.\u0027))"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a7e1126_9d6ac419","line":64,"range":{"start_line":64,"start_character":35,"end_line":64,"end_character":41},"updated":"2015-12-17 04:29:59.000000000","message":"Are you sure this will speed up the resync on agent side? \n\nThe total amount of the data is not change and the num of rpc calls are increased, so I will not expect the resync will speed up.","commit_id":"c487e04dae18a6f5fba0c63d3c44539ae6f2f7a6"},{"author":{"_account_id":19575,"name":"carl","email":"gsl0610@163.com","username":"carlgao"},"change_message_id":"14cde957fc76c12f1a6f1bd0eaa1aacc458ea171","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                      \u0027Should not exceed connection pool size configured on \u0027"},{"line_number":59,"context_line":"                      \u0027server.\u0027)),"},{"line_number":60,"context_line":"    cfg.IntOpt(\u0027sync_networks_max_chunk_size\u0027,"},{"line_number":61,"context_line":"               default\u003d256,"},{"line_number":62,"context_line":"               help\u003d_(\u0027Max number of networks to fetch from neutron server \u0027"},{"line_number":63,"context_line":"                      \u0027at a time on sync. This value should be reconfigured \u0027"},{"line_number":64,"context_line":"                      \u0027when MessagingTimeout exception happens on agent \u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a7e1126_7dd1b556","line":61,"range":{"start_line":61,"start_character":23,"end_line":61,"end_character":26},"updated":"2015-12-18 14:11:27.000000000","message":"Did you make a testing with 256?","commit_id":"f47cebd4730c3ecf4b69cc8e7cccaf9652f85409"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"ed6d2b51c4563390bac9815f4e60ab4d4c7853c0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"               default\u003d256,"},{"line_number":62,"context_line":"               help\u003d_(\u0027Max number of networks to fetch from neutron server \u0027"},{"line_number":63,"context_line":"                      \u0027at a time on sync. This value should be reconfigured \u0027"},{"line_number":64,"context_line":"                      \u0027when MessagingTimeout exception happens on agent \u0027"},{"line_number":65,"context_line":"                      \u0027side.\u0027))"},{"line_number":66,"context_line":"]"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3a7e1126_1080b945","line":64,"range":{"start_line":64,"start_character":23,"end_line":64,"end_character":71},"updated":"2015-12-17 16:24:14.000000000","message":"What do you mean \"when MessagingTimeout exception happens on agent\" ?\n\nAlways happened or just for a single case ?","commit_id":"f47cebd4730c3ecf4b69cc8e7cccaf9652f85409"}],"neutron/api/rpc/handlers/dhcp_rpc.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"4a717abdd12b073c202871299bed1b88da82c1ac","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":178,"context_line":"        plugin.delete_ports_by_device_id(context, device_id, network_id)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def get_networks_list_info(self, context, **kwargs):"},{"line_number":181,"context_line":"        \"\"\"Retrieve and return a extended infomation about given networks.\"\"\""},{"line_number":182,"context_line":"        network_ids \u003d kwargs.get(\u0027network_ids\u0027)"},{"line_number":183,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a710552_8b74a59c","line":180,"updated":"2015-12-15 09:38:49.000000000","message":"This method is mostly copied from \"get_active_networks_info\", consider to use the old one, instead of creating new one.","commit_id":"231fc9bed4413f261b87f25e42cee72a6f75cfb7"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7fde589c10a9a36cf562a166e7dc857350873c24","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                context, host)"},{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            network_ids \u003d kwargs.get(\u0027filters\u0027)"},{"line_number":79,"context_line":"            filters \u003d dict(admin_state_up\u003d[True]).update({\"id\": network_ids})"},{"line_number":80,"context_line":"            nets \u003d plugin.get_networks(context, filters\u003dfilters)"},{"line_number":81,"context_line":"        return nets"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a710552_0de65bb4","line":79,"updated":"2015-12-16 00:16:43.000000000","message":"???\n\nfilters is None because dict.update returns nothing","commit_id":"5ac37db591b5b715920e30380f7aad58a9df7742"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e3003e45027519d6a9ae43a5a1587c42eb1329a5","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":179,"context_line":"        plugin.delete_ports_by_device_id(context, device_id, network_id)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def get_networks_list_info(self, context, **kwargs):"},{"line_number":182,"context_line":"        \"\"\"Retrieve and return a extended infomation about given networks.\"\"\""},{"line_number":183,"context_line":"        network_ids \u003d kwargs.get(\u0027network_ids\u0027)"},{"line_number":184,"context_line":"        networks \u003d self.get_active_networks_info(context,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_bff3ac09","line":181,"updated":"2015-12-16 01:46:03.000000000","message":"I think this method is no longer needed, the rpc call to current \"get_active_networks_info\"(with proper arguments) can meet your requirement.","commit_id":"a67ad2d94719d2d1bd901103a7d094eaec89acb9"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"fbcdb4143d61887dc2a0f5fa6759c0e634b246c8","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":179,"context_line":"        plugin.delete_ports_by_device_id(context, device_id, network_id)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def get_networks_list_info(self, context, **kwargs):"},{"line_number":182,"context_line":"        \"\"\"Retrieve and return a extended infomation about given networks.\"\"\""},{"line_number":183,"context_line":"        network_ids \u003d kwargs.get(\u0027network_ids\u0027)"},{"line_number":184,"context_line":"        networks \u003d self.get_active_networks_info(context,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_df479875","line":181,"in_reply_to":"5a710552_bff3ac09","updated":"2015-12-16 02:05:35.000000000","message":"thanks for your comments, i have removed it in latest patch","commit_id":"a67ad2d94719d2d1bd901103a7d094eaec89acb9"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"b6af3ec7ecf6d3b1620a9b2c58b7608d71397a06","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    def get_active_networks(self, context, **kwargs):"},{"line_number":113,"context_line":"        \"\"\"Retrieve and return a list of the active network ids.\"\"\""},{"line_number":114,"context_line":"        # NOTE(arosen): This method is no longer used by the DHCP agent but is"},{"line_number":115,"context_line":"        # left so that neutron-dhcp-agents will still continue to work if"},{"line_number":116,"context_line":"        # neutron-server is upgraded and not the agent."},{"line_number":117,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":118,"context_line":"        LOG.debug(\u0027get_active_networks requested from %s\u0027, host)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a710552_92801e48","line":115,"updated":"2015-12-16 07:23:34.000000000","message":"I think you need update the comments here before going use method get_active_networks in agent side, and I also think this method name is confusing, it\u0027s trying to get network ids, not networks themselves, so maybe get_active_network_ids is better.","commit_id":"975c52bf3e7d5d65b5044a6711f7168d54bafdd4"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"85656e6af849e771e3d8df4276525fc7923995cf","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    def get_active_networks(self, context, **kwargs):"},{"line_number":113,"context_line":"        \"\"\"Retrieve and return a list of the active network ids.\"\"\""},{"line_number":114,"context_line":"        # NOTE(arosen): This method is no longer used by the DHCP agent but is"},{"line_number":115,"context_line":"        # left so that neutron-dhcp-agents will still continue to work if"},{"line_number":116,"context_line":"        # neutron-server is upgraded and not the agent."},{"line_number":117,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":118,"context_line":"        LOG.debug(\u0027get_active_networks requested from %s\u0027, host)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a710552_5d096730","line":115,"in_reply_to":"5a710552_92801e48","updated":"2015-12-16 08:08:33.000000000","message":"i agree with you","commit_id":"975c52bf3e7d5d65b5044a6711f7168d54bafdd4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"44be04db476aef23a1c1006f53f60a6523b9ebd0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            nets \u003d plugin.list_active_networks_on_active_dhcp_agent("},{"line_number":76,"context_line":"                context, host)"},{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            network_ids \u003d kwargs.get(\u0027filters\u0027)"},{"line_number":79,"context_line":"            filters \u003d dict(admin_state_up\u003d[True], id\u003dnetwork_ids)"},{"line_number":80,"context_line":"            nets \u003d plugin.get_networks(context, filters\u003dfilters)"},{"line_number":81,"context_line":"        return nets"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a7e1126_27ee2123","line":78,"updated":"2015-12-17 02:25:08.000000000","message":"This doesn\u0027t look right, the id\u0027s would be in the filter, right?","commit_id":"924392ef5fad6587bd4230ff0178168650597783"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"b9ffcc78d330e7402082d6acf0c8b46660b6d603","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            nets \u003d plugin.list_active_networks_on_active_dhcp_agent("},{"line_number":76,"context_line":"                context, host)"},{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            network_ids \u003d kwargs.get(\u0027filters\u0027)"},{"line_number":79,"context_line":"            filters \u003d dict(admin_state_up\u003d[True], id\u003dnetwork_ids)"},{"line_number":80,"context_line":"            nets \u003d plugin.get_networks(context, filters\u003dfilters)"},{"line_number":81,"context_line":"        return nets"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a7e1126_e22a472c","line":78,"in_reply_to":"3a7e1126_27ee2123","updated":"2015-12-17 03:10:55.000000000","message":"network ids in the param \"filters\". I think it is right. hm.... Where is wrong?","commit_id":"924392ef5fad6587bd4230ff0178168650597783"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"f3aa72f5addf6f4515b2025f4094feb8097e846d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            nets \u003d plugin.list_active_networks_on_active_dhcp_agent("},{"line_number":76,"context_line":"                context, host)"},{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            network_ids \u003d kwargs.get(\u0027filters\u0027)"},{"line_number":79,"context_line":"            filters \u003d dict(admin_state_up\u003d[True], id\u003dnetwork_ids)"},{"line_number":80,"context_line":"            nets \u003d plugin.get_networks(context, filters\u003dfilters)"},{"line_number":81,"context_line":"        return nets"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a7e1126_b8dc6e47","line":78,"range":{"start_line":78,"start_character":36,"end_line":78,"end_character":38},"updated":"2015-12-17 04:29:59.000000000","message":"See my comment in agent.py","commit_id":"c487e04dae18a6f5fba0c63d3c44539ae6f2f7a6"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"ed6d2b51c4563390bac9815f4e60ab4d4c7853c0","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def get_active_network_ids(self, context, **kwargs):"},{"line_number":113,"context_line":"        \"\"\"Retrieve and return a list of the active network ids.\"\"\""},{"line_number":114,"context_line":"        # NOTE(arosen): This method is no longer used by the DHCP agent but is"},{"line_number":115,"context_line":"        # left so that neutron-dhcp-agents will still continue to work if"},{"line_number":116,"context_line":"        # neutron-server is upgraded and not the agent."},{"line_number":117,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a7e1126_b5275711","line":114,"range":{"start_line":114,"start_character":31,"end_line":114,"end_character":52},"updated":"2015-12-17 16:24:14.000000000","message":"Please update comments here.","commit_id":"f47cebd4730c3ecf4b69cc8e7cccaf9652f85409"}],"neutron/tests/unit/agent/dhcp/test_agent.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"4a717abdd12b073c202871299bed1b88da82c1ac","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        with mock.patch(DHCP_PLUGIN) as plug:"},{"line_number":356,"context_line":"            mock_plugin \u003d mock.Mock()"},{"line_number":357,"context_line":"            mock_plugin.get_active_networks_info.return_value \u003d active_networks"},{"line_number":358,"context_line":"            mock_plugin.get_active_networks.return_value \u003d active_networks"},{"line_number":359,"context_line":"            mock_plugin.get_networks_list_info.return_value \u003d active_networks"},{"line_number":360,"context_line":"            plug.return_value \u003d mock_plugin"},{"line_number":361,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a710552_ebe4493c","line":358,"updated":"2015-12-15 09:38:49.000000000","message":"I don\u0027t think you want \"active_networks\" as return value here. As get_active_networks returns a list of uuid, \"active_networks\" here is a set of object.","commit_id":"231fc9bed4413f261b87f25e42cee72a6f75cfb7"}],"neutron/tests/unit/api/rpc/handlers/test_dhcp_rpc.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"44be04db476aef23a1c1006f53f60a6523b9ebd0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.plugin.get_networks.return_value \u003d plugin_retval"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        networks \u003d self.callbacks.get_active_network_ids(mock.Mock(),"},{"line_number":48,"context_line":"                                                         host\u003d\u0027host\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.assertEqual(networks, [\u0027a\u0027, \u0027b\u0027])"},{"line_number":51,"context_line":"        filters \u003d dict(admin_state_up\u003d[True], id\u003d[\u0027a\u0027, \u0027b\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a7e1126_c77b9d7a","line":48,"updated":"2015-12-17 02:25:08.000000000","message":"You\u0027re not passing any id\u0027s here, or \u0027filter\u0027, but you\u0027re expecting the calls to change?","commit_id":"924392ef5fad6587bd4230ff0178168650597783"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"667470c903e6722262fe5c54669f0f96a67f003e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.plugin.get_networks.return_value \u003d plugin_retval"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        networks \u003d self.callbacks.get_active_network_ids(mock.Mock(),"},{"line_number":48,"context_line":"                                                         host\u003d\u0027host\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.assertEqual(networks, [\u0027a\u0027, \u0027b\u0027])"},{"line_number":51,"context_line":"        filters \u003d dict(admin_state_up\u003d[True], id\u003d[\u0027a\u0027, \u0027b\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a7e1126_826d8334","line":48,"in_reply_to":"3a7e1126_c77b9d7a","updated":"2015-12-17 03:20:57.000000000","message":"did you mean there should be like this?\n    \n    networks \u003d self.callbacks.get_active_network_ids(mock.Mock(),\n                                                         host\u003d\u0027host\u0027, filters\u003d[\u0027a\u0027, \u0027b\u0027])","commit_id":"924392ef5fad6587bd4230ff0178168650597783"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"b9ffcc78d330e7402082d6acf0c8b46660b6d603","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.plugin.get_networks.return_value \u003d plugin_retval"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        networks \u003d self.callbacks.get_active_network_ids(mock.Mock(),"},{"line_number":48,"context_line":"                                                         host\u003d\u0027host\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.assertEqual(networks, [\u0027a\u0027, \u0027b\u0027])"},{"line_number":51,"context_line":"        filters \u003d dict(admin_state_up\u003d[True], id\u003d[\u0027a\u0027, \u0027b\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a7e1126_62ee57ee","line":48,"in_reply_to":"3a7e1126_c77b9d7a","updated":"2015-12-17 03:10:55.000000000","message":"the method \"get_active_network_ids\" returns all the network ids. Is not right there?","commit_id":"924392ef5fad6587bd4230ff0178168650597783"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"ed6d2b51c4563390bac9815f4e60ab4d4c7853c0","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.utils_p \u003d mock.patch(\u0027neutron.plugins.common.utils.create_port\u0027)"},{"line_number":41,"context_line":"        self.utils \u003d self.utils_p.start()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_get_active_networks(self):"},{"line_number":44,"context_line":"        plugin_retval \u003d [dict(id\u003d\u0027a\u0027), dict(id\u003d\u0027b\u0027)]"},{"line_number":45,"context_line":"        net_ids \u003d [\u0027a\u0027, \u0027b\u0027]"},{"line_number":46,"context_line":"        self.plugin.get_networks.return_value \u003d plugin_retval"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a7e1126_153f4bd7","line":43,"range":{"start_line":43,"start_character":13,"end_line":43,"end_character":32},"updated":"2015-12-17 16:24:14.000000000","message":"No such a method anymore.","commit_id":"f47cebd4730c3ecf4b69cc8e7cccaf9652f85409"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"cca4b57706e70c2dcf044413d372f6f7b0576135","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.utils_p \u003d mock.patch(\u0027neutron.plugins.common.utils.create_port\u0027)"},{"line_number":41,"context_line":"        self.utils \u003d self.utils_p.start()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_get_active_networks(self):"},{"line_number":44,"context_line":"        plugin_retval \u003d [dict(id\u003d\u0027a\u0027), dict(id\u003d\u0027b\u0027)]"},{"line_number":45,"context_line":"        net_ids \u003d [\u0027a\u0027, \u0027b\u0027]"},{"line_number":46,"context_line":"        self.plugin.get_networks.return_value \u003d plugin_retval"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a7e1126_8302096e","line":43,"range":{"start_line":43,"start_character":13,"end_line":43,"end_character":32},"in_reply_to":"3a7e1126_153f4bd7","updated":"2015-12-18 04:06:22.000000000","message":"why?","commit_id":"f47cebd4730c3ecf4b69cc8e7cccaf9652f85409"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"ff19e32d1769f4fe1b37c513a4f8f0fb35fffcbd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.utils_p \u003d mock.patch(\u0027neutron.plugins.common.utils.create_port\u0027)"},{"line_number":41,"context_line":"        self.utils \u003d self.utils_p.start()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_get_active_networks(self):"},{"line_number":44,"context_line":"        plugin_retval \u003d [dict(id\u003d\u0027a\u0027), dict(id\u003d\u0027b\u0027)]"},{"line_number":45,"context_line":"        net_ids \u003d [\u0027a\u0027, \u0027b\u0027]"},{"line_number":46,"context_line":"        self.plugin.get_networks.return_value \u003d plugin_retval"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a7e1126_dea0e6a1","line":43,"range":{"start_line":43,"start_character":13,"end_line":43,"end_character":32},"in_reply_to":"3a7e1126_8302096e","updated":"2015-12-19 05:59:27.000000000","message":"Check your own code changing....\n\nIn https://review.openstack.org/#/c/257100/15/neutron/api/rpc/handlers/dhcp_rpc.py or L48.","commit_id":"f47cebd4730c3ecf4b69cc8e7cccaf9652f85409"}]}
