)]}'
{"neutron/tests/functional/agent/l2/base.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b502606f20bd840513b92e9c94294ad12773d187","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        def stop_agent_and_polling(agent, polling_manager, rpc_thread):"},{"line_number":160,"context_line":"            agent.run_daemon_loop \u003d False"},{"line_number":161,"context_line":"            rpc_thread.wait()"},{"line_number":162,"context_line":"            if polling_manager._monitor.is_active():"},{"line_number":163,"context_line":"                polling_manager.stop()"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        self.addCleanup(stop_agent_and_polling, agent, polling_manager, t)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_5a0a16d4","line":162,"updated":"2015-12-15 03:48:10.000000000","message":"have you considered to put this check in stop() itself?","commit_id":"11c89e67b47bdbab05b3f24f50b322d29c1c1581"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"2915765085f1b3affafa191c74dd29e14c0f287f","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        def stop_agent_and_polling(agent, polling_manager, rpc_thread):"},{"line_number":160,"context_line":"            agent.run_daemon_loop \u003d False"},{"line_number":161,"context_line":"            rpc_thread.wait()"},{"line_number":162,"context_line":"            if polling_manager._monitor.is_active():"},{"line_number":163,"context_line":"                polling_manager.stop()"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        self.addCleanup(stop_agent_and_polling, agent, polling_manager, t)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_34ebede0","line":162,"in_reply_to":"5a710552_5a0a16d4","updated":"2015-12-21 12:51:08.000000000","message":"yes but didn\u0027t do that because AsyncProcess.stop() explicitly throws an exception if the process is not running. Anyway the code would probably be cleaner. Let\u0027s do that!","commit_id":"11c89e67b47bdbab05b3f24f50b322d29c1c1581"}]}