)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18573,"name":"Petri Kemppainen","email":"petri.kemppainen@nokia.com","username":"petrkemp"},"change_message_id":"d8c6f23d547690d40e8a067a0d9105768f75166c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2015-12-14 20:05:45 +0900"},{"line_number":4,"context_line":"Commit:     Kazuhiro Suzuki \u003ckaz@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-14 20:24:19 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add reserved stamps to notify flows created by other than ovs agent."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Flows without a stamp shoud not be deleted by ovs agent."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_0bfb247a","line":6,"updated":"2015-12-14 11:57:48.000000000","message":"The first line should be limited to 50 characters and should not end with a period.","commit_id":"76321542c5aa571a953302aa2017a9345d3f05c5"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8e1bb76277c26dc33bcb73dbbc2aa49c8bf078f6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"agent."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iab3dd8e48fd2f707c1253832c5f4394a3169163a"},{"line_number":14,"context_line":"Closes-Bug: #1514056"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_2eccee87","line":14,"updated":"2015-12-14 12:19:50.000000000","message":"i don\u0027t think this change fixes this bug.","commit_id":"76321542c5aa571a953302aa2017a9345d3f05c5"},{"author":{"_account_id":18573,"name":"Petri Kemppainen","email":"petri.kemppainen@nokia.com","username":"petrkemp"},"change_message_id":"0200b9290bd320362658007e5f03075e71e9d70a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2015-12-14 20:05:45 +0900"},{"line_number":4,"context_line":"Commit:     Kazuhiro Suzuki \u003ckaz@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-14 23:48:03 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add reserved stamps to notify flows created by other than ovs agent."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Flows without a stamp shoud not be deleted by ovs agent."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a710552_94d5ae44","line":6,"updated":"2015-12-15 07:43:17.000000000","message":"The first line should be limited to 50 characters and should not end with a period. See https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"5672c2d8482d1e70b2582d7c0632a56a19d53bcd"},{"author":{"_account_id":18573,"name":"Petri Kemppainen","email":"petri.kemppainen@nokia.com","username":"petrkemp"},"change_message_id":"633aafdbebba9de5e51a25d215024118b8290a35","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kazuhiro Suzuki \u003ckaz@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-22 14:36:23 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add reserved stamps to notify flows created by other than ovs agent."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Flows without a stamp shoud not be deleted by ovs agent."},{"line_number":10,"context_line":"This patch modifies not to delete flows created by other than ovs"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a7e1126_54c20b54","line":7,"range":{"start_line":7,"start_character":67,"end_line":7,"end_character":68},"updated":"2015-12-22 10:42:31.000000000","message":"Please remove \u0027.\u0027","commit_id":"de0ca8fa65baf4facf56c411b38cc30d1f952c1e"}],"neutron/plugins/ml2/drivers/openvswitch/agent/common/constants.py":[{"author":{"_account_id":18573,"name":"Petri Kemppainen","email":"petri.kemppainen@nokia.com","username":"petrkemp"},"change_message_id":"d8c6f23d547690d40e8a067a0d9105768f75166c","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"MAX_DEVICE_RETRIES \u003d 5"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Reserved stamps to notify flows created by other than ovs agent."},{"line_number":111,"context_line":"# This value is set as cookie of a flow. "},{"line_number":112,"context_line":"# Currently, only the default value (0x0) is contained."},{"line_number":113,"context_line":"# Coordination is required to avoid conflict of cookie with neutron"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_0b4244ae","line":110,"updated":"2015-12-14 11:57:48.000000000","message":"Please remove space from the end of the line","commit_id":"76321542c5aa571a953302aa2017a9345d3f05c5"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8e1bb76277c26dc33bcb73dbbc2aa49c8bf078f6","unresolved":false,"context_lines":[{"line_number":112,"context_line":"# Currently, only the default value (0x0) is contained."},{"line_number":113,"context_line":"# Coordination is required to avoid conflict of cookie with neutron"},{"line_number":114,"context_line":"# subprojects."},{"line_number":115,"context_line":"OVS_RESERVED_STAMPS \u003d [ 0x0 ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_aebf7ece","line":115,"updated":"2015-12-14 12:19:50.000000000","message":"it would preserve flows installed by older versions of ovs-agent, which doesn\u0027t use cookies for this purpose.","commit_id":"76321542c5aa571a953302aa2017a9345d3f05c5"},{"author":{"_account_id":18573,"name":"Petri Kemppainen","email":"petri.kemppainen@nokia.com","username":"petrkemp"},"change_message_id":"0200b9290bd320362658007e5f03075e71e9d70a","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"MAX_DEVICE_RETRIES \u003d 5"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Reserved stamps to notify flows created by other than ovs agent."},{"line_number":111,"context_line":"# This value is set as cookie of a flow. "},{"line_number":112,"context_line":"# Currently, only the default value (0x0) is contained."},{"line_number":113,"context_line":"# Coordination is required to avoid conflict of cookie with neutron"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_542bc630","line":110,"updated":"2015-12-15 07:43:17.000000000","message":"Please remove space from the end of the line","commit_id":"5672c2d8482d1e70b2582d7c0632a56a19d53bcd"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"3897157a69d658acdea8567dc557caa1f435b26c","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"MAX_DEVICE_RETRIES \u003d 5"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Reserved stamps to notify flows created by other than ovs agent."},{"line_number":111,"context_line":"# This value is set as cookie of a flow."},{"line_number":112,"context_line":"# Currently, only tentative value (0xFFFFFFFFFFFFFFFF) is contained."},{"line_number":113,"context_line":"# Coordination is required to avoid conflict of cookie with neutron"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_bb131a64","line":110,"updated":"2015-12-22 12:48:03.000000000","message":"I\u0027d add a note saying that flow created using this cookie are meant to be cleaned up by the creator, the OVS agent won\u0027t take care of that. Anyway we should document that somewhere, devref is a good place for that","commit_id":"de0ca8fa65baf4facf56c411b38cc30d1f952c1e"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5fa4de10425c3672ba4e0650237216ab0ca5082d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"# Reserved stamps to notify flows created by other than ovs agent."},{"line_number":111,"context_line":"# This value is set as cookie of a flow."},{"line_number":112,"context_line":"# Currently, only tentative value (0xFFFFFFFFFFFFFFFF) is contained."},{"line_number":113,"context_line":"# Coordination is required to avoid conflict of cookie with neutron"},{"line_number":114,"context_line":"# subprojects."},{"line_number":115,"context_line":"OVS_RESERVED_STAMP \u003d 0xFFFFFFFFFFFFFFFF"},{"line_number":116,"context_line":"OVS_RESERVED_STAMPS \u003d [OVS_RESERVED_STAMP]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_b2703673","line":113,"updated":"2016-01-07 02:30:22.000000000","message":"What if a subproject wants to have similar flow recovery logic as the neutron agent? It seems that having them all use the same cookie is going to be limiting.\n\nWhat if we dedicate a new table to act as a registration place for cookies used by other agents? Then the OVS agent could scan that table and store all of the cookies in that table and ignore any flows in the rest of the tables that match those cookies.","commit_id":"de0ca8fa65baf4facf56c411b38cc30d1f952c1e"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"3897157a69d658acdea8567dc557caa1f435b26c","unresolved":false,"context_lines":[{"line_number":110,"context_line":"# Reserved stamps to notify flows created by other than ovs agent."},{"line_number":111,"context_line":"# This value is set as cookie of a flow."},{"line_number":112,"context_line":"# Currently, only tentative value (0xFFFFFFFFFFFFFFFF) is contained."},{"line_number":113,"context_line":"# Coordination is required to avoid conflict of cookie with neutron"},{"line_number":114,"context_line":"# subprojects."},{"line_number":115,"context_line":"OVS_RESERVED_STAMP \u003d 0xFFFFFFFFFFFFFFFF"},{"line_number":116,"context_line":"OVS_RESERVED_STAMPS \u003d [OVS_RESERVED_STAMP]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_7b529268","line":113,"updated":"2015-12-22 12:48:03.000000000","message":"why do we need coordination? If we use a special cookie for flows that are not supposed to be cleaned up, every subproject can use the same one, the OVS agent won\u0027t delete those flows. No need to differentiate between flows installed by different subprojects.","commit_id":"de0ca8fa65baf4facf56c411b38cc30d1f952c1e"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"3897157a69d658acdea8567dc557caa1f435b26c","unresolved":false,"context_lines":[{"line_number":112,"context_line":"# Currently, only tentative value (0xFFFFFFFFFFFFFFFF) is contained."},{"line_number":113,"context_line":"# Coordination is required to avoid conflict of cookie with neutron"},{"line_number":114,"context_line":"# subprojects."},{"line_number":115,"context_line":"OVS_RESERVED_STAMP \u003d 0xFFFFFFFFFFFFFFFF"},{"line_number":116,"context_line":"OVS_RESERVED_STAMPS \u003d [OVS_RESERVED_STAMP]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_fb68c2f6","line":115,"updated":"2015-12-22 12:48:03.000000000","message":"can we use something like \"DONT_DELETE_COOKIE\" ? Why are you using the word \"stamp\" instead of cookie? That\u0027s not clear to me.","commit_id":"de0ca8fa65baf4facf56c411b38cc30d1f952c1e"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"3897157a69d658acdea8567dc557caa1f435b26c","unresolved":false,"context_lines":[{"line_number":113,"context_line":"# Coordination is required to avoid conflict of cookie with neutron"},{"line_number":114,"context_line":"# subprojects."},{"line_number":115,"context_line":"OVS_RESERVED_STAMP \u003d 0xFFFFFFFFFFFFFFFF"},{"line_number":116,"context_line":"OVS_RESERVED_STAMPS \u003d [OVS_RESERVED_STAMP]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_9b9dfe0b","line":116,"updated":"2015-12-22 12:48:03.000000000","message":"YAGNI why do we need a plural?","commit_id":"de0ca8fa65baf4facf56c411b38cc30d1f952c1e"}],"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/ofswitch.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"3897157a69d658acdea8567dc557caa1f435b26c","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            # Do not delete a flow which was added by other than ovs"},{"line_number":145,"context_line":"            # agent."},{"line_number":146,"context_line":"            if c in constants.OVS_RESERVED_STAMPS:"},{"line_number":147,"context_line":"                LOG.debug(\"Reserved stamp is used: 0x%x\", c)"},{"line_number":148,"context_line":"                continue"},{"line_number":149,"context_line":"            LOG.warn(_LW(\"Deleting flow with cookie 0x%(cookie)x\") % {"},{"line_number":150,"context_line":"                \u0027cookie\u0027: c})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_9be65eae","line":147,"updated":"2015-12-22 12:48:03.000000000","message":"s/stamp/cookie ?","commit_id":"de0ca8fa65baf4facf56c411b38cc30d1f952c1e"}],"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/ovs_ofctl/ofswitch.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8e1bb76277c26dc33bcb73dbbc2aa49c8bf078f6","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                fl_table \u003d fl_table.group(1)"},{"line_number":109,"context_line":"                yield flow, fl_cookie, fl_table"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def cleanup_flows(self):"},{"line_number":112,"context_line":"        flows \u003d self.dump_flows_all_tables()"},{"line_number":113,"context_line":"        for flow, cookie, table in self._filter_flows(flows):"},{"line_number":114,"context_line":"            # deleting a stale flow should be rare."}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_0ecd7265","line":111,"updated":"2015-12-14 12:19:50.000000000","message":"please update openflow/native/ variant as well.","commit_id":"76321542c5aa571a953302aa2017a9345d3f05c5"}]}