)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18573,"name":"Petri Kemppainen","email":"petri.kemppainen@nokia.com","username":"petrkemp"},"change_message_id":"3652e37455c2ea65eb8edcaed842eb0c4d81522e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2015-12-15 16:05:11 +0800"},{"line_number":4,"context_line":"Commit:     zhang sheng \u003clangyxxl@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-15 19:24:15 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Filter dvr mode l3-agent when neutron server schedule ha router to additional agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when dvr mode l3-agent run sync_router, neutron server will bind ha router"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a710552_82831ecc","line":6,"updated":"2015-12-15 12:45:45.000000000","message":"The first line should be limited to 50 characters.","commit_id":"185fc94f81aba8054c6dd8af6fa081c45887a5bf"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"58fb6b1b95ba2b15f6fad0fcf6d14d8d5a1406ba","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhang sheng \u003clangyxxl@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-15 19:24:15 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Filter dvr mode l3-agent when neutron server schedule ha router to additional agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when dvr mode l3-agent run sync_router, neutron server will bind ha router"},{"line_number":10,"context_line":"to this agent if ha router hasn\u0027t reach max_l3_agents_per_router setting in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a710552_3d97bb49","line":7,"updated":"2015-12-16 08:00:27.000000000","message":"You can take this [1] as reference, it helps me a lot with my first patch.\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Examples_of_bad_practice","commit_id":"185fc94f81aba8054c6dd8af6fa081c45887a5bf"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5255aab0e37844b75e5c933090cad830ab4176c4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when dvr mode l3-agent run sync_router, neutron server will bind ha router"},{"line_number":10,"context_line":"to this agent if ha router hasn\u0027t reach max_l3_agents_per_router setting in"},{"line_number":11,"context_line":"neutron.conf. This will cause ha router run in computer nodes."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I769b79bc7e53219cca1a416313cf4d50c1fb1b13"},{"line_number":14,"context_line":"Closes-Bug: #1526175"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_73e4e03a","line":11,"updated":"2015-12-17 05:55:31.000000000","message":"+1","commit_id":"185fc94f81aba8054c6dd8af6fa081c45887a5bf"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"9f709753ed0ae4c96668fd6a00267f2f48b628d4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when dvr mode l3-agent run sync_router, neutron server will bind ha router"},{"line_number":10,"context_line":"to this agent if ha router hasn\u0027t reach max_l3_agents_per_router setting in"},{"line_number":11,"context_line":"neutron.conf. This will cause ha router run in computer nodes."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I769b79bc7e53219cca1a416313cf4d50c1fb1b13"},{"line_number":14,"context_line":"Closes-Bug: #1526175"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a710552_f86dc198","line":11,"updated":"2015-12-16 08:15:24.000000000","message":"I think the point we should care is ha router running on compute nodes or not, but ha router will be bound to a dvr mode L3 agent.","commit_id":"185fc94f81aba8054c6dd8af6fa081c45887a5bf"}],"neutron/scheduler/l3_agent_scheduler.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5255aab0e37844b75e5c933090cad830ab4176c4","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        if not unscheduled_routers:"},{"line_number":151,"context_line":"            if utils.is_extension_supported("},{"line_number":152,"context_line":"                    plugin, constants.L3_HA_MODE_EXT_ALIAS):"},{"line_number":153,"context_line":"                agent_conf \u003d plugin.get_configuration_dict(l3_agent)"},{"line_number":154,"context_line":"                agent_mode \u003d agent_conf.get(constants.L3_AGENT_MODE,"},{"line_number":155,"context_line":"                                        constants.L3_AGENT_MODE_LEGACY)"},{"line_number":156,"context_line":"                if agent_mode in ("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_13d0fc52","line":153,"updated":"2015-12-17 05:55:31.000000000","message":"I think this patch will become a lot shorter if you just early return right here:\n\n  if agent_conf.get(constants.L3_AGENT_MODE) \u003d\u003d contants.L3_AGENT_MODE_DVR:\n      return False","commit_id":"185fc94f81aba8054c6dd8af6fa081c45887a5bf"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"58fb6b1b95ba2b15f6fad0fcf6d14d8d5a1406ba","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                    plugin, constants.L3_HA_MODE_EXT_ALIAS):"},{"line_number":153,"context_line":"                agent_conf \u003d plugin.get_configuration_dict(l3_agent)"},{"line_number":154,"context_line":"                agent_mode \u003d agent_conf.get(constants.L3_AGENT_MODE,"},{"line_number":155,"context_line":"                                        constants.L3_AGENT_MODE_LEGACY)"},{"line_number":156,"context_line":"                if agent_mode in ("},{"line_number":157,"context_line":"                constants.L3_AGENT_MODE_LEGACY,"},{"line_number":158,"context_line":"                constants.L3_AGENT_MODE_DVR_SNAT):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_7db1c3e0","line":155,"updated":"2015-12-16 08:00:27.000000000","message":"aligning the arguments is needed here. If you are not sure about the format, there are lots of good example in current code.","commit_id":"185fc94f81aba8054c6dd8af6fa081c45887a5bf"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3981101ecb931ee5ac5f5507560fa19341774aa3","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                    plugin, constants.L3_HA_MODE_EXT_ALIAS):"},{"line_number":153,"context_line":"                agent_conf \u003d plugin.get_configuration_dict(l3_agent)"},{"line_number":154,"context_line":"                agent_mode \u003d agent_conf.get(constants.L3_AGENT_MODE,"},{"line_number":155,"context_line":"                                        constants.L3_AGENT_MODE_LEGACY)"},{"line_number":156,"context_line":"                if agent_mode in ("},{"line_number":157,"context_line":"                constants.L3_AGENT_MODE_LEGACY,"},{"line_number":158,"context_line":"                constants.L3_AGENT_MODE_DVR_SNAT):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_140ac321","line":155,"updated":"2015-12-16 14:41:26.000000000","message":"in fact default constants.L3_AGENT_MODE_LEGACY is not needed here at all","commit_id":"185fc94f81aba8054c6dd8af6fa081c45887a5bf"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"9f709753ed0ae4c96668fd6a00267f2f48b628d4","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                    plugin, constants.L3_HA_MODE_EXT_ALIAS):"},{"line_number":153,"context_line":"                agent_conf \u003d plugin.get_configuration_dict(l3_agent)"},{"line_number":154,"context_line":"                agent_mode \u003d agent_conf.get(constants.L3_AGENT_MODE,"},{"line_number":155,"context_line":"                                        constants.L3_AGENT_MODE_LEGACY)"},{"line_number":156,"context_line":"                if agent_mode in ("},{"line_number":157,"context_line":"                constants.L3_AGENT_MODE_LEGACY,"},{"line_number":158,"context_line":"                constants.L3_AGENT_MODE_DVR_SNAT):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_ddcb171d","line":155,"in_reply_to":"5a710552_7db1c3e0","updated":"2015-12-16 08:15:24.000000000","message":"The following code seems better in indentation:\n    agent_mode \u003d agent_conf.get(constants.L3_AGENT_MODE,\n                                constants.L3_AGENT_MODE_LEGACY)","commit_id":"185fc94f81aba8054c6dd8af6fa081c45887a5bf"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"46240fa511c94d039b662243fe52b2f667f2a4c6","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                                        constants.L3_AGENT_MODE_LEGACY)"},{"line_number":156,"context_line":"                if agent_mode in ("},{"line_number":157,"context_line":"                constants.L3_AGENT_MODE_LEGACY,"},{"line_number":158,"context_line":"                constants.L3_AGENT_MODE_DVR_SNAT):"},{"line_number":159,"context_line":"                    return self._schedule_ha_routers_to_additional_agent("},{"line_number":160,"context_line":"                        plugin, context, l3_agent)"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_d4f31209","line":158,"updated":"2015-12-15 17:41:54.000000000","message":"nit: pls clean up the indentation here","commit_id":"185fc94f81aba8054c6dd8af6fa081c45887a5bf"}]}