)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"b9e39e0c007bfeaf09bc1f59f7ca41ea01564441","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sreekumar S \u003csreesiv@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-15 20:40:47 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"SIGHUP missed by child daemon process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This issue might be due to the service process missing the"},{"line_number":10,"context_line":"SIGHUP. This is reproducible locally when we set \u0027max pending"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_2e613ca9","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2015-12-22 05:16:00.000000000","message":"Pls add [WIP] or other tags in the title to avoid other reviewers being confused with the status of this patch.","commit_id":"67aa74914859ca224da099b3a11f2eee70b9653f"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"4957f8eb43d2faf01ad0486aac3cc6b746a51dc9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sreekumar S \u003csreesiv@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-15 20:40:47 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"SIGHUP missed by child daemon process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This issue might be due to the service process missing the"},{"line_number":10,"context_line":"SIGHUP. This is reproducible locally when we set \u0027max pending"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_6db8a711","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"in_reply_to":"3a7e1126_2e613ca9","updated":"2015-12-22 07:47:32.000000000","message":"This patch will in any case be abandoned. This is just to check the runs. \n\nHopefully they may try re-configuring the server, if the test is being moved as is. Otherwise that\u0027s also not needed. We may hit the same issue in some other test somewhere else :-)","commit_id":"67aa74914859ca224da099b3a11f2eee70b9653f"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"b2a3126744ff5abb3d40e9700360e667c8db1d9c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sreekumar S \u003csreesiv@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-15 20:40:47 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"SIGHUP missed by child daemon process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This issue might be due to the service process missing the"},{"line_number":10,"context_line":"SIGHUP. This is reproducible locally when we set \u0027max pending"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_d45b4d2d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"in_reply_to":"3a7e1126_2fa60554","updated":"2015-12-22 17:19:37.000000000","message":"Done","commit_id":"67aa74914859ca224da099b3a11f2eee70b9653f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"f053e427a1edfccd91b55b66870bc68c72354460","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sreekumar S \u003csreesiv@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-15 20:40:47 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"SIGHUP missed by child daemon process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This issue might be due to the service process missing the"},{"line_number":10,"context_line":"SIGHUP. This is reproducible locally when we set \u0027max pending"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_2fa60554","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"in_reply_to":"3a7e1126_6db8a711","updated":"2015-12-22 13:38:19.000000000","message":"No matter if the patch will be abandoned, your time spent on it is valuable. And if you want to provide something others can reference, then just test the \u0027ulimit\u0027 in this patch.","commit_id":"67aa74914859ca224da099b3a11f2eee70b9653f"}],"neutron/tests/functional/test_server.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"b9e39e0c007bfeaf09bc1f59f7ca41ea01564441","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            return workers"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # Wait for a service to start."},{"line_number":102,"context_line":"        utils.wait_until_true(self.health_checker, timeout\u003d100, sleep\u003d0.1,"},{"line_number":103,"context_line":"                              exception\u003dRuntimeError("},{"line_number":104,"context_line":"                                  \"Failed to start service.\"))"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_2e3a9c99","line":102,"range":{"start_line":102,"start_character":51,"end_line":102,"end_character":58},"updated":"2015-12-22 05:16:00.000000000","message":"If you are verifying that the root cause is the max pending signals configuration, you should not change the timeout. Otherwise, even if the test always passes, you will not be able to know which factor takes effect.","commit_id":"67aa74914859ca224da099b3a11f2eee70b9653f"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"4957f8eb43d2faf01ad0486aac3cc6b746a51dc9","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            return workers"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # Wait for a service to start."},{"line_number":102,"context_line":"        utils.wait_until_true(self.health_checker, timeout\u003d100, sleep\u003d0.1,"},{"line_number":103,"context_line":"                              exception\u003dRuntimeError("},{"line_number":104,"context_line":"                                  \"Failed to start service.\"))"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_4d612bd2","line":102,"range":{"start_line":102,"start_character":51,"end_line":102,"end_character":58},"in_reply_to":"3a7e1126_2e3a9c99","updated":"2015-12-22 07:47:32.000000000","message":"Both factors may affect the issue, that\u0027s why I\u0027ve kept like that. That\u0027s why I\u0027ve mentioned in the LP bug and here that, once the configuration is done the runs will be checked with  the call removed and timeout kept the same. Also this is per session call that is being tried.\n\nOnce the server is configured, I don\u0027t think delay changes will be required. However I am keeping the option open, that\u0027s all. Anyway since this test is being removed there is no need to worry though. The server change may be done if the same test is being moved to oslo tests.","commit_id":"67aa74914859ca224da099b3a11f2eee70b9653f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"f053e427a1edfccd91b55b66870bc68c72354460","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            return workers"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # Wait for a service to start."},{"line_number":102,"context_line":"        utils.wait_until_true(self.health_checker, timeout\u003d100, sleep\u003d0.1,"},{"line_number":103,"context_line":"                              exception\u003dRuntimeError("},{"line_number":104,"context_line":"                                  \"Failed to start service.\"))"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_cf774107","line":102,"range":{"start_line":102,"start_character":51,"end_line":102,"end_character":58},"in_reply_to":"3a7e1126_4d612bd2","updated":"2015-12-22 13:38:19.000000000","message":"From my understanding, the issue is time relative. Extend time here will low down the possibility of the appearance of the issue. \n\nAll your successful test are meaningless, no one know it is because you extend the time or you enlarge the threshold of num of signals.\n\nSo, if you really want to verify something and make something convincing, recover the timeout, and rerun the test.","commit_id":"67aa74914859ca224da099b3a11f2eee70b9653f"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"b2a3126744ff5abb3d40e9700360e667c8db1d9c","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            return workers"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # Wait for a service to start."},{"line_number":102,"context_line":"        utils.wait_until_true(self.health_checker, timeout\u003d100, sleep\u003d0.1,"},{"line_number":103,"context_line":"                              exception\u003dRuntimeError("},{"line_number":104,"context_line":"                                  \"Failed to start service.\"))"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_d424adb0","line":102,"range":{"start_line":102,"start_character":51,"end_line":102,"end_character":58},"in_reply_to":"3a7e1126_cf774107","updated":"2015-12-22 17:19:37.000000000","message":"Got your point. Done.","commit_id":"67aa74914859ca224da099b3a11f2eee70b9653f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"0327589d91ecc4366359e3e5190d3eb6ebe8964b","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        3. Wait for workers (if any) to (re)start."},{"line_number":139,"context_line":"        \"\"\""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        cmd \u003d [\u0027ulimit\u0027, \u0027-i\u0027, \u0027unlimited\u0027]"},{"line_number":142,"context_line":"        subprocess.call(cmd, shell\u003dTrue)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        self._start_server(callback\u003dservice, workers\u003dworkers)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_d7fc7d40","line":141,"updated":"2015-12-15 15:46:23.000000000","message":"The man page for ulimit says it\u0027s obsolete.","commit_id":"67aa74914859ca224da099b3a11f2eee70b9653f"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"aa3a70ad92c5b1c2a25198eb440eeb9b774b6fde","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        3. Wait for workers (if any) to (re)start."},{"line_number":139,"context_line":"        \"\"\""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        cmd \u003d [\u0027ulimit\u0027, \u0027-i\u0027, \u0027unlimited\u0027]"},{"line_number":142,"context_line":"        subprocess.call(cmd, shell\u003dTrue)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        self._start_server(callback\u003dservice, workers\u003dworkers)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_748c9e7f","line":141,"in_reply_to":"5a710552_d7fc7d40","updated":"2015-12-15 17:39:39.000000000","message":"This is intended to validate the test runs and not for check-in","commit_id":"67aa74914859ca224da099b3a11f2eee70b9653f"}]}
