)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"47c1530724dd3a29a0d221cf55ea3ea39ce3cbea","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bo Chi \u003cshcbo@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-16 06:19:51 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refactor test_validate_ip_address()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed many test cases to use a for loop"},{"line_number":10,"context_line":"Removed an useless mock assert"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a710552_f21e4262","line":7,"updated":"2015-12-16 07:20:54.000000000","message":"The first letter is usually capitalized","commit_id":"11fe00d7b4ec8774519dd4f97bd1da4129c37546"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"da2e6f74a2808ad8251d45274a568c35ca6ffa2c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bo Chi \u003cshcbo@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-16 06:19:51 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refactor test_validate_ip_address()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed many test cases to use a for loop"},{"line_number":10,"context_line":"Removed an useless mock assert"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a710552_5ce880b4","line":7,"in_reply_to":"5a710552_f21e4262","updated":"2015-12-16 10:55:37.000000000","message":"Done","commit_id":"11fe00d7b4ec8774519dd4f97bd1da4129c37546"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"47c1530724dd3a29a0d221cf55ea3ea39ce3cbea","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refactor test_validate_ip_address()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed many test cases to use a for loop"},{"line_number":10,"context_line":"Removed an useless mock assert"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I129e38721ca9d9cd28f10cda1c095ad54e743e8b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a710552_7221f29e","line":9,"updated":"2015-12-16 07:20:54.000000000","message":"This could be more specific, like why you do the change","commit_id":"11fe00d7b4ec8774519dd4f97bd1da4129c37546"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"da2e6f74a2808ad8251d45274a568c35ca6ffa2c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refactor test_validate_ip_address()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed many test cases to use a for loop"},{"line_number":10,"context_line":"Removed an useless mock assert"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I129e38721ca9d9cd28f10cda1c095ad54e743e8b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a710552_bce164d2","line":9,"in_reply_to":"5a710552_7221f29e","updated":"2015-12-16 10:55:37.000000000","message":"Done","commit_id":"11fe00d7b4ec8774519dd4f97bd1da4129c37546"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"f6082efb737e488bdaa5a39de314738eafee3155","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refactor test_validate_ip_address()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed many test cases to use a for loop"},{"line_number":10,"context_line":"Removed an useless mock assert"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I129e38721ca9d9cd28f10cda1c095ad54e743e8b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_c45a7b50","line":9,"in_reply_to":"5a710552_7221f29e","updated":"2015-12-17 16:04:11.000000000","message":"Seems \"This patch will change test cases for _validate_ip_address, with using a for loop, to remove duplicated assert\" explain more clear.","commit_id":"11fe00d7b4ec8774519dd4f97bd1da4129c37546"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"47c1530724dd3a29a0d221cf55ea3ea39ce3cbea","unresolved":false,"context_lines":[{"line_number":7,"context_line":"refactor test_validate_ip_address()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed many test cases to use a for loop"},{"line_number":10,"context_line":"Removed an useless mock assert"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I129e38721ca9d9cd28f10cda1c095ad54e743e8b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a710552_523716e3","line":10,"updated":"2015-12-16 07:20:54.000000000","message":"I remember there is a related bug, it should be recorded here.","commit_id":"11fe00d7b4ec8774519dd4f97bd1da4129c37546"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"da2e6f74a2808ad8251d45274a568c35ca6ffa2c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"refactor test_validate_ip_address()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed many test cases to use a for loop"},{"line_number":10,"context_line":"Removed an useless mock assert"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I129e38721ca9d9cd28f10cda1c095ad54e743e8b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a710552_9cdee80f","line":10,"in_reply_to":"5a710552_523716e3","updated":"2015-12-16 10:55:37.000000000","message":"Done","commit_id":"11fe00d7b4ec8774519dd4f97bd1da4129c37546"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"5fb8f3d75c2a6170fcc96116b17fc8bc0705f100","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bo Chi \u003cshcbo@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-05 06:32:19 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactor test_attributes.py (part 2)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch refactored repeated test cases with a for loop, to remove"},{"line_number":10,"context_line":"duplicated assert"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa69d971_0b3db2c3","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":35},"updated":"2016-01-05 06:21:50.000000000","message":"Given you are modifying one file with similar contents, why 2 parts are needed?","commit_id":"d5a87d94173ad96ae86b413e36e23f8959b40315"}],"neutron/tests/unit/api/v2/test_attributes.py":[{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"f6082efb737e488bdaa5a39de314738eafee3155","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        ip_addrs \u003d [\u00271111.1.1.1\u0027,"},{"line_number":240,"context_line":"                    # Depending on platform to run UTs, this case"},{"line_number":241,"context_line":"                    # might or might not be an equivalent to"},{"line_number":242,"context_line":"                    # test_validate_ip_address_bsd."},{"line_number":243,"context_line":"                    \u00271\u0027 * 59,"},{"line_number":244,"context_line":"                    \u00271.1.1.1 has whitespace\u0027,"},{"line_number":245,"context_line":"                    \u0027111.1.1.1\\twhitespace\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_bacbc652","line":242,"range":{"start_line":242,"start_character":50,"end_line":242,"end_character":51},"updated":"2015-12-17 16:04:11.000000000","message":"I don\u0027t think the comment here is necessary, it seems a comon failed case here. Or maybe you want a special case for non-BSD/OS X platform with \u00271\u0027 * 59.","commit_id":"11fe00d7b4ec8774519dd4f97bd1da4129c37546"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"fc4abb4540bad0897d8ed77287096463eeaa20ce","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        # \u00271\u0027 * 59 as a valid address.  The behaviour is inherited from"},{"line_number":273,"context_line":"        # libc behaviour there.  This test ensures that our validator reject"},{"line_number":274,"context_line":"        # such addresses on such platforms by mocking netaddr to emulate"},{"line_number":275,"context_line":"        # the behaviour."},{"line_number":276,"context_line":"        ip_addr \u003d \u00271\u0027 * 59"},{"line_number":277,"context_line":"        msg \u003d attributes._validate_ip_address(ip_addr)"},{"line_number":278,"context_line":"        self.assertEqual(\"\u0027%s\u0027 is not a valid IP address\" % ip_addr, msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_fdf7d788","line":275,"updated":"2015-12-16 16:00:42.000000000","message":"Modify this comment since you are no longer mocking netaddr (or see my comment below and maybe just remove this method and move the test to \u0027test_validate_ip_address\u0027","commit_id":"11fe00d7b4ec8774519dd4f97bd1da4129c37546"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"fc4abb4540bad0897d8ed77287096463eeaa20ce","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        # such addresses on such platforms by mocking netaddr to emulate"},{"line_number":275,"context_line":"        # the behaviour."},{"line_number":276,"context_line":"        ip_addr \u003d \u00271\u0027 * 59"},{"line_number":277,"context_line":"        msg \u003d attributes._validate_ip_address(ip_addr)"},{"line_number":278,"context_line":"        self.assertEqual(\"\u0027%s\u0027 is not a valid IP address\" % ip_addr, msg)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def test_validate_ip_pools(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_bda86f78","line":277,"updated":"2015-12-16 16:00:42.000000000","message":"I can\u0027t figure out what this test (which you removed) was actually testing by patching netaddr.IPAddress, even with the comment.  It does seem to be a useless test, but hopefully some other reviewer will be able to explain whether it makes sense to remove this mock.  If the mock can be removed, then this \u00271\u0027 * 59 address should just be added to the \u0027test_validate_ip_address\u0027 function above.","commit_id":"11fe00d7b4ec8774519dd4f97bd1da4129c37546"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4aa23b0adbbd49c69fe00656bdd0740b5acfd40d","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        # such addresses on such platforms by mocking netaddr to emulate"},{"line_number":275,"context_line":"        # the behaviour."},{"line_number":276,"context_line":"        ip_addr \u003d \u00271\u0027 * 59"},{"line_number":277,"context_line":"        msg \u003d attributes._validate_ip_address(ip_addr)"},{"line_number":278,"context_line":"        self.assertEqual(\"\u0027%s\u0027 is not a valid IP address\" % ip_addr, msg)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def test_validate_ip_pools(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_a7b0ca8c","line":277,"updated":"2015-12-17 05:30:33.000000000","message":"No, this can\u0027t be removed. What this is testing is L208 of attributes.py. netaddr is mocked because otherwide netaddr will be throwing an exception above that on non-BSD systems.\n\nOn BSD, netaddr would accept that address so we have that L208 check to make sure it wasn\u0027t a strange address accepted by netaddr that we actually don\u0027t want to deal with.","commit_id":"11fe00d7b4ec8774519dd4f97bd1da4129c37546"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"f6082efb737e488bdaa5a39de314738eafee3155","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        # such addresses on such platforms by mocking netaddr to emulate"},{"line_number":275,"context_line":"        # the behaviour."},{"line_number":276,"context_line":"        ip_addr \u003d \u00271\u0027 * 59"},{"line_number":277,"context_line":"        msg \u003d attributes._validate_ip_address(ip_addr)"},{"line_number":278,"context_line":"        self.assertEqual(\"\u0027%s\u0027 is not a valid IP address\" % ip_addr, msg)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def test_validate_ip_pools(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_1f5e8c76","line":277,"in_reply_to":"3a7e1126_a7b0ca8c","updated":"2015-12-17 16:04:11.000000000","message":"+1, without mock netaddr.IPAddress exception will raise on non-BSD systems, and for that, the left assert in this test cannot figure out which logic branch cause the invalid message.\n\nAnd as the test case method name shown, it\u0027s only for BSD(or OS X), it will be necessary to keep netaddr.IPAddress mock here to emulate BSD platform behavior.","commit_id":"11fe00d7b4ec8774519dd4f97bd1da4129c37546"}]}
