)]}'
{"neutron/tests/functional/db/test_migrations.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"df0608664a618b9703ca39e8bc5834928bb233ab","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def filter_metadata_diff(self, diff):"},{"line_number":136,"context_line":"        return list(filter(self.remove_unrelated_errors, diff))"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    # TODO(akamyshkova): remove this method as soon comparison with Variant"},{"line_number":139,"context_line":"    # will be implemented in oslo.db or alembic"},{"line_number":140,"context_line":"    def compare_type(self, ctxt, insp_col, meta_col, insp_type, meta_type):"},{"line_number":141,"context_line":"        \"\"\"Return True if types are different, False if not."}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_c647b649","line":138,"updated":"2015-12-16 12:53:05.000000000","message":"unless you changed your surname, I suspect there is a typo.","commit_id":"eafcea9db4b471b88732b85d35c19064b8b53a24"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"1c4bf6b2a7f723603afd32bbffea9b256a12ba88","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def filter_metadata_diff(self, diff):"},{"line_number":136,"context_line":"        return list(filter(self.remove_unrelated_errors, diff))"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    # TODO(akamyshkova): remove this method as soon comparison with Variant"},{"line_number":139,"context_line":"    # will be implemented in oslo.db or alembic"},{"line_number":140,"context_line":"    def compare_type(self, ctxt, insp_col, meta_col, insp_type, meta_type):"},{"line_number":141,"context_line":"        \"\"\"Return True if types are different, False if not."}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_f16e2e2e","line":138,"in_reply_to":"5a710552_c647b649","updated":"2015-12-16 13:17:10.000000000","message":"Done","commit_id":"eafcea9db4b471b88732b85d35c19064b8b53a24"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"69122f0f1159fe6a2f9db8e41163c249fdbdd361","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        BOOLEAN_METADATA \u003d (types.BOOLEAN, types.Boolean)"},{"line_number":152,"context_line":"        BOOLEAN_SQL \u003d BOOLEAN_METADATA + (types.INTEGER, types.Integer)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        if issubclass(type(meta_type), BOOLEAN_METADATA):"},{"line_number":155,"context_line":"            return not issubclass(type(insp_type), BOOLEAN_SQL)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # Workaroud for bug 1526675"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_0b094731","line":154,"updated":"2015-12-16 12:52:23.000000000","message":"instead of copy-pasting code, can\u0027t we somehow reuse what is in oslo.db? Like calling to super()?","commit_id":"eafcea9db4b471b88732b85d35c19064b8b53a24"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"1c4bf6b2a7f723603afd32bbffea9b256a12ba88","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        BOOLEAN_METADATA \u003d (types.BOOLEAN, types.Boolean)"},{"line_number":152,"context_line":"        BOOLEAN_SQL \u003d BOOLEAN_METADATA + (types.INTEGER, types.Integer)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        if issubclass(type(meta_type), BOOLEAN_METADATA):"},{"line_number":155,"context_line":"            return not issubclass(type(insp_type), BOOLEAN_SQL)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # Workaroud for bug 1526675"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_51ce22b5","line":154,"in_reply_to":"5a710552_0b094731","updated":"2015-12-16 13:17:10.000000000","message":"I hope that this won\u0027t stay here for a long time, that is why I just copy-paste this.","commit_id":"eafcea9db4b471b88732b85d35c19064b8b53a24"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"df0608664a618b9703ca39e8bc5834928bb233ab","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        if issubclass(type(meta_type), BOOLEAN_METADATA):"},{"line_number":155,"context_line":"            return not issubclass(type(insp_type), BOOLEAN_SQL)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # Workaroud for bug 1526675"},{"line_number":158,"context_line":"        if isinstance(meta_type, types.Variant):"},{"line_number":159,"context_line":"            meta_col.type \u003d meta_type.impl"},{"line_number":160,"context_line":"            self.compare_type(ctxt, insp_col, meta_col, insp_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_8678ce90","line":157,"updated":"2015-12-16 12:53:05.000000000","message":"workaround","commit_id":"eafcea9db4b471b88732b85d35c19064b8b53a24"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"1c4bf6b2a7f723603afd32bbffea9b256a12ba88","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        if issubclass(type(meta_type), BOOLEAN_METADATA):"},{"line_number":155,"context_line":"            return not issubclass(type(insp_type), BOOLEAN_SQL)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # Workaroud for bug 1526675"},{"line_number":158,"context_line":"        if isinstance(meta_type, types.Variant):"},{"line_number":159,"context_line":"            meta_col.type \u003d meta_type.impl"},{"line_number":160,"context_line":"            self.compare_type(ctxt, insp_col, meta_col, insp_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_7161de38","line":157,"in_reply_to":"5a710552_8678ce90","updated":"2015-12-16 13:17:10.000000000","message":"Done","commit_id":"eafcea9db4b471b88732b85d35c19064b8b53a24"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"69122f0f1159fe6a2f9db8e41163c249fdbdd361","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        # Workaroud for bug 1526675"},{"line_number":158,"context_line":"        if isinstance(meta_type, types.Variant):"},{"line_number":159,"context_line":"            meta_col.type \u003d meta_type.impl"},{"line_number":160,"context_line":"            self.compare_type(ctxt, insp_col, meta_col, insp_type,"},{"line_number":161,"context_line":"                              meta_type.impl)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        return None  # tells alembic to use the default comparison method"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_cb025f0b","line":160,"updated":"2015-12-16 12:52:23.000000000","message":"shouldn\u0027t we return the result here?","commit_id":"eafcea9db4b471b88732b85d35c19064b8b53a24"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"1c4bf6b2a7f723603afd32bbffea9b256a12ba88","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        # Workaroud for bug 1526675"},{"line_number":158,"context_line":"        if isinstance(meta_type, types.Variant):"},{"line_number":159,"context_line":"            meta_col.type \u003d meta_type.impl"},{"line_number":160,"context_line":"            self.compare_type(ctxt, insp_col, meta_col, insp_type,"},{"line_number":161,"context_line":"                              meta_type.impl)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        return None  # tells alembic to use the default comparison method"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_11c73a46","line":160,"in_reply_to":"5a710552_cb025f0b","updated":"2015-12-16 13:17:10.000000000","message":"I prefer that alembic will do the comparison because it will be done properly, I just give it the right types to compare.\nhttps://github.com/zzzeek/alembic/blob/831b1b9222d37d0e9b393d83b26811b98d9da0e9/alembic/ddl/impl.py#L237-L261 because I don\u0027t want to add workarounds for all types like it is done above for boolean types.","commit_id":"eafcea9db4b471b88732b85d35c19064b8b53a24"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"746f4b37f52d606072c6dc219cb51b297113001a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    def compare_type(self, ctxt, insp_col, meta_col, insp_type, meta_type):"},{"line_number":141,"context_line":"        if isinstance(meta_type, types.Variant):"},{"line_number":142,"context_line":"            meta_col.type \u003d meta_type.impl"},{"line_number":143,"context_line":"            self.compare_type(ctxt, insp_col, meta_col, insp_type,"},{"line_number":144,"context_line":"                              meta_type.impl)"},{"line_number":145,"context_line":"        else:"},{"line_number":146,"context_line":"            super(_TestModelsMigrations, self).compare_type("}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_56005301","line":143,"updated":"2015-12-16 14:12:24.000000000","message":"my understanding from reading oslo.db code for the fixture is that returned result of the method is significant for alembic, so I would expect us to return result here and in line 146.","commit_id":"3283e459477c8019d72048bfe7951e05c4d250d7"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d01cb779b23876f30cb1e1ab8ae755c6a595fad3","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    def compare_type(self, ctxt, insp_col, meta_col, insp_type, meta_type):"},{"line_number":141,"context_line":"        if isinstance(meta_type, types.Variant):"},{"line_number":142,"context_line":"            meta_col.type \u003d meta_type.impl"},{"line_number":143,"context_line":"            self.compare_type(ctxt, insp_col, meta_col, insp_type,"},{"line_number":144,"context_line":"                              meta_type.impl)"},{"line_number":145,"context_line":"        else:"},{"line_number":146,"context_line":"            super(_TestModelsMigrations, self).compare_type("}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_36458716","line":143,"in_reply_to":"5a710552_56005301","updated":"2015-12-16 14:16:12.000000000","message":"+1. I tried inserting the returns and it works.","commit_id":"3283e459477c8019d72048bfe7951e05c4d250d7"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"05a13870134dffe4c14247cba378464b1820e94e","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    # TODO(akamyshikova): remove this method as soon as comparison with Variant"},{"line_number":139,"context_line":"    # will be implemented in oslo.db or alembic"},{"line_number":140,"context_line":"    def compare_type(self, ctxt, insp_col, meta_col, insp_type, meta_type):"},{"line_number":141,"context_line":"        if isinstance(meta_type, types.Variant):"},{"line_number":142,"context_line":"            meta_col.type \u003d meta_type.impl"},{"line_number":143,"context_line":"            return self.compare_type(ctxt, insp_col, meta_col, insp_type,"},{"line_number":144,"context_line":"                                     meta_type.impl)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a710552_03ce0282","line":141,"updated":"2015-12-16 16:25:11.000000000","message":"before change you need to setup something to put it back since this modifies model:\n\norig_type \u003d meta_col.type\n\nrestore \u003d lambda: setattr(meta_col, \u0027type\u0027, orig_type)\n\nself.addCleanup(restore)\n\nmeta_col.type \u003d meta_type.impl","commit_id":"aafee56c7e80284d0e27bbc807aad21fbc0873d0"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a3ad953d9f0c967deb2999f0359d59208805e1cb","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    # TODO(akamyshikova): remove this method as soon as comparison with Variant"},{"line_number":139,"context_line":"    # will be implemented in oslo.db or alembic"},{"line_number":140,"context_line":"    def compare_type(self, ctxt, insp_col, meta_col, insp_type, meta_type):"},{"line_number":141,"context_line":"        if isinstance(meta_type, types.Variant):"},{"line_number":142,"context_line":"            meta_col.type \u003d meta_type.impl"},{"line_number":143,"context_line":"            return self.compare_type(ctxt, insp_col, meta_col, insp_type,"},{"line_number":144,"context_line":"                                     meta_type.impl)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a710552_e6df4467","line":141,"in_reply_to":"5a710552_03ce0282","updated":"2015-12-16 16:37:07.000000000","message":"Done","commit_id":"aafee56c7e80284d0e27bbc807aad21fbc0873d0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8d2efa4f20b9b1f373e31f6e43015f34fbcee054","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        if isinstance(meta_type, types.Variant):"},{"line_number":142,"context_line":"            orig_type \u003d meta_col.type"},{"line_number":143,"context_line":"            restore \u003d lambda: setattr(meta_col, \u0027type\u0027, orig_type)"},{"line_number":144,"context_line":"            self.addCleanup(restore)"},{"line_number":145,"context_line":"            meta_col.type \u003d meta_type.impl"},{"line_number":146,"context_line":"            return self.compare_type(ctxt, insp_col, meta_col, insp_type,"},{"line_number":147,"context_line":"                                     meta_type.impl)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_0c1a3718","line":144,"updated":"2015-12-16 20:53:28.000000000","message":"it will probably work for our needs, but for completeness, I suggested to use try: finally: instead here to avoid leaving models modified for the rest of the test case that uses the method.","commit_id":"43eced7ef40bba556f59a262f1606e9b5224c337"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"48b3920af2860e04904650a5023dccd90c786380","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        if isinstance(meta_type, types.Variant):"},{"line_number":142,"context_line":"            orig_type \u003d meta_col.type"},{"line_number":143,"context_line":"            restore \u003d lambda: setattr(meta_col, \u0027type\u0027, orig_type)"},{"line_number":144,"context_line":"            self.addCleanup(restore)"},{"line_number":145,"context_line":"            meta_col.type \u003d meta_type.impl"},{"line_number":146,"context_line":"            return self.compare_type(ctxt, insp_col, meta_col, insp_type,"},{"line_number":147,"context_line":"                                     meta_type.impl)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_0f58e955","line":144,"in_reply_to":"3a7e1126_0c1a3718","updated":"2015-12-16 21:38:04.000000000","message":"I believe the following version would be less twisted:\n\n    def compare_type(self, ctxt, insp_col, meta_col, insp_type, meta_type):\n        if isinstance(meta_type, types.Variant):\n            orig_type \u003d meta_col.type\n            meta_col.type \u003d meta_type.impl\n            try:\n                return self.compare_type(ctxt, insp_col, meta_col, insp_type,\n                                         meta_type.impl)\n            finally:\n                meta_col.type \u003d orig_type\n        else:\n            ret \u003d super(_TestModelsMigrations, self).compare_type(\n                ctxt, insp_col, meta_col, insp_type, meta_type)\n            if ret is not None:\n                return ret\n            return ctxt.impl.compare_type(insp_col, meta_col)\n\nSince it nicely isolates the section of the code that runs with modified models.","commit_id":"43eced7ef40bba556f59a262f1606e9b5224c337"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d6e9c6592cce4901e1457a777bded2ff44477557","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        if isinstance(meta_type, types.Variant):"},{"line_number":142,"context_line":"            orig_type \u003d meta_col.type"},{"line_number":143,"context_line":"            restore \u003d lambda: setattr(meta_col, \u0027type\u0027, orig_type)"},{"line_number":144,"context_line":"            self.addCleanup(restore)"},{"line_number":145,"context_line":"            meta_col.type \u003d meta_type.impl"},{"line_number":146,"context_line":"            return self.compare_type(ctxt, insp_col, meta_col, insp_type,"},{"line_number":147,"context_line":"                                     meta_type.impl)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_e136ccb3","line":144,"in_reply_to":"3a7e1126_0f58e955","updated":"2015-12-16 23:51:56.000000000","message":"Thanks Ihar, makes sense. This works locally, let\u0027s try it in the gate.","commit_id":"43eced7ef40bba556f59a262f1606e9b5224c337"}]}
