)]}'
{"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"9c4b5b8c4c6cbb18027ea9aff85dc3cf1f2136de","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                    s[\u0027cidr\u0027], s[\u0027gateway_ip\u0027])):"},{"line_number":464,"context_line":"                error_message \u003d _(\"Gateway is not valid on subnet\")"},{"line_number":465,"context_line":"                raise n_exc.InvalidInput(error_message\u003derror_message)"},{"line_number":466,"context_line":"            # In case of update, we need to ensure the new gateway IP is not"},{"line_number":467,"context_line":"            # assigned to any port"},{"line_number":468,"context_line":"            # NOTE(salv-orlando): There is slight chance of a race, when"},{"line_number":469,"context_line":"            # a subnet-update and a router-interface-add operation are"},{"line_number":470,"context_line":"            # executed concurrently"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_718a55c1","line":467,"range":{"start_line":466,"start_character":14,"end_line":467,"end_character":34},"updated":"2015-12-17 20:28:34.000000000","message":"You\u0027ve mis-understood the original intention of this check.  The code correctly implements the original intention which was to avoid changing the gateway ip address if a port was using it.\n\nSee Ie29be1b83f9a639562bfc84f3f2c082833126d32 for details.\n\nHonestly, I\u0027m not sure why it is important to check if either the old gateway ip is being used by a port or the new one.  Why not just let the user change the gateway ip address if he/she wants to?","commit_id":"a0e200a6f942426cc7d0198e5a446130491e5498"}]}