)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"4971f5db901627d4b43a146a60d8f0f142d84722","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch allow to show the loaded extensions"},{"line_number":10,"context_line":"when executing neutron agent-show \u003cSR-IOV agent id\u003e"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1527307"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5dcb79ef539e4f18693e4a8eff03fff40873d3fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_7d2d3545","line":11,"updated":"2015-12-18 07:43:21.000000000","message":"This patchset changes how the result of the api call \u0027neutron agent-show\u0027 looks like. I think such a minor output only change is not considered as API Change, right?","commit_id":"d6150a99a959919f9ba2cd12b95f2cff2df3f050"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"f7a843eba40fa6a28e91eb9c9b5d36723754dc76","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch allow to show the loaded extensions"},{"line_number":10,"context_line":"when executing neutron agent-show \u003cSR-IOV agent id\u003e"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1527307"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5dcb79ef539e4f18693e4a8eff03fff40873d3fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_4ff08d91","line":11,"in_reply_to":"3a7e1126_7d2d3545","updated":"2015-12-19 12:41:35.000000000","message":"looking on the ovs patch https://review.openstack.org/#/c/227394/ I need just to put DocImpact","commit_id":"d6150a99a959919f9ba2cd12b95f2cff2df3f050"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b14a27311b25b63d9c9bf2574afe0ff76bf6a552","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"SR-IOV agent: display loaded extensions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch allow to show the loaded extensions"},{"line_number":10,"context_line":"when executing neutron agent-show \u003cSR-IOV agent id\u003e"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1527307"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a7e1126_7698b9c0","line":9,"updated":"2015-12-20 10:04:02.000000000","message":"i was originally confused by this. Can you please add the commit reference for the support in the plugin and then it will be crystal clear","commit_id":"ea8d7e727aa44f54e33c0e923b71bf13d6f26526"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"7d86efa6da2972cd978fc7d064fd9514079b2d01","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"SR-IOV agent: display loaded extensions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch allow to show the loaded extensions"},{"line_number":10,"context_line":"when executing neutron agent-show \u003cSR-IOV agent id\u003e"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1527307"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a7e1126_d27e5618","line":9,"in_reply_to":"3a7e1126_7698b9c0","updated":"2015-12-20 16:58:52.000000000","message":"Done","commit_id":"ea8d7e727aa44f54e33c0e923b71bf13d6f26526"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"3caf818ebdfc981781365b074f8a3f2992c2da7a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"when executing neutron agent-show \u003cSR-IOV agent id\u003e"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1527307"},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":"Change-Id: I5dcb79ef539e4f18693e4a8eff03fff40873d3fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a7e1126_60b23396","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":9},"updated":"2015-12-20 07:05:24.000000000","message":"Plz mention detail about the DocImpact","commit_id":"ea8d7e727aa44f54e33c0e923b71bf13d6f26526"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"7d86efa6da2972cd978fc7d064fd9514079b2d01","unresolved":false,"context_lines":[{"line_number":10,"context_line":"when executing neutron agent-show \u003cSR-IOV agent id\u003e"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1527307"},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":"Change-Id: I5dcb79ef539e4f18693e4a8eff03fff40873d3fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a7e1126_92744e36","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":9},"in_reply_to":"3a7e1126_60b23396","updated":"2015-12-20 16:58:52.000000000","message":"Done","commit_id":"ea8d7e727aa44f54e33c0e923b71bf13d6f26526"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b14a27311b25b63d9c9bf2574afe0ff76bf6a552","unresolved":false,"context_lines":[{"line_number":10,"context_line":"when executing neutron agent-show \u003cSR-IOV agent id\u003e"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1527307"},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":"Change-Id: I5dcb79ef539e4f18693e4a8eff03fff40873d3fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a7e1126_d67e4d69","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":9},"in_reply_to":"3a7e1126_60b23396","updated":"2015-12-20 10:04:02.000000000","message":"in the case of a docimpact flag please add in the release note","commit_id":"ea8d7e727aa44f54e33c0e923b71bf13d6f26526"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"708756596ca53ed7d2afb1bdb1ab25b9c26d305e","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1527307"},{"line_number":16,"context_line":"DocImpact update the agent configuration to show"},{"line_number":17,"context_line":"\t  l2 agent extensions"},{"line_number":18,"context_line":"Change-Id: I5dcb79ef539e4f18693e4a8eff03fff40873d3fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a7e1126_9c153ce6","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":3},"updated":"2015-12-21 05:48:36.000000000","message":"nit: remove tabs.","commit_id":"0517cb166a467bb63342ad89b9d38d457ff4f11f"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"b2ee628bc31e002969c39f40e6bbc081a673db97","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1527307"},{"line_number":16,"context_line":"DocImpact update the agent configuration to show"},{"line_number":17,"context_line":"\t  l2 agent extensions"},{"line_number":18,"context_line":"Change-Id: I5dcb79ef539e4f18693e4a8eff03fff40873d3fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a7e1126_32beaf65","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":3},"in_reply_to":"3a7e1126_9c153ce6","updated":"2015-12-21 07:35:17.000000000","message":"Done","commit_id":"0517cb166a467bb63342ad89b9d38d457ff4f11f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fddcd0a1e5436e5f3acfed7849b54d952ace9866","unresolved":false,"context_lines":[{"line_number":13,"context_line":"when executing neutron agent-show \u003cSR-IOV agent id\u003e"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1527307"},{"line_number":16,"context_line":"DocImpact update the agent configuration to show"},{"line_number":17,"context_line":"          l2 agent extensions"},{"line_number":18,"context_line":"Change-Id: I5dcb79ef539e4f18693e4a8eff03fff40873d3fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa69d971_1fa0ad8f","line":16,"updated":"2016-01-04 16:15:52.000000000","message":"I don\u0027t think DocImpact is justified here. Why do we want to document how to enable extensions, just to see extensions in the list? What should be documented is how we enable extensions, without relation to listing extensions for an agent.","commit_id":"342543f19d88f6bab0d57df7318a56a0b1cb75b2"}],"neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"21def92596d67cf6d21f05a513900e3c11256a0c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            self.connection)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        configurations \u003d {\u0027device_mappings\u0027: physical_devices_mappings,"},{"line_number":114,"context_line":"                          \u0027extensions\u0027: self.ext_manager.names()}"},{"line_number":115,"context_line":"        self.agent_state \u003d {"},{"line_number":116,"context_line":"            \u0027binary\u0027: \u0027neutron-sriov-nic-agent\u0027,"},{"line_number":117,"context_line":"            \u0027host\u0027: self.conf.host,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_18971f3b","line":114,"updated":"2015-12-20 19:48:20.000000000","message":"I hope this code duplication will go away with modular agent progress","commit_id":"0517cb166a467bb63342ad89b9d38d457ff4f11f"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"b2ee628bc31e002969c39f40e6bbc081a673db97","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            self.connection)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        configurations \u003d {\u0027device_mappings\u0027: physical_devices_mappings,"},{"line_number":114,"context_line":"                          \u0027extensions\u0027: self.ext_manager.names()}"},{"line_number":115,"context_line":"        self.agent_state \u003d {"},{"line_number":116,"context_line":"            \u0027binary\u0027: \u0027neutron-sriov-nic-agent\u0027,"},{"line_number":117,"context_line":"            \u0027host\u0027: self.conf.host,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_b28b7fc2","line":114,"in_reply_to":"3a7e1126_18971f3b","updated":"2015-12-21 07:35:17.000000000","message":"me too :)","commit_id":"0517cb166a467bb63342ad89b9d38d457ff4f11f"}],"neutron/tests/unit/plugins/ml2/drivers/mech_sriov/agent/test_sriov_nic_agent.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"3caf818ebdfc981781365b074f8a3f2992c2da7a","unresolved":false,"context_lines":[{"line_number":314,"context_line":"class TestSRIOVAgentExtensionConfig(base.BaseTestCase):"},{"line_number":315,"context_line":"    def setUp(self):"},{"line_number":316,"context_line":"        super(TestSRIOVAgentExtensionConfig, self).setUp()"},{"line_number":317,"context_line":"        l2_ext_manager.register_opts(cfg.CONF)"},{"line_number":318,"context_line":"        cfg.CONF.set_override(\u0027extensions\u0027, [\u0027qos\u0027], group\u003d\u0027agent\u0027)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    @mock.patch(\"neutron.plugins.ml2.drivers.mech_sriov.agent.eswitch_manager\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_c0b8c777","line":317,"range":{"start_line":317,"start_character":23,"end_line":317,"end_character":36},"updated":"2015-12-20 07:05:24.000000000","message":"let\u0027s place this statement after set_override.","commit_id":"ea8d7e727aa44f54e33c0e923b71bf13d6f26526"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"7d86efa6da2972cd978fc7d064fd9514079b2d01","unresolved":false,"context_lines":[{"line_number":314,"context_line":"class TestSRIOVAgentExtensionConfig(base.BaseTestCase):"},{"line_number":315,"context_line":"    def setUp(self):"},{"line_number":316,"context_line":"        super(TestSRIOVAgentExtensionConfig, self).setUp()"},{"line_number":317,"context_line":"        l2_ext_manager.register_opts(cfg.CONF)"},{"line_number":318,"context_line":"        cfg.CONF.set_override(\u0027extensions\u0027, [\u0027qos\u0027], group\u003d\u0027agent\u0027)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    @mock.patch(\"neutron.plugins.ml2.drivers.mech_sriov.agent.eswitch_manager\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_526026a5","line":317,"range":{"start_line":317,"start_character":23,"end_line":317,"end_character":36},"in_reply_to":"3a7e1126_c0b8c777","updated":"2015-12-20 16:58:52.000000000","message":"why do you think it is better?\nwe need first to register the l2_ext_manager options and only after that we can ovrride the values, otherwise we will get and exception no such config option","commit_id":"ea8d7e727aa44f54e33c0e923b71bf13d6f26526"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"56d1b17be7e8635c995ca76692662d2ff0382483","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                               \u0027report_state\u0027) as mock_report_state:"},{"line_number":327,"context_line":"            agent \u003d sriov_nic_agent.SriovNicSwitchAgent({}, {}, 0)"},{"line_number":328,"context_line":"            agent._report_state()"},{"line_number":329,"context_line":"            agent_state \u003d mock_report_state.call_args[0][1]"},{"line_number":330,"context_line":"            self.assertEqual("},{"line_number":331,"context_line":"                [\u0027qos\u0027], agent_state[\u0027configurations\u0027][\u0027extensions\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_6cf292d4","line":329,"range":{"start_line":329,"start_character":44,"end_line":329,"end_character":53},"updated":"2015-12-24 06:12:12.000000000","message":"I feel not intuitive. How about the following?\n\nmock_report_state.assert_called_with(agent.context, agent.agent_state)\nself.assertEqual(\n    [\u0027qos\u0027], agent.agent_state[\u0027configurations\u0027][\u0027extensions\u0027])","commit_id":"5483e81c38e219d7d5000f08378ea7468fe3b087"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f3ae75296b0d43f2b2ad21a5c943766e0aff30db","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                               \u0027report_state\u0027) as mock_report_state:"},{"line_number":327,"context_line":"            agent \u003d sriov_nic_agent.SriovNicSwitchAgent({}, {}, 0)"},{"line_number":328,"context_line":"            agent._report_state()"},{"line_number":329,"context_line":"            agent_state \u003d mock_report_state.call_args[0][1]"},{"line_number":330,"context_line":"            self.assertEqual("},{"line_number":331,"context_line":"                [\u0027qos\u0027], agent_state[\u0027configurations\u0027][\u0027extensions\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_0f13c00e","line":329,"range":{"start_line":329,"start_character":44,"end_line":329,"end_character":53},"in_reply_to":"1a7b0d38_6cf292d4","updated":"2015-12-24 06:45:40.000000000","message":"+1","commit_id":"5483e81c38e219d7d5000f08378ea7468fe3b087"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"f1eb86cebb72511294a0032523addfa4c43392be","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                               \u0027report_state\u0027) as mock_report_state:"},{"line_number":327,"context_line":"            agent \u003d sriov_nic_agent.SriovNicSwitchAgent({}, {}, 0)"},{"line_number":328,"context_line":"            agent._report_state()"},{"line_number":329,"context_line":"            agent_state \u003d mock_report_state.call_args[0][1]"},{"line_number":330,"context_line":"            self.assertEqual("},{"line_number":331,"context_line":"                [\u0027qos\u0027], agent_state[\u0027configurations\u0027][\u0027extensions\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_825ea710","line":329,"range":{"start_line":329,"start_character":44,"end_line":329,"end_character":53},"in_reply_to":"1a7b0d38_6cf292d4","updated":"2015-12-24 07:29:22.000000000","message":"Done","commit_id":"5483e81c38e219d7d5000f08378ea7468fe3b087"}],"releasenotes/notes/sriov_show_l2_agent_extensions-ca852e155a529e99.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f3ae75296b0d43f2b2ad21a5c943766e0aff30db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - allow SR-IOV agent to display it\u0027s loaded extensions"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a7b0d38_4f09c8dc","line":3,"updated":"2015-12-24 06:45:40.000000000","message":"Nit: How about the following?\n\n  Loaded agent extensions of SR-IOV agent are now shown in agent state API.\n\nI think how operators can see this information is more important in the release note.","commit_id":"5483e81c38e219d7d5000f08378ea7468fe3b087"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"f1eb86cebb72511294a0032523addfa4c43392be","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - allow SR-IOV agent to display it\u0027s loaded extensions"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a7b0d38_0213970e","line":3,"in_reply_to":"1a7b0d38_4f09c8dc","updated":"2015-12-24 07:29:22.000000000","message":"Done","commit_id":"5483e81c38e219d7d5000f08378ea7468fe3b087"}]}