)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"41803506bd2404878defcc8c2740e4d0e8614c29","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch update the l3 agent to add fdb entry for each router internal network port."},{"line_number":14,"context_line":"Config option is added to the l3 agent for specifying the physical interfaces"},{"line_number":15,"context_line":"to associate theses mac address"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact adding fdb_interfaces_list config option to l3 agent"},{"line_number":18,"context_line":"Closes-Bug: #1527991"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a7e1126_18c87fa7","line":15,"updated":"2015-12-20 19:44:20.000000000","message":"these","commit_id":"831224bdaa25e0f27d93c2ce6958098ee45f30dc"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"5721127996e573121840c5a94ece5e6b95dd50da","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch update the l3 agent to add fdb entry for each router internal network port."},{"line_number":14,"context_line":"Config option is added to the l3 agent for specifying the physical interfaces"},{"line_number":15,"context_line":"to associate theses mac address"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact adding fdb_interfaces_list config option to l3 agent"},{"line_number":18,"context_line":"Closes-Bug: #1527991"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a7e1126_8d5d0817","line":15,"in_reply_to":"3a7e1126_18c87fa7","updated":"2015-12-21 08:57:57.000000000","message":"Done","commit_id":"831224bdaa25e0f27d93c2ce6958098ee45f30dc"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"d8f8f8dd7158884d41f0e8ac785ac53e29b55552","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Config option is added to the l3 agent for specifying the physical interfaces"},{"line_number":15,"context_line":"to associate these mac address"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact adding fdb_interfaces_list config option to l3 agent"},{"line_number":18,"context_line":"Closes-Bug: #1527991"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I2261660912984442b111fa0a0deb967a09c6737b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a7e1126_e8a91325","line":17,"updated":"2015-12-21 10:45:05.000000000","message":"fdb_interface","commit_id":"53e3a3980700f2f4b144081ae18b289ea23148ce"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"9bfcd2861f4bed799cc2fb76807036a0c58d0407","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Config option is added to the l3 agent for specifying the physical interfaces"},{"line_number":15,"context_line":"to associate these mac address"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact adding fdb_interfaces_list config option to l3 agent"},{"line_number":18,"context_line":"Closes-Bug: #1527991"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I2261660912984442b111fa0a0deb967a09c6737b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a7e1126_6381c4fa","line":17,"in_reply_to":"3a7e1126_e8a91325","updated":"2015-12-21 10:54:20.000000000","message":"Done","commit_id":"53e3a3980700f2f4b144081ae18b289ea23148ce"}],"neutron/agent/l3/config.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"41803506bd2404878defcc8c2740e4d0e8614c29","unresolved":false,"context_lines":[{"line_number":100,"context_line":"               help\u003d_(\u0027Iptables mangle mark used to mark ingress from \u0027"},{"line_number":101,"context_line":"                      \u0027external network. This mark will be masked with \u0027"},{"line_number":102,"context_line":"                      \u00270xffff so that only the lower 16 bits will be used.\u0027)),"},{"line_number":103,"context_line":"    cfg.ListOpt(\u0027fdb_interfaces_list\u0027,"},{"line_number":104,"context_line":"               default\u003d[],"},{"line_number":105,"context_line":"               help\u003d_(\u0027List of pyhsical interfaces to which the internal \u0027"},{"line_number":106,"context_line":"                      \u0027router ports mac addresses are associated.\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_38445b19","line":103,"updated":"2015-12-20 19:44:20.000000000","message":"I do not think config attribute name should reflect its type. It can be fdb_interfaces","commit_id":"831224bdaa25e0f27d93c2ce6958098ee45f30dc"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"5721127996e573121840c5a94ece5e6b95dd50da","unresolved":false,"context_lines":[{"line_number":100,"context_line":"               help\u003d_(\u0027Iptables mangle mark used to mark ingress from \u0027"},{"line_number":101,"context_line":"                      \u0027external network. This mark will be masked with \u0027"},{"line_number":102,"context_line":"                      \u00270xffff so that only the lower 16 bits will be used.\u0027)),"},{"line_number":103,"context_line":"    cfg.ListOpt(\u0027fdb_interfaces_list\u0027,"},{"line_number":104,"context_line":"               default\u003d[],"},{"line_number":105,"context_line":"               help\u003d_(\u0027List of pyhsical interfaces to which the internal \u0027"},{"line_number":106,"context_line":"                      \u0027router ports mac addresses are associated.\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_8d8bc867","line":103,"in_reply_to":"3a7e1126_38445b19","updated":"2015-12-21 08:57:57.000000000","message":"Done","commit_id":"831224bdaa25e0f27d93c2ce6958098ee45f30dc"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"d23665b6963865c266255c048c8f345f27fe6d77","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                      \u00270xffff so that only the lower 16 bits will be used.\u0027)),"},{"line_number":103,"context_line":"    cfg.ListOpt(\u0027fdb_interfaces_list\u0027,"},{"line_number":104,"context_line":"               default\u003d[],"},{"line_number":105,"context_line":"               help\u003d_(\u0027List of pyhsical interfaces to which the internal \u0027"},{"line_number":106,"context_line":"                      \u0027router ports mac addresses are associated.\u0027)),"},{"line_number":107,"context_line":"]"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_323ebada","line":105,"range":{"start_line":105,"start_character":31,"end_line":105,"end_character":39},"updated":"2015-12-20 17:45:23.000000000","message":"nit..change it to physical","commit_id":"831224bdaa25e0f27d93c2ce6958098ee45f30dc"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"5721127996e573121840c5a94ece5e6b95dd50da","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                      \u00270xffff so that only the lower 16 bits will be used.\u0027)),"},{"line_number":103,"context_line":"    cfg.ListOpt(\u0027fdb_interfaces_list\u0027,"},{"line_number":104,"context_line":"               default\u003d[],"},{"line_number":105,"context_line":"               help\u003d_(\u0027List of pyhsical interfaces to which the internal \u0027"},{"line_number":106,"context_line":"                      \u0027router ports mac addresses are associated.\u0027)),"},{"line_number":107,"context_line":"]"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_cd955087","line":105,"range":{"start_line":105,"start_character":31,"end_line":105,"end_character":39},"in_reply_to":"3a7e1126_323ebada","updated":"2015-12-21 08:57:57.000000000","message":"Done","commit_id":"831224bdaa25e0f27d93c2ce6958098ee45f30dc"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c626b66af3f59dc1508383a310e4e6abc037e1b4","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                      \u0027external network. This mark will be masked with \u0027"},{"line_number":102,"context_line":"                      \u00270xffff so that only the lower 16 bits will be used.\u0027)),"},{"line_number":103,"context_line":"    cfg.ListOpt(\u0027fdb_interfaces\u0027,"},{"line_number":104,"context_line":"               default\u003d[],"},{"line_number":105,"context_line":"               help\u003d_(\u0027List of physical interfaces to which the internal \u0027"},{"line_number":106,"context_line":"                      \u0027router ports mac addresses are associated.\u0027)),"},{"line_number":107,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_f1e4370e","line":104,"updated":"2015-12-23 11:57:51.000000000","message":"please fix the indentation here","commit_id":"58617a3188d2728043ba04f66bf5667153789370"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b9757f2f517b0a7e5e160b2fb301bb53b17b487b","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                      \u00270xffff so that only the lower 16 bits will be used.\u0027)),"},{"line_number":103,"context_line":"    cfg.ListOpt(\u0027fdb_interfaces\u0027,"},{"line_number":104,"context_line":"                default\u003d[],"},{"line_number":105,"context_line":"                help\u003d_(\u0027List of physical interfaces to which the internal \u0027"},{"line_number":106,"context_line":"                       \u0027router ports mac addresses are associated.\u0027)),"},{"line_number":107,"context_line":"]"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_1f22edb9","line":105,"updated":"2016-01-04 16:25:07.000000000","message":"I would fail to understand what the option is supposed to do if I were an operator somewhere in the wild and not reading the patch. Probably needs some rewording.\n\nBut first, can you clarify why we want to configure it in the config file? Isn\u0027t there a way to get the list in runtime somehow?","commit_id":"c4ee895223032b1c4bea5f743a79bfc62eef97ef"}],"neutron/agent/l3/router_info.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"41803506bd2404878defcc8c2740e4d0e8614c29","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        self.router_namespace.delete()"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def _process_fdb_entries(self, method, mac_address):"},{"line_number":270,"context_line":"        if self.agent_conf.fdb_interfaces_list:"},{"line_number":271,"context_line":"            for interface in self.agent_conf.fdb_interfaces_list:"},{"line_number":272,"context_line":"                method(interface, mac_address)"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_b8fe0bac","line":270,"updated":"2015-12-20 19:44:20.000000000","message":"you do not need this line, if note defined, it will be defaulted to empty list","commit_id":"831224bdaa25e0f27d93c2ce6958098ee45f30dc"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"5721127996e573121840c5a94ece5e6b95dd50da","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        self.router_namespace.delete()"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def _process_fdb_entries(self, method, mac_address):"},{"line_number":270,"context_line":"        if self.agent_conf.fdb_interfaces_list:"},{"line_number":271,"context_line":"            for interface in self.agent_conf.fdb_interfaces_list:"},{"line_number":272,"context_line":"                method(interface, mac_address)"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_4df080fe","line":270,"in_reply_to":"3a7e1126_b8fe0bac","updated":"2015-12-21 08:57:57.000000000","message":"Done","commit_id":"831224bdaa25e0f27d93c2ce6958098ee45f30dc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"56d9c9213d4152265bf622df5c8c7c0a595b8815","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        mac_address \u003d port[\u0027mac_address\u0027]"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        interface_name \u003d self.get_internal_device_name(port_id)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        self._internal_network_added(self.ns_name,"},{"line_number":312,"context_line":"                                     network_id,"},{"line_number":313,"context_line":"                                     port_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_3da24b4c","side":"PARENT","line":310,"updated":"2016-01-04 22:39:57.000000000","message":"gratuitous whitespace change","commit_id":"904cdc723b6da6638f9cd97047a0ef8ecc8c0da6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"56d9c9213d4152265bf622df5c8c7c0a595b8815","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron._i18n import _LE, _LW"},{"line_number":20,"context_line":"from neutron.agent.l3 import namespaces"},{"line_number":21,"context_line":"from neutron.agent.linux import bridge_lib"},{"line_number":22,"context_line":"from neutron.agent.linux import ip_lib"},{"line_number":23,"context_line":"from neutron.agent.linux import iptables_manager"},{"line_number":24,"context_line":"from neutron.agent.linux import ra"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_c04462b8","line":21,"updated":"2016-01-04 22:39:57.000000000","message":"This seems wrong to me as only the linuxbridge agent should be manipulating the underlying bridge device.","commit_id":"c4ee895223032b1c4bea5f743a79bfc62eef97ef"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"3b6bb5f1101f6f0c4fc07983b45744069eb05655","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron._i18n import _LE, _LW"},{"line_number":20,"context_line":"from neutron.agent.l3 import namespaces"},{"line_number":21,"context_line":"from neutron.agent.linux import bridge_lib"},{"line_number":22,"context_line":"from neutron.agent.linux import ip_lib"},{"line_number":23,"context_line":"from neutron.agent.linux import iptables_manager"},{"line_number":24,"context_line":"from neutron.agent.linux import ra"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_48dbadec","line":21,"in_reply_to":"fa69d971_c04462b8","updated":"2016-01-05 07:54:11.000000000","message":"I guess you are right the manipulating should be by the L2 agent that bind the interface_router.\nand the problem is similar to this patch https://review.openstack.org/#/c/198736/ allow SR-IOV and OVS VMs connectivity (or any L2 PV agent on the same host). \n\nI guess I need to find a common way to tell L2 Agent to add fdb entry to a specific port.\n\nWhen using SR-IOV we need to add fdb entry for the PV (normal port) in the following scenarios:\n1. when router agent and SR-IOV VM run on the same physical machine.\n2. when to ping SR-IOV VM and PV (normal port) VM on the same same physical machine.\nmaybe I should add and extension of fdb_population and when network/port is updated with fdb_population\u003dTrue the L2 Agent will add the entry.\nDoes this make more sens?","commit_id":"c4ee895223032b1c4bea5f743a79bfc62eef97ef"}],"neutron/agent/linux/bridge_lib.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"56d9c9213d4152265bf622df5c8c7c0a595b8815","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @classmethod"},{"line_number":136,"context_line":"    def get_macs_for_interface(cls, interface):"},{"line_number":137,"context_line":"        lines \u003d cls._bridge_fdb([\u0027show\u0027, interface]).splitlines()"},{"line_number":138,"context_line":"        return [line.split()[0] for line in lines]"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_dd044f4b","line":137,"updated":"2016-01-04 22:39:57.000000000","message":"You need to use [\u0027show\u0027, \u0027dev\u0027, interface] else you\u0027ll get all the entries:\n\n--\u003e bridge fdb show eth0\n01:00:5e:00:00:01 dev eth0 self permanent\n33:33:00:00:00:01 dev eth0 self permanent\n33:33:ff:4f:f8:5d dev eth0 self permanent\n01:00:5e:00:00:fb dev eth0 self permanent\n33:33:00:00:00:fb dev eth0 self permanent\n33:33:00:00:00:01 dev eth1 self permanent\n01:00:5e:00:00:01 dev eth1 self permanent\n\n--\u003e bridge fdb show dev eth0\n01:00:5e:00:00:01 self permanent\n33:33:00:00:00:01 self permanent\n33:33:ff:4f:f8:5d self permanent\n01:00:5e:00:00:fb self permanent\n33:33:00:00:00:fb self permanen","commit_id":"c4ee895223032b1c4bea5f743a79bfc62eef97ef"}],"neutron/tests/unit/agent/l3/test_router_info.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"41803506bd2404878defcc8c2740e4d0e8614c29","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        if not router:"},{"line_number":134,"context_line":"            router \u003d mock.MagicMock()"},{"line_number":135,"context_line":"        if not conf:"},{"line_number":136,"context_line":"            conf \u003d FakeConf()"},{"line_number":137,"context_line":"        self.router_id \u003d _uuid()"},{"line_number":138,"context_line":"        return router_info.RouterInfo(self.router_id,"},{"line_number":139,"context_line":"                                      router,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_78c18353","line":136,"updated":"2015-12-20 19:44:20.000000000","message":"Why Fake onf is needed?\nYou can use cfg.CONF.set_override(..) to setup required conf attribute.\ncheck here for example:https://github.com/openstack/neutron/blob/master/neutron/tests/unit/plugins/ml2/test_plugin.py#L376","commit_id":"831224bdaa25e0f27d93c2ce6958098ee45f30dc"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"5721127996e573121840c5a94ece5e6b95dd50da","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        if not router:"},{"line_number":134,"context_line":"            router \u003d mock.MagicMock()"},{"line_number":135,"context_line":"        if not conf:"},{"line_number":136,"context_line":"            conf \u003d FakeConf()"},{"line_number":137,"context_line":"        self.router_id \u003d _uuid()"},{"line_number":138,"context_line":"        return router_info.RouterInfo(self.router_id,"},{"line_number":139,"context_line":"                                      router,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_a30ed338","line":136,"in_reply_to":"3a7e1126_78c18353","updated":"2015-12-21 08:57:57.000000000","message":"Done","commit_id":"831224bdaa25e0f27d93c2ce6958098ee45f30dc"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"41803506bd2404878defcc8c2740e4d0e8614c29","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        eth0 \u003d \u0027eth0\u0027"},{"line_number":259,"context_line":"        eth1 \u003d \u0027eth1\u0027"},{"line_number":260,"context_line":"        mac \u003d \u0027aa:bb:cc:dd:ee:ff\u0027"},{"line_number":261,"context_line":"        setattr(conf, \u0027fdb_interfaces_list\u0027, [eth0, eth1])"},{"line_number":262,"context_line":"        ri \u003d self._create_router(conf\u003dconf)"},{"line_number":263,"context_line":"        ri._process_fdb_entries(bridge_lib.ForwardingDatabase.add_entry, mac)"},{"line_number":264,"context_line":"        mock_add_entry.assert_any_call(eth0, mac)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_f8949343","line":261,"updated":"2015-12-20 19:44:20.000000000","message":"previous comment applicable here","commit_id":"831224bdaa25e0f27d93c2ce6958098ee45f30dc"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"5721127996e573121840c5a94ece5e6b95dd50da","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        eth0 \u003d \u0027eth0\u0027"},{"line_number":259,"context_line":"        eth1 \u003d \u0027eth1\u0027"},{"line_number":260,"context_line":"        mac \u003d \u0027aa:bb:cc:dd:ee:ff\u0027"},{"line_number":261,"context_line":"        setattr(conf, \u0027fdb_interfaces_list\u0027, [eth0, eth1])"},{"line_number":262,"context_line":"        ri \u003d self._create_router(conf\u003dconf)"},{"line_number":263,"context_line":"        ri._process_fdb_entries(bridge_lib.ForwardingDatabase.add_entry, mac)"},{"line_number":264,"context_line":"        mock_add_entry.assert_any_call(eth0, mac)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_1e013c05","line":261,"in_reply_to":"3a7e1126_f8949343","updated":"2015-12-21 08:57:57.000000000","message":"Done","commit_id":"831224bdaa25e0f27d93c2ce6958098ee45f30dc"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"41803506bd2404878defcc8c2740e4d0e8614c29","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        eth0 \u003d \u0027eth0\u0027"},{"line_number":271,"context_line":"        eth1 \u003d \u0027eth1\u0027"},{"line_number":272,"context_line":"        mac \u003d \u0027aa:bb:cc:dd:ee:ff\u0027"},{"line_number":273,"context_line":"        setattr(conf, \u0027fdb_interfaces_list\u0027, [eth0, eth1])"},{"line_number":274,"context_line":"        ri \u003d self._create_router(conf\u003dconf)"},{"line_number":275,"context_line":"        ri._process_fdb_entries(bridge_lib.ForwardingDatabase.del_entry, mac)"},{"line_number":276,"context_line":"        mock_remove_entry.assert_any_call(eth0, mac)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_989d4f68","line":273,"updated":"2015-12-20 19:44:20.000000000","message":"ditto","commit_id":"831224bdaa25e0f27d93c2ce6958098ee45f30dc"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"5721127996e573121840c5a94ece5e6b95dd50da","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        eth0 \u003d \u0027eth0\u0027"},{"line_number":271,"context_line":"        eth1 \u003d \u0027eth1\u0027"},{"line_number":272,"context_line":"        mac \u003d \u0027aa:bb:cc:dd:ee:ff\u0027"},{"line_number":273,"context_line":"        setattr(conf, \u0027fdb_interfaces_list\u0027, [eth0, eth1])"},{"line_number":274,"context_line":"        ri \u003d self._create_router(conf\u003dconf)"},{"line_number":275,"context_line":"        ri._process_fdb_entries(bridge_lib.ForwardingDatabase.del_entry, mac)"},{"line_number":276,"context_line":"        mock_remove_entry.assert_any_call(eth0, mac)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_de06541b","line":273,"in_reply_to":"3a7e1126_989d4f68","updated":"2015-12-21 08:57:57.000000000","message":"Done","commit_id":"831224bdaa25e0f27d93c2ce6958098ee45f30dc"}]}