)]}'
{"neutron/db/agents_db.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e8e196ff159e6c686715ed0539831bd69ec8210f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"cfg.CONF.register_opts(AGENT_OPTS)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"class Agent(model_base.BASEV2, model_base.HasId):"},{"line_number":73,"context_line":"    \"\"\"Represents agents running in neutron deployments.\"\"\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    __table_args__ \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_bbe57c09","line":72,"updated":"2016-01-06 23:20:45.000000000","message":"This change eliminates a circular import that would\u0027ve been introduced by this patch.  I might suggest making this change throughout the entire repository and then rebase this patch set to that one.  In fact, why not change it for HasTenant and HasStatusDescription too?  Code in this repository should uniformly access those through model_base in my opinion.\n\nI just spent a couple minutes with xargs, grep, sed, and tox and came up with this:  https://review.openstack.org/264420  Rebasing may not be necessary.\n\nI see the note in models_v2.py that some external projects expect to see them in models_v2.py.  Do we know which ones?  Any effort to change them?  Any possibility of deprecating them for external projects somehow?","commit_id":"30fb32cfeb38a4edb258bd7ebf77e735435b401b"}],"neutron/db/l3_attrs_db.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e8e196ff159e6c686715ed0539831bd69ec8210f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    availability_zone_hints \u003d sa.Column(sa.String(255))"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    router \u003d orm.relationship("},{"line_number":50,"context_line":"        \u0027Router\u0027,"},{"line_number":51,"context_line":"        backref\u003dorm.backref(\"extra_attributes\", lazy\u003d\u0027joined\u0027,"},{"line_number":52,"context_line":"                            uselist\u003dFalse, cascade\u003d\u0027delete\u0027))"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_9e574657","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":16},"updated":"2016-01-06 23:20:45.000000000","message":"This change might seem a little random at first too but it gets around a circular import.","commit_id":"30fb32cfeb38a4edb258bd7ebf77e735435b401b"}],"neutron/db/l3_db.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"41f0ffb4d8e244759dd984083e576fd551082bef","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    gw_port_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027ports.id\u0027))"},{"line_number":91,"context_line":"    gw_port \u003d orm.relationship(models_v2.Port, lazy\u003d\u0027joined\u0027)"},{"line_number":92,"context_line":"    attached_ports \u003d orm.relationship("},{"line_number":93,"context_line":"        RouterPort,"},{"line_number":94,"context_line":"        backref\u003d\u0027router\u0027,"},{"line_number":95,"context_line":"        lazy\u003d\u0027dynamic\u0027)"},{"line_number":96,"context_line":"    l3_agents \u003d orm.relationship("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_4002e40c","line":93,"updated":"2016-01-03 08:00:56.000000000","message":"why was https://review.openstack.org/#/c/261222/1/neutron/db/l3_attrs_db.py changed to \u0027Router\u0027 and here it is not changed?","commit_id":"30fb32cfeb38a4edb258bd7ebf77e735435b401b"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e8e196ff159e6c686715ed0539831bd69ec8210f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    gw_port_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027ports.id\u0027))"},{"line_number":91,"context_line":"    gw_port \u003d orm.relationship(models_v2.Port, lazy\u003d\u0027joined\u0027)"},{"line_number":92,"context_line":"    attached_ports \u003d orm.relationship("},{"line_number":93,"context_line":"        RouterPort,"},{"line_number":94,"context_line":"        backref\u003d\u0027router\u0027,"},{"line_number":95,"context_line":"        lazy\u003d\u0027dynamic\u0027)"},{"line_number":96,"context_line":"    l3_agents \u003d orm.relationship("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_bbcfbc54","line":93,"in_reply_to":"fa69d971_4002e40c","updated":"2016-01-06 23:20:45.000000000","message":"The other change was needed to remove a circular import that otherwise wouldn\u0027t been introduced by this patch set.  This reference to RouterPort here is local to this file and so it can\u0027t cause a circular import.\n\nChanging this would be out of scope for this patch.\n\n  Cyclic import (neutron.db.l3_agentschedulers_db -\u003e neutron.db.l3_attrs_db -\u003e neutron.db.l3_db)","commit_id":"30fb32cfeb38a4edb258bd7ebf77e735435b401b"}]}