)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b349f4cc14cc6bbbe3d193a57e2419f79f51a0f5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-12-24 06:50:00 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow other extension to extend Securitygroup resources"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8c462a4ee6f60ef716bf9e4d7f83a35c7e1dead0"},{"line_number":10,"context_line":"Closes-Bug: #1529109"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_7591b846","line":8,"updated":"2015-12-27 13:54:51.000000000","message":"Can you please add some comments to the commit message here. It is unclear.\n\nCan you maybe provide an example if possible","commit_id":"83e2dd250ba3db3bc219ec429a37fb1108994240"}],"neutron/extensions/securitygroup.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b349f4cc14cc6bbbe3d193a57e2419f79f51a0f5","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        return exts"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def update_attributes_map(self, attributes):"},{"line_number":338,"context_line":"        super(Securitygroup, self).update_attributes_map("},{"line_number":339,"context_line":"            attributes, extension_attrs_map\u003dRESOURCE_ATTRIBUTE_MAP)"},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_9596a43d","line":337,"updated":"2015-12-27 13:54:51.000000000","message":"please add a unit tests for the new method","commit_id":"83e2dd250ba3db3bc219ec429a37fb1108994240"},{"author":{"_account_id":9423,"name":"Roey Chen","email":"roeyc@vmware.com","username":"roeyc"},"change_message_id":"9b937e0bd3834c2d45d90b56399a1504ea038c40","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        return exts"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def update_attributes_map(self, attributes):"},{"line_number":338,"context_line":"        super(Securitygroup, self).update_attributes_map("},{"line_number":339,"context_line":"            attributes, extension_attrs_map\u003dRESOURCE_ATTRIBUTE_MAP)"},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_b54c00c9","line":337,"in_reply_to":"1a7b0d38_9596a43d","updated":"2015-12-27 14:44:51.000000000","message":"I think that this method should (if not already) be tested together with the rest of the extensions loading process.\nAdding this test to each extension which override this method will end up in duplicated code and the same procedure will be tested couple of times with the same inputs.","commit_id":"83e2dd250ba3db3bc219ec429a37fb1108994240"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5dca4795e383791be9c9f0d0e06e1ba430e56d1f","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        return exts"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def update_attributes_map(self, attributes):"},{"line_number":338,"context_line":"        super(Securitygroup, self).update_attributes_map("},{"line_number":339,"context_line":"            attributes, extension_attrs_map\u003dRESOURCE_ATTRIBUTE_MAP)"},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_4e6aaeef","line":337,"updated":"2016-01-06 00:00:19.000000000","message":"I\u0027m not sure what this is buying us. Why not just call the super method from the thing extending it? This class doesn\u0027t define this function anyway so it\u0027s not like it\u0027s going to interfere with the call.","commit_id":"0ee7a333d992b81dbee08279c3289690d5e97617"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5437fed7b089d8b1e7c84897be4a68619f3521f1","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        return exts"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def update_attributes_map(self, attributes):"},{"line_number":338,"context_line":"        super(Securitygroup, self).update_attributes_map("},{"line_number":339,"context_line":"            attributes, extension_attrs_map\u003dRESOURCE_ATTRIBUTE_MAP)"},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_ae27aac8","line":337,"updated":"2016-01-06 00:03:38.000000000","message":"I\u0027m not sure what this is buying us. Why not just call the super method from the thing extending it? This class doesn\u0027t define this function anyway so it\u0027s not like it\u0027s going to interfere with the call.","commit_id":"0ee7a333d992b81dbee08279c3289690d5e97617"},{"author":{"_account_id":9423,"name":"Roey Chen","email":"roeyc@vmware.com","username":"roeyc"},"change_message_id":"bd028342689ac71e279eaf1cbda9b9a5566a7c85","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        return exts"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def update_attributes_map(self, attributes):"},{"line_number":338,"context_line":"        super(Securitygroup, self).update_attributes_map("},{"line_number":339,"context_line":"            attributes, extension_attrs_map\u003dRESOURCE_ATTRIBUTE_MAP)"},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_45282e33","line":337,"in_reply_to":"fa69d971_ae27aac8","updated":"2016-01-06 17:14:17.000000000","message":"It would not work (to the best of my knowledge), unless the plugin does not specify \u0027security-group\u0027 in it\u0027s supported extensions, that may complicate stuff (e.g - Horizon support).\nIt also complicates stuff when you have more than one extension which requires to extend the same extension.\n\nThe way it\u0027s done in Neutron today is through this function, as it expose the extension attribute map so other extensions could access it and add attributes.\nAlternatively, One could import this module and directly update the attribute map here, but thats ugly and redundant, given we already have a procedure to achieve that goal (by overriding this method).","commit_id":"0ee7a333d992b81dbee08279c3289690d5e97617"}]}
