)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"afba8979f7536a041cb85e482283379ba2bc6bdb","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-12-26 12:11:52 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds support to provide udpcsum option for Linux Bridge"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ice9584ef9ad2a8df4dac303b5a6b63e398526463"},{"line_number":10,"context_line":"Closes-bug:  #1515069"},{"line_number":11,"context_line":"Related-Bug: #1492111"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a7b0d38_3686e313","line":8,"updated":"2015-12-26 09:30:41.000000000","message":"Please provide some useful information for helping others review.","commit_id":"67f50617f7560c0c39be5872b0da0b1d1a101c08"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"eae0498e124baaed3112ad1bf260da57960ee248","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The new option for the linux bridge agent will enable to"},{"line_number":10,"context_line":"set/unset the udpcsum option for the vxlan tunnels."},{"line_number":11,"context_line":"This enable gro on the receiver with some network card."},{"line_number":12,"context_line":"The default is maintained as False."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa69d971_9e02bf3d","line":11,"updated":"2015-12-30 09:05:08.000000000","message":"this sentence does not make sense to me. Please change gro to GRO, and enable \u003d\u003e enables\n\nDo you mean same instead of some?","commit_id":"5d3e17091e237bec2145dec829734148059dc5ed"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"eae0498e124baaed3112ad1bf260da57960ee248","unresolved":false,"context_lines":[{"line_number":10,"context_line":"set/unset the udpcsum option for the vxlan tunnels."},{"line_number":11,"context_line":"This enable gro on the receiver with some network card."},{"line_number":12,"context_line":"The default is maintained as False."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact:"},{"line_number":15,"context_line":"Change-Id: Ice9584ef9ad2a8df4dac303b5a6b63e398526463"},{"line_number":16,"context_line":"Closes-bug:  #1515069"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa69d971_5efc473e","line":13,"updated":"2015-12-30 09:05:08.000000000","message":"Can you please add a release note for this","commit_id":"5d3e17091e237bec2145dec829734148059dc5ed"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"24a6747a1a7645725dbcdf0e7c463b2a240facf4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This enables GRO on the receiver with some network card."},{"line_number":12,"context_line":"The default is maintained as False."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact: Add udpcsum option to enable GRO on the receiver"},{"line_number":15,"context_line":"Change-Id: Ice9584ef9ad2a8df4dac303b5a6b63e398526463"},{"line_number":16,"context_line":"Closes-bug:  #1515069"},{"line_number":17,"context_line":"Related-Bug: #1492111"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"fa69d971_84ca7a6d","line":14,"updated":"2016-01-07 12:27:24.000000000","message":"please can you add the release note to this patch. i think having the kernel and iproute limitations there will be great","commit_id":"3268ec282e390b4dc1152d7807c630262f0410fd"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"c23535b344f2e70a00b422c9025927ca9e21f7a6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The new option for the linux bridge agent will enable to"},{"line_number":10,"context_line":"set/unset the udpcsum option for the vxlan tunnels."},{"line_number":11,"context_line":"This enables GRO on the receiver with some network card."},{"line_number":12,"context_line":"The default is maintained as False."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This feature requires kernel 3.16+[1] and iproute2 3.18.0+[2]"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"dae33548_9b9390a3","line":12,"range":{"start_line":12,"start_character":29,"end_line":12,"end_character":34},"updated":"2016-02-15 09:12:35.000000000","message":"I think it changed to True, right?","commit_id":"ade5d5ad26adcb0740f811f6392c99e488106652"}],"neutron/cmd/sanity/checks.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"588b882229bb14f957d26b55054942c682f8029e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    try:"},{"line_number":73,"context_line":"        port \u003d ip.add_vxlan(name, 3000, udpcsum\u003dTrue)"},{"line_number":74,"context_line":"        ip.del_veth(name)"},{"line_number":75,"context_line":"        return name \u003d\u003d port.name"},{"line_number":76,"context_line":"    except RuntimeError:"},{"line_number":77,"context_line":"        LOG.debug(\"Current iproute2 version does not support \""},{"line_number":78,"context_line":"                  \"udpcsum option.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_a862693c","line":75,"updated":"2016-01-05 07:52:51.000000000","message":"why is checking the names equivalent here necessary? can you add a note in the code explaining why if so? it\u0027s not obvious that it has anything to do with ucpcsum support","commit_id":"83a4dab3885f8424a21863663b9f94a2693b28b1"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"fe4549a3da1242d5f94c7e1fd8e473453eb23784","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    return name \u003d\u003d port.name"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def iproute2_vxlan_udpcsum_supported():"},{"line_number":70,"context_line":"    ip \u003d ip_lib.IPWrapper()"},{"line_number":71,"context_line":"    name \u003d \"vxlantest-\" + utils.get_random_string(4)"},{"line_number":72,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_8c9959c6","line":69,"range":{"start_line":69,"start_character":4,"end_line":69,"end_character":38},"updated":"2016-01-07 01:24:04.000000000","message":"It seems this method always returns None except RuntimeError case. I believe that that\u0027s not your expecting.","commit_id":"ef1fb6de58d206cbc43012b3a9e84f7eb4d7561a"}],"neutron/cmd/sanity_check.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"eae0498e124baaed3112ad1bf260da57960ee248","unresolved":false,"context_lines":[{"line_number":81,"context_line":"def check_iproute2_vxlan_udpcsum():"},{"line_number":82,"context_line":"    result \u003d checks.iproute2_vxlan_udpcsum_supported()"},{"line_number":83,"context_line":"    if not result:"},{"line_number":84,"context_line":"        LOG.error(_LE(\u0027Check for iproute2 udpcsum VXLAN support failed.\u0027"},{"line_number":85,"context_line":"                      \u0027Please ensure that the iproute2 has udpcsum support.\u0027))"},{"line_number":86,"context_line":"    return result"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_be51c364","line":84,"updated":"2015-12-30 09:05:08.000000000","message":"missing space at the end of the sentence","commit_id":"5d3e17091e237bec2145dec829734148059dc5ed"}],"neutron/plugins/ml2/drivers/linuxbridge/agent/common/config.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d54d55ba390da730dfd2d9cbd1cd8e985bef7794","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                       \"VXLAN forwarding table.\")),"},{"line_number":49,"context_line":"    cfg.BoolOpt(\u0027udpcsum\u0027, default\u003dFalse,"},{"line_number":50,"context_line":"                help\u003d_(\"Set or un-set the outer UDP header checksum \""},{"line_number":51,"context_line":"                       \"to improve vxlan performance. \")),"},{"line_number":52,"context_line":"]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"bridge_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_b4f3fb72","line":51,"range":{"start_line":51,"start_character":53,"end_line":51,"end_character":54},"updated":"2015-12-31 12:43:38.000000000","message":"Plz remove the extra space before the period.","commit_id":"5d3e17091e237bec2145dec829734148059dc5ed"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"45cd2ec442dafbfe4602421b9aaff4e2b43fbdf8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                       \"VXLAN forwarding table.\")),"},{"line_number":49,"context_line":"    cfg.BoolOpt(\u0027udpcsum\u0027, default\u003dFalse,"},{"line_number":50,"context_line":"                help\u003d_(\"Set or un-set the outer UDP header checksum \""},{"line_number":51,"context_line":"                       \"to improve vxlan performance. \")),"},{"line_number":52,"context_line":"]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"bridge_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_5b5f7c0e","line":51,"updated":"2015-12-30 05:15:53.000000000","message":"You can add a message to user about the supported kernel and iproute version.","commit_id":"5d3e17091e237bec2145dec829734148059dc5ed"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2e3f51b69f0a667233ac8bd30cfeae84dd0434b0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                       \"VXLAN forwarding table.\")),"},{"line_number":49,"context_line":"    cfg.BoolOpt(\u0027udpcsum\u0027, default\u003dFalse,"},{"line_number":50,"context_line":"                help\u003d_(\"Set or un-set the outer UDP header checksum \""},{"line_number":51,"context_line":"                       \"to improve vxlan performance.\""},{"line_number":52,"context_line":"                       \"(require kernel 3.12 and iproute2 3.18.0)\")),"},{"line_number":53,"context_line":"]"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_e65093d6","line":51,"updated":"2016-01-05 07:23:05.000000000","message":"Please add a space at last.","commit_id":"83a4dab3885f8424a21863663b9f94a2693b28b1"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"205bd948ba5a7d206287b508596b22cddbf2e045","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                help\u003d_(\"Extension to use alongside ml2 plugin\u0027s l2population \""},{"line_number":47,"context_line":"                       \"mechanism driver. It enables the plugin to populate \""},{"line_number":48,"context_line":"                       \"VXLAN forwarding table.\")),"},{"line_number":49,"context_line":"    cfg.BoolOpt(\u0027udpcsum\u0027, default\u003dFalse,"},{"line_number":50,"context_line":"                help\u003d_(\"Set or un-set the outer UDP header checksum \""},{"line_number":51,"context_line":"                       \"to improve vxlan performance. \""},{"line_number":52,"context_line":"                       \"(require kernel 3.12 and iproute2 3.18.0)\")),"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_9895f789","line":49,"updated":"2016-01-07 16:36:01.000000000","message":"Consider using a more generic (or less obscure) name for the option, such as \u0027udp_checksum\u0027 to prevent dependency of neutron configuration options on future changes or additions to iproute2.","commit_id":"3268ec282e390b4dc1152d7807c630262f0410fd"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"24a6747a1a7645725dbcdf0e7c463b2a240facf4","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    cfg.BoolOpt(\u0027udpcsum\u0027, default\u003dFalse,"},{"line_number":50,"context_line":"                help\u003d_(\"Set or un-set the outer UDP header checksum \""},{"line_number":51,"context_line":"                       \"to improve vxlan performance. \""},{"line_number":52,"context_line":"                       \"(require kernel 3.12 and iproute2 3.18.0)\")),"},{"line_number":53,"context_line":"]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"bridge_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_e4d1f630","line":52,"range":{"start_line":52,"start_character":25,"end_line":52,"end_character":32},"updated":"2016-01-07 12:27:24.000000000","message":"require \u003d\u003e requires\n\ni assume that these are the minimum versions right? maybe it is worthwhile to add that comment here - or update that on the commit message","commit_id":"3268ec282e390b4dc1152d7807c630262f0410fd"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"205bd948ba5a7d206287b508596b22cddbf2e045","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    cfg.BoolOpt(\u0027udpcsum\u0027, default\u003dFalse,"},{"line_number":50,"context_line":"                help\u003d_(\"Set or un-set the outer UDP header checksum \""},{"line_number":51,"context_line":"                       \"to improve vxlan performance. \""},{"line_number":52,"context_line":"                       \"(require kernel 3.12 and iproute2 3.18.0)\")),"},{"line_number":53,"context_line":"]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"bridge_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_161c7976","line":52,"range":{"start_line":52,"start_character":25,"end_line":52,"end_character":32},"in_reply_to":"fa69d971_e4d1f630","updated":"2016-01-07 16:36:01.000000000","message":"Suggestion:\n\nEnable UDP header checksums to improve performance. Requires kernel 3.16+ and iproute2 3.18.0+.","commit_id":"3268ec282e390b4dc1152d7807c630262f0410fd"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"8b31e69b50dc003b20b07472468d85c536d3811d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                help\u003d_(\"Extension to use alongside ml2 plugin\u0027s l2population \""},{"line_number":46,"context_line":"                       \"mechanism driver. It enables the plugin to populate \""},{"line_number":47,"context_line":"                       \"VXLAN forwarding table.\")),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027udp_checksum\u0027, default\u003dFalse,"},{"line_number":49,"context_line":"                help\u003d_(\"Enable UDP header checksums to improve performance. \""},{"line_number":50,"context_line":"                       \"This valid only GSO and GRO are enabled. \""},{"line_number":51,"context_line":"                       \"Requires kernel 3.16+ and iproute2 3.18.0+.\"))"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_9059df5c","line":48,"updated":"2016-01-22 11:03:54.000000000","message":"Does it make sense for this to be default as false? Would it make sense to check if it is running on a 3.16+ kernel and iproute2 3.18.0+ and automatically turn on?","commit_id":"47e89264b49b18a6dde55cd96d276b0443e52d69"},{"author":{"_account_id":19225,"name":"okamoto_takashi_p3","email":"okamoto_takashi_p3@lab.ntt.co.jp","username":"okamoto_takashi_p3"},"change_message_id":"ec8a2674ee7bf72a564c6e184883040b26e6906e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                help\u003d_(\"Extension to use alongside ml2 plugin\u0027s l2population \""},{"line_number":46,"context_line":"                       \"mechanism driver. It enables the plugin to populate \""},{"line_number":47,"context_line":"                       \"VXLAN forwarding table.\")),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027udp_checksum\u0027, default\u003dFalse,"},{"line_number":49,"context_line":"                help\u003d_(\"Enable UDP header checksums to improve performance. \""},{"line_number":50,"context_line":"                       \"This valid only GSO and GRO are enabled. \""},{"line_number":51,"context_line":"                       \"Requires kernel 3.16+ and iproute2 3.18.0+.\"))"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a5ae5dd_a59248f4","line":48,"in_reply_to":"9a68dd71_9059df5c","updated":"2016-02-08 09:55:23.000000000","message":"The kernel back ported feature could supports csum.\nThe csum enabled receiver\u0027s CPU average is higher than\ndisabled.\nThere are cases where csum make performance slow\nlike: https://www.mail-archive.com/dev@openvswitch.org/msg55165.html\n\nTherefore I would like to make it false in default.","commit_id":"47e89264b49b18a6dde55cd96d276b0443e52d69"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"8b31e69b50dc003b20b07472468d85c536d3811d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                       \"VXLAN forwarding table.\")),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027udp_checksum\u0027, default\u003dFalse,"},{"line_number":49,"context_line":"                help\u003d_(\"Enable UDP header checksums to improve performance. \""},{"line_number":50,"context_line":"                       \"This valid only GSO and GRO are enabled. \""},{"line_number":51,"context_line":"                       \"Requires kernel 3.16+ and iproute2 3.18.0+.\"))"},{"line_number":52,"context_line":"]"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_f085bbac","line":50,"updated":"2016-01-22 11:03:54.000000000","message":"This needs to be clarified. \n\n\"This feature is only able to be used if GSO and GRO are enabled.\"","commit_id":"47e89264b49b18a6dde55cd96d276b0443e52d69"}],"neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"7909b891b91cf9fbe181d835b5d565bb314f6357","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            if cfg.CONF.VXLAN.l2_population:"},{"line_number":270,"context_line":"                args[\u0027proxy\u0027] \u003d True"},{"line_number":271,"context_line":"            if cfg.CONF.VXLAN.udp_checksum:"},{"line_number":272,"context_line":"                csum_chk \u003d checks.iproute2_vxlan_udpcsum_supported()"},{"line_number":273,"context_line":"                if csum_chk:"},{"line_number":274,"context_line":"                    args[\u0027udpcsum\u0027] \u003d True"},{"line_number":275,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a57f1b5_0a31ad0b","line":272,"updated":"2016-02-10 00:33:44.000000000","message":"this is not something we want to call on every setup. once during the agent start with an error message if they have it enabled but their kernel doesn\u0027t support it. Then you can just override it to false and safely reference the config value here.","commit_id":"9b506b7f32048695bf0fe99be8e0a7cdc9b6b6fc"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"c23535b344f2e70a00b422c9025927ca9e21f7a6","unresolved":false,"context_lines":[{"line_number":863,"context_line":"        if not udpcsum_support:"},{"line_number":864,"context_line":"            cfg.CONF.VXLAN.udp_checksum \u003d False"},{"line_number":865,"context_line":"            LOG.warning(_LW(\u0027udp checksum is unavailable. \u0027"},{"line_number":866,"context_line":"                            \u0027set udp_checksum option as False.\u0027))"},{"line_number":867,"context_line":"    try:"},{"line_number":868,"context_line":"        interface_mappings \u003d n_utils.parse_mappings("},{"line_number":869,"context_line":"            cfg.CONF.LINUX_BRIDGE.physical_interface_mappings)"}],"source_content_type":"text/x-python","patch_set":17,"id":"dae33548_7bddec41","line":866,"updated":"2016-02-15 09:12:35.000000000","message":"2 Things\n- maybe you could list the requirements to enable it (e.g. kernel \u003e ...)\n- I would prefer you use a whole sentence here. From this message it\u0027s not clear to me if the feature now has been disabled or if the admin should change the value in the config file. Maybe something like \"udp checksumming has been disabled\" would be more clear.","commit_id":"ade5d5ad26adcb0740f811f6392c99e488106652"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5c3e210e3a6acdb1ad92f66b38207a79058a1de7","unresolved":false,"context_lines":[{"line_number":861,"context_line":"    if cfg.CONF.VXLAN.udp_checksum:"},{"line_number":862,"context_line":"        udpcsum_support \u003d checks.iproute2_vxlan_udpcsum_supported()"},{"line_number":863,"context_line":"        if not udpcsum_support:"},{"line_number":864,"context_line":"            cfg.CONF.VXLAN.udp_checksum \u003d False"},{"line_number":865,"context_line":"            LOG.warning(_LW(\u0027udp checksumming has been disabled. \u0027"},{"line_number":866,"context_line":"                            \u0027udp_checksum requires kernel 3.16+ and \u0027"},{"line_number":867,"context_line":"                            \u0027iproute2 3.18.0+. \u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"da0c15f0_71313c05","line":864,"updated":"2016-03-28 10:19:11.000000000","message":"I think you can do it with cfg.CONF.set_override(\u0027udp_checksum\u0027, False, group\u003d\u0027VXLAN\u0027)","commit_id":"facbaaaa84a2ab5f2857c809949c07466619d135"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"402f1bdf81541fd3ca2a70d6b4eef954459a014b","unresolved":false,"context_lines":[{"line_number":861,"context_line":"    if cfg.CONF.VXLAN.udp_checksum:"},{"line_number":862,"context_line":"        udpcsum_support \u003d checks.iproute2_vxlan_udpcsum_supported()"},{"line_number":863,"context_line":"        if not udpcsum_support:"},{"line_number":864,"context_line":"            cfg.CONF.VXLAN.udp_checksum \u003d False"},{"line_number":865,"context_line":"            LOG.warning(_LW(\u0027udp checksumming has been disabled. \u0027"},{"line_number":866,"context_line":"                            \u0027udp_checksum requires kernel 3.16+ and \u0027"},{"line_number":867,"context_line":"                            \u0027iproute2 3.18.0+. \u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_9db4b682","line":864,"updated":"2016-02-17 08:08:56.000000000","message":"Seems like that this line does not have any effect [1] \n\n\n[1] http://logs.openstack.org/09/261409/19/check/gate-tempest-dsvm-neutron-linuxbridge/025e01b/logs/screen-q-agt.txt.gz#_2016-02-17_02_11_06_780","commit_id":"facbaaaa84a2ab5f2857c809949c07466619d135"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"fc0d6f18a3a04dc3b5ab905af222053f87349d9c","unresolved":false,"context_lines":[{"line_number":861,"context_line":"    if cfg.CONF.VXLAN.udp_checksum:"},{"line_number":862,"context_line":"        udpcsum_support \u003d checks.iproute2_vxlan_udpcsum_supported()"},{"line_number":863,"context_line":"        if not udpcsum_support:"},{"line_number":864,"context_line":"            cfg.CONF.VXLAN.udp_checksum \u003d False"},{"line_number":865,"context_line":"            LOG.warning(_LW(\u0027udp checksumming has been disabled. \u0027"},{"line_number":866,"context_line":"                            \u0027udp_checksum requires kernel 3.16+ and \u0027"},{"line_number":867,"context_line":"                            \u0027iproute2 3.18.0+. \u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba0121b8_97e22502","line":864,"in_reply_to":"da0c15f0_71313c05","updated":"2016-03-29 16:14:38.000000000","message":"yes, that should work - alternatively, pass udpcsum_support into the linuxbridge manager as argument and access it from there with self.udp_checksum instead of cfg.CONF...","commit_id":"facbaaaa84a2ab5f2857c809949c07466619d135"},{"author":{"_account_id":19225,"name":"okamoto_takashi_p3","email":"okamoto_takashi_p3@lab.ntt.co.jp","username":"okamoto_takashi_p3"},"change_message_id":"dda789bad75f02922249e318a5dca2be9ff68fee","unresolved":false,"context_lines":[{"line_number":861,"context_line":"    if cfg.CONF.VXLAN.udp_checksum:"},{"line_number":862,"context_line":"        udpcsum_support \u003d checks.iproute2_vxlan_udpcsum_supported()"},{"line_number":863,"context_line":"        if not udpcsum_support:"},{"line_number":864,"context_line":"            cfg.CONF.VXLAN.udp_checksum \u003d False"},{"line_number":865,"context_line":"            LOG.warning(_LW(\u0027udp checksumming has been disabled. \u0027"},{"line_number":866,"context_line":"                            \u0027udp_checksum requires kernel 3.16+ and \u0027"},{"line_number":867,"context_line":"                            \u0027iproute2 3.18.0+. \u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_ff717245","line":864,"in_reply_to":"dae33548_9db4b682","updated":"2016-02-17 09:30:27.000000000","message":"thanx. But I\u0027m afraid said, I don\u0027t have any idea to change configuration when udpcsum fail.\nDo you have a idea?","commit_id":"facbaaaa84a2ab5f2857c809949c07466619d135"}],"neutron/tests/unit/agent/linux/test_ip_lib.py":[{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"45cd2ec442dafbfe4602421b9aaff4e2b43fbdf8","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                          local\u003d\u0027local0\u0027, proxy\u003dTrue,"},{"line_number":478,"context_line":"                          port\u003d(\u00271\u0027, \u00272\u0027, \u00273\u0027))"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    def test_add_vxlan_udpcsum(self):"},{"line_number":481,"context_line":"        retval \u003d ip_lib.IPWrapper().add_vxlan(\u0027vxlan0\u0027, \u0027vni0\u0027,"},{"line_number":482,"context_line":"                                              group\u003d\u0027group0\u0027,"},{"line_number":483,"context_line":"                                              dev\u003d\u0027dev0\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_bba47808","line":480,"updated":"2015-12-30 05:15:53.000000000","message":"Check the kernel version and iproute version, if it is less than 3.18, you can skip this test case to make sure the gate is working.","commit_id":"5d3e17091e237bec2145dec829734148059dc5ed"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"588b882229bb14f957d26b55054942c682f8029e","unresolved":false,"context_lines":[{"line_number":479,"context_line":"                          port\u003d(\u00271\u0027, \u00272\u0027, \u00273\u0027))"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"    def test_add_vxlan_udpcsum(self):"},{"line_number":482,"context_line":"        if not checks.iproute2_vxlan_udpcsum_supported():"},{"line_number":483,"context_line":"            return"},{"line_number":484,"context_line":"        retval \u003d ip_lib.IPWrapper().add_vxlan(\u0027vxlan0\u0027, \u0027vni0\u0027,"},{"line_number":485,"context_line":"                                              group\u003d\u0027group0\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_c8679d4b","line":482,"updated":"2016-01-05 07:52:51.000000000","message":"we don\u0027t want to run santity checks in unit tests. the unit tests shouldn\u0027t be dependent on the underlying system. This test is just ensuring that the correct args are passed to the CLI so remove this check.","commit_id":"83a4dab3885f8424a21863663b9f94a2693b28b1"}],"neutron/tests/unit/plugins/ml2/drivers/linuxbridge/agent/test_linuxbridge_neutron_agent.py":[{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"45cd2ec442dafbfe4602421b9aaff4e2b43fbdf8","unresolved":false,"context_lines":[{"line_number":591,"context_line":"                                                dev\u003dself.lbm.local_int,"},{"line_number":592,"context_line":"                                                proxy\u003dTrue)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"    def test_ensure_vxlan_with_csum(self):"},{"line_number":595,"context_line":"        seg_id \u003d \"12345678\""},{"line_number":596,"context_line":"        self.lbm.local_int \u003d \u0027eth0\u0027"},{"line_number":597,"context_line":"        self.lbm.vxlan_mode \u003d lconst.VXLAN_MCAST"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_7bafe0e3","line":594,"updated":"2015-12-30 05:15:53.000000000","message":"Check the kernel version and the iproute version first to make sure it is supported and the gate is working properly.","commit_id":"5d3e17091e237bec2145dec829734148059dc5ed"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"588b882229bb14f957d26b55054942c682f8029e","unresolved":false,"context_lines":[{"line_number":593,"context_line":"                                                proxy\u003dTrue)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    def test_ensure_vxlan_with_csum(self):"},{"line_number":596,"context_line":"        if not checks.iproute2_vxlan_udpcsum_supported():"},{"line_number":597,"context_line":"            return"},{"line_number":598,"context_line":"        seg_id \u003d \"12345678\""},{"line_number":599,"context_line":"        self.lbm.local_int \u003d \u0027eth0\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_6858f18a","line":596,"updated":"2016-01-05 07:52:51.000000000","message":"same here, no sanity checks in unit tests","commit_id":"83a4dab3885f8424a21863663b9f94a2693b28b1"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2e3f51b69f0a667233ac8bd30cfeae84dd0434b0","unresolved":false,"context_lines":[{"line_number":600,"context_line":"        self.lbm.vxlan_mode \u003d lconst.VXLAN_MCAST"},{"line_number":601,"context_line":"        with mock.patch.object(ip_lib, \u0027device_exists\u0027) as de_fn:"},{"line_number":602,"context_line":"            de_fn.return_value \u003d True"},{"line_number":603,"context_line":"            self.assertEqual(self.lbm.ensure_vxlan(seg_id), \"vxlan-\" + seg_id)"},{"line_number":604,"context_line":"            de_fn.return_value \u003d False"},{"line_number":605,"context_line":"            with mock.patch.object(self.lbm.ip,"},{"line_number":606,"context_line":"                                   \u0027add_vxlan\u0027) as add_vxlan_fn:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_e6a89379","line":603,"range":{"start_line":603,"start_character":12,"end_line":603,"end_character":78},"updated":"2016-01-05 07:23:05.000000000","message":"It\u0027s better to use the pattern \"self.assertEqual(expected, observed)\"[1].\n[1]: https://github.com/openstack/neutron/blob/master/doc/source/devref/effective_neutron.rst#mocking-and-testing","commit_id":"83a4dab3885f8424a21863663b9f94a2693b28b1"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2e3f51b69f0a667233ac8bd30cfeae84dd0434b0","unresolved":false,"context_lines":[{"line_number":605,"context_line":"            with mock.patch.object(self.lbm.ip,"},{"line_number":606,"context_line":"                                   \u0027add_vxlan\u0027) as add_vxlan_fn:"},{"line_number":607,"context_line":"                add_vxlan_fn.return_value \u003d FakeIpDevice()"},{"line_number":608,"context_line":"                self.assertEqual(self.lbm.ensure_vxlan(seg_id),"},{"line_number":609,"context_line":"                                 \"vxlan-\" + seg_id)"},{"line_number":610,"context_line":"                add_vxlan_fn.assert_called_with(\"vxlan-\" + seg_id, seg_id,"},{"line_number":611,"context_line":"                                                group\u003d\"224.0.0.1\","},{"line_number":612,"context_line":"                                                dev\u003dself.lbm.local_int)"},{"line_number":613,"context_line":"                cfg.CONF.set_override(\u0027l2_population\u0027, \u0027True\u0027, \u0027VXLAN\u0027)"},{"line_number":614,"context_line":"                cfg.CONF.set_override(\u0027udpcsum\u0027, \u0027True\u0027, \u0027VXLAN\u0027)"},{"line_number":615,"context_line":"                self.assertEqual(self.lbm.ensure_vxlan(seg_id),"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_c6478fba","line":612,"range":{"start_line":608,"start_character":16,"end_line":612,"end_character":71},"updated":"2016-01-05 07:23:05.000000000","message":"Do we need a pattern without udpcsum? I think that this test should check udpcsum only.","commit_id":"83a4dab3885f8424a21863663b9f94a2693b28b1"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2e3f51b69f0a667233ac8bd30cfeae84dd0434b0","unresolved":false,"context_lines":[{"line_number":612,"context_line":"                                                dev\u003dself.lbm.local_int)"},{"line_number":613,"context_line":"                cfg.CONF.set_override(\u0027l2_population\u0027, \u0027True\u0027, \u0027VXLAN\u0027)"},{"line_number":614,"context_line":"                cfg.CONF.set_override(\u0027udpcsum\u0027, \u0027True\u0027, \u0027VXLAN\u0027)"},{"line_number":615,"context_line":"                self.assertEqual(self.lbm.ensure_vxlan(seg_id),"},{"line_number":616,"context_line":"                                 \"vxlan-\" + seg_id)"},{"line_number":617,"context_line":"                add_vxlan_fn.assert_called_with(\"vxlan-\" + seg_id, seg_id,"},{"line_number":618,"context_line":"                                                group\u003d\"224.0.0.1\","},{"line_number":619,"context_line":"                                                dev\u003dself.lbm.local_int,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_067fe715","line":616,"range":{"start_line":615,"start_character":16,"end_line":616,"end_character":51},"updated":"2016-01-05 07:23:05.000000000","message":"ditto","commit_id":"83a4dab3885f8424a21863663b9f94a2693b28b1"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"c23535b344f2e70a00b422c9025927ca9e21f7a6","unresolved":false,"context_lines":[{"line_number":359,"context_line":"                                                proxy\u003dTrue,"},{"line_number":360,"context_line":"                                                udpcsum\u003dTrue)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def test_ensure_vxlan_without_csum(self):"},{"line_number":363,"context_line":"        seg_id \u003d \"12345678\""},{"line_number":364,"context_line":"        self.lbm.local_int \u003d \u0027eth0\u0027"},{"line_number":365,"context_line":"        self.lbm.vxlan_mode \u003d lconst.VXLAN_MCAST"}],"source_content_type":"text/x-python","patch_set":17,"id":"dae33548_bbf8147e","line":362,"updated":"2016-02-15 09:12:35.000000000","message":"What about adding a new parameter to test_ensure_vxlan(self, udpcsum\u003dTrue)? Of course than change the lines udpcsum\u003dTrue to udpcsum\u003dudpcsum... (L352, L360)\nAnd then call this test twice, once with True and once with False. Doing so you could get rid of the following lines of code that are just duplicates...","commit_id":"ade5d5ad26adcb0740f811f6392c99e488106652"}]}
