)]}'
{"neutron/db/l3_agentschedulers_db.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"04c3b13d80933cbf46adc4b931202ac39d54bc7c","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        return self.get_sync_data(context, router_ids\u003drouter_ids, active\u003dTrue)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    def list_active_sync_routers_on_active_l3_agent("},{"line_number":374,"context_line":"            self, context, host, router_ids):"},{"line_number":375,"context_line":"        agent \u003d self._get_agent_by_type_and_host("},{"line_number":376,"context_line":"            context, constants.AGENT_TYPE_L3, host)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da6ed579_c3d4eabe","side":"PARENT","line":373,"range":{"start_line":373,"start_character":8,"end_line":373,"end_character":51},"updated":"2016-01-15 22:20:40.000000000","message":"It is really strange how gerrit decided to do this diff.  I think the whole diff would be easier to read if it had matched these lines with L388 - 393.  As far as I can tell, they haven\u0027t changed except for the indentation.\n\nWould you object to moving the new _get_router_ids_for_agent after list_active_sync_routers_on_active_l3_agent to help it out here?  I know it doesn\u0027t matter but it might help reviewers see the differences more easily.\n\nMaybe I\u0027ll just do it.  I hope you don\u0027t mind.","commit_id":"a24130ac568781fac9d8cc3346b6d70a9fc52edf"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"114ba60f900556a5025646784681838b3a3e07ce","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        return self.get_sync_data(context, router_ids\u003drouter_ids, active\u003dTrue)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    def list_active_sync_routers_on_active_l3_agent("},{"line_number":374,"context_line":"            self, context, host, router_ids):"},{"line_number":375,"context_line":"        agent \u003d self._get_agent_by_type_and_host("},{"line_number":376,"context_line":"            context, constants.AGENT_TYPE_L3, host)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da6ed579_b01c6778","side":"PARENT","line":373,"range":{"start_line":373,"start_character":8,"end_line":373,"end_character":51},"in_reply_to":"da6ed579_c3d4eabe","updated":"2016-01-18 10:55:45.000000000","message":"sure, I don\u0027t mind, thanks Carl","commit_id":"a24130ac568781fac9d8cc3346b6d70a9fc52edf"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"04c3b13d80933cbf46adc4b931202ac39d54bc7c","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    def list_active_sync_routers_on_active_l3_agent("},{"line_number":389,"context_line":"            self, context, host, router_ids):"},{"line_number":390,"context_line":"        agent \u003d self._get_agent_by_type_and_host("},{"line_number":391,"context_line":"                context, constants.AGENT_TYPE_L3, host)"},{"line_number":392,"context_line":"        if not agentschedulers_db.services_available(agent.admin_state_up):"},{"line_number":393,"context_line":"            return []"},{"line_number":394,"context_line":"        router_ids \u003d self._get_router_ids_for_agent("}],"source_content_type":"text/x-python","patch_set":9,"id":"da6ed579_43a9da7a","line":391,"range":{"start_line":391,"start_character":12,"end_line":391,"end_character":16},"updated":"2016-01-15 22:20:40.000000000","message":"This should be indented 4 spaces, I think.  It was in the original and I wonder if that would help gerrit display the diff a little more cleanly.","commit_id":"50833f391543ccbea75ac9717bbabc1a9cda3cb1"}],"neutron/db/l3_dvrscheduler_db.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"21ce4f374e9edd3877e771b3d06ec9f86514d082","unresolved":false,"context_lines":[{"line_number":493,"context_line":"            models_v2.Port.device_owner.in_("},{"line_number":494,"context_line":"                n_utils.get_other_dvr_serviced_device_owners()))"},{"line_number":495,"context_line":"        query \u003d query.filter(owner_filter)"},{"line_number":496,"context_line":"        subnet_ids \u003d [item[0] for item in query]"},{"line_number":497,"context_line":"        LOG.debug(\u0027Subnets on host %s for DVR: %s\u0027, host, subnet_ids)"},{"line_number":498,"context_line":"        return subnet_ids"},{"line_number":499,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_fee0a5ce","line":496,"range":{"start_line":496,"start_character":30,"end_line":496,"end_character":47},"updated":"2016-01-15 22:52:15.000000000","message":"This iteration triggers the query in the DB and the result is sent back.  But, on L507, I think you could make this query a subquery of that one and defer triggering the DB query until that query is triggered.","commit_id":"4e443f55c385fcb1a59eced41bc45dda6439aad5"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0db7d146b1654ca33d50271ecc517512aaefed2c","unresolved":false,"context_lines":[{"line_number":493,"context_line":"            models_v2.Port.device_owner.in_("},{"line_number":494,"context_line":"                n_utils.get_other_dvr_serviced_device_owners()))"},{"line_number":495,"context_line":"        query \u003d query.filter(owner_filter)"},{"line_number":496,"context_line":"        subnet_ids \u003d [item[0] for item in query]"},{"line_number":497,"context_line":"        LOG.debug(\u0027Subnets on host %s for DVR: %s\u0027, host, subnet_ids)"},{"line_number":498,"context_line":"        return subnet_ids"},{"line_number":499,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_da0ed1e4","line":496,"range":{"start_line":496,"start_character":30,"end_line":496,"end_character":47},"in_reply_to":"da6ed579_fee0a5ce","updated":"2016-01-18 13:07:25.000000000","message":"Done","commit_id":"4e443f55c385fcb1a59eced41bc45dda6439aad5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"732b9b0cb328457788a58e3b5325d44f3f6e6649","unresolved":false,"context_lines":[{"line_number":504,"context_line":"            models_v2.Port.device_owner \u003d\u003d n_const.DEVICE_OWNER_DVR_INTERFACE)"},{"line_number":505,"context_line":"        query \u003d query.join(models_v2.Port.fixed_ips)"},{"line_number":506,"context_line":"        query \u003d query.filter("},{"line_number":507,"context_line":"            models_v2.IPAllocation.subnet_id.in_(subnet_ids_on_host))"},{"line_number":508,"context_line":"        router_ids \u003d [item[0] for item in query]"},{"line_number":509,"context_line":"        LOG.debug(\u0027DVR routers on host %s: %s\u0027, host, router_ids)"},{"line_number":510,"context_line":"        return router_ids"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_3e471d4d","line":507,"range":{"start_line":507,"start_character":49,"end_line":507,"end_character":67},"updated":"2016-01-15 22:28:44.000000000","message":"I really think that it isn\u0027t too hard to do this as a subquery so that the entire thing could be run by the DB in one shot.  Let me look in to it a bit.","commit_id":"4e443f55c385fcb1a59eced41bc45dda6439aad5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"21ce4f374e9edd3877e771b3d06ec9f86514d082","unresolved":false,"context_lines":[{"line_number":504,"context_line":"            models_v2.Port.device_owner \u003d\u003d n_const.DEVICE_OWNER_DVR_INTERFACE)"},{"line_number":505,"context_line":"        query \u003d query.join(models_v2.Port.fixed_ips)"},{"line_number":506,"context_line":"        query \u003d query.filter("},{"line_number":507,"context_line":"            models_v2.IPAllocation.subnet_id.in_(subnet_ids_on_host))"},{"line_number":508,"context_line":"        router_ids \u003d [item[0] for item in query]"},{"line_number":509,"context_line":"        LOG.debug(\u0027DVR routers on host %s: %s\u0027, host, router_ids)"},{"line_number":510,"context_line":"        return router_ids"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_3e9b9d74","line":507,"range":{"start_line":507,"start_character":49,"end_line":507,"end_character":67},"in_reply_to":"da6ed579_3e471d4d","updated":"2016-01-15 22:52:15.000000000","message":"I think is as easy as returning the query on L480 instead of creating a list in memory and passing that back.  I think it would avoid a round trip to the DB because that query would become a subquery of this query.","commit_id":"4e443f55c385fcb1a59eced41bc45dda6439aad5"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0db7d146b1654ca33d50271ecc517512aaefed2c","unresolved":false,"context_lines":[{"line_number":504,"context_line":"            models_v2.Port.device_owner \u003d\u003d n_const.DEVICE_OWNER_DVR_INTERFACE)"},{"line_number":505,"context_line":"        query \u003d query.join(models_v2.Port.fixed_ips)"},{"line_number":506,"context_line":"        query \u003d query.filter("},{"line_number":507,"context_line":"            models_v2.IPAllocation.subnet_id.in_(subnet_ids_on_host))"},{"line_number":508,"context_line":"        router_ids \u003d [item[0] for item in query]"},{"line_number":509,"context_line":"        LOG.debug(\u0027DVR routers on host %s: %s\u0027, host, router_ids)"},{"line_number":510,"context_line":"        return router_ids"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_9af939cb","line":507,"range":{"start_line":507,"start_character":49,"end_line":507,"end_character":67},"in_reply_to":"da6ed579_3e9b9d74","updated":"2016-01-18 13:07:25.000000000","message":"Done","commit_id":"4e443f55c385fcb1a59eced41bc45dda6439aad5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"21ce4f374e9edd3877e771b3d06ec9f86514d082","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        return router_ids"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def _get_router_ids_for_agent(self, context, agent_db, router_ids):"},{"line_number":513,"context_line":"        result_list \u003d super(L3_DVRsch_db_mixin,"},{"line_number":514,"context_line":"                            self)._get_router_ids_for_agent("},{"line_number":515,"context_line":"            context, agent_db, router_ids)"},{"line_number":516,"context_line":"        if router_ids and set(result_list) \u003d\u003d set(router_ids):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_be38ed3e","line":513,"range":{"start_line":513,"start_character":8,"end_line":513,"end_character":19},"updated":"2016-01-15 22:52:15.000000000","message":"Suggestion:  Convert this to a set here.  All of the code below seems to naturally want to work with a set and there are redundant conversions to set (L516, L529, L536)","commit_id":"4e443f55c385fcb1a59eced41bc45dda6439aad5"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0db7d146b1654ca33d50271ecc517512aaefed2c","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        return router_ids"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def _get_router_ids_for_agent(self, context, agent_db, router_ids):"},{"line_number":513,"context_line":"        result_list \u003d super(L3_DVRsch_db_mixin,"},{"line_number":514,"context_line":"                            self)._get_router_ids_for_agent("},{"line_number":515,"context_line":"            context, agent_db, router_ids)"},{"line_number":516,"context_line":"        if router_ids and set(result_list) \u003d\u003d set(router_ids):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_25ffce02","line":513,"range":{"start_line":513,"start_character":8,"end_line":513,"end_character":19},"in_reply_to":"da6ed579_be38ed3e","updated":"2016-01-18 13:07:25.000000000","message":"Done","commit_id":"4e443f55c385fcb1a59eced41bc45dda6439aad5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"21ce4f374e9edd3877e771b3d06ec9f86514d082","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        if router_ids and set(result_list) \u003d\u003d set(router_ids):"},{"line_number":517,"context_line":"            # no need for extra dvr checks if requested routers are"},{"line_number":518,"context_line":"            # explicitly scheduled to the agent"},{"line_number":519,"context_line":"            return result_list"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"        # dvr routers are not explicitly scheduled to agents on hosts with"},{"line_number":522,"context_line":"        # dvr serviceable ports so need special handling"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_5e253108","line":519,"range":{"start_line":519,"start_character":19,"end_line":519,"end_character":30},"updated":"2016-01-15 22:52:15.000000000","message":"You can convert back to list here as you do on L536.  It shouldn\u0027t be a long list of agents at this point (because won\u0027t be scheduling to compute hosts anymore, right?)","commit_id":"4e443f55c385fcb1a59eced41bc45dda6439aad5"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0db7d146b1654ca33d50271ecc517512aaefed2c","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        if router_ids and set(result_list) \u003d\u003d set(router_ids):"},{"line_number":517,"context_line":"            # no need for extra dvr checks if requested routers are"},{"line_number":518,"context_line":"            # explicitly scheduled to the agent"},{"line_number":519,"context_line":"            return result_list"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"        # dvr routers are not explicitly scheduled to agents on hosts with"},{"line_number":522,"context_line":"        # dvr serviceable ports so need special handling"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_4502020b","line":519,"range":{"start_line":519,"start_character":19,"end_line":519,"end_character":30},"in_reply_to":"da6ed579_5e253108","updated":"2016-01-18 13:07:25.000000000","message":"Done","commit_id":"4e443f55c385fcb1a59eced41bc45dda6439aad5"}]}
