)]}'
{"neutron/cmd/sanity/checks.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7208440b90be9c3be338ccfda5d7971214b79f69","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        agent_utils.execute(cmd)"},{"line_number":361,"context_line":"        return True"},{"line_number":362,"context_line":"    except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":363,"context_line":"        LOG.warning(_LW(\"Exception while checking for installed ip6tables. \""},{"line_number":364,"context_line":"                        \"Exception: %s\"), e)"},{"line_number":365,"context_line":"        return False"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_540f1fe1","line":363,"updated":"2015-12-31 12:29:24.000000000","message":"We we log it as \u0027warning\u0027. Can\u0027t it just be \u0027debug\u0027?","commit_id":"cde22fcddc06a50fdae09645101588463e6fea89"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7f17879fa2ee93c8de99dc575f94309cd09284d4","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        agent_utils.execute(cmd)"},{"line_number":361,"context_line":"        return True"},{"line_number":362,"context_line":"    except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":363,"context_line":"        LOG.warning(_LW(\"Exception while checking for installed ip6tables. \""},{"line_number":364,"context_line":"                        \"Exception: %s\"), e)"},{"line_number":365,"context_line":"        return False"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_c0ad8589","line":363,"in_reply_to":"fa69d971_0573af81","updated":"2015-12-31 15:22:16.000000000","message":"Warning looks scary. I was just looking at other functions e.g. L352.","commit_id":"cde22fcddc06a50fdae09645101588463e6fea89"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"4dc5bfdbbbce771db55a60b7ae1048008ac2cc25","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        agent_utils.execute(cmd)"},{"line_number":361,"context_line":"        return True"},{"line_number":362,"context_line":"    except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":363,"context_line":"        LOG.warning(_LW(\"Exception while checking for installed ip6tables. \""},{"line_number":364,"context_line":"                        \"Exception: %s\"), e)"},{"line_number":365,"context_line":"        return False"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_0573af81","line":363,"in_reply_to":"fa69d971_540f1fe1","updated":"2015-12-31 14:21:56.000000000","message":"In this situation, I think warning is appropriate.","commit_id":"cde22fcddc06a50fdae09645101588463e6fea89"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"3ccd605aadd04596b43c9066b7c0632345bd7c35","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        agent_utils.execute(cmd)"},{"line_number":361,"context_line":"        return True"},{"line_number":362,"context_line":"    except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":363,"context_line":"        LOG.warning(_LW(\"Exception while checking for installed ip6tables. \""},{"line_number":364,"context_line":"                        \"Exception: %s\"), e)"},{"line_number":365,"context_line":"        return False"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_57cb7a72","line":363,"in_reply_to":"fa69d971_c0ad8589","updated":"2016-01-04 11:08:04.000000000","message":"Done","commit_id":"cde22fcddc06a50fdae09645101588463e6fea89"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c0bc0aa571a6348a4f0a9cc2aa067403ca0e59a8","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        agent_utils.execute(cmd)"},{"line_number":361,"context_line":"        return True"},{"line_number":362,"context_line":"    except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":363,"context_line":"        LOG.warning(_LW(\"Exception while checking for installed ip6tables. \""},{"line_number":364,"context_line":"                        \"Exception: %s\"), e)"},{"line_number":365,"context_line":"        return False"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_f1e87e12","line":363,"in_reply_to":"fa69d971_c0ad8589","updated":"2016-01-04 10:09:23.000000000","message":"lets try and be consistent with the others - please go for debug","commit_id":"cde22fcddc06a50fdae09645101588463e6fea89"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"3ccd605aadd04596b43c9066b7c0632345bd7c35","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        agent_utils.execute(cmd)"},{"line_number":361,"context_line":"        return True"},{"line_number":362,"context_line":"    except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":363,"context_line":"        LOG.warning(_LW(\"Exception while checking for installed ip6tables. \""},{"line_number":364,"context_line":"                        \"Exception: %s\"), e)"},{"line_number":365,"context_line":"        return False"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_b7a2f6ac","line":363,"in_reply_to":"fa69d971_f1e87e12","updated":"2016-01-04 11:08:04.000000000","message":"Done","commit_id":"cde22fcddc06a50fdae09645101588463e6fea89"}]}
