)]}'
{"neutron/db/dvr_mac_db.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4d861413b1889cc612a96b40446a9428aa46fb69","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        return ports_by_host"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    @log_helpers.log_method_call"},{"line_number":159,"context_line":"    def get_subnet_for_dvr(self, context, subnet, fixed_ips\u003dNone):"},{"line_number":160,"context_line":"        if fixed_ips:"},{"line_number":161,"context_line":"            subnet_id \u003d fixed_ips[0][\u0027subnet_id\u0027]"},{"line_number":162,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_40c4245e","line":159,"updated":"2016-01-03 05:36:19.000000000","message":"IMO, let\u0027s rename the parameter \"subnet\" to \"subnet_id\" for better readability.","commit_id":"94d34f71c6efe34c8778cf57b39f9dfcb9ccb325"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"45e73c414d573b4d1acb2541620d2e0bb507a019","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        return ports_by_host"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    @log_helpers.log_method_call"},{"line_number":159,"context_line":"    def get_subnet_for_dvr(self, context, subnet, fixed_ips\u003dNone):"},{"line_number":160,"context_line":"        if fixed_ips:"},{"line_number":161,"context_line":"            subnet_id \u003d fixed_ips[0][\u0027subnet_id\u0027]"},{"line_number":162,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_00994c1f","line":159,"in_reply_to":"fa69d971_40c4245e","updated":"2016-01-03 07:34:36.000000000","message":"Done","commit_id":"94d34f71c6efe34c8778cf57b39f9dfcb9ccb325"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4d861413b1889cc612a96b40446a9428aa46fb69","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        if fixed_ips:"},{"line_number":161,"context_line":"            subnet_id \u003d fixed_ips[0][\u0027subnet_id\u0027]"},{"line_number":162,"context_line":"        else:"},{"line_number":163,"context_line":"            subnet_id \u003d subnet"},{"line_number":164,"context_line":"        try:"},{"line_number":165,"context_line":"            subnet_info \u003d self.plugin.get_subnet("},{"line_number":166,"context_line":"                context, subnet_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_e0a198aa","line":163,"updated":"2016-01-03 05:36:19.000000000","message":"If we rename then this statement is not required.","commit_id":"94d34f71c6efe34c8778cf57b39f9dfcb9ccb325"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"45e73c414d573b4d1acb2541620d2e0bb507a019","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        if fixed_ips:"},{"line_number":161,"context_line":"            subnet_id \u003d fixed_ips[0][\u0027subnet_id\u0027]"},{"line_number":162,"context_line":"        else:"},{"line_number":163,"context_line":"            subnet_id \u003d subnet"},{"line_number":164,"context_line":"        try:"},{"line_number":165,"context_line":"            subnet_info \u003d self.plugin.get_subnet("},{"line_number":166,"context_line":"                context, subnet_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_a09f2002","line":163,"in_reply_to":"fa69d971_e0a198aa","updated":"2016-01-03 07:34:36.000000000","message":"Done","commit_id":"94d34f71c6efe34c8778cf57b39f9dfcb9ccb325"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4d861413b1889cc612a96b40446a9428aa46fb69","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        else:"},{"line_number":163,"context_line":"            subnet_id \u003d subnet"},{"line_number":164,"context_line":"        try:"},{"line_number":165,"context_line":"            subnet_info \u003d self.plugin.get_subnet("},{"line_number":166,"context_line":"                context, subnet_id)"},{"line_number":167,"context_line":"        except n_exc.SubnetNotFound:"},{"line_number":168,"context_line":"            return {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_00a5ccb3","line":165,"updated":"2016-01-03 05:36:19.000000000","message":"We need to retrieve the subnet details iff fixed_ip is not specified. I feel we can execute this operation if fixed_ip is not specified.","commit_id":"94d34f71c6efe34c8778cf57b39f9dfcb9ccb325"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b2c97ae74276e6d340b5c5b91ce906f8e5c06a56","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        else:"},{"line_number":163,"context_line":"            subnet_id \u003d subnet"},{"line_number":164,"context_line":"        try:"},{"line_number":165,"context_line":"            subnet_info \u003d self.plugin.get_subnet("},{"line_number":166,"context_line":"                context, subnet_id)"},{"line_number":167,"context_line":"        except n_exc.SubnetNotFound:"},{"line_number":168,"context_line":"            return {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_2007b01d","line":165,"in_reply_to":"fa69d971_00a5ccb3","updated":"2016-01-03 08:01:11.000000000","message":"Actually we need it anyway since we return it eventually","commit_id":"94d34f71c6efe34c8778cf57b39f9dfcb9ccb325"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"45e73c414d573b4d1acb2541620d2e0bb507a019","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        else:"},{"line_number":163,"context_line":"            subnet_id \u003d subnet"},{"line_number":164,"context_line":"        try:"},{"line_number":165,"context_line":"            subnet_info \u003d self.plugin.get_subnet("},{"line_number":166,"context_line":"                context, subnet_id)"},{"line_number":167,"context_line":"        except n_exc.SubnetNotFound:"},{"line_number":168,"context_line":"            return {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_c0a2544b","line":165,"in_reply_to":"fa69d971_00a5ccb3","updated":"2016-01-03 07:34:36.000000000","message":"Done","commit_id":"94d34f71c6efe34c8778cf57b39f9dfcb9ccb325"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"ef91040ca08fba73fed2daa738141da524a51421","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    @log_helpers.log_method_call"},{"line_number":159,"context_line":"    def get_subnet_for_dvr(self, context, subnet_id, fixed_ips\u003dNone):"},{"line_number":160,"context_line":"        if fixed_ips:"},{"line_number":161,"context_line":"            subnet_id \u003d fixed_ips[0][\u0027subnet_id\u0027]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        try:"},{"line_number":164,"context_line":"            subnet_info \u003d self.plugin.get_subnet("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_87730b80","line":161,"updated":"2016-01-04 03:25:57.000000000","message":"Checking https://github.com/openstack/neutron/blob/77a6d114eae9de8078b358a9bd8502fb7c393641/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_dvr_neutron_agent.py , L366-367 , L509 \u0026 L525, I\u0027m not sure whether the previous two lines are necessary.\n\nsubnet_id should be fixed_ips[0][\u0027subnet_id\u0027] already, we may don\u0027t need to do assignment here again.","commit_id":"090f435ad70a4a4df9ea7f8a90583dc6523e0545"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b1b99e7108f3cc79b2cba1f347d527005af01aa9","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    @log_helpers.log_method_call"},{"line_number":159,"context_line":"    def get_subnet_for_dvr(self, context, subnet_id, fixed_ips\u003dNone):"},{"line_number":160,"context_line":"        if fixed_ips:"},{"line_number":161,"context_line":"            subnet_id \u003d fixed_ips[0][\u0027subnet_id\u0027]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        try:"},{"line_number":164,"context_line":"            subnet_info \u003d self.plugin.get_subnet("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_3dcd5585","line":161,"in_reply_to":"fa69d971_1782c900","updated":"2016-01-11 06:44:28.000000000","message":"subnet is still a confusing name for a variable storing just id so I\u0027d let a separate patch deal with renaming","commit_id":"090f435ad70a4a4df9ea7f8a90583dc6523e0545"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"7abf7dc3178c30799a2ddac0334ef4992e9c6b7e","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    @log_helpers.log_method_call"},{"line_number":159,"context_line":"    def get_subnet_for_dvr(self, context, subnet_id, fixed_ips\u003dNone):"},{"line_number":160,"context_line":"        if fixed_ips:"},{"line_number":161,"context_line":"            subnet_id \u003d fixed_ips[0][\u0027subnet_id\u0027]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        try:"},{"line_number":164,"context_line":"            subnet_info \u003d self.plugin.get_subnet("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_98a27ead","line":161,"in_reply_to":"fa69d971_87730b80","updated":"2016-01-04 13:29:27.000000000","message":"It wasn\u0027t introduced by this patch so should not really be a blocker. Thoughts?","commit_id":"090f435ad70a4a4df9ea7f8a90583dc6523e0545"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"909334aeccd441f51d1e6e05d41bb3a7cd50509c","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    @log_helpers.log_method_call"},{"line_number":159,"context_line":"    def get_subnet_for_dvr(self, context, subnet_id, fixed_ips\u003dNone):"},{"line_number":160,"context_line":"        if fixed_ips:"},{"line_number":161,"context_line":"            subnet_id \u003d fixed_ips[0][\u0027subnet_id\u0027]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        try:"},{"line_number":164,"context_line":"            subnet_info \u003d self.plugin.get_subnet("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_b567274c","line":161,"in_reply_to":"fa69d971_98a27ead","updated":"2016-01-05 05:08:31.000000000","message":"I know your point, it would be considered as out scope of this patch. But I\u0027m not sure, since you are going to modify get_subnet_for_dvr, maybe it\u0027s possible to fix it in this patch.\n\nWell, I will remove my previous -1, code changing fit descriptions in commit message, +1 should be given.","commit_id":"090f435ad70a4a4df9ea7f8a90583dc6523e0545"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"be2a0e4c2b59b46a0cd4a4111733bd42f626cf6f","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    @log_helpers.log_method_call"},{"line_number":159,"context_line":"    def get_subnet_for_dvr(self, context, subnet_id, fixed_ips\u003dNone):"},{"line_number":160,"context_line":"        if fixed_ips:"},{"line_number":161,"context_line":"            subnet_id \u003d fixed_ips[0][\u0027subnet_id\u0027]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        try:"},{"line_number":164,"context_line":"            subnet_info \u003d self.plugin.get_subnet("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_f13833a2","line":161,"in_reply_to":"fa69d971_b567274c","updated":"2016-01-05 17:52:33.000000000","message":"I prefer a stricter approach and I don\u0027t like to see irrelevant changes mixed in with a patch set even if it seems innocent enough.  This is documented in our effective neutron guide [1].\n\nHonestly, I\u0027m not particularly thrilled about the rename from subnet_data to subnet_id even though subnet_id is obviously a better naming choice.  This patch set would be cleaner without the rename.\n\n [1] http://docs.openstack.org/developer/neutron/devref/effective_neutron.html#scoping-your-patch-appropriately","commit_id":"090f435ad70a4a4df9ea7f8a90583dc6523e0545"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9a1a47cd9ce4a3e5769bd062f4e39a688cb10429","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    @log_helpers.log_method_call"},{"line_number":159,"context_line":"    def get_subnet_for_dvr(self, context, subnet_id, fixed_ips\u003dNone):"},{"line_number":160,"context_line":"        if fixed_ips:"},{"line_number":161,"context_line":"            subnet_id \u003d fixed_ips[0][\u0027subnet_id\u0027]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        try:"},{"line_number":164,"context_line":"            subnet_info \u003d self.plugin.get_subnet("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_1782c900","line":161,"in_reply_to":"fa69d971_f13833a2","updated":"2016-01-08 22:44:09.000000000","message":"If we remove the else: (as was done), then we have to change either the argument name or the local variable to match each other.  Could we just change this line to \"subnet \u003d...\" and change L165 to subnet too?","commit_id":"090f435ad70a4a4df9ea7f8a90583dc6523e0545"}]}
