)]}'
{"quantum/agent/firewall.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c6b453574545e5d451ecf1f60a57178e1fbb3653","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @property"},{"line_number":96,"context_line":"    def ports(self):"},{"line_number":97,"context_line":"        \"\"\"Returns filterd ports.\"\"\""},{"line_number":98,"context_line":"        pass"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @contextlib.contextmanager"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOX%2F%2F6ec%3D","line":97,"updated":"2013-04-07 06:23:11.000000000","message":"Since we are touching the comment.\nfilterd \u003d\u003e filtered","commit_id":"d42f895c0d2638afab56ad3d45171c1ca34016fe"}],"quantum/agent/l3_agent.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c6b453574545e5d451ecf1f60a57178e1fbb3653","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                                   bridge\u003dself.conf.external_network_bridge,"},{"line_number":201,"context_line":"                                   namespace\u003dnamespace,"},{"line_number":202,"context_line":"                                   prefix\u003dEXTERNAL_DEV_PREFIX)"},{"line_number":203,"context_line":"        #TODO(garyk) Address the failure for the deletion of the namespace"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def _create_router_namespace(self, ri):"},{"line_number":206,"context_line":"            ip_wrapper_root \u003d ip_lib.IPWrapper(self.root_helper)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOX%2F%2F6eY%3D","line":203,"updated":"2013-04-07 06:23:11.000000000","message":"How did I inherit this :)","commit_id":"d42f895c0d2638afab56ad3d45171c1ca34016fe"}],"quantum/db/securitygroups_db.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"34029d873469fa31e77b68337d95dd0eed63fc79","unresolved":false,"context_lines":[{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    def _check_update_deletes_security_groups(self, port):"},{"line_number":452,"context_line":"        \"\"\"Return True if port has as a security group and it\u0027s value"},{"line_number":453,"context_line":"        is either [] or not is_attr_set, otherwise return False"},{"line_number":454,"context_line":"        \"\"\""},{"line_number":455,"context_line":"        if (ext_sg.SECURITYGROUPS in port[\u0027port\u0027] and"},{"line_number":456,"context_line":"            not (attr.is_attr_set(port[\u0027port\u0027][ext_sg.SECURITYGROUPS])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2F52g%3D","line":453,"updated":"2013-04-12 04:23:43.000000000","message":"nit: missing .","commit_id":"a13295b9a8c76c01b2f6dfa013110b2e24a6e4da"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    def _check_update_deletes_security_groups(self, port):"},{"line_number":452,"context_line":"        \"\"\"Return True if port has as a security group and it\u0027s value"},{"line_number":453,"context_line":"        is either [] or not is_attr_set, otherwise return False"},{"line_number":454,"context_line":"        \"\"\""},{"line_number":455,"context_line":"        if (ext_sg.SECURITYGROUPS in port[\u0027port\u0027] and"},{"line_number":456,"context_line":"            not (attr.is_attr_set(port[\u0027port\u0027][ext_sg.SECURITYGROUPS])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2F5xY%3D","line":453,"in_reply_to":"AAAAOn%2F%2F52g%3D","updated":"2013-04-12 05:40:05.000000000","message":"The hacking plugin only validates punctuation for a single line docstring, but even with a period at the end this docstring would not be in compliance with hacking.  Multi-line docstrings are supposed to have a single line summary (which the hacking plugin would validate correctly), followed by a newline, followed by a more content.  Until we have automatic validation and cleanup the codebase accordingly, though, I\u0027d rather not have to be strict.  The less mechanical work that reviewers have to do, the better - it\u0027s hard enough to focus on the semantic aspects of a given patch.","commit_id":"a13295b9a8c76c01b2f6dfa013110b2e24a6e4da"}],"quantum/plugins/brocade/nos/nosdriver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c6b453574545e5d451ecf1f60a57178e1fbb3653","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            LOG.debug(_(\"Connect failed to switch: %s\"), e)"},{"line_number":67,"context_line":"            raise"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        LOG.debug(_(\"Connect success to host %(host)s:%(SSH_PORT)d\"), locals())"},{"line_number":70,"context_line":"        return mgr"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def create_network(self, host, username, password, net_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOX%2F%2F6eU%3D","line":69,"updated":"2013-04-07 06:23:11.000000000","message":"please do not use locals. we should use a dictionary","commit_id":"d42f895c0d2638afab56ad3d45171c1ca34016fe"}],"quantum/plugins/hyperv/agent/hyperv_quantum_agent.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c6b453574545e5d451ecf1f60a57178e1fbb3653","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        else:"},{"line_number":163,"context_line":"            raise utils.HyperVException("},{"line_number":164,"context_line":"                _(\"Cannot provision unknown network type %(network_type)s \""},{"line_number":165,"context_line":"                  \"for network %(net_uuid)s\"), locals())"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        map \u003d {"},{"line_number":168,"context_line":"            \u0027network_type\u0027: network_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOX%2F%2F6eQ%3D","line":165,"updated":"2013-04-07 06:23:11.000000000","message":"we should not use locals","commit_id":"d42f895c0d2638afab56ad3d45171c1ca34016fe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c6b453574545e5d451ecf1f60a57178e1fbb3653","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        if network_type \u003d\u003d constants.TYPE_VLAN:"},{"line_number":196,"context_line":"            LOG.info(_(\u0027Binding VLAN ID %(segmentation_id)s \u0027"},{"line_number":197,"context_line":"                       \u0027to switch port %(port_id)s\u0027),"},{"line_number":198,"context_line":"                     locals())"},{"line_number":199,"context_line":"            self._utils.set_vswitch_port_vlan_id("},{"line_number":200,"context_line":"                segmentation_id,"},{"line_number":201,"context_line":"                port_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOX%2F%2F6eM%3D","line":198,"updated":"2013-04-07 06:23:11.000000000","message":"ditto","commit_id":"d42f895c0d2638afab56ad3d45171c1ca34016fe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c6b453574545e5d451ecf1f60a57178e1fbb3653","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            except Exception as e:"},{"line_number":256,"context_line":"                LOG.debug(_("},{"line_number":257,"context_line":"                    \"Unable to get port details for device %(device)s: %(e)s\"),"},{"line_number":258,"context_line":"                    locals())"},{"line_number":259,"context_line":"                resync \u003d True"},{"line_number":260,"context_line":"                continue"},{"line_number":261,"context_line":"            if \u0027port_id\u0027 in device_details:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOX%2F%2F6eE%3D","line":258,"updated":"2013-04-07 06:23:11.000000000","message":"ditto","commit_id":"d42f895c0d2638afab56ad3d45171c1ca34016fe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c6b453574545e5d451ecf1f60a57178e1fbb3653","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            except Exception as e:"},{"line_number":283,"context_line":"                LOG.debug("},{"line_number":284,"context_line":"                    _(\"Removing port failed for device %(device)s: %(e)s\"),"},{"line_number":285,"context_line":"                    locals())"},{"line_number":286,"context_line":"                resync \u003d True"},{"line_number":287,"context_line":"                continue"},{"line_number":288,"context_line":"            self._port_unbound(device)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOX%2F%2F6eA%3D","line":285,"updated":"2013-04-07 06:23:11.000000000","message":"ditto","commit_id":"d42f895c0d2638afab56ad3d45171c1ca34016fe"}],"quantum/plugins/plumgrid/plumgrid_nos_plugin/rest_connection.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c6b453574545e5d451ecf1f60a57178e1fbb3653","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        try:"},{"line_number":64,"context_line":"            LOG.debug(_(\"PLUMgrid_NOS_Server Sending Data: %(nos_url)s \""},{"line_number":65,"context_line":"                        \"%(body_data)s %(headers)s\"), locals())"},{"line_number":66,"context_line":"            conn.request(action, nos_url, body_data, headers)"},{"line_number":67,"context_line":"            resp \u003d conn.getresponse()"},{"line_number":68,"context_line":"            resp_str \u003d resp.read()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOX%2F%2F6d8%3D","line":65,"updated":"2013-04-07 06:23:11.000000000","message":"please do not use locals","commit_id":"d42f895c0d2638afab56ad3d45171c1ca34016fe"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        try:"},{"line_number":64,"context_line":"            LOG.debug(_(\"PLUMgrid_NOS_Server Sending Data: %(nos_url)s \""},{"line_number":65,"context_line":"                        \"%(body_data)s %(headers)s\"), locals())"},{"line_number":66,"context_line":"            conn.request(action, nos_url, body_data, headers)"},{"line_number":67,"context_line":"            resp \u003d conn.getresponse()"},{"line_number":68,"context_line":"            resp_str \u003d resp.read()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOX%2F%2F5ps%3D","line":65,"in_reply_to":"AAAAOX%2F%2F6d8%3D","updated":"2013-04-08 15:09:21.000000000","message":"agree","commit_id":"d42f895c0d2638afab56ad3d45171c1ca34016fe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c6b453574545e5d451ecf1f60a57178e1fbb3653","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            resp_str \u003d resp.read()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"            LOG.debug(_(\"PLUMgrid_NOS_Server Connection Data: %(resp)s, \""},{"line_number":71,"context_line":"                        \"%(resp_str)s\"), locals())"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"            if resp.status is httplib.OK:"},{"line_number":74,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOX%2F%2F6d4%3D","line":71,"updated":"2013-04-07 06:23:11.000000000","message":"ditto","commit_id":"d42f895c0d2638afab56ad3d45171c1ca34016fe"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"unresolved":false,"context_lines":[{"line_number":68,"context_line":"            resp_str \u003d resp.read()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"            LOG.debug(_(\"PLUMgrid_NOS_Server Connection Data: %(resp)s, \""},{"line_number":71,"context_line":"                        \"%(resp_str)s\"), locals())"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"            if resp.status is httplib.OK:"},{"line_number":74,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOX%2F%2F5po%3D","line":71,"in_reply_to":"AAAAOX%2F%2F6d4%3D","updated":"2013-04-08 15:09:21.000000000","message":"also agree","commit_id":"d42f895c0d2638afab56ad3d45171c1ca34016fe"}]}
