)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4288fc2b8f6b3232d5662aa113d68ead21784606","unresolved":false,"context_lines":[{"line_number":12,"context_line":"take away some of the hassle of configuring all these things correctly,"},{"line_number":13,"context_line":"and see if it can be automatically determined."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TODO - see what breaks."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1]: https://specs.openstack.org/openstack/fuel-specs/specs/7.0/jumbo-frames-between-instances.html"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa69d971_8460b7a6","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":23},"updated":"2016-01-05 02:44:23.000000000","message":"Please add considering \"DocImpact\" or \"RENO\" into your TODO.\n\nI looked at the spec of advertise MTU and found the following sentence. \n\u003e defaulting to false if absent (for backward compatibility)\nI don\u0027t know what the \"backward compatibility\" means but we should consider the case still exists.","commit_id":"d6ba5e97ce1299cc2028dab71fc7f81ed4b4ff17"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3fa42bdde176c5c709a4305dc17e31808ba7dc5f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"take away some of the hassle of configuring all these things correctly,"},{"line_number":13,"context_line":"and see if it can be automatically determined."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TODO - see what breaks."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1]: https://specs.openstack.org/openstack/fuel-specs/specs/7.0/jumbo-frames-between-instances.html"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa69d971_13286432","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":23},"in_reply_to":"fa69d971_8460b7a6","updated":"2016-01-11 16:36:42.000000000","message":"There should be no genuine compatibility implications here. I guess it was left as False merely because the feature was merged in late phase of the cycle.\n\nIf mtu api extension is not enabled, dhcp agent will still receive mtu for networks (set to constants.DEFAULT_NETWORK_MTU, as per _make_network_dict code in base db neutron class). In that case, dhcp agent will do nothing with the value, not passing --mtu option. So should be fine in this regard too.","commit_id":"d6ba5e97ce1299cc2028dab71fc7f81ed4b4ff17"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3fa42bdde176c5c709a4305dc17e31808ba7dc5f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"TODO - see what breaks."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1]: https://specs.openstack.org/openstack/fuel-specs/specs/7.0/jumbo-frames-between-instances.html"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I5cbbc4660f8c4e15e59f8f5ce0419501bdd27348"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa69d971_53c01c50","line":18,"updated":"2016-01-11 16:36:42.000000000","message":"I suspect that patch is related to bug 1527675 where we fail to ssh into an instance (validating the hypothesis with https://review.openstack.org/#/c/265759/ )","commit_id":"d6ba5e97ce1299cc2028dab71fc7f81ed4b4ff17"}],"neutron/common/config.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0c2aba99d595567a8d15034043cefce52745a52f","unresolved":false,"context_lines":[{"line_number":154,"context_line":"               help\u003d_(\u0027Number of seconds between sending events to nova if \u0027"},{"line_number":155,"context_line":"                      \u0027there are any events to send.\u0027)),"},{"line_number":156,"context_line":"    cfg.BoolOpt(\u0027advertise_mtu\u0027, default\u003dTrue,"},{"line_number":157,"context_line":"                help\u003d_(\u0027If True and the plug-in provides a way to indicate \u0027"},{"line_number":158,"context_line":"                       \u0027path MTU of the physical network infrastructure, \u0027"},{"line_number":159,"context_line":"                       \u0027provide the path MTU minus any overlay protocol \u0027"},{"line_number":160,"context_line":"                       \u0027overhead to instances via DHCP and RA MTU \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_2e24f8c2","line":157,"updated":"2016-01-15 08:58:45.000000000","message":"That is actually wrong. I think you can still set mtu manually for a network thru API, even if plugin does not support path_mtu based calculation.","commit_id":"ed393121eab88c94c42a68df5916f43d8b451caf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f01304ae7593b069b45f7e3fcef7d88fa3a5644a","unresolved":false,"context_lines":[{"line_number":154,"context_line":"               help\u003d_(\u0027Number of seconds between sending events to nova if \u0027"},{"line_number":155,"context_line":"                      \u0027there are any events to send.\u0027)),"},{"line_number":156,"context_line":"    cfg.BoolOpt(\u0027advertise_mtu\u0027, default\u003dTrue,"},{"line_number":157,"context_line":"                help\u003d_(\u0027If True and the plug-in provides a way to indicate \u0027"},{"line_number":158,"context_line":"                       \u0027path MTU of the physical network infrastructure, \u0027"},{"line_number":159,"context_line":"                       \u0027provide the path MTU minus any overlay protocol \u0027"},{"line_number":160,"context_line":"                       \u0027overhead to instances via DHCP and RA MTU \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_63750762","line":157,"in_reply_to":"da6ed579_143d6b8e","updated":"2016-01-15 18:34:57.000000000","message":"Maybe \u0027If True, advertise network MTU values if core plugin calculates them. Currently, the only way to advertise MTU to running instances is using corresponding DHCP option.\u0027","commit_id":"ed393121eab88c94c42a68df5916f43d8b451caf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6c500cc42c181322ca942566f6af6399e5e12586","unresolved":false,"context_lines":[{"line_number":154,"context_line":"               help\u003d_(\u0027Number of seconds between sending events to nova if \u0027"},{"line_number":155,"context_line":"                      \u0027there are any events to send.\u0027)),"},{"line_number":156,"context_line":"    cfg.BoolOpt(\u0027advertise_mtu\u0027, default\u003dTrue,"},{"line_number":157,"context_line":"                help\u003d_(\u0027If True and the plug-in provides a way to indicate \u0027"},{"line_number":158,"context_line":"                       \u0027path MTU of the physical network infrastructure, \u0027"},{"line_number":159,"context_line":"                       \u0027provide the path MTU minus any overlay protocol \u0027"},{"line_number":160,"context_line":"                       \u0027overhead to instances via DHCP and RA MTU \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_b17fedde","line":157,"in_reply_to":"da6ed579_2e24f8c2","updated":"2016-01-15 09:15:38.000000000","message":"I am a bit wrong on it: current extension does not allow post for the attribute. Nevertheless, mixing ml2 path_mtu with the agent option is probably wrong: other plugins may have a different way of doing it.","commit_id":"ed393121eab88c94c42a68df5916f43d8b451caf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"65686c546bfd59b4477905aaf72f20f083911a8f","unresolved":false,"context_lines":[{"line_number":154,"context_line":"               help\u003d_(\u0027Number of seconds between sending events to nova if \u0027"},{"line_number":155,"context_line":"                      \u0027there are any events to send.\u0027)),"},{"line_number":156,"context_line":"    cfg.BoolOpt(\u0027advertise_mtu\u0027, default\u003dTrue,"},{"line_number":157,"context_line":"                help\u003d_(\u0027If True and the plug-in provides a way to indicate \u0027"},{"line_number":158,"context_line":"                       \u0027path MTU of the physical network infrastructure, \u0027"},{"line_number":159,"context_line":"                       \u0027provide the path MTU minus any overlay protocol \u0027"},{"line_number":160,"context_line":"                       \u0027overhead to instances via DHCP and RA MTU \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_d4822ac8","line":157,"in_reply_to":"da6ed579_63750762","updated":"2016-01-18 12:39:31.000000000","message":"Done","commit_id":"ed393121eab88c94c42a68df5916f43d8b451caf"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"d916b0eb05c395fa5a03a98fe37b43de41e6470a","unresolved":false,"context_lines":[{"line_number":154,"context_line":"               help\u003d_(\u0027Number of seconds between sending events to nova if \u0027"},{"line_number":155,"context_line":"                      \u0027there are any events to send.\u0027)),"},{"line_number":156,"context_line":"    cfg.BoolOpt(\u0027advertise_mtu\u0027, default\u003dTrue,"},{"line_number":157,"context_line":"                help\u003d_(\u0027If True and the plug-in provides a way to indicate \u0027"},{"line_number":158,"context_line":"                       \u0027path MTU of the physical network infrastructure, \u0027"},{"line_number":159,"context_line":"                       \u0027provide the path MTU minus any overlay protocol \u0027"},{"line_number":160,"context_line":"                       \u0027overhead to instances via DHCP and RA MTU \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_143d6b8e","line":157,"in_reply_to":"da6ed579_b17fedde","updated":"2016-01-15 17:24:56.000000000","message":"I avoided specifically mentioning the configuration option path_mtu, but kept the concept. What do you suggest for wording... at least until we clean up the implementation of the mtu-selection-and-advertisement spec.","commit_id":"ed393121eab88c94c42a68df5916f43d8b451caf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0c2aba99d595567a8d15034043cefce52745a52f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                help\u003d_(\u0027If True and the plug-in provides a way to indicate \u0027"},{"line_number":158,"context_line":"                       \u0027path MTU of the physical network infrastructure, \u0027"},{"line_number":159,"context_line":"                       \u0027provide the path MTU minus any overlay protocol \u0027"},{"line_number":160,"context_line":"                       \u0027overhead to instances via DHCP and RA MTU \u0027"},{"line_number":161,"context_line":"                       \u0027options.\u0027)),"},{"line_number":162,"context_line":"    cfg.StrOpt(\u0027ipam_driver\u0027,"},{"line_number":163,"context_line":"               help\u003d_(\"Neutron IPAM (IP address management) driver to use. \""}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_ee29009c","line":160,"updated":"2016-01-15 08:58:45.000000000","message":"RA is not supported yet.","commit_id":"ed393121eab88c94c42a68df5916f43d8b451caf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"65686c546bfd59b4477905aaf72f20f083911a8f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                help\u003d_(\u0027If True and the plug-in provides a way to indicate \u0027"},{"line_number":158,"context_line":"                       \u0027path MTU of the physical network infrastructure, \u0027"},{"line_number":159,"context_line":"                       \u0027provide the path MTU minus any overlay protocol \u0027"},{"line_number":160,"context_line":"                       \u0027overhead to instances via DHCP and RA MTU \u0027"},{"line_number":161,"context_line":"                       \u0027options.\u0027)),"},{"line_number":162,"context_line":"    cfg.StrOpt(\u0027ipam_driver\u0027,"},{"line_number":163,"context_line":"               help\u003d_(\"Neutron IPAM (IP address management) driver to use. \""}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_946d9234","line":160,"in_reply_to":"da6ed579_94115b54","updated":"2016-01-18 12:39:31.000000000","message":"Done","commit_id":"ed393121eab88c94c42a68df5916f43d8b451caf"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"d916b0eb05c395fa5a03a98fe37b43de41e6470a","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                help\u003d_(\u0027If True and the plug-in provides a way to indicate \u0027"},{"line_number":158,"context_line":"                       \u0027path MTU of the physical network infrastructure, \u0027"},{"line_number":159,"context_line":"                       \u0027provide the path MTU minus any overlay protocol \u0027"},{"line_number":160,"context_line":"                       \u0027overhead to instances via DHCP and RA MTU \u0027"},{"line_number":161,"context_line":"                       \u0027options.\u0027)),"},{"line_number":162,"context_line":"    cfg.StrOpt(\u0027ipam_driver\u0027,"},{"line_number":163,"context_line":"               help\u003d_(\"Neutron IPAM (IP address management) driver to use. \""}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_94115b54","line":160,"in_reply_to":"da6ed579_ee29009c","updated":"2016-01-15 17:24:56.000000000","message":"Right... guess I was hoping the RA patches would merge.","commit_id":"ed393121eab88c94c42a68df5916f43d8b451caf"}],"releasenotes/notes/advertise_mtu_by_default-d8b0b056a74517b8.yaml":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0c2aba99d595567a8d15034043cefce52745a52f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - By default, the DHCP agent provides a network MTU value to instances using"},{"line_number":4,"context_line":"    the corresponding DHCP option if the [ml2] path_mtu option contains a"},{"line_number":5,"context_line":"    value greater than zero."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - To disable, use [DEFAULT] advertise_mtu \u003d False."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"da6ed579_5108f127","line":4,"updated":"2016-01-15 08:58:45.000000000","message":"it\u0027s wrong to mix ml2 and dhcp agent. The latter can be used outside of ml2 context. There are other means of passing mtu for a network (like setting it manually thru API).","commit_id":"ed393121eab88c94c42a68df5916f43d8b451caf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f01304ae7593b069b45f7e3fcef7d88fa3a5644a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - By default, the DHCP agent provides a network MTU value to instances using"},{"line_number":4,"context_line":"    the corresponding DHCP option if the [ml2] path_mtu option contains a"},{"line_number":5,"context_line":"    value greater than zero."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - To disable, use [DEFAULT] advertise_mtu \u003d False."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"da6ed579_c3271361","line":4,"in_reply_to":"da6ed579_374d11c4","updated":"2016-01-15 18:34:57.000000000","message":"Maybe you can first give general idea (as I proposed for option description), and then give additional advice for ml2 plugin specifically.","commit_id":"ed393121eab88c94c42a68df5916f43d8b451caf"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"d916b0eb05c395fa5a03a98fe37b43de41e6470a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - By default, the DHCP agent provides a network MTU value to instances using"},{"line_number":4,"context_line":"    the corresponding DHCP option if the [ml2] path_mtu option contains a"},{"line_number":5,"context_line":"    value greater than zero."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - To disable, use [DEFAULT] advertise_mtu \u003d False."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"da6ed579_374d11c4","line":4,"in_reply_to":"da6ed579_5108f127","updated":"2016-01-15 17:24:56.000000000","message":"Should I change this to refer to a more generic MTU option? The value sent to VMs should reflect the minimum MTU across all segments between the VM and physical network infrastructure rather than MTU of a segment. Also, the current read-only API extension seems useless.","commit_id":"ed393121eab88c94c42a68df5916f43d8b451caf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"65686c546bfd59b4477905aaf72f20f083911a8f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - By default, the DHCP agent provides a network MTU value to instances using"},{"line_number":4,"context_line":"    the corresponding DHCP option if the [ml2] path_mtu option contains a"},{"line_number":5,"context_line":"    value greater than zero."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - To disable, use [DEFAULT] advertise_mtu \u003d False."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"da6ed579_17d3e439","line":4,"in_reply_to":"da6ed579_c3271361","updated":"2016-01-18 12:39:31.000000000","message":"Done","commit_id":"ed393121eab88c94c42a68df5916f43d8b451caf"}]}