)]}'
{"quantum/plugins/nec/drivers/pfc.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":97,"context_line":"        return re.sub(r\u0027[^0-9a-zA-Z]\u0027, \u0027_\u0027, raw_str)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _generate_pfc_id(self, id_str):"},{"line_number":100,"context_line":"        try:"},{"line_number":101,"context_line":"            # Need to use uuid.UUID to accept Keystone tenant_id as UUID"},{"line_number":102,"context_line":"            uuid_str \u003d str(uuid.UUID(id_str)).replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":103,"context_line":"            # Drop version field in UUID version 4"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2F%2BJk%3D","line":100,"updated":"2013-04-09 17:49:01.000000000","message":"The current logic takes care of a case Quantum without Keystone. As long as Keystone auth is used, id_str is always UUID and the except clause is not needed. I can change L.96-110 to the following. This is a bit simpler. Is it better?\n\n    def _generate_pfc_id(self, id_str):\n        uuid_str \u003d id_str.replace(\u0027-\u0027, \u0027\u0027)\n        # Drop version field in UUID version 4\n        return uuid_str[:12] + uuid_str[13:32]\n\n    def _generate_pfc_description(self, desc):\n        escape_str \u003d re.sub(r\u0027[^0-9a-zA-Z]\u0027, \u0027_\u0027, desc)\n        return escape_str[:127]","commit_id":"c276470c3485627cd54f70eeeacf64f4a873e652"}],"quantum/tests/unit/nec/test_pfc_driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"06c7e5bece2d50ae49e62d70d82a85f1717a7bb5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import unittest"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from quantum.common import utils"},{"line_number":25,"context_line":"from quantum.openstack.common import uuidutils"},{"line_number":26,"context_line":"from quantum.plugins.nec import drivers"},{"line_number":27,"context_line":"from quantum.plugins.nec.db import models as nmodels"},{"line_number":28,"context_line":"from quantum.plugins.nec.common import ofc_client as ofc"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F%2Fo8%3D","line":25,"updated":"2013-04-08 21:18:27.000000000","message":"i do not think that this exists in stable folsom. you will need the uuid import","commit_id":"a1cd33149d49f557c7d3c20fe4bcccd298fa56f4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":22,"context_line":"import unittest"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from quantum.common import utils"},{"line_number":25,"context_line":"from quantum.openstack.common import uuidutils"},{"line_number":26,"context_line":"from quantum.plugins.nec import drivers"},{"line_number":27,"context_line":"from quantum.plugins.nec.db import models as nmodels"},{"line_number":28,"context_line":"from quantum.plugins.nec.common import ofc_client as ofc"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F%2FIA%3D","line":25,"in_reply_to":"AAAAOn%2F%2F%2Fo8%3D","updated":"2013-04-09 02:54:16.000000000","message":"Thanks. I use utils.str_uuid() instead.\n\nOops. Grizzly *.pyc remained when I tested.","commit_id":"a1cd33149d49f557c7d3c20fe4bcccd298fa56f4"}]}
