)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"08c97387f403b755dff81d974b9ccff9c06cf2e6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add unit test cases for linuxbridge agent when prevent_arp_spoofing is True"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently there are no unit test cases executed when prevent_arp_spoofing is true."},{"line_number":10,"context_line":"This fix address that issue."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie8bfa873120378dcdcb9d43e307daa5d55c038f2"},{"line_number":13,"context_line":"Closes-Bug: #1520255"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_8aef39e8","line":10,"updated":"2016-01-05 20:31:39.000000000","message":"Currently there is no *test coverage* for when prevent_arp_spoofing is set to true.","commit_id":"461a96df663a0185236859d3963399c7f4b4d135"},{"author":{"_account_id":15237,"name":"Anand Shanmugam","email":"anand1712@gmail.com","username":"anand1712"},"change_message_id":"d0aeb83cea0774e95caafe226ca9d0c4fdbb145a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add unit test cases for linuxbridge agent when prevent_arp_spoofing is True"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently there are no unit test cases executed when prevent_arp_spoofing is true."},{"line_number":10,"context_line":"This fix address that issue."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie8bfa873120378dcdcb9d43e307daa5d55c038f2"},{"line_number":13,"context_line":"Closes-Bug: #1520255"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_ed012f39","line":10,"in_reply_to":"fa69d971_8aef39e8","updated":"2016-01-05 21:09:28.000000000","message":"Done","commit_id":"461a96df663a0185236859d3963399c7f4b4d135"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"eaa3bac94a0762d90e9e849e9e18b2aa02256429","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Anand Shanmugam \u003canand1712@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-07 09:21:32 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add unit test cases for linuxbridge agent when prevent_arp_spoofing is True"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently there is no test coverage for when prevent_arp_spoofing is set to true."},{"line_number":10,"context_line":"This fix address that issue."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa69d971_b608bf29","line":7,"updated":"2016-01-08 12:32:33.000000000","message":"nit: check line length, it\u0027s longer than 72 chars","commit_id":"75dcd5f2ecbdc7491b520e3c317929e1e644b025"}],"neutron/tests/unit/plugins/ml2/drivers/linuxbridge/agent/test_linuxbridge_neutron_agent.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"53ebbe5999f650bb511f3700637d08a3ed698ebf","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            self.assertTrue(fn_udd.called)"},{"line_number":174,"context_line":"            self.assertTrue(fn_rdf.called)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def test_treat_devices_removed_with_prevent_arp_spoofing_true(self):"},{"line_number":177,"context_line":"        agent \u003d self.agent"},{"line_number":178,"context_line":"        self.agent.prevent_arp_spoofing \u003d True"},{"line_number":179,"context_line":"        agent._ensure_port_admin_state \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_2e397aa4","line":176,"updated":"2016-01-05 23:43:06.000000000","message":"There\u0027s other tests for \u0027treat_devices_removed\u0027, I think here the only assertion should be that delete_arp_spoofing_protection was called with the expected arguments.","commit_id":"2338036c92ff8c909f93830d62040fcdd34fccc4"},{"author":{"_account_id":15237,"name":"Anand Shanmugam","email":"anand1712@gmail.com","username":"anand1712"},"change_message_id":"10ac5eca34cea47f2ded734281ce2b8e32167069","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            self.assertTrue(fn_udd.called)"},{"line_number":174,"context_line":"            self.assertTrue(fn_rdf.called)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def test_treat_devices_removed_with_prevent_arp_spoofing_true(self):"},{"line_number":177,"context_line":"        agent \u003d self.agent"},{"line_number":178,"context_line":"        self.agent.prevent_arp_spoofing \u003d True"},{"line_number":179,"context_line":"        agent._ensure_port_admin_state \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_eeada284","line":176,"in_reply_to":"fa69d971_2e397aa4","updated":"2016-01-05 23:50:44.000000000","message":"Done","commit_id":"2338036c92ff8c909f93830d62040fcdd34fccc4"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"53ebbe5999f650bb511f3700637d08a3ed698ebf","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        self._test_scan_devices(previous, updated, fake_current, expected,"},{"line_number":312,"context_line":"                                sync\u003dTrue)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def test_scan_devices_with_prevent_arp_spoofing_true(self):"},{"line_number":315,"context_line":"        self.agent.prevent_arp_spoofing \u003d True"},{"line_number":316,"context_line":"        previous \u003d None"},{"line_number":317,"context_line":"        fake_current \u003d set([1, 2])"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_ae6a4ab1","line":314,"updated":"2016-01-05 23:43:06.000000000","message":"Upon taking a closer look, considering that delete_unreferenced_arp_protection is already covered by a functional test, this test is fine as it is.","commit_id":"2338036c92ff8c909f93830d62040fcdd34fccc4"},{"author":{"_account_id":15237,"name":"Anand Shanmugam","email":"anand1712@gmail.com","username":"anand1712"},"change_message_id":"10ac5eca34cea47f2ded734281ce2b8e32167069","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        self._test_scan_devices(previous, updated, fake_current, expected,"},{"line_number":312,"context_line":"                                sync\u003dTrue)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def test_scan_devices_with_prevent_arp_spoofing_true(self):"},{"line_number":315,"context_line":"        self.agent.prevent_arp_spoofing \u003d True"},{"line_number":316,"context_line":"        previous \u003d None"},{"line_number":317,"context_line":"        fake_current \u003d set([1, 2])"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_0eb356ea","line":314,"in_reply_to":"fa69d971_ae6a4ab1","updated":"2016-01-05 23:50:44.000000000","message":"Done","commit_id":"2338036c92ff8c909f93830d62040fcdd34fccc4"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"53ebbe5999f650bb511f3700637d08a3ed698ebf","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                                      constants.DEVICE_OWNER_NETWORK_PREFIX)"},{"line_number":371,"context_line":"        self.assertTrue(agent.plugin_rpc.update_device_up.called)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    def test_treat_devices_added_updated_prevent_arp_spoofing_true(self):"},{"line_number":374,"context_line":"        agent \u003d self.agent"},{"line_number":375,"context_line":"        self.agent.prevent_arp_spoofing \u003d True"},{"line_number":376,"context_line":"        mock_details \u003d {\u0027device\u0027: \u0027dev123\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_4e65ceb2","line":373,"updated":"2016-01-05 23:43:06.000000000","message":"Same comment as line 176.","commit_id":"2338036c92ff8c909f93830d62040fcdd34fccc4"},{"author":{"_account_id":15237,"name":"Anand Shanmugam","email":"anand1712@gmail.com","username":"anand1712"},"change_message_id":"10ac5eca34cea47f2ded734281ce2b8e32167069","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                                      constants.DEVICE_OWNER_NETWORK_PREFIX)"},{"line_number":371,"context_line":"        self.assertTrue(agent.plugin_rpc.update_device_up.called)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    def test_treat_devices_added_updated_prevent_arp_spoofing_true(self):"},{"line_number":374,"context_line":"        agent \u003d self.agent"},{"line_number":375,"context_line":"        self.agent.prevent_arp_spoofing \u003d True"},{"line_number":376,"context_line":"        mock_details \u003d {\u0027device\u0027: \u0027dev123\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_6ed9b221","line":373,"in_reply_to":"fa69d971_4e65ceb2","updated":"2016-01-05 23:50:44.000000000","message":"Done","commit_id":"2338036c92ff8c909f93830d62040fcdd34fccc4"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"7c4b87e2ba36dedaefafaafb58102385392580c2","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                                  \"remove_devices_filter\"):"},{"line_number":213,"context_line":"            fn_udd.return_value \u003d {\u0027device\u0027: DEVICE_1,"},{"line_number":214,"context_line":"                                   \u0027exists\u0027: True}"},{"line_number":215,"context_line":"            with mock.patch.object(linuxbridge_neutron_agent.LOG,"},{"line_number":216,"context_line":"                                   \u0027info\u0027),\\"},{"line_number":217,"context_line":"                mock.patch.object(arp_protect,"},{"line_number":218,"context_line":"                                  \u0027delete_arp_spoofing_protection\u0027) as del_arp:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_5db2224d","line":215,"range":{"start_line":215,"start_character":35,"end_line":215,"end_character":60},"updated":"2016-01-07 09:19:37.000000000","message":"there\u0027s no need to mock the LOG thing as you do not assert on it. It just adds complexity. Please remove this.","commit_id":"b331009f8db54b5d5c4004c921e5ca483c0bcc48"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"7c4b87e2ba36dedaefafaafb58102385392580c2","unresolved":false,"context_lines":[{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def test_treat_devices_added_updated_prevent_arp_spoofing_true(self):"},{"line_number":428,"context_line":"        agent \u003d self.agent"},{"line_number":429,"context_line":"        self.agent.prevent_arp_spoofing \u003d True"},{"line_number":430,"context_line":"        mock_details \u003d {\u0027device\u0027: \u0027dev123\u0027,"},{"line_number":431,"context_line":"                        \u0027port_id\u0027: \u0027port123\u0027,"},{"line_number":432,"context_line":"                        \u0027network_id\u0027: \u0027net123\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_3db88e10","line":429,"range":{"start_line":429,"start_character":8,"end_line":429,"end_character":12},"updated":"2016-01-07 09:19:37.000000000","message":"why working on \u0027self.agent\u0027 and not on \u0027agent\u0027 direclty?","commit_id":"b331009f8db54b5d5c4004c921e5ca483c0bcc48"}]}
