)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"200d978a13d21834b5a4a838121eb679b8850a2a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     hgangwx \u003chgangwx@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-06 23:29:08 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Useless slash in the return message"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\"Insufficient prefix space to allocate subnet size /%s\""},{"line_number":10,"context_line":"Should be:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_d91411ea","line":7,"updated":"2016-01-06 13:53:22.000000000","message":"nit: Please change this to \"Remove useless ...\" so that it describes what the commit is doing.","commit_id":"2875236fd90c932bf9a16585ae50048eb9737d19"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c185e4b150a6b5ecf870ee94eb435ea2a89d6928","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     hgangwx \u003chgangwx@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-07 04:17:04 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Romove useless slash in the return message"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\"Insufficient prefix space to allocate subnet size /%s\""},{"line_number":10,"context_line":"Should be:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa69d971_bfd57de5","line":7,"updated":"2016-01-06 14:30:37.000000000","message":"Now you\u0027ve got a typo here: Romove -\u003e Remove\n\nBut I still think this change may not be needed. Looking at the bug report I\u0027d say it\u0027s not a bug. It\u0027s only a bug if the user visible message contains two slashes. There SHOULD be a single slash before the integer that represents the subnet size.","commit_id":"f81be64afe890423b247865a1036fa7dcb81448f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d5a5ea8bcdfddb10bbbb509860b75cd4d39de9a0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\"Insufficient prefix space to allocate subnet size /%s\""},{"line_number":10,"context_line":"Should be:"},{"line_number":11,"context_line":"\"Insufficient prefix space to allocate subnet size %s\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I810a08430146d4dc7ff341711c6bd14efed3abc6"},{"line_number":14,"context_line":"Closes-Bug: 1531375"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa69d971_1fe609e8","line":11,"updated":"2016-01-06 14:29:42.000000000","message":"There is no need to copy the change into the commit message","commit_id":"f81be64afe890423b247865a1036fa7dcb81448f"}],"neutron/ipam/subnet_alloc.py":[{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"200d978a13d21834b5a4a838121eb679b8850a2a","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                                      allocation_pools\u003dpools)"},{"line_number":136,"context_line":"            msg \u003d _(\"Insufficient prefix space to allocate subnet size %s\")"},{"line_number":137,"context_line":"            raise n_exc.SubnetAllocationError(reason\u003dmsg %"},{"line_number":138,"context_line":"                                              str(request.prefixlen))"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def _allocate_specific_subnet(self, request):"},{"line_number":141,"context_line":"        with self._context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_991e996e","line":138,"updated":"2016-01-06 13:53:22.000000000","message":"Does request.prefixlen include a leading slash? Or is it an integer. If it\u0027s an integer then the / in the message is not useless. The actual user visible message should be \"Insufficient prefix space to allocate subnet size /##\" where ## is an integer and there is one slash preceding it. If you\u0027re saying that two slashes appear in the user visible message (because str(request.prefixlen) already contains a slash) then you\u0027re correct, but if only one slash appears then it\u0027s supposed to be there. Subnet sizes are always stated with a leading forward slash.","commit_id":"2875236fd90c932bf9a16585ae50048eb9737d19"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bf437cf0e0d01b84a5d2d4f1ad8cce329becc47a","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                                      allocation_pools\u003dpools)"},{"line_number":136,"context_line":"            msg \u003d _(\"Insufficient prefix space to allocate subnet size %s\")"},{"line_number":137,"context_line":"            raise n_exc.SubnetAllocationError(reason\u003dmsg %"},{"line_number":138,"context_line":"                                              str(request.prefixlen))"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def _allocate_specific_subnet(self, request):"},{"line_number":141,"context_line":"        with self._context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_2459808e","line":138,"in_reply_to":"fa69d971_991e996e","updated":"2016-01-06 14:08:42.000000000","message":"+1.  At best the text could be changed slightly:\n\n\"Insufficient prefix space to allocate a subnet of size /%s\"","commit_id":"2875236fd90c932bf9a16585ae50048eb9737d19"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c185e4b150a6b5ecf870ee94eb435ea2a89d6928","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                                      allocation_pools\u003dpools)"},{"line_number":136,"context_line":"            msg \u003d _(\"Insufficient prefix space to allocate subnet size %s\")"},{"line_number":137,"context_line":"            raise n_exc.SubnetAllocationError(reason\u003dmsg %"},{"line_number":138,"context_line":"                                              str(request.prefixlen))"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def _allocate_specific_subnet(self, request):"},{"line_number":141,"context_line":"        with self._context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_5f2ec1fb","line":138,"updated":"2016-01-06 14:30:37.000000000","message":"Does request.prefixlen contain a slash? If it\u0027s an integer then the slash IS needed in msg because subnet sizes are written with a leading forward slash.","commit_id":"f81be64afe890423b247865a1036fa7dcb81448f"}]}