)]}'
{"bin/quantum-check-nvp-config":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo.config import cfg"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from quantum.common import config"},{"line_number":27,"context_line":"from quantum.plugins.nicira import NvpApiClient"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAOn%2F%2F0mc%3D","line":24,"updated":"2013-04-21 18:47:57.000000000","message":"These changes seem like a regression.  The previous version allowed the binary script to added using an entrypoint console script.  Why the change?","commit_id":"56d88614eeba632234445898acaf2d1a1b0d5874"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo.config import cfg"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from quantum.common import config"},{"line_number":27,"context_line":"from quantum.plugins.nicira import NvpApiClient"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAOn%2F%2F0PA%3D","line":24,"in_reply_to":"AAAAOn%2F%2F0mc%3D","updated":"2013-04-22 10:29:50.000000000","message":"sorry, I wanted to simplify without realizing the way this script was used in the context of packaging, and how it was done with all the other bin scripts. I will put things back as they were.","commit_id":"56d88614eeba632234445898acaf2d1a1b0d5874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":40,"context_line":"def get_gateway_services(cluster):"},{"line_number":41,"context_line":"    ret_gw_services \u003d {\"L2GatewayServiceConfig\": [],"},{"line_number":42,"context_line":"                       \"L3GatewayServiceConfig\": []}"},{"line_number":43,"context_line":"    gw_services \u003d nvplib.get_gateway_services(cluster).get(\u0027results\u0027)"},{"line_number":44,"context_line":"    if gw_services:"},{"line_number":45,"context_line":"        for gw_service in gw_services:"},{"line_number":46,"context_line":"            ret_gw_services[gw_service[\u0027type\u0027]].append(gw_service[\u0027uuid\u0027])"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAOn%2F%2F0mY%3D","line":43,"updated":"2013-04-21 18:47:57.000000000","message":"Considering replacing 43-46 with:\n\ngw_services \u003d nvplib.get_gateway_services(cluster).get(\u0027results\u0027, [])\n\nfor gw_service in gw_services:\n    ret_gw_services[gw_service[\u0027type\u0027]].append(gw_service[\u0027uuid\u0027])","commit_id":"56d88614eeba632234445898acaf2d1a1b0d5874"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":40,"context_line":"def get_gateway_services(cluster):"},{"line_number":41,"context_line":"    ret_gw_services \u003d {\"L2GatewayServiceConfig\": [],"},{"line_number":42,"context_line":"                       \"L3GatewayServiceConfig\": []}"},{"line_number":43,"context_line":"    gw_services \u003d nvplib.get_gateway_services(cluster).get(\u0027results\u0027)"},{"line_number":44,"context_line":"    if gw_services:"},{"line_number":45,"context_line":"        for gw_service in gw_services:"},{"line_number":46,"context_line":"            ret_gw_services[gw_service[\u0027type\u0027]].append(gw_service[\u0027uuid\u0027])"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAOn%2F%2F0O4%3D","line":43,"in_reply_to":"AAAAOn%2F%2F0mY%3D","updated":"2013-04-22 10:29:50.000000000","message":"Done","commit_id":"56d88614eeba632234445898acaf2d1a1b0d5874"}],"etc/quantum/plugins/nicira/check_nvp_config":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"f6a25928a2be0ce759ae195f19c11088bf8d6437","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2013 Nicira, Inc."}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAOn%2F%2F4lw%3D","line":1,"updated":"2013-04-13 17:18:04.000000000","message":"we shouldn\u0027t move this to etc","commit_id":"01befe0f2c98f31ab1613e2147dd008f00aa1de3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2013 Nicira, Inc."}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAOn%2F%2F4Js%3D","line":1,"in_reply_to":"AAAAOn%2F%2F4Vc%3D","updated":"2013-04-15 09:08:22.000000000","message":"Thanks for pointing this one out Aaron, I guess we no longer have a misunderstanding! Sorry if I haven\u0027t spotted this file earlier.","commit_id":"01befe0f2c98f31ab1613e2147dd008f00aa1de3"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"f6a25928a2be0ce759ae195f19c11088bf8d6437","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2013 Nicira, Inc."}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAOn%2F%2F4Vc%3D","line":1,"in_reply_to":"AAAAOn%2F%2F4bI%3D","updated":"2013-04-15 01:07:46.000000000","message":"We have this file which solves that issue: https://github.com/openstack/quantum/blob/master/bin/quantum-check-nvp-config","commit_id":"01befe0f2c98f31ab1613e2147dd008f00aa1de3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2013 Nicira, Inc."}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAOn%2F%2F4bI%3D","line":1,"in_reply_to":"AAAAOn%2F%2F4c0%3D","updated":"2013-04-14 17:40:00.000000000","message":"IMO,  etc directory should contain files usually deployed into /etc directory. We can find init.d scripts in /etc/init.d. The case is a little different because this is a checker script.\n\nIt sounds good idea to create a subdirectory. plugins/nicira/bin or bin/nicira is good to me.","commit_id":"01befe0f2c98f31ab1613e2147dd008f00aa1de3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2013 Nicira, Inc."}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAOn%2F%2F4c0%3D","line":1,"in_reply_to":"AAAAOn%2F%2F4jQ%3D","updated":"2013-04-14 09:17:56.000000000","message":"the etc directory doesn\u0027t seem to obey to this rule (see init.d for example), even though quantum/plugins does. I thought: \"what would it be the best place for a validator tool than next the config file that\u0027s meant to validate?\" I am slightly against the plugin directory because that makes the tool difficult to find by users as well as packagers/deployers: the final destination of a binary that\u0027s meant to be called from the CLI is typically /usr/*/bin rather than the python package directory under dist-packages or whatever. How about a nicira dir under contrib? Then, we can shepherd changes to the package rules so that the file ends up in the right place on the OS, when quantum is installed. That said, I am happy to put it back where it was.","commit_id":"01befe0f2c98f31ab1613e2147dd008f00aa1de3"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"f6a25928a2be0ce759ae195f19c11088bf8d6437","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2013 Nicira, Inc."}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAOn%2F%2F4jQ%3D","line":1,"in_reply_to":"AAAAOn%2F%2F4kg%3D","updated":"2013-04-13 22:14:16.000000000","message":"sure, /etc/ is for configuration files, not for tools to check configuration files imho. I believe this fits better somewhere in the plugin directory. What do you think?","commit_id":"01befe0f2c98f31ab1613e2147dd008f00aa1de3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2013 Nicira, Inc."}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAOn%2F%2F4kg%3D","line":1,"in_reply_to":"AAAAOn%2F%2F4lw%3D","updated":"2013-04-13 18:15:31.000000000","message":"Ok. Could you explain why?","commit_id":"01befe0f2c98f31ab1613e2147dd008f00aa1de3"}],"quantum/plugins/nicira/QuantumPlugin.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":88,"context_line":"    # want to support deprecated options in the nvp config file"},{"line_number":89,"context_line":"    # ### BEGIN"},{"line_number":90,"context_line":"    config.register_deprecated(cfg.CONF)"},{"line_number":91,"context_line":"    # ### END"},{"line_number":92,"context_line":"    cluster \u003d nvp_cluster.NVPCluster(**cluster_opts)"},{"line_number":93,"context_line":"    api_providers \u003d [ctrl.split(\u0027:\u0027) + [True]"},{"line_number":94,"context_line":"                     for ctrl in cluster.nvp_controllers]"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FvXk%3D","line":91,"updated":"2013-04-25 13:26:40.000000000","message":"how pedantic :)","commit_id":"5eb2fee8d70f6369089d28c9ebd03be9fef31797"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":88,"context_line":"    # want to support deprecated options in the nvp config file"},{"line_number":89,"context_line":"    # ### BEGIN"},{"line_number":90,"context_line":"    config.register_deprecated(cfg.CONF)"},{"line_number":91,"context_line":"    # ### END"},{"line_number":92,"context_line":"    cluster \u003d nvp_cluster.NVPCluster(**cluster_opts)"},{"line_number":93,"context_line":"    api_providers \u003d [ctrl.split(\u0027:\u0027) + [True]"},{"line_number":94,"context_line":"                     for ctrl in cluster.nvp_controllers]"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2Fu4k%3D","line":91,"in_reply_to":"AAAAOn%2F%2FvXk%3D","updated":"2013-04-25 18:44:05.000000000","message":"well....I figured...if I said remove next line...what if another line snuck in? :)","commit_id":"5eb2fee8d70f6369089d28c9ebd03be9fef31797"}],"quantum/plugins/nicira/README":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"    (default -1 meaning do not time out)"},{"line_number":26,"context_line":"    3) NVP cluster"},{"line_number":27,"context_line":"    By default the Quantum NVP plugin can talk to multiple controllers in a"},{"line_number":28,"context_line":"    single cluster. In the future (Havana+) support for multiple cluster"},{"line_number":29,"context_line":"    will be added."},{"line_number":30,"context_line":"    The following parameters can be configured:"},{"line_number":31,"context_line":"    - default_tz_uuid: This is uuid of the default NVP Transport zone that"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAAOn%2F%2FvXg%3D","line":28,"updated":"2013-04-25 13:26:40.000000000","message":"pedant nit: support for multiple clusters","commit_id":"5eb2fee8d70f6369089d28c9ebd03be9fef31797"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"    (default -1 meaning do not time out)"},{"line_number":26,"context_line":"    3) NVP cluster"},{"line_number":27,"context_line":"    By default the Quantum NVP plugin can talk to multiple controllers in a"},{"line_number":28,"context_line":"    single cluster. In the future (Havana+) support for multiple cluster"},{"line_number":29,"context_line":"    will be added."},{"line_number":30,"context_line":"    The following parameters can be configured:"},{"line_number":31,"context_line":"    - default_tz_uuid: This is uuid of the default NVP Transport zone that"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAAOn%2F%2Fu4g%3D","line":28,"in_reply_to":"AAAAOn%2F%2FvXg%3D","updated":"2013-04-25 18:44:05.000000000","message":"oops","commit_id":"5eb2fee8d70f6369089d28c9ebd03be9fef31797"}],"quantum/plugins/nicira/check_nvp_config.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2013 Nicira, Inc."}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FvXU%3D","side":"PARENT","line":1,"updated":"2013-04-25 13:26:40.000000000","message":"Why remove the shebang?","commit_id":"765baf8532473473ce6a022ca2d1120a60e44fe4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2013 Nicira, Inc."}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2Fu4Q%3D","side":"PARENT","line":1,"in_reply_to":"AAAAOn%2F%2FvXU%3D","updated":"2013-04-25 18:44:05.000000000","message":"the way I understand it, this file gets called by quantum-check-nvp-config (located in bin), so there is no need for this line. This file is not even executable and the package doesn\u0027t touch it and it\u0027s well hidden in the source tree. Aaron may be able to tell more, but the way I see it, this is a copy and paste error.","commit_id":"765baf8532473473ce6a022ca2d1120a60e44fe4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":72,"context_line":"    print \"\\tmax_lp_per_overlay_ls: %s\" % cfg.CONF.NVP.max_lp_per_overlay_ls"},{"line_number":73,"context_line":"    print (\"\\tenable_metadata_access_network: %s\" %"},{"line_number":74,"context_line":"           cfg.CONF.NVP.enable_metadata_access_network)"},{"line_number":75,"context_line":"    cluster \u003d QuantumPlugin.create_nvp_cluster("},{"line_number":76,"context_line":"        cfg.CONF,"},{"line_number":77,"context_line":"        cfg.CONF.NVP.concurrent_connections,"},{"line_number":78,"context_line":"        cfg.CONF.NVP.nvp_gen_timeout)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FvXQ%3D","line":75,"updated":"2013-04-25 13:26:40.000000000","message":"Everything which is printed from this point till the end, should be probably in the Cluster Options section.\n\nWhat do you reckon?","commit_id":"5eb2fee8d70f6369089d28c9ebd03be9fef31797"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":72,"context_line":"    print \"\\tmax_lp_per_overlay_ls: %s\" % cfg.CONF.NVP.max_lp_per_overlay_ls"},{"line_number":73,"context_line":"    print (\"\\tenable_metadata_access_network: %s\" %"},{"line_number":74,"context_line":"           cfg.CONF.NVP.enable_metadata_access_network)"},{"line_number":75,"context_line":"    cluster \u003d QuantumPlugin.create_nvp_cluster("},{"line_number":76,"context_line":"        cfg.CONF,"},{"line_number":77,"context_line":"        cfg.CONF.NVP.concurrent_connections,"},{"line_number":78,"context_line":"        cfg.CONF.NVP.nvp_gen_timeout)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2Fu4I%3D","line":75,"in_reply_to":"AAAAOn%2F%2FvXQ%3D","updated":"2013-04-25 18:44:05.000000000","message":"good point.","commit_id":"5eb2fee8d70f6369089d28c9ebd03be9fef31797"}],"quantum/plugins/nicira/nvp_cluster.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":81,"context_line":"                for option in cluster_section:"},{"line_number":82,"context_line":"                    v \u003d cluster_section.get(option)"},{"line_number":83,"context_line":"                    if option not in DEPRECATED_ATTRIBUTES:"},{"line_number":84,"context_line":"                        setattr(self, option, options.get(option) or v)"},{"line_number":85,"context_line":"                        self._process_attribute(option)"},{"line_number":86,"context_line":"                    else:"},{"line_number":87,"context_line":"                        self._deprecated_attributes[option] \u003d v"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F0mU%3D","line":84,"updated":"2013-04-21 18:47:57.000000000","message":"The or is unnecessary. \n\nsetattr(self, option, options.get(option, v))","commit_id":"56d88614eeba632234445898acaf2d1a1b0d5874"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":81,"context_line":"                for option in cluster_section:"},{"line_number":82,"context_line":"                    v \u003d cluster_section.get(option)"},{"line_number":83,"context_line":"                    if option not in DEPRECATED_ATTRIBUTES:"},{"line_number":84,"context_line":"                        setattr(self, option, options.get(option) or v)"},{"line_number":85,"context_line":"                        self._process_attribute(option)"},{"line_number":86,"context_line":"                    else:"},{"line_number":87,"context_line":"                        self._deprecated_attributes[option] \u003d v"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F0Po%3D","line":84,"in_reply_to":"AAAAOn%2F%2F0mU%3D","updated":"2013-04-22 10:29:50.000000000","message":"Done","commit_id":"56d88614eeba632234445898acaf2d1a1b0d5874"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":31,"context_line":"# Emit a INFO log if one of those attributes is not specified"},{"line_number":32,"context_line":"IMPORTANT_ATTRIBUTES \u003d [\u0027default_l3_gw_service_uuid\u0027]"},{"line_number":33,"context_line":"# Deprecated attributes"},{"line_number":34,"context_line":"DEPRECATED_ATTRIBUTES \u003d [\u0027nvp_controller_connection\u0027]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class NVPCluster(object):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FvWs%3D","line":34,"updated":"2013-04-25 13:26:40.000000000","message":"metadata_host_route too?","commit_id":"5eb2fee8d70f6369089d28c9ebd03be9fef31797"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":31,"context_line":"# Emit a INFO log if one of those attributes is not specified"},{"line_number":32,"context_line":"IMPORTANT_ATTRIBUTES \u003d [\u0027default_l3_gw_service_uuid\u0027]"},{"line_number":33,"context_line":"# Deprecated attributes"},{"line_number":34,"context_line":"DEPRECATED_ATTRIBUTES \u003d [\u0027nvp_controller_connection\u0027]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class NVPCluster(object):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2Fu4E%3D","line":34,"in_reply_to":"AAAAOn%2F%2FvWs%3D","updated":"2013-04-25 18:44:05.000000000","message":"seems fair.","commit_id":"5eb2fee8d70f6369089d28c9ebd03be9fef31797"}],"quantum/tests/unit/nicira/test_nvpopts.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.assertEqual(256, cfg.CONF.NVP.max_lp_per_overlay_ls)"},{"line_number":122,"context_line":"        self.assertEqual(5, cfg.CONF.NVP.concurrent_connections)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.assertEqual(None, cfg.CONF.default_tz_uuid)"},{"line_number":125,"context_line":"        self.assertEqual(None, cfg.CONF.nvp_cluster_uuid)"},{"line_number":126,"context_line":"        self.assertEqual(\u0027admin\u0027, cfg.CONF.nvp_user)"},{"line_number":127,"context_line":"        self.assertEqual(\u0027admin\u0027, cfg.CONF.nvp_password)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F0mQ%3D","line":124,"updated":"2013-04-21 18:47:57.000000000","message":"self.assertNone()","commit_id":"56d88614eeba632234445898acaf2d1a1b0d5874"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.assertEqual(256, cfg.CONF.NVP.max_lp_per_overlay_ls)"},{"line_number":122,"context_line":"        self.assertEqual(5, cfg.CONF.NVP.concurrent_connections)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.assertEqual(None, cfg.CONF.default_tz_uuid)"},{"line_number":125,"context_line":"        self.assertEqual(None, cfg.CONF.nvp_cluster_uuid)"},{"line_number":126,"context_line":"        self.assertEqual(\u0027admin\u0027, cfg.CONF.nvp_user)"},{"line_number":127,"context_line":"        self.assertEqual(\u0027admin\u0027, cfg.CONF.nvp_password)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F0Pk%3D","line":124,"in_reply_to":"AAAAOn%2F%2F0mQ%3D","updated":"2013-04-22 10:29:50.000000000","message":"Done","commit_id":"56d88614eeba632234445898acaf2d1a1b0d5874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.assertEqual(5, cfg.CONF.NVP.concurrent_connections)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.assertEqual(None, cfg.CONF.default_tz_uuid)"},{"line_number":125,"context_line":"        self.assertEqual(None, cfg.CONF.nvp_cluster_uuid)"},{"line_number":126,"context_line":"        self.assertEqual(\u0027admin\u0027, cfg.CONF.nvp_user)"},{"line_number":127,"context_line":"        self.assertEqual(\u0027admin\u0027, cfg.CONF.nvp_password)"},{"line_number":128,"context_line":"        self.assertEqual(30, cfg.CONF.req_timeout)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F0mM%3D","line":125,"updated":"2013-04-21 18:47:57.000000000","message":"self.assertNone()","commit_id":"56d88614eeba632234445898acaf2d1a1b0d5874"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.assertEqual(5, cfg.CONF.NVP.concurrent_connections)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.assertEqual(None, cfg.CONF.default_tz_uuid)"},{"line_number":125,"context_line":"        self.assertEqual(None, cfg.CONF.nvp_cluster_uuid)"},{"line_number":126,"context_line":"        self.assertEqual(\u0027admin\u0027, cfg.CONF.nvp_user)"},{"line_number":127,"context_line":"        self.assertEqual(\u0027admin\u0027, cfg.CONF.nvp_password)"},{"line_number":128,"context_line":"        self.assertEqual(30, cfg.CONF.req_timeout)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F0Pg%3D","line":125,"in_reply_to":"AAAAOn%2F%2F0mM%3D","updated":"2013-04-22 10:29:50.000000000","message":"Done","commit_id":"56d88614eeba632234445898acaf2d1a1b0d5874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.assertEqual(10, cfg.CONF.http_timeout)"},{"line_number":130,"context_line":"        self.assertEqual(2, cfg.CONF.retries)"},{"line_number":131,"context_line":"        self.assertEqual(2, cfg.CONF.redirects)"},{"line_number":132,"context_line":"        self.assertEqual(None, cfg.CONF.nvp_controllers)"},{"line_number":133,"context_line":"        self.assertEqual(None,"},{"line_number":134,"context_line":"                         cfg.CONF.default_l3_gw_service_uuid)"},{"line_number":135,"context_line":"        self.assertEqual(None,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F0mI%3D","line":132,"updated":"2013-04-21 18:47:57.000000000","message":"self.assertNone()","commit_id":"56d88614eeba632234445898acaf2d1a1b0d5874"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.assertEqual(10, cfg.CONF.http_timeout)"},{"line_number":130,"context_line":"        self.assertEqual(2, cfg.CONF.retries)"},{"line_number":131,"context_line":"        self.assertEqual(2, cfg.CONF.redirects)"},{"line_number":132,"context_line":"        self.assertEqual(None, cfg.CONF.nvp_controllers)"},{"line_number":133,"context_line":"        self.assertEqual(None,"},{"line_number":134,"context_line":"                         cfg.CONF.default_l3_gw_service_uuid)"},{"line_number":135,"context_line":"        self.assertEqual(None,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F0Pc%3D","line":132,"in_reply_to":"AAAAOn%2F%2F0mI%3D","updated":"2013-04-22 10:29:50.000000000","message":"Done","commit_id":"56d88614eeba632234445898acaf2d1a1b0d5874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":130,"context_line":"        self.assertEqual(2, cfg.CONF.retries)"},{"line_number":131,"context_line":"        self.assertEqual(2, cfg.CONF.redirects)"},{"line_number":132,"context_line":"        self.assertEqual(None, cfg.CONF.nvp_controllers)"},{"line_number":133,"context_line":"        self.assertEqual(None,"},{"line_number":134,"context_line":"                         cfg.CONF.default_l3_gw_service_uuid)"},{"line_number":135,"context_line":"        self.assertEqual(None,"},{"line_number":136,"context_line":"                         cfg.CONF.default_l2_gw_service_uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F0mE%3D","line":133,"updated":"2013-04-21 18:47:57.000000000","message":"self.assertNone()","commit_id":"56d88614eeba632234445898acaf2d1a1b0d5874"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":130,"context_line":"        self.assertEqual(2, cfg.CONF.retries)"},{"line_number":131,"context_line":"        self.assertEqual(2, cfg.CONF.redirects)"},{"line_number":132,"context_line":"        self.assertEqual(None, cfg.CONF.nvp_controllers)"},{"line_number":133,"context_line":"        self.assertEqual(None,"},{"line_number":134,"context_line":"                         cfg.CONF.default_l3_gw_service_uuid)"},{"line_number":135,"context_line":"        self.assertEqual(None,"},{"line_number":136,"context_line":"                         cfg.CONF.default_l2_gw_service_uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F0PY%3D","line":133,"in_reply_to":"AAAAOn%2F%2F0mE%3D","updated":"2013-04-22 10:29:50.000000000","message":"Done","commit_id":"56d88614eeba632234445898acaf2d1a1b0d5874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self.assertEqual(None, cfg.CONF.nvp_controllers)"},{"line_number":133,"context_line":"        self.assertEqual(None,"},{"line_number":134,"context_line":"                         cfg.CONF.default_l3_gw_service_uuid)"},{"line_number":135,"context_line":"        self.assertEqual(None,"},{"line_number":136,"context_line":"                         cfg.CONF.default_l2_gw_service_uuid)"},{"line_number":137,"context_line":"        self.assertEqual(\u0027breth0\u0027,"},{"line_number":138,"context_line":"                         cfg.CONF.default_interface_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F0mA%3D","line":135,"updated":"2013-04-21 18:47:57.000000000","message":"self.assertNone()","commit_id":"56d88614eeba632234445898acaf2d1a1b0d5874"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self.assertEqual(None, cfg.CONF.nvp_controllers)"},{"line_number":133,"context_line":"        self.assertEqual(None,"},{"line_number":134,"context_line":"                         cfg.CONF.default_l3_gw_service_uuid)"},{"line_number":135,"context_line":"        self.assertEqual(None,"},{"line_number":136,"context_line":"                         cfg.CONF.default_l2_gw_service_uuid)"},{"line_number":137,"context_line":"        self.assertEqual(\u0027breth0\u0027,"},{"line_number":138,"context_line":"                         cfg.CONF.default_interface_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F0PU%3D","line":135,"in_reply_to":"AAAAOn%2F%2F0mA%3D","updated":"2013-04-22 10:29:50.000000000","message":"Done","commit_id":"56d88614eeba632234445898acaf2d1a1b0d5874"}]}