)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"c2e0a51aa3a582eaf5b278bd209f2c2d62079760","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     gongysh \u003cgongysh@linux.vnet.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-04-09 09:11:32 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Not to run metadata proxy with falsed enable_isolated_metadata"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug #1159015"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAOn%2F%2F0n4%3D","line":7,"updated":"2013-04-21 17:36:43.000000000","message":"Is this syntax correct in English?","commit_id":"e2d88ff2f2175e525e9330ac269978c5867c0918"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"c66407a268d37503157e6123ae95c849f0aa7f7f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     gongysh \u003cgongysh@linux.vnet.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-04-09 09:11:32 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Not to run metadata proxy with falsed enable_isolated_metadata"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug #1159015"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAOn%2F%2FwMQ%3D","line":7,"in_reply_to":"AAAAOn%2F%2F0n4%3D","updated":"2013-04-24 19:27:29.000000000","message":"No, it\u0027s not.  Since it sounds like there are other circumstances where it needs to be enabled, I think a better title would be something like \"Don\u0027t run metadata proxy when it is not needed\".  Should also probably add more details about when that is the case in the rest of the commit message.","commit_id":"e2d88ff2f2175e525e9330ac269978c5867c0918"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     gongysh \u003cgongysh@linux.vnet.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-04-09 09:11:32 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Not to run metadata proxy with falsed enable_isolated_metadata"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug #1159015"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAOn%2F%2FitA%3D","line":7,"in_reply_to":"AAAAOn%2F%2FwMQ%3D","updated":"2013-05-06 07:58:43.000000000","message":"Done","commit_id":"e2d88ff2f2175e525e9330ac269978c5867c0918"}],"quantum/agent/dhcp_agent.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"c2e0a51aa3a582eaf5b278bd209f2c2d62079760","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            if subnet.enable_dhcp:"},{"line_number":186,"context_line":"                if self.call_driver(\u0027enable\u0027, network):"},{"line_number":187,"context_line":"                    if (self.conf.use_namespaces and"},{"line_number":188,"context_line":"                        self.conf.enable_isolated_metadata):"},{"line_number":189,"context_line":"                        self.enable_isolated_metadata_proxy(network)"},{"line_number":190,"context_line":"                    self.cache.put(network)"},{"line_number":191,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F0nM%3D","line":188,"updated":"2013-04-21 17:36:43.000000000","message":"There is also another case in which the proxy needs to be started: enable_metadata_network\n\nThe metadata network is defined for all those plugins who want to use the proxy but do not leverage the l3 agent. It is a 169.254.169.254/x (16\u003c\u003dx\u003c\u003d30) network, which plugs into a quantum router and receives metadata requests on a proxy started by the dhcp agent.","commit_id":"e2d88ff2f2175e525e9330ac269978c5867c0918"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":185,"context_line":"            if subnet.enable_dhcp:"},{"line_number":186,"context_line":"                if self.call_driver(\u0027enable\u0027, network):"},{"line_number":187,"context_line":"                    if (self.conf.use_namespaces and"},{"line_number":188,"context_line":"                        self.conf.enable_isolated_metadata):"},{"line_number":189,"context_line":"                        self.enable_isolated_metadata_proxy(network)"},{"line_number":190,"context_line":"                    self.cache.put(network)"},{"line_number":191,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fis8%3D","line":188,"in_reply_to":"AAAAOn%2F%2F0nM%3D","updated":"2013-05-06 07:58:43.000000000","message":"I think we don\u0027t need to run it in this case, see lines 67-68","commit_id":"e2d88ff2f2175e525e9330ac269978c5867c0918"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"c66407a268d37503157e6123ae95c849f0aa7f7f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                    help\u003d_(\"Support Metadata requests on isolated networks.\")),"},{"line_number":65,"context_line":"        cfg.BoolOpt(\u0027enable_metadata_network\u0027, default\u003dFalse,"},{"line_number":66,"context_line":"                    help\u003d_(\"Allows for serving metadata requests from a \""},{"line_number":67,"context_line":"                           \"dedicate network. Requires \""},{"line_number":68,"context_line":"                           \"enable_isolated_metadata \u003d True \")),"},{"line_number":69,"context_line":"    ]"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FiCM%3D","line":67,"updated":"2013-05-06 17:15:19.000000000","message":"dedicate-\u003ededicated","commit_id":"55ae4d5d19675468c7906423c01e2b19a9cc2e87"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":64,"context_line":"                    help\u003d_(\"Support Metadata requests on isolated networks.\")),"},{"line_number":65,"context_line":"        cfg.BoolOpt(\u0027enable_metadata_network\u0027, default\u003dFalse,"},{"line_number":66,"context_line":"                    help\u003d_(\"Allows for serving metadata requests from a \""},{"line_number":67,"context_line":"                           \"dedicate network. Requires \""},{"line_number":68,"context_line":"                           \"enable_isolated_metadata \u003d True \")),"},{"line_number":69,"context_line":"    ]"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fc4o%3D","line":67,"in_reply_to":"AAAAOn%2F%2FiCM%3D","updated":"2013-05-09 06:10:54.000000000","message":"Done","commit_id":"55ae4d5d19675468c7906423c01e2b19a9cc2e87"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":65,"context_line":"        cfg.BoolOpt(\u0027enable_metadata_network\u0027, default\u003dFalse,"},{"line_number":66,"context_line":"                    help\u003d_(\"Allows for serving metadata requests from a \""},{"line_number":67,"context_line":"                           \"dedicate network. Requires \""},{"line_number":68,"context_line":"                           \"enable_isolated_metadata \u003d True \")),"},{"line_number":69,"context_line":"    ]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def __init__(self, host\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FidU%3D","line":68,"updated":"2013-05-06 12:35:13.000000000","message":"True \" \u003d\u003e True\"","commit_id":"55ae4d5d19675468c7906423c01e2b19a9cc2e87"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":65,"context_line":"        cfg.BoolOpt(\u0027enable_metadata_network\u0027, default\u003dFalse,"},{"line_number":66,"context_line":"                    help\u003d_(\"Allows for serving metadata requests from a \""},{"line_number":67,"context_line":"                           \"dedicate network. Requires \""},{"line_number":68,"context_line":"                           \"enable_isolated_metadata \u003d True \")),"},{"line_number":69,"context_line":"    ]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def __init__(self, host\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fc4k%3D","line":68,"in_reply_to":"AAAAOn%2F%2FidU%3D","updated":"2013-05-09 06:10:54.000000000","message":"Done","commit_id":"55ae4d5d19675468c7906423c01e2b19a9cc2e87"}],"quantum/tests/unit/test_dhcp_agent.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"c2e0a51aa3a582eaf5b278bd209f2c2d62079760","unresolved":false,"context_lines":[{"line_number":454,"context_line":"                \u0027sudo\u0027,"},{"line_number":455,"context_line":"                \u0027qdhcp-12345678-1234-5678-1234567890ab\u0027),"},{"line_number":456,"context_line":"            mock.call().enable(mock.ANY)"},{"line_number":457,"context_line":"        ])"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    def test_enable_dhcp_helper_(self):"},{"line_number":460,"context_line":"        self.plugin.get_network_info.return_value \u003d fake_network"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F0nk%3D","line":457,"updated":"2013-04-21 17:36:43.000000000","message":"Would it be possible to save some LOCs by doing some refactoring of this unit test and the next one?","commit_id":"e2d88ff2f2175e525e9330ac269978c5867c0918"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":454,"context_line":"                \u0027sudo\u0027,"},{"line_number":455,"context_line":"                \u0027qdhcp-12345678-1234-5678-1234567890ab\u0027),"},{"line_number":456,"context_line":"            mock.call().enable(mock.ANY)"},{"line_number":457,"context_line":"        ])"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    def test_enable_dhcp_helper_(self):"},{"line_number":460,"context_line":"        self.plugin.get_network_info.return_value \u003d fake_network"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fis4%3D","line":457,"in_reply_to":"AAAAOn%2F%2F0nk%3D","updated":"2013-05-06 07:58:43.000000000","message":"Done","commit_id":"e2d88ff2f2175e525e9330ac269978c5867c0918"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"c2e0a51aa3a582eaf5b278bd209f2c2d62079760","unresolved":false,"context_lines":[{"line_number":463,"context_line":"            [mock.call.get_network_info(fake_network.id)])"},{"line_number":464,"context_line":"        self.call_driver.assert_called_once_with(\u0027enable\u0027, fake_network)"},{"line_number":465,"context_line":"        self.cache.assert_has_calls([mock.call.put(fake_network)])"},{"line_number":466,"context_line":"        self.assertEqual(0, self.external_process.call_count)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    def test_enable_dhcp_helper_down_network(self):"},{"line_number":469,"context_line":"        self.plugin.get_network_info.return_value \u003d fake_down_network"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F0nw%3D","line":466,"updated":"2013-04-21 17:36:43.000000000","message":"you are missing an assert_has_calls on self.external_process.\n\nIf the argument is that you have it anyway in test_enable_dhcp_helper_isolated_metadata, I think each unit tests should be regarded as independent from each other, and should therefore have the same level of behavioural validation","commit_id":"e2d88ff2f2175e525e9330ac269978c5867c0918"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":463,"context_line":"            [mock.call.get_network_info(fake_network.id)])"},{"line_number":464,"context_line":"        self.call_driver.assert_called_once_with(\u0027enable\u0027, fake_network)"},{"line_number":465,"context_line":"        self.cache.assert_has_calls([mock.call.put(fake_network)])"},{"line_number":466,"context_line":"        self.assertEqual(0, self.external_process.call_count)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    def test_enable_dhcp_helper_down_network(self):"},{"line_number":469,"context_line":"        self.plugin.get_network_info.return_value \u003d fake_down_network"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fisw%3D","line":466,"in_reply_to":"AAAAOn%2F%2F0nw%3D","updated":"2013-05-06 07:58:43.000000000","message":"This function is to test behavior with defaulted enable_isolated_metadata, when we should not  run external_process at all.","commit_id":"e2d88ff2f2175e525e9330ac269978c5867c0918"}]}