)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"efd4f08d36f9e548fb723a3a5e82c82ef8d916e1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yatin Kumbhare \u003cyatinkumbhare@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-07 14:43:20 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix use of assertFalse as per the hacking checks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixing as per the neutron hacking checks."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_7dcfe655","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":41},"updated":"2016-01-07 09:25:59.000000000","message":"nit.. I do not think that the hacking check mentions anything about the message parameter of the asertFalse()\n\nMaybe you can skip it if there is another patch-set for this patch","commit_id":"6111112a2f21969e39385552b747aa7ea9d80f9a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f32139c38235de9725ba7b8b19a884a9f64d02a2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yatin Kumbhare \u003cyatinkumbhare@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-07 14:43:20 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix use of assertFalse as per the hacking checks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixing as per the neutron hacking checks."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6ed579_b16ea894","line":7,"updated":"2016-01-12 21:50:08.000000000","message":"which hacking check is this violating? If it is violating one, why hasn\u0027t it resulted in a failure? I\u0027m not quite following what you are saying here.","commit_id":"6111112a2f21969e39385552b747aa7ea9d80f9a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"c8b7bb47c4c6286f453ec2bf86c6e1132dc50691","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yatin Kumbhare \u003cyatinkumbhare@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-07 14:43:20 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix use of assertFalse as per the hacking checks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixing as per the neutron hacking checks."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6ed579_d1b6bc89","line":7,"in_reply_to":"da6ed579_b16ea894","updated":"2016-01-12 22:03:16.000000000","message":"An example seems required. iiuc, it could be:\n\n self.assertFalse(observed)\n\ninstead of:\n\n self.assertFalse(observed, msg??)","commit_id":"6111112a2f21969e39385552b747aa7ea9d80f9a"},{"author":{"_account_id":7002,"name":"Yatin Kumbhare","email":"yatinkumbhare@gmail.com","username":"yatin.kumbhare"},"change_message_id":"034863c4acd46ef8b62526df3deec41d4c986ad0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yatin Kumbhare \u003cyatinkumbhare@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-07 14:43:20 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix use of assertFalse as per the hacking checks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixing as per the neutron hacking checks."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_38df3cd7","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":41},"in_reply_to":"fa69d971_7dcfe655","updated":"2016-01-07 09:52:45.000000000","message":"Thanks Reedip.\nYou are right. hacking checks don\u0027t say about message argument.\nfrom methods: test_assertfalse(), test_asserttrue()\nthe pass_code variable defines usages of assertFalse(expr) and assertTrue(expr), as single argument method.\n\njust a thought, Will that not help? :)","commit_id":"6111112a2f21969e39385552b747aa7ea9d80f9a"}]}