)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5a1dc3d43246f3605247b91ab95404cc27a49f62","unresolved":false,"context_lines":[{"line_number":14,"context_line":"of GMR. This way, logging is handled correctly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Without the error message being thrown, neutron-pd-notify is once again"},{"line_number":17,"context_line":"able to complete successfully when called by dibbler-client. Additionaly,"},{"line_number":18,"context_line":"this patch improves logging and command line options for pd_notify."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Iac3162f6b7e968c2f11fd8ef2a6e275242fb21ff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a5ae5dd_a045dfb3","line":17,"updated":"2016-02-04 08:10:13.000000000","message":"Additionally","commit_id":"8846e54edb2317b7af8ad3bf4a8dc8e2c809b133"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"084f04119cb01ef77f321935b773ec4b0437462c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"of GMR. This way, logging is handled correctly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Without the error message being thrown, neutron-pd-notify is once again"},{"line_number":17,"context_line":"able to complete successfully when called by dibbler-client. Additionaly,"},{"line_number":18,"context_line":"this patch improves logging and command line options for pd_notify."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Iac3162f6b7e968c2f11fd8ef2a6e275242fb21ff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a5ae5dd_4213ae66","line":17,"in_reply_to":"5a5ae5dd_a045dfb3","updated":"2016-02-04 18:51:26.000000000","message":"Removing the pd_notify changes, so this sentence is going.","commit_id":"8846e54edb2317b7af8ad3bf4a8dc8e2c809b133"}],"neutron/agent/linux/dibbler.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ddd346b53d41971cb678c584f7d3327e1f69fa68","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# The first line must be #!/usr/bin/env bash"},{"line_number":59,"context_line":"SCRIPT_TEMPLATE \u003d jinja2.Template(\"\"\"#!/usr/bin/env bash"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"exec neutron-pd-notify --operation $1 --prefix_fname {{ prefix_path }} \\"},{"line_number":62,"context_line":"--agent_pid {{ l3_agent_pid }}"},{"line_number":63,"context_line":"\"\"\")"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_e0cd175e","line":61,"updated":"2016-02-04 08:08:53.000000000","message":"I suspect the change does not really belong to the fix you pursue (unbreaking notify script). Can you leave it out of scope for the patch?\n\nAlso, I wonder whether the change is compatible with existing dibbler processes that are configured to use old format for the arguments. My understanding is that on agent restart, if dibbler is still running, we don\u0027t touch it. So dibbler will still stay configured to use the old format of the arguments, while the new notify tool code will not work with them, so you\u0027ll get your notification broken.\n\nAmirite?","commit_id":"8846e54edb2317b7af8ad3bf4a8dc8e2c809b133"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"414e014ca48c1545ca753b1871cdd9ba02137c68","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# The first line must be #!/usr/bin/env bash"},{"line_number":59,"context_line":"SCRIPT_TEMPLATE \u003d jinja2.Template(\"\"\"#!/usr/bin/env bash"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"exec neutron-pd-notify --operation $1 --prefix_fname {{ prefix_path }} \\"},{"line_number":62,"context_line":"--agent_pid {{ l3_agent_pid }}"},{"line_number":63,"context_line":"\"\"\")"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_89cd2bb9","line":61,"in_reply_to":"5a5ae5dd_25c1dc80","updated":"2016-02-05 10:30:05.000000000","message":"Are you sure? As per the code, why start a new client only if there is no pid file with a valid PID [2].\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/agent/linux/pd.py#L270\n[2] https://github.com/openstack/neutron/blob/master/neutron/agent/linux/dibbler.py#L77","commit_id":"8846e54edb2317b7af8ad3bf4a8dc8e2c809b133"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"084f04119cb01ef77f321935b773ec4b0437462c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# The first line must be #!/usr/bin/env bash"},{"line_number":59,"context_line":"SCRIPT_TEMPLATE \u003d jinja2.Template(\"\"\"#!/usr/bin/env bash"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"exec neutron-pd-notify --operation $1 --prefix_fname {{ prefix_path }} \\"},{"line_number":62,"context_line":"--agent_pid {{ l3_agent_pid }}"},{"line_number":63,"context_line":"\"\"\")"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_25c1dc80","line":61,"in_reply_to":"5a5ae5dd_e0cd175e","updated":"2016-02-04 18:51:26.000000000","message":"I\u0027ll remove these changes because you\u0027re right, they\u0027re not really in scope - just nice to have. Dibbler is actually restarted on agent restart, so this change shouldn\u0027t cause compatibility issues, but lets tackle that in a separate patch.","commit_id":"8846e54edb2317b7af8ad3bf4a8dc8e2c809b133"}],"neutron/cmd/__init__.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e5bd15d4aa4e320b96c1c799e424d8a1bfc44df5","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from oslo_reports import guru_meditation_report as gmr"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron import version"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"_version_string \u003d version.version_info.release_string()"},{"line_number":20,"context_line":"gmr.TextGuruMeditation.setup_autorun(version\u003d_version_string)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_7c7d051b","side":"PARENT","line":17,"updated":"2016-01-11 11:17:31.000000000","message":"Shouldn\u0027t we instead just set logging handler here before calling to GMR? I don\u0027t like how we spread the same code into all entry point files.","commit_id":"8e5424865386dfce5c01864a63474711caad760b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"396c56fc239f20488b77b75fbd11b6cecf5921f3","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from oslo_reports import guru_meditation_report as gmr"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron import version"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"_version_string \u003d version.version_info.release_string()"},{"line_number":20,"context_line":"gmr.TextGuruMeditation.setup_autorun(version\u003d_version_string)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_e5a31a9d","side":"PARENT","line":17,"in_reply_to":"fa69d971_351ea570","updated":"2016-01-12 12:36:29.000000000","message":"I don\u0027t agree we should keep the file light. It\u0027s *designed* to call code that is common to all entry points under it.\n\nDuplicating the same code is not the best thing you could do. So, have you actually tried just defining logging inside the module?","commit_id":"8e5424865386dfce5c01864a63474711caad760b"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"7e6590dbd0ddc09e35f511cc53bb656208c2c6c0","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from oslo_reports import guru_meditation_report as gmr"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron import version"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"_version_string \u003d version.version_info.release_string()"},{"line_number":20,"context_line":"gmr.TextGuruMeditation.setup_autorun(version\u003d_version_string)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_351ea570","side":"PARENT","line":17,"in_reply_to":"fa69d971_7c7d051b","updated":"2016-01-11 22:03:54.000000000","message":"For the sake of keeping the __init__ file as light as possible, I think I prefer Manjeet\u0027s suggestion below.","commit_id":"8e5424865386dfce5c01864a63474711caad760b"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"45ad3cd0c091f7eacca956fce7a74283b6007a14","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_reports import guru_meditation_report as gmr"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron import version"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"_version_string \u003d version.version_info.release_string()"},{"line_number":20,"context_line":"gmr.TextGuruMeditation.setup_autorun(version\u003d_version_string)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_399ca65c","side":"PARENT","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":0},"updated":"2016-01-08 21:45:10.000000000","message":"can\u0027t this be defined as function and called it wherever needed ? instead to putting all four line into other files ?","commit_id":"8e5424865386dfce5c01864a63474711caad760b"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"7e6590dbd0ddc09e35f511cc53bb656208c2c6c0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_reports import guru_meditation_report as gmr"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron import version"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"_version_string \u003d version.version_info.release_string()"},{"line_number":20,"context_line":"gmr.TextGuruMeditation.setup_autorun(version\u003d_version_string)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_f53c8de2","side":"PARENT","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":0},"in_reply_to":"fa69d971_399ca65c","updated":"2016-01-11 22:03:54.000000000","message":"Done","commit_id":"8e5424865386dfce5c01864a63474711caad760b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7c5ddfd4bbdd044bbf215b45050b72d2705bae46","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron.common import config"},{"line_number":18,"context_line":"from neutron import version"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"config.setup_logging()"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"_version_string \u003d version.version_info.release_string()"},{"line_number":23,"context_line":"gmr.TextGuruMeditation.setup_autorun(version\u003d_version_string)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_a8cc72bb","line":20,"updated":"2016-01-25 05:53:08.000000000","message":"with this addition this line will be executed twice, but I assume this to be idempotent?","commit_id":"5c33b173fdd9ccd581ca463a1b5342f3ba97bc56"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ed1c90b07e21bd9f1bb95aa92ac788da433685b7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron.common import config"},{"line_number":18,"context_line":"from neutron import version"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"config.setup_logging()"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"_version_string \u003d version.version_info.release_string()"},{"line_number":23,"context_line":"gmr.TextGuruMeditation.setup_autorun(version\u003d_version_string)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_8b1e3b6e","line":20,"in_reply_to":"9a68dd71_a8cc72bb","updated":"2016-01-25 12:17:27.000000000","message":"You are right. We may want to remove it from config.py","commit_id":"5c33b173fdd9ccd581ca463a1b5342f3ba97bc56"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e82b041ed7e75c509f46b704620e6a9ae9ce2727","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron import version"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def initiate_gmr():"},{"line_number":21,"context_line":"    _version_string \u003d version.version_info.release_string()"},{"line_number":22,"context_line":"    gmr.TextGuruMeditation.setup_autorun(version\u003d_version_string)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_e43c14ca","line":20,"updated":"2016-02-05 04:06:02.000000000","message":"I must be missing something, but once we do this aren\u0027t we supposed to do this for all the commands as specific in [1] and available in [2], most notably neutron-server?\n\n[1] https://github.com/openstack/neutron/blob/master/setup.cfg#L42\n[2] https://github.com/openstack/neutron/tree/master/neutron/cmd","commit_id":"1e6974c10b6c430b10fe63d50f1b79471fc3ac22"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c5b27d6245d5b20f9110698d0df2424478f483db","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron import version"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def initiate_gmr():"},{"line_number":21,"context_line":"    _version_string \u003d version.version_info.release_string()"},{"line_number":22,"context_line":"    gmr.TextGuruMeditation.setup_autorun(version\u003d_version_string)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_c96563b5","line":20,"in_reply_to":"5a5ae5dd_e43c14ca","updated":"2016-02-05 10:32:27.000000000","message":"Yes, we absolutely should.","commit_id":"1e6974c10b6c430b10fe63d50f1b79471fc3ac22"}],"neutron/cmd/ipset_cleanup.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"276177008006722957e368bfd77c8e67841decc2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron._i18n import _, _LE, _LI"},{"line_number":20,"context_line":"from neutron.agent.linux import ipset_manager"},{"line_number":21,"context_line":"from neutron.agent.linux import utils"},{"line_number":22,"context_line":"from neutron.cmd import initiate_gmr"},{"line_number":23,"context_line":"from neutron.common import config"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_c93651b4","line":22,"range":{"start_line":22,"start_character":24,"end_line":22,"end_character":36},"updated":"2016-01-11 22:09:28.000000000","message":"you should import only modules","commit_id":"d5a152a407160135f7b8751a5e1e776703f238ee"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"7d8087307ce1df6296aab5fab3a8a3629b47db0d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron._i18n import _, _LE, _LI"},{"line_number":20,"context_line":"from neutron.agent.linux import ipset_manager"},{"line_number":21,"context_line":"from neutron.agent.linux import utils"},{"line_number":22,"context_line":"from neutron.cmd import initiate_gmr"},{"line_number":23,"context_line":"from neutron.common import config"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_cf4c1179","line":22,"range":{"start_line":22,"start_character":24,"end_line":22,"end_character":36},"in_reply_to":"da6ed579_c93651b4","updated":"2016-01-11 22:45:44.000000000","message":"Done","commit_id":"d5a152a407160135f7b8751a5e1e776703f238ee"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"05a08441540364cb78bc81760faa5d98ff47a284","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import neutron.cmd as n_cmd"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_ab7bc87a","line":16,"updated":"2016-01-12 04:41:34.000000000","message":"This should go alphabetically with the other neutron imports below, and it is more common in neutron convention to write:\n\n  from neutron import cmd as n_cmd\n\n\nSame for the rest of the patch.","commit_id":"ef7b89ef4a4d2c53b44f08d9c0881d8430a713ed"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f284581d9f24a08f00e2c7c2893c3ee8a564776b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import neutron.cmd as n_cmd"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_7f8800e8","line":16,"in_reply_to":"da6ed579_1fe8e4e1","updated":"2016-01-12 19:06:02.000000000","message":"the check was removed from openstack hacking rules lately.","commit_id":"ef7b89ef4a4d2c53b44f08d9c0881d8430a713ed"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"43bc4e5291e4ef9ddcd84c89c9bdbc563138a7e3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import neutron.cmd as n_cmd"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_df580c59","line":16,"in_reply_to":"da6ed579_7f8800e8","updated":"2016-01-12 19:09:52.000000000","message":"ok. thanks.","commit_id":"ef7b89ef4a4d2c53b44f08d9c0881d8430a713ed"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"9e714eb0223e3277a26e230cb879c72b869d4cf0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import neutron.cmd as n_cmd"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_1fe8e4e1","line":16,"in_reply_to":"da6ed579_ab7bc87a","updated":"2016-01-12 19:01:49.000000000","message":"+1 @henry don\u0027t we have a check in pep8 for this ?","commit_id":"ef7b89ef4a4d2c53b44f08d9c0881d8430a713ed"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"0d22ceed47a457b27878cc1e4e2ab3ddc53efff7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import neutron.cmd as n_cmd"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_ad73a27f","line":16,"in_reply_to":"da6ed579_ab7bc87a","updated":"2016-01-19 18:59:17.000000000","message":"Done","commit_id":"ef7b89ef4a4d2c53b44f08d9c0881d8430a713ed"}],"neutron/cmd/pd_notify.py":[{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"b1d7aa77598994a43c232abfdd0ccc6de5fb1262","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    cli_opts \u003d ["},{"line_number":38,"context_line":"        cfg.StrOpt(\u0027operation\u0027,"},{"line_number":39,"context_line":"                   help\u003d_(\u0027The add/update/delete operation performed by the \u0027"},{"line_number":40,"context_line":"                          \u0027PD agent.\u0027)),"},{"line_number":41,"context_line":"        cfg.StrOpt(\u0027prefix_fname\u0027,"},{"line_number":42,"context_line":"                   help\u003d_(\u0027The file where the new prefix should be written.\u0027)),"},{"line_number":43,"context_line":"        cfg.StrOpt(\u0027agent_pid\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_0f21924d","line":40,"range":{"start_line":40,"start_character":30,"end_line":40,"end_character":35},"updated":"2016-02-03 23:05:22.000000000","message":"The help msg is a bit confusing to me. What\u0027s PD agent? Is it different from the agent_pid (for l3 agent)?\n\nWould it be: to add/update/delete a prefix requested by the PD client?","commit_id":"d20a9c500584a8ef6ffbd1357d64d9fd562d6e38"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"01283fd6c430044d6f09c0cd1f33408e0db11532","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    cli_opts \u003d ["},{"line_number":38,"context_line":"        cfg.StrOpt(\u0027operation\u0027,"},{"line_number":39,"context_line":"                   help\u003d_(\u0027The add/update/delete operation performed by the \u0027"},{"line_number":40,"context_line":"                          \u0027PD agent.\u0027)),"},{"line_number":41,"context_line":"        cfg.StrOpt(\u0027prefix_fname\u0027,"},{"line_number":42,"context_line":"                   help\u003d_(\u0027The file where the new prefix should be written.\u0027)),"},{"line_number":43,"context_line":"        cfg.StrOpt(\u0027agent_pid\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_25c26f86","line":40,"range":{"start_line":40,"start_character":30,"end_line":40,"end_character":35},"in_reply_to":"5a5ae5dd_0f21924d","updated":"2016-02-04 00:45:01.000000000","message":"Done","commit_id":"d20a9c500584a8ef6ffbd1357d64d9fd562d6e38"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"b1d7aa77598994a43c232abfdd0ccc6de5fb1262","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        utils.replace_file(conf.prefix_fname, \"%s/64\" % prefix)"},{"line_number":65,"context_line":"    elif conf.operation \u003d\u003d \"delete\":"},{"line_number":66,"context_line":"        LOG.info(_LI(\"Deleting recorded prefix\"))"},{"line_number":67,"context_line":"        utils.replace_file(conf.prefix_fname, \"::/64\")"},{"line_number":68,"context_line":"    os.kill(int(conf.agent_pid), signal.SIGUSR1)"},{"line_number":69,"context_line":"    LOG.info(_LI(\"Kill signal sent to l3 agent\"))"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_afa63ebf","line":67,"range":{"start_line":67,"start_character":14,"end_line":67,"end_character":26},"updated":"2016-02-03 23:05:22.000000000","message":"Nit: it seems to me that one log message at the begging (line 60) would be good enough. something like:\n   Notify \u003cagent_id\u003e to \u003coperation\u003e prefix: \u003cprefix\u003e","commit_id":"d20a9c500584a8ef6ffbd1357d64d9fd562d6e38"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"01283fd6c430044d6f09c0cd1f33408e0db11532","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        utils.replace_file(conf.prefix_fname, \"%s/64\" % prefix)"},{"line_number":65,"context_line":"    elif conf.operation \u003d\u003d \"delete\":"},{"line_number":66,"context_line":"        LOG.info(_LI(\"Deleting recorded prefix\"))"},{"line_number":67,"context_line":"        utils.replace_file(conf.prefix_fname, \"::/64\")"},{"line_number":68,"context_line":"    os.kill(int(conf.agent_pid), signal.SIGUSR1)"},{"line_number":69,"context_line":"    LOG.info(_LI(\"Kill signal sent to l3 agent\"))"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_0d2c3901","line":67,"range":{"start_line":67,"start_character":14,"end_line":67,"end_character":26},"in_reply_to":"5a5ae5dd_afa63ebf","updated":"2016-02-04 00:45:01.000000000","message":"I\u0027ve consolidated all log messages from L60 onwards into a single message that is logged after the kill signal is sent. Additionally, I\u0027ve cleaned up this section to reduce code duplication.","commit_id":"d20a9c500584a8ef6ffbd1357d64d9fd562d6e38"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"300c155c48147471478c73a69c54ef01d9515b85","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if conf.operation \u003d\u003d \"delete\":"},{"line_number":64,"context_line":"            prefix \u003d \"::\""},{"line_number":65,"context_line":"        utils.replace_file(conf.prefix_fname, \"%s/64\" % prefix)"},{"line_number":66,"context_line":"    os.kill(int(conf.agent_pid), signal.SIGUSR1)"},{"line_number":67,"context_line":"    LOG.info(_LI(\"Agent %(agent_pid)s notified of new prefix: %(prefix)s/64\"),"},{"line_number":68,"context_line":"             {\u0027agent_pid\u0027: conf.agent_pid, \u0027prefix\u0027: prefix})"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_89ca3e6d","line":66,"range":{"start_line":66,"start_character":33,"end_line":66,"end_character":39},"updated":"2016-02-04 13:24:25.000000000","message":"should the above call be indented inside the \"if\" statement?","commit_id":"8846e54edb2317b7af8ad3bf4a8dc8e2c809b133"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"084f04119cb01ef77f321935b773ec4b0437462c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if conf.operation \u003d\u003d \"delete\":"},{"line_number":64,"context_line":"            prefix \u003d \"::\""},{"line_number":65,"context_line":"        utils.replace_file(conf.prefix_fname, \"%s/64\" % prefix)"},{"line_number":66,"context_line":"    os.kill(int(conf.agent_pid), signal.SIGUSR1)"},{"line_number":67,"context_line":"    LOG.info(_LI(\"Agent %(agent_pid)s notified of new prefix: %(prefix)s/64\"),"},{"line_number":68,"context_line":"             {\u0027agent_pid\u0027: conf.agent_pid, \u0027prefix\u0027: prefix})"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_855f70e4","line":66,"range":{"start_line":66,"start_character":33,"end_line":66,"end_character":39},"in_reply_to":"5a5ae5dd_89ca3e6d","updated":"2016-02-04 18:51:26.000000000","message":"I\u0027m removing all of these changes so we can concentrate on getting the bug fixed.","commit_id":"8846e54edb2317b7af8ad3bf4a8dc8e2c809b133"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"300c155c48147471478c73a69c54ef01d9515b85","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        utils.replace_file(conf.prefix_fname, \"%s/64\" % prefix)"},{"line_number":66,"context_line":"    os.kill(int(conf.agent_pid), signal.SIGUSR1)"},{"line_number":67,"context_line":"    LOG.info(_LI(\"Agent %(agent_pid)s notified of new prefix: %(prefix)s/64\"),"},{"line_number":68,"context_line":"             {\u0027agent_pid\u0027: conf.agent_pid, \u0027prefix\u0027: prefix})"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_e9889224","line":68,"range":{"start_line":68,"start_character":53,"end_line":68,"end_character":59},"updated":"2016-02-04 13:24:25.000000000","message":"If you want to keep just one log msg, in light of the if statement, the log can be moved to the beginning.","commit_id":"8846e54edb2317b7af8ad3bf4a8dc8e2c809b133"}]}
