)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"d42f3e71fa6d16ff8234819c55fbdee46fecc277","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make sure datapath_type is updated on bridges changed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When changing datapth_type in the config, physical and tunnel bridges"},{"line_number":10,"context_line":"do not have their datapath_type updated. Calling create() on already"},{"line_number":11,"context_line":"created bridges should be safe as it passes \u0027--may-exist\u0027 when adding"},{"line_number":12,"context_line":"the bridge, which will do nothing if the bridge already exists, but"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da6ed579_994bb0b0","line":9,"updated":"2016-01-12 11:21:21.000000000","message":"typo: datapath_type","commit_id":"67efa60f4c16a83dfa970f1fe89b835ebba74564"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"68169abb7abd382571a4a874e4e1acf2fc44ba71","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make sure datapath_type is updated on bridges changed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When changing datapth_type in the config, physical and tunnel bridges"},{"line_number":10,"context_line":"do not have their datapath_type updated. Calling create() on already"},{"line_number":11,"context_line":"created bridges should be safe as it passes \u0027--may-exist\u0027 when adding"},{"line_number":12,"context_line":"the bridge, which will do nothing if the bridge already exists, but"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da6ed579_ff6883bc","line":9,"in_reply_to":"da6ed579_994bb0b0","updated":"2016-01-12 13:59:35.000000000","message":"ditto. change is doing a respin.","commit_id":"67efa60f4c16a83dfa970f1fe89b835ebba74564"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"d42f3e71fa6d16ff8234819c55fbdee46fecc277","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"            br \u003d self.br_phys_cls(bridge)"},{"line_number":1061,"context_line":"            # The bridge already exists, so create won\u0027t recreate it, but will"},{"line_number":1062,"context_line":"            # handle things like changing the datapath_type"},{"line_number":1063,"context_line":"            br.create()"},{"line_number":1064,"context_line":"            br.setup_controllers(self.conf)"},{"line_number":1065,"context_line":"            br.setup_default_table()"},{"line_number":1066,"context_line":"            self.phys_brs[physical_network] \u003d br"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_147307b3","line":1063,"updated":"2016-01-12 11:21:21.000000000","message":"I don\u0027t think we ever need to change the datapath_type of physical bridges. Is this really needed? What\u0027s the reason behind adding this line?","commit_id":"67efa60f4c16a83dfa970f1fe89b835ebba74564"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"68169abb7abd382571a4a874e4e1acf2fc44ba71","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"            br \u003d self.br_phys_cls(bridge)"},{"line_number":1061,"context_line":"            # The bridge already exists, so create won\u0027t recreate it, but will"},{"line_number":1062,"context_line":"            # handle things like changing the datapath_type"},{"line_number":1063,"context_line":"            br.create()"},{"line_number":1064,"context_line":"            br.setup_controllers(self.conf)"},{"line_number":1065,"context_line":"            br.setup_default_table()"},{"line_number":1066,"context_line":"            self.phys_brs[physical_network] \u003d br"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_5f5c2f25","line":1063,"in_reply_to":"da6ed579_147307b3","updated":"2016-01-12 13:59:35.000000000","message":"ditto","commit_id":"67efa60f4c16a83dfa970f1fe89b835ebba74564"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"90f2f0a07657d2a274a592d98452631685fd8c29","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"            br \u003d self.br_phys_cls(bridge)"},{"line_number":1061,"context_line":"            # The bridge already exists, so create won\u0027t recreate it, but will"},{"line_number":1062,"context_line":"            # handle things like changing the datapath_type"},{"line_number":1063,"context_line":"            br.create()"},{"line_number":1064,"context_line":"            br.setup_controllers(self.conf)"},{"line_number":1065,"context_line":"            br.setup_default_table()"},{"line_number":1066,"context_line":"            self.phys_brs[physical_network] \u003d br"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_a7f99d4f","line":1063,"in_reply_to":"da6ed579_5f5c2f25","updated":"2016-01-12 15:20:22.000000000","message":"The partial OVSBridge that is created above via br_phys_cls(bridge) has the datapath_type set to netdev (or whatever is configured). As we instantiate the class, but never call create, the value only matches if the bridge was originally created with the same value. In the case where things are reconfigured, the values would differ.","commit_id":"67efa60f4c16a83dfa970f1fe89b835ebba74564"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"77c06ab27f9cd365c93be26dba6ebd7b3c4742f1","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"            br \u003d self.br_phys_cls(bridge)"},{"line_number":1061,"context_line":"            # The bridge already exists, so create won\u0027t recreate it, but will"},{"line_number":1062,"context_line":"            # handle things like changing the datapath_type"},{"line_number":1063,"context_line":"            br.create()"},{"line_number":1064,"context_line":"            br.setup_controllers(self.conf)"},{"line_number":1065,"context_line":"            br.setup_default_table()"},{"line_number":1066,"context_line":"            self.phys_brs[physical_network] \u003d br"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_1fcf8480","line":1063,"in_reply_to":"da6ed579_a7f99d4f","updated":"2016-01-12 19:03:59.000000000","message":"yes as terry said above the call to create is required to ensure all bridges are reconfigured if the bridge already exits when the agent is started.\n\nAs the physical bridges are interconnected by patch ports to the br-int if the datapath is different no traffic will flow between the bridges.\n\nthis would only effect vlan and flat networks as the br-tun will be used for all other networks.\n\nin the special case of converting a kernel ovs install to ovs with dpdk  if you remove the call to create here the physical bridges will not be updated by the agent to the netdev datapath.","commit_id":"67efa60f4c16a83dfa970f1fe89b835ebba74564"}]}
