)]}'
{"neutron/plugins/ml2/drivers/l2pop/mech_driver.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"9d2b55e5333f4d183c8bd0a50d6834ef8494a0e6","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def _update_port_up(self, context):"},{"line_number":208,"context_line":"        port \u003d context.current"},{"line_number":209,"context_line":"        agent_host \u003d context.host"},{"line_number":210,"context_line":"        session \u003d db_api.get_session()"},{"line_number":211,"context_line":"        agent \u003d self.get_agent_by_host(session, agent_host)"},{"line_number":212,"context_line":"        if not agent:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_45c1c7e3","line":209,"updated":"2016-01-12 12:29:21.000000000","message":"What if agent_host is None? From the code, it will hit line 213, to print the warning \"Unable to retrieve active L2 agent on host None\". I don\u0027t know if it is a acceptable change.","commit_id":"b53527b2cc8115dd639855a0fe4a5eb348953998"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"51be4fd8f0bdd3703c0ffd4117db409659c52744","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def _update_port_up(self, context):"},{"line_number":208,"context_line":"        port \u003d context.current"},{"line_number":209,"context_line":"        agent_host \u003d context.host"},{"line_number":210,"context_line":"        session \u003d db_api.get_session()"},{"line_number":211,"context_line":"        agent \u003d self.get_agent_by_host(session, agent_host)"},{"line_number":212,"context_line":"        if not agent:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_4eb9e3e8","line":209,"in_reply_to":"da6ed579_45c1c7e3","updated":"2016-01-12 13:22:32.000000000","message":"That was changed in the previous patch, not this one. I think it\u0027s reasonable, it\u0027s only hit if the status changed to ACTIVE. In that case it\u0027s kinda odd if an agent is not found for the port.","commit_id":"b53527b2cc8115dd639855a0fe4a5eb348953998"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"9d2b55e5333f4d183c8bd0a50d6834ef8494a0e6","unresolved":false,"context_lines":[{"line_number":261,"context_line":"            session, agent_host, network_id)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        agent \u003d self.get_agent_by_host(db_api.get_session(), agent_host)"},{"line_number":264,"context_line":"        segment \u003d self._get_and_validate_segment(context, port[\u0027id\u0027], agent)"},{"line_number":265,"context_line":"        agent_ip \u003d self.get_agent_ip(agent)"},{"line_number":266,"context_line":"        other_fdb_entries \u003d self._get_fdb_entries_template("},{"line_number":267,"context_line":"            segment, agent_ip, port[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_254a9384","line":264,"updated":"2016-01-12 12:29:21.000000000","message":"I think you need to check if segment is None, just as line 224 do.","commit_id":"b53527b2cc8115dd639855a0fe4a5eb348953998"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"51be4fd8f0bdd3703c0ffd4117db409659c52744","unresolved":false,"context_lines":[{"line_number":261,"context_line":"            session, agent_host, network_id)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        agent \u003d self.get_agent_by_host(db_api.get_session(), agent_host)"},{"line_number":264,"context_line":"        segment \u003d self._get_and_validate_segment(context, port[\u0027id\u0027], agent)"},{"line_number":265,"context_line":"        agent_ip \u003d self.get_agent_ip(agent)"},{"line_number":266,"context_line":"        other_fdb_entries \u003d self._get_fdb_entries_template("},{"line_number":267,"context_line":"            segment, agent_ip, port[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_6e4dc771","line":264,"in_reply_to":"da6ed579_254a9384","updated":"2016-01-12 13:22:32.000000000","message":"Done.","commit_id":"b53527b2cc8115dd639855a0fe4a5eb348953998"}],"neutron/tests/unit/plugins/ml2/drivers/l2pop/test_mech_driver.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"9d2b55e5333f4d183c8bd0a50d6834ef8494a0e6","unresolved":false,"context_lines":[{"line_number":820,"context_line":"            l2pop_mech._fixed_ips_changed("},{"line_number":821,"context_line":"                port_context, None, port[\u0027port\u0027], (set([\u002710.0.0.1\u0027]), set()))"},{"line_number":822,"context_line":""},{"line_number":823,"context_line":"        # There\u0027s no need to send an RPC update if the IP address for an"},{"line_number":824,"context_line":"        # unbound port changed."},{"line_number":825,"context_line":"        self.assertFalse("},{"line_number":826,"context_line":"            l2pop_mech.L2populationAgentNotify.update_fdb_entries.called)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_25a133aa","line":823,"range":{"start_line":823,"start_character":34,"end_line":823,"end_character":36},"updated":"2016-01-12 12:29:21.000000000","message":"nit: s/an/a/g","commit_id":"b53527b2cc8115dd639855a0fe4a5eb348953998"}]}
