)]}'
{"neutron/agent/linux/daemon.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"961289dedc3c508b22d16efc85eaeaf506104faa","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    def _fork(self):"},{"line_number":185,"context_line":"        try:"},{"line_number":186,"context_line":"            pid \u003d os.fork()"},{"line_number":187,"context_line":"            if pid:"},{"line_number":188,"context_line":"                os._exit(0)"},{"line_number":189,"context_line":"        except OSError:"},{"line_number":190,"context_line":"            LOG.exception(_LE(\u0027Fork failed\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_9f0aa7d1","line":187,"updated":"2016-01-12 14:08:03.000000000","message":"so now if fork() failed and returned -1, you still exit...","commit_id":"c2210c1fd37ad70b0b70868d5521191ef2d85097"}],"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"961289dedc3c508b22d16efc85eaeaf506104faa","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"    advertisements (RAs) are sufficient for address resolution and"},{"line_number":1009,"context_line":"    duplicate address detection."},{"line_number":1010,"context_line":"    \"\"\""},{"line_number":1011,"context_line":"    count \u003d config.send_arp_for_ha"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    def arping():"},{"line_number":1014,"context_line":"        _arping(ns_name, iface_name, address, count)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_bfc8cb75","line":1011,"updated":"2016-01-12 14:08:03.000000000","message":"there is no guard against having the value negative in the config file.","commit_id":"c2210c1fd37ad70b0b70868d5521191ef2d85097"}],"neutron/api/api_common.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"961289dedc3c508b22d16efc85eaeaf506104faa","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    \"\"\""},{"line_number":86,"context_line":"    max_limit \u003d _get_pagination_max_limit()"},{"line_number":87,"context_line":"    limit \u003d _get_limit_param(request)"},{"line_number":88,"context_line":"    if max_limit:"},{"line_number":89,"context_line":"        limit \u003d min(max_limit, limit) or max_limit"},{"line_number":90,"context_line":"    if not limit:"},{"line_number":91,"context_line":"        return None, None"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_ffa3a39c","line":88,"updated":"2016-01-12 14:08:03.000000000","message":"max_limit can be -1.","commit_id":"c2210c1fd37ad70b0b70868d5521191ef2d85097"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"aabfc669c1bbdf1b99ac2329473400bfc4597019","unresolved":false,"context_lines":[{"line_number":537,"context_line":"                LOG.debug(\"attempt to remove a non-existent port %s\", ofport)"},{"line_number":538,"context_line":"                return"},{"line_number":539,"context_line":"            lvm.tun_ofports.remove(ofport)"},{"line_number":540,"context_line":"            if len(lvm.tun_ofports):"},{"line_number":541,"context_line":"                br.install_flood_to_tun(lvm.vlan, lvm.segmentation_id,"},{"line_number":542,"context_line":"                                        lvm.tun_ofports)"},{"line_number":543,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_e6e1f7ff","line":540,"updated":"2016-01-12 05:17:55.000000000","message":"if lvm.tun_ofports","commit_id":"c2210c1fd37ad70b0b70868d5521191ef2d85097"}],"neutron/plugins/ml2/drivers/type_flat.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"961289dedc3c508b22d16efc85eaeaf506104faa","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    def get_mtu(self, physical_network):"},{"line_number":142,"context_line":"        seg_mtu \u003d super(FlatTypeDriver, self).get_mtu()"},{"line_number":143,"context_line":"        mtu \u003d []"},{"line_number":144,"context_line":"        if seg_mtu:"},{"line_number":145,"context_line":"            mtu.append(seg_mtu)"},{"line_number":146,"context_line":"        if physical_network in self.physnet_mtus:"},{"line_number":147,"context_line":"            mtu.append(int(self.physnet_mtus[physical_network]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_bf49abd2","line":144,"updated":"2016-01-12 14:08:03.000000000","message":"there is no guard that the result is not negative.","commit_id":"c2210c1fd37ad70b0b70868d5521191ef2d85097"}],"neutron/plugins/ml2/drivers/type_tunnel.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"961289dedc3c508b22d16efc85eaeaf506104faa","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        mtu \u003d []"},{"line_number":248,"context_line":"        if seg_mtu:"},{"line_number":249,"context_line":"            mtu.append(seg_mtu)"},{"line_number":250,"context_line":"        if cfg.CONF.ml2.path_mtu:"},{"line_number":251,"context_line":"            mtu.append(cfg.CONF.ml2.path_mtu)"},{"line_number":252,"context_line":"        return min(mtu) if mtu else 0"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_9f1707a3","line":250,"updated":"2016-01-12 14:08:03.000000000","message":"could be negative","commit_id":"c2210c1fd37ad70b0b70868d5521191ef2d85097"}],"neutron/plugins/ml2/managers.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"aabfc669c1bbdf1b99ac2329473400bfc4597019","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    def _add_network_segment(self, session, network_id, segment, mtu,"},{"line_number":185,"context_line":"                             segment_index\u003d0):"},{"line_number":186,"context_line":"        db.add_network_segment(session, network_id, segment, segment_index)"},{"line_number":187,"context_line":"        if segment.get(api.MTU, 0):"},{"line_number":188,"context_line":"            mtu.append(segment[api.MTU])"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def create_network_segments(self, context, network, tenant_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_a6e45f0d","line":187,"updated":"2016-01-12 05:17:55.000000000","message":"if segment.get(api.MTU)","commit_id":"c2210c1fd37ad70b0b70868d5521191ef2d85097"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"aabfc669c1bbdf1b99ac2329473400bfc4597019","unresolved":false,"context_lines":[{"line_number":632,"context_line":"                                                         result)"},{"line_number":633,"context_line":"            self.mechanism_manager.create_network_precommit(mech_context)"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"            if net_data.get(api.MTU, 0):"},{"line_number":636,"context_line":"                res \u003d super(Ml2Plugin, self).update_network(context,"},{"line_number":637,"context_line":"                    result[\u0027id\u0027], {\u0027network\u0027: {api.MTU: net_data[api.MTU]}})"},{"line_number":638,"context_line":"                result[api.MTU] \u003d res.get(api.MTU, 0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_86e7db11","line":635,"updated":"2016-01-12 05:17:55.000000000","message":"if net_data.get(api.MTU)","commit_id":"c2210c1fd37ad70b0b70868d5521191ef2d85097"}],"neutron/tests/tempest/auth.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"aabfc669c1bbdf1b99ac2329473400bfc4597019","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        catalog \u003d _auth_data[\u0027catalog\u0027]"},{"line_number":396,"context_line":"        # Select entries with matching service type"},{"line_number":397,"context_line":"        service_catalog \u003d [ep for ep in catalog if ep[\u0027type\u0027] \u003d\u003d service]"},{"line_number":398,"context_line":"        if len(service_catalog):"},{"line_number":399,"context_line":"            service_catalog \u003d service_catalog[0][\u0027endpoints\u0027]"},{"line_number":400,"context_line":"        else:"},{"line_number":401,"context_line":"            # No matching service"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_46f1e3cc","line":398,"updated":"2016-01-12 05:17:55.000000000","message":"if service_catalog","commit_id":"c2210c1fd37ad70b0b70868d5521191ef2d85097"}],"neutron/tests/tempest/common/generator/base_generator.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"aabfc669c1bbdf1b99ac2329473400bfc4597019","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            invalid_snippet \u003d generator_result[1]"},{"line_number":172,"context_line":"            expected_result \u003d generator_result[2]"},{"line_number":173,"context_line":"            element \u003d path.pop()"},{"line_number":174,"context_line":"            if len(path):"},{"line_number":175,"context_line":"                schema_snip \u003d six.moves.reduce(dict.get, path, schema)"},{"line_number":176,"context_line":"                schema_snip[element] \u003d invalid_snippet"},{"line_number":177,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_06ba0be2","line":174,"updated":"2016-01-12 05:17:55.000000000","message":"if path","commit_id":"c2210c1fd37ad70b0b70868d5521191ef2d85097"}],"neutron/tests/tempest/exceptions.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"aabfc669c1bbdf1b99ac2329473400bfc4597019","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        except Exception:"},{"line_number":34,"context_line":"            # at least get the core message out if something happened"},{"line_number":35,"context_line":"            self._error_string \u003d self.message"},{"line_number":36,"context_line":"        if len(args):"},{"line_number":37,"context_line":"            # If there is a non-kwarg parameter, assume it\u0027s the error"},{"line_number":38,"context_line":"            # message or reason description and tack it on to the end"},{"line_number":39,"context_line":"            # of the exception message"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_c6dcf348","line":36,"updated":"2016-01-12 05:17:55.000000000","message":"if args","commit_id":"c2210c1fd37ad70b0b70868d5521191ef2d85097"}],"neutron/wsgi.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"aabfc669c1bbdf1b99ac2329473400bfc4597019","unresolved":false,"context_lines":[{"line_number":448,"context_line":"            LOG.debug(\"No Content-Type provided in request\")"},{"line_number":449,"context_line":"            return {}"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        if not len(request.body):"},{"line_number":452,"context_line":"            LOG.debug(\"Empty body provided in request\")"},{"line_number":453,"context_line":"            return {}"},{"line_number":454,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_66ee67ee","line":451,"updated":"2016-01-12 05:17:55.000000000","message":"if not request.body","commit_id":"c2210c1fd37ad70b0b70868d5521191ef2d85097"}]}
