)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"2ea63500544c86ee7d6b3534bf53af7bb8ff686f","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Once Neutron starts using neutron-lib, next steps will be taking content"},{"line_number":16,"context_line":"of devstack/lib/ovs and putting it into neutron-lib project in order to"},{"line_number":17,"context_line":"let other projects like networking-ovn to re-use the code."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] https://github.com/openstack/networking-ovn/blob/master/devstack/plugin.sh#L175"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"5a5ae5dd_12ed5f8b","line":17,"range":{"start_line":17,"start_character":40,"end_line":17,"end_character":58},"updated":"2016-02-03 11:47:39.000000000","message":"totally agreed :)","commit_id":"2070b742a0dd718169943fdd8967f0222dcd4adb"}],"devstack/lib/ovs":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7d5bc6880f375726aa4072d49f3612779f3d45de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OVS_REPO\u003dhttps://github.com/justinpettit/ovs.git"},{"line_number":2,"context_line":"OVS_REPO_NAME\u003d$(basename ${OVS_REPO} | cut -f1 -d\u0027.\u0027)"},{"line_number":3,"context_line":"OVS_BRANCH\u003dorigin/conntrack"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"da6ed579_3c8a9bc0","line":1,"updated":"2016-01-12 17:28:43.000000000","message":"Should be either:\n\nhttps://github.com/openvswitch/ovs.git\ngit@github.com:openvswitch/ovs.git\n\naccording to http://openvswitch.org/pipermail/announce/2014-April/000063.html","commit_id":"9b80c654d6a7c23549d63018041961de91f66e82"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1586c941637b64853523ab132a5469f92ae45c9f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OVS_REPO\u003dhttps://github.com/justinpettit/ovs.git"},{"line_number":2,"context_line":"OVS_REPO_NAME\u003d$(basename ${OVS_REPO} | cut -f1 -d\u0027.\u0027)"},{"line_number":3,"context_line":"OVS_BRANCH\u003dorigin/conntrack"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"da6ed579_e7f1ccce","line":1,"in_reply_to":"da6ed579_3c8a9bc0","updated":"2016-01-12 17:36:13.000000000","message":"Yeah, I\u0027m lying in the commit message :) This is the version I work with locally. I haven\u0027t taken a look yet whether all conntrack stuff is already merged in ovs. But thanks for pointing that out, I\u0027ll put a TODO here.","commit_id":"9b80c654d6a7c23549d63018041961de91f66e82"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"8d7c522d065de8e9641926e0102b8b4836959b02","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#TODO(jlibosva): Change to actual ovs repository"},{"line_number":2,"context_line":"OVS_REPO\u003d${OVS_REPO:-https://github.com/justinpettit/ovs.git}"},{"line_number":3,"context_line":"OVS_REPO_NAME\u003d$(basename ${OVS_REPO} | cut -f1 -d\u0027.\u0027)"},{"line_number":4,"context_line":"OVS_BRANCH\u003d${OVS_BRANCH:-origin/conntrack}"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"da6ed579_21c5625a","line":1,"updated":"2016-01-13 13:22:38.000000000","message":"can you add a license header to the new file?","commit_id":"2c7c0c1d02c86ed4cc4ebbb4f103fbf5bc9595d0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"30aa824fed97043b39ea051e623276cea88c23cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#TODO(jlibosva): Change to actual ovs repository"},{"line_number":2,"context_line":"OVS_REPO\u003d${OVS_REPO:-https://github.com/justinpettit/ovs.git}"},{"line_number":3,"context_line":"OVS_REPO_NAME\u003d$(basename ${OVS_REPO} | cut -f1 -d\u0027.\u0027)"},{"line_number":4,"context_line":"OVS_BRANCH\u003d${OVS_BRANCH:-origin/conntrack}"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"da6ed579_6174bace","line":1,"in_reply_to":"da6ed579_21c5625a","updated":"2016-01-13 13:32:48.000000000","message":"Sure, I just looked at other files in this dir and they miss it.","commit_id":"2c7c0c1d02c86ed4cc4ebbb4f103fbf5bc9595d0"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"8d7c522d065de8e9641926e0102b8b4836959b02","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#TODO(jlibosva): Change to actual ovs repository"},{"line_number":2,"context_line":"OVS_REPO\u003d${OVS_REPO:-https://github.com/justinpettit/ovs.git}"},{"line_number":3,"context_line":"OVS_REPO_NAME\u003d$(basename ${OVS_REPO} | cut -f1 -d\u0027.\u0027)"},{"line_number":4,"context_line":"OVS_BRANCH\u003d${OVS_BRANCH:-origin/conntrack}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"function compile_ovs {"},{"line_number":7,"context_line":"    local _pwd\u003d$PWD"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"da6ed579_c1a246ae","line":4,"updated":"2016-01-13 13:22:38.000000000","message":"This should be updated now since all code is merged into ovs master at this point","commit_id":"2c7c0c1d02c86ed4cc4ebbb4f103fbf5bc9595d0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"30aa824fed97043b39ea051e623276cea88c23cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#TODO(jlibosva): Change to actual ovs repository"},{"line_number":2,"context_line":"OVS_REPO\u003d${OVS_REPO:-https://github.com/justinpettit/ovs.git}"},{"line_number":3,"context_line":"OVS_REPO_NAME\u003d$(basename ${OVS_REPO} | cut -f1 -d\u0027.\u0027)"},{"line_number":4,"context_line":"OVS_BRANCH\u003d${OVS_BRANCH:-origin/conntrack}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"function compile_ovs {"},{"line_number":7,"context_line":"    local _pwd\u003d$PWD"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"da6ed579_615b5a55","line":4,"in_reply_to":"da6ed579_c1a246ae","updated":"2016-01-13 13:32:48.000000000","message":"ok, will do once this patch actually works :)","commit_id":"2c7c0c1d02c86ed4cc4ebbb4f103fbf5bc9595d0"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"8d7c522d065de8e9641926e0102b8b4836959b02","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    sudo modprobe libcrc32c"},{"line_number":42,"context_line":"    # Be super explicit that we want our custom modules loaded ..."},{"line_number":43,"context_line":"    sudo insmod datapath/linux/openvswitch.ko"},{"line_number":44,"context_line":"    sudo insmod datapath/linux/vport-geneve.ko || (echo \"FAILED TO LOAD vport_geneve\" \u0026\u0026 dmesg)"},{"line_number":45,"context_line":"    sudo chown $(whoami) /usr/local/var/run/openvswitch"},{"line_number":46,"context_line":"    sudo chown $(whoami) /usr/local/var/log/openvswitch"},{"line_number":47,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"da6ed579_e193ca4d","line":44,"updated":"2016-01-13 13:22:38.000000000","message":"A lot of this has changed in networking-ovn, including making building/loading the custom module optional.  I would sync back up.\n\nI like the idea of getting this into a shared place, though.  Maybe we could split this part out in its own patch to get it in sooner so that we can start using the same lib/ovs ?","commit_id":"2c7c0c1d02c86ed4cc4ebbb4f103fbf5bc9595d0"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"c1595d39a37c9e3b9b9e97d5ca3d7823c6aa3fd5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    sudo modprobe libcrc32c"},{"line_number":42,"context_line":"    # Be super explicit that we want our custom modules loaded ..."},{"line_number":43,"context_line":"    sudo insmod datapath/linux/openvswitch.ko"},{"line_number":44,"context_line":"    sudo insmod datapath/linux/vport-geneve.ko || (echo \"FAILED TO LOAD vport_geneve\" \u0026\u0026 dmesg)"},{"line_number":45,"context_line":"    sudo chown $(whoami) /usr/local/var/run/openvswitch"},{"line_number":46,"context_line":"    sudo chown $(whoami) /usr/local/var/log/openvswitch"},{"line_number":47,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"da6ed579_e1c41c60","line":44,"in_reply_to":"da6ed579_1c48c55a","updated":"2016-01-13 16:53:31.000000000","message":"yes, you already have this function, i was thinking networking-ovn could use this function from the neutron tree","commit_id":"2c7c0c1d02c86ed4cc4ebbb4f103fbf5bc9595d0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"30aa824fed97043b39ea051e623276cea88c23cc","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    sudo modprobe libcrc32c"},{"line_number":42,"context_line":"    # Be super explicit that we want our custom modules loaded ..."},{"line_number":43,"context_line":"    sudo insmod datapath/linux/openvswitch.ko"},{"line_number":44,"context_line":"    sudo insmod datapath/linux/vport-geneve.ko || (echo \"FAILED TO LOAD vport_geneve\" \u0026\u0026 dmesg)"},{"line_number":45,"context_line":"    sudo chown $(whoami) /usr/local/var/run/openvswitch"},{"line_number":46,"context_line":"    sudo chown $(whoami) /usr/local/var/log/openvswitch"},{"line_number":47,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"da6ed579_1c48c55a","line":44,"in_reply_to":"da6ed579_e193ca4d","updated":"2016-01-13 13:32:48.000000000","message":"That\u0027s a good idea. You mean we\u0027ll put it in separate function and networking-ovn will source it from Neutron tree, right?","commit_id":"2c7c0c1d02c86ed4cc4ebbb4f103fbf5bc9595d0"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"77f2069e21d3452f03b2097c79794c948e22f165","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"OVS_REPO\u003d${OVS_REPO:-https://github.com/openvswitch/ovs.git}"},{"line_number":14,"context_line":"OVS_REPO_NAME\u003d$(basename ${OVS_REPO} | cut -f1 -d\u0027.\u0027)"},{"line_number":15,"context_line":"OVS_BRANCH\u003d${OVS_BRANCH:-origin/master}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Functions"},{"line_number":18,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"da6ed579_e9695626","line":15,"updated":"2016-01-13 20:56:07.000000000","message":"It looks like we\u0027re compiling master. This means that if OVS merge a regression it might affect us as well - For now I suggest that we pick a random commit (For example whatever is HEAD right now), so we\u0027re at least pinned against a known good revision of OVS. Then when they spin off a 2.5 branch we can pin on that.","commit_id":"2310793279f93236d34477637558f1af971771d1"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"58eef2dc310e840181785c23b56fda106beb4093","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"OVS_REPO\u003d${OVS_REPO:-https://github.com/openvswitch/ovs.git}"},{"line_number":14,"context_line":"OVS_REPO_NAME\u003d$(basename ${OVS_REPO} | cut -f1 -d\u0027.\u0027)"},{"line_number":15,"context_line":"OVS_BRANCH\u003d${OVS_BRANCH:-origin/master}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Functions"},{"line_number":18,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"da6ed579_79f0d7fe","line":15,"in_reply_to":"da6ed579_09138a67","updated":"2016-01-13 21:05:03.000000000","message":"Maybe define it in tox.ini. Otherwise local runs and the gate might have different results.","commit_id":"2310793279f93236d34477637558f1af971771d1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1fe6421d0041bd5dca97a5afa79199efc4e775c8","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"OVS_REPO\u003d${OVS_REPO:-https://github.com/openvswitch/ovs.git}"},{"line_number":14,"context_line":"OVS_REPO_NAME\u003d$(basename ${OVS_REPO} | cut -f1 -d\u0027.\u0027)"},{"line_number":15,"context_line":"OVS_BRANCH\u003d${OVS_BRANCH:-origin/master}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Functions"},{"line_number":18,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"da6ed579_b97c0fb6","line":15,"in_reply_to":"da6ed579_79f0d7fe","updated":"2016-01-13 21:15:42.000000000","message":"tox.ini is too late. gate_hook.sh is used prior to executing tox","commit_id":"2310793279f93236d34477637558f1af971771d1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e5e8c7039dfd9b68c01e9b2889c29cb4acccbddb","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"OVS_REPO\u003d${OVS_REPO:-https://github.com/openvswitch/ovs.git}"},{"line_number":14,"context_line":"OVS_REPO_NAME\u003d$(basename ${OVS_REPO} | cut -f1 -d\u0027.\u0027)"},{"line_number":15,"context_line":"OVS_BRANCH\u003d${OVS_BRANCH:-origin/master}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Functions"},{"line_number":18,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"da6ed579_09138a67","line":15,"in_reply_to":"da6ed579_e9695626","updated":"2016-01-13 21:01:32.000000000","message":"Makes sense. I\u0027d say to keep master as default and define commit per usage (e.g. define OVS_BRANCH in gate_hook.sh).","commit_id":"2310793279f93236d34477637558f1af971771d1"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"a2e19f106e1d712433b384806ae631badf1dac5c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    fi"},{"line_number":77,"context_line":"    load_module libcrc32c"},{"line_number":78,"context_line":"    load_module gre"},{"line_number":79,"context_line":"    load_module vxlan"},{"line_number":80,"context_line":"    load_module openvswitch"},{"line_number":81,"context_line":"    sudo modprobe vport-geneve || (echo \"FAILED TO LOAD vport_geneve\" \u0026\u0026 dmesg)"},{"line_number":82,"context_line":"    dmesg | tail"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"da6ed579_89045ac0","line":79,"updated":"2016-01-13 20:48:55.000000000","message":"You an remove these 3 lines","commit_id":"2310793279f93236d34477637558f1af971771d1"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"d06fde57074babaa0dac9755003fd3bb4cba4bb4","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    fi"},{"line_number":77,"context_line":"    load_module libcrc32c"},{"line_number":78,"context_line":"    load_module gre"},{"line_number":79,"context_line":"    load_module vxlan"},{"line_number":80,"context_line":"    load_module openvswitch"},{"line_number":81,"context_line":"    sudo modprobe vport-geneve || (echo \"FAILED TO LOAD vport_geneve\" \u0026\u0026 dmesg)"},{"line_number":82,"context_line":"    dmesg | tail"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"da6ed579_a9eefeb1","line":79,"in_reply_to":"da6ed579_4990a243","updated":"2016-01-13 20:54:53.000000000","message":"ah ok, i guess we\u0027re not using vxlan in the OVN jobs","commit_id":"2310793279f93236d34477637558f1af971771d1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a02151f9ff2c23a32591e2c801f84354fe1f8d73","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    fi"},{"line_number":77,"context_line":"    load_module libcrc32c"},{"line_number":78,"context_line":"    load_module gre"},{"line_number":79,"context_line":"    load_module vxlan"},{"line_number":80,"context_line":"    load_module openvswitch"},{"line_number":81,"context_line":"    sudo modprobe vport-geneve || (echo \"FAILED TO LOAD vport_geneve\" \u0026\u0026 dmesg)"},{"line_number":82,"context_line":"    dmesg | tail"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"da6ed579_4990a243","line":79,"in_reply_to":"da6ed579_89045ac0","updated":"2016-01-13 20:51:47.000000000","message":"It doesn\u0027t work for our functional jobs without it. Here is an vxlan example: http://logs.openstack.org/23/266423/7/check/gate-neutron-dsvm-functional/005d4f2/logs/kern_log.txt.gz","commit_id":"2310793279f93236d34477637558f1af971771d1"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"11f11012af9de788920f492f192c159b77c459e0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    fi"},{"line_number":69,"context_line":"    load_module libcrc32c"},{"line_number":70,"context_line":"    load_module gre"},{"line_number":71,"context_line":"    load_module vxlan"},{"line_number":72,"context_line":"    load_module openvswitch"},{"line_number":73,"context_line":"    sudo modprobe vport-geneve || (echo \"FAILED TO LOAD vport_geneve\" \u0026\u0026 dmesg)"},{"line_number":74,"context_line":"    dmesg | tail"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"7a5de9d1_34dc0718","line":71,"updated":"2016-02-02 16:20:11.000000000","message":"You can remove the above 3 lines.  modprobe will handle this automatically.","commit_id":"3e930425a3f1a6636e70ecd2bbde0524ec70a69e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f23705855807f2a087d40f8842757b8010f7200","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    fi"},{"line_number":69,"context_line":"    load_module libcrc32c"},{"line_number":70,"context_line":"    load_module gre"},{"line_number":71,"context_line":"    load_module vxlan"},{"line_number":72,"context_line":"    load_module openvswitch"},{"line_number":73,"context_line":"    sudo modprobe vport-geneve || (echo \"FAILED TO LOAD vport_geneve\" \u0026\u0026 dmesg)"},{"line_number":74,"context_line":"    dmesg | tail"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"7a5de9d1_85682389","line":71,"in_reply_to":"7a5de9d1_34dc0718","updated":"2016-02-02 17:13:44.000000000","message":"Done","commit_id":"3e930425a3f1a6636e70ecd2bbde0524ec70a69e"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"11f11012af9de788920f492f192c159b77c459e0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    load_module gre"},{"line_number":71,"context_line":"    load_module vxlan"},{"line_number":72,"context_line":"    load_module openvswitch"},{"line_number":73,"context_line":"    sudo modprobe vport-geneve || (echo \"FAILED TO LOAD vport_geneve\" \u0026\u0026 dmesg)"},{"line_number":74,"context_line":"    dmesg | tail"},{"line_number":75,"context_line":"    sudo chown $(whoami) /usr/local/var/run/openvswitch"},{"line_number":76,"context_line":"    sudo chown $(whoami) /usr/local/var/log/openvswitch"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"7a5de9d1_14eb0bb2","line":73,"updated":"2016-02-02 16:20:11.000000000","message":"How about adding an additional argument to load_module to say whether a failure should be fatal or not?","commit_id":"3e930425a3f1a6636e70ecd2bbde0524ec70a69e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f23705855807f2a087d40f8842757b8010f7200","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    load_module gre"},{"line_number":71,"context_line":"    load_module vxlan"},{"line_number":72,"context_line":"    load_module openvswitch"},{"line_number":73,"context_line":"    sudo modprobe vport-geneve || (echo \"FAILED TO LOAD vport_geneve\" \u0026\u0026 dmesg)"},{"line_number":74,"context_line":"    dmesg | tail"},{"line_number":75,"context_line":"    sudo chown $(whoami) /usr/local/var/run/openvswitch"},{"line_number":76,"context_line":"    sudo chown $(whoami) /usr/local/var/log/openvswitch"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"7a5de9d1_e581d7c4","line":73,"in_reply_to":"7a5de9d1_14eb0bb2","updated":"2016-02-02 17:13:44.000000000","message":"Done","commit_id":"3e930425a3f1a6636e70ecd2bbde0524ec70a69e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"de2199d3889d5ab954cfc81e7347c7c88e6e38a5","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    dmesg | tail"},{"line_number":75,"context_line":"    sudo chown $(whoami) /usr/local/var/run/openvswitch"},{"line_number":76,"context_line":"    sudo chown $(whoami) /usr/local/var/log/openvswitch"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    cd $_pwd"},{"line_number":79,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"7a5de9d1_b1a87078","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":0},"updated":"2016-01-31 10:34:06.000000000","message":"Should we remove old conf.db and lock here to make the function idempotent?","commit_id":"3e930425a3f1a6636e70ecd2bbde0524ec70a69e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ea07c6b413aa9fc6ef938fe26d0a28a967205f5d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    fi"},{"line_number":62,"context_line":"    if [ ! -f config.status ] || [ configure -nt config.status ] ; then"},{"line_number":63,"context_line":"        if [[ \"$build_modules\" \u003d\u003d \"True\" ]]; then"},{"line_number":64,"context_line":"            ./configure --with-linux\u003d/lib/modules/$(uname -r)/build"},{"line_number":65,"context_line":"        else"},{"line_number":66,"context_line":"            ./configure"},{"line_number":67,"context_line":"        fi"}],"source_content_type":"application/octet-stream","patch_set":23,"id":"5a5ae5dd_15aa29d5","line":64,"range":{"start_line":64,"start_character":62,"end_line":64,"end_character":67},"updated":"2016-02-03 11:51:11.000000000","message":"--prefix\u003d/usr","commit_id":"b0ec9adfedecdfea16200cdc97c6c7a574192525"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"75d47172e818414824c19d932a73dc8032f4b815","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    fi"},{"line_number":62,"context_line":"    if [ ! -f config.status ] || [ configure -nt config.status ] ; then"},{"line_number":63,"context_line":"        if [[ \"$build_modules\" \u003d\u003d \"True\" ]]; then"},{"line_number":64,"context_line":"            ./configure --with-linux\u003d/lib/modules/$(uname -r)/build"},{"line_number":65,"context_line":"        else"},{"line_number":66,"context_line":"            ./configure"},{"line_number":67,"context_line":"        fi"}],"source_content_type":"application/octet-stream","patch_set":23,"id":"5a5ae5dd_a482cefe","line":64,"range":{"start_line":64,"start_character":62,"end_line":64,"end_character":67},"in_reply_to":"5a5ae5dd_15aa29d5","updated":"2016-02-04 09:46:06.000000000","message":"Done","commit_id":"b0ec9adfedecdfea16200cdc97c6c7a574192525"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ea07c6b413aa9fc6ef938fe26d0a28a967205f5d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if [[ \"$build_modules\" \u003d\u003d \"True\" ]]; then"},{"line_number":64,"context_line":"            ./configure --with-linux\u003d/lib/modules/$(uname -r)/build"},{"line_number":65,"context_line":"        else"},{"line_number":66,"context_line":"            ./configure"},{"line_number":67,"context_line":"        fi"},{"line_number":68,"context_line":"    fi"},{"line_number":69,"context_line":"    make -j$[$(nproc) + 1]"}],"source_content_type":"application/octet-stream","patch_set":23,"id":"5a5ae5dd_b5af95e2","line":66,"updated":"2016-02-03 11:51:11.000000000","message":"--prefix\u003d/usr","commit_id":"b0ec9adfedecdfea16200cdc97c6c7a574192525"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"75d47172e818414824c19d932a73dc8032f4b815","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if [[ \"$build_modules\" \u003d\u003d \"True\" ]]; then"},{"line_number":64,"context_line":"            ./configure --with-linux\u003d/lib/modules/$(uname -r)/build"},{"line_number":65,"context_line":"        else"},{"line_number":66,"context_line":"            ./configure"},{"line_number":67,"context_line":"        fi"},{"line_number":68,"context_line":"    fi"},{"line_number":69,"context_line":"    make -j$[$(nproc) + 1]"}],"source_content_type":"application/octet-stream","patch_set":23,"id":"5a5ae5dd_647db61b","line":66,"in_reply_to":"5a5ae5dd_b5af95e2","updated":"2016-02-04 09:46:06.000000000","message":"Done","commit_id":"b0ec9adfedecdfea16200cdc97c6c7a574192525"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1c1d2a499aea9b2baba7aae01f3f12a8eb594a06","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# start_new_ovs() - removes old ovs database, creates a new one and starts ovs"},{"line_number":90,"context_line":"function start_new_ovs () {"},{"line_number":91,"context_line":"    rm -f /etc/openvswitch/conf.db /etc/openvswitch/.conf.db~lock~"},{"line_number":92,"context_line":"    sudo /usr/share/openvswitch/scripts/ovs-ctl start"},{"line_number":93,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"5a5ae5dd_f7594c5b","line":91,"range":{"start_line":91,"start_character":3,"end_line":91,"end_character":4},"updated":"2016-02-04 14:21:41.000000000","message":"Here should be sudo as well","commit_id":"00f731316204e63086fe58a911c88cb0ebe2ef7f"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"cf4b95f0f20402cf420cd937a817ef68f650d46e","unresolved":false,"context_lines":[{"line_number":89,"context_line":"# start_new_ovs() - removes old ovs database, creates a new one and starts ovs"},{"line_number":90,"context_line":"function start_new_ovs () {"},{"line_number":91,"context_line":"    rm -f /etc/openvswitch/conf.db /etc/openvswitch/.conf.db~lock~"},{"line_number":92,"context_line":"    sudo /usr/share/openvswitch/scripts/ovs-ctl start"},{"line_number":93,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"5a5ae5dd_1360b300","line":92,"updated":"2016-02-04 16:44:22.000000000","message":"I wasn\u0027t aware of this script... Neat.","commit_id":"00f731316204e63086fe58a911c88cb0ebe2ef7f"}],"neutron/tests/contrib/functional-testing.filters":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"2ea63500544c86ee7d6b3534bf53af7bb8ff686f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"touch_filter2: RegExpFilter, /usr/bin/touch, root, touch, /etc/netns/qdhcp-[0-9a-z./-]+/resolv.conf"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# When ovs is custom compiled, binaries have different locations"},{"line_number":39,"context_line":"kill_compiled_ovsdb_client: KillFilter, root, /usr/local/bin/ovsdb-client, -9"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"5a5ae5dd_f2b5237e","line":39,"range":{"start_line":39,"start_character":66,"end_line":39,"end_character":67},"updated":"2016-02-03 11:47:39.000000000","message":"you could do a --prefix\u003d/usr in the ./configure step to avoid that.","commit_id":"2070b742a0dd718169943fdd8967f0222dcd4adb"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ea07c6b413aa9fc6ef938fe26d0a28a967205f5d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"touch_filter2: RegExpFilter, /usr/bin/touch, root, touch, /etc/netns/qdhcp-[0-9a-z./-]+/resolv.conf"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# When ovs is custom compiled, binaries have different locations"},{"line_number":39,"context_line":"kill_compiled_ovsdb_client: KillFilter, root, /usr/local/bin/ovsdb-client, -9"}],"source_content_type":"application/octet-stream","patch_set":23,"id":"5a5ae5dd_955ff90d","line":39,"range":{"start_line":39,"start_character":51,"end_line":39,"end_character":56},"updated":"2016-02-03 11:51:11.000000000","message":"try using --prefix\u003d/usr on configure to avoid this extra rootwrap filter.","commit_id":"b0ec9adfedecdfea16200cdc97c6c7a574192525"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"75d47172e818414824c19d932a73dc8032f4b815","unresolved":false,"context_lines":[{"line_number":36,"context_line":"touch_filter2: RegExpFilter, /usr/bin/touch, root, touch, /etc/netns/qdhcp-[0-9a-z./-]+/resolv.conf"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# When ovs is custom compiled, binaries have different locations"},{"line_number":39,"context_line":"kill_compiled_ovsdb_client: KillFilter, root, /usr/local/bin/ovsdb-client, -9"}],"source_content_type":"application/octet-stream","patch_set":23,"id":"5a5ae5dd_c49caa5f","line":39,"range":{"start_line":39,"start_character":51,"end_line":39,"end_character":56},"in_reply_to":"5a5ae5dd_955ff90d","updated":"2016-02-04 09:46:06.000000000","message":"Done","commit_id":"b0ec9adfedecdfea16200cdc97c6c7a574192525"}],"neutron/tests/contrib/gate_hook.sh":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"00caef66a8f15d319eb8d6337625d6f1d0855224","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    PROJECT_NAME\u003dneutron"},{"line_number":17,"context_line":"    IS_GATE\u003dTrue"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    source $DEVSTACK_PATH/functions"},{"line_number":20,"context_line":"    source $NEUTRON_PATH/devstack/lib/ovs"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    source $NEUTRON_PATH/tools/configure_for_func_testing.sh"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-sh","patch_set":19,"id":"7a5de9d1_15d51bb8","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":41},"updated":"2016-01-28 13:58:31.000000000","message":"Maybe this could be moved to the block at L26","commit_id":"d0b28c8dbc7b43e2a52f033bc5b45bacb0fd78d5"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"11f11012af9de788920f492f192c159b77c459e0","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            fi"},{"line_number":33,"context_line":"        done"},{"line_number":34,"context_line":"        compile_ovs"},{"line_number":35,"context_line":"        sudo $DEST/$OVS_REPO_NAME/utilities/ovs-ctl start"},{"line_number":36,"context_line":"    fi"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # Make the workspace owned by the stack user"}],"source_content_type":"text/x-sh","patch_set":21,"id":"7a5de9d1_b4a23799","line":35,"updated":"2016-02-02 16:20:11.000000000","message":"It seems more appropriate to execute ovs-ctl from its installed location, but I suppose this has the same result","commit_id":"3e930425a3f1a6636e70ecd2bbde0524ec70a69e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f23705855807f2a087d40f8842757b8010f7200","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            fi"},{"line_number":33,"context_line":"        done"},{"line_number":34,"context_line":"        compile_ovs"},{"line_number":35,"context_line":"        sudo $DEST/$OVS_REPO_NAME/utilities/ovs-ctl start"},{"line_number":36,"context_line":"    fi"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # Make the workspace owned by the stack user"}],"source_content_type":"text/x-sh","patch_set":21,"id":"7a5de9d1_25bb6f77","line":35,"in_reply_to":"7a5de9d1_b4a23799","updated":"2016-02-02 17:13:44.000000000","message":"Done","commit_id":"3e930425a3f1a6636e70ecd2bbde0524ec70a69e"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"dfa79588f3387428fb29ae9447f03088c02f9e76","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                uninstall_package $package"},{"line_number":32,"context_line":"            fi"},{"line_number":33,"context_line":"        done"},{"line_number":34,"context_line":"        compile_ovs True /usr"},{"line_number":35,"context_line":"        start_new_ovs"},{"line_number":36,"context_line":"    fi"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-sh","patch_set":26,"id":"5a5ae5dd_51cb9072","line":34,"updated":"2016-02-04 13:41:50.000000000","message":"I personally don\u0027t recommend using --prefix\u003d/usr.  That path is generally reserved for installation of packages.  /usr/local/ is for custom stuff.  That makes it more clear that you\u0027re using a source build and also makes it a bit easier to clean up if needed.","commit_id":"00f731316204e63086fe58a911c88cb0ebe2ef7f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a12718af80ab168d4d122614815504cd62773c17","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                uninstall_package $package"},{"line_number":32,"context_line":"            fi"},{"line_number":33,"context_line":"        done"},{"line_number":34,"context_line":"        compile_ovs True /usr"},{"line_number":35,"context_line":"        start_new_ovs"},{"line_number":36,"context_line":"    fi"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-sh","patch_set":26,"id":"5a5ae5dd_54acdeec","line":34,"in_reply_to":"5a5ae5dd_51cb9072","updated":"2016-02-04 13:54:15.000000000","message":"Miguel suggested that and it also made some stuff easier - like not needing custom rootwrap filters and linking openvswitch logs for gate log collector. Given that this is going to be running on gate vm cattle, I guess it\u0027s ok to have it here. Miguel, what\u0027s your opinion?","commit_id":"00f731316204e63086fe58a911c88cb0ebe2ef7f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5016d5cc5e9c506b93ffd71173b46a8f07f9bbac","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                uninstall_package $package"},{"line_number":32,"context_line":"            fi"},{"line_number":33,"context_line":"        done"},{"line_number":34,"context_line":"        compile_ovs True /usr"},{"line_number":35,"context_line":"        start_new_ovs"},{"line_number":36,"context_line":"    fi"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-sh","patch_set":26,"id":"5a5ae5dd_66928859","line":34,"in_reply_to":"5a5ae5dd_54acdeec","updated":"2016-02-04 15:34:05.000000000","message":"Yeah, that was my reason, I\u0027m fine with either way, but I preferred the no need for special rootwrap filters.","commit_id":"00f731316204e63086fe58a911c88cb0ebe2ef7f"}]}
