)]}'
{"neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"0fe6639495d60d1e5333f8930b020ea51d249633","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                          {\u0027brq\u0027: bridge, \u0027net\u0027: physnet})"},{"line_number":101,"context_line":"                sys.exit(1)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def get_local_ip_device(self):"},{"line_number":104,"context_line":"        \"\"\"Return the device with local_ip on the host.\"\"\""},{"line_number":105,"context_line":"        device \u003d self.ip.get_device_by_ip(self.local_ip)"},{"line_number":106,"context_line":"        if not device:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_31edd825","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":27},"updated":"2016-01-12 21:48:24.000000000","message":"I don\u0027t see the added value of such change. IMO, we should transform this method into a staticmethod without removing local_ip argument as it simplifies tests","commit_id":"452f1b818337b85e4acff532d934907218183b7f"},{"author":{"_account_id":11255,"name":"Dustin Lundquist","username":"dustin.lundquist","inactive":true},"change_message_id":"a6eb3d9947a47ebdcdd5f1b875d9c1cb1b4ca57b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                          {\u0027brq\u0027: bridge, \u0027net\u0027: physnet})"},{"line_number":101,"context_line":"                sys.exit(1)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def get_local_ip_device(self):"},{"line_number":104,"context_line":"        \"\"\"Return the device with local_ip on the host.\"\"\""},{"line_number":105,"context_line":"        device \u003d self.ip.get_device_by_ip(self.local_ip)"},{"line_number":106,"context_line":"        if not device:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_b4fe9636","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":27},"in_reply_to":"da6ed579_31edd825","updated":"2016-01-12 22:27:15.000000000","message":"It can\u0027t be a static method since IP Wrapper is an instance attribute.","commit_id":"452f1b818337b85e4acff532d934907218183b7f"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"687fa1daabd57a7cbeadb7f2510c784c4af02fb4","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                          {\u0027brq\u0027: bridge, \u0027net\u0027: physnet})"},{"line_number":101,"context_line":"                sys.exit(1)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def get_local_ip_device(self):"},{"line_number":104,"context_line":"        \"\"\"Return the device with local_ip on the host.\"\"\""},{"line_number":105,"context_line":"        device \u003d self.ip.get_device_by_ip(self.local_ip)"},{"line_number":106,"context_line":"        if not device:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_f70c103d","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":27},"in_reply_to":"da6ed579_b4fe9636","updated":"2016-01-12 22:32:32.000000000","message":"I still don\u0027t see the added value of such change when i look at UT change","commit_id":"452f1b818337b85e4acff532d934907218183b7f"},{"author":{"_account_id":11255,"name":"Dustin Lundquist","username":"dustin.lundquist","inactive":true},"change_message_id":"9a1c0a7c7b9ad7ce2b31c9320cc215d19b50b524","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                          {\u0027brq\u0027: bridge, \u0027net\u0027: physnet})"},{"line_number":101,"context_line":"                sys.exit(1)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def get_local_ip_device(self):"},{"line_number":104,"context_line":"        \"\"\"Return the device with local_ip on the host.\"\"\""},{"line_number":105,"context_line":"        device \u003d self.ip.get_device_by_ip(self.local_ip)"},{"line_number":106,"context_line":"        if not device:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_1789a426","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":27},"in_reply_to":"da6ed579_f70c103d","updated":"2016-01-12 22:49:12.000000000","message":"I don\u0027t think we should abandon OOP practices for continence of unit tests, we have plenty to tools to modify behavior inside test environments.\n\nI agree this is low impact change, but noticed this and thought I would \"fix the broken window\".","commit_id":"452f1b818337b85e4acff532d934907218183b7f"}]}
