)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"0c2e35061e8fa6e5af935952cca2371118c6bf5a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix some fixed_ip error for floatingip test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Method prepare_router_data in l3_test_common.py can give us a router data"},{"line_number":10,"context_line":"object with a default floating IP with \u002710.0.0.1\u0027 as fixed_ip_address, but"},{"line_number":11,"context_line":"all the router\u0027s IPv4 cidrs are in style \u002735.4.x.0/24\u0027, method"},{"line_number":12,"context_line":"router_append_interface can tell that. So that doesn\u0027t make any sense."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch also fixes some other places using *wrong* fixed_ip in tests,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6ed579_e4474a49","line":11,"range":{"start_line":10,"start_character":71,"end_line":11,"end_character":54},"updated":"2016-01-13 17:04:36.000000000","message":"Can you give some references for this?  I don\u0027t know what this means.","commit_id":"8777e807d510cf2a40102cfb6b161955ad6fc338"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"0c2e35061e8fa6e5af935952cca2371118c6bf5a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Method prepare_router_data in l3_test_common.py can give us a router data"},{"line_number":10,"context_line":"object with a default floating IP with \u002710.0.0.1\u0027 as fixed_ip_address, but"},{"line_number":11,"context_line":"all the router\u0027s IPv4 cidrs are in style \u002735.4.x.0/24\u0027, method"},{"line_number":12,"context_line":"router_append_interface can tell that. So that doesn\u0027t make any sense."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch also fixes some other places using *wrong* fixed_ip in tests,"},{"line_number":15,"context_line":"but not all of them, that\u0027s too overkill and out of this patch scope."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6ed579_e48c2a81","line":12,"range":{"start_line":12,"start_character":24,"end_line":12,"end_character":37},"updated":"2016-01-13 17:04:36.000000000","message":"I\u0027m not sure what you mean by \"method router_append_interface can tell that.\"  Could you try to reword this to be clearer?  Maybe more references will help.","commit_id":"8777e807d510cf2a40102cfb6b161955ad6fc338"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"0c2e35061e8fa6e5af935952cca2371118c6bf5a","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch also fixes some other places using *wrong* fixed_ip in tests,"},{"line_number":15,"context_line":"but not all of them, that\u0027s too overkill and out of this patch scope."},{"line_number":16,"context_line":"This patch will only fixes tests related to bug 1462154."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Idb0403284363fcca8fa8f31bc9301729caaebf1d"},{"line_number":19,"context_line":"Partial-Bug: #1462154"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6ed579_a14e2494","line":16,"range":{"start_line":16,"start_character":21,"end_line":16,"end_character":26},"updated":"2016-01-13 17:04:36.000000000","message":"nit:  *fix","commit_id":"8777e807d510cf2a40102cfb6b161955ad6fc338"}],"neutron/tests/common/l3_test_common.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"30b2ba4b4ee14b3fc7c9498710db7695a7a981ee","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            \u0027port_id\u0027: _uuid(),"},{"line_number":110,"context_line":"            \u0027status\u0027: \u0027DOWN\u0027,"},{"line_number":111,"context_line":"            \u0027floating_ip_address\u0027: \u002719.4.4.2\u0027,"},{"line_number":112,"context_line":"            \u0027fixed_ip_address\u0027: \u002735.4.0.3\u0027}]"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    router_append_interface(router, count\u003dnum_internal_ports,"},{"line_number":115,"context_line":"                            ip_version\u003dip_version, dual_stack\u003ddual_stack)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_19e6a5b4","line":112,"range":{"start_line":112,"start_character":33,"end_line":112,"end_character":41},"updated":"2016-01-13 09:05:35.000000000","message":"It is not obvious for the reader why it should be 35.4.0.3 here. Consider a comment or better some global IPNetwork to consume addresses for such cases.","commit_id":"8777e807d510cf2a40102cfb6b161955ad6fc338"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"21b210c286b012647268e1c41ed363a67efbce96","unresolved":false,"context_lines":[{"line_number":251,"context_line":"def get_floatingip_addr_pair_list(router, count\u003d1, intf\u003d0):"},{"line_number":252,"context_line":"    \"\"\"Return list of (fixed_ip_address, floating_ip_address) pair"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    @param count: Number of floatingip addresses paris to return."},{"line_number":255,"context_line":"    @param intf: Index of router interfaces."},{"line_number":256,"context_line":"    \"\"\""},{"line_number":257,"context_line":"    ret \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_5053f916","line":254,"range":{"start_line":254,"start_character":39,"end_line":254,"end_character":54},"updated":"2016-01-15 14:29:01.000000000","message":"Nit: s/addresses paris/address pairs","commit_id":"4a8930e7916f249cada06f37f2e7a98fef2997f5"}]}
