)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"bd7b7c5acb2b7f8febaa6f17162260c468112ac9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"l2-agent-extensions-agent-api"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- adds consume_api method to the AgentCoreResourceExtension class."},{"line_number":10,"context_line":"- modifies the AgentExtensionManager class to accept the AgentExtensionAPI"},{"line_number":11,"context_line":"  class as an optional arguement."},{"line_number":12,"context_line":"- adds the OVSAgentExtensionAPI class."},{"line_number":13,"context_line":"- modifies ovs_lib and ofswitch to include a list of uuid stamps"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a68dd71_f37d526d","line":10,"range":{"start_line":10,"start_character":15,"end_line":10,"end_character":36},"updated":"2016-01-25 21:43:55.000000000","message":"AgentExtensionsManager","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"bd7b7c5acb2b7f8febaa6f17162260c468112ac9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"l2-agent-extensions-agent-api"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- adds consume_api method to the AgentCoreResourceExtension class."},{"line_number":10,"context_line":"- modifies the AgentExtensionManager class to accept the AgentExtensionAPI"},{"line_number":11,"context_line":"  class as an optional arguement."},{"line_number":12,"context_line":"- adds the OVSAgentExtensionAPI class."},{"line_number":13,"context_line":"- modifies ovs_lib and ofswitch to include a list of uuid stamps"},{"line_number":14,"context_line":"  to exempt from flow deletion."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a68dd71_b6ad88ea","line":11,"range":{"start_line":10,"start_character":53,"end_line":11,"end_character":7},"updated":"2016-01-25 21:43:55.000000000","message":"Suggest: \"... an AgentExtensionAPI instance ...\"","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- adds consume_api method to the AgentCoreResourceExtension class."},{"line_number":10,"context_line":"- modifies the AgentExtensionManager class to accept the AgentExtensionAPI"},{"line_number":11,"context_line":"  class as an optional arguement."},{"line_number":12,"context_line":"- adds the OVSAgentExtensionAPI class."},{"line_number":13,"context_line":"- modifies ovs_lib and ofswitch to include a list of uuid stamps"},{"line_number":14,"context_line":"  to exempt from flow deletion."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a68dd71_f90c353d","line":11,"range":{"start_line":11,"start_character":23,"end_line":11,"end_character":32},"updated":"2016-01-26 13:08:41.000000000","message":"argument","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"bd7b7c5acb2b7f8febaa6f17162260c468112ac9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- modifies the AgentExtensionManager class to accept the AgentExtensionAPI"},{"line_number":11,"context_line":"  class as an optional arguement."},{"line_number":12,"context_line":"- adds the OVSAgentExtensionAPI class."},{"line_number":13,"context_line":"- modifies ovs_lib and ofswitch to include a list of uuid stamps"},{"line_number":14,"context_line":"  to exempt from flow deletion."},{"line_number":15,"context_line":"- modifies OVSNeutronAgent to initialize OVSAgentExtensionAPI and pass"},{"line_number":16,"context_line":"  into the AgentExtensionManager."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a68dd71_56bd2c00","line":13,"range":{"start_line":13,"start_character":35,"end_line":13,"end_character":53},"updated":"2016-01-25 21:43:55.000000000","message":"I think ovs_lib and ofswitch are doing different sorts of things with the set of uuid stamps.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"fdff2c00b5f5a50f527c4c49473d97892a6d6415","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- adds consume_api method to the AgentCoreResourceExtension class."},{"line_number":10,"context_line":"- modifies the AgentExtensionManager class to accept the AgentExtensionAPI"},{"line_number":11,"context_line":"  class as an optional arguement."},{"line_number":12,"context_line":"- adds the OVSAgentExtensionAPI class."},{"line_number":13,"context_line":"- modifies ovs_lib and ofswitch to include a list of uuid stamps"},{"line_number":14,"context_line":"  to exempt from flow deletion."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"5a5ae5dd_35ffeaab","line":11,"updated":"2016-02-04 10:59:34.000000000","message":"arguement -\u003e argument","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"c2862de3973d26329a307601db9e47c2d12ea190","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- adds consume_api method to the AgentCoreResourceExtension class."},{"line_number":10,"context_line":"- modifies the AgentExtensionManager class to accept the AgentExtensionAPI"},{"line_number":11,"context_line":"  class as an optional arguement."},{"line_number":12,"context_line":"- adds the OVSAgentExtensionAPI class."},{"line_number":13,"context_line":"- modifies ovs_lib and ofswitch to include a list of uuid stamps"},{"line_number":14,"context_line":"  to exempt from flow deletion."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"5a5ae5dd_29e8ea0f","line":11,"in_reply_to":"5a5ae5dd_35ffeaab","updated":"2016-02-04 15:10:59.000000000","message":"I was sure I fixed that already... Done","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2bf0d0d8f3bf3d19dab330ca81b38ece618daaca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nate Johnston \u003cnate_johnston@cable.comcast.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-09 17:43:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"l2-agent-extensions-agent-api"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- adds consume_api method to the AgentCoreResourceExtension class."},{"line_number":10,"context_line":"- modifies the AgentExtensionManager class to accept the AgentExtensionAPI"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"3a57f1b5_e1dc1d14","line":7,"updated":"2016-02-11 12:03:01.000000000","message":"Please also let\u0027s change the commit message in several ways:\n\n1. the title should be in English.\n2. You may mention the blueprint in line 20: Implements: blueprint ...\n3. Describe the intent of the change, not just technical details how you achieve it.","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Shaughnessy \u003cdavid.shaughnessy@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-12 11:14:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"l2 agent extensions-agent api"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Introduces an API to allow l2-agents to access resources within"},{"line_number":10,"context_line":"  the OvSNeutronAgent, specifically the integration and tunnel bridges."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"3a57f1b5_f97fad14","line":7,"updated":"2016-02-12 15:13:31.000000000","message":"This is still not a proper English.\n\nLet\u0027s have it like: \u0027Added agent specific API support to L2 extensions\u0027","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"64237c9f61c963e5b1d1db4b892560277c68300e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Shaughnessy \u003cdavid.shaughnessy@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-12 11:14:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"l2 agent extensions-agent api"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Introduces an API to allow l2-agents to access resources within"},{"line_number":10,"context_line":"  the OvSNeutronAgent, specifically the integration and tunnel bridges."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"3a57f1b5_b1d06920","line":7,"in_reply_to":"3a57f1b5_f97fad14","updated":"2016-02-15 14:09:08.000000000","message":"Done","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"l2 agent extensions-agent api"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Introduces an API to allow l2-agents to access resources within"},{"line_number":10,"context_line":"  the OvSNeutronAgent, specifically the integration and tunnel bridges."},{"line_number":11,"context_line":"- adds consume_api method to the AgentCoreResourceExtension class."},{"line_number":12,"context_line":"- modifies the AgentExtensionManager class to accept the AgentExtensionAPI"},{"line_number":13,"context_line":"  class as an optional argument."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"3a57f1b5_79abbd75","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":21},"updated":"2016-02-12 15:13:31.000000000","message":"It suggests there is such a class. Replace: \u0027Open vSwitch agent\u0027.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"64237c9f61c963e5b1d1db4b892560277c68300e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"l2 agent extensions-agent api"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Introduces an API to allow l2-agents to access resources within"},{"line_number":10,"context_line":"  the OvSNeutronAgent, specifically the integration and tunnel bridges."},{"line_number":11,"context_line":"- adds consume_api method to the AgentCoreResourceExtension class."},{"line_number":12,"context_line":"- modifies the AgentExtensionManager class to accept the AgentExtensionAPI"},{"line_number":13,"context_line":"  class as an optional argument."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"3a57f1b5_d1cde585","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":21},"in_reply_to":"3a57f1b5_79abbd75","updated":"2016-02-15 14:09:08.000000000","message":"Done","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_ext_uuid_stamps(self, vals):"},{"line_number":187,"context_line":"        self.ext_uuid_stamps \u003d vals"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def set_controller(self, controllers):"},{"line_number":190,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_c21c0d6c","line":187,"updated":"2016-01-15 10:30:39.000000000","message":"I think instead of adding this method specifically for extensions, we should have some method that appends a stamp value to a list of known stamps, and make set_agent_uuid_stamp() to rely on it. The set_agent_uuid_stamp may also be marked for deprecation and removed in N.\n\nIt would also make sense to have a method to determine whether a stamp is \u0027known\u0027.\n\nFinally, for debug purposes, would it make sense to allow to maintain an extension-to-stamp map, and maybe log that in debug mode? That would help to read tables later.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"79a613b05e4ea62a72302cee202a9a3c7fa7f256","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_ext_uuid_stamps(self, vals):"},{"line_number":187,"context_line":"        self.ext_uuid_stamps \u003d vals"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def set_controller(self, controllers):"},{"line_number":190,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_5777789f","line":187,"in_reply_to":"da6ed579_0cafb37d","updated":"2016-01-15 12:02:27.000000000","message":"Not in the context of what you\u0027re proposing.\n\nUntil now it was though, the qos_driver uses one for bandwidth limiting, it just wasn\u0027t assigned a uuid because it didn\u0027t need flows. \n\nIn a more recent patch I\u0027m working on for dscp I was using the assigned ext_uuid as a agent_uuid for that object to create flows.\nBut I\u0027d much rather use you\u0027re method (pass the bridge into the API and use that) than the one I\u0027m currently working on.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"07b59ef34c4325b9193d99336d9ca10ffa2a8d4e","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_ext_uuid_stamps(self, vals):"},{"line_number":187,"context_line":"        self.ext_uuid_stamps \u003d vals"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def set_controller(self, controllers):"},{"line_number":190,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_0cafb37d","line":187,"in_reply_to":"da6ed579_31f534ec","updated":"2016-01-15 11:52:55.000000000","message":"Is there a real need to have multiple bridge objects for the same bridge?","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"ca6155c92dc83c6aca3234072511acb77bf7230b","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_ext_uuid_stamps(self, vals):"},{"line_number":187,"context_line":"        self.ext_uuid_stamps \u003d vals"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def set_controller(self, controllers):"},{"line_number":190,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_f7878cb2","line":187,"in_reply_to":"da6ed579_5761b8a7","updated":"2016-01-15 12:16:50.000000000","message":"Sure.\n\nDo you have example code/documentation for versioning an object I could reference, it\u0027s for swift containers correct?","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5b33a62d03a555816db92cf2dd08a7c6b871579a","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_ext_uuid_stamps(self, vals):"},{"line_number":187,"context_line":"        self.ext_uuid_stamps \u003d vals"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def set_controller(self, controllers):"},{"line_number":190,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_5761b8a7","line":187,"in_reply_to":"da6ed579_5777789f","updated":"2016-01-15 12:07:06.000000000","message":"Then let\u0027s pass the bridge, as a first class citizen in agent API, versioned and all?","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c7588ab5c0a11ebf3e8d31b4134cc747d6a21cd2","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_ext_uuid_stamps(self, vals):"},{"line_number":187,"context_line":"        self.ext_uuid_stamps \u003d vals"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def set_controller(self, controllers):"},{"line_number":190,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_a37b1abd","line":187,"in_reply_to":"da6ed579_8057ec24","updated":"2016-01-15 11:06:33.000000000","message":"Ah right, it\u0027s the default value. Well, it could also be generated by the class on its first usage, and appended to the list. But agreed that it should be tracked separately (but if you go with the entity-to-stamp map, you could have something like \u0027_default\u0027 key for the default value.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"51d4a2289b42b19babab915be7c338f870302b52","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_ext_uuid_stamps(self, vals):"},{"line_number":187,"context_line":"        self.ext_uuid_stamps \u003d vals"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def set_controller(self, controllers):"},{"line_number":190,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_31f534ec","line":187,"in_reply_to":"da6ed579_a37b1abd","updated":"2016-01-15 11:49:49.000000000","message":"I Think it should be manually assigned, otherwise if an extension is using a class derived from this class to generate flows it means you wouldn\u0027t be able to sync the flows of both classes [which isn\u0027t an issue anyway if the aim is to manage all flow creation in the future from the API].\n\nI understand you\u0027re saying add the bridge object to the API class and have it manage access to flows, but I think that could cause problems given how the class has functioned until now [To clarify no problem with adding the bridge to the API-object, just about that bridge assigning uuids].\n\nApologies for the comments contradicted by the brackets just puzzling it out.\n\nJust to clarify, you want to scrap  agent_uuid_stamp/ext_uuid_stamps that are assigned by the OVSNeutronAgent and change them to a list of all stamps, with a _default (agent) stamp that are generated by the bridge object and assigned to the OVSNeutronAgent and where all uuids following that are added to a list when they are requested. Am I following you right?","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"1d8e541ccca3bce2dfd82d2551f13d6149b1c49e","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_ext_uuid_stamps(self, vals):"},{"line_number":187,"context_line":"        self.ext_uuid_stamps \u003d vals"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def set_controller(self, controllers):"},{"line_number":190,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_2915c49a","line":187,"in_reply_to":"da6ed579_b24842b4","updated":"2016-01-15 13:10:41.000000000","message":"My mistake. Thanks!","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"7d51eb58c2933324c888c4569646e8ce4de48386","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_ext_uuid_stamps(self, vals):"},{"line_number":187,"context_line":"        self.ext_uuid_stamps \u003d vals"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def set_controller(self, controllers):"},{"line_number":190,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_8057ec24","line":187,"in_reply_to":"da6ed579_c21c0d6c","updated":"2016-01-15 11:04:01.000000000","message":"I wanted to keep the agent ID separate from the extension IDs. If you look through the rest of this class and the openflow classes mixed into it, they use the agent ID for flow creation and management. The extension IDs are only used to stop extension flows being deleted.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a55b4c1013f21e6a20f55229ce0c020ee761f682","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_ext_uuid_stamps(self, vals):"},{"line_number":187,"context_line":"        self.ext_uuid_stamps \u003d vals"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def set_controller(self, controllers):"},{"line_number":190,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_b24842b4","line":187,"in_reply_to":"da6ed579_f7878cb2","updated":"2016-01-15 12:33:11.000000000","message":"Swift containers?.. I don\u0027t follow.\n\nExamples of versioned objects in neutron are yet in qos only. F.e. https://github.com/openstack/neutron/blob/master/neutron/objects/qos/policy.py#L28","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self.agent_uuid_stamp \u003d 0"},{"line_number":183,"context_line":"        self.agent_stamps \u003d []"},{"line_number":184,"context_line":"        self.uuid_to_agent \u003d {}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_6a095731","line":183,"updated":"2016-01-20 12:49:29.000000000","message":"let\u0027s avoid the \u0027agent\u0027 notion. Let\u0027s have something more generic, like \u0027self.used_stamps\u0027.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c44dfbb1b3fb97cd48b57ed6fc0adf38d33ac638","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self.agent_uuid_stamp \u003d 0"},{"line_number":183,"context_line":"        self.agent_stamps \u003d []"},{"line_number":184,"context_line":"        self.uuid_to_agent \u003d {}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_1c181784","line":183,"in_reply_to":"9a68dd71_2134e2dc","updated":"2016-01-20 16:28:22.000000000","message":"Yes, you could. Though if you don\u0027t cache, you don\u0027t need the map, just a list.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self.agent_uuid_stamp \u003d 0"},{"line_number":183,"context_line":"        self.agent_stamps \u003d []"},{"line_number":184,"context_line":"        self.uuid_to_agent \u003d {}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_2134e2dc","line":183,"in_reply_to":"9a68dd71_6a095731","updated":"2016-01-20 15:44:40.000000000","message":"I could remove this list entirely and use the keys from uuid_to_agent?","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.agent_stamps \u003d []"},{"line_number":184,"context_line":"        self.uuid_to_agent \u003d {}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":188,"context_line":"        self.agent_stamps.append(val)"},{"line_number":189,"context_line":"        self.uuid_to_agent[val] \u003d \u0027OVSNeutronAgent\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_6dcbb173","line":186,"updated":"2016-01-20 12:49:29.000000000","message":"I don\u0027t believe there is a use case to set specific value for the stamp, as long as we set SOME value. We may want to deprecate the method.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"0785565c2575e054c47097c86df9c4eb60d0fede","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.agent_stamps \u003d []"},{"line_number":184,"context_line":"        self.uuid_to_agent \u003d {}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":188,"context_line":"        self.agent_stamps.append(val)"},{"line_number":189,"context_line":"        self.uuid_to_agent[val] \u003d \u0027OVSNeutronAgent\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_e2a47e09","line":186,"in_reply_to":"9a68dd71_5f1d2165","updated":"2016-01-20 17:08:36.000000000","message":"Consistency, you would only need to track one cookie across the 2 bridges to know which flows belong to the agent. There is a third bridge object created in the OVSNeutronAgent but I haven\u0027t seen it use the set_agent_uuid_stamp call so I don\u0027t think it would need a cookie track for it.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.agent_stamps \u003d []"},{"line_number":184,"context_line":"        self.uuid_to_agent \u003d {}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":188,"context_line":"        self.agent_stamps.append(val)"},{"line_number":189,"context_line":"        self.uuid_to_agent[val] \u003d \u0027OVSNeutronAgent\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_967b927b","line":186,"in_reply_to":"9a68dd71_6dcbb173","updated":"2016-01-20 15:44:40.000000000","message":"The reason for adding it back in after Patch Set 4 was because br_tun uses this method to have the same stamp as int_br, I only added it back in for that reason.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c44dfbb1b3fb97cd48b57ed6fc0adf38d33ac638","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.agent_stamps \u003d []"},{"line_number":184,"context_line":"        self.uuid_to_agent \u003d {}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":188,"context_line":"        self.agent_stamps.append(val)"},{"line_number":189,"context_line":"        self.uuid_to_agent[val] \u003d \u0027OVSNeutronAgent\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_5f1d2165","line":186,"in_reply_to":"9a68dd71_967b927b","updated":"2016-01-20 16:28:22.000000000","message":"Can you elaborate why we are interested in exact same value for those two bridges?","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"106d5c32e6f3c1fad6e1d44d062eaa8eb65e3450","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.agent_stamps \u003d []"},{"line_number":184,"context_line":"        self.uuid_to_agent \u003d {}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":188,"context_line":"        self.agent_stamps.append(val)"},{"line_number":189,"context_line":"        self.uuid_to_agent[val] \u003d \u0027OVSNeutronAgent\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_41d9a3f2","line":186,"in_reply_to":"9a68dd71_e2a47e09","updated":"2016-01-21 09:25:49.000000000","message":"But then there is still no consistency if an extension will need flows for both bridges, and it gets different cookies for each.\n\nI think in this regard agent should not be different from other entities requesting flow cookies. If we lack debug information to correlate the flows to agent, fine, let\u0027s add some log messages in the agent itself to spill the cookies after requesting them. But making it part of bridge API seems unneeded.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        self.agent_stamps.append(val)"},{"line_number":189,"context_line":"        self.uuid_to_agent[val] \u003d \u0027OVSNeutronAgent\u0027"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def request_agent_uuid_stamp(self, agent_name):"},{"line_number":192,"context_line":"        if agent_name not in self.uuid_to_agent.values():"},{"line_number":193,"context_line":"            uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":194,"context_line":"            if self.agent_uuid_stamp \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_6a74f7ce","line":191,"updated":"2016-01-20 12:49:29.000000000","message":"why do we use *agent name* to distinguish entities interested in stamps (not just agents, but e.g. extensions)? I think it should be reasonable to expect that an entity calls the method once, or that at least it stores the stamp values somewhere. With that in mind, I am not sure there is huge value in caching the values as you do it here. I would go with simpler approach: return a new unoccupied value on each call.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"106d5c32e6f3c1fad6e1d44d062eaa8eb65e3450","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        self.agent_stamps.append(val)"},{"line_number":189,"context_line":"        self.uuid_to_agent[val] \u003d \u0027OVSNeutronAgent\u0027"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def request_agent_uuid_stamp(self, agent_name):"},{"line_number":192,"context_line":"        if agent_name not in self.uuid_to_agent.values():"},{"line_number":193,"context_line":"            uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":194,"context_line":"            if self.agent_uuid_stamp \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_c19a7314","line":191,"in_reply_to":"9a68dd71_02b0b2f3","updated":"2016-01-21 09:25:49.000000000","message":"For logging purposes, I think it\u0027s fine to log requested cookies in agent API object. That should be enough to correlate flows to extensions (assuming we have a way to extract extension names from extension objects).","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        self.agent_stamps.append(val)"},{"line_number":189,"context_line":"        self.uuid_to_agent[val] \u003d \u0027OVSNeutronAgent\u0027"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def request_agent_uuid_stamp(self, agent_name):"},{"line_number":192,"context_line":"        if agent_name not in self.uuid_to_agent.values():"},{"line_number":193,"context_line":"            uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":194,"context_line":"            if self.agent_uuid_stamp \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_c1162655","line":191,"in_reply_to":"9a68dd71_6a74f7ce","updated":"2016-01-20 15:44:40.000000000","message":"It\u0027s used in the debug log to show what extensions are using stamps to filter flows.\nIt\u0027s mostly a counter measure to make sure there isn\u0027t an extension requesting new stamps every time it wants to create a flow.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c44dfbb1b3fb97cd48b57ed6fc0adf38d33ac638","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        self.agent_stamps.append(val)"},{"line_number":189,"context_line":"        self.uuid_to_agent[val] \u003d \u0027OVSNeutronAgent\u0027"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def request_agent_uuid_stamp(self, agent_name):"},{"line_number":192,"context_line":"        if agent_name not in self.uuid_to_agent.values():"},{"line_number":193,"context_line":"            uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":194,"context_line":"            if self.agent_uuid_stamp \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_df56f105","line":191,"in_reply_to":"9a68dd71_c1162655","updated":"2016-01-20 16:28:22.000000000","message":"Shouldn\u0027t we allow the extension to shoot in its own foot?","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"0785565c2575e054c47097c86df9c4eb60d0fede","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        self.agent_stamps.append(val)"},{"line_number":189,"context_line":"        self.uuid_to_agent[val] \u003d \u0027OVSNeutronAgent\u0027"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def request_agent_uuid_stamp(self, agent_name):"},{"line_number":192,"context_line":"        if agent_name not in self.uuid_to_agent.values():"},{"line_number":193,"context_line":"            uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":194,"context_line":"            if self.agent_uuid_stamp \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_02b0b2f3","line":191,"in_reply_to":"9a68dd71_df56f105","updated":"2016-01-20 17:08:36.000000000","message":"It could also be done intentionally, if sfc wanted to get unique cookies for each chain or if QoS wanted unique cookies for QoS policies. I\u0027ll remove it but the debug info in ofswitch.py won\u0027t have names for the cookie stamps its using.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    def request_agent_uuid_stamp(self, agent_name):"},{"line_number":192,"context_line":"        if agent_name not in self.uuid_to_agent.values():"},{"line_number":193,"context_line":"            uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":194,"context_line":"            if self.agent_uuid_stamp \u003d\u003d 0:"},{"line_number":195,"context_line":"                self.agent_uuid_stamp \u003d uuid_stamp"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"            self.agent_stamps.append(uuid_stamp)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_2a559f1c","line":194,"updated":"2016-01-20 12:49:29.000000000","message":"I think we could generate the value in __init__ already, in line 182.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                    uuid_stamp \u003d agt_uuid"},{"line_number":203,"context_line":"        return uuid_stamp"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def query_agent_stamps(self, uuid_stamp):"},{"line_number":206,"context_line":"        if uuid_stamp in self.uuid_to_agent:"},{"line_number":207,"context_line":"            return self.uuid_to_agent[uuid_stamp]"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_2db6193e","line":205,"updated":"2016-01-20 12:49:29.000000000","message":"Not sure I follow the meaning of the method. Can you elaborate what it\u0027s used for?","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                    uuid_stamp \u003d agt_uuid"},{"line_number":203,"context_line":"        return uuid_stamp"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def query_agent_stamps(self, uuid_stamp):"},{"line_number":206,"context_line":"        if uuid_stamp in self.uuid_to_agent:"},{"line_number":207,"context_line":"            return self.uuid_to_agent[uuid_stamp]"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_f608ce93","line":205,"in_reply_to":"9a68dd71_2db6193e","updated":"2016-01-20 15:44:40.000000000","message":"I intended to remove the list of stamps from the OVSAgentAPI and use this method to know which agent is trying to make a flow.\nThe idea was in later iterations where flow management was used to decide how to handle flow submissions if the string contained something along the lines of \"Security\" or \"Firewall\" those could be given a higher priority.\nIn this iteration, it was just going to be used to check the stamp is stored here.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"106d5c32e6f3c1fad6e1d44d062eaa8eb65e3450","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                    uuid_stamp \u003d agt_uuid"},{"line_number":203,"context_line":"        return uuid_stamp"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def query_agent_stamps(self, uuid_stamp):"},{"line_number":206,"context_line":"        if uuid_stamp in self.uuid_to_agent:"},{"line_number":207,"context_line":"            return self.uuid_to_agent[uuid_stamp]"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_e181b790","line":205,"in_reply_to":"9a68dd71_f608ce93","updated":"2016-01-21 09:25:49.000000000","message":"I don\u0027t see a use case to validate a cookie is registered (because the assumption should be that cookies used are extracted using request_agent_uuid_stamp).\n\nI also don\u0027t think that flow priorities should be defined by random string contents. Let\u0027s push back the change and consider it once we get into flow table rework phase.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                               if \u0027NXST\u0027 not in item)"},{"line_number":335,"context_line":"        return retval"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def dump_flows(self, **kwargs):"},{"line_number":338,"context_line":"        retval \u003d None"},{"line_number":339,"context_line":"        flow_str \u003d \"\""},{"line_number":340,"context_line":"        for key in kwargs:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_cd365db4","line":337,"updated":"2016-01-20 12:49:29.000000000","message":"Why do we need that? Also, I see you copy-pasted some code from dump_flows_for_table here. Please instead reuse the code.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c44dfbb1b3fb97cd48b57ed6fc0adf38d33ac638","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                               if \u0027NXST\u0027 not in item)"},{"line_number":335,"context_line":"        return retval"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def dump_flows(self, **kwargs):"},{"line_number":338,"context_line":"        retval \u003d None"},{"line_number":339,"context_line":"        flow_str \u003d \"\""},{"line_number":340,"context_line":"        for key in kwargs:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_df6d91cd","line":337,"in_reply_to":"9a68dd71_56251ac0","updated":"2016-01-20 16:28:22.000000000","message":"But why do extensions need to dump all flows?","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                               if \u0027NXST\u0027 not in item)"},{"line_number":335,"context_line":"        return retval"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def dump_flows(self, **kwargs):"},{"line_number":338,"context_line":"        retval \u003d None"},{"line_number":339,"context_line":"        flow_str \u003d \"\""},{"line_number":340,"context_line":"        for key in kwargs:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_56251ac0","line":337,"in_reply_to":"9a68dd71_cd365db4","updated":"2016-01-20 15:44:40.000000000","message":"Dump_table does not allow you to filter based on your own criteria, this works similar to mod-flows and del-flows where you can Query for all flows with a cookie (not limited to a table by table search and filtering through the strings after) if you needed.\n\nIt saves extensions needing to make multiple requests to check all tables and it removes the need for a filter to be done to sort the relevant information.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"0785565c2575e054c47097c86df9c4eb60d0fede","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                               if \u0027NXST\u0027 not in item)"},{"line_number":335,"context_line":"        return retval"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def dump_flows(self, **kwargs):"},{"line_number":338,"context_line":"        retval \u003d None"},{"line_number":339,"context_line":"        flow_str \u003d \"\""},{"line_number":340,"context_line":"        for key in kwargs:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_cdc96bae","line":337,"in_reply_to":"9a68dd71_df6d91cd","updated":"2016-01-20 17:08:36.000000000","message":"Not all of them, with cookie being a requirement in the OVSAgentAPI class it means that the extensions will only be able to see all their own flows.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"437a6d3e2b3b3b463748741999246fdd57b5bbd9","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        return uuid_stamp"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def get_uuid_stamp_list(self):"},{"line_number":197,"context_line":"        if (self.agent_uuid_stamp !\u003d 0 and"},{"line_number":198,"context_line":"            self.agent_uuid_stamp not in self.uuid_stamps):"},{"line_number":199,"context_line":"            self.uuid_stamps.append(self.agent_uuid_stamp)"},{"line_number":200,"context_line":"        return self.uuid_stamps"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def set_controller(self, controllers):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_906ee8c7","line":199,"range":{"start_line":197,"start_character":8,"end_line":199,"end_character":58},"updated":"2016-01-21 16:57:59.000000000","message":"This is just to make sure that it can work until set_agent_uuid_stamp() is actually removed","commit_id":"5cbb0101bbd98078190978396fe03c5ea3d4e3ad"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        super(OVSBridge, self).__init__()"},{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self.agent_uuid_stamp \u003d 0"},{"line_number":183,"context_line":"        self.uuid_stamps \u003d []"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def set_agent_uuid_stamp(self, val):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_5fa9a123","line":182,"updated":"2016-01-26 13:08:41.000000000","message":"I wonder why we don\u0027t just generate the default cookie value here. Do you know why?","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8c497646b7e2c0896a59f29179e24645d9634833","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        super(OVSBridge, self).__init__()"},{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self.agent_uuid_stamp \u003d 0"},{"line_number":183,"context_line":"        self.uuid_stamps \u003d []"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def set_agent_uuid_stamp(self, val):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_a20be62a","line":182,"in_reply_to":"9a68dd71_5fa9a123","updated":"2016-01-26 15:19:00.000000000","message":"there wouldn\u0027t be a way to retrieve it and send it to the OVSAgentAPI.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"39457844d439d195dc2f63b7037027eebb01a8ed","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        super(OVSBridge, self).__init__()"},{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self.agent_uuid_stamp \u003d 0"},{"line_number":183,"context_line":"        self.uuid_stamps \u003d []"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def set_agent_uuid_stamp(self, val):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_b5f7aaf4","line":182,"in_reply_to":"9a68dd71_a20be62a","updated":"2016-01-27 11:24:13.000000000","message":"Yeah, but it could be just appended to uuid_stamps below?","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self.agent_uuid_stamp \u003d 0"},{"line_number":183,"context_line":"        self.uuid_stamps \u003d []"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":186,"context_line":"        self.agent_uuid_stamp \u003d val"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_9971797a","line":183,"updated":"2016-01-26 13:08:41.000000000","message":"From its name, it\u0027s not clear which stamps those are. Should we maybe have something like \u0027self.reserved_stamps\u0027 or even \u0027self.reserved_cookies\u0027. Also, it could be a set, to avoid duplications.\n\nI would actually retire \u0027stamp\u0027 term from everywhere and replace it with \u0027cookie\u0027. Would it make more sense?","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8c497646b7e2c0896a59f29179e24645d9634833","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self.agent_uuid_stamp \u003d 0"},{"line_number":183,"context_line":"        self.uuid_stamps \u003d []"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":186,"context_line":"        self.agent_uuid_stamp \u003d val"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_ad6437e5","line":183,"in_reply_to":"9a68dd71_9971797a","updated":"2016-01-26 15:19:00.000000000","message":"It would make more sense, I\u0027ll need to change it in all the methods and tests as well.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        self.agent_uuid_stamp \u003d 0"},{"line_number":183,"context_line":"        self.uuid_stamps \u003d []"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":186,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def request_agent_uuid_stamp(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_b9ca3d6d","line":185,"updated":"2016-01-26 13:08:41.000000000","message":"I suggest we deprecate the method.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.uuid_stamps \u003d []"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":186,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def request_agent_uuid_stamp(self):"},{"line_number":189,"context_line":"        uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_39a5edb4","line":186,"updated":"2016-01-26 13:08:41.000000000","message":"why not just adding to the reserved list (or set) right away?","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8c497646b7e2c0896a59f29179e24645d9634833","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.uuid_stamps \u003d []"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":186,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def request_agent_uuid_stamp(self):"},{"line_number":189,"context_line":"        uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_add99785","line":186,"in_reply_to":"9a68dd71_39a5edb4","updated":"2016-01-26 15:19:00.000000000","message":"The agent_uuid_stamp is used in the rest of bridge/mixin classes as a default value.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"39457844d439d195dc2f63b7037027eebb01a8ed","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.uuid_stamps \u003d []"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":186,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def request_agent_uuid_stamp(self):"},{"line_number":189,"context_line":"        uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_f530c2a0","line":186,"in_reply_to":"9a68dd71_add99785","updated":"2016-01-27 11:24:13.000000000","message":"That\u0027s fair. Then how about leaving the attribute, but renaming it so that it\u0027s private and so that it reflects its goal (f.e. some like self.default_cookie), and also have a method to retrieve the default value (and make the mixins to use that method instead of the attribute directly)?","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":186,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def request_agent_uuid_stamp(self):"},{"line_number":189,"context_line":"        uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":190,"context_line":"        if self.agent_uuid_stamp \u003d\u003d 0:"},{"line_number":191,"context_line":"            self.agent_uuid_stamp \u003d uuid_stamp"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_d98131c5","line":188,"updated":"2016-01-26 13:08:41.000000000","message":"I am not sure what this method is designed to do. It seems to update \u0027agent\u0027 stamp sometimes, depending on whether it was called before. Which does not make much sense to me from API perspective. \n\nShould this instead be a method that\n1) generates an *unreserved* value,\n2) appends it to the list of reserved stamps,\n3) returns it to the caller.\n\nWould it make API more clear?","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def request_agent_uuid_stamp(self):"},{"line_number":189,"context_line":"        uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":190,"context_line":"        if self.agent_uuid_stamp \u003d\u003d 0:"},{"line_number":191,"context_line":"            self.agent_uuid_stamp \u003d uuid_stamp"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_d9e611b0","line":189,"updated":"2016-01-26 13:08:41.000000000","message":"To stay on safe side, you may want to validate that generated value is not already reserved, and if it\u0027s reserved, repeat generation.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8c497646b7e2c0896a59f29179e24645d9634833","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        self.agent_uuid_stamp \u003d val"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def request_agent_uuid_stamp(self):"},{"line_number":189,"context_line":"        uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":190,"context_line":"        if self.agent_uuid_stamp \u003d\u003d 0:"},{"line_number":191,"context_line":"            self.agent_uuid_stamp \u003d uuid_stamp"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_cd240b62","line":189,"in_reply_to":"9a68dd71_d9e611b0","updated":"2016-01-26 15:19:00.000000000","message":"I was considering putting it in but I figured the chances of 2 randomly generated 64-bit values being equal would be slim, I\u0027ll put it in just in case.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def request_agent_uuid_stamp(self):"},{"line_number":189,"context_line":"        uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":190,"context_line":"        if self.agent_uuid_stamp \u003d\u003d 0:"},{"line_number":191,"context_line":"            self.agent_uuid_stamp \u003d uuid_stamp"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        self.uuid_stamps.append(uuid_stamp)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_f9d435be","line":190,"updated":"2016-01-26 13:08:41.000000000","message":"is there still any valid reason to maintain the attribute? I suspect we should not bother, instead kill it.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"39457844d439d195dc2f63b7037027eebb01a8ed","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def request_agent_uuid_stamp(self):"},{"line_number":189,"context_line":"        uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":190,"context_line":"        if self.agent_uuid_stamp \u003d\u003d 0:"},{"line_number":191,"context_line":"            self.agent_uuid_stamp \u003d uuid_stamp"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        self.uuid_stamps.append(uuid_stamp)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_75cb7273","line":190,"in_reply_to":"9a68dd71_4d549bc9","updated":"2016-01-27 11:24:13.000000000","message":"See above. I don\u0027t think special case the first call to the method to set the default cookie value for the bridge. Instead, we should have a separate method for just that (we actually already have one, it\u0027s called set_agent_uuid_stamp, though a better name, like \u0027set_default_cookie\u0027, would be more reasonable.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8c497646b7e2c0896a59f29179e24645d9634833","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def request_agent_uuid_stamp(self):"},{"line_number":189,"context_line":"        uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":190,"context_line":"        if self.agent_uuid_stamp \u003d\u003d 0:"},{"line_number":191,"context_line":"            self.agent_uuid_stamp \u003d uuid_stamp"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        self.uuid_stamps.append(uuid_stamp)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_4d549bc9","line":190,"in_reply_to":"9a68dd71_f9d435be","updated":"2016-01-26 15:19:00.000000000","message":"The agent_uuid_stamp is used in the rest of bridge/mixin classes as a default value.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"ba2134bf49d19d680b8940a3f945ebff83952cd8","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        if self.agent_uuid_stamp \u003d\u003d 0:"},{"line_number":191,"context_line":"            self.agent_uuid_stamp \u003d uuid_stamp"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        self.uuid_stamps.append(uuid_stamp)"},{"line_number":194,"context_line":"        return uuid_stamp"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def get_uuid_stamp_list(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_848f0074","line":193,"range":{"start_line":193,"start_character":24,"end_line":193,"end_character":25},"updated":"2016-01-25 16:03:21.000000000","message":"Is there any scenario where one might want to request an already allocated UUID stamp?  It seems this always appends to uuid_stamps even if the uuid_stamp was previously allocated, and so you\u0027d end up with duplicates in the array, which could be avoided with an \"if uuid_stamp not in uuid_stamps\" kind of check.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"448b8aba88cbc5b211ce1cd17be96440f3a01a64","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        if self.agent_uuid_stamp \u003d\u003d 0:"},{"line_number":191,"context_line":"            self.agent_uuid_stamp \u003d uuid_stamp"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        self.uuid_stamps.append(uuid_stamp)"},{"line_number":194,"context_line":"        return uuid_stamp"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def get_uuid_stamp_list(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_2e0f3d89","line":193,"range":{"start_line":193,"start_character":24,"end_line":193,"end_character":25},"in_reply_to":"7a5de9d1_159f9e60","updated":"2016-01-31 09:05:37.000000000","message":"+1 for using set","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"39457844d439d195dc2f63b7037027eebb01a8ed","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        if self.agent_uuid_stamp \u003d\u003d 0:"},{"line_number":191,"context_line":"            self.agent_uuid_stamp \u003d uuid_stamp"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        self.uuid_stamps.append(uuid_stamp)"},{"line_number":194,"context_line":"        return uuid_stamp"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def get_uuid_stamp_list(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_159f9e60","line":193,"range":{"start_line":193,"start_character":24,"end_line":193,"end_character":25},"in_reply_to":"9a68dd71_0d5f8376","updated":"2016-01-27 11:24:13.000000000","message":"Using set() would avoid duplicates. But I think we should safe-guard against high jacking cookie values reserved by other entities.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8c497646b7e2c0896a59f29179e24645d9634833","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        if self.agent_uuid_stamp \u003d\u003d 0:"},{"line_number":191,"context_line":"            self.agent_uuid_stamp \u003d uuid_stamp"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        self.uuid_stamps.append(uuid_stamp)"},{"line_number":194,"context_line":"        return uuid_stamp"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def get_uuid_stamp_list(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_0d5f8376","line":193,"range":{"start_line":193,"start_character":24,"end_line":193,"end_character":25},"in_reply_to":"9a68dd71_848f0074","updated":"2016-01-26 15:19:00.000000000","message":"I order to be able to do that the bridge class would need to be able to know when a UUID stamp is no longer being used. \n\nIn previous iterations of the code there was a check to make sure the same agent couldn\u0027t request multiple stamps and if it did it always returned the same UUID stamp.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"bd7b7c5acb2b7f8febaa6f17162260c468112ac9","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        self.uuid_stamps.append(uuid_stamp)"},{"line_number":194,"context_line":"        return uuid_stamp"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def get_uuid_stamp_list(self):"},{"line_number":197,"context_line":"        if (self.agent_uuid_stamp !\u003d 0 and"},{"line_number":198,"context_line":"            self.agent_uuid_stamp not in self.uuid_stamps):"},{"line_number":199,"context_line":"            self.uuid_stamps.append(self.agent_uuid_stamp)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_847b7bbd","line":196,"range":{"start_line":196,"start_character":22,"end_line":196,"end_character":27},"updated":"2016-01-25 21:43:55.000000000","message":"Suggest removing reference to datatype, even if it is a list (but especially if it\u0027s not :) ).  (Would get_uuid_stamps make sense?)","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        self.uuid_stamps.append(uuid_stamp)"},{"line_number":194,"context_line":"        return uuid_stamp"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def get_uuid_stamp_list(self):"},{"line_number":197,"context_line":"        if (self.agent_uuid_stamp !\u003d 0 and"},{"line_number":198,"context_line":"            self.agent_uuid_stamp not in self.uuid_stamps):"},{"line_number":199,"context_line":"            self.uuid_stamps.append(self.agent_uuid_stamp)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_f9a2f54a","line":196,"range":{"start_line":196,"start_character":22,"end_line":196,"end_character":27},"in_reply_to":"9a68dd71_847b7bbd","updated":"2016-01-26 13:08:41.000000000","message":"Agreed. Or even \u0027get_reserved_cookies\u0027. There is probably no actual reason to maintain a list here (the order is irrelevant), set should be enough.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"d040e73d66bac8f8b4672f72813bb0a6491d49c6","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        return uuid_stamp"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def get_uuid_stamp_list(self):"},{"line_number":197,"context_line":"        if (self.agent_uuid_stamp !\u003d 0 and"},{"line_number":198,"context_line":"            self.agent_uuid_stamp not in self.uuid_stamps):"},{"line_number":199,"context_line":"            self.uuid_stamps.append(self.agent_uuid_stamp)"},{"line_number":200,"context_line":"        return self.uuid_stamps"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def set_controller(self, controllers):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_816b60b6","line":199,"range":{"start_line":197,"start_character":8,"end_line":199,"end_character":58},"updated":"2016-01-25 22:02:28.000000000","message":"You mentioned in PS: \"This is just to make sure that it can work until set_agent_uuid_stamp() is actually removed.\"  Can/should this be added as a code comment?","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        return uuid_stamp"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def get_uuid_stamp_list(self):"},{"line_number":197,"context_line":"        if (self.agent_uuid_stamp !\u003d 0 and"},{"line_number":198,"context_line":"            self.agent_uuid_stamp not in self.uuid_stamps):"},{"line_number":199,"context_line":"            self.uuid_stamps.append(self.agent_uuid_stamp)"},{"line_number":200,"context_line":"        return self.uuid_stamps"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def set_controller(self, controllers):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_f970b5de","line":199,"range":{"start_line":197,"start_character":8,"end_line":199,"end_character":58},"in_reply_to":"9a68dd71_816b60b6","updated":"2016-01-26 13:08:41.000000000","message":"I understand why we want to keep set_agent_uuid_stamp method for a cycle (though I suggest we deprecate it right away), but there is no reason to maintain a separate attribute for the agent uuid.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"39457844d439d195dc2f63b7037027eebb01a8ed","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        return uuid_stamp"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def get_uuid_stamp_list(self):"},{"line_number":197,"context_line":"        if (self.agent_uuid_stamp !\u003d 0 and"},{"line_number":198,"context_line":"            self.agent_uuid_stamp not in self.uuid_stamps):"},{"line_number":199,"context_line":"            self.uuid_stamps.append(self.agent_uuid_stamp)"},{"line_number":200,"context_line":"        return self.uuid_stamps"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def set_controller(self, controllers):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_35c17a2f","line":199,"range":{"start_line":197,"start_character":8,"end_line":199,"end_character":58},"in_reply_to":"9a68dd71_f970b5de","updated":"2016-01-27 11:24:13.000000000","message":"OK, I guess my comment should instead say: \"there is no reason to maintain the attribute as public and with that name since it does not reflect its intent (the default cookie)\".","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"ba2134bf49d19d680b8940a3f945ebff83952cd8","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                               if \u0027NXST\u0027 not in item)"},{"line_number":326,"context_line":"        return retval"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def dump_flow(self, **kwargs):"},{"line_number":329,"context_line":"        retval \u003d None"},{"line_number":330,"context_line":"        flow_str \u003d \"\""},{"line_number":331,"context_line":"        for key in kwargs:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_0425505a","line":328,"range":{"start_line":328,"start_character":24,"end_line":328,"end_character":26},"updated":"2016-01-25 16:03:21.000000000","message":"In service to DRY, should dump_flows_for_table be recoded to be a call to dump_flow with specific parameters?","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"bd7b7c5acb2b7f8febaa6f17162260c468112ac9","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                               if \u0027NXST\u0027 not in item)"},{"line_number":326,"context_line":"        return retval"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def dump_flow(self, **kwargs):"},{"line_number":329,"context_line":"        retval \u003d None"},{"line_number":330,"context_line":"        flow_str \u003d \"\""},{"line_number":331,"context_line":"        for key in kwargs:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_956ba884","line":328,"range":{"start_line":328,"start_character":8,"end_line":328,"end_character":17},"updated":"2016-01-25 21:43:55.000000000","message":"Suggest s/dump_flow/dump_flows","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8c497646b7e2c0896a59f29179e24645d9634833","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                               if \u0027NXST\u0027 not in item)"},{"line_number":326,"context_line":"        return retval"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def dump_flow(self, **kwargs):"},{"line_number":329,"context_line":"        retval \u003d None"},{"line_number":330,"context_line":"        flow_str \u003d \"\""},{"line_number":331,"context_line":"        for key in kwargs:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_edeb0f77","line":328,"range":{"start_line":328,"start_character":24,"end_line":328,"end_character":26},"in_reply_to":"9a68dd71_0425505a","updated":"2016-01-26 15:19:00.000000000","message":"Done","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                               if \u0027NXST\u0027 not in item)"},{"line_number":326,"context_line":"        return retval"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def dump_flow(self, **kwargs):"},{"line_number":329,"context_line":"        retval \u003d None"},{"line_number":330,"context_line":"        flow_str \u003d \"\""},{"line_number":331,"context_line":"        for key in kwargs:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_fc298338","line":328,"range":{"start_line":328,"start_character":8,"end_line":328,"end_character":17},"in_reply_to":"9a68dd71_956ba884","updated":"2016-01-26 13:08:41.000000000","message":"Agreed with both comments.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8c497646b7e2c0896a59f29179e24645d9634833","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                               if \u0027NXST\u0027 not in item)"},{"line_number":326,"context_line":"        return retval"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def dump_flow(self, **kwargs):"},{"line_number":329,"context_line":"        retval \u003d None"},{"line_number":330,"context_line":"        flow_str \u003d \"\""},{"line_number":331,"context_line":"        for key in kwargs:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_2df28770","line":328,"range":{"start_line":328,"start_character":8,"end_line":328,"end_character":17},"in_reply_to":"9a68dd71_956ba884","updated":"2016-01-26 15:19:00.000000000","message":"dump_flows is already in another class and over rides this one, took me a while to figure that out...\n\nDoes \"dump_select_flows\" sound ok?","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9f27ad9435057b50bbe9240c039677410b8cea94","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self.agent_uuid_stamp \u003d 0"},{"line_number":183,"context_line":"        self.uuid_stamps \u003d []"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":186,"context_line":"        self.agent_uuid_stamp \u003d val"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a5de9d1_e55b3e84","line":183,"updated":"2016-02-02 04:43:22.000000000","message":"i tend to think uuid_stamp things belong to the agent, rather than ovs_lib.","commit_id":"50edc4a3f42a66f34e0d3e68c83fd6132f6cc88a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"80953e649f14a303b971d3a88b166e0e6a023948","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self.agent_uuid_stamp \u003d 0"},{"line_number":183,"context_line":"        self.uuid_stamps \u003d []"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":186,"context_line":"        self.agent_uuid_stamp \u003d val"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_eba1f8f8","line":183,"in_reply_to":"5a5ae5dd_fbb949cc","updated":"2016-02-08 04:42:51.000000000","message":"my point is that it isn\u0027t a great idea to hardcode this particular usage of cookies in a library. (ovs_lib)","commit_id":"50edc4a3f42a66f34e0d3e68c83fd6132f6cc88a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e72a84f3185a2e7f0932eba961ea33875203c4fa","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self.agent_uuid_stamp \u003d 0"},{"line_number":183,"context_line":"        self.uuid_stamps \u003d []"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":186,"context_line":"        self.agent_uuid_stamp \u003d val"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_fbb949cc","line":183,"in_reply_to":"7a5de9d1_e55b3e84","updated":"2016-02-04 08:53:16.000000000","message":"We have a bridge mixin that cleans up stale flows based on the list: neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/ofswitch.py","commit_id":"50edc4a3f42a66f34e0d3e68c83fd6132f6cc88a"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"a9a276842b6133c89a1581b770d1d44848ed10e5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from neutron.plugins.common import constants as p_const"},{"line_number":33,"context_line":"from neutron.plugins.ml2.drivers.openvswitch.agent.common \\"},{"line_number":34,"context_line":"    import constants"},{"line_number":35,"context_line":"from sets import Set"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"UINT64_BITMASK \u003d (1 \u003c\u003c 64) - 1"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_af61ac06","line":35,"range":{"start_line":35,"start_character":10,"end_line":35,"end_character":16},"updated":"2016-02-08 17:27:13.000000000","message":"Maybe this was discussed already, but is there a reason to use the old \"sets.Set\" v. the new built-in set?\nhttps://docs.python.org/2/library/sets.html#module-sets","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"fdff2c00b5f5a50f527c4c49473d97892a6d6415","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        self.br_name \u003d br_name"},{"line_number":182,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":183,"context_line":"        self.default_cookie \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":184,"context_line":"        self.reserved_cookies \u003d Set([self.default_cookie])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        LOG.warn(_LW(\"set_agent_uuid_stamp is depricated and to be removed\""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_15f2eed2","line":184,"range":{"start_line":184,"start_character":13,"end_line":184,"end_character":29},"updated":"2016-02-04 10:59:34.000000000","message":"opinion: may be a better name is preserved  or ignored ? :)","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fc32f0c6095350ca2f69fd12b4743f4ff5bc0178","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        self.br_name \u003d br_name"},{"line_number":182,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":183,"context_line":"        self.default_cookie \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":184,"context_line":"        self.reserved_cookies \u003d Set([self.default_cookie])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        LOG.warn(_LW(\"set_agent_uuid_stamp is depricated and to be removed\""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_86eafaaa","line":184,"range":{"start_line":184,"start_character":13,"end_line":184,"end_character":29},"in_reply_to":"5a5ae5dd_15f2eed2","updated":"2016-02-05 10:21:16.000000000","message":"Definitely not ignored. Preserved is also a bit specific (it does reflect only one side of the cookie usage - the cleanup part; but cookies are also used to distinguish between flows belonging to different features that those features \u0027reserved\u0027 before).","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"84ee16e25ba7b8f732edad491044ec512f339619","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        self.br_name \u003d br_name"},{"line_number":182,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":183,"context_line":"        self.default_cookie \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":184,"context_line":"        self.reserved_cookies \u003d Set([self.default_cookie])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        LOG.warn(_LW(\"set_agent_uuid_stamp is depricated and to be removed\""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_f2a5a846","line":184,"range":{"start_line":184,"start_character":13,"end_line":184,"end_character":29},"in_reply_to":"5a5ae5dd_86eafaaa","updated":"2016-02-05 12:09:39.000000000","message":"I think reserved is OK.","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"fdff2c00b5f5a50f527c4c49473d97892a6d6415","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.reserved_cookies \u003d Set([self.default_cookie])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        LOG.warn(_LW(\"set_agent_uuid_stamp is depricated and to be removed\""},{"line_number":188,"context_line":"                     \" in Newton\"))"},{"line_number":189,"context_line":"        self.default_cookie \u003d val"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_15c98e78","line":187,"updated":"2016-02-04 10:59:34.000000000","message":"depricated-\u003edeprecated","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"0cc656c404e51b6b867412b02af6d6cbcb85d05f","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.reserved_cookies \u003d Set([self.default_cookie])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        LOG.warn(_LW(\"set_agent_uuid_stamp is depricated and to be removed\""},{"line_number":188,"context_line":"                     \" in Newton\"))"},{"line_number":189,"context_line":"        self.default_cookie \u003d val"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_97c9c628","line":187,"in_reply_to":"5a5ae5dd_15c98e78","updated":"2016-02-05 13:44:09.000000000","message":"Done","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"84ee16e25ba7b8f732edad491044ec512f339619","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.reserved_cookies \u003d Set([self.default_cookie])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        LOG.warn(_LW(\"set_agent_uuid_stamp is depricated and to be removed\""},{"line_number":188,"context_line":"                     \" in Newton\"))"},{"line_number":189,"context_line":"        self.default_cookie \u003d val"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_bd2dc196","line":187,"in_reply_to":"5a5ae5dd_15c98e78","updated":"2016-02-05 12:09:39.000000000","message":"Just a question: Can we use debtcollector for this?","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e7782d3d8a280a7a9c8990c9a5b1e8976d9260a1","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    def get_default_cookie(self):"},{"line_number":192,"context_line":"        return self.default_cookie"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def request_cookie(self):"},{"line_number":195,"context_line":"        uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":196,"context_line":"        while uuid_stamp in self.reserved_cookies:"},{"line_number":197,"context_line":"            uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_972d4600","line":194,"range":{"start_line":194,"start_character":27,"end_line":194,"end_character":29},"updated":"2016-02-05 11:26:23.000000000","message":"based on my later comments, I\u0027d introduce an extra parameter, to indicate (and store) who uses the cookie\n\nrequest_cookie(usage\u003d\"qos-dscp\")\nrequest_cookie(usage\u003d\"sfc\") ....\n\n\netc, so later reporting and debugging would be easier, we could have guru reports with details of what\u0027s every cookie used for. Or better logging around this.\n\nWe would require a map instead of a set, then.","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"84ee16e25ba7b8f732edad491044ec512f339619","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    def get_default_cookie(self):"},{"line_number":192,"context_line":"        return self.default_cookie"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def request_cookie(self):"},{"line_number":195,"context_line":"        uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":196,"context_line":"        while uuid_stamp in self.reserved_cookies:"},{"line_number":197,"context_line":"            uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_9d76c5a2","line":194,"range":{"start_line":194,"start_character":27,"end_line":194,"end_character":29},"in_reply_to":"5a5ae5dd_972d4600","updated":"2016-02-05 12:09:39.000000000","message":"+1","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"0cc656c404e51b6b867412b02af6d6cbcb85d05f","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    def get_default_cookie(self):"},{"line_number":192,"context_line":"        return self.default_cookie"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def request_cookie(self):"},{"line_number":195,"context_line":"        uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":196,"context_line":"        while uuid_stamp in self.reserved_cookies:"},{"line_number":197,"context_line":"            uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_ef1ffa69","line":194,"range":{"start_line":194,"start_character":27,"end_line":194,"end_character":29},"in_reply_to":"5a5ae5dd_972d4600","updated":"2016-02-05 13:44:09.000000000","message":"We did this early on, but it was phased out.\n\nIt was originally part of the requesting process to provide the extension object and later a String with the name of the extension. We phased it out as extensions may want to request multiple cookies (for example a cookie per QoS policy).","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2e417f8624ae2792bb4fd72eb855c12ea5898d4b","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    def get_default_cookie(self):"},{"line_number":192,"context_line":"        return self.default_cookie"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def request_cookie(self):"},{"line_number":195,"context_line":"        uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":196,"context_line":"        while uuid_stamp in self.reserved_cookies:"},{"line_number":197,"context_line":"            uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_5560fdce","line":194,"range":{"start_line":194,"start_character":27,"end_line":194,"end_character":29},"in_reply_to":"5a5ae5dd_ef1ffa69","updated":"2016-02-06 16:03:16.000000000","message":"Yes, for the least, bridge is not interested in tracking cookie users. If we\u0027d like to have some debugging logs, fine, let\u0027s have them (later) in agent API object itself.","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"fdff2c00b5f5a50f527c4c49473d97892a6d6415","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        return self.default_cookie"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def request_cookie(self):"},{"line_number":195,"context_line":"        uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":196,"context_line":"        while uuid_stamp in self.reserved_cookies:"},{"line_number":197,"context_line":"            uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_b59c3a5e","line":195,"updated":"2016-02-04 10:59:34.000000000","message":"I\u0027d extract the uuid.uuid4().int \u0026 UINT64_BITMASK to another function, \nmay be: ?\n\ndef _get_random_cookie():\n     return uuid.uuid4().int \u0026 UINT64_BITMASK","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"c2862de3973d26329a307601db9e47c2d12ea190","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        return self.default_cookie"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def request_cookie(self):"},{"line_number":195,"context_line":"        uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":196,"context_line":"        while uuid_stamp in self.reserved_cookies:"},{"line_number":197,"context_line":"            uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_a045c817","line":195,"in_reply_to":"5a5ae5dd_b59c3a5e","updated":"2016-02-04 15:10:59.000000000","message":"Done","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"fdff2c00b5f5a50f527c4c49473d97892a6d6415","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def get_reserved_cookies(self):"},{"line_number":203,"context_line":"        # NOTE Check only necessary until set_agent_uuid_stamp is removed"},{"line_number":204,"context_line":"        if self.default_cookie not in self.reserved_cookies:"},{"line_number":205,"context_line":"            self.reserved_cookies.add(self.default_cookie)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        return self.reserved_cookies"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_b5eafaaa","line":204,"updated":"2016-02-04 10:59:34.000000000","message":"can we just add that check to set_agent_uuid_stamp?","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"c2862de3973d26329a307601db9e47c2d12ea190","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def get_reserved_cookies(self):"},{"line_number":203,"context_line":"        # NOTE Check only necessary until set_agent_uuid_stamp is removed"},{"line_number":204,"context_line":"        if self.default_cookie not in self.reserved_cookies:"},{"line_number":205,"context_line":"            self.reserved_cookies.add(self.default_cookie)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        return self.reserved_cookies"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_e94df272","line":204,"in_reply_to":"5a5ae5dd_b5eafaaa","updated":"2016-02-04 15:10:59.000000000","message":"It originally was, but with set_agent_uuid_stamp getting deprecated I was told to keep new code out of it.","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e7782d3d8a280a7a9c8990c9a5b1e8976d9260a1","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def get_reserved_cookies(self):"},{"line_number":203,"context_line":"        # NOTE Check only necessary until set_agent_uuid_stamp is removed"},{"line_number":204,"context_line":"        if self.default_cookie not in self.reserved_cookies:"},{"line_number":205,"context_line":"            self.reserved_cookies.add(self.default_cookie)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        return self.reserved_cookies"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_b7a8828e","line":204,"in_reply_to":"5a5ae5dd_e94df272","updated":"2016-02-05 11:26:23.000000000","message":"Ok, makes sense.","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"fdff2c00b5f5a50f527c4c49473d97892a6d6415","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        retval \u003d None"},{"line_number":331,"context_line":"        flow_str \u003d \"\""},{"line_number":332,"context_line":"        for key in kwargs:"},{"line_number":333,"context_line":"            flow_str +\u003d str(key) + \"\u003d\" + str(kwargs[key]) + \",\""},{"line_number":334,"context_line":"        flow_str \u003d flow_str.rstrip(\u0027,\u0027)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        flows \u003d self.run_ofctl(\"dump-flows\", [flow_str])"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_5555c64d","line":333,"range":{"start_line":333,"start_character":60,"end_line":333,"end_character":63},"updated":"2016-02-04 10:59:34.000000000","message":"this is just nitpicking, but it\u0027s more visual (and longer...) if you do\n\n\n    flow_strs \u003d [\"%(key)s\u003d%(value)s,\" % {\u0027key\u0027: key, \u0027value\u0027: str(value)}\n                        for key, value in kwargs.items()]\n\n    flow_str \u003d \u0027,\u0027.join(flow_strs)\n\nThis is probably slower, you may discard it, and just keep the string formatting suggestion. If we manipulate a lot of flows it\u0027s probably good to keep an eye on speed.\n\nbtw, do we need str(key), or just key would do?","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"c2862de3973d26329a307601db9e47c2d12ea190","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        retval \u003d None"},{"line_number":331,"context_line":"        flow_str \u003d \"\""},{"line_number":332,"context_line":"        for key in kwargs:"},{"line_number":333,"context_line":"            flow_str +\u003d str(key) + \"\u003d\" + str(kwargs[key]) + \",\""},{"line_number":334,"context_line":"        flow_str \u003d flow_str.rstrip(\u0027,\u0027)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        flows \u003d self.run_ofctl(\"dump-flows\", [flow_str])"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_891c7e14","line":333,"range":{"start_line":333,"start_character":60,"end_line":333,"end_character":63},"in_reply_to":"5a5ae5dd_5555c64d","updated":"2016-02-04 15:10:59.000000000","message":"I recall having problems with key without it being inside str(), I might be confusing it with kwargs though.\nI\u0027ll check + change.","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.default_cookie \u003d cookie or self._generate_random_cookie()"},{"line_number":184,"context_line":"        self.reserved_cookies \u003d set([self.default_cookie])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        self.default_cookie \u003d val"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _generate_random_cookie(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_f41df90f","line":186,"updated":"2016-02-10 14:28:42.000000000","message":"You talk below we may want to remove the method. Should we mark it for deprecation now then? [with debtcollector]","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8883902021ca8647a75fa24f7dfea6f7bbca56da","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.default_cookie \u003d cookie or self._generate_random_cookie()"},{"line_number":184,"context_line":"        self.reserved_cookies \u003d set([self.default_cookie])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        self.default_cookie \u003d val"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _generate_random_cookie(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_79d97d21","line":186,"in_reply_to":"3a57f1b5_96bec6d2","updated":"2016-02-12 15:16:03.000000000","message":"OK, let\u0027s leave deprecation to later.","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8327571bd8ed14cff119cc67e1a4296a2694d4a4","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.default_cookie \u003d cookie or self._generate_random_cookie()"},{"line_number":184,"context_line":"        self.reserved_cookies \u003d set([self.default_cookie])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        self.default_cookie \u003d val"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _generate_random_cookie(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_96bec6d2","line":186,"in_reply_to":"3a57f1b5_f41df90f","updated":"2016-02-11 17:00:20.000000000","message":"I worked around needing it with the addition of the optional argument in the constructor.\nWe can still deprecate it if you think it\u0027s for the best?","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.reserved_cookies \u003d set([self.default_cookie])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        self.default_cookie \u003d val"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _generate_random_cookie(self):"},{"line_number":190,"context_line":"        return uuid.uuid4().int \u0026 UINT64_BITMASK"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_f4cbb970","line":187,"updated":"2016-02-10 14:28:42.000000000","message":"Should we drop the old value from reserved_cookies and also add the new one there?","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8327571bd8ed14cff119cc67e1a4296a2694d4a4","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.reserved_cookies \u003d set([self.default_cookie])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        self.default_cookie \u003d val"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _generate_random_cookie(self):"},{"line_number":190,"context_line":"        return uuid.uuid4().int \u0026 UINT64_BITMASK"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_f6de1a6c","line":187,"in_reply_to":"3a57f1b5_f4cbb970","updated":"2016-02-11 17:00:20.000000000","message":"I think so, If the primary function was to change the OVSNeutronAgent\u0027s cookie then it makes sense to remove the previous one from the list.","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        return uuid_stamp"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def get_reserved_cookies(self):"},{"line_number":204,"context_line":"        # NOTE Check only necessary until set_agent_uuid_stamp is removed"},{"line_number":205,"context_line":"        if self.default_cookie not in self.reserved_cookies:"},{"line_number":206,"context_line":"            self.reserved_cookies.add(self.default_cookie)"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_f4f659d6","line":204,"updated":"2016-02-10 14:28:42.000000000","message":"I think you need to add your nickname here to pass pep8 check.","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8327571bd8ed14cff119cc67e1a4296a2694d4a4","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        return uuid_stamp"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def get_reserved_cookies(self):"},{"line_number":204,"context_line":"        # NOTE Check only necessary until set_agent_uuid_stamp is removed"},{"line_number":205,"context_line":"        if self.default_cookie not in self.reserved_cookies:"},{"line_number":206,"context_line":"            self.reserved_cookies.add(self.default_cookie)"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_96a566b6","line":204,"in_reply_to":"3a57f1b5_f4f659d6","updated":"2016-02-11 17:00:20.000000000","message":"Done","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    def get_reserved_cookies(self):"},{"line_number":204,"context_line":"        # NOTE Check only necessary until set_agent_uuid_stamp is removed"},{"line_number":205,"context_line":"        if self.default_cookie not in self.reserved_cookies:"},{"line_number":206,"context_line":"            self.reserved_cookies.add(self.default_cookie)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        return self.reserved_cookies"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_34b071f4","line":206,"updated":"2016-02-10 14:28:42.000000000","message":"If you make set_agent_uuid_stamp update reserved_cookies, you don\u0027t need lines 205-206 here.","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8327571bd8ed14cff119cc67e1a4296a2694d4a4","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    def get_reserved_cookies(self):"},{"line_number":204,"context_line":"        # NOTE Check only necessary until set_agent_uuid_stamp is removed"},{"line_number":205,"context_line":"        if self.default_cookie not in self.reserved_cookies:"},{"line_number":206,"context_line":"            self.reserved_cookies.add(self.default_cookie)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        return self.reserved_cookies"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_1692d657","line":206,"in_reply_to":"3a57f1b5_0e1be173","updated":"2016-02-11 17:00:20.000000000","message":"Done","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5b781ed0346449257e53656949456d9935c2ff6f","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    def get_reserved_cookies(self):"},{"line_number":204,"context_line":"        # NOTE Check only necessary until set_agent_uuid_stamp is removed"},{"line_number":205,"context_line":"        if self.default_cookie not in self.reserved_cookies:"},{"line_number":206,"context_line":"            self.reserved_cookies.add(self.default_cookie)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        return self.reserved_cookies"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_0e1be173","line":206,"in_reply_to":"3a57f1b5_34b071f4","updated":"2016-02-10 14:47:41.000000000","message":"See PS14, @david said: \"It originally was, but with set_agent_uuid_stamp getting deprecated I was told to keep new code out of it.\" to same comment. But now that function doesn\u0027t seem to be deprecated any more :), so, comment applies again :)\n\nhttps://review.openstack.org/#/c/267591/14..18/neutron/agent/common/ovs_lib.py","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        if self.default_cookie not in self.reserved_cookies:"},{"line_number":206,"context_line":"            self.reserved_cookies.add(self.default_cookie)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        return self.reserved_cookies"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def set_controller(self, controllers):"},{"line_number":211,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_14821501","line":208,"updated":"2016-02-10 14:28:42.000000000","message":"I suggest we return a copy of the set to avoid callers messing with the original set.","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5b781ed0346449257e53656949456d9935c2ff6f","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        if self.default_cookie not in self.reserved_cookies:"},{"line_number":206,"context_line":"            self.reserved_cookies.add(self.default_cookie)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        return self.reserved_cookies"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def set_controller(self, controllers):"},{"line_number":211,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_a340a657","line":208,"in_reply_to":"3a57f1b5_14821501","updated":"2016-02-10 14:47:41.000000000","message":"+1, give we won\u0027t have control over the caller on some extensions","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8327571bd8ed14cff119cc67e1a4296a2694d4a4","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        if self.default_cookie not in self.reserved_cookies:"},{"line_number":206,"context_line":"            self.reserved_cookies.add(self.default_cookie)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        return self.reserved_cookies"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def set_controller(self, controllers):"},{"line_number":211,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_116f4093","line":208,"in_reply_to":"3a57f1b5_a340a657","updated":"2016-02-11 17:00:20.000000000","message":"Done","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        self.do_action_flows(\u0027del\u0027, [kwargs])"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def dump_flows_for_table(self, table):"},{"line_number":328,"context_line":"        return self.dump_flow(**{\"table\": table})"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def dump_flow(self, **kwargs):"},{"line_number":331,"context_line":"        retval \u003d None"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_d4ca3d4f","line":328,"range":{"start_line":328,"start_character":30,"end_line":328,"end_character":48},"updated":"2016-02-10 14:28:42.000000000","message":"better: dump_flow(table\u003dtable)","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5b781ed0346449257e53656949456d9935c2ff6f","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        self.do_action_flows(\u0027del\u0027, [kwargs])"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def dump_flows_for_table(self, table):"},{"line_number":328,"context_line":"        return self.dump_flow(**{\"table\": table})"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def dump_flow(self, **kwargs):"},{"line_number":331,"context_line":"        retval \u003d None"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_ce52a913","line":328,"range":{"start_line":328,"start_character":30,"end_line":328,"end_character":48},"in_reply_to":"3a57f1b5_d4ca3d4f","updated":"2016-02-10 14:47:41.000000000","message":"+1","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8327571bd8ed14cff119cc67e1a4296a2694d4a4","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        self.do_action_flows(\u0027del\u0027, [kwargs])"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def dump_flows_for_table(self, table):"},{"line_number":328,"context_line":"        return self.dump_flow(**{\"table\": table})"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def dump_flow(self, **kwargs):"},{"line_number":331,"context_line":"        retval \u003d None"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_fcdcbbe5","line":328,"range":{"start_line":328,"start_character":30,"end_line":328,"end_character":48},"in_reply_to":"3a57f1b5_d4ca3d4f","updated":"2016-02-11 17:00:20.000000000","message":"Done","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":327,"context_line":"    def dump_flows_for_table(self, table):"},{"line_number":328,"context_line":"        return self.dump_flow(**{\"table\": table})"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def dump_flow(self, **kwargs):"},{"line_number":331,"context_line":"        retval \u003d None"},{"line_number":332,"context_line":"        flow_str \u003d \"\""},{"line_number":333,"context_line":"        for key in kwargs:"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_5a499730","line":330,"range":{"start_line":330,"start_character":8,"end_line":330,"end_character":17},"updated":"2016-02-10 14:28:42.000000000","message":"The name is still unfortunate. First, we may want to document here why we don\u0027t use dump_flows (since it\u0027s used in a bridge mixin). Second, how about e.g. \u0027dump_flows_for(self, **kwargs)?","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8327571bd8ed14cff119cc67e1a4296a2694d4a4","unresolved":false,"context_lines":[{"line_number":327,"context_line":"    def dump_flows_for_table(self, table):"},{"line_number":328,"context_line":"        return self.dump_flow(**{\"table\": table})"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def dump_flow(self, **kwargs):"},{"line_number":331,"context_line":"        retval \u003d None"},{"line_number":332,"context_line":"        flow_str \u003d \"\""},{"line_number":333,"context_line":"        for key in kwargs:"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_7cc8cb22","line":330,"range":{"start_line":330,"start_character":8,"end_line":330,"end_character":17},"in_reply_to":"3a57f1b5_5a499730","updated":"2016-02-11 17:00:20.000000000","message":"Done","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def dump_flow(self, **kwargs):"},{"line_number":331,"context_line":"        retval \u003d None"},{"line_number":332,"context_line":"        flow_str \u003d \"\""},{"line_number":333,"context_line":"        for key in kwargs:"},{"line_number":334,"context_line":"            flow_str +\u003d key + \"\u003d\" + str(kwargs[key]) + \",\""},{"line_number":335,"context_line":"        flow_str \u003d flow_str.rstrip(\u0027,\u0027)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        flows \u003d self.run_ofctl(\"dump-flows\", [flow_str])"},{"line_number":338,"context_line":"        if flows:"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_d4b0fd8d","line":335,"range":{"start_line":332,"start_character":8,"end_line":335,"end_character":39},"updated":"2016-02-10 14:28:42.000000000","message":"flow_str \u003d \",\".join(\n    \"\u003d\".join([key, val])\n    for key, val in kwargs.items()\n)","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8327571bd8ed14cff119cc67e1a4296a2694d4a4","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def dump_flow(self, **kwargs):"},{"line_number":331,"context_line":"        retval \u003d None"},{"line_number":332,"context_line":"        flow_str \u003d \"\""},{"line_number":333,"context_line":"        for key in kwargs:"},{"line_number":334,"context_line":"            flow_str +\u003d key + \"\u003d\" + str(kwargs[key]) + \",\""},{"line_number":335,"context_line":"        flow_str \u003d flow_str.rstrip(\u0027,\u0027)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        flows \u003d self.run_ofctl(\"dump-flows\", [flow_str])"},{"line_number":338,"context_line":"        if flows:"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_dce1bf9b","line":335,"range":{"start_line":332,"start_character":8,"end_line":335,"end_character":39},"in_reply_to":"3a57f1b5_d4b0fd8d","updated":"2016-02-11 17:00:20.000000000","message":"Done","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5b781ed0346449257e53656949456d9935c2ff6f","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def dump_flow(self, **kwargs):"},{"line_number":331,"context_line":"        retval \u003d None"},{"line_number":332,"context_line":"        flow_str \u003d \"\""},{"line_number":333,"context_line":"        for key in kwargs:"},{"line_number":334,"context_line":"            flow_str +\u003d key + \"\u003d\" + str(kwargs[key]) + \",\""},{"line_number":335,"context_line":"        flow_str \u003d flow_str.rstrip(\u0027,\u0027)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        flows \u003d self.run_ofctl(\"dump-flows\", [flow_str])"},{"line_number":338,"context_line":"        if flows:"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_ae82cd50","line":335,"range":{"start_line":332,"start_character":8,"end_line":335,"end_character":39},"in_reply_to":"3a57f1b5_d4b0fd8d","updated":"2016-02-10 14:47:41.000000000","message":"Similar PS14 comments :-)\n\nmany ways to do this.","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        super(OVSBridge, self).__init__()"},{"line_number":181,"context_line":"        self.br_name \u003d br_name"},{"line_number":182,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":183,"context_line":"        self.default_cookie \u003d cookie or self._generate_random_cookie()"},{"line_number":184,"context_line":"        self.reserved_cookies \u003d set([self.default_cookie])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_5967e14c","line":183,"range":{"start_line":183,"start_character":8,"end_line":183,"end_character":30},"updated":"2016-02-12 15:13:31.000000000","message":"Below, you probably assume a non-int cookie can be passed. If that\u0027s the case you want to handle, then you should make setters convert the passed value to int, and also use the setter here instead of direct attribute access.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9504976b3924baa04cad58b7b1ae35ad4cad940e","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.default_cookie \u003d cookie or self._generate_random_cookie()"},{"line_number":184,"context_line":"        self.reserved_cookies \u003d set([self.default_cookie])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        self.reserved_cookies.remove(self.default_cookie)"},{"line_number":188,"context_line":"        if val not in self.reserved_cookies:"},{"line_number":189,"context_line":"            self.reserved_cookies.add(val)"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_9577e6d3","line":186,"updated":"2016-02-15 04:31:12.000000000","message":"i guess you can just remove this method.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        self.reserved_cookies.remove(self.default_cookie)"},{"line_number":188,"context_line":"        if val not in self.reserved_cookies:"},{"line_number":189,"context_line":"            self.reserved_cookies.add(val)"},{"line_number":190,"context_line":"        self.default_cookie \u003d val"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_f9fb2d79","line":188,"updated":"2016-02-12 15:13:31.000000000","message":"nit: it\u0027s a set, you can just add it without a check (it won\u0027t allow duplicates).","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"64237c9f61c963e5b1d1db4b892560277c68300e","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        self.reserved_cookies.remove(self.default_cookie)"},{"line_number":188,"context_line":"        if val not in self.reserved_cookies:"},{"line_number":189,"context_line":"            self.reserved_cookies.add(val)"},{"line_number":190,"context_line":"        self.default_cookie \u003d val"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_51bd75b5","line":188,"in_reply_to":"3a57f1b5_f9fb2d79","updated":"2016-02-15 14:09:08.000000000","message":"Done","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        return uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def get_default_cookie(self):"},{"line_number":196,"context_line":"        return int(self.default_cookie)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def request_cookie(self):"},{"line_number":199,"context_line":"        uuid_stamp \u003d self._generate_random_cookie()"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_79473dbc","line":196,"updated":"2016-02-12 15:13:31.000000000","message":"Do you believe users can set it to non-int type? Then let\u0027s guard against it in setter functions.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"786a7af492f05a5eaf6805fdb665e34abf1883bc","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        return uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def get_default_cookie(self):"},{"line_number":196,"context_line":"        return int(self.default_cookie)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def request_cookie(self):"},{"line_number":199,"context_line":"        uuid_stamp \u003d self._generate_random_cookie()"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_71a8b120","line":196,"in_reply_to":"3a57f1b5_3f4c459d","updated":"2016-02-12 15:37:12.000000000","message":"Integers are not passed by reference but by value. There is no need to copy it.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"aeaecaa36c393dff7ae7fb7085f5511c74ecc7db","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        return uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def get_default_cookie(self):"},{"line_number":196,"context_line":"        return int(self.default_cookie)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def request_cookie(self):"},{"line_number":199,"context_line":"        uuid_stamp \u003d self._generate_random_cookie()"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_3f4c459d","line":196,"in_reply_to":"3a57f1b5_79473dbc","updated":"2016-02-12 15:28:00.000000000","message":"I added this to stop direct access, similar to how it\u0027s done in get_reserved_cookie().","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    def get_default_cookie(self):"},{"line_number":196,"context_line":"        return int(self.default_cookie)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def request_cookie(self):"},{"line_number":199,"context_line":"        uuid_stamp \u003d self._generate_random_cookie()"},{"line_number":200,"context_line":"        while uuid_stamp in self.reserved_cookies:"},{"line_number":201,"context_line":"            uuid_stamp \u003d self._generate_random_cookie()"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_64a234ff","line":198,"updated":"2016-02-12 15:13:31.000000000","message":"There should be a test in test_ovs_lib that targets the method. Same for get_reserved_cookies. And dump_flows_for.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"64237c9f61c963e5b1d1db4b892560277c68300e","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    def get_default_cookie(self):"},{"line_number":196,"context_line":"        return int(self.default_cookie)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def request_cookie(self):"},{"line_number":199,"context_line":"        uuid_stamp \u003d self._generate_random_cookie()"},{"line_number":200,"context_line":"        while uuid_stamp in self.reserved_cookies:"},{"line_number":201,"context_line":"            uuid_stamp \u003d self._generate_random_cookie()"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_177588f8","line":198,"in_reply_to":"3a57f1b5_64a234ff","updated":"2016-02-15 14:09:08.000000000","message":"Done","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9504976b3924baa04cad58b7b1ae35ad4cad940e","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        return uuid_stamp"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def get_reserved_cookies(self):"},{"line_number":207,"context_line":"        return set(self.reserved_cookies)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def set_controller(self, controllers):"},{"line_number":210,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_f53592f7","line":207,"updated":"2016-02-15 04:31:12.000000000","message":"sorry for insisting, i still believe these \"reserved cookie\" stuffs should be moved into ovs-agent.\ni suppose ovs_lib will be in neutron-lib eventually.\nhaving these ovs-agent specific code here can involve unnecessary compatibility burden in future.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"49910f716fbe9d97398832c521bc51d928ee38b0","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        return uuid_stamp"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def get_reserved_cookies(self):"},{"line_number":207,"context_line":"        return set(self.reserved_cookies)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def set_controller(self, controllers):"},{"line_number":210,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":19,"id":"bae84128_2bc230e9","line":207,"in_reply_to":"bae84128_89f6ef8c","updated":"2016-02-24 09:57:17.000000000","message":"Done","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2ba374b68269bef37241da7aa49ad7e0a60c34cd","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        return uuid_stamp"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def get_reserved_cookies(self):"},{"line_number":207,"context_line":"        return set(self.reserved_cookies)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def set_controller(self, controllers):"},{"line_number":210,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_e782c993","line":207,"in_reply_to":"dae33548_6c0dfe8f","updated":"2016-02-16 10:03:28.000000000","message":"Is it a matter of moving code in a mixin that is used by ovs agent? I am fine with it if that covers your concern.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2ba374b68269bef37241da7aa49ad7e0a60c34cd","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        return uuid_stamp"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def get_reserved_cookies(self):"},{"line_number":207,"context_line":"        return set(self.reserved_cookies)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def set_controller(self, controllers):"},{"line_number":210,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_6b4a23c7","line":207,"in_reply_to":"dae33548_d7e4c00e","updated":"2016-02-16 10:03:28.000000000","message":"There is a way to do it out of the bridge logic, yes. Though I also believe that it\u0027s not bound to the agent itself. In theory, other agents may be also interested in setting flows for some bridges and cleaning them up in a way that does not break data plane. So I would say keeping the code in the bridge is justified, as it\u0027s justified now to keep the default cookie value here.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"788d662b486dae878046950f8bc12b78357bcdc2","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        return uuid_stamp"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def get_reserved_cookies(self):"},{"line_number":207,"context_line":"        return set(self.reserved_cookies)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def set_controller(self, controllers):"},{"line_number":210,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_6c0dfe8f","line":207,"in_reply_to":"dae33548_d7e4c00e","updated":"2016-02-16 09:40:37.000000000","message":"sorry, i don\u0027t understand why it wouldn\u0027t work.\n\nthe mixin belongs to the agent, where i think these cookie stuff should be too.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2787fdff14e63ffefe3f21d8a4976de52d6dd1e3","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        return uuid_stamp"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def get_reserved_cookies(self):"},{"line_number":207,"context_line":"        return set(self.reserved_cookies)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def set_controller(self, controllers):"},{"line_number":210,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":19,"id":"bae84128_89f6ef8c","line":207,"in_reply_to":"dae33548_e782c993","updated":"2016-02-24 06:48:13.000000000","message":"yes, it\u0027s what i meant.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"64237c9f61c963e5b1d1db4b892560277c68300e","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        return uuid_stamp"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def get_reserved_cookies(self):"},{"line_number":207,"context_line":"        return set(self.reserved_cookies)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def set_controller(self, controllers):"},{"line_number":210,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_d7e4c00e","line":207,"in_reply_to":"dae33548_f53592f7","updated":"2016-02-15 14:09:08.000000000","message":"It wouldn\u0027t work in ovs_agent. The flow clean up method is inside the bridge object from a mixin and it uses the agent_uuid_stamp (which is changed to the list reserved_cookies here) to delete flows that don\u0027t match that uuid.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        super(OVSBridge, self).__init__()"},{"line_number":181,"context_line":"        self.br_name \u003d br_name"},{"line_number":182,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":183,"context_line":"        self.default_cookie \u003d cookie or self._generate_random_cookie()"},{"line_number":184,"context_line":"        self.reserved_cookies \u003d set([self.default_cookie])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        self.reserved_cookies.remove(self.default_cookie)"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_f98ae462","line":184,"range":{"start_line":183,"start_character":8,"end_line":184,"end_character":58},"updated":"2016-02-18 12:07:31.000000000","message":"I would make default_cookie and reserved_cookies private:\n\nif not cookie:\n    cookie \u003d self._generate_random_cookie()\nself._default_cookie \u003d cookie\nself._reserved_cookies \u003d {cookie}","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    def _generate_random_cookie(self):"},{"line_number":192,"context_line":"        return uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def get_default_cookie(self):"},{"line_number":195,"context_line":"        return self.default_cookie"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def request_cookie(self):"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_6ce615e9","line":194,"updated":"2016-02-18 12:07:31.000000000","message":"I would implement it as a property:\n\n@property\ndef default_cookie(self):\n     return self._default_cookie","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        self.reserved_cookies.add(uuid_stamp)"},{"line_number":203,"context_line":"        return uuid_stamp"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def get_reserved_cookies(self):"},{"line_number":206,"context_line":"        return set(self.reserved_cookies)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def set_controller(self, controllers):"},{"line_number":209,"context_line":"        self.ovsdb.set_controller(self.br_name,"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_f652f333","line":206,"range":{"start_line":205,"start_character":4,"end_line":206,"end_character":41},"updated":"2016-02-18 12:07:31.000000000","message":"I would implement this method as a property:\n\n@property\ndef reserved_cookies(self):\n     return self._reserved_cookies","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    def dump_flows_for_table(self, table):"},{"line_number":326,"context_line":"        return self.dump_flows_for(table\u003dtable)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def dump_flows_for(self, **kwargs):"},{"line_number":329,"context_line":"        retval \u003d None"},{"line_number":330,"context_line":"        if \"cookie\" in kwargs:"},{"line_number":331,"context_line":"            if \u0027/\u0027 not in kwargs[\"cookie\"]:"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_4c6fd1fb","line":328,"updated":"2016-02-18 12:07:31.000000000","message":"Accept cookie as argument with default value as None. It would make this code simpler.","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def dump_flows_for(self, **kwargs):"},{"line_number":329,"context_line":"        retval \u003d None"},{"line_number":330,"context_line":"        if \"cookie\" in kwargs:"},{"line_number":331,"context_line":"            if \u0027/\u0027 not in kwargs[\"cookie\"]:"},{"line_number":332,"context_line":"                kwargs[\"cookie\"] \u003d str(kwargs[\"cookie\"]) + \"/-1\""},{"line_number":333,"context_line":"        flow_str \u003d \",\".join(\"\u003d\".join([key, str(val)])"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_a0fdc16f","line":330,"updated":"2016-02-18 12:07:31.000000000","message":"I think this code is more explicit:\n\ndef dump_flows_for(self, cookie\u003dNone, **entries):\n    retval \u003d None\n    if cookie is not None:\n        cookie \u003d str(cookie)\n        if \u0027/\u0027 not in cookie:\n            cookie +\u003d \"/-1\"\n        entries[\u0027cookie\u0027] \u003d cookie\n    flow_str \u003d \u0027,\u0027.join(\u0027{}\u003d{}\u0027.format(*i) for i in six.iteritems(entries))","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"3555da0d8aaa8df9bc44f2855e5b37451a19308a","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def dump_flows_for(self, **kwargs):"},{"line_number":329,"context_line":"        retval \u003d None"},{"line_number":330,"context_line":"        if \"cookie\" in kwargs:"},{"line_number":331,"context_line":"            if \u0027/\u0027 not in kwargs[\"cookie\"]:"},{"line_number":332,"context_line":"                kwargs[\"cookie\"] \u003d str(kwargs[\"cookie\"]) + \"/-1\""},{"line_number":333,"context_line":"        flow_str \u003d \",\".join(\"\u003d\".join([key, str(val)])"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_7aad19e8","line":330,"in_reply_to":"dae33548_a0fdc16f","updated":"2016-02-18 14:40:53.000000000","message":"I think in this case \n\n  if cookie is not None:\n\ncould be replaced by\n\n  if cookie:","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"353060a8bd9ae79893f398171c4438eb5b648f24","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        self.br_name \u003d br_name"},{"line_number":182,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":183,"context_line":"        self._default_cookie \u003d cookie or self._generate_random_cookie()"},{"line_number":184,"context_line":"        self._reserved_cookies \u003d set([self._default_cookie])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":187,"context_line":"        self._reserved_cookies.remove(self._default_cookie)"}],"source_content_type":"text/x-python","patch_set":23,"id":"dae33548_c239cea5","line":184,"range":{"start_line":184,"start_character":33,"end_line":184,"end_character":60},"updated":"2016-02-18 18:45:53.000000000","message":"self._reserved_cookies \u003d {self._default_cookie}","commit_id":"fcf624ab120f02ea328935747857428a1595a76f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"15e5c4ac7225b3bd34104d566c788298aa4e4d83","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        retval \u003d None"},{"line_number":320,"context_line":"        if \"cookie\" in kwargs:"},{"line_number":321,"context_line":"            if \u0027/\u0027 not in str(kwargs[\"cookie\"]):"},{"line_number":322,"context_line":"                kwargs[\"cookie\"] \u003d str(kwargs[\"cookie\"]) + \"/-1\""},{"line_number":323,"context_line":"        flow_str \u003d \",\".join(\"\u003d\".join([key, str(val)])"},{"line_number":324,"context_line":"            for key, val in kwargs.items())"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_bbf43587","line":322,"range":{"start_line":322,"start_character":35,"end_line":322,"end_character":56},"updated":"2016-02-22 16:43:36.000000000","message":"nitty nit: you could calculate it just once for lines 321 and 322.","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d0ef73d7b0b3793499639fe005fb75743bc8aea3","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        retval \u003d None"},{"line_number":320,"context_line":"        if \"cookie\" in kwargs:"},{"line_number":321,"context_line":"            if \u0027/\u0027 not in str(kwargs[\"cookie\"]):"},{"line_number":322,"context_line":"                kwargs[\"cookie\"] \u003d str(kwargs[\"cookie\"]) + \"/-1\""},{"line_number":323,"context_line":"        flow_str \u003d \",\".join(\"\u003d\".join([key, str(val)])"},{"line_number":324,"context_line":"            for key, val in kwargs.items())"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_e239cdf3","line":322,"range":{"start_line":322,"start_character":35,"end_line":322,"end_character":56},"in_reply_to":"bae84128_bbf43587","updated":"2016-02-23 11:01:24.000000000","message":"Done","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8cfff639b4bc94945a903ef771f8bca1f13d8c87","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        super(OVSBridge, self).__init__()"},{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self._default_cookie \u003d generate_random_cookie()"},{"line_number":183,"context_line":"        self._reserved_cookies \u003d {self._default_cookie}"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":27,"id":"bae84128_c97bd7bc","line":182,"updated":"2016-02-24 07:14:23.000000000","message":"why to change the default?","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4f223038531f2663decdd229240daac0c401376c","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        super(OVSBridge, self).__init__()"},{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self._default_cookie \u003d generate_random_cookie()"},{"line_number":183,"context_line":"        self._reserved_cookies \u003d {self._default_cookie}"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":27,"id":"bae84128_6a870fb5","line":182,"in_reply_to":"bae84128_2b7fd0e0","updated":"2016-02-24 10:55:26.000000000","message":"have you confirmed it\u0027s ok for out of tree users of ovs_lib?","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"fdfe3192abb9eb50041da65b4cdca30a4c57fd45","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        super(OVSBridge, self).__init__()"},{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self._default_cookie \u003d generate_random_cookie()"},{"line_number":183,"context_line":"        self._reserved_cookies \u003d {self._default_cookie}"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":27,"id":"9aed3d3a_ed0c8b96","line":182,"in_reply_to":"bae84128_314ed6c1","updated":"2016-02-26 10:55:43.000000000","message":"Could we provide access via a property with a deprecation warning?","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ae2eaa62574234657a71f505ca3173da741e9e55","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        super(OVSBridge, self).__init__()"},{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self._default_cookie \u003d generate_random_cookie()"},{"line_number":183,"context_line":"        self._reserved_cookies \u003d {self._default_cookie}"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":27,"id":"bae84128_314ed6c1","line":182,"in_reply_to":"bae84128_4caaf586","updated":"2016-02-25 09:17:19.000000000","message":"No. I only mean that there is no reason to access the attribute unless you call set_agent_uuid_stamp() before that access. In which case it does not matter which initial value was generated for the default cookie.","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"0b5f22d80b758fd4abd555a531fbd536e190b13a","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        super(OVSBridge, self).__init__()"},{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self._default_cookie \u003d generate_random_cookie()"},{"line_number":183,"context_line":"        self._reserved_cookies \u003d {self._default_cookie}"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":27,"id":"bae84128_e1285d88","line":182,"in_reply_to":"bae84128_53f2c206","updated":"2016-02-24 12:40:40.000000000","message":"i meant the latter.\n\nout of tree code can create its own bridge,\nwhich is not managed by ovs-agent at all.\nif such a code happens to use cookies for its own purpose,\nthis change can break it.","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e6ffa02b25cab51d9301a569cd498adf36f08fa5","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        super(OVSBridge, self).__init__()"},{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self._default_cookie \u003d generate_random_cookie()"},{"line_number":183,"context_line":"        self._reserved_cookies \u003d {self._default_cookie}"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":27,"id":"bae84128_4caaf586","line":182,"in_reply_to":"bae84128_5c70070b","updated":"2016-02-25 01:04:47.000000000","message":"Ihar,\n\ndo you mean such an entity needs to be updated to call set_agent_uuid_stamp(0)?","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"7f21e73cc0375479979f8aae1a2fee858c577156","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        super(OVSBridge, self).__init__()"},{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self._default_cookie \u003d generate_random_cookie()"},{"line_number":183,"context_line":"        self._reserved_cookies \u003d {self._default_cookie}"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":27,"id":"bae84128_53f2c206","line":182,"in_reply_to":"bae84128_6a870fb5","updated":"2016-02-24 11:28:42.000000000","message":"for deprecating _set_agent_uuid_stamp() or generating the cookie in __init__()?\n\nlong story short out of tree users couldn\u0027t use it.\n\nThe only purpose the agent_uuid_stamp served was for the graceful restart feature which deleted flowids that didn\u0027t match the current session_id.\nThis means out of tree users wouldn\u0027t have been able to use it as neutron would delete their flows and they wouldn\u0027t have access to the sessions current flowid.","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"27d2eeb67b1231e01267ee07c070ac4ca4274e39","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        super(OVSBridge, self).__init__()"},{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self._default_cookie \u003d generate_random_cookie()"},{"line_number":183,"context_line":"        self._reserved_cookies \u003d {self._default_cookie}"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":27,"id":"bae84128_2b7fd0e0","line":182,"in_reply_to":"bae84128_c97bd7bc","updated":"2016-02-24 09:56:43.000000000","message":"The _default_cookie should be generated by the bridge. The previous versions of the code included adding an optional argument to set it, however this was only added to allow the ovs_agent_api to set the cookie value when it created new OVSBridge objects for extensions (as there was plans to deprecate set_agent_uuid_stamp()).","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"67c1f815c8a01a97b7dee546845928c538fa47ad","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        super(OVSBridge, self).__init__()"},{"line_number":180,"context_line":"        self.br_name \u003d br_name"},{"line_number":181,"context_line":"        self.datapath_type \u003d datapath_type"},{"line_number":182,"context_line":"        self._default_cookie \u003d generate_random_cookie()"},{"line_number":183,"context_line":"        self._reserved_cookies \u003d {self._default_cookie}"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":27,"id":"bae84128_5c70070b","line":182,"in_reply_to":"bae84128_e1285d88","updated":"2016-02-24 14:55:16.000000000","message":"I don\u0027t believe there should be a concern here. If an external entity relied on the value, it probably used it after calling to set_agent_uuid_stamp(). Otherwise there is no reason to access the attribute.","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e6ffa02b25cab51d9301a569cd498adf36f08fa5","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @property"},{"line_number":190,"context_line":"    def reserved_cookies(self):"},{"line_number":191,"context_line":"        return set(self._reserved_cookies)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":194,"context_line":"        self._reserved_cookies.remove(self._default_cookie)"}],"source_content_type":"text/x-python","patch_set":27,"id":"bae84128_4cb5d57c","line":191,"updated":"2016-02-25 01:04:47.000000000","message":"set() seems redundant.","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ae2eaa62574234657a71f505ca3173da741e9e55","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @property"},{"line_number":190,"context_line":"    def reserved_cookies(self):"},{"line_number":191,"context_line":"        return set(self._reserved_cookies)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":194,"context_line":"        self._reserved_cookies.remove(self._default_cookie)"}],"source_content_type":"text/x-python","patch_set":27,"id":"bae84128_f1daaee8","line":191,"in_reply_to":"bae84128_4cb5d57c","updated":"2016-02-25 09:17:19.000000000","message":"It\u0027s to copy the set, not allowing the caller to mess with it.","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"fdfe3192abb9eb50041da65b4cdca30a4c57fd45","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @property"},{"line_number":190,"context_line":"    def reserved_cookies(self):"},{"line_number":191,"context_line":"        return set(self._reserved_cookies)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":194,"context_line":"        self._reserved_cookies.remove(self._default_cookie)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9aed3d3a_0d244f0b","line":191,"in_reply_to":"bae84128_f1daaee8","updated":"2016-02-26 10:55:43.000000000","message":"Correct. +1 for keeping set.","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e6ffa02b25cab51d9301a569cd498adf36f08fa5","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    def reserved_cookies(self):"},{"line_number":191,"context_line":"        return set(self._reserved_cookies)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":194,"context_line":"        self._reserved_cookies.remove(self._default_cookie)"},{"line_number":195,"context_line":"        self._reserved_cookies.add(val)"},{"line_number":196,"context_line":"        self._default_cookie \u003d val"}],"source_content_type":"text/x-python","patch_set":27,"id":"bae84128_676432e5","line":193,"range":{"start_line":193,"start_character":8,"end_line":193,"end_character":28},"updated":"2016-02-25 01:04:47.000000000","message":"now set_default_cookie is more appropriate name i guess.","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ae2eaa62574234657a71f505ca3173da741e9e55","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    def reserved_cookies(self):"},{"line_number":191,"context_line":"        return set(self._reserved_cookies)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":194,"context_line":"        self._reserved_cookies.remove(self._default_cookie)"},{"line_number":195,"context_line":"        self._reserved_cookies.add(val)"},{"line_number":196,"context_line":"        self._default_cookie \u003d val"}],"source_content_type":"text/x-python","patch_set":27,"id":"bae84128_f1010e3b","line":193,"range":{"start_line":193,"start_character":8,"end_line":193,"end_character":28},"in_reply_to":"bae84128_676432e5","updated":"2016-02-25 09:17:19.000000000","message":"Could be. Though it would require deprecation path. I prefer we leave it for a follow up.","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"fdfe3192abb9eb50041da65b4cdca30a4c57fd45","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    def reserved_cookies(self):"},{"line_number":191,"context_line":"        return set(self._reserved_cookies)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def set_agent_uuid_stamp(self, val):"},{"line_number":194,"context_line":"        self._reserved_cookies.remove(self._default_cookie)"},{"line_number":195,"context_line":"        self._reserved_cookies.add(val)"},{"line_number":196,"context_line":"        self._default_cookie \u003d val"}],"source_content_type":"text/x-python","patch_set":27,"id":"9aed3d3a_8d65ff46","line":193,"range":{"start_line":193,"start_character":8,"end_line":193,"end_character":28},"in_reply_to":"bae84128_f1010e3b","updated":"2016-02-26 10:55:43.000000000","message":"Let\u0027s follow up if possible, this API is blocking other efforts.","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"}],"neutron/agent/l2/agent_api.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":22,"context_line":"class AgentAPI(object):"},{"line_number":23,"context_line":"    \"\"\"Define stable abstract interface for agent API extensions for"},{"line_number":24,"context_line":"    l2 agent API."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_2d5299de","line":22,"updated":"2016-01-20 12:49:29.000000000","message":"If there is nothing in common, why do we even need the abstract class?","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":22,"context_line":"class AgentAPI(object):"},{"line_number":23,"context_line":"    \"\"\"Define stable abstract interface for agent API extensions for"},{"line_number":24,"context_line":"    l2 agent API."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_7ce4bd0c","line":22,"in_reply_to":"9a68dd71_2d5299de","updated":"2016-01-20 15:44:40.000000000","message":"I\u0027ll remove it.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"}],"neutron/agent/l2/agent_extension.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        :param data: port data"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def consume_api(self, l2_api_ext):"},{"line_number":62,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_42afbd7c","line":61,"updated":"2016-01-15 10:30:39.000000000","message":"l2_api_ext -\u003e l2_agent_api, consume_api -\u003e consume_agent_api. Also, please add docstring.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def consume_api(self, l2_api_ext):"},{"line_number":62,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_6200c166","line":62,"updated":"2016-01-15 10:30:39.000000000","message":"nit: \u0027pass\u0027 would probably be more explicit of the intent.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        :param data: port data"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def consume_api(self, l2_agent_api):"},{"line_number":62,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_cd041dc8","line":61,"updated":"2016-01-20 12:49:29.000000000","message":"...or even just agent_api, since we are already in l2 agent context.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        :param data: port data"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def consume_api(self, l2_agent_api):"},{"line_number":62,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_7cffdd34","line":61,"in_reply_to":"9a68dd71_cd041dc8","updated":"2016-01-20 15:44:40.000000000","message":"Done","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"bd7b7c5acb2b7f8febaa6f17162260c468112ac9","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        :param data: port data"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def consume_api(self, agent_api):"},{"line_number":62,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_33ec4f29","line":61,"range":{"start_line":61,"start_character":8,"end_line":61,"end_character":19},"updated":"2016-01-25 21:43:55.000000000","message":"Can you provide documentation for this method?  \n\nAlso, add the abstractmethod decorator?","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        :param data: port data"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def consume_api(self, agent_api):"},{"line_number":62,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_9c95e789","line":61,"range":{"start_line":61,"start_character":8,"end_line":61,"end_character":19},"in_reply_to":"9a68dd71_33ec4f29","updated":"2016-01-26 13:08:41.000000000","message":"No, it can\u0027t be abstract since it should be defined for all extensions, even those that don\u0027t care about the agent API object (or those that were written before the new API was added).\n\n+ on adding docstring.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b65b7d1c62e02d6982a4661aee7d20c456d38e37","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        :param data: port data"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def consume_api(self, agent_api):"},{"line_number":62,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a5de9d1_daf4e0f1","line":61,"range":{"start_line":61,"start_character":4,"end_line":61,"end_character":37},"updated":"2016-02-02 05:53:42.000000000","message":"Please doc string.","commit_id":"50edc4a3f42a66f34e0d3e68c83fd6132f6cc88a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"fdff2c00b5f5a50f527c4c49473d97892a6d6415","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        :param data: port data"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def consume_api(self, agent_api):"},{"line_number":62,"context_line":"        \"\"\"Consume the AgentAPI instance from the ExtensionsManager"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        This allows extensions to gain access to resources limited to the"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_5014f442","line":61,"updated":"2016-02-04 10:59:34.000000000","message":"can\u0027t we use just the initialize part? , or pass it as part of __init__ ?\n\nIf we had to keep the method, may be set_api would be a better name.\n\n\nI understand, this allows backwards-compatibility, but we\u0027re still in a place where we can clean that up -later will be too late-, as the only extension is likely to be QoS, and we\u0027re on control of it.\n\n\nIf we finally decide to keep the method, please use set_api or something like that :)","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"c2862de3973d26329a307601db9e47c2d12ea190","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        :param data: port data"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def consume_api(self, agent_api):"},{"line_number":62,"context_line":"        \"\"\"Consume the AgentAPI instance from the ExtensionsManager"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        This allows extensions to gain access to resources limited to the"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_c9383640","line":61,"in_reply_to":"5a5ae5dd_5014f442","updated":"2016-02-04 15:10:59.000000000","message":"There are a few projects that are using this for Mitaka, SFC is the first that comes to mind (excluding QoS). However there are projects that are not using it so I want to avoid breaking projects that don\u0027t need this.","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fc32f0c6095350ca2f69fd12b4743f4ff5bc0178","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        :param data: port data"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def consume_api(self, agent_api):"},{"line_number":62,"context_line":"        \"\"\"Consume the AgentAPI instance from the ExtensionsManager"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        This allows extensions to gain access to resources limited to the"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_26fb067b","line":61,"in_reply_to":"5a5ae5dd_c9383640","updated":"2016-02-05 10:21:16.000000000","message":"Yes, the reason here is to leave extension __init__ signature intact.","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"a9a276842b6133c89a1581b770d1d44848ed10e5","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def consume_api(self, agent_api):"},{"line_number":62,"context_line":"        \"\"\"Consume the AgentAPI instance from the ExtensionsManager"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        This allows extensions to gain access to resources limited to the"},{"line_number":65,"context_line":"        NeutronAgent."}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_4fe4b7aa","line":62,"range":{"start_line":62,"start_character":50,"end_line":62,"end_character":67},"updated":"2016-02-08 17:27:13.000000000","message":"AgentExtensionsManager","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        :param agent_api: An instance of an agent specific API"},{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_202091f6","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":12},"updated":"2016-02-18 12:07:31.000000000","message":"\u0027pass\u0027 is not required as a doctrine is given.","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"d7990e57f8a0701648b16dffc7625b4d02d3dd84","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        :param agent_api: An instance of an agent specific API"},{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_6aedc424","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":12},"updated":"2016-02-22 19:34:43.000000000","message":"Pass statement is not required as a docstring is provided here.","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d0ef73d7b0b3793499639fe005fb75743bc8aea3","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        :param agent_api: An instance of an agent specific API"},{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_a2334513","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":12},"in_reply_to":"bae84128_6aedc424","updated":"2016-02-23 11:01:24.000000000","message":"Done","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"}],"neutron/agent/l2/agent_extension_api.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":22,"context_line":"class AgentExtensionAPI(object):"},{"line_number":23,"context_line":"    \"\"\"Define stable abstract interface for agent API extensions."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    An agent extension extends the agent core functionality."}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_6246817c","line":22,"updated":"2016-01-15 10:30:39.000000000","message":"We decided before it will use versioned objects.\n\nI suggest we rename the class to AgentAPI (and do the same with the file). In theory, the object could be used outside of extensions.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":22,"context_line":"class AgentExtensionAPI(object):"},{"line_number":23,"context_line":"    \"\"\"Define stable abstract interface for agent API extensions."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    An agent extension extends the agent core functionality."},{"line_number":26,"context_line":"    This API allows extensions to use agent resources."}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_dd14f0e9","line":23,"updated":"2016-01-15 10:30:39.000000000","message":"for L2 agent API.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class AgentExtensionAPI(object):"},{"line_number":23,"context_line":"    \"\"\"Define stable abstract interface for agent API extensions."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    An agent extension extends the agent core functionality."},{"line_number":26,"context_line":"    This API allows extensions to use agent resources."},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_ddc2b052","line":25,"updated":"2016-01-15 10:30:39.000000000","message":"Remove notions of extensions here. We should not assume a single usage for the class.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    This API allows extensions to use agent resources."},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def initialize(self):"},{"line_number":30,"context_line":"        \"\"\"Perform agent core API extension initialization.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_bd981b79","line":29,"updated":"2016-01-15 10:30:39.000000000","message":"Why do we need a separate initialize() method? Isn\u0027t __init__ enough?","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"}],"neutron/agent/l2/extensions/manager.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            invoke_on_load\u003dTrue, name_order\u003dTrue)"},{"line_number":44,"context_line":"        LOG.info(_LI(\"Loaded agent extensions: %s\"), self.names())"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def initialize(self, connection, driver_type, agent_api_ext\u003dNone):"},{"line_number":47,"context_line":"        \"\"\"Initialize enabled L2 agent extensions."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param connection: RPC connection that can be reused by extensions to"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_5d9b2066","line":46,"updated":"2016-01-15 10:30:39.000000000","message":"I suggest renaming agent_api_ext -\u003e agent_api","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        :param driver_type: a string that defines the agent type to the"},{"line_number":52,"context_line":"                            extension. Can be used by the extension to choose"},{"line_number":53,"context_line":"                            the right backend implementation."},{"line_number":54,"context_line":"        :param agent_api_ext: an object containing information from the agent"},{"line_number":55,"context_line":"                            that is required by extensions to perform tasks."},{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":"        # Initialize each agent extension in the list."}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_e2b83113","line":54,"updated":"2016-01-15 10:30:39.000000000","message":"please specify the type for the argument. Also, it\u0027s not \u0027containing information\u0027, it provides API to interact with the agent that the manager is running in.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                            extension. Can be used by the extension to choose"},{"line_number":53,"context_line":"                            the right backend implementation."},{"line_number":54,"context_line":"        :param agent_api_ext: an object containing information from the agent"},{"line_number":55,"context_line":"                            that is required by extensions to perform tasks."},{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":"        # Initialize each agent extension in the list."},{"line_number":58,"context_line":"        for extension in self:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_82a4d5b9","line":55,"updated":"2016-01-15 10:30:39.000000000","message":"It\u0027s not \u0027required\u0027, it \u0027can be used\u0027.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        # Initialize each agent extension in the list."},{"line_number":58,"context_line":"        for extension in self:"},{"line_number":59,"context_line":"            LOG.info(_LI(\"Initializing agent extension \u0027%s\u0027\"), extension.name)"},{"line_number":60,"context_line":"            if agent_api_ext:"},{"line_number":61,"context_line":"                extension.obj.consume_api(agent_api_ext)"},{"line_number":62,"context_line":"            extension.obj.initialize(connection, driver_type)"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_c2e64d43","line":60,"updated":"2016-01-15 10:30:39.000000000","message":"Why do we want to check it here? I think it\u0027s ok to allow the extension to decide whether it wants to know that it\u0027s running without an agent API object.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        :param driver_type: a string that defines the agent type to the"},{"line_number":52,"context_line":"                            extension. Can be used by the extension to choose"},{"line_number":53,"context_line":"                            the right backend implementation."},{"line_number":54,"context_line":"        :param agent_api_ext: an AgentAPI object that provides an API to"},{"line_number":55,"context_line":"                              interact with the agent that the manager"},{"line_number":56,"context_line":"                              is running in."},{"line_number":57,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_ad13e90c","line":54,"updated":"2016-01-20 12:49:29.000000000","message":"param name is wrong","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        :param driver_type: a string that defines the agent type to the"},{"line_number":52,"context_line":"                            extension. Can be used by the extension to choose"},{"line_number":53,"context_line":"                            the right backend implementation."},{"line_number":54,"context_line":"        :param agent_api_ext: an AgentAPI object that provides an API to"},{"line_number":55,"context_line":"                              interact with the agent that the manager"},{"line_number":56,"context_line":"                              is running in."},{"line_number":57,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_9cb5f17f","line":54,"in_reply_to":"9a68dd71_ad13e90c","updated":"2016-01-20 15:44:40.000000000","message":"Done","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"bd7b7c5acb2b7f8febaa6f17162260c468112ac9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        :param driver_type: a string that defines the agent type to the"},{"line_number":52,"context_line":"                            extension. Can be used by the extension to choose"},{"line_number":53,"context_line":"                            the right backend implementation."},{"line_number":54,"context_line":"        :param agent_api: an AgentAPI object that provides an API to"},{"line_number":55,"context_line":"                              interact with the agent that the manager"},{"line_number":56,"context_line":"                              is running in."},{"line_number":57,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_169ed4b8","line":54,"range":{"start_line":54,"start_character":38,"end_line":54,"end_character":44},"updated":"2016-01-25 21:43:55.000000000","message":"Suggest making it clear that this is an instance rather than a class.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        :param driver_type: a string that defines the agent type to the"},{"line_number":52,"context_line":"                            extension. Can be used by the extension to choose"},{"line_number":53,"context_line":"                            the right backend implementation."},{"line_number":54,"context_line":"        :param agent_api: an AgentAPI object that provides an API to"},{"line_number":55,"context_line":"                              interact with the agent that the manager"},{"line_number":56,"context_line":"                              is running in."},{"line_number":57,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_3cd4fb45","line":54,"range":{"start_line":54,"start_character":38,"end_line":54,"end_character":44},"in_reply_to":"9a68dd71_169ed4b8","updated":"2016-01-26 13:08:41.000000000","message":"I thought \u0027object\u0027 implies it\u0027s a class. At least in common usage.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"b4c9cc2c2aff37143593271852f6e1a75dd9afe3","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        :param driver_type: a string that defines the agent type to the"},{"line_number":52,"context_line":"                            extension. Can be used by the extension to choose"},{"line_number":53,"context_line":"                            the right backend implementation."},{"line_number":54,"context_line":"        :param agent_api: an AgentAPI object that provides an API to"},{"line_number":55,"context_line":"                              interact with the agent that the manager"},{"line_number":56,"context_line":"                              is running in."},{"line_number":57,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_c88159c5","line":54,"range":{"start_line":54,"start_character":38,"end_line":54,"end_character":44},"in_reply_to":"9a68dd71_3cd4fb45","updated":"2016-01-26 14:15:11.000000000","message":"Yes, I think it may, and I think that\u0027s a mistake, so all the more reason to be precise.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"e469f3b6ac16ff3abaf0368515d2b4a74aaf79b1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        :param driver_type: a string that defines the agent type to the"},{"line_number":52,"context_line":"                            extension. Can be used by the extension to choose"},{"line_number":53,"context_line":"                            the right backend implementation."},{"line_number":54,"context_line":"        :param agent_api: an AgentAPI object that provides an API to"},{"line_number":55,"context_line":"                              interact with the agent that the manager"},{"line_number":56,"context_line":"                              is running in."},{"line_number":57,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_6e54f520","line":54,"range":{"start_line":54,"start_character":38,"end_line":54,"end_character":44},"in_reply_to":"9a68dd71_c88159c5","updated":"2016-01-26 14:27:28.000000000","message":"I think my response was flippant.  Sorry about that.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"fdff2c00b5f5a50f527c4c49473d97892a6d6415","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        # Initialize each agent extension in the list."},{"line_number":59,"context_line":"        for extension in self:"},{"line_number":60,"context_line":"            LOG.info(_LI(\"Initializing agent extension \u0027%s\u0027\"), extension.name)"},{"line_number":61,"context_line":"            extension.obj.consume_api(agent_api)"},{"line_number":62,"context_line":"            extension.obj.initialize(connection, driver_type)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def handle_port(self, context, data):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_b08688d9","line":61,"updated":"2016-02-04 10:59:34.000000000","message":"I was thinking, that probably the extension receiving the API shall check it\u0027s the correct type of API (so OVS extension won\u0027t be used on LB, etc... if they require an specific type of API), and we will get a reasonable error like \"This extension does not work in this agent...\" instead of \"method blah_blah_blah not found...\".\n\nThoughts?","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e7782d3d8a280a7a9c8990c9a5b1e8976d9260a1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        # Initialize each agent extension in the list."},{"line_number":59,"context_line":"        for extension in self:"},{"line_number":60,"context_line":"            LOG.info(_LI(\"Initializing agent extension \u0027%s\u0027\"), extension.name)"},{"line_number":61,"context_line":"            extension.obj.consume_api(agent_api)"},{"line_number":62,"context_line":"            extension.obj.initialize(connection, driver_type)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def handle_port(self, context, data):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_b796423d","line":61,"in_reply_to":"5a5ae5dd_0645aab1","updated":"2016-02-05 11:26:23.000000000","message":"I\u0027d probably follow up with some generic mechanism to do such thing, but I\u0027m fine with iterating.","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e7782d3d8a280a7a9c8990c9a5b1e8976d9260a1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        # Initialize each agent extension in the list."},{"line_number":59,"context_line":"        for extension in self:"},{"line_number":60,"context_line":"            LOG.info(_LI(\"Initializing agent extension \u0027%s\u0027\"), extension.name)"},{"line_number":61,"context_line":"            extension.obj.consume_api(agent_api)"},{"line_number":62,"context_line":"            extension.obj.initialize(connection, driver_type)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def handle_port(self, context, data):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_177f1616","line":61,"in_reply_to":"5a5ae5dd_7a78eac4","updated":"2016-02-05 11:26:23.000000000","message":"But you could still configure the wrong extension in the agent file.","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fc32f0c6095350ca2f69fd12b4743f4ff5bc0178","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        # Initialize each agent extension in the list."},{"line_number":59,"context_line":"        for extension in self:"},{"line_number":60,"context_line":"            LOG.info(_LI(\"Initializing agent extension \u0027%s\u0027\"), extension.name)"},{"line_number":61,"context_line":"            extension.obj.consume_api(agent_api)"},{"line_number":62,"context_line":"            extension.obj.initialize(connection, driver_type)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def handle_port(self, context, data):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_0645aab1","line":61,"in_reply_to":"5a5ae5dd_7a78eac4","updated":"2016-02-05 10:21:16.000000000","message":"Extensions may want to do such a check, though it\u0027s indeed quite worthless. The patch does not scope any extension specific checks.","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"c2862de3973d26329a307601db9e47c2d12ea190","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        # Initialize each agent extension in the list."},{"line_number":59,"context_line":"        for extension in self:"},{"line_number":60,"context_line":"            LOG.info(_LI(\"Initializing agent extension \u0027%s\u0027\"), extension.name)"},{"line_number":61,"context_line":"            extension.obj.consume_api(agent_api)"},{"line_number":62,"context_line":"            extension.obj.initialize(connection, driver_type)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def handle_port(self, context, data):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_7a78eac4","line":61,"in_reply_to":"5a5ae5dd_b08688d9","updated":"2016-02-04 15:10:59.000000000","message":"I don\u0027t think there could be a scenario where the wrong API object is sent to the wrong driver. If I understand this correctly, if you had OvS and linux bridge agents at the same time the agents have separate AgentExtensionsManagers, correct?","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2e417f8624ae2792bb4fd72eb855c12ea5898d4b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        # Initialize each agent extension in the list."},{"line_number":59,"context_line":"        for extension in self:"},{"line_number":60,"context_line":"            LOG.info(_LI(\"Initializing agent extension \u0027%s\u0027\"), extension.name)"},{"line_number":61,"context_line":"            extension.obj.consume_api(agent_api)"},{"line_number":62,"context_line":"            extension.obj.initialize(connection, driver_type)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def handle_port(self, context, data):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_35a221fe","line":61,"in_reply_to":"5a5ae5dd_b796423d","updated":"2016-02-06 16:03:16.000000000","message":"Well, if your extension relies on specific agent type, it can already do the check now, since we pass the type name into extensions.","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"fdff2c00b5f5a50f527c4c49473d97892a6d6415","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        for extension in self:"},{"line_number":60,"context_line":"            LOG.info(_LI(\"Initializing agent extension \u0027%s\u0027\"), extension.name)"},{"line_number":61,"context_line":"            extension.obj.consume_api(agent_api)"},{"line_number":62,"context_line":"            extension.obj.initialize(connection, driver_type)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def handle_port(self, context, data):"},{"line_number":65,"context_line":"        \"\"\"Notify all agent extensions to handle port.\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_503b94d1","line":62,"updated":"2016-02-04 10:59:34.000000000","message":"why not just moving it to initialize? :)\n\n(see my backwards compat comment on the previous file)","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"c2862de3973d26329a307601db9e47c2d12ea190","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        for extension in self:"},{"line_number":60,"context_line":"            LOG.info(_LI(\"Initializing agent extension \u0027%s\u0027\"), extension.name)"},{"line_number":61,"context_line":"            extension.obj.consume_api(agent_api)"},{"line_number":62,"context_line":"            extension.obj.initialize(connection, driver_type)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def handle_port(self, context, data):"},{"line_number":65,"context_line":"        \"\"\"Notify all agent extensions to handle port.\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_bda5fc04","line":62,"in_reply_to":"5a5ae5dd_503b94d1","updated":"2016-02-04 15:10:59.000000000","message":"Any non Neutron projects that adds an l2 extension would break when it merged, I tried that early on but decided to change to this.","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e7782d3d8a280a7a9c8990c9a5b1e8976d9260a1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        for extension in self:"},{"line_number":60,"context_line":"            LOG.info(_LI(\"Initializing agent extension \u0027%s\u0027\"), extension.name)"},{"line_number":61,"context_line":"            extension.obj.consume_api(agent_api)"},{"line_number":62,"context_line":"            extension.obj.initialize(connection, driver_type)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def handle_port(self, context, data):"},{"line_number":65,"context_line":"        \"\"\"Notify all agent extensions to handle port.\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_37a3329f","line":62,"in_reply_to":"5a5ae5dd_bda5fc04","updated":"2016-02-05 11:26:23.000000000","message":"ack","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"}],"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/br_cookie.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"15e5c4ac7225b3bd34104d566c788298aa4e4d83","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import uuid"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"UINT64_BITMASK \u003d (1 \u003c\u003c 64) - 1"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class OVSBridgeCookieMixin(object):"}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_db4019a8","line":18,"updated":"2016-02-22 16:43:36.000000000","message":"Should we instead reuse the constant from ovs_lib module?","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d0ef73d7b0b3793499639fe005fb75743bc8aea3","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import uuid"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"UINT64_BITMASK \u003d (1 \u003c\u003c 64) - 1"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class OVSBridgeCookieMixin(object):"}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_c2476975","line":18,"in_reply_to":"bae84128_db4019a8","updated":"2016-02-23 11:01:24.000000000","message":"Done","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"15e5c4ac7225b3bd34104d566c788298aa4e4d83","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \u0027\u0027\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _generate_random_cookie(self):"},{"line_number":27,"context_line":"        return uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def request_cookie(self):"},{"line_number":30,"context_line":"        uuid_stamp \u003d self._generate_random_cookie()"}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_bb2275ff","line":27,"updated":"2016-02-22 16:43:36.000000000","message":"This code is duplicated in ovs_lib, so I guess it\u0027s better to have a common helper method somewhere and reuse it in both places.","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d0ef73d7b0b3793499639fe005fb75743bc8aea3","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \u0027\u0027\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _generate_random_cookie(self):"},{"line_number":27,"context_line":"        return uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def request_cookie(self):"},{"line_number":30,"context_line":"        uuid_stamp \u003d self._generate_random_cookie()"}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_2261f505","line":27,"in_reply_to":"bae84128_bb2275ff","updated":"2016-02-23 11:01:24.000000000","message":"Done","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e6ffa02b25cab51d9301a569cd498adf36f08fa5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class OVSBridgeCookieMixin(object):"},{"line_number":20,"context_line":"    \u0027\u0027\u0027Mixin to provide cookie retention functionality"},{"line_number":21,"context_line":"    to the OVSAgentBridge"},{"line_number":22,"context_line":"    \u0027\u0027\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def request_cookie(self):"},{"line_number":25,"context_line":"        uuid_stamp \u003d ovs_lib.generate_random_cookie()"}],"source_content_type":"text/x-python","patch_set":27,"id":"bae84128_6736f2e8","line":22,"updated":"2016-02-25 01:04:47.000000000","message":"thank you for creating this mixin.\n\nit\u0027s cleaner if you move _reserved_cookie handling here.","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d4ef3a04140a64ff76b980fcf3f378e0ba7ccbb1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class OVSBridgeCookieMixin(object):"},{"line_number":20,"context_line":"    \u0027\u0027\u0027Mixin to provide cookie retention functionality"},{"line_number":21,"context_line":"    to the OVSAgentBridge"},{"line_number":22,"context_line":"    \u0027\u0027\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def request_cookie(self):"},{"line_number":25,"context_line":"        uuid_stamp \u003d ovs_lib.generate_random_cookie()"}],"source_content_type":"text/x-python","patch_set":27,"id":"bae84128_a6e3cb04","line":22,"in_reply_to":"bae84128_5199da1e","updated":"2016-02-25 09:46:46.000000000","message":"I\u0027d need to add checks in request_cookie and reserved_cookie to make sure the default_cookie is in _request_cookie. Is that ok?","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ae2eaa62574234657a71f505ca3173da741e9e55","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class OVSBridgeCookieMixin(object):"},{"line_number":20,"context_line":"    \u0027\u0027\u0027Mixin to provide cookie retention functionality"},{"line_number":21,"context_line":"    to the OVSAgentBridge"},{"line_number":22,"context_line":"    \u0027\u0027\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def request_cookie(self):"},{"line_number":25,"context_line":"        uuid_stamp \u003d ovs_lib.generate_random_cookie()"}],"source_content_type":"text/x-python","patch_set":27,"id":"bae84128_5199da1e","line":22,"in_reply_to":"bae84128_6736f2e8","updated":"2016-02-25 09:17:19.000000000","message":"Yes, probably you are right.","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"60e8d7c6b8db07a83ba8dae65fbb057d4988f461","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    \u0027\u0027\u0027Mixin to provide cookie retention functionality"},{"line_number":21,"context_line":"    to the OVSAgentBridge"},{"line_number":22,"context_line":"    \u0027\u0027\u0027"},{"line_number":23,"context_line":"    _reserved_cookies \u003d set()"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @property"},{"line_number":26,"context_line":"    def reserved_cookies(self):"}],"source_content_type":"text/x-python","patch_set":28,"id":"9aed3d3a_3b1b3c1d","line":23,"updated":"2016-02-26 14:19:08.000000000","message":"I don\u0027t think it\u0027s wise to define it as a class attribute. Multiple bridges will reuse the same set, which is probably not ideal.","commit_id":"763fb916afc0d7e9b03607cbcce8f601d1b4cf0e"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"04d5fd2ceee0b7bad23c7d54649d6fe4fa51f37b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    \u0027\u0027\u0027Mixin to provide cookie retention functionality"},{"line_number":21,"context_line":"    to the OVSAgentBridge"},{"line_number":22,"context_line":"    \u0027\u0027\u0027"},{"line_number":23,"context_line":"    _reserved_cookies \u003d set()"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @property"},{"line_number":26,"context_line":"    def reserved_cookies(self):"}],"source_content_type":"text/x-python","patch_set":28,"id":"9aed3d3a_dd2e83f9","line":23,"in_reply_to":"9aed3d3a_3b1b3c1d","updated":"2016-02-26 15:03:44.000000000","message":"Done","commit_id":"763fb916afc0d7e9b03607cbcce8f601d1b4cf0e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"60e8d7c6b8db07a83ba8dae65fbb057d4988f461","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self._reserved_cookies.add(val)"},{"line_number":43,"context_line":"        if self._default_cookie in self._reserved_cookies:"},{"line_number":44,"context_line":"            self._reserved_cookies.remove(self._default_cookie)"},{"line_number":45,"context_line":"        self._default_cookie \u003d val"}],"source_content_type":"text/x-python","patch_set":28,"id":"9aed3d3a_3bc97c79","line":45,"updated":"2016-02-26 14:19:08.000000000","message":"that thing could be left to super class.","commit_id":"763fb916afc0d7e9b03607cbcce8f601d1b4cf0e"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"04d5fd2ceee0b7bad23c7d54649d6fe4fa51f37b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self._reserved_cookies.add(val)"},{"line_number":43,"context_line":"        if self._default_cookie in self._reserved_cookies:"},{"line_number":44,"context_line":"            self._reserved_cookies.remove(self._default_cookie)"},{"line_number":45,"context_line":"        self._default_cookie \u003d val"}],"source_content_type":"text/x-python","patch_set":28,"id":"9aed3d3a_9deebbb2","line":45,"in_reply_to":"9aed3d3a_3bc97c79","updated":"2016-02-26 15:03:44.000000000","message":"This class doesn\u0027t inherit from OVSBridge so I don\u0027t think it can use super. This just overrides set_agent_uuid_stamp when they are mixed into OVSAgentBridge.","commit_id":"763fb916afc0d7e9b03607cbcce8f601d1b4cf0e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"103ebf8655557a352cef618bb55dc1921263604c","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @property"},{"line_number":25,"context_line":"    def reserved_cookies(self):"},{"line_number":26,"context_line":"        self._check_reserved_cookies()"},{"line_number":27,"context_line":"        if self._default_cookie not in self._reserved_cookies:"},{"line_number":28,"context_line":"            self._reserved_cookies.add(self._default_cookie)"},{"line_number":29,"context_line":"        return set(self._reserved_cookies)"}],"source_content_type":"text/x-python","patch_set":29,"id":"9aed3d3a_8c732b80","line":26,"updated":"2016-02-26 16:09:38.000000000","message":"That initialization would belong to __init__ instead. Just make sure that after you set it there, you call to super().__init__","commit_id":"b059299c296d9e1427b5e560e0b74b2b79776b4a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"103ebf8655557a352cef618bb55dc1921263604c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self._reserved_cookies.add(val)"},{"line_number":45,"context_line":"        if self._default_cookie in self._reserved_cookies:"},{"line_number":46,"context_line":"            self._reserved_cookies.remove(self._default_cookie)"},{"line_number":47,"context_line":"        self._default_cookie \u003d val"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def _check_reserved_cookies(self):"},{"line_number":50,"context_line":"        if not hasattr(self, \u0027_reserved_cookies\u0027):"}],"source_content_type":"text/x-python","patch_set":29,"id":"9aed3d3a_2c2adf2c","line":47,"updated":"2016-02-26 16:09:38.000000000","message":"There is no reason not to call to super() here anyway. Even though mixin does not directly inherit from OVSBridge, super() will make sure we call to the proper implementation from MRO, in case it exists.","commit_id":"b059299c296d9e1427b5e560e0b74b2b79776b4a"}],"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/br_tun.py":[{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        ]"},{"line_number":109,"context_line":"        actions \u003d ["},{"line_number":110,"context_line":"            ofpp.NXActionLearn(table_id\u003dconstants.UCAST_TO_TUN,"},{"line_number":111,"context_line":"                               cookie\u003dself.get_default_cookie(),"},{"line_number":112,"context_line":"                               priority\u003d1,"},{"line_number":113,"context_line":"                               hard_timeout\u003d300,"},{"line_number":114,"context_line":"                               specs\u003dflow_specs),"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_99b5987f","line":111,"range":{"start_line":111,"start_character":43,"end_line":111,"end_character":61},"updated":"2016-02-18 12:07:31.000000000","message":"If you make a property this would be\n\nself.default_cookie,","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"}],"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/ofswitch.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    def cleanup_flows(self):"},{"line_number":138,"context_line":"        cookies \u003d set([f.cookie for f in self.dump_flows()])"},{"line_number":139,"context_line":"        for c in cookies:"},{"line_number":140,"context_line":"            if c \u003d\u003d self.agent_uuid_stamp or c in self.ext_uuid_stamps:"},{"line_number":141,"context_line":"                continue"},{"line_number":142,"context_line":"            LOG.warn(_LW(\"Deleting flow with cookie 0x%(cookie)x\") % {"},{"line_number":143,"context_line":"                \u0027cookie\u0027: c})"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_e229119c","line":140,"updated":"2016-01-15 10:30:39.000000000","message":"If we would introduce a method to determine whether a stamp value is \u0027known\u0027 to OVSBridge, we would call it here instead of checking in two attributes.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    def cleanup_flows(self):"},{"line_number":138,"context_line":"        cookies \u003d set([f.cookie for f in self.dump_flows()])"},{"line_number":139,"context_line":"        for c in cookies:"},{"line_number":140,"context_line":"            if c in self.agent_stamps:"},{"line_number":141,"context_line":"                continue"},{"line_number":142,"context_line":"            LOG.warn(_LW(\"Deleting flow with cookie 0x%(cookie)x\") % {"},{"line_number":143,"context_line":"                \u0027cookie\u0027: c})"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_2d73794f","line":140,"updated":"2016-01-20 12:49:29.000000000","message":"I think it\u0027s worth to have a level of indirection here (instead of accessing the list directly, have a method that returns the list). In that way, we will be more free in the future if modifications are needed to the way we extract the list.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    def cleanup_flows(self):"},{"line_number":138,"context_line":"        cookies \u003d set([f.cookie for f in self.dump_flows()])"},{"line_number":139,"context_line":"        for c in cookies:"},{"line_number":140,"context_line":"            if c in self.agent_stamps:"},{"line_number":141,"context_line":"                continue"},{"line_number":142,"context_line":"            LOG.warn(_LW(\"Deleting flow with cookie 0x%(cookie)x\") % {"},{"line_number":143,"context_line":"                \u0027cookie\u0027: c})"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_305509c6","line":140,"in_reply_to":"9a68dd71_2d73794f","updated":"2016-01-20 15:44:40.000000000","message":"Done","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"fdff2c00b5f5a50f527c4c49473d97892a6d6415","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    def cleanup_flows(self):"},{"line_number":138,"context_line":"        cookies \u003d set([f.cookie for f in self.dump_flows()])"},{"line_number":139,"context_line":"        for c in cookies:"},{"line_number":140,"context_line":"            if c in self.get_reserved_cookies():"},{"line_number":141,"context_line":"                continue"},{"line_number":142,"context_line":"            LOG.warn(_LW(\"Deleting flow with cookie 0x%(cookie)x\") % {"},{"line_number":143,"context_line":"                \u0027cookie\u0027: c})"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_706490e4","line":140,"updated":"2016-02-04 10:59:34.000000000","message":"preserved_cookies looks much better :)","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e7782d3d8a280a7a9c8990c9a5b1e8976d9260a1","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    def cleanup_flows(self):"},{"line_number":138,"context_line":"        cookies \u003d set([f.cookie for f in self.dump_flows()])"},{"line_number":139,"context_line":"        for c in cookies:"},{"line_number":140,"context_line":"            if c in self.get_reserved_cookies():"},{"line_number":141,"context_line":"                continue"},{"line_number":142,"context_line":"            LOG.warn(_LW(\"Deleting flow with cookie 0x%(cookie)x\") % {"},{"line_number":143,"context_line":"                \u0027cookie\u0027: c})"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_d7d97e23","line":140,"in_reply_to":"5a5ae5dd_2670e60a","updated":"2016-02-05 11:26:23.000000000","message":"If it\u0027s reserved for certain features, we could *now* introduce a MAP to know which feature uses which cookies. (That could be included in logs/reports to be used for debug).","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"c2862de3973d26329a307601db9e47c2d12ea190","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    def cleanup_flows(self):"},{"line_number":138,"context_line":"        cookies \u003d set([f.cookie for f in self.dump_flows()])"},{"line_number":139,"context_line":"        for c in cookies:"},{"line_number":140,"context_line":"            if c in self.get_reserved_cookies():"},{"line_number":141,"context_line":"                continue"},{"line_number":142,"context_line":"            LOG.warn(_LW(\"Deleting flow with cookie 0x%(cookie)x\") % {"},{"line_number":143,"context_line":"                \u0027cookie\u0027: c})"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_d7cbf01c","line":140,"in_reply_to":"5a5ae5dd_706490e4","updated":"2016-02-04 15:10:59.000000000","message":"Done","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fc32f0c6095350ca2f69fd12b4743f4ff5bc0178","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    def cleanup_flows(self):"},{"line_number":138,"context_line":"        cookies \u003d set([f.cookie for f in self.dump_flows()])"},{"line_number":139,"context_line":"        for c in cookies:"},{"line_number":140,"context_line":"            if c in self.get_reserved_cookies():"},{"line_number":141,"context_line":"                continue"},{"line_number":142,"context_line":"            LOG.warn(_LW(\"Deleting flow with cookie 0x%(cookie)x\") % {"},{"line_number":143,"context_line":"                \u0027cookie\u0027: c})"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_2670e60a","line":140,"in_reply_to":"5a5ae5dd_d7cbf01c","updated":"2016-02-05 10:21:16.000000000","message":"I am sorry, but no. the cookies are not just for flow \u0027preservation\u0027, but also for flow \u0027differentiation\u0027.","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2e417f8624ae2792bb4fd72eb855c12ea5898d4b","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    def cleanup_flows(self):"},{"line_number":138,"context_line":"        cookies \u003d set([f.cookie for f in self.dump_flows()])"},{"line_number":139,"context_line":"        for c in cookies:"},{"line_number":140,"context_line":"            if c in self.get_reserved_cookies():"},{"line_number":141,"context_line":"                continue"},{"line_number":142,"context_line":"            LOG.warn(_LW(\"Deleting flow with cookie 0x%(cookie)x\") % {"},{"line_number":143,"context_line":"                \u0027cookie\u0027: c})"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_f5a7a908","line":140,"in_reply_to":"5a5ae5dd_d7d97e23","updated":"2016-02-06 16:03:16.000000000","message":"That\u0027s fine with me, as long as it\u0027s not bridge that tracks it. And let\u0027s leave it out of scope for the patch.","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        cookies \u003d set([f.cookie for f in self.dump_flows()])"},{"line_number":139,"context_line":"        for c in cookies:"},{"line_number":140,"context_line":"            if c in self.get_reserved_cookies():"},{"line_number":141,"context_line":"                continue"},{"line_number":142,"context_line":"            LOG.warn(_LW(\"Deleting flow with cookie 0x%(cookie)x\") % {"},{"line_number":143,"context_line":"                \u0027cookie\u0027: c})"},{"line_number":144,"context_line":"            self.delete_flows(cookie\u003dc, cookie_mask\u003d((1 \u003c\u003c 64) - 1))"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_40503532","line":141,"range":{"start_line":141,"start_character":16,"end_line":141,"end_character":24},"updated":"2016-02-18 12:07:31.000000000","message":"This should be easier to read and faster instead of using continue statement:\n\ncookies \u003d {f.cookie for f in self.dump_flows()} - self.reserved_cookies\nfor c in cookies:\n    LOG.warn(\n         _LW(\"Deleting flows with cookie: 0x%(cookie)x\u0027),\n         {\u0027cookie\u0027: c})\n    self.delete_flows(cookie\u003dc, cookie_mask\u003dovs_lib.UINT64_BITMASK)","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        match \u003d self._match(ofp, ofpp, match, **match_kwargs)"},{"line_number":183,"context_line":"        msg \u003d ofpp.OFPFlowMod(dp,"},{"line_number":184,"context_line":"                              table_id\u003dtable_id,"},{"line_number":185,"context_line":"                              cookie\u003dself.get_default_cookie(),"},{"line_number":186,"context_line":"                              match\u003dmatch,"},{"line_number":187,"context_line":"                              priority\u003dpriority,"},{"line_number":188,"context_line":"                              instructions\u003dinstructions)"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_f414abe9","line":185,"range":{"start_line":185,"start_character":37,"end_line":185,"end_character":62},"updated":"2016-02-18 12:07:31.000000000","message":"cookie\u003dself.default_cookie,","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"353060a8bd9ae79893f398171c4438eb5b648f24","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    def cleanup_flows(self):"},{"line_number":138,"context_line":"        cookies \u003d set([f.cookie for f in self.dump_flows()])"},{"line_number":139,"context_line":"        for c in cookies:"},{"line_number":140,"context_line":"            if c in self.reserved_cookies:"},{"line_number":141,"context_line":"                continue"},{"line_number":142,"context_line":"            LOG.warn(_LW(\"Deleting flow with cookie 0x%(cookie)x\") % {"},{"line_number":143,"context_line":"                \u0027cookie\u0027: c})"}],"source_content_type":"text/x-python","patch_set":23,"id":"dae33548_e284d2d3","line":140,"range":{"start_line":140,"start_character":12,"end_line":140,"end_character":41},"updated":"2016-02-18 18:45:53.000000000","message":"This is creating a copy of a set for each c in cookies.\nRemove from cookies set reserved cookies once at the beginning:\n\ncookies \u003d {f.cookie for f in self.dump_flows()} - self.reserved_cookies\n\nthen remove this line and continue.\n\nfor c in cookies:\n    LOG.warning(\n        _LW(\"Deleting flow with cookie 0x%(cookie)x\"),\n                {\u0027cookie\u0027: c})\n     self.delete_flows(cookie, cookie_mask\u003dovs_lib.UINT64_BITMASK)\n\nPlease note that you shouldn\u0027t use % operator with loggers. Leave them doing it for you as the would format the message only when it is required.","commit_id":"fcf624ab120f02ea328935747857428a1595a76f"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"d7990e57f8a0701648b16dffc7625b4d02d3dd84","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        return flows"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def cleanup_flows(self):"},{"line_number":138,"context_line":"        cookies \u003d set([f.cookie for f in self.dump_flows()])"},{"line_number":139,"context_line":"        cookie_list \u003d self.reserved_cookies"},{"line_number":140,"context_line":"        for c in cookies:"},{"line_number":141,"context_line":"            if c in cookie_list:"},{"line_number":142,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_4af3a0d6","line":139,"range":{"start_line":138,"start_character":0,"end_line":139,"end_character":43},"updated":"2016-02-22 19:34:43.000000000","message":"Sets support difference operations. Please use it and iterate over the result.\n\ncookies \u003d set([f.cookie for f in self.dump_flows()]) - self.reserved_cookies","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d0ef73d7b0b3793499639fe005fb75743bc8aea3","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        return flows"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def cleanup_flows(self):"},{"line_number":138,"context_line":"        cookies \u003d set([f.cookie for f in self.dump_flows()])"},{"line_number":139,"context_line":"        cookie_list \u003d self.reserved_cookies"},{"line_number":140,"context_line":"        for c in cookies:"},{"line_number":141,"context_line":"            if c in cookie_list:"},{"line_number":142,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_427d19b0","line":139,"range":{"start_line":138,"start_character":0,"end_line":139,"end_character":43},"in_reply_to":"bae84128_4af3a0d6","updated":"2016-02-23 11:01:24.000000000","message":"Done","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"}],"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/ovs_bridge.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"60e8d7c6b8db07a83ba8dae65fbb057d4988f461","unresolved":false,"context_lines":[{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class OVSAgentBridge(br_cookie.OVSBridgeCookieMixin, ofswitch."},{"line_number":34,"context_line":"                     OpenFlowSwitchMixin, ovs_lib.OVSBridge):"},{"line_number":35,"context_line":"    \"\"\"Common code for bridges used by OVS agent\"\"\""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"9aed3d3a_9bb088f6","line":33,"updated":"2016-02-26 14:19:08.000000000","message":"can we avoid splitting at the dot?","commit_id":"763fb916afc0d7e9b03607cbcce8f601d1b4cf0e"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"04d5fd2ceee0b7bad23c7d54649d6fe4fa51f37b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class OVSAgentBridge(br_cookie.OVSBridgeCookieMixin, ofswitch."},{"line_number":34,"context_line":"                     OpenFlowSwitchMixin, ovs_lib.OVSBridge):"},{"line_number":35,"context_line":"    \"\"\"Common code for bridges used by OVS agent\"\"\""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"9aed3d3a_bd4a9fc3","line":33,"in_reply_to":"9aed3d3a_9bb088f6","updated":"2016-02-26 15:03:44.000000000","message":"Done","commit_id":"763fb916afc0d7e9b03607cbcce8f601d1b4cf0e"}],"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/ovs_ofctl/br_tun.py":[{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                            \"load:0-\u003eNXM_OF_VLAN_TCI[],\""},{"line_number":108,"context_line":"                            \"load:NXM_NX_TUN_ID[]-\u003eNXM_NX_TUN_ID[],\""},{"line_number":109,"context_line":"                            \"output:NXM_OF_IN_PORT[]\" %"},{"line_number":110,"context_line":"                            {\u0027cookie\u0027: self.get_default_cookie(),"},{"line_number":111,"context_line":"                             \u0027table\u0027: constants.UCAST_TO_TUN})"},{"line_number":112,"context_line":"            # Once remote mac addresses are learnt, output packet to patch_int"},{"line_number":113,"context_line":"            deferred_br.add_flow(table\u003dconstants.LEARN_FROM_TUN,"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_14c82f73","line":110,"range":{"start_line":110,"start_character":28,"end_line":110,"end_character":65},"updated":"2016-02-18 12:07:31.000000000","message":"{\u0027cookie\u0027: self.default_cookie,","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"}],"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/ovs_ofctl/ofswitch.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        LOG.debug(\"Agent uuid stamp used to filter flows: %s, \" +"},{"line_number":89,"context_line":"                  \"Extension uuid stamps used to filter flows: %s\","},{"line_number":90,"context_line":"                  self.agent_uuid_stamp,"},{"line_number":91,"context_line":"                  str(self.ext_uuid_stamps))"},{"line_number":92,"context_line":"        cookie_re \u003d re.compile(\u0027cookie\u003d(0x[A-Fa-f0-9]*)\u0027)"},{"line_number":93,"context_line":"        table_re \u003d re.compile(\u0027table\u003d([0-9]*)\u0027)"},{"line_number":94,"context_line":"        for flow in flows:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_3de66ce8","line":91,"updated":"2016-01-15 10:30:39.000000000","message":"It could make sense to log here a entity-to-stamp map here (to easier match extension flows back to extensions).","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                continue"},{"line_number":98,"context_line":"            fl_cookie \u003d fl_cookie.group(1)"},{"line_number":99,"context_line":"            if (int(fl_cookie, 16) !\u003d self.agent_uuid_stamp and"},{"line_number":100,"context_line":"                int(fl_cookie, 16) not in self.ext_uuid_stamps):"},{"line_number":101,"context_line":"                fl_table \u003d table_re.search(flow)"},{"line_number":102,"context_line":"                if not fl_table:"},{"line_number":103,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_3d7bcc7c","line":100,"updated":"2016-01-15 10:30:39.000000000","message":"nit: you should calculate int() value once only; but note the other suggestion to have a method to determine a stamp is known.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            super(OpenFlowSwitchMixin, self).remove_all_flows()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _filter_flows(self, flows):"},{"line_number":88,"context_line":"        LOG.debug(\"Agent stamps and agents used to filter flows: %s, \" +"},{"line_number":89,"context_line":"                  str(self.uuid_to_agent.items()))"},{"line_number":90,"context_line":"        cookie_re \u003d re.compile(\u0027cookie\u003d(0x[A-Fa-f0-9]*)\u0027)"},{"line_number":91,"context_line":"        table_re \u003d re.compile(\u0027table\u003d([0-9]*)\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_adb449d1","line":88,"updated":"2016-01-20 12:49:29.000000000","message":"you should not execute + here, comma should be used instead. This is to avoid executing the operation when debug \u003d False (then it\u0027s ignored).","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            super(OpenFlowSwitchMixin, self).remove_all_flows()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _filter_flows(self, flows):"},{"line_number":88,"context_line":"        LOG.debug(\"Agent stamps and agents used to filter flows: %s, \" +"},{"line_number":89,"context_line":"                  str(self.uuid_to_agent.items()))"},{"line_number":90,"context_line":"        cookie_re \u003d re.compile(\u0027cookie\u003d(0x[A-Fa-f0-9]*)\u0027)"},{"line_number":91,"context_line":"        table_re \u003d re.compile(\u0027table\u003d([0-9]*)\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_5000bdaa","line":88,"in_reply_to":"9a68dd71_adb449d1","updated":"2016-01-20 15:44:40.000000000","message":"Done","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _filter_flows(self, flows):"},{"line_number":88,"context_line":"        LOG.debug(\"Agent stamps and agents used to filter flows: %s, \" +"},{"line_number":89,"context_line":"                  str(self.uuid_to_agent.items()))"},{"line_number":90,"context_line":"        cookie_re \u003d re.compile(\u0027cookie\u003d(0x[A-Fa-f0-9]*)\u0027)"},{"line_number":91,"context_line":"        table_re \u003d re.compile(\u0027table\u003d([0-9]*)\u0027)"},{"line_number":92,"context_line":"        for flow in flows:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_4dd10dfb","line":89,"updated":"2016-01-20 12:49:29.000000000","message":"you should not apply str() here, LOG.debug should take care of it for you (and it will also allow to avoid executing str() when debug is False.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _filter_flows(self, flows):"},{"line_number":88,"context_line":"        LOG.debug(\"Agent stamps and agents used to filter flows: %s, \" +"},{"line_number":89,"context_line":"                  str(self.uuid_to_agent.items()))"},{"line_number":90,"context_line":"        cookie_re \u003d re.compile(\u0027cookie\u003d(0x[A-Fa-f0-9]*)\u0027)"},{"line_number":91,"context_line":"        table_re \u003d re.compile(\u0027table\u003d([0-9]*)\u0027)"},{"line_number":92,"context_line":"        for flow in flows:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_f02bf131","line":89,"in_reply_to":"9a68dd71_4dd10dfb","updated":"2016-01-20 15:44:40.000000000","message":"Done","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            if not fl_cookie:"},{"line_number":95,"context_line":"                continue"},{"line_number":96,"context_line":"            fl_cookie \u003d fl_cookie.group(1)"},{"line_number":97,"context_line":"            if int(fl_cookie, 16) not in self.agent_stamps:"},{"line_number":98,"context_line":"                fl_table \u003d table_re.search(flow)"},{"line_number":99,"context_line":"                if not fl_table:"},{"line_number":100,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_8dfdc570","line":97,"updated":"2016-01-20 12:49:29.000000000","message":"same comment as in ofswitch.py","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            if not fl_cookie:"},{"line_number":95,"context_line":"                continue"},{"line_number":96,"context_line":"            fl_cookie \u003d fl_cookie.group(1)"},{"line_number":97,"context_line":"            if int(fl_cookie, 16) not in self.agent_stamps:"},{"line_number":98,"context_line":"                fl_table \u003d table_re.search(flow)"},{"line_number":99,"context_line":"                if not fl_table:"},{"line_number":100,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_70e70113","line":97,"in_reply_to":"9a68dd71_8dfdc570","updated":"2016-01-20 15:44:40.000000000","message":"Done","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"bd7b7c5acb2b7f8febaa6f17162260c468112ac9","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            super(OpenFlowSwitchMixin, self).remove_all_flows()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _filter_flows(self, flows):"},{"line_number":88,"context_line":"        LOG.debug(\"Agent stamps used to filter flows: %s, \","},{"line_number":89,"context_line":"                  self.get_uuid_stamp_list())"},{"line_number":90,"context_line":"        cookie_re \u003d re.compile(\u0027cookie\u003d(0x[A-Fa-f0-9]*)\u0027)"},{"line_number":91,"context_line":"        table_re \u003d re.compile(\u0027table\u003d([0-9]*)\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_f380f7f8","line":88,"range":{"start_line":88,"start_character":19,"end_line":88,"end_character":31},"updated":"2016-01-25 21:43:55.000000000","message":"Can/should you add \"uuid\" back in?","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            super(OpenFlowSwitchMixin, self).remove_all_flows()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _filter_flows(self, flows):"},{"line_number":88,"context_line":"        LOG.debug(\"Agent stamps used to filter flows: %s, \","},{"line_number":89,"context_line":"                  self.get_uuid_stamp_list())"},{"line_number":90,"context_line":"        cookie_re \u003d re.compile(\u0027cookie\u003d(0x[A-Fa-f0-9]*)\u0027)"},{"line_number":91,"context_line":"        table_re \u003d re.compile(\u0027table\u003d([0-9]*)\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_1c8ed727","line":88,"range":{"start_line":88,"start_character":19,"end_line":88,"end_character":31},"in_reply_to":"9a68dd71_f380f7f8","updated":"2016-01-26 13:08:41.000000000","message":"I would actually avoid talking about \u0027agent stamps\u0027 here. How abount instead: \"Bridge cookies used to filter flows: %s\"?","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b65b7d1c62e02d6982a4661aee7d20c456d38e37","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            super(OpenFlowSwitchMixin, self).remove_all_flows()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _filter_flows(self, flows):"},{"line_number":88,"context_line":"        LOG.debug(\"Agent stamps used to filter flows: %s, \","},{"line_number":89,"context_line":"                  self.get_uuid_stamp_list())"},{"line_number":90,"context_line":"        cookie_re \u003d re.compile(\u0027cookie\u003d(0x[A-Fa-f0-9]*)\u0027)"},{"line_number":91,"context_line":"        table_re \u003d re.compile(\u0027table\u003d([0-9]*)\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a5de9d1_5a179044","line":88,"range":{"start_line":88,"start_character":18,"end_line":88,"end_character":59},"updated":"2016-02-02 05:53:42.000000000","message":"Do you mean \"Agent stamps used to filter flows: [A, B, C], \"?","commit_id":"50edc4a3f42a66f34e0d3e68c83fd6132f6cc88a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e72a84f3185a2e7f0932eba961ea33875203c4fa","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            super(OpenFlowSwitchMixin, self).remove_all_flows()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _filter_flows(self, flows):"},{"line_number":88,"context_line":"        LOG.debug(\"Agent stamps used to filter flows: %s, \","},{"line_number":89,"context_line":"                  self.get_uuid_stamp_list())"},{"line_number":90,"context_line":"        cookie_re \u003d re.compile(\u0027cookie\u003d(0x[A-Fa-f0-9]*)\u0027)"},{"line_number":91,"context_line":"        table_re \u003d re.compile(\u0027table\u003d([0-9]*)\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_3b72814a","line":88,"range":{"start_line":88,"start_character":18,"end_line":88,"end_character":59},"in_reply_to":"7a5de9d1_5a179044","updated":"2016-02-04 08:53:16.000000000","message":"+","commit_id":"50edc4a3f42a66f34e0d3e68c83fd6132f6cc88a"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _filter_flows(self, flows):"},{"line_number":88,"context_line":"        LOG.debug(\"Bridge cookies used to filter flows: %s\","},{"line_number":89,"context_line":"                  self.get_reserved_cookies())"},{"line_number":90,"context_line":"        cookie_re \u003d re.compile(\u0027cookie\u003d(0x[A-Fa-f0-9]*)\u0027)"},{"line_number":91,"context_line":"        table_re \u003d re.compile(\u0027table\u003d([0-9]*)\u0027)"},{"line_number":92,"context_line":"        for flow in flows:"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_74ad3b9a","line":89,"updated":"2016-02-18 12:07:31.000000000","message":"self.reserved_cookies","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            if not fl_cookie:"},{"line_number":95,"context_line":"                continue"},{"line_number":96,"context_line":"            fl_cookie \u003d fl_cookie.group(1)"},{"line_number":97,"context_line":"            if int(fl_cookie, 16) not in self.get_reserved_cookies():"},{"line_number":98,"context_line":"                fl_table \u003d table_re.search(flow)"},{"line_number":99,"context_line":"                if not fl_table:"},{"line_number":100,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_b47a2322","line":97,"updated":"2016-02-18 12:07:31.000000000","message":"self.reserved_cookies","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"353060a8bd9ae79893f398171c4438eb5b648f24","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            if not fl_cookie:"},{"line_number":95,"context_line":"                continue"},{"line_number":96,"context_line":"            fl_cookie \u003d fl_cookie.group(1)"},{"line_number":97,"context_line":"            if int(fl_cookie, 16) not in self.reserved_cookies:"},{"line_number":98,"context_line":"                fl_table \u003d table_re.search(flow)"},{"line_number":99,"context_line":"                if not fl_table:"},{"line_number":100,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":23,"id":"dae33548_22aeba2d","line":97,"updated":"2016-02-18 18:45:53.000000000","message":"Crete a method to check if a cookie is reserved as this property is making a copy of the set.","commit_id":"fcf624ab120f02ea328935747857428a1595a76f"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"d7990e57f8a0701648b16dffc7625b4d02d3dd84","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _filter_flows(self, flows):"},{"line_number":88,"context_line":"        LOG.debug(\"Bridge cookies used to filter flows: %s\","},{"line_number":89,"context_line":"                  self.reserved_cookies)"},{"line_number":90,"context_line":"        cookie_re \u003d re.compile(\u0027cookie\u003d(0x[A-Fa-f0-9]*)\u0027)"},{"line_number":91,"context_line":"        table_re \u003d re.compile(\u0027table\u003d([0-9]*)\u0027)"},{"line_number":92,"context_line":"        cookie_list \u003d self.reserved_cookies"}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_ea78b42d","line":89,"updated":"2016-02-22 19:34:43.000000000","message":"A copy of set reserved_cookies is produced two times. Please use a temporary variable.","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d0ef73d7b0b3793499639fe005fb75743bc8aea3","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _filter_flows(self, flows):"},{"line_number":88,"context_line":"        LOG.debug(\"Bridge cookies used to filter flows: %s\","},{"line_number":89,"context_line":"                  self.reserved_cookies)"},{"line_number":90,"context_line":"        cookie_re \u003d re.compile(\u0027cookie\u003d(0x[A-Fa-f0-9]*)\u0027)"},{"line_number":91,"context_line":"        table_re \u003d re.compile(\u0027table\u003d([0-9]*)\u0027)"},{"line_number":92,"context_line":"        cookie_list \u003d self.reserved_cookies"}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_1d3d32c4","line":89,"in_reply_to":"bae84128_ea78b42d","updated":"2016-02-23 11:01:24.000000000","message":"Done","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"}],"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/ovs_ofctl/ovs_bridge.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"60e8d7c6b8db07a83ba8dae65fbb057d4988f461","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    import ofswitch"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class OVSAgentBridge(br_cookie.OVSBridgeCookieMixin, ofswitch."},{"line_number":28,"context_line":"                     OpenFlowSwitchMixin, ovs_lib.OVSBridge):"},{"line_number":29,"context_line":"    \"\"\"Common code for bridges used by OVS agent\"\"\""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"9aed3d3a_5b8d6030","line":27,"updated":"2016-02-26 14:19:08.000000000","message":"ditto on split at the dot.","commit_id":"763fb916afc0d7e9b03607cbcce8f601d1b4cf0e"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"04d5fd2ceee0b7bad23c7d54649d6fe4fa51f37b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    import ofswitch"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class OVSAgentBridge(br_cookie.OVSBridgeCookieMixin, ofswitch."},{"line_number":28,"context_line":"                     OpenFlowSwitchMixin, ovs_lib.OVSBridge):"},{"line_number":29,"context_line":"    \"\"\"Common code for bridges used by OVS agent\"\"\""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"9aed3d3a_dd15e39b","line":27,"in_reply_to":"9aed3d3a_5b8d6030","updated":"2016-02-26 15:03:44.000000000","message":"Done","commit_id":"763fb916afc0d7e9b03607cbcce8f601d1b4cf0e"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_agent_extension_api.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import oslo_messaging"},{"line_number":17,"context_line":"import uuid"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.agent.l2.agent_extension_api import AgentExtensionAPI"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_bdf1fc96","line":17,"updated":"2016-01-15 10:30:39.000000000","message":"nit: uuid is stdlib, move above and insert a new line before oslo_messaging","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import oslo_messaging"},{"line_number":17,"context_line":"import uuid"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.agent.l2.agent_extension_api import AgentExtensionAPI"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"UINT64_BITMASK \u003d (1 \u003c\u003c 64) - 1"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_7d15c499","line":19,"updated":"2016-01-15 10:30:39.000000000","message":"it\u0027s not common to import classes in neutron code. Please import whole module instead.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class OVSAgentExtensionAPI(AgentExtensionAPI):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    \u0027\u0027\u0027Implements the Agent extension agent api"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    The Neutron OvS agent passes this object into the extension manager"},{"line_number":28,"context_line":"    to extend functionality from the Neutron Agent to the extensions"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_1d6cc833","line":25,"updated":"2016-01-15 10:30:39.000000000","message":"Implements agent API for Open vSwitch agent.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    \u0027\u0027\u0027Implements the Agent extension agent api"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    The Neutron OvS agent passes this object into the extension manager"},{"line_number":28,"context_line":"    to extend functionality from the Neutron Agent to the extensions"},{"line_number":29,"context_line":"    that are running."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_dd71500d","line":27,"updated":"2016-01-15 10:30:39.000000000","message":"Let\u0027s not mention how agent exactly uses the object. It may later use it for its own needs (for better code separation).","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \u0027\u0027\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    # history"},{"line_number":36,"context_line":"    #   1.0 Initial version, added in ovs_neutron_agent 1.5"},{"line_number":37,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.0\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_3dd0acc8","line":36,"updated":"2016-01-15 10:30:39.000000000","message":"1.5?.. Where do you get the number from?","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    # history"},{"line_number":36,"context_line":"    #   1.0 Initial version, added in ovs_neutron_agent 1.5"},{"line_number":37,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.0\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self):"},{"line_number":40,"context_line":"        self.ext_uuid_stamps \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_a218f9d3","line":37,"updated":"2016-01-15 10:30:39.000000000","message":"?? It\u0027s not a RPC entrypoint. Instead, you should make it a NeutronObject.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def initialize(self, agent_uuid):"},{"line_number":45,"context_line":"        self.agent_uuid_stamp \u003d agent_uuid"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def request_ext_uuid_stamp(self, ext_obj):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        ext_str \u003d str(ext_obj)"},{"line_number":50,"context_line":"        if ext_str not in self.ext_dict:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_fd245360","line":47,"updated":"2016-01-15 10:30:39.000000000","message":"I would better have a \u0027register_cookie\u0027 API that will return a value that is either newly generated or previously returned for ext_obj, depending on whether it\u0027s the first call.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def request_ext_uuid_stamp(self, ext_obj):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        ext_str \u003d str(ext_obj)"},{"line_number":50,"context_line":"        if ext_str not in self.ext_dict:"},{"line_number":51,"context_line":"            ext_uuid \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":52,"context_line":"            self.ext_uuid_stamps.append(ext_uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_1d592735","line":49,"updated":"2016-01-15 10:30:39.000000000","message":"I think you could use ext_obj directly for your dict keys. Relying on string representation is fragile (the code will be broken if some extension defines __str__.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        ext_str \u003d str(ext_obj)"},{"line_number":50,"context_line":"        if ext_str not in self.ext_dict:"},{"line_number":51,"context_line":"            ext_uuid \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":52,"context_line":"            self.ext_uuid_stamps.append(ext_uuid)"},{"line_number":53,"context_line":"            self.ext_dict[ext_str] \u003d ext_uuid"},{"line_number":54,"context_line":"            return ext_uuid"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_7db8632a","line":51,"updated":"2016-01-15 10:30:39.000000000","message":"Would it make more sense if the uuid is generated by bridge methods themselves? I think extensions should not define the format for stamps, they should receive them from ovs_lib and use as blobs.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        ext_str \u003d str(ext_obj)"},{"line_number":50,"context_line":"        if ext_str not in self.ext_dict:"},{"line_number":51,"context_line":"            ext_uuid \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":52,"context_line":"            self.ext_uuid_stamps.append(ext_uuid)"},{"line_number":53,"context_line":"            self.ext_dict[ext_str] \u003d ext_uuid"},{"line_number":54,"context_line":"            return ext_uuid"},{"line_number":55,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_9d3758fe","line":52,"updated":"2016-01-15 10:30:39.000000000","message":"There is no reason to maintain that attribute on the object if we append it to the bridge list of known stamps right away. (Note: That would mean we need to have the brirdge device maintained in the object.)","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class OVSAgentExtensionAPI(AgentAPI):"},{"line_number":24,"context_line":"    \u0027\u0027\u0027Implements the Agent API for Open vSwitch agent."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    Extensions can gain access to this API by over-riding the consume_api"},{"line_number":27,"context_line":"    function which has been added to the AgentCoreResourceExtension class"},{"line_number":28,"context_line":"    and setting a ext_name string with the name of the extension."},{"line_number":29,"context_line":"    \u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_2deff9b1","line":26,"updated":"2016-01-20 12:49:29.000000000","message":"over-riding -\u003e overriding","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    Extensions can gain access to this API by over-riding the consume_api"},{"line_number":27,"context_line":"    function which has been added to the AgentCoreResourceExtension class"},{"line_number":28,"context_line":"    and setting a ext_name string with the name of the extension."},{"line_number":29,"context_line":"    \u0027\u0027\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    #   1.0 Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_6d23b106","line":28,"updated":"2016-01-20 12:49:29.000000000","message":"I don\u0027t follow the comment. What\u0027s that ext_name?","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"106d5c32e6f3c1fad6e1d44d062eaa8eb65e3450","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    Extensions can gain access to this API by over-riding the consume_api"},{"line_number":27,"context_line":"    function which has been added to the AgentCoreResourceExtension class"},{"line_number":28,"context_line":"    and setting a ext_name string with the name of the extension."},{"line_number":29,"context_line":"    \u0027\u0027\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    #   1.0 Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_a1189f85","line":28,"in_reply_to":"9a68dd71_13a00ff4","updated":"2016-01-21 09:25:49.000000000","message":"I think we should pass the whole extension object, not just a random string name.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    Extensions can gain access to this API by over-riding the consume_api"},{"line_number":27,"context_line":"    function which has been added to the AgentCoreResourceExtension class"},{"line_number":28,"context_line":"    and setting a ext_name string with the name of the extension."},{"line_number":29,"context_line":"    \u0027\u0027\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    #   1.0 Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_13a00ff4","line":28,"in_reply_to":"9a68dd71_6d23b106","updated":"2016-01-20 15:44:40.000000000","message":"My mistake sorry, I was considering adding a string to the abstract AgentCoreResourceExtension that could have been accessed through ext_obj to use when registering a new cookie, but I decided against it in favor of passing the name of the extension trying to access flows instead.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    fields \u003d {}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    _changed_fields \u003d {"},{"line_number":37,"context_line":"        \"agent_uuid_stamp\": obj_fields.UUIDField(nullable\u003dFalse)"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    obj_name \u003d AgentAPI"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_0d779503","line":37,"updated":"2016-01-20 12:49:29.000000000","message":"Hm, why isn\u0027t it registered in fields?","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c44dfbb1b3fb97cd48b57ed6fc0adf38d33ac638","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    fields \u003d {}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    _changed_fields \u003d {"},{"line_number":37,"context_line":"        \"agent_uuid_stamp\": obj_fields.UUIDField(nullable\u003dFalse)"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    obj_name \u003d AgentAPI"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_1fd00953","line":37,"in_reply_to":"9a68dd71_063c4f92","updated":"2016-01-20 16:28:22.000000000","message":"First time I see _changed_fields. We did not need it when introduced first QoS objects. I doubt we need it here either. Seems like some internal attribute from oslo.versionedobjects that we are not supposed to use.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    fields \u003d {}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    _changed_fields \u003d {"},{"line_number":37,"context_line":"        \"agent_uuid_stamp\": obj_fields.UUIDField(nullable\u003dFalse)"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    obj_name \u003d AgentAPI"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_063c4f92","line":37,"in_reply_to":"9a68dd71_0d779503","updated":"2016-01-20 15:44:40.000000000","message":"It needs to have a value in _changed_fields, I believe when it gets to version 1.1 you move \"agent_uuid_stamp\" to fields and the newly added values into changed fields.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"0785565c2575e054c47097c86df9c4eb60d0fede","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    fields \u003d {}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    _changed_fields \u003d {"},{"line_number":37,"context_line":"        \"agent_uuid_stamp\": obj_fields.UUIDField(nullable\u003dFalse)"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    obj_name \u003d AgentAPI"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_0d9b03cb","line":37,"in_reply_to":"9a68dd71_1fd00953","updated":"2016-01-20 17:08:36.000000000","message":"It throws an error without it as it tries to iterate through _changed_fields. There was a database version as well in the QoS classes, I\u0027ll have a look and check it out.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    obj_name \u003d AgentAPI"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self):"},{"line_number":43,"context_line":"        self.ext_uuid_stamps \u003d []"},{"line_number":44,"context_line":"        self.agent_uuid_stamp \u003d 0"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_8dd065cb","line":42,"updated":"2016-01-20 12:49:29.000000000","message":"please call to super().__init__","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.ext_uuid_stamps \u003d []"},{"line_number":44,"context_line":"        self.agent_uuid_stamp \u003d 0"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def initialize(self, agent_uuid, int_br):"},{"line_number":47,"context_line":"        self.agent_uuid_stamp \u003d agent_uuid"},{"line_number":48,"context_line":"        self.br_int \u003d int_br"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_d0fef204","line":46,"updated":"2016-01-20 12:49:29.000000000","message":"what\u0027s the deal with having the initialization code in __init__?","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c44dfbb1b3fb97cd48b57ed6fc0adf38d33ac638","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.ext_uuid_stamps \u003d []"},{"line_number":44,"context_line":"        self.agent_uuid_stamp \u003d 0"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def initialize(self, agent_uuid, int_br):"},{"line_number":47,"context_line":"        self.agent_uuid_stamp \u003d agent_uuid"},{"line_number":48,"context_line":"        self.br_int \u003d int_br"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_3f638db3","line":46,"in_reply_to":"9a68dd71_c6b4f7d2","updated":"2016-01-20 16:28:22.000000000","message":"But we can postpone initialization of the object until everything is ready, right?","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.ext_uuid_stamps \u003d []"},{"line_number":44,"context_line":"        self.agent_uuid_stamp \u003d 0"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def initialize(self, agent_uuid, int_br):"},{"line_number":47,"context_line":"        self.agent_uuid_stamp \u003d agent_uuid"},{"line_number":48,"context_line":"        self.br_int \u003d int_br"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_c6b4f7d2","line":46,"in_reply_to":"9a68dd71_d0fef204","updated":"2016-01-20 15:44:40.000000000","message":"Just to have the values initialized before the OVSNeutronAgent is ready to pass them in.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.agent_uuid_stamp \u003d agent_uuid"},{"line_number":48,"context_line":"        self.br_int \u003d int_br"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def register_cookie(self, ext_name):"},{"line_number":51,"context_line":"        ext_uuid \u003d self.br_int.request_agent_uuid_stamp(ext_name)"},{"line_number":52,"context_line":"        self.ext_uuid_stamps.append(ext_uuid)"},{"line_number":53,"context_line":"        return ext_uuid"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_cd309d0a","line":50,"updated":"2016-01-20 12:49:29.000000000","message":"I think we should pass some value that *uniquely* identifies the extension, like the extension object itself (self).\n\nPlease also add docstrings to all methods that are part of object API.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c44dfbb1b3fb97cd48b57ed6fc0adf38d33ac638","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.agent_uuid_stamp \u003d agent_uuid"},{"line_number":48,"context_line":"        self.br_int \u003d int_br"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def register_cookie(self, ext_name):"},{"line_number":51,"context_line":"        ext_uuid \u003d self.br_int.request_agent_uuid_stamp(ext_name)"},{"line_number":52,"context_line":"        self.ext_uuid_stamps.append(ext_uuid)"},{"line_number":53,"context_line":"        return ext_uuid"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_1f2c8949","line":50,"in_reply_to":"9a68dd71_1aa6dcc1","updated":"2016-01-20 16:28:22.000000000","message":"Can we extract extension names somehow for logging purposes?","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"0785565c2575e054c47097c86df9c4eb60d0fede","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.agent_uuid_stamp \u003d agent_uuid"},{"line_number":48,"context_line":"        self.br_int \u003d int_br"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def register_cookie(self, ext_name):"},{"line_number":51,"context_line":"        ext_uuid \u003d self.br_int.request_agent_uuid_stamp(ext_name)"},{"line_number":52,"context_line":"        self.ext_uuid_stamps.append(ext_uuid)"},{"line_number":53,"context_line":"        return ext_uuid"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_ed722fad","line":50,"in_reply_to":"9a68dd71_1f2c8949","updated":"2016-01-20 17:08:36.000000000","message":"As far as I can tell they are not stored, I\u0027ll see if I can pass them in from inside the extension manager but the extensions themselves will still need to identify themselves in case there is more than one extension being loaded.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.agent_uuid_stamp \u003d agent_uuid"},{"line_number":48,"context_line":"        self.br_int \u003d int_br"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def register_cookie(self, ext_name):"},{"line_number":51,"context_line":"        ext_uuid \u003d self.br_int.request_agent_uuid_stamp(ext_name)"},{"line_number":52,"context_line":"        self.ext_uuid_stamps.append(ext_uuid)"},{"line_number":53,"context_line":"        return ext_uuid"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_1aa6dcc1","line":50,"in_reply_to":"9a68dd71_cd309d0a","updated":"2016-01-20 15:44:40.000000000","message":"I changed it to facilitate the logging of extension names, will I use both ext_obj and ext_name? \n\nHave a verification in this method on the ext_obj and have the verification in br_int work on the name?","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.ext_uuid_stamps.append(ext_uuid)"},{"line_number":53,"context_line":"        return ext_uuid"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def add_flow(self, **kwargs):"},{"line_number":56,"context_line":"        if \u0027cookie\u0027 not in kwargs:"},{"line_number":57,"context_line":"            return \"No Cookie Provided\""},{"line_number":58,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_906ddace","line":55,"updated":"2016-01-20 12:49:29.000000000","message":"I think we should use a more explicit name, so that it points to exact bridge we use (smth like add_br_int_flow) so that later we can add more flow control methods for other bridges.","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.ext_uuid_stamps.append(ext_uuid)"},{"line_number":53,"context_line":"        return ext_uuid"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def add_flow(self, **kwargs):"},{"line_number":56,"context_line":"        if \u0027cookie\u0027 not in kwargs:"},{"line_number":57,"context_line":"            return \"No Cookie Provided\""},{"line_number":58,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_9f863eb8","line":55,"in_reply_to":"9a68dd71_906ddace","updated":"2016-01-20 15:44:40.000000000","message":"Done","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        return ext_uuid"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def add_flow(self, **kwargs):"},{"line_number":56,"context_line":"        if \u0027cookie\u0027 not in kwargs:"},{"line_number":57,"context_line":"            return \"No Cookie Provided\""},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            if kwargs[\"cookie\"] not in self.ext_uuid_stamps:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_4db02d8c","line":56,"updated":"2016-01-20 12:49:29.000000000","message":"If you want to enforce it, then why don\u0027t you make it a required argument?","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        return ext_uuid"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def add_flow(self, **kwargs):"},{"line_number":56,"context_line":"        if \u0027cookie\u0027 not in kwargs:"},{"line_number":57,"context_line":"            return \"No Cookie Provided\""},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            if kwargs[\"cookie\"] not in self.ext_uuid_stamps:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_ffedfa8e","line":56,"in_reply_to":"9a68dd71_4db02d8c","updated":"2016-01-20 15:44:40.000000000","message":"Done","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def add_flow(self, **kwargs):"},{"line_number":56,"context_line":"        if \u0027cookie\u0027 not in kwargs:"},{"line_number":57,"context_line":"            return \"No Cookie Provided\""},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            if kwargs[\"cookie\"] not in self.ext_uuid_stamps:"},{"line_number":60,"context_line":"                return \"Invalid Cookie Provided\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_ada3e94e","line":57,"updated":"2016-01-20 12:49:29.000000000","message":"that\u0027s not how exceptions in python work :) you should raise, not return a string...","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def add_flow(self, **kwargs):"},{"line_number":56,"context_line":"        if \u0027cookie\u0027 not in kwargs:"},{"line_number":57,"context_line":"            return \"No Cookie Provided\""},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            if kwargs[\"cookie\"] not in self.ext_uuid_stamps:"},{"line_number":60,"context_line":"                return \"Invalid Cookie Provided\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_bfe782ab","line":57,"in_reply_to":"9a68dd71_ada3e94e","updated":"2016-01-20 15:44:40.000000000","message":"Done","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            return \"No Cookie Provided\""},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            if kwargs[\"cookie\"] not in self.ext_uuid_stamps:"},{"line_number":60,"context_line":"                return \"Invalid Cookie Provided\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        self.br_int.add_flow(**kwargs)"},{"line_number":63,"context_line":"        return \"Flow Added\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_8d6ce509","line":60,"updated":"2016-01-20 12:49:29.000000000","message":"ditto for exceptions..","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            return \"No Cookie Provided\""},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            if kwargs[\"cookie\"] not in self.ext_uuid_stamps:"},{"line_number":60,"context_line":"                return \"Invalid Cookie Provided\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        self.br_int.add_flow(**kwargs)"},{"line_number":63,"context_line":"        return \"Flow Added\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_7fdb4aee","line":60,"in_reply_to":"9a68dd71_8d6ce509","updated":"2016-01-20 15:44:40.000000000","message":"Done","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.br_int.add_flow(**kwargs)"},{"line_number":63,"context_line":"        return \"Flow Added\""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def del_flows(self, **kwargs):"},{"line_number":66,"context_line":"        if \u0027cookie\u0027 not in kwargs:"},{"line_number":67,"context_line":"            return \"No Cookie Provided\""},{"line_number":68,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_50968295","line":65,"updated":"2016-01-20 12:49:29.000000000","message":"Same comments as above.\n\nAlso, methods should operate on similar arguments (meaning, either all of them operate on multiple flows, or all of them operate on a single flow).","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.br_int.add_flow(**kwargs)"},{"line_number":63,"context_line":"        return \"Flow Added\""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def del_flows(self, **kwargs):"},{"line_number":66,"context_line":"        if \u0027cookie\u0027 not in kwargs:"},{"line_number":67,"context_line":"            return \"No Cookie Provided\""},{"line_number":68,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_dfd596b9","line":65,"in_reply_to":"9a68dd71_50968295","updated":"2016-01-20 15:44:40.000000000","message":"Done","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.br_int.delete_flow(**kwargs)"},{"line_number":73,"context_line":"        return \"Flows Removed\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def mod_flows(self, **kwargs):"},{"line_number":76,"context_line":"        if \u0027cookie\u0027 not in kwargs:"},{"line_number":77,"context_line":"            return \"No Cookie Provided\""},{"line_number":78,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_308d0e7c","line":75,"updated":"2016-01-20 12:49:29.000000000","message":"ditto","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.br_int.delete_flow(**kwargs)"},{"line_number":73,"context_line":"        return \"Flows Removed\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def mod_flows(self, **kwargs):"},{"line_number":76,"context_line":"        if \u0027cookie\u0027 not in kwargs:"},{"line_number":77,"context_line":"            return \"No Cookie Provided\""},{"line_number":78,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_bfd0e2ca","line":75,"in_reply_to":"9a68dd71_308d0e7c","updated":"2016-01-20 15:44:40.000000000","message":"Done","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self.br_int.mod_flow(**kwargs)"},{"line_number":83,"context_line":"        return \"Flows Modified\""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def dump_flows(self, **kwargs):"},{"line_number":86,"context_line":"        if \u0027cookie\u0027 not in kwargs:"},{"line_number":87,"context_line":"            return \"No Cookie Provided\""},{"line_number":88,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_f0ed3626","line":85,"updated":"2016-01-20 12:49:29.000000000","message":"I don\u0027t believe dump_flows should be part of public API. Why would you need it for extensions?","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.objects import base"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":27,"context_line":"class OVSAgentExtensionAPI(base.NeutronObject):"},{"line_number":28,"context_line":"    \u0027\u0027\u0027Implements the Agent API for Open vSwitch agent."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_828ca280","line":26,"updated":"2016-01-26 13:08:41.000000000","message":"note to self: once https://review.openstack.org/270230 merged, we\u0027ll need to register the object in neutron.objects","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    #   1.0 Initial version"},{"line_number":35,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self, agent_uuid, int_br):"},{"line_number":38,"context_line":"        super(OVSAgentExtensionAPI, self).__init__()"},{"line_number":39,"context_line":"        self.ext_uuid_stamps \u003d []"},{"line_number":40,"context_line":"        self.agent_uuid_stamp \u003d agent_uuid"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_5c1f6fb7","line":37,"updated":"2016-01-26 13:08:41.000000000","message":"Why do we want to pass and store agent_uuid here?","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self, agent_uuid, int_br):"},{"line_number":38,"context_line":"        super(OVSAgentExtensionAPI, self).__init__()"},{"line_number":39,"context_line":"        self.ext_uuid_stamps \u003d []"},{"line_number":40,"context_line":"        self.agent_uuid_stamp \u003d agent_uuid"},{"line_number":41,"context_line":"        self.br_int \u003d int_br"},{"line_number":42,"context_line":"        self.ext_to_uuid \u003d {}"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_dc583f8d","line":39,"updated":"2016-01-26 13:08:41.000000000","message":"I suggest to use private names for all non-public attributes (prepend _).\n\nI don\u0027t see a reason to store stamp values here instead of fetching them from the bridge when needed using public bridge API.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.ext_uuid_stamps \u003d []"},{"line_number":40,"context_line":"        self.agent_uuid_stamp \u003d agent_uuid"},{"line_number":41,"context_line":"        self.br_int \u003d int_br"},{"line_number":42,"context_line":"        self.ext_to_uuid \u003d {}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def register_cookie(self, ext_obj):"},{"line_number":45,"context_line":"        \"\"\"Allows extensions to request a cookie uuid to gain"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_bcac6b36","line":42,"updated":"2016-01-26 13:08:41.000000000","message":"Explain why we need the attribute.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"bd7b7c5acb2b7f8febaa6f17162260c468112ac9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.br_int \u003d int_br"},{"line_number":42,"context_line":"        self.ext_to_uuid \u003d {}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def register_cookie(self, ext_obj):"},{"line_number":45,"context_line":"        \"\"\"Allows extensions to request a cookie uuid to gain"},{"line_number":46,"context_line":"        access to flow creation."},{"line_number":47,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_3398cf1b","line":44,"range":{"start_line":44,"start_character":30,"end_line":44,"end_character":37},"updated":"2016-01-25 21:43:55.000000000","message":"Can you add a :param doc?","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"bd7b7c5acb2b7f8febaa6f17162260c468112ac9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.br_int \u003d int_br"},{"line_number":42,"context_line":"        self.ext_to_uuid \u003d {}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def register_cookie(self, ext_obj):"},{"line_number":45,"context_line":"        \"\"\"Allows extensions to request a cookie uuid to gain"},{"line_number":46,"context_line":"        access to flow creation."},{"line_number":47,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_aefc56b8","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":23},"updated":"2016-01-25 21:43:55.000000000","message":"Is this a primarily a register or a request of a cookie?  More a point of confusion for me rather than a challenge.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.br_int \u003d int_br"},{"line_number":42,"context_line":"        self.ext_to_uuid \u003d {}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def register_cookie(self, ext_obj):"},{"line_number":45,"context_line":"        \"\"\"Allows extensions to request a cookie uuid to gain"},{"line_number":46,"context_line":"        access to flow creation."},{"line_number":47,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_fc474375","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":23},"in_reply_to":"9a68dd71_aefc56b8","updated":"2016-01-26 13:08:41.000000000","message":"Yes, it should be \u0027request_cookie\u0027 or even \u0027reserve_cookie\u0027","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"bd7b7c5acb2b7f8febaa6f17162260c468112ac9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.ext_to_uuid \u003d {}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def register_cookie(self, ext_obj):"},{"line_number":45,"context_line":"        \"\"\"Allows extensions to request a cookie uuid to gain"},{"line_number":46,"context_line":"        access to flow creation."},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        ext_uuid \u003d 0"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_33f1af6b","line":45,"range":{"start_line":45,"start_character":18,"end_line":45,"end_character":28},"updated":"2016-01-25 21:43:55.000000000","message":"Suggest (here and below): s/extensions/an extension","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.ext_to_uuid \u003d {}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def register_cookie(self, ext_obj):"},{"line_number":45,"context_line":"        \"\"\"Allows extensions to request a cookie uuid to gain"},{"line_number":46,"context_line":"        access to flow creation."},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        ext_uuid \u003d 0"},{"line_number":49,"context_line":"        if ext_obj not in self.ext_to_uuid:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_ff0c153d","line":46,"range":{"start_line":45,"start_character":54,"end_line":46,"end_character":31},"updated":"2016-01-26 13:08:41.000000000","message":"Unclear. Better \u0027to use for extension specific flows\u0027.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            ext_uuid \u003d self.ext_to_uuid[ext_obj]"},{"line_number":55,"context_line":"        return ext_uuid"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def add_br_int_flow(self, stamp, **kwargs):"},{"line_number":58,"context_line":"        \"\"\"Allows extensions to add a flow to the flow table provided"},{"line_number":59,"context_line":"        a valid cookie is provided."},{"line_number":60,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_9fc3998a","line":57,"range":{"start_line":57,"start_character":30,"end_line":57,"end_character":35},"updated":"2016-01-26 13:08:41.000000000","message":"rename argument into \u0027cookie\u0027.\n\nAlso, all arguments should be documented in docstring.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        return ext_uuid"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def add_br_int_flow(self, stamp, **kwargs):"},{"line_number":58,"context_line":"        \"\"\"Allows extensions to add a flow to the flow table provided"},{"line_number":59,"context_line":"        a valid cookie is provided."},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        if stamp not in self.ext_uuid_stamps:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_df5591fa","line":59,"range":{"start_line":58,"start_character":61,"end_line":59,"end_character":34},"updated":"2016-01-26 13:08:41.000000000","message":"too many provided. Better: \"Add a flow to the integration bridge flow table with a valid cookie.\" Same below in other methods.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        a valid cookie is provided."},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        if stamp not in self.ext_uuid_stamps:"},{"line_number":63,"context_line":"            msg \u003d _(\"Invalid cookie provided\")"},{"line_number":64,"context_line":"            raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_9f95d989","line":62,"updated":"2016-01-26 13:08:41.000000000","message":"You could get the list of valid cookies from the bridge.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"bd7b7c5acb2b7f8febaa6f17162260c468112ac9","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        if stamp not in self.ext_uuid_stamps:"},{"line_number":63,"context_line":"            msg \u003d _(\"Invalid cookie provided\")"},{"line_number":64,"context_line":"            raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        kwargs[\"cookie\"] \u003d stamp"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_b37a7fbb","line":63,"range":{"start_line":63,"start_character":21,"end_line":63,"end_character":44},"updated":"2016-01-25 21:43:55.000000000","message":"Can you log the cookie that was provided?","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"bd7b7c5acb2b7f8febaa6f17162260c468112ac9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        a valid cookie is provided."},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        if stamp not in self.ext_uuid_stamps:"},{"line_number":63,"context_line":"            msg \u003d _(\"Invalid cookie provided\")"},{"line_number":64,"context_line":"            raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        kwargs[\"cookie\"] \u003d stamp"},{"line_number":67,"context_line":"        self.br_int.add_flow(**kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_5369c3f7","line":64,"range":{"start_line":62,"start_character":8,"end_line":64,"end_character":60},"updated":"2016-01-25 21:43:55.000000000","message":"Suggest converting these lines to a private method, which can then be called in this method and the following three.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        kwargs[\"cookie\"] \u003d stamp"},{"line_number":67,"context_line":"        self.br_int.add_flow(**kwargs)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def del_br_int_flows(self, stamp, **kwargs):"},{"line_number":70,"context_line":"        \"\"\"Allows extensions to remove flows from the flow table provided"},{"line_number":71,"context_line":"        a valid cookie is provided."},{"line_number":72,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_1f5d69ec","line":69,"updated":"2016-01-26 13:08:41.000000000","message":"Please avoid abbreviations like \u0027del\u0027. suggest: \u0027delete_integration_bridge_flow\u0027","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            msg \u003d _(\"Invalid cookie provided\")"},{"line_number":76,"context_line":"            raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        kwargs[\"cookie\"] \u003d str(stamp) + \"/-1\""},{"line_number":79,"context_line":"        self.br_int.delete_flows(**kwargs)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def mod_br_int_flows(self, stamp, **kwargs):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_5f9e8164","line":78,"updated":"2016-01-26 13:08:41.000000000","message":"I see that \"/-1\" magic in multiple places here. You should have some helper method for that, and you should explain the goal here in a comment.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"39457844d439d195dc2f63b7037027eebb01a8ed","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            msg \u003d _(\"Invalid cookie provided\")"},{"line_number":76,"context_line":"            raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        kwargs[\"cookie\"] \u003d str(stamp) + \"/-1\""},{"line_number":79,"context_line":"        self.br_int.delete_flows(**kwargs)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def mod_br_int_flows(self, stamp, **kwargs):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_15f23e9b","line":78,"in_reply_to":"9a68dd71_4ee6d145","updated":"2016-01-27 11:24:13.000000000","message":"Yes, we need the comment.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8c497646b7e2c0896a59f29179e24645d9634833","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            msg \u003d _(\"Invalid cookie provided\")"},{"line_number":76,"context_line":"            raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        kwargs[\"cookie\"] \u003d str(stamp) + \"/-1\""},{"line_number":79,"context_line":"        self.br_int.delete_flows(**kwargs)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def mod_br_int_flows(self, stamp, **kwargs):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_4ee6d145","line":78,"in_reply_to":"9a68dd71_5f9e8164","updated":"2016-01-26 15:19:00.000000000","message":"Just to put it here for clarification but I\u0027ll add a comment later, it\u0027s a bit mask that tells delete, modify and dump that if cookie \u0026 -1(Or all bits in the value \u003d 1) \u003d\u003d cookie then it fits the criteria of this value.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        kwargs[\"cookie\"] \u003d str(stamp) + \"/-1\""},{"line_number":79,"context_line":"        self.br_int.delete_flows(**kwargs)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def mod_br_int_flows(self, stamp, **kwargs):"},{"line_number":82,"context_line":"        \"\"\"Allows extensions to modify flows in the flow table provided"},{"line_number":83,"context_line":"        a valid cookie is provided."},{"line_number":84,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_ff5bb5f4","line":81,"updated":"2016-01-26 13:08:41.000000000","message":"modify_integration_bridge_flow","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.br_int.delete_flows(**kwargs)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def mod_br_int_flows(self, stamp, **kwargs):"},{"line_number":82,"context_line":"        \"\"\"Allows extensions to modify flows in the flow table provided"},{"line_number":83,"context_line":"        a valid cookie is provided."},{"line_number":84,"context_line":"        \"\"\""},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_3f094dde","line":82,"range":{"start_line":82,"start_character":39,"end_line":82,"end_character":44},"updated":"2016-01-26 13:08:41.000000000","message":"Looks more like a single flow? (you calling to mod_flow). Or does the latter allow to modify multiple flows?","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8c497646b7e2c0896a59f29179e24645d9634833","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.br_int.delete_flows(**kwargs)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def mod_br_int_flows(self, stamp, **kwargs):"},{"line_number":82,"context_line":"        \"\"\"Allows extensions to modify flows in the flow table provided"},{"line_number":83,"context_line":"        a valid cookie is provided."},{"line_number":84,"context_line":"        \"\"\""},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_b33d76bd","line":82,"range":{"start_line":82,"start_character":39,"end_line":82,"end_character":44},"in_reply_to":"9a68dd71_3f094dde","updated":"2016-01-26 15:19:00.000000000","message":"If the criteria is vague enough it will modify multiple flows.\n\nie. if just the cookie is provided then all flows with that uuid will have their actions modified.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"39457844d439d195dc2f63b7037027eebb01a8ed","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.br_int.delete_flows(**kwargs)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def mod_br_int_flows(self, stamp, **kwargs):"},{"line_number":82,"context_line":"        \"\"\"Allows extensions to modify flows in the flow table provided"},{"line_number":83,"context_line":"        a valid cookie is provided."},{"line_number":84,"context_line":"        \"\"\""},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_35465ac0","line":82,"range":{"start_line":82,"start_character":39,"end_line":82,"end_character":44},"in_reply_to":"9a68dd71_b33d76bd","updated":"2016-01-27 11:24:13.000000000","message":"Got it. Thanks.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        kwargs[\"cookie\"] \u003d str(stamp) + \"/-1\""},{"line_number":91,"context_line":"        self.br_int.mod_flow(**kwargs)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def dump_br_int_flows(self, stamp, **kwargs):"},{"line_number":94,"context_line":"        \"\"\"Allows extensions to view flows in the flow table provided"},{"line_number":95,"context_line":"        a valid cookie is provided."},{"line_number":96,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_3c787b8f","line":93,"updated":"2016-01-26 13:08:41.000000000","message":"I don\u0027t think it\u0027s wise to make dump-flows output format define public agent API here. The method currently returns a list of strings.\n\nI still struggle to see what\u0027s the actual use case for dumping the flows. How does it help extensions to handle their needs?\n\nRemember that each method you add here puts additional burden on us to maintain compatibility, I prefer to stay short on methods here.\n\nI suggest you rebase qos dscp patch on top of that one to show how you plan to use the method. Maybe it would clarify the need in it.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8c497646b7e2c0896a59f29179e24645d9634833","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        kwargs[\"cookie\"] \u003d str(stamp) + \"/-1\""},{"line_number":91,"context_line":"        self.br_int.mod_flow(**kwargs)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def dump_br_int_flows(self, stamp, **kwargs):"},{"line_number":94,"context_line":"        \"\"\"Allows extensions to view flows in the flow table provided"},{"line_number":95,"context_line":"        a valid cookie is provided."},{"line_number":96,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_73685e88","line":93,"in_reply_to":"9a68dd71_3c787b8f","updated":"2016-01-26 15:19:00.000000000","message":"I put up the last dscp patch on top of this one.\nI use it to validate that there is not already a dscp flow and if there is it uses it to modify the existing flow and insert the modify action into the existing flow (avoiding competition between existing QoS flows).\nIt helps prevent extensions from being blind to their own flows in short.\n\nDo you think it would be better to parse out relevant information and return that? you could exclude the cookie and return the criteria on each flow (leaving out things like idle_time) and the actions field.\n\nDSCP patch:\nhttps://review.openstack.org/#/c/251738/15/neutron/plugins/ml2/drivers/openvswitch/agent/extension_drivers/qos_driver.py","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"39457844d439d195dc2f63b7037027eebb01a8ed","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        kwargs[\"cookie\"] \u003d str(stamp) + \"/-1\""},{"line_number":91,"context_line":"        self.br_int.mod_flow(**kwargs)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def dump_br_int_flows(self, stamp, **kwargs):"},{"line_number":94,"context_line":"        \"\"\"Allows extensions to view flows in the flow table provided"},{"line_number":95,"context_line":"        a valid cookie is provided."},{"line_number":96,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_352c1aab","line":93,"in_reply_to":"9a68dd71_73685e88","updated":"2016-01-27 11:24:13.000000000","message":"I think I see why you need it now. Maybe it\u0027s better to use some other terminology here (f.e. \u0027get\u0027, not \u0027dump\u0027 since \u0027dump\u0027 often times means a log dump or smth).\n\nRe parsing, I am not sure. It\u0027s of course unfortunate that we return strings instead of some well defined objects for flows. But I would not require this part covered for you to proceed either. I suspect ryu library could have some abstractions for flows, but I haven\u0027t checked myself.\n\nI guess we will need to live with list of strings here at least for a while.","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"39457844d439d195dc2f63b7037027eebb01a8ed","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def dump_br_int_flows(self, stamp, **kwargs):"},{"line_number":94,"context_line":"        \"\"\"Allows extensions to view flows in the flow table provided"},{"line_number":95,"context_line":"        a valid cookie is provided."},{"line_number":96,"context_line":"        \"\"\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        if stamp not in self.ext_uuid_stamps:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_00043a13","line":95,"updated":"2016-01-27 11:24:13.000000000","message":"Please describe the exact type and format of returned value here (using @returns).","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"665ea6f634cfdcb17cc2e503ea9113fff0420722","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7a5de9d1_c1de2f3d","updated":"2016-02-02 08:32:49.000000000","message":"One issue that has been raised is the fact that the br_tun is not yet accessible. This one is easy to fix by duplicating the (add,del,mod,dump)_br_int_flow(s) methods.\n\nBut the (add,del,mod,dump)_br_int_flow(s) methods have the drawback of not making it easy (if at all possible) of using some of the things defined in OVSBridge:\n- deferred()\n- install_arp_responder() or install_arp_responder()\n- add_patch_ports()\n- ...\n\nThe two last issues would make it hard to use the agent API for BGPVPN (see [1]).\n\nLet me suggest the following:\n- extend the OVSBridge class with a get_stamped_bridge(stamp) method that returns a OVSBridge subclass for which the relevant add/del/mod/dump flow methods will call the corresponding method inherited from OVSBridge but adding the cookie\u003dstamp flow parameter (we could call this class StampingOVSBridge)\n- in OSVAgentExtensionAPI, instead of (add,del,mod,dump)_br_int_flow(s), simply provide a get_br_int(stamp) and a get_br_tun(stamp) method which will check that the stamp is legit and return a StampingOVSBridge for the said stamp\n\n\n[1] https://etherpad.openstack.org/p/l2-agent-extensions-api-expansion","commit_id":"50edc4a3f42a66f34e0d3e68c83fd6132f6cc88a"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"f2dacac3d8f6e58433958880709fc41c7c5e86c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5a5ae5dd_473517d8","in_reply_to":"5a5ae5dd_5b217d4c","updated":"2016-02-04 11:24:56.000000000","message":"Having bridges as field on the versioned object would not, I think, allow the use of multiple cookies by an extension.\n\nHence my suggestion of OVSAgentExtensionAPI.get_br_tun(cookie).","commit_id":"50edc4a3f42a66f34e0d3e68c83fd6132f6cc88a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e72a84f3185a2e7f0932eba961ea33875203c4fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5a5ae5dd_5b217d4c","in_reply_to":"7a5de9d1_c1de2f3d","updated":"2016-02-04 08:53:16.000000000","message":"I am fine with that approach, as long as we are quick to respin. If we don\u0027t get the code in a week (with tests), I suggest we stick to current implementation.\n\nBTW we could also have the bridges as fields on the versioned object.","commit_id":"50edc4a3f42a66f34e0d3e68c83fd6132f6cc88a"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"e07adca0b1fda5afdf84ac558bfc23cfefec8d8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5a5ae5dd_cf05a3c2","in_reply_to":"7a5de9d1_c1de2f3d","updated":"2016-02-04 09:58:15.000000000","message":"It\u0027s easy to do all of those things, you just create an OVSBridge object (Like is done inside the qos_driver), this will give you access to the patch_port and deferred methods neither of which use flows. The arp_responder methods just creates a single flow using the info you send, they don\u0027t use any variables unique to the bridge (except for the cookie being applied in add_flow).","commit_id":"50edc4a3f42a66f34e0d3e68c83fd6132f6cc88a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9f27ad9435057b50bbe9240c039677410b8cea94","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":27,"context_line":"class OVSAgentExtensionAPI(base.NeutronObject):"},{"line_number":28,"context_line":"    \u0027\u0027\u0027Implements the Agent API for Open vSwitch agent."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    Extensions can gain access to this API by overriding the consume_api"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a5de9d1_a500e634","line":27,"updated":"2016-02-02 04:43:22.000000000","message":"is a versioned object supposed to be used for\nprocess-internal objects like this?","commit_id":"50edc4a3f42a66f34e0d3e68c83fd6132f6cc88a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e72a84f3185a2e7f0932eba961ea33875203c4fa","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":27,"context_line":"class OVSAgentExtensionAPI(base.NeutronObject):"},{"line_number":28,"context_line":"    \u0027\u0027\u0027Implements the Agent API for Open vSwitch agent."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    Extensions can gain access to this API by overriding the consume_api"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_bbb751f4","line":27,"in_reply_to":"7a5de9d1_a500e634","updated":"2016-02-04 08:53:16.000000000","message":"It can be used. The rationale here is that if later we introduce fields and want to refactor them, we allow external (out-of-tree) extensions to get their object in the version they know how to interact with.","commit_id":"50edc4a3f42a66f34e0d3e68c83fd6132f6cc88a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9f27ad9435057b50bbe9240c039677410b8cea94","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            ext_uuid \u003d self.ext_to_uuid[ext_obj]"},{"line_number":55,"context_line":"        return ext_uuid"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def add_br_int_flow(self, stamp, **kwargs):"},{"line_number":58,"context_line":"        \"\"\"Allows extensions to add a flow to the flow table provided"},{"line_number":59,"context_line":"        a valid cookie is provided."},{"line_number":60,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"7a5de9d1_858ccada","line":57,"updated":"2016-02-02 04:43:22.000000000","message":"it\u0027s better to allow extensions to use \"native\" of_interface.\n\nis it allowed for extensions to use api.br_int directly?","commit_id":"50edc4a3f42a66f34e0d3e68c83fd6132f6cc88a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e72a84f3185a2e7f0932eba961ea33875203c4fa","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            ext_uuid \u003d self.ext_to_uuid[ext_obj]"},{"line_number":55,"context_line":"        return ext_uuid"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def add_br_int_flow(self, stamp, **kwargs):"},{"line_number":58,"context_line":"        \"\"\"Allows extensions to add a flow to the flow table provided"},{"line_number":59,"context_line":"        a valid cookie is provided."},{"line_number":60,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_9b8295ff","line":57,"in_reply_to":"7a5de9d1_858ccada","updated":"2016-02-04 08:53:16.000000000","message":"Do you suggest to expose two bridges directly? I am fine with it.","commit_id":"50edc4a3f42a66f34e0d3e68c83fd6132f6cc88a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"fdff2c00b5f5a50f527c4c49473d97892a6d6415","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def search_for_cookie(cookie):"},{"line_number":23,"context_line":"    #NOTE: This method converts cookie to a string and appends /-1 to"},{"line_number":24,"context_line":"    #the end. This acts as a bit mask providing the equivilent logic of:"},{"line_number":25,"context_line":"    #if flow_cookie \u0026 -1(all bits set to 1) \u003d\u003d cookie:"},{"line_number":26,"context_line":"    #which simplifies to: if flow_cookie \u003d\u003d cookie:"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_709250a1","line":23,"updated":"2016-02-04 10:59:34.000000000","message":"We can convert this NOTE into a Docstring :)","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"c2862de3973d26329a307601db9e47c2d12ea190","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def search_for_cookie(cookie):"},{"line_number":23,"context_line":"    #NOTE: This method converts cookie to a string and appends /-1 to"},{"line_number":24,"context_line":"    #the end. This acts as a bit mask providing the equivilent logic of:"},{"line_number":25,"context_line":"    #if flow_cookie \u0026 -1(all bits set to 1) \u003d\u003d cookie:"},{"line_number":26,"context_line":"    #which simplifies to: if flow_cookie \u003d\u003d cookie:"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_cbd10559","line":23,"in_reply_to":"5a5ae5dd_709250a1","updated":"2016-02-04 15:10:59.000000000","message":"Done","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"a9a276842b6133c89a1581b770d1d44848ed10e5","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def search_for_cookie(cookie):"},{"line_number":23,"context_line":"    #NOTE: This method converts cookie to a string and appends /-1 to"},{"line_number":24,"context_line":"    #the end. This acts as a bit mask providing the equivilent logic of:"},{"line_number":25,"context_line":"    #if flow_cookie \u0026 -1(all bits set to 1) \u003d\u003d cookie:"},{"line_number":26,"context_line":"    #which simplifies to: if flow_cookie \u003d\u003d cookie:"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_d2c850aa","line":24,"range":{"start_line":24,"start_character":52,"end_line":24,"end_character":62},"updated":"2016-02-08 17:27:13.000000000","message":"equivalent","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"fdff2c00b5f5a50f527c4c49473d97892a6d6415","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    return str(cookie) + \u0027/-1\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":32,"context_line":"class OVSAgentExtensionAPI(base.NeutronObject):"},{"line_number":33,"context_line":"    \u0027\u0027\u0027Implements the Agent API for Open vSwitch agent."}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_b09c485e","line":30,"updated":"2016-02-04 10:59:34.000000000","message":"This looks very good in general, I\u0027m curious about the backwards-compat mechanisms by using versioned objects on this.","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fc32f0c6095350ca2f69fd12b4743f4ff5bc0178","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    return str(cookie) + \u0027/-1\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":32,"context_line":"class OVSAgentExtensionAPI(base.NeutronObject):"},{"line_number":33,"context_line":"    \u0027\u0027\u0027Implements the Agent API for Open vSwitch agent."}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_865d1a7b","line":30,"in_reply_to":"5a5ae5dd_b09c485e","updated":"2016-02-05 10:21:16.000000000","message":"Currently, it does not buy us much. But later we may have fields on it, and extensions backporting the object to their known version.","commit_id":"da8c2455773f2e295d01ee65c827f0a3bd521802"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    fields \u003d {"},{"line_number":35,"context_line":"        \"br-int\": obj_fields.ObjectField(\u0027OVSAgentBridge\u0027, subclasses\u003dTrue),"},{"line_number":36,"context_line":"        \"br-tun\": obj_fields.ObjectField(\u0027OVSAgentBridge\u0027, subclasses\u003dTrue)"},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_dd302159","line":35,"range":{"start_line":35,"start_character":42,"end_line":35,"end_character":56},"updated":"2016-02-10 14:28:42.000000000","message":"This type is a versioned object type, not any python type. To have it properly typed, you need to implement a new versioned object type for bridge objects.\n\nThis object type would be smth like:\n\nclass OVSAgentBridge(base.NeutronObject):\n\n    fields \u003d {\n        \u0027name\u0027: obj_fields.StringField(...),\n        \u0027default_cookie\u0027: obj_fields.IntField(...),\n    }\n\n    synthetic_fields \u003d [\u0027name\u0027, \u0027default_cookie\u0027]\n\n    def __init__(self, bridge):\n         super(...).__init__()\n         self._bridge \u003d bridge\n\n    def obj_load_attr(self, attrname):\n         if attrname \u003d\u003d \u0027name\u0027:\n             return self._bridge.br_name\n         elif attrname \u003d\u003d \u0027default_cookie\u0027:\n             return self._bridge.get_default_cookie()\n         else:\n             raise exceptions.ObjectActionError(...)\n\n    def __getattr__(self, name):\n         return getattr(self._bridge, name)\n\nThat should make all calls to the versioned object to proxy into the bridge itself, plus it gives us proper serialization for the versioned object with name and default cookie.","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    fields \u003d {"},{"line_number":35,"context_line":"        \"br-int\": obj_fields.ObjectField(\u0027OVSAgentBridge\u0027, subclasses\u003dTrue),"},{"line_number":36,"context_line":"        \"br-tun\": obj_fields.ObjectField(\u0027OVSAgentBridge\u0027, subclasses\u003dTrue)"},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_fd62bdd7","line":35,"range":{"start_line":35,"start_character":9,"end_line":35,"end_character":15},"updated":"2016-02-10 14:28:42.000000000","message":"You want to have it with uderscores, so that e.g. api_obj.br_int works (.br-int is not correct python syntax).","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ec75c6c8eacb6a44f7407ddf2d25b78e3a234f2a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    fields \u003d {"},{"line_number":35,"context_line":"        \"br-int\": obj_fields.ObjectField(\u0027OVSAgentBridge\u0027, subclasses\u003dTrue),"},{"line_number":36,"context_line":"        \"br-tun\": obj_fields.ObjectField(\u0027OVSAgentBridge\u0027, subclasses\u003dTrue)"},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_b4dd3a16","line":35,"range":{"start_line":35,"start_character":42,"end_line":35,"end_character":56},"in_reply_to":"3a57f1b5_6e8375cd","updated":"2016-02-10 15:13:23.000000000","message":"Copying from IRC:\n\nthe more I think about using versioned objects for API object, the more I think it may be not such a bright idea\n\nin the end, the only thing it buys us in the future is that potentially some extensions will be able to work with multiple versions of neutron. which is not such a huge benefit. While we get deeper in the hole of working around the versioned objects API requirements.\n\ndo you think it would be reasonable to just remove the fields and the versioning from there, and just handle future deprecations as we usually do (breaking old code once in a while)?\n\nI tend to lean to answer yes now...","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8327571bd8ed14cff119cc67e1a4296a2694d4a4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    fields \u003d {"},{"line_number":35,"context_line":"        \"br-int\": obj_fields.ObjectField(\u0027OVSAgentBridge\u0027, subclasses\u003dTrue),"},{"line_number":36,"context_line":"        \"br-tun\": obj_fields.ObjectField(\u0027OVSAgentBridge\u0027, subclasses\u003dTrue)"},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_d7475849","line":35,"range":{"start_line":35,"start_character":42,"end_line":35,"end_character":56},"in_reply_to":"3a57f1b5_b4dd3a16","updated":"2016-02-11 17:00:20.000000000","message":"Done","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5b781ed0346449257e53656949456d9935c2ff6f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    fields \u003d {"},{"line_number":35,"context_line":"        \"br-int\": obj_fields.ObjectField(\u0027OVSAgentBridge\u0027, subclasses\u003dTrue),"},{"line_number":36,"context_line":"        \"br-tun\": obj_fields.ObjectField(\u0027OVSAgentBridge\u0027, subclasses\u003dTrue)"},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_6e8375cd","line":35,"range":{"start_line":35,"start_character":42,"end_line":35,"end_character":56},"in_reply_to":"3a57f1b5_dd302159","updated":"2016-02-10 14:47:41.000000000","message":"OVO madneeeees ;D :-)","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5b781ed0346449257e53656949456d9935c2ff6f","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    fields \u003d {"},{"line_number":35,"context_line":"        \"br-int\": obj_fields.ObjectField(\u0027OVSAgentBridge\u0027, subclasses\u003dTrue),"},{"line_number":36,"context_line":"        \"br-tun\": obj_fields.ObjectField(\u0027OVSAgentBridge\u0027, subclasses\u003dTrue)"},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self, int_br, tun_br):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_2ee81de2","line":36,"updated":"2016-02-10 14:47:41.000000000","message":"I wonder how will we do if we need to provide other bridges in the future (like br-eth1 / etc related to provider networks or other uses)\n\nIs there any way to (later) provide an array of provider-network bridges?","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b33d928314e854538d05a0d55758cd78269193a2","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    fields \u003d {"},{"line_number":35,"context_line":"        \"br-int\": obj_fields.ObjectField(\u0027OVSAgentBridge\u0027, subclasses\u003dTrue),"},{"line_number":36,"context_line":"        \"br-tun\": obj_fields.ObjectField(\u0027OVSAgentBridge\u0027, subclasses\u003dTrue)"},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self, int_br, tun_br):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_4e00f934","line":36,"in_reply_to":"3a57f1b5_2ee81de2","updated":"2016-02-10 14:49:38.000000000","message":"We\u0027ll add a field later if we need one.","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        \"br-tun\": obj_fields.ObjectField(\u0027OVSAgentBridge\u0027, subclasses\u003dTrue)"},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self, int_br, tun_br):"},{"line_number":40,"context_line":"        super(OVSAgentExtensionAPI, self).__init__()"},{"line_number":41,"context_line":"        self.br_int \u003d int_br"},{"line_number":42,"context_line":"        self.br_tun \u003d tun_br"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_fde5dda7","line":39,"updated":"2016-02-10 14:28:42.000000000","message":"This method is unneeded. You should allow the oslo.versionedobjects machinery to set and validate the fields for you.","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                                 cookie\u003dext_uuid)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def request_tun_br(self):"},{"line_number":53,"context_line":"        \"\"\"Allows extensions to request an tunnel bridge to use for"},{"line_number":54,"context_line":"        extension specific flows."},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        if not self.br_tun:"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_5a3d172a","line":53,"range":{"start_line":53,"start_character":40,"end_line":53,"end_character":42},"updated":"2016-02-10 14:28:42.000000000","message":"a","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8327571bd8ed14cff119cc67e1a4296a2694d4a4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                                 cookie\u003dext_uuid)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def request_tun_br(self):"},{"line_number":53,"context_line":"        \"\"\"Allows extensions to request an tunnel bridge to use for"},{"line_number":54,"context_line":"        extension specific flows."},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        if not self.br_tun:"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_173e50b8","line":53,"range":{"start_line":53,"start_character":40,"end_line":53,"end_character":42},"in_reply_to":"3a57f1b5_5a3d172a","updated":"2016-02-11 17:00:20.000000000","message":"Done","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def request_tun_br(self):"},{"line_number":53,"context_line":"        \"\"\"Allows extensions to request an tunnel bridge to use for"},{"line_number":54,"context_line":"        extension specific flows."},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        if not self.br_tun:"},{"line_number":57,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_5a6bd71e","line":54,"updated":"2016-02-10 14:28:42.000000000","message":"Please note that it may be unavailable, depending on tunnelling enabled; and that then you get None.","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8327571bd8ed14cff119cc67e1a4296a2694d4a4","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def request_tun_br(self):"},{"line_number":53,"context_line":"        \"\"\"Allows extensions to request an tunnel bridge to use for"},{"line_number":54,"context_line":"        extension specific flows."},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        if not self.br_tun:"},{"line_number":57,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_b74c1c71","line":54,"in_reply_to":"3a57f1b5_5a6bd71e","updated":"2016-02-11 17:00:20.000000000","message":"Done","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def request_tun_br(self):"},{"line_number":41,"context_line":"        \"\"\"Allows extensions to request a tunnel bridge to use for"},{"line_number":42,"context_line":"        extension specific flows."},{"line_number":43,"context_line":"        Please note if tunneling is not enabled, this method will return None"},{"line_number":44,"context_line":"        \"\"\""},{"line_number":45,"context_line":"        if not self.br_tun:"},{"line_number":46,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_79e3bda4","line":43,"updated":"2016-02-12 15:13:31.000000000","message":"nit: add a trailing dot. And maybe remove \u0027Please note \u0027. Also maybe add an empty newline between the sentences.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"64237c9f61c963e5b1d1db4b892560277c68300e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def request_tun_br(self):"},{"line_number":41,"context_line":"        \"\"\"Allows extensions to request a tunnel bridge to use for"},{"line_number":42,"context_line":"        extension specific flows."},{"line_number":43,"context_line":"        Please note if tunneling is not enabled, this method will return None"},{"line_number":44,"context_line":"        \"\"\""},{"line_number":45,"context_line":"        if not self.br_tun:"},{"line_number":46,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_b14149ab","line":43,"in_reply_to":"3a57f1b5_79e3bda4","updated":"2016-02-15 14:09:08.000000000","message":"Done","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b2494258b6c6af6c768c04b1e28a2623fd88a52b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \"\"\""},{"line_number":36,"context_line":"        ext_uuid \u003d self.br_int.request_cookie()"},{"line_number":37,"context_line":"        return ovs_lib.OVSBridge(self.br_int.br_name,"},{"line_number":38,"context_line":"                                 cookie\u003dext_uuid)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def request_tun_br(self):"},{"line_number":41,"context_line":"        \"\"\"Allows extensions to request a tunnel bridge to use for"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_2c32d610","line":38,"updated":"2016-02-16 09:53:52.000000000","message":"this effectively forces extensions to use \"ovs-ofctl\" of_interface.\nit would be nicer if it allows \"native\" too.\n\niwamoto-san, do you have any idea?","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"3057a62e0eb9000a7d2021f392cf50d197003796","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \"\"\""},{"line_number":36,"context_line":"        ext_uuid \u003d self.br_int.request_cookie()"},{"line_number":37,"context_line":"        return ovs_lib.OVSBridge(self.br_int.br_name,"},{"line_number":38,"context_line":"                                 cookie\u003dext_uuid)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def request_tun_br(self):"},{"line_number":41,"context_line":"        \"\"\"Allows extensions to request a tunnel bridge to use for"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_008bcd68","line":38,"in_reply_to":"dae33548_2c32d610","updated":"2016-02-18 10:48:58.000000000","message":"I agree that this is not ideal.\n\nPassing the real bridge of the agent to the extension would seem better, it would also allow an extension to use methods that are not defined in OVSBridge but only in OVSTunnelBridge, like install_arp_responder and delete_arp_responder.   The fact that this is not possible is actually a problem I ran into today while writing an L2 agent extension for networking-bgpvpn [1].\n\n[1] https://review.openstack.org/#/c/281358/ and \n    https://review.openstack.org/#/c/281347/","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        If tunneling is not enabled, this method will return None."},{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        if not self.br_tun:"},{"line_number":47,"context_line":"            return None"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        ext_uuid \u003d self.br_tun.request_cookie()"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_8384070b","line":46,"updated":"2016-02-18 12:07:31.000000000","message":"Positive logic is easier to read:\n\nresult \u003d None\nbr_tun \u003d self.br_tun\nif br_tun:\n    result \u003d ovs_lib.OVSBridge(\n        br_tun.br_name,\n        cookie\u003dbr_tun.request_cookie())\nreturn result","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"4816c71dc77e95efec9abfc0afe4de14341724e9","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    This class creates a bridge that will pass all calls to its underlying"},{"line_number":27,"context_line":"    bridge, except (add/mod/del/dump)_flow calls for which a cookie (reserved"},{"line_number":28,"context_line":"    at init from the underlying bridge) will be added before calling the "},{"line_number":29,"context_line":"    underlying bridge."},{"line_number":30,"context_line":"    \u0027\u0027\u0027"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"dae33548_96055015","line":28,"range":{"start_line":28,"start_character":72,"end_line":28,"end_character":73},"updated":"2016-02-18 17:47:26.000000000","message":"Remove space :)","commit_id":"88ac12da0bbb03d36bf3bf5d253774e882e2b7c2"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"107b20247663a1a951217ebd9859f04ae3215b5f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.br \u003d bridge"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        if cookie:"},{"line_number":40,"context_line":"            self.br.reserve_cookie(cookie)"},{"line_number":41,"context_line":"            self.cookie \u003d cookie"},{"line_number":42,"context_line":"        else:"},{"line_number":43,"context_line":"            self.cookie \u003d self.br.request_cookie()"}],"source_content_type":"text/x-python","patch_set":22,"id":"dae33548_7c4fcb33","line":40,"range":{"start_line":40,"start_character":12,"end_line":40,"end_character":19},"updated":"2016-02-18 18:16:28.000000000","message":"Please replace self.br with bridge.","commit_id":"88ac12da0bbb03d36bf3bf5d253774e882e2b7c2"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"107b20247663a1a951217ebd9859f04ae3215b5f","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        if cookie:"},{"line_number":40,"context_line":"            self.br.reserve_cookie(cookie)"},{"line_number":41,"context_line":"            self.cookie \u003d cookie"},{"line_number":42,"context_line":"        else:"},{"line_number":43,"context_line":"            self.cookie \u003d self.br.request_cookie()"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"dae33548_dc2ed741","line":41,"range":{"start_line":41,"start_character":17,"end_line":41,"end_character":23},"updated":"2016-02-18 18:16:28.000000000","message":"I would make this attribute private:\n\nself._cookie \u003d cookie","commit_id":"88ac12da0bbb03d36bf3bf5d253774e882e2b7c2"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"107b20247663a1a951217ebd9859f04ae3215b5f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            self.br.reserve_cookie(cookie)"},{"line_number":41,"context_line":"            self.cookie \u003d cookie"},{"line_number":42,"context_line":"        else:"},{"line_number":43,"context_line":"            self.cookie \u003d self.br.request_cookie()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def get_default_cookie(self):"},{"line_number":46,"context_line":"        return self.cookie"}],"source_content_type":"text/x-python","patch_set":22,"id":"dae33548_fc591bfe","line":43,"range":{"start_line":43,"start_character":26,"end_line":43,"end_character":33},"updated":"2016-02-18 18:16:28.000000000","message":"Please replace self.br with bridge.","commit_id":"88ac12da0bbb03d36bf3bf5d253774e882e2b7c2"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"107b20247663a1a951217ebd9859f04ae3215b5f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        else:"},{"line_number":43,"context_line":"            self.cookie \u003d self.br.request_cookie()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def get_default_cookie(self):"},{"line_number":46,"context_line":"        return self.cookie"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def do_action_flows(self, action, kwargs_list):"}],"source_content_type":"text/x-python","patch_set":22,"id":"dae33548_5cd12722","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":26},"updated":"2016-02-18 18:16:28.000000000","message":"I would make this a property:\n\n@property\ndef default_cookie(self):\n     return self._cookie","commit_id":"88ac12da0bbb03d36bf3bf5d253774e882e2b7c2"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"107b20247663a1a951217ebd9859f04ae3215b5f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # an extension does not delete flows of another"},{"line_number":53,"context_line":"        # extension"},{"line_number":54,"context_line":"        for kw in kwargs_list:"},{"line_number":55,"context_line":"            if \u0027cookie\u0027 not in kw:"},{"line_number":56,"context_line":"                kw[\u0027cookie\u0027] \u003d self.cookie"},{"line_number":57,"context_line":"        self.br.do_action_flows(action, kwargs_list)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def add_flow(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":22,"id":"dae33548_dcb897ca","line":56,"range":{"start_line":55,"start_character":12,"end_line":56,"end_character":42},"updated":"2016-02-18 18:16:28.000000000","message":"kw.setdefault(\u0027cookie\u0027, self._cookie)","commit_id":"88ac12da0bbb03d36bf3bf5d253774e882e2b7c2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"140de0ae823070bf60a1d16a2ba25bfdc02529c0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        return self._cookie"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def do_action_flows(self, action, kwargs_list):"},{"line_number":41,"context_line":"        # NOTE(tmorin): the OSVBridge code is excluding the \u0027del\u0027"},{"line_number":42,"context_line":"        # action from this step where a cookie"},{"line_number":43,"context_line":"        # is added, but I think we need to keep it so that"},{"line_number":44,"context_line":"        # an extension does not delete flows of another"}],"source_content_type":"text/x-python","patch_set":24,"id":"bae84128_bde138d3","line":41,"updated":"2016-02-19 11:55:57.000000000","message":"OVSBridge","commit_id":"9aacb91882e7e6bb92c364f332a8963c398e8951"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"15e5c4ac7225b3bd34104d566c788298aa4e4d83","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            kw.setdefault(\u0027cookie\u0027, self._cookie)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"            if (action is \u0027mod\u0027 or action is \u0027del\u0027) and \u0027/\u0027 not in \\"},{"line_number":49,"context_line":"                str(kw[\u0027cookie\u0027]):"},{"line_number":50,"context_line":"                kw[\u0027cookie\u0027] \u003d str(kw[\u0027cookie\u0027]) + \u0027/-1\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.bridge.do_action_flows(action, kwargs_list)"}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_db2659cd","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":33},"updated":"2016-02-22 16:43:36.000000000","message":"nitty nit: could be calculated just once","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d0ef73d7b0b3793499639fe005fb75743bc8aea3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            kw.setdefault(\u0027cookie\u0027, self._cookie)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"            if (action is \u0027mod\u0027 or action is \u0027del\u0027) and \u0027/\u0027 not in \\"},{"line_number":49,"context_line":"                str(kw[\u0027cookie\u0027]):"},{"line_number":50,"context_line":"                kw[\u0027cookie\u0027] \u003d str(kw[\u0027cookie\u0027]) + \u0027/-1\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.bridge.do_action_flows(action, kwargs_list)"}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_b82374a6","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":33},"in_reply_to":"bae84128_db2659cd","updated":"2016-02-23 11:01:24.000000000","message":"Done","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"d7990e57f8a0701648b16dffc7625b4d02d3dd84","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            kw.setdefault(\u0027cookie\u0027, self._cookie)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"            if (action is \u0027mod\u0027 or action is \u0027del\u0027) and \u0027/\u0027 not in \\"},{"line_number":49,"context_line":"                str(kw[\u0027cookie\u0027]):"},{"line_number":50,"context_line":"                kw[\u0027cookie\u0027] \u003d str(kw[\u0027cookie\u0027]) + \u0027/-1\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.bridge.do_action_flows(action, kwargs_list)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_e0c0d37e","line":50,"range":{"start_line":49,"start_character":16,"end_line":50,"end_character":56},"updated":"2016-02-22 19:34:43.000000000","message":"If statement and the code inside its block cannot have same indentation. I would be surprised if PEP8 doesn\u0027t complain about it.","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"15e5c4ac7225b3bd34104d566c788298aa4e4d83","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        for kw in kwargs_list:"},{"line_number":46,"context_line":"            kw.setdefault(\u0027cookie\u0027, self._cookie)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"            if (action is \u0027mod\u0027 or action is \u0027del\u0027) and \u0027/\u0027 not in \\"},{"line_number":49,"context_line":"                str(kw[\u0027cookie\u0027]):"},{"line_number":50,"context_line":"                kw[\u0027cookie\u0027] \u003d str(kw[\u0027cookie\u0027]) + \u0027/-1\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.bridge.do_action_flows(action, kwargs_list)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_7b162d56","line":50,"range":{"start_line":48,"start_character":56,"end_line":50,"end_character":56},"updated":"2016-02-22 16:43:36.000000000","message":"This code to calculate cookie is duplicated here and in ovs_lib, could use some common helper function.","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d0ef73d7b0b3793499639fe005fb75743bc8aea3","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        for kw in kwargs_list:"},{"line_number":46,"context_line":"            kw.setdefault(\u0027cookie\u0027, self._cookie)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"            if (action is \u0027mod\u0027 or action is \u0027del\u0027) and \u0027/\u0027 not in \\"},{"line_number":49,"context_line":"                str(kw[\u0027cookie\u0027]):"},{"line_number":50,"context_line":"                kw[\u0027cookie\u0027] \u003d str(kw[\u0027cookie\u0027]) + \u0027/-1\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.bridge.do_action_flows(action, kwargs_list)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_183d40c4","line":50,"range":{"start_line":48,"start_character":56,"end_line":50,"end_character":56},"in_reply_to":"bae84128_7b162d56","updated":"2016-02-23 11:01:24.000000000","message":"Done","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d0ef73d7b0b3793499639fe005fb75743bc8aea3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            kw.setdefault(\u0027cookie\u0027, self._cookie)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"            if (action is \u0027mod\u0027 or action is \u0027del\u0027) and \u0027/\u0027 not in \\"},{"line_number":49,"context_line":"                str(kw[\u0027cookie\u0027]):"},{"line_number":50,"context_line":"                kw[\u0027cookie\u0027] \u003d str(kw[\u0027cookie\u0027]) + \u0027/-1\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.bridge.do_action_flows(action, kwargs_list)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_fd6cce36","line":50,"range":{"start_line":49,"start_character":16,"end_line":50,"end_character":56},"in_reply_to":"bae84128_e0c0d37e","updated":"2016-02-23 11:01:24.000000000","message":"There are a few examples over Neutron of this indentation being used and PEP8 hasn\u0027t thrown an issue with it.","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e6ffa02b25cab51d9301a569cd498adf36f08fa5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    This class creates a bridge that will pass all calls to its underlying"},{"line_number":23,"context_line":"    bridge, except (add/mod/del/dump)_flow calls for which a cookie (reserved"},{"line_number":24,"context_line":"    at init from the underlying bridge) will be added before calling the"},{"line_number":25,"context_line":"    underlying bridge."},{"line_number":26,"context_line":"    \u0027\u0027\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def __init__(self, bridge):"}],"source_content_type":"text/x-python","patch_set":27,"id":"bae84128_a7d75aec","line":25,"updated":"2016-02-25 01:04:47.000000000","message":"can you add a TODO comment for \"native\" support?","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d4ef3a04140a64ff76b980fcf3f378e0ba7ccbb1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    This class creates a bridge that will pass all calls to its underlying"},{"line_number":23,"context_line":"    bridge, except (add/mod/del/dump)_flow calls for which a cookie (reserved"},{"line_number":24,"context_line":"    at init from the underlying bridge) will be added before calling the"},{"line_number":25,"context_line":"    underlying bridge."},{"line_number":26,"context_line":"    \u0027\u0027\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def __init__(self, bridge):"}],"source_content_type":"text/x-python","patch_set":27,"id":"bae84128_431111af","line":25,"in_reply_to":"bae84128_a7d75aec","updated":"2016-02-25 09:46:46.000000000","message":"Is native not supported by giving direct access to the bridges (line #62)?","commit_id":"098530c6644752e7bb0945a9196b2e6b67f6a0d3"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    #   1.2 Support DVR (Distributed Virtual Router) RPC"},{"line_number":139,"context_line":"    #   1.3 Added param devices_to_update to security_groups_provider_updated"},{"line_number":140,"context_line":"    #   1.4 Added support for network_update"},{"line_number":141,"context_line":"    #   1.5 Added support for l2 agent extensions agent api"},{"line_number":142,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.5\u0027)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def __init__(self, bridge_classes, conf\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_bdea5bd9","line":141,"updated":"2016-01-15 10:30:39.000000000","message":"? You update RPC endpoint version, but there are no changes for RPC here. I think you mix oslo versioned objects (NeutronObject) and RPC versioning here.","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        self.agent_uuid_stamp \u003d uuid.uuid4().int \u0026 UINT64_BITMASK"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        self.ovs_agent_ext_api \u003d ovs_ext_api.OVSAgentExtensionAPI()"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        self.ovs_agent_ext_api.initialize(self.agent_uuid_stamp)"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_3dbd0bd8","line":191,"updated":"2016-01-15 10:30:39.000000000","message":"self.agent_api?","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":387,"context_line":"            ext_manager.AgentExtensionsManager(self.conf))"},{"line_number":388,"context_line":"        self.ext_manager.initialize("},{"line_number":389,"context_line":"            connection, constants.EXTENSION_DRIVER_TYPE,"},{"line_number":390,"context_line":"            self.ovs_agent_ext_api)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        ext_uuid_stamps \u003d []"},{"line_number":393,"context_line":"        ext_uuid_stamps \u003d self.ovs_agent_ext_api.get_ext_uuid_stamps()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_1d84c708","line":390,"updated":"2016-01-15 10:30:39.000000000","message":"Maybe pass it as kwarg: agent_api\u003dself.agent_api?","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"887b610564072e162b4733815b9aa5339565bcfb","unresolved":false,"context_lines":[{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        ext_uuid_stamps \u003d []"},{"line_number":393,"context_line":"        ext_uuid_stamps \u003d self.ovs_agent_ext_api.get_ext_uuid_stamps()"},{"line_number":394,"context_line":"        self.int_br.set_ext_uuid_stamps(ext_uuid_stamps)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    def get_net_uuid(self, vif_id):"},{"line_number":397,"context_line":"        for network_id, vlan_mapping in six.iteritems(self.local_vlan_map):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_5dbc7fba","line":394,"updated":"2016-01-15 10:30:39.000000000","message":"I would better have the agent API object to do the job (it means you need to pass brdige when initializing the object).","commit_id":"75a4daf75827390fcf2f8e9bc4d8503d00bbb67f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29302c49cba4d1437d015591b1832ace706252f2","unresolved":false,"context_lines":[{"line_number":959,"context_line":""},{"line_number":960,"context_line":"        \u0027\u0027\u0027"},{"line_number":961,"context_line":"        self.int_br.set_agent_uuid_stamp(self.agent_uuid_stamp)"},{"line_number":962,"context_line":""},{"line_number":963,"context_line":"        # Ensure the integration bridge is created."},{"line_number":964,"context_line":"        # ovs_lib.OVSBridge.create() will run"},{"line_number":965,"context_line":"        #   ovs-vsctl -- --may-exist add-br BRIDGE_NAME"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_f030d6a0","line":962,"updated":"2016-01-20 12:49:29.000000000","message":"nit: redundant change","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"769f0caea6f15ea51a8f6d4eef4cc1268b18f557","unresolved":false,"context_lines":[{"line_number":959,"context_line":""},{"line_number":960,"context_line":"        \u0027\u0027\u0027"},{"line_number":961,"context_line":"        self.int_br.set_agent_uuid_stamp(self.agent_uuid_stamp)"},{"line_number":962,"context_line":""},{"line_number":963,"context_line":"        # Ensure the integration bridge is created."},{"line_number":964,"context_line":"        # ovs_lib.OVSBridge.create() will run"},{"line_number":965,"context_line":"        #   ovs-vsctl -- --may-exist add-br BRIDGE_NAME"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_da860413","line":962,"in_reply_to":"9a68dd71_f030d6a0","updated":"2016-01-20 15:44:40.000000000","message":"Done","commit_id":"2c782f9beb51cdeeab322adf6f5202f867044f9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        self.ext_manager \u003d ("},{"line_number":383,"context_line":"            ext_manager.AgentExtensionsManager(self.conf))"},{"line_number":384,"context_line":"        self.agent_api \u003d ovs_ext_api.OVSAgentExtensionAPI("},{"line_number":385,"context_line":"                                     self.agent_uuid_stamp, self.int_br)"},{"line_number":386,"context_line":"        self.ext_manager.initialize("},{"line_number":387,"context_line":"            connection, constants.EXTENSION_DRIVER_TYPE,"},{"line_number":388,"context_line":"            self.agent_api)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_bf9f7d4f","line":385,"updated":"2016-01-26 13:08:41.000000000","message":"I don\u0027t see a reason for us to pass the cookie into the class (it\u0027s already available thru bridge methods).","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":952,"context_line":"        \u0027\u0027\u0027Setup the integration bridge."},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"        \u0027\u0027\u0027"},{"line_number":955,"context_line":"        self.agent_uuid_stamp \u003d self.int_br.request_agent_uuid_stamp()"},{"line_number":956,"context_line":"        # Ensure the integration bridge is created."},{"line_number":957,"context_line":"        # ovs_lib.OVSBridge.create() will run"},{"line_number":958,"context_line":"        #   ovs-vsctl -- --may-exist add-br BRIDGE_NAME"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_422a2a80","line":955,"updated":"2016-01-26 13:08:41.000000000","message":"I believe you don\u0027t need the attribute.\n\nThough you should do that: \n\n\u0027self.int_br.set_agent_uuid_stamp(self.int_br.reserve_cookie())\u0027\n\nOr better, if we fix naming in API and have the following:\n\n\u0027self.int_br.set_default_cookie(self.int_br.reserve_cookie())\u0027","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84fc0a09e2847c08296c187f3976348270281184","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"        \u0027\u0027\u0027"},{"line_number":1003,"context_line":"        if not self.tun_br:"},{"line_number":1004,"context_line":"            self.tun_br \u003d self.br_tun_cls(tun_br_name)"},{"line_number":1005,"context_line":"        self.tun_br.request_agent_uuid_stamp()"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        # tun_br.create() won\u0027t recreate bridge if it exists, but will handle"},{"line_number":1008,"context_line":"        # cases where something like datapath_type has changed"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_e2555efa","line":1005,"updated":"2016-01-26 13:08:41.000000000","message":"Once you remove special casing in bridge method, you would need the same as above here (set_default(reserve())","commit_id":"d29a74eed4b45f5003dd0ae22519b5481fcc2650"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"a640fae2f3eb7d0b61ca3eec5851317d3e8d45d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"dae33548_ac993dc6","updated":"2016-02-18 10:35:27.000000000","message":"The modifications in this file seem unrelated to the change being review, aren\u0027t they ?","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"1c45cf3cafc61fc8b947ba580eedb34f4bc662ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"dae33548_2c636d43","in_reply_to":"dae33548_ac993dc6","updated":"2016-02-18 10:43:18.000000000","message":"They\u0027re related, with the bridge handling the cookies the neutron agent no longer needs to generate  it\u0027s own uuid (So uuid is removed and set_agent_uuid_stamp is removed for br-tun and br-int).\n\nIn order to allow br-tun to be passed into the agentAPI the init_extension_manager method has to be called after br-tun is initialized. \n\nThen in init_extension_manager the OVSAgentExtensionAPI is initialized and passed into the AgentExtensionsManager.","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"}],"neutron/tests/functional/agent/l2/base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        self._plug_ports(self.network, self.ports, self.agent,"},{"line_number":386,"context_line":"                         bridge\u003dancillary_bridge)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def test_l2_agent_extension(self):"},{"line_number":389,"context_line":"        port \u003d 5432"},{"line_number":390,"context_line":"        mark \u003d 22"},{"line_number":391,"context_line":"        action \u003d \u0027NORMAL\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_fdaabd18","line":388,"updated":"2016-02-10 14:28:42.000000000","message":"Why is it a functional test? I don\u0027t see you trigger anything on backend here.","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5b781ed0346449257e53656949456d9935c2ff6f","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        self._plug_ports(self.network, self.ports, self.agent,"},{"line_number":386,"context_line":"                         bridge\u003dancillary_bridge)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def test_l2_agent_extension(self):"},{"line_number":389,"context_line":"        port \u003d 5432"},{"line_number":390,"context_line":"        mark \u003d 22"},{"line_number":391,"context_line":"        action \u003d \u0027NORMAL\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_6ee7f5e4","line":388,"in_reply_to":"3a57f1b5_fdaabd18","updated":"2016-02-10 14:47:41.000000000","message":"I agree, this one can be moved to unit tests.\n\nIf you make another one that really manipulates the bridges via the api, then yes, that\u0027d be functional.","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                         bridge\u003dancillary_bridge)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def test_l2_agent_extension(self):"},{"line_number":389,"context_line":"        port \u003d 5432"},{"line_number":390,"context_line":"        mark \u003d 22"},{"line_number":391,"context_line":"        action \u003d \u0027NORMAL\u0027"},{"line_number":392,"context_line":"        self.br_int \u003d ovs_lib.OVSBridge(\"br-int\")"},{"line_number":393,"context_line":"        self.br_tun \u003d ovs_lib.OVSBridge(\"br-tun\")"},{"line_number":394,"context_line":"        self.agent_api \u003d ovs_ext_api.OVSAgentExtensionAPI(self.br_int, self.br_tun)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_bd63e519","line":391,"range":{"start_line":389,"start_character":8,"end_line":391,"end_character":25},"updated":"2016-02-10 14:28:42.000000000","message":"unused?","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":389,"context_line":"        port \u003d 5432"},{"line_number":390,"context_line":"        mark \u003d 22"},{"line_number":391,"context_line":"        action \u003d \u0027NORMAL\u0027"},{"line_number":392,"context_line":"        self.br_int \u003d ovs_lib.OVSBridge(\"br-int\")"},{"line_number":393,"context_line":"        self.br_tun \u003d ovs_lib.OVSBridge(\"br-tun\")"},{"line_number":394,"context_line":"        self.agent_api \u003d ovs_ext_api.OVSAgentExtensionAPI(self.br_int, self.br_tun)"},{"line_number":395,"context_line":"        new_br_int \u003d self.agent_api.request_int_br()"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_7d3b2dec","line":392,"range":{"start_line":392,"start_character":30,"end_line":392,"end_character":39},"updated":"2016-02-10 14:28:42.000000000","message":"Those will need to be of br_int/br_tun fields versioned type.","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        action \u003d \u0027NORMAL\u0027"},{"line_number":392,"context_line":"        self.br_int \u003d ovs_lib.OVSBridge(\"br-int\")"},{"line_number":393,"context_line":"        self.br_tun \u003d ovs_lib.OVSBridge(\"br-tun\")"},{"line_number":394,"context_line":"        self.agent_api \u003d ovs_ext_api.OVSAgentExtensionAPI(self.br_int, self.br_tun)"},{"line_number":395,"context_line":"        new_br_int \u003d self.agent_api.request_int_br()"},{"line_number":396,"context_line":"        new_br_tun \u003d self.agent_api.request_tun_br()"},{"line_number":397,"context_line":"        br_int_cookie \u003d new_br_int.request_cookie()"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_fdfcfd3f","line":394,"range":{"start_line":394,"start_character":37,"end_line":394,"end_character":83},"updated":"2016-02-10 14:28:42.000000000","message":"Should be smth like: OVSAgentExtensionAPI(br_int\u003dself.br_int, br_tun\u003dself.br_tun)\n\nSo that proper versioned fields are set and validated with the values.","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"}],"neutron/tests/unit/agent/common/test_ovs_lib.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":891,"context_line":"        with ovs_lib.DeferredOVSBridge(self.br) as deferred_br:"},{"line_number":892,"context_line":"            self.assertRaises(AttributeError, getattr, deferred_br, \u0027failure\u0027)"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"    def test_cookies(self):"},{"line_number":895,"context_line":"        self.br \u003d ovs_lib.OVSBridge(\"br-tun\")"},{"line_number":896,"context_line":"        self.assertNotEqual(0, self.br.default_cookie)"},{"line_number":897,"context_line":"        uuid_stamp1 \u003d self.br.get_default_cookie()"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_84497062","line":894,"range":{"start_line":894,"start_character":8,"end_line":894,"end_character":20},"updated":"2016-02-12 15:13:31.000000000","message":"rename into test_get_default_cookie maybe","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"64237c9f61c963e5b1d1db4b892560277c68300e","unresolved":false,"context_lines":[{"line_number":891,"context_line":"        with ovs_lib.DeferredOVSBridge(self.br) as deferred_br:"},{"line_number":892,"context_line":"            self.assertRaises(AttributeError, getattr, deferred_br, \u0027failure\u0027)"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"    def test_cookies(self):"},{"line_number":895,"context_line":"        self.br \u003d ovs_lib.OVSBridge(\"br-tun\")"},{"line_number":896,"context_line":"        self.assertNotEqual(0, self.br.default_cookie)"},{"line_number":897,"context_line":"        uuid_stamp1 \u003d self.br.get_default_cookie()"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_b75adc81","line":894,"range":{"start_line":894,"start_character":8,"end_line":894,"end_character":20},"in_reply_to":"3a57f1b5_84497062","updated":"2016-02-15 14:09:08.000000000","message":"Done","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":893,"context_line":""},{"line_number":894,"context_line":"    def test_cookies(self):"},{"line_number":895,"context_line":"        self.br \u003d ovs_lib.OVSBridge(\"br-tun\")"},{"line_number":896,"context_line":"        self.assertNotEqual(0, self.br.default_cookie)"},{"line_number":897,"context_line":"        uuid_stamp1 \u003d self.br.get_default_cookie()"},{"line_number":898,"context_line":"        self.assertEqual(uuid_stamp1, self.br.default_cookie)"},{"line_number":899,"context_line":"        self.assertEqual(set([uuid_stamp1]), self.br.reserved_cookies)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_c46a08b3","line":896,"updated":"2016-02-12 15:13:31.000000000","message":"Well technically, 0 can also be generated, right? I guess the check is redundant.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"64237c9f61c963e5b1d1db4b892560277c68300e","unresolved":false,"context_lines":[{"line_number":893,"context_line":""},{"line_number":894,"context_line":"    def test_cookies(self):"},{"line_number":895,"context_line":"        self.br \u003d ovs_lib.OVSBridge(\"br-tun\")"},{"line_number":896,"context_line":"        self.assertNotEqual(0, self.br.default_cookie)"},{"line_number":897,"context_line":"        uuid_stamp1 \u003d self.br.get_default_cookie()"},{"line_number":898,"context_line":"        self.assertEqual(uuid_stamp1, self.br.default_cookie)"},{"line_number":899,"context_line":"        self.assertEqual(set([uuid_stamp1]), self.br.reserved_cookies)"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_975fd871","line":896,"in_reply_to":"3a57f1b5_c46a08b3","updated":"2016-02-15 14:09:08.000000000","message":"Done","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ad23a55b4a3d2c7b6f9194c4e53c8b0bbac25b39","unresolved":false,"context_lines":[{"line_number":917,"context_line":"        self.br \u003d ovs_lib.OVSBridge(\"br-tun\")"},{"line_number":918,"context_line":"        default_cookie \u003d self.br.get_default_cookie()"},{"line_number":919,"context_line":"        self.assertEqual(default_cookie, self.br.default_cookie)"},{"line_number":920,"context_line":"        self.assertEqual(set([default_cookie]), self.br.reserved_cookies)"},{"line_number":921,"context_line":"        self.assertEqual(1, len(self.br.get_reserved_cookies()))"},{"line_number":922,"context_line":"        requested_cookie \u003d self.br.request_cookie()"},{"line_number":923,"context_line":"        self.assertTrue(requested_cookie in self.br.reserved_cookies)"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_cb49af8d","line":920,"updated":"2016-02-15 16:51:31.000000000","message":"I think you should not compare with the attribute. Instead, use get_reserved_cookies() result.","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d15617661a5ff6170dc89a1eddd38f08d4b619bb","unresolved":false,"context_lines":[{"line_number":917,"context_line":"        self.br \u003d ovs_lib.OVSBridge(\"br-tun\")"},{"line_number":918,"context_line":"        default_cookie \u003d self.br.get_default_cookie()"},{"line_number":919,"context_line":"        self.assertEqual(default_cookie, self.br.default_cookie)"},{"line_number":920,"context_line":"        self.assertEqual(set([default_cookie]), self.br.reserved_cookies)"},{"line_number":921,"context_line":"        self.assertEqual(1, len(self.br.get_reserved_cookies()))"},{"line_number":922,"context_line":"        requested_cookie \u003d self.br.request_cookie()"},{"line_number":923,"context_line":"        self.assertTrue(requested_cookie in self.br.reserved_cookies)"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_c74505b4","line":920,"in_reply_to":"dae33548_cb49af8d","updated":"2016-02-18 09:55:09.000000000","message":"Done","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ad23a55b4a3d2c7b6f9194c4e53c8b0bbac25b39","unresolved":false,"context_lines":[{"line_number":918,"context_line":"        default_cookie \u003d self.br.get_default_cookie()"},{"line_number":919,"context_line":"        self.assertEqual(default_cookie, self.br.default_cookie)"},{"line_number":920,"context_line":"        self.assertEqual(set([default_cookie]), self.br.reserved_cookies)"},{"line_number":921,"context_line":"        self.assertEqual(1, len(self.br.get_reserved_cookies()))"},{"line_number":922,"context_line":"        requested_cookie \u003d self.br.request_cookie()"},{"line_number":923,"context_line":"        self.assertTrue(requested_cookie in self.br.reserved_cookies)"},{"line_number":924,"context_line":"        self.assertTrue(requested_cookie in self.br.get_reserved_cookies())"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_ab31cb0d","line":921,"updated":"2016-02-15 16:51:31.000000000","message":"If you go using get_reserved_cookie() result, you don\u0027t need the check.","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d15617661a5ff6170dc89a1eddd38f08d4b619bb","unresolved":false,"context_lines":[{"line_number":918,"context_line":"        default_cookie \u003d self.br.get_default_cookie()"},{"line_number":919,"context_line":"        self.assertEqual(default_cookie, self.br.default_cookie)"},{"line_number":920,"context_line":"        self.assertEqual(set([default_cookie]), self.br.reserved_cookies)"},{"line_number":921,"context_line":"        self.assertEqual(1, len(self.br.get_reserved_cookies()))"},{"line_number":922,"context_line":"        requested_cookie \u003d self.br.request_cookie()"},{"line_number":923,"context_line":"        self.assertTrue(requested_cookie in self.br.reserved_cookies)"},{"line_number":924,"context_line":"        self.assertTrue(requested_cookie in self.br.get_reserved_cookies())"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_8722ddff","line":921,"in_reply_to":"dae33548_ab31cb0d","updated":"2016-02-18 09:55:09.000000000","message":"Done","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ad23a55b4a3d2c7b6f9194c4e53c8b0bbac25b39","unresolved":false,"context_lines":[{"line_number":920,"context_line":"        self.assertEqual(set([default_cookie]), self.br.reserved_cookies)"},{"line_number":921,"context_line":"        self.assertEqual(1, len(self.br.get_reserved_cookies()))"},{"line_number":922,"context_line":"        requested_cookie \u003d self.br.request_cookie()"},{"line_number":923,"context_line":"        self.assertTrue(requested_cookie in self.br.reserved_cookies)"},{"line_number":924,"context_line":"        self.assertTrue(requested_cookie in self.br.get_reserved_cookies())"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"    def test_dump_flows_for(self):"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_2bb13b90","line":923,"updated":"2016-02-15 16:51:31.000000000","message":"I think that check is redundant.","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d15617661a5ff6170dc89a1eddd38f08d4b619bb","unresolved":false,"context_lines":[{"line_number":920,"context_line":"        self.assertEqual(set([default_cookie]), self.br.reserved_cookies)"},{"line_number":921,"context_line":"        self.assertEqual(1, len(self.br.get_reserved_cookies()))"},{"line_number":922,"context_line":"        requested_cookie \u003d self.br.request_cookie()"},{"line_number":923,"context_line":"        self.assertTrue(requested_cookie in self.br.reserved_cookies)"},{"line_number":924,"context_line":"        self.assertTrue(requested_cookie in self.br.get_reserved_cookies())"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"    def test_dump_flows_for(self):"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_954e786d","line":923,"in_reply_to":"dae33548_2bb13b90","updated":"2016-02-18 09:55:09.000000000","message":"Done","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ad23a55b4a3d2c7b6f9194c4e53c8b0bbac25b39","unresolved":false,"context_lines":[{"line_number":921,"context_line":"        self.assertEqual(1, len(self.br.get_reserved_cookies()))"},{"line_number":922,"context_line":"        requested_cookie \u003d self.br.request_cookie()"},{"line_number":923,"context_line":"        self.assertTrue(requested_cookie in self.br.reserved_cookies)"},{"line_number":924,"context_line":"        self.assertTrue(requested_cookie in self.br.get_reserved_cookies())"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"    def test_dump_flows_for(self):"},{"line_number":927,"context_line":"        self.br \u003d ovs_lib.OVSBridge(\"br-int\")"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_ab638b19","line":924,"updated":"2016-02-15 16:51:31.000000000","message":"You may want to check that default_cookie is still reserved.","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d15617661a5ff6170dc89a1eddd38f08d4b619bb","unresolved":false,"context_lines":[{"line_number":921,"context_line":"        self.assertEqual(1, len(self.br.get_reserved_cookies()))"},{"line_number":922,"context_line":"        requested_cookie \u003d self.br.request_cookie()"},{"line_number":923,"context_line":"        self.assertTrue(requested_cookie in self.br.reserved_cookies)"},{"line_number":924,"context_line":"        self.assertTrue(requested_cookie in self.br.get_reserved_cookies())"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"    def test_dump_flows_for(self):"},{"line_number":927,"context_line":"        self.br \u003d ovs_lib.OVSBridge(\"br-int\")"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_7551340e","line":924,"in_reply_to":"dae33548_ab638b19","updated":"2016-02-18 09:55:09.000000000","message":"Done","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ad23a55b4a3d2c7b6f9194c4e53c8b0bbac25b39","unresolved":false,"context_lines":[{"line_number":924,"context_line":"        self.assertTrue(requested_cookie in self.br.get_reserved_cookies())"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"    def test_dump_flows_for(self):"},{"line_number":927,"context_line":"        self.br \u003d ovs_lib.OVSBridge(\"br-int\")"},{"line_number":928,"context_line":"        self.br.delete_flows(table\u003d0)"},{"line_number":929,"context_line":"        self.br.delete_flows(table\u003d23)"},{"line_number":930,"context_line":"        self.br.delete_flows(table\u003d24)"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_0b8717b6","line":927,"updated":"2016-02-15 16:51:31.000000000","message":"Your unit test accesses actual bridge on the system. I presume the test won\u0027t work on a system with no such bridge. Unit tests should not depend on the platform. You either should move the tests into functional suite, or mock out bridge access methods so that the platform is not touched.","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d15617661a5ff6170dc89a1eddd38f08d4b619bb","unresolved":false,"context_lines":[{"line_number":924,"context_line":"        self.assertTrue(requested_cookie in self.br.get_reserved_cookies())"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"    def test_dump_flows_for(self):"},{"line_number":927,"context_line":"        self.br \u003d ovs_lib.OVSBridge(\"br-int\")"},{"line_number":928,"context_line":"        self.br.delete_flows(table\u003d0)"},{"line_number":929,"context_line":"        self.br.delete_flows(table\u003d23)"},{"line_number":930,"context_line":"        self.br.delete_flows(table\u003d24)"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_0081128f","line":927,"in_reply_to":"dae33548_0b8717b6","updated":"2016-02-18 09:55:09.000000000","message":"Having seen how test_dump_flows works, I think that method provides proper test coverage for test_dump_flows_for. As dump_flows_for_table() just calls dump_flows_for() now.","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ad23a55b4a3d2c7b6f9194c4e53c8b0bbac25b39","unresolved":false,"context_lines":[{"line_number":927,"context_line":"        self.br \u003d ovs_lib.OVSBridge(\"br-int\")"},{"line_number":928,"context_line":"        self.br.delete_flows(table\u003d0)"},{"line_number":929,"context_line":"        self.br.delete_flows(table\u003d23)"},{"line_number":930,"context_line":"        self.br.delete_flows(table\u003d24)"},{"line_number":931,"context_line":"        self.br.add_flow(cookie\u003d\u00270x00\u0027, table\u003d0, priority\u003d2, in_port\u003d1,"},{"line_number":932,"context_line":"                         actions\u003d\u0027drop\u0027)"},{"line_number":933,"context_line":"        self.br.add_flow(cookie\u003d\u00270x01\u0027, table\u003d0, priority\u003d3, in_port\u003d1,"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_4b911ff0","line":930,"updated":"2016-02-15 16:51:31.000000000","message":"Those cleanups suggest that you actually work with existing bridge.","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ad23a55b4a3d2c7b6f9194c4e53c8b0bbac25b39","unresolved":false,"context_lines":[{"line_number":934,"context_line":"                         dl_vlan\u003d100, actions\u003d\u0027mod_vlan_vid:1,NORMAL\u0027)"},{"line_number":935,"context_line":"        self.br.add_flow(cookie\u003d\u00270x01\u0027, table\u003d0, priority\u003d1,"},{"line_number":936,"context_line":"                         actions\u003d\u0027NORMAL\u0027)"},{"line_number":937,"context_line":"        self.br.add_flow(cookie\u003d\u00270x02\u0027, table\u003d23, priority\u003d0,"},{"line_number":938,"context_line":"                         actions\u003d\u0027drop\u0027)"},{"line_number":939,"context_line":"        retflows \u003d self.br.dump_flows_for()"},{"line_number":940,"context_line":"        self.assertEqual(4, len(retflows.splitlines()))"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_eb12b361","line":937,"updated":"2016-02-15 16:51:31.000000000","message":"Instead of actually adding flows, you want to mock parts of ovs_lib that return the flows.","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":895,"context_line":"        self.br \u003d ovs_lib.OVSBridge(\"br-tun\")"},{"line_number":896,"context_line":"        uuid_stamp1 \u003d self.br.get_default_cookie()"},{"line_number":897,"context_line":"        self.assertEqual(uuid_stamp1, self.br.default_cookie)"},{"line_number":898,"context_line":"        self.assertEqual(set([uuid_stamp1]), self.br.reserved_cookies)"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"    def test_cookie_passed_to_addmod(self):"},{"line_number":901,"context_line":"        self.br \u003d ovs_lib.OVSBridge(\"br-tun\")"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_03ed97b6","line":898,"range":{"start_line":898,"start_character":25,"end_line":898,"end_character":43},"updated":"2016-02-18 12:07:31.000000000","message":"{uuid_stamp1}","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":910,"context_line":"        with mock.patch.object(self.br, \u0027run_ofctl\u0027) as f:"},{"line_number":911,"context_line":"            with ovs_lib.DeferredOVSBridge(self.br) as deferred_br:"},{"line_number":912,"context_line":"                deferred_br.add_flow(actions\u003d\u0027drop\u0027)"},{"line_number":913,"context_line":"                deferred_br.mod_flow(actions\u003d\u0027drop\u0027)"},{"line_number":914,"context_line":"            f.assert_has_calls(expected_calls)"},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"    def test_reserved_cookies(self):"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_a3b5cb7e","line":913,"range":{"start_line":913,"start_character":16,"end_line":913,"end_character":36},"updated":"2016-02-18 12:07:31.000000000","message":"You should create one test for add_flow separate from another test for mod_flow.","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":915,"context_line":""},{"line_number":916,"context_line":"    def test_reserved_cookies(self):"},{"line_number":917,"context_line":"        self.br \u003d ovs_lib.OVSBridge(\"br-tun\")"},{"line_number":918,"context_line":"        default_cookie \u003d self.br.get_default_cookie()"},{"line_number":919,"context_line":"        self.assertEqual(default_cookie, self.br.get_default_cookie())"},{"line_number":920,"context_line":"        self.assertIn(default_cookie, self.br.get_reserved_cookies())"},{"line_number":921,"context_line":"        requested_cookie \u003d self.br.request_cookie()"},{"line_number":922,"context_line":"        self.assertTrue(default_cookie in self.br.get_reserved_cookies())"},{"line_number":923,"context_line":"        self.assertTrue(requested_cookie in self.br.get_reserved_cookies())"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_d6440f4b","line":920,"range":{"start_line":918,"start_character":8,"end_line":920,"end_character":69},"updated":"2016-02-18 12:07:31.000000000","message":"This test part overlaps with test_get_default_cookie. Create a test specific for request_cookie only checking that it changes the default_cookie and it modify reserved cookies.\n\nAlways test behaviours before than state access methods.\n\nget_reserved_cookies and get_default_cookie don\u0027t implement any real behaviours they are just simple getters. Therefore testing them is not so important.\n\novs_lib.OVSBridge constructor and request_cookie instead implements behaviours that have to be tested.\n\nBest and easy to maintain way to test behaviours I think is writing a test divided it 3 parts:\n\n- set initial state and prepare parameters: GIVEN section where you create test fixtures\n- run tested method (tested behaviour): WHEN section where you call tested method\n- verify final state: THEN section where you call assert methods.\n\nYou should have a different test for each combination initials tate + method parameters you want to test.\n\nPlease read something about behaviour driven development: it would give you a simple pattern to follow when writing tests for your code.","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"15e5c4ac7225b3bd34104d566c788298aa4e4d83","unresolved":false,"context_lines":[{"line_number":905,"context_line":"        expected_calls \u003d ["},{"line_number":906,"context_line":"            mock.call(\u0027add-flows\u0027, [\u0027-\u0027],"},{"line_number":907,"context_line":"                      \u0027hard_timeout\u003d0,idle_timeout\u003d0,priority\u003d1,\u0027"},{"line_number":908,"context_line":"                      \u0027cookie\u003d\u0027 + str(stamp) + \u0027,actions\u003ddrop\u0027),"},{"line_number":909,"context_line":"            mock.call(\u0027mod-flows\u0027, [\u0027-\u0027],"},{"line_number":910,"context_line":"                      \u0027cookie\u003d\u0027 + str(stamp) + \u0027,actions\u003ddrop\u0027)"},{"line_number":911,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_ed5e0411","line":908,"range":{"start_line":908,"start_character":34,"end_line":908,"end_character":44},"updated":"2016-02-22 16:43:36.000000000","message":"nitty nit: could calculate it once","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d0ef73d7b0b3793499639fe005fb75743bc8aea3","unresolved":false,"context_lines":[{"line_number":905,"context_line":"        expected_calls \u003d ["},{"line_number":906,"context_line":"            mock.call(\u0027add-flows\u0027, [\u0027-\u0027],"},{"line_number":907,"context_line":"                      \u0027hard_timeout\u003d0,idle_timeout\u003d0,priority\u003d1,\u0027"},{"line_number":908,"context_line":"                      \u0027cookie\u003d\u0027 + str(stamp) + \u0027,actions\u003ddrop\u0027),"},{"line_number":909,"context_line":"            mock.call(\u0027mod-flows\u0027, [\u0027-\u0027],"},{"line_number":910,"context_line":"                      \u0027cookie\u003d\u0027 + str(stamp) + \u0027,actions\u003ddrop\u0027)"},{"line_number":911,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_589ea863","line":908,"range":{"start_line":908,"start_character":34,"end_line":908,"end_character":44},"in_reply_to":"bae84128_ed5e0411","updated":"2016-02-23 11:01:24.000000000","message":"Done","commit_id":"64076674d3caaaf4e804cb7d3b241a9c068674e9"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/openflow/native/ovs_bridge_test_base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                                    vif_mac\u003dvif_mac,"},{"line_number":218,"context_line":"                                    dvr_mac_address\u003ddvr_mac_address)"},{"line_number":219,"context_line":"        (dp, ofp, ofpp) \u003d self._get_dp()"},{"line_number":220,"context_line":"        stamp \u003d self.br.get_default_cookie()"},{"line_number":221,"context_line":"        expected \u003d ["},{"line_number":222,"context_line":"            call._send_msg(ofpp.OFPFlowMod(dp,"},{"line_number":223,"context_line":"                cookie\u003dstamp,"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_04f10001","line":220,"updated":"2016-02-12 15:13:31.000000000","message":"nit: since you duplicate the call in each test, maybe it\u0027s worth doing the call in setUp and storing it f.e. as self.stamp, then reusing everywhere.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"64237c9f61c963e5b1d1db4b892560277c68300e","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                                    vif_mac\u003dvif_mac,"},{"line_number":218,"context_line":"                                    dvr_mac_address\u003ddvr_mac_address)"},{"line_number":219,"context_line":"        (dp, ofp, ofpp) \u003d self._get_dp()"},{"line_number":220,"context_line":"        stamp \u003d self.br.get_default_cookie()"},{"line_number":221,"context_line":"        expected \u003d ["},{"line_number":222,"context_line":"            call._send_msg(ofpp.OFPFlowMod(dp,"},{"line_number":223,"context_line":"                cookie\u003dstamp,"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_b2094a2f","line":220,"in_reply_to":"3a57f1b5_04f10001","updated":"2016-02-15 14:09:08.000000000","message":"Done","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def setup_bridge_mock(self, name, cls):"},{"line_number":36,"context_line":"        self.br \u003d cls(name)"},{"line_number":37,"context_line":"        self.stamp \u003d self.br.get_default_cookie()"},{"line_number":38,"context_line":"        self.dp \u003d mock.Mock()"},{"line_number":39,"context_line":"        self.ofp \u003d importutils.import_module(self._OFP_MODULE)"},{"line_number":40,"context_line":"        self.ofpp \u003d importutils.import_module(self._OFPP_MODULE)"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_74b25be6","line":37,"range":{"start_line":37,"start_character":21,"end_line":37,"end_character":49},"updated":"2016-02-18 12:07:31.000000000","message":"self.default_cookie","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/openflow/native/test_br_int.py":[{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(OVSIntegrationBridgeTest, self).setUp()"},{"line_number":29,"context_line":"        self.setup_bridge_mock(\u0027br-int\u0027, self.br_int_cls)"},{"line_number":30,"context_line":"        self.stamp \u003d self.br.get_default_cookie()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def test_setup_default_table(self):"},{"line_number":33,"context_line":"        self.br.setup_default_table()"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_14db0f1c","line":30,"range":{"start_line":30,"start_character":21,"end_line":30,"end_character":49},"updated":"2016-02-18 12:07:31.000000000","message":"self.default_cookie","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/openflow/native/test_br_phys.py":[{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def setUp(self):"},{"line_number":34,"context_line":"        super(OVSPhysicalBridgeTest, self).setUp()"},{"line_number":35,"context_line":"        self.setup_bridge_mock(\u0027br-phys\u0027, self.br_phys_cls)"},{"line_number":36,"context_line":"        self.stamp \u003d self.br.get_default_cookie()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_setup_default_table(self):"},{"line_number":39,"context_line":"        self.br.setup_default_table()"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_d4fb6777","line":36,"range":{"start_line":36,"start_character":21,"end_line":36,"end_character":49},"updated":"2016-02-18 12:07:31.000000000","message":"self.br.default_cookie","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/openflow/native/test_br_tun.py":[{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def setUp(self):"},{"line_number":34,"context_line":"        super(OVSTunnelBridgeTest, self).setUp()"},{"line_number":35,"context_line":"        self.setup_bridge_mock(\u0027br-tun\u0027, self.br_tun_cls)"},{"line_number":36,"context_line":"        self.stamp \u003d self.br.get_default_cookie()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_setup_default_table(self):"},{"line_number":39,"context_line":"        patch_int_ofport \u003d 5555"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_94343f4a","line":36,"range":{"start_line":36,"start_character":21,"end_line":36,"end_character":49},"updated":"2016-02-18 12:07:31.000000000","message":"self.r.default_cookie","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/openflow/ovs_ofctl/test_br_tun.py":[{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def setUp(self):"},{"line_number":35,"context_line":"        super(OVSTunnelBridgeTest, self).setUp()"},{"line_number":36,"context_line":"        self.setup_bridge_mock(\u0027br-tun\u0027, self.br_tun_cls)"},{"line_number":37,"context_line":"        self.stamp \u003d self.br.get_default_cookie()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def test_setup_default_table(self):"},{"line_number":40,"context_line":"        patch_int_ofport \u003d 5555"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_14202ff6","line":37,"range":{"start_line":37,"start_character":21,"end_line":37,"end_character":49},"updated":"2016-02-18 12:07:31.000000000","message":"self.r.default_cookie","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_agent_extension_api.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.agent.common import ovs_lib"},{"line_number":20,"context_line":"from neutron.plugins.ml2.drivers.openvswitch.agent \\"},{"line_number":21,"context_line":"    import ovs_agent_extension_api"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Useful global variables."}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_806ec0c7","line":21,"range":{"start_line":21,"start_character":11,"end_line":21,"end_character":34},"updated":"2016-02-10 14:28:42.000000000","message":"I suggest you have some shorter alias for the module.","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8327571bd8ed14cff119cc67e1a4296a2694d4a4","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.agent.common import ovs_lib"},{"line_number":20,"context_line":"from neutron.plugins.ml2.drivers.openvswitch.agent \\"},{"line_number":21,"context_line":"    import ovs_agent_extension_api"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Useful global variables."}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_6c19fa87","line":21,"range":{"start_line":21,"start_character":11,"end_line":21,"end_character":34},"in_reply_to":"3a57f1b5_806ec0c7","updated":"2016-02-11 17:00:20.000000000","message":"Done","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Useful global variables."},{"line_number":25,"context_line":"call \u003d mock.call"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class TestOVSAgentExtensionAPI(object):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_e379be94","line":25,"updated":"2016-02-10 14:28:42.000000000","message":"not used?","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class TestOVSAgentExtensionAPI(object):"},{"line_number":29,"context_line":"    def setup_bridge_mock(self):"},{"line_number":30,"context_line":"        self.br_int \u003d ovs_lib.OVSBridge(\"br-int\")"},{"line_number":31,"context_line":"        self.br_tun \u003d ovs_lib.OVSBridge(\"br-tun\")"},{"line_number":32,"context_line":"        self.mock \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_a05c1c26","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":25},"updated":"2016-02-10 14:28:42.000000000","message":"Where is it triggered?..","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8327571bd8ed14cff119cc67e1a4296a2694d4a4","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class TestOVSAgentExtensionAPI(object):"},{"line_number":29,"context_line":"    def setup_bridge_mock(self):"},{"line_number":30,"context_line":"        self.br_int \u003d ovs_lib.OVSBridge(\"br-int\")"},{"line_number":31,"context_line":"        self.br_tun \u003d ovs_lib.OVSBridge(\"br-tun\")"},{"line_number":32,"context_line":"        self.mock \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_bf8cf27f","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":25},"in_reply_to":"3a57f1b5_a05c1c26","updated":"2016-02-11 17:00:20.000000000","message":"Done","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def test_request_int_br(self):"},{"line_number":35,"context_line":"        agent_extension_api \u003d ovs_agent_extension_api. \\"},{"line_number":36,"context_line":"                              OVSAgentExtensionAPI(self.br_int, self.br_tun)"},{"line_number":37,"context_line":"        self.assertNotEqual(None, agent_extension_api."},{"line_number":38,"context_line":"                            request_int_br())"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_request_tun_br(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_a0173c50","line":37,"updated":"2016-02-10 14:28:42.000000000","message":"Don\u0027t you want to e.g. check cookie or name?","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8327571bd8ed14cff119cc67e1a4296a2694d4a4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def test_request_int_br(self):"},{"line_number":35,"context_line":"        agent_extension_api \u003d ovs_agent_extension_api. \\"},{"line_number":36,"context_line":"                              OVSAgentExtensionAPI(self.br_int, self.br_tun)"},{"line_number":37,"context_line":"        self.assertNotEqual(None, agent_extension_api."},{"line_number":38,"context_line":"                            request_int_br())"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_request_tun_br(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_cc2b4e93","line":37,"in_reply_to":"3a57f1b5_a0173c50","updated":"2016-02-11 17:00:20.000000000","message":"Done","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                              OVSAgentExtensionAPI(self.br_int, self.br_tun)"},{"line_number":43,"context_line":"        self.assertNotEqual(None, agent_extension_api."},{"line_number":44,"context_line":"                            request_tun_br())"},{"line_number":45,"context_line":"        br_tun \u003d None"},{"line_number":46,"context_line":"        agent_extension_api \u003d ovs_agent_extension_api.OVSAgentExtensionAPI("},{"line_number":47,"context_line":"                                                      self.br_int, br_tun)"},{"line_number":48,"context_line":"        self.assertEqual(None, agent_extension_api."}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_c3ffe2ff","line":45,"updated":"2016-02-10 14:28:42.000000000","message":"please split None version into a separate test case.","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8327571bd8ed14cff119cc67e1a4296a2694d4a4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                              OVSAgentExtensionAPI(self.br_int, self.br_tun)"},{"line_number":43,"context_line":"        self.assertNotEqual(None, agent_extension_api."},{"line_number":44,"context_line":"                            request_tun_br())"},{"line_number":45,"context_line":"        br_tun \u003d None"},{"line_number":46,"context_line":"        agent_extension_api \u003d ovs_agent_extension_api.OVSAgentExtensionAPI("},{"line_number":47,"context_line":"                                                      self.br_int, br_tun)"},{"line_number":48,"context_line":"        self.assertEqual(None, agent_extension_api."}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_0c096631","line":45,"in_reply_to":"3a57f1b5_c3ffe2ff","updated":"2016-02-11 17:00:20.000000000","message":"Done","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        br_tun \u003d None"},{"line_number":46,"context_line":"        agent_extension_api \u003d ovs_agent_extension_api.OVSAgentExtensionAPI("},{"line_number":47,"context_line":"                                                      self.br_int, br_tun)"},{"line_number":48,"context_line":"        self.assertEqual(None, agent_extension_api."},{"line_number":49,"context_line":"                         request_tun_br())"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_600aa428","line":48,"updated":"2016-02-10 14:28:42.000000000","message":"ditto","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8327571bd8ed14cff119cc67e1a4296a2694d4a4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        br_tun \u003d None"},{"line_number":46,"context_line":"        agent_extension_api \u003d ovs_agent_extension_api.OVSAgentExtensionAPI("},{"line_number":47,"context_line":"                                                      self.br_int, br_tun)"},{"line_number":48,"context_line":"        self.assertEqual(None, agent_extension_api."},{"line_number":49,"context_line":"                         request_tun_br())"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_ac07f21a","line":48,"in_reply_to":"3a57f1b5_600aa428","updated":"2016-02-11 17:00:20.000000000","message":"Done","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    import ovs_agent_extension_api as ovs_ext_agt"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TestOVSAgentExtensionAPI(object):"},{"line_number":25,"context_line":"    def setup_bridge_mock(self):"},{"line_number":26,"context_line":"        if self.br_int is None:"},{"line_number":27,"context_line":"            self.br_int \u003d ovs_lib.OVSBridge(\"br-int\")"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_a467ccb5","line":24,"updated":"2016-02-12 15:13:31.000000000","message":"The test is not executed at all. And would fail hard if you would try to execute it. Please inherit from base.BaseTestCase.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"64237c9f61c963e5b1d1db4b892560277c68300e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    import ovs_agent_extension_api as ovs_ext_agt"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TestOVSAgentExtensionAPI(object):"},{"line_number":25,"context_line":"    def setup_bridge_mock(self):"},{"line_number":26,"context_line":"        if self.br_int is None:"},{"line_number":27,"context_line":"            self.br_int \u003d ovs_lib.OVSBridge(\"br-int\")"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_e64673be","line":24,"in_reply_to":"3a57f1b5_a467ccb5","updated":"2016-02-15 14:09:08.000000000","message":"Done","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TestOVSAgentExtensionAPI(object):"},{"line_number":25,"context_line":"    def setup_bridge_mock(self):"},{"line_number":26,"context_line":"        if self.br_int is None:"},{"line_number":27,"context_line":"            self.br_int \u003d ovs_lib.OVSBridge(\"br-int\")"},{"line_number":28,"context_line":"            self.br_tun \u003d ovs_lib.OVSBridge(\"br-tun\")"},{"line_number":29,"context_line":"        self.mock \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_e4cdc485","line":26,"updated":"2016-02-12 15:13:31.000000000","message":"that would result in AttributeError if only the code would execute.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        if self.br_int is None:"},{"line_number":27,"context_line":"            self.br_int \u003d ovs_lib.OVSBridge(\"br-int\")"},{"line_number":28,"context_line":"            self.br_tun \u003d ovs_lib.OVSBridge(\"br-tun\")"},{"line_number":29,"context_line":"        self.mock \u003d mock.Mock()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def test_request_int_br(self):"},{"line_number":32,"context_line":"        self.setup_bridge_mock()"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_048020f6","line":29,"updated":"2016-02-12 15:13:31.000000000","message":"not used?","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        self.mock \u003d mock.Mock()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def test_request_int_br(self):"},{"line_number":32,"context_line":"        self.setup_bridge_mock()"},{"line_number":33,"context_line":"        agent_extension_api \u003d ovs_ext_agt.OVSAgentExtensionAPI(self.br_int,"},{"line_number":34,"context_line":"                                                               self.br_tun)"},{"line_number":35,"context_line":"        new_int_br \u003d agent_extension_api.request_int_br()"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_44913846","line":32,"updated":"2016-02-12 15:13:31.000000000","message":"if you need to call some code for every test case, put it in setUp(self).","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.assertTrue(new_int_br.get_default_cookie() in"},{"line_number":39,"context_line":"                        self.br_int.get_reserved_cookies())"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_request_tun_br(self):"},{"line_number":42,"context_line":"        self.setup_bridge_mock()"},{"line_number":43,"context_line":"        agent_extension_api \u003d ovs_ext_agt.OVSAgentExtensionAPI(self.br_int,"},{"line_number":44,"context_line":"                                                               self.br_tun)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_447b78f5","line":41,"updated":"2016-02-12 15:13:31.000000000","message":"Those two cases for tun_br and int_br are duplicate. Please move common pieces into a helper method and reuse.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.assertNotEqual(None, new_tun_br)"},{"line_number":47,"context_line":"        self.assertEqual(self.br_tun.br_name, new_tun_br.br_name)"},{"line_number":48,"context_line":"        self.assertTrue(new_tun_br.get_default_cookie() in"},{"line_number":49,"context_line":"                        self.br_tun.get_reserved_cookies())"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_request_tun_br_None(self):"},{"line_number":52,"context_line":"        br_tun \u003d None"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_6419d4d6","line":49,"updated":"2016-02-12 15:13:31.000000000","message":"You also want to check that new_tun_br default cookie is different from self.br_tun one.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.assertTrue(new_tun_br.get_default_cookie() in"},{"line_number":49,"context_line":"                        self.br_tun.get_reserved_cookies())"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_request_tun_br_None(self):"},{"line_number":52,"context_line":"        br_tun \u003d None"},{"line_number":53,"context_line":"        agent_extension_api \u003d ovs_ext_agt.OVSAgentExtensionAPI(self.br_int,"},{"line_number":54,"context_line":"                                                               br_tun)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_e4d064f8","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":32},"updated":"2016-02-12 15:13:31.000000000","message":"rename: test_request_tun_br_tunneling_disabled","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                        self.br_tun.get_reserved_cookies())"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_request_tun_br_None(self):"},{"line_number":52,"context_line":"        br_tun \u003d None"},{"line_number":53,"context_line":"        agent_extension_api \u003d ovs_ext_agt.OVSAgentExtensionAPI(self.br_int,"},{"line_number":54,"context_line":"                                                               br_tun)"},{"line_number":55,"context_line":"        self.assertIsNone(agent_extension_api.request_tun_br())"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_24019c6a","line":52,"updated":"2016-02-12 15:13:31.000000000","message":"no need for the variable, just pass None directly.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ad23a55b4a3d2c7b6f9194c4e53c8b0bbac25b39","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.tests import base"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def test_bridge(test, orig_bridge, new_bridge):"},{"line_number":24,"context_line":"    test.assertNotEqual(None, new_bridge)"},{"line_number":25,"context_line":"    test.assertEqual(orig_bridge.br_name, new_bridge.br_name)"},{"line_number":26,"context_line":"    test.assertTrue(new_bridge.get_default_cookie() in"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_ee576100","line":23,"updated":"2016-02-15 16:51:31.000000000","message":"Why isn\u0027t it part of the class (just rename it into _test_bridge so that it\u0027s not triggered by testtools implicitly)?","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ad23a55b4a3d2c7b6f9194c4e53c8b0bbac25b39","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def test_bridge(test, orig_bridge, new_bridge):"},{"line_number":24,"context_line":"    test.assertNotEqual(None, new_bridge)"},{"line_number":25,"context_line":"    test.assertEqual(orig_bridge.br_name, new_bridge.br_name)"},{"line_number":26,"context_line":"    test.assertTrue(new_bridge.get_default_cookie() in"},{"line_number":27,"context_line":"                    orig_bridge.get_reserved_cookies())"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_8e797596","line":24,"updated":"2016-02-15 16:51:31.000000000","message":"self.assertIsNotNone","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ad23a55b4a3d2c7b6f9194c4e53c8b0bbac25b39","unresolved":false,"context_lines":[{"line_number":23,"context_line":"def test_bridge(test, orig_bridge, new_bridge):"},{"line_number":24,"context_line":"    test.assertNotEqual(None, new_bridge)"},{"line_number":25,"context_line":"    test.assertEqual(orig_bridge.br_name, new_bridge.br_name)"},{"line_number":26,"context_line":"    test.assertTrue(new_bridge.get_default_cookie() in"},{"line_number":27,"context_line":"                    orig_bridge.get_reserved_cookies())"},{"line_number":28,"context_line":"    test.assertFalse(orig_bridge.get_default_cookie() \u003d\u003d"},{"line_number":29,"context_line":"                     new_bridge.get_default_cookie())"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_6e6351dd","line":26,"updated":"2016-02-15 16:51:31.000000000","message":"assertIn","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ad23a55b4a3d2c7b6f9194c4e53c8b0bbac25b39","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    test.assertEqual(orig_bridge.br_name, new_bridge.br_name)"},{"line_number":26,"context_line":"    test.assertTrue(new_bridge.get_default_cookie() in"},{"line_number":27,"context_line":"                    orig_bridge.get_reserved_cookies())"},{"line_number":28,"context_line":"    test.assertFalse(orig_bridge.get_default_cookie() \u003d\u003d"},{"line_number":29,"context_line":"                     new_bridge.get_default_cookie())"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_ae9b99c8","line":28,"updated":"2016-02-15 16:51:31.000000000","message":"self.assertNotEqual","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def _test_bridge(self, orig_bridge, new_bridge):"},{"line_number":31,"context_line":"        self.assertIsNotNone(new_bridge)"},{"line_number":32,"context_line":"        self.assertEqual(orig_bridge.br_name, new_bridge.br_name)"},{"line_number":33,"context_line":"        self.assertIn(new_bridge.get_default_cookie(),"},{"line_number":34,"context_line":"                    orig_bridge.get_reserved_cookies())"},{"line_number":35,"context_line":"        self.assertNotEqual(orig_bridge.get_default_cookie(),"},{"line_number":36,"context_line":"                     new_bridge.get_default_cookie())"}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_5463d741","line":33,"range":{"start_line":33,"start_character":33,"end_line":33,"end_character":51},"updated":"2016-02-18 12:07:31.000000000","message":"new_bridge.default_cookie","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"7e222b3e7230d97aaa2a8fe215141de29ba71758","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.assertIsNotNone(new_bridge)"},{"line_number":32,"context_line":"        self.assertEqual(orig_bridge.br_name, new_bridge.br_name)"},{"line_number":33,"context_line":"        self.assertIn(new_bridge.get_default_cookie(),"},{"line_number":34,"context_line":"                    orig_bridge.get_reserved_cookies())"},{"line_number":35,"context_line":"        self.assertNotEqual(orig_bridge.get_default_cookie(),"},{"line_number":36,"context_line":"                     new_bridge.get_default_cookie())"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"dae33548_14e5cfa6","line":34,"range":{"start_line":34,"start_character":20,"end_line":34,"end_character":54},"updated":"2016-02-18 12:07:31.000000000","message":"rig_bridge.reserved_cookies","commit_id":"c35614a735c1661d0a02fb12ba71532e71091899"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"107b20247663a1a951217ebd9859f04ae3215b5f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    import ovs_agent_extension_api as ovs_ext_agt"},{"line_number":22,"context_line":"from neutron.tests import base"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import logging"},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"dae33548_1c431f6d","line":24,"updated":"2016-02-18 18:16:28.000000000","message":"Import logging at the beginning as it is a standard python module.","commit_id":"88ac12da0bbb03d36bf3bf5d253774e882e2b7c2"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"107b20247663a1a951217ebd9859f04ae3215b5f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self.assertIsNone(agent_extension_api.request_tun_br())"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class TestOVSCookieBridge(base.BaseTestCase):"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def setUp(self):"},{"line_number":64,"context_line":"        super(TestOVSCookieBridge, self).setUp()"}],"source_content_type":"text/x-python","patch_set":22,"id":"dae33548_e742240e","line":61,"updated":"2016-02-18 18:16:28.000000000","message":"Use DietTestCase: it automatically rollback all mock patching.","commit_id":"88ac12da0bbb03d36bf3bf5d253774e882e2b7c2"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"107b20247663a1a951217ebd9859f04ae3215b5f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.br.do_action_flows \u003d mock.Mock()"},{"line_number":67,"context_line":"        self.tested_bridge \u003d ovs_ext_agt.OVSCookieBridge(self.br)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def check_flow_params(self):"},{"line_number":70,"context_line":"        LOG.warning(\"mock: %s\", self.br.do_action_flows)"},{"line_number":71,"context_line":"        LOG.warning(\"mock: %s\", self.br.do_action_flows.call_args)"},{"line_number":72,"context_line":"        self.assertIsNot(0, self.br.do_action_flows.call_count)"}],"source_content_type":"text/x-python","patch_set":22,"id":"dae33548_477f9014","line":69,"updated":"2016-02-18 18:16:28.000000000","message":"Reusing code there makes tests hard to understand. Expecially self.br.do_action_flows.call_args[0][1][0] is not selfdocumenting. What is it?\n\nThis code is too implicit and it is hard to understand what it is tested.","commit_id":"88ac12da0bbb03d36bf3bf5d253774e882e2b7c2"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"107b20247663a1a951217ebd9859f04ae3215b5f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.tested_bridge \u003d ovs_ext_agt.OVSCookieBridge(self.br)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def check_flow_params(self):"},{"line_number":70,"context_line":"        LOG.warning(\"mock: %s\", self.br.do_action_flows)"},{"line_number":71,"context_line":"        LOG.warning(\"mock: %s\", self.br.do_action_flows.call_args)"},{"line_number":72,"context_line":"        self.assertIsNot(0, self.br.do_action_flows.call_count)"},{"line_number":73,"context_line":"        flow_params \u003d self.br.do_action_flows.call_args[0][1][0]"}],"source_content_type":"text/x-python","patch_set":22,"id":"dae33548_a7a65cbe","line":70,"updated":"2016-02-18 18:16:28.000000000","message":"This should be debug and not warning.","commit_id":"88ac12da0bbb03d36bf3bf5d253774e882e2b7c2"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"107b20247663a1a951217ebd9859f04ae3215b5f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.assertIsNot(0, self.br.do_action_flows.call_count)"},{"line_number":73,"context_line":"        flow_params \u003d self.br.do_action_flows.call_args[0][1][0]"},{"line_number":74,"context_line":"        self.assertIn(\"cookie\", flow_params)"},{"line_number":75,"context_line":"        self.assertEquals(self.tested_bridge.get_default_cookie(), flow_params[\u0027cookie\u0027])"},{"line_number":76,"context_line":"        self.br.do_action_flows.reset_mock()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def testAddFlow(self):"}],"source_content_type":"text/x-python","patch_set":22,"id":"dae33548_87b8782b","line":75,"range":{"start_line":75,"start_character":26,"end_line":75,"end_character":65},"updated":"2016-02-18 18:16:28.000000000","message":"self.tested_bridge.default_cookie","commit_id":"88ac12da0bbb03d36bf3bf5d253774e882e2b7c2"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"107b20247663a1a951217ebd9859f04ae3215b5f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        flow_params \u003d self.br.do_action_flows.call_args[0][1][0]"},{"line_number":74,"context_line":"        self.assertIn(\"cookie\", flow_params)"},{"line_number":75,"context_line":"        self.assertEquals(self.tested_bridge.get_default_cookie(), flow_params[\u0027cookie\u0027])"},{"line_number":76,"context_line":"        self.br.do_action_flows.reset_mock()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def testAddFlow(self):"},{"line_number":79,"context_line":"        self.tested_bridge.add_flow(in_port\u003d1, actions\u003d\"output:2\")"}],"source_content_type":"text/x-python","patch_set":22,"id":"dae33548_870238b2","line":76,"updated":"2016-02-18 18:16:28.000000000","message":"If test fails before gere this rollback will not be performed. This line should not be here.","commit_id":"88ac12da0bbb03d36bf3bf5d253774e882e2b7c2"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"4816c71dc77e95efec9abfc0afe4de14341724e9","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.assertEquals(self.tested_bridge.get_default_cookie(), flow_params[\u0027cookie\u0027])"},{"line_number":76,"context_line":"        self.br.do_action_flows.reset_mock()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def testAddFlow(self):"},{"line_number":79,"context_line":"        self.tested_bridge.add_flow(in_port\u003d1, actions\u003d\"output:2\")"},{"line_number":80,"context_line":"        self.check_flow_params()"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"dae33548_b694d436","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":19},"updated":"2016-02-18 17:47:26.000000000","message":"Suggest changing method name to test_add_flow, and similarly for the next two method names.","commit_id":"88ac12da0bbb03d36bf3bf5d253774e882e2b7c2"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"107b20247663a1a951217ebd9859f04ae3215b5f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.assertEquals(self.tested_bridge.get_default_cookie(), flow_params[\u0027cookie\u0027])"},{"line_number":76,"context_line":"        self.br.do_action_flows.reset_mock()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def testAddFlow(self):"},{"line_number":79,"context_line":"        self.tested_bridge.add_flow(in_port\u003d1, actions\u003d\"output:2\")"},{"line_number":80,"context_line":"        self.check_flow_params()"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"dae33548_47231056","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":19},"in_reply_to":"dae33548_b694d436","updated":"2016-02-18 18:16:28.000000000","message":"Indeed.","commit_id":"88ac12da0bbb03d36bf3bf5d253774e882e2b7c2"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"107b20247663a1a951217ebd9859f04ae3215b5f","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def testAddFlow(self):"},{"line_number":79,"context_line":"        self.tested_bridge.add_flow(in_port\u003d1, actions\u003d\"output:2\")"},{"line_number":80,"context_line":"        self.check_flow_params()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def testModFlow(self):"},{"line_number":83,"context_line":"        self.tested_bridge.mod_flow(in_port\u003d1, actions\u003d\"output:2\")"}],"source_content_type":"text/x-python","patch_set":22,"id":"dae33548_e784e4d3","line":80,"updated":"2016-02-18 18:16:28.000000000","message":"Make this code explicit: replace this with something like:\n\nself.br.do_action_flows.assert_called_once_with(...)","commit_id":"88ac12da0bbb03d36bf3bf5d253774e882e2b7c2"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"107b20247663a1a951217ebd9859f04ae3215b5f","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def testModFlow(self):"},{"line_number":83,"context_line":"        self.tested_bridge.mod_flow(in_port\u003d1, actions\u003d\"output:2\")"},{"line_number":84,"context_line":"        self.check_flow_params()"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def testDelFlows(self):"},{"line_number":87,"context_line":"        self.tested_bridge.delete_flows(in_port\u003d1)"}],"source_content_type":"text/x-python","patch_set":22,"id":"dae33548_6771f40b","line":84,"updated":"2016-02-18 18:16:28.000000000","message":"Make this code explicit: replace this with something like:\nself.br.do_action_flows.assert_called_once_with(...)","commit_id":"88ac12da0bbb03d36bf3bf5d253774e882e2b7c2"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"107b20247663a1a951217ebd9859f04ae3215b5f","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def testDelFlows(self):"},{"line_number":87,"context_line":"        self.tested_bridge.delete_flows(in_port\u003d1)"},{"line_number":88,"context_line":"        self.check_flow_params()"}],"source_content_type":"text/x-python","patch_set":22,"id":"dae33548_874d18c6","line":88,"updated":"2016-02-18 18:16:28.000000000","message":"Make this code explicit: replace this with something like:\nself.br.do_action_flows.assert_called_once_with(...)","commit_id":"88ac12da0bbb03d36bf3bf5d253774e882e2b7c2"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"ecccb8b8a65541cf026c0145f1ac0b2eb8e1fdc8","unresolved":false,"context_lines":[{"line_number":123,"context_line":"              \"cookie\": str(1234) + \u0027/-1\u0027}]"},{"line_number":124,"context_line":"        )"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_mod_flow_with_hash(self):"},{"line_number":127,"context_line":"        self.tested_bridge.mod_flow(cookie\u003d\u00271234/3\u0027,"},{"line_number":128,"context_line":"                                    in_port\u003d1, actions\u003d\"output:2\")"},{"line_number":129,"context_line":"        self.bridge.do_action_flows.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":25,"id":"bae84128_edbe60fe","line":126,"updated":"2016-02-19 16:25:55.000000000","message":"(I think \u0027mask\u0027 is the right term, rather than \u0027hash\u0027)","commit_id":"bba130278b0fd25e49d3f54e811206100466108a"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":1816,"context_line":"class TestOvsNeutronAgentOFCtl(TestOvsNeutronAgent,"},{"line_number":1817,"context_line":"                               ovs_test_base.OVSOFCtlTestBase):"},{"line_number":1818,"context_line":"    def test_cleanup_stale_flows(self):"},{"line_number":1819,"context_line":"        with mock.patch.object(self.agent.int_br, \u0027default_cookie\u0027,"},{"line_number":1820,"context_line":"                               new\u003d1234),\\"},{"line_number":1821,"context_line":"            mock.patch.object(self.agent.int_br,"},{"line_number":1822,"context_line":"                              \u0027dump_flows_all_tables\u0027) as dump_flows,\\"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_e3a0def6","line":1819,"updated":"2016-02-10 14:28:42.000000000","message":"Wouldn\u0027t it be more correct to mock get_default_cookie instead?","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c4d71fa2c683e02f3e36092450aa27698393f5c","unresolved":false,"context_lines":[{"line_number":1841,"context_line":"                             ovs_test_base.OVSRyuTestBase):"},{"line_number":1842,"context_line":"    def test_cleanup_stale_flows(self):"},{"line_number":1843,"context_line":"        uint64_max \u003d (1 \u003c\u003c 64) - 1"},{"line_number":1844,"context_line":"        with mock.patch.object(self.agent.int_br, \u0027default_cookie\u0027,"},{"line_number":1845,"context_line":"                               new\u003d1234),\\"},{"line_number":1846,"context_line":"            mock.patch.object(self.agent.int_br,"},{"line_number":1847,"context_line":"                              \u0027dump_flows\u0027) as dump_flows,\\"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_a3aae6d2","line":1844,"updated":"2016-02-10 14:28:42.000000000","message":"ditto","commit_id":"3e7ea9f843c69822ec912d1591d450d253cb6d15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":1816,"context_line":"class TestOvsNeutronAgentOFCtl(TestOvsNeutronAgent,"},{"line_number":1817,"context_line":"                               ovs_test_base.OVSOFCtlTestBase):"},{"line_number":1818,"context_line":"    def test_cleanup_stale_flows(self):"},{"line_number":1819,"context_line":"        with mock.patch.object(self.agent.int_br, \"default_cookie\","},{"line_number":1820,"context_line":"                               new\u003d1234),\\"},{"line_number":1821,"context_line":"            mock.patch.object(self.agent.int_br,"},{"line_number":1822,"context_line":"                              \u0027dump_flows_all_tables\u0027) as dump_flows,\\"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_9f6779b6","line":1819,"updated":"2016-02-12 15:13:31.000000000","message":"Instead of mocking, I guess we can just call the setter method. Then you won\u0027t need lines 1825-1826.","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"64237c9f61c963e5b1d1db4b892560277c68300e","unresolved":false,"context_lines":[{"line_number":1816,"context_line":"class TestOvsNeutronAgentOFCtl(TestOvsNeutronAgent,"},{"line_number":1817,"context_line":"                               ovs_test_base.OVSOFCtlTestBase):"},{"line_number":1818,"context_line":"    def test_cleanup_stale_flows(self):"},{"line_number":1819,"context_line":"        with mock.patch.object(self.agent.int_br, \"default_cookie\","},{"line_number":1820,"context_line":"                               new\u003d1234),\\"},{"line_number":1821,"context_line":"            mock.patch.object(self.agent.int_br,"},{"line_number":1822,"context_line":"                              \u0027dump_flows_all_tables\u0027) as dump_flows,\\"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_4612bfb5","line":1819,"in_reply_to":"3a57f1b5_9f6779b6","updated":"2016-02-15 14:09:08.000000000","message":"Done","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97d2cc7d36d223269d4e3c9f2e1fdf6464647a1d","unresolved":false,"context_lines":[{"line_number":1843,"context_line":"                             ovs_test_base.OVSRyuTestBase):"},{"line_number":1844,"context_line":"    def test_cleanup_stale_flows(self):"},{"line_number":1845,"context_line":"        uint64_max \u003d (1 \u003c\u003c 64) - 1"},{"line_number":1846,"context_line":"        with mock.patch.object(self.agent.int_br, \u0027default_cookie\u0027,"},{"line_number":1847,"context_line":"                               new\u003d1234),\\"},{"line_number":1848,"context_line":"            mock.patch.object(self.agent.int_br,"},{"line_number":1849,"context_line":"                              \u0027dump_flows\u0027) as dump_flows,\\"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_5f0ca1ec","line":1846,"updated":"2016-02-12 15:13:31.000000000","message":"ditto","commit_id":"f64b70755fb393af5d583e3034debb755d7da70a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ad23a55b4a3d2c7b6f9194c4e53c8b0bbac25b39","unresolved":false,"context_lines":[{"line_number":1820,"context_line":"                              \u0027dump_flows_all_tables\u0027) as dump_flows,\\"},{"line_number":1821,"context_line":"                mock.patch.object(self.agent.int_br,"},{"line_number":1822,"context_line":"                                  \u0027delete_flows\u0027) as del_flow:"},{"line_number":1823,"context_line":"            self.agent.int_br.set_agent_uuid_stamp(0x4d2)"},{"line_number":1824,"context_line":"            dump_flows.return_value \u003d ["},{"line_number":1825,"context_line":"                \u0027cookie\u003d0x4d2, duration\u003d50.156s, table\u003d0,actions\u003ddrop\u0027,"},{"line_number":1826,"context_line":"                \u0027cookie\u003d0x4321, duration\u003d54.143s, table\u003d2, priority\u003d0\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_ee5801fd","line":1823,"updated":"2016-02-15 16:51:31.000000000","message":"you pass hex value here but dec value below. any reason?","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d15617661a5ff6170dc89a1eddd38f08d4b619bb","unresolved":false,"context_lines":[{"line_number":1820,"context_line":"                              \u0027dump_flows_all_tables\u0027) as dump_flows,\\"},{"line_number":1821,"context_line":"                mock.patch.object(self.agent.int_br,"},{"line_number":1822,"context_line":"                                  \u0027delete_flows\u0027) as del_flow:"},{"line_number":1823,"context_line":"            self.agent.int_br.set_agent_uuid_stamp(0x4d2)"},{"line_number":1824,"context_line":"            dump_flows.return_value \u003d ["},{"line_number":1825,"context_line":"                \u0027cookie\u003d0x4d2, duration\u003d50.156s, table\u003d0,actions\u003ddrop\u0027,"},{"line_number":1826,"context_line":"                \u0027cookie\u003d0x4321, duration\u003d54.143s, table\u003d2, priority\u003d0\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_0b0bf3d6","line":1823,"in_reply_to":"dae33548_ee5801fd","updated":"2016-02-18 09:55:09.000000000","message":"The flows below display the value as hex so I thought it would be more explicit.","commit_id":"baad4d67d8e1c99361c6ef06af15845f55941348"}]}
