)]}'
{"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"33ad2da7cca10acf30be95c50c7cc931008c538c","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"            attrs[\u0027status\u0027] \u003d const.PORT_STATUS_DOWN"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"        session \u003d context.session"},{"line_number":1024,"context_line":"        with db_api.exc_to_retry(os_db_exception.DBDuplicateEntry),\\"},{"line_number":1025,"context_line":"                session.begin(subtransactions\u003dTrue):"},{"line_number":1026,"context_line":"            dhcp_opts \u003d attrs.get(edo_ext.EXTRADHCPOPTS, [])"},{"line_number":1027,"context_line":"            result \u003d super(Ml2Plugin, self).create_port(context, port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_2e015838","line":1024,"range":{"start_line":1024,"start_character":13,"end_line":1024,"end_character":66},"updated":"2016-01-15 08:53:39.000000000","message":"Have you thought on doing it less broader (for only ip allocation block)? I mean potentially there could be other places raising DBDuplicateEntry that do not have \"normal\" duplicate check which will be triggered on a second attempt.","commit_id":"f67fc3cb08ce4f0e6fc685801a243fe68503578e"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"01045b497cf7ad90587a5bcf6cfb326e82b9e884","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"            attrs[\u0027status\u0027] \u003d const.PORT_STATUS_DOWN"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"        session \u003d context.session"},{"line_number":1024,"context_line":"        with db_api.exc_to_retry(os_db_exception.DBDuplicateEntry),\\"},{"line_number":1025,"context_line":"                session.begin(subtransactions\u003dTrue):"},{"line_number":1026,"context_line":"            dhcp_opts \u003d attrs.get(edo_ext.EXTRADHCPOPTS, [])"},{"line_number":1027,"context_line":"            result \u003d super(Ml2Plugin, self).create_port(context, port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_2e1e2170","line":1024,"range":{"start_line":1024,"start_character":13,"end_line":1024,"end_character":66},"in_reply_to":"da6ed579_2e015838","updated":"2016-01-15 15:26:12.000000000","message":"Unfortunately it the exception triggers when one of the context managers is exited and the info is sent to the DB. Check out the stack trace here to see an example: http://logs.openstack.org/38/257938/9/gate/gate-neutron-dsvm-api/d98d247/logs/screen-q-svc.txt.gz?level\u003dERROR#_2016-01-12_06_02_24_930","commit_id":"f67fc3cb08ce4f0e6fc685801a243fe68503578e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"6da4d29ae7e94cd62ff3547eccdd7d97b906c096","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"            attrs[\u0027status\u0027] \u003d const.PORT_STATUS_DOWN"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"        session \u003d context.session"},{"line_number":1024,"context_line":"        with db_api.exc_to_retry(os_db_exception.DBDuplicateEntry),\\"},{"line_number":1025,"context_line":"                session.begin(subtransactions\u003dTrue):"},{"line_number":1026,"context_line":"            dhcp_opts \u003d attrs.get(edo_ext.EXTRADHCPOPTS, [])"},{"line_number":1027,"context_line":"            result \u003d super(Ml2Plugin, self).create_port(context, port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_d17a8a76","line":1024,"range":{"start_line":1024,"start_character":13,"end_line":1024,"end_character":66},"in_reply_to":"da6ed579_2e1e2170","updated":"2016-01-15 15:29:35.000000000","message":"ah, right","commit_id":"f67fc3cb08ce4f0e6fc685801a243fe68503578e"}],"neutron/tests/unit/plugins/ml2/test_plugin.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"81c9f013630da0eabb42ec13d276be694011bed9","unresolved":false,"context_lines":[{"line_number":774,"context_line":"            self._test_operation_resillient_to_ipallocation_failure(do_request)"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    def _test_operation_resillient_to_ipallocation_failure(self, func):"},{"line_number":777,"context_line":"        from sqlalchemy import event"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"        class IPAllocationsGrenade(object):"},{"line_number":780,"context_line":"            insert_ip_called \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_572bcf94","line":777,"updated":"2016-01-16 04:12:05.000000000","message":"Don\u0027t do what again? Test-specific imports? What about the test-specific class right below it?\n\nIs there any justification for it other than style? If it\u0027s a style thing we want to rule out, it sounds like something that belongs in a hacking check.","commit_id":"f67fc3cb08ce4f0e6fc685801a243fe68503578e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1d0c152e0f80039032f9e75c5be0ec84d672941a","unresolved":false,"context_lines":[{"line_number":774,"context_line":"            self._test_operation_resillient_to_ipallocation_failure(do_request)"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    def _test_operation_resillient_to_ipallocation_failure(self, func):"},{"line_number":777,"context_line":"        from sqlalchemy import event"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"        class IPAllocationsGrenade(object):"},{"line_number":780,"context_line":"            insert_ip_called \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_7a8cd3d9","line":777,"updated":"2016-01-15 16:21:02.000000000","message":"nit: belongs at the top","commit_id":"f67fc3cb08ce4f0e6fc685801a243fe68503578e"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"a1527928fd17f13ba3058aef90c5bf301b8efd91","unresolved":false,"context_lines":[{"line_number":774,"context_line":"            self._test_operation_resillient_to_ipallocation_failure(do_request)"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    def _test_operation_resillient_to_ipallocation_failure(self, func):"},{"line_number":777,"context_line":"        from sqlalchemy import event"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"        class IPAllocationsGrenade(object):"},{"line_number":780,"context_line":"            insert_ip_called \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_88f6188d","line":777,"in_reply_to":"da6ed579_2a4844cb","updated":"2016-01-15 18:23:01.000000000","message":"Don\u0027t do this again.","commit_id":"f67fc3cb08ce4f0e6fc685801a243fe68503578e"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"86274659f4a9a587fe73ad9ea22e43e9fbc8befa","unresolved":false,"context_lines":[{"line_number":774,"context_line":"            self._test_operation_resillient_to_ipallocation_failure(do_request)"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    def _test_operation_resillient_to_ipallocation_failure(self, func):"},{"line_number":777,"context_line":"        from sqlalchemy import event"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"        class IPAllocationsGrenade(object):"},{"line_number":780,"context_line":"            insert_ip_called \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_16022f70","line":777,"in_reply_to":"da6ed579_572bcf94","updated":"2016-01-16 17:20:38.000000000","message":"I was just kidding, piling on the nit train.\n\nActually, I think locally scoped imports/classes/methods are good, and we should not rule them out.","commit_id":"f67fc3cb08ce4f0e6fc685801a243fe68503578e"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"aa28badd9f5cc54f9930856a4ac487b409e16edf","unresolved":false,"context_lines":[{"line_number":774,"context_line":"            self._test_operation_resillient_to_ipallocation_failure(do_request)"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    def _test_operation_resillient_to_ipallocation_failure(self, func):"},{"line_number":777,"context_line":"        from sqlalchemy import event"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"        class IPAllocationsGrenade(object):"},{"line_number":780,"context_line":"            insert_ip_called \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_2a4844cb","line":777,"in_reply_to":"da6ed579_7a8cd3d9","updated":"2016-01-15 17:42:14.000000000","message":"+1 but only if doing re-spin","commit_id":"f67fc3cb08ce4f0e6fc685801a243fe68503578e"}]}
