)]}'
{"neutron/api/v2/resource.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d5f9fdfc0c7d65c03cdb7477fbbadea46e794d45","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        return webob.Response(request\u003drequest, status\u003dstatus,"},{"line_number":148,"context_line":"                              content_type\u003dcontent_type,"},{"line_number":149,"context_line":"                              body\u003dbody)"},{"line_number":150,"context_line":"    #TODO(blogan): explain the need for this"},{"line_number":151,"context_line":"    setattr(resource, \u0027controller\u0027, controller)"},{"line_number":152,"context_line":"    return resource"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_274edb96","line":150,"updated":"2016-02-04 13:01:38.000000000","message":"that would be a nice idea ;)","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"24ac39f7c4f5a9ac58ab92a8288b6fa3e666e5bb","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        return webob.Response(request\u003drequest, status\u003dstatus,"},{"line_number":148,"context_line":"                              content_type\u003dcontent_type,"},{"line_number":149,"context_line":"                              body\u003dbody)"},{"line_number":150,"context_line":"    #TODO(blogan): explain the need for this"},{"line_number":151,"context_line":"    setattr(resource, \u0027controller\u0027, controller)"},{"line_number":152,"context_line":"    return resource"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_faf77fd0","line":150,"in_reply_to":"5a5ae5dd_274edb96","updated":"2016-02-08 09:16:51.000000000","message":"good thing i put that there to remind myself.  of course what is most likely to happen is i forget about it adn this TODO lives on forever.","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"}],"neutron/manager.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"17d764fc11f1fe9e5512cc7510d02ecac3c0cc67","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        res_plugin_mappings \u003d cls.get_instance().resource_plugin_mappings"},{"line_number":254,"context_line":"        return res_plugin_mappings.get("},{"line_number":255,"context_line":"            resource,"},{"line_number":256,"context_line":"            res_plugin_mappings.get(resource.replace(\u0027-\u0027, \u0027_\u0027)))"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    @classmethod"},{"line_number":259,"context_line":"    def set_controller_for_resource(cls, resource, controller):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_bebdaed9","line":256,"updated":"2016-03-04 21:34:06.000000000","message":"I thought this was not necessary anymore???","commit_id":"951e5092fb9ac279ed6328a67c4a0dd3c04af96e"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a84b574e1d45d43cadacb90d0f92990a4110b328","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        res_plugin_mappings \u003d cls.get_instance().resource_plugin_mappings"},{"line_number":254,"context_line":"        return res_plugin_mappings.get("},{"line_number":255,"context_line":"            resource,"},{"line_number":256,"context_line":"            res_plugin_mappings.get(resource.replace(\u0027-\u0027, \u0027_\u0027)))"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    @classmethod"},{"line_number":259,"context_line":"    def set_controller_for_resource(cls, resource, controller):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_bcaf5d7c","line":256,"in_reply_to":"7af24918_bebdaed9","updated":"2016-03-06 09:08:57.000000000","message":"aye! good catch.  The shim controllers werent init\u0027ing properly.  If this is the case, then the get_controller_for_resource can be simplified too no?","commit_id":"951e5092fb9ac279ed6328a67c4a0dd3c04af96e"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a84b574e1d45d43cadacb90d0f92990a4110b328","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        cls.get_instance().resource_controller_mappings[resource] \u003d controller"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    @classmethod"},{"line_number":263,"context_line":"    def get_controller_for_resource(cls, resource):"},{"line_number":264,"context_line":"        res_ctrl_mappings \u003d cls.get_instance().resource_controller_mappings"},{"line_number":265,"context_line":"        # If no controller is found for resource, try replacing dashes with"},{"line_number":266,"context_line":"        # underscores"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_9cb421d2","line":263,"updated":"2016-03-06 09:08:57.000000000","message":"here.","commit_id":"951e5092fb9ac279ed6328a67c4a0dd3c04af96e"}],"neutron/pecan_wsgi/controllers/resource.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d5f9fdfc0c7d65c03cdb7477fbbadea46e794d45","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                         \"code 404\"), subcollection)"},{"line_number":74,"context_line":"            pecan.abort(404)"},{"line_number":75,"context_line":"        request.context[\u0027subresource\u0027] \u003d None"},{"line_number":76,"context_line":"        request.context[\u0027subcollection\u0027] \u003d subcollection"},{"line_number":77,"context_line":"        return controller, remainder"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_271c9b76","line":76,"updated":"2016-02-04 13:01:38.000000000","message":"I thought you had a different patch for subresources?","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"24ac39f7c4f5a9ac58ab92a8288b6fa3e666e5bb","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                         \"code 404\"), subcollection)"},{"line_number":74,"context_line":"            pecan.abort(404)"},{"line_number":75,"context_line":"        request.context[\u0027subresource\u0027] \u003d None"},{"line_number":76,"context_line":"        request.context[\u0027subcollection\u0027] \u003d subcollection"},{"line_number":77,"context_line":"        return controller, remainder"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_5ad6d328","line":76,"in_reply_to":"5a5ae5dd_271c9b76","updated":"2016-02-08 09:16:51.000000000","message":"no i don\u0027t think so.  i would like to find a better way than this though.  worried the possibility of subsubcollection in the future, yuck.  perhaps it shouldn\u0027t be worried about until its need though.","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"69eec1a9a8948836e4abd5dd84f205980bc3bec0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                         \"code 404\"), subcollection)"},{"line_number":74,"context_line":"            pecan.abort(404)"},{"line_number":75,"context_line":"        request.context[\u0027subresource\u0027] \u003d None"},{"line_number":76,"context_line":"        request.context[\u0027subcollection\u0027] \u003d subcollection"},{"line_number":77,"context_line":"        return controller, remainder"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_a0754364","line":76,"in_reply_to":"5a5ae5dd_5ad6d328","updated":"2016-02-08 15:58:10.000000000","message":"We can make the resource attribute of the request context a stack and therefore being able to handle arbitrartily nested resources.\nStill if an API proposal with a subsubresource is made they\u0027ll have probably to pass over my dead body to have it approved (and they will likely pass... ;))","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d5f9fdfc0c7d65c03cdb7477fbbadea46e794d45","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Store resource identifier in request context"},{"line_number":87,"context_line":"        request.context[\u0027resource_id\u0027] \u003d item"},{"line_number":88,"context_line":"        item_name \u003d \u0027%s_id\u0027 % self.resource"},{"line_number":89,"context_line":"        request.context[\u0027named_items\u0027][item_name] \u003d item"},{"line_number":90,"context_line":"        return self.item_controller_class(self.resource, item), remainder"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @utils.expose(generic\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_5a196e78","line":89,"updated":"2016-02-04 13:01:38.000000000","message":"an","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"122eb8a913ceae85255762010257baeaab6144f9","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Store resource identifier in request context"},{"line_number":87,"context_line":"        request.context[\u0027resource_id\u0027] \u003d item"},{"line_number":88,"context_line":"        item_name \u003d \u0027%s_id\u0027 % self.resource"},{"line_number":89,"context_line":"        request.context[\u0027named_items\u0027][item_name] \u003d item"},{"line_number":90,"context_line":"        return self.item_controller_class(self.resource, item), remainder"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @utils.expose(generic\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_7edddf6f","line":89,"in_reply_to":"5a5ae5dd_20d63328","updated":"2016-02-15 08:01:47.000000000","message":"Unfortuntely, I think this is the easiest way.  I don\u0027t like it either but the scheduler controllers expect a kwarg to exist and it be the name of the resource + _id.  I can definitely name it better as suggested in another file though.  If you have ideas on how to better handle this, I\u0027m all ears.","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"24ac39f7c4f5a9ac58ab92a8288b6fa3e666e5bb","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Store resource identifier in request context"},{"line_number":87,"context_line":"        request.context[\u0027resource_id\u0027] \u003d item"},{"line_number":88,"context_line":"        item_name \u003d \u0027%s_id\u0027 % self.resource"},{"line_number":89,"context_line":"        request.context[\u0027named_items\u0027][item_name] \u003d item"},{"line_number":90,"context_line":"        return self.item_controller_class(self.resource, item), remainder"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @utils.expose(generic\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_5abd73d6","line":89,"in_reply_to":"5a5ae5dd_5a196e78","updated":"2016-02-08 09:16:51.000000000","message":"?","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"69eec1a9a8948836e4abd5dd84f205980bc3bec0","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Store resource identifier in request context"},{"line_number":87,"context_line":"        request.context[\u0027resource_id\u0027] \u003d item"},{"line_number":88,"context_line":"        item_name \u003d \u0027%s_id\u0027 % self.resource"},{"line_number":89,"context_line":"        request.context[\u0027named_items\u0027][item_name] \u003d item"},{"line_number":90,"context_line":"        return self.item_controller_class(self.resource, item), remainder"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @utils.expose(generic\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_20d63328","line":89,"in_reply_to":"5a5ae5dd_5abd73d6","updated":"2016-02-08 15:58:10.000000000","message":"Truncated comment... I\u0027m not sure what happened.\nI don\u0027t even remember exactly the wording of the comments, but it has to do with the fact that I\u0027m not thrilled about adding this named_items collection.\n\nDo you think there might be an easy way to do without it?","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"626ea917b2d15b5c9fc6790aaa382ec592b54602","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Store resource identifier in request context"},{"line_number":87,"context_line":"        request.context[\u0027resource_id\u0027] \u003d item"},{"line_number":88,"context_line":"        item_name \u003d \u0027%s_id\u0027 % self.resource"},{"line_number":89,"context_line":"        request.context[\u0027named_items\u0027][item_name] \u003d item"},{"line_number":90,"context_line":"        return self.item_controller_class(self.resource, item), remainder"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @utils.expose(generic\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_792cb04a","line":89,"in_reply_to":"dae33548_06b71c3a","updated":"2016-02-16 19:21:43.000000000","message":"I don\u0027t mind talking through a better way to do this right now.","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"cc81e0e38e4a2ca55268d173ea86e05b2922dcd4","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Store resource identifier in request context"},{"line_number":87,"context_line":"        request.context[\u0027resource_id\u0027] \u003d item"},{"line_number":88,"context_line":"        item_name \u003d \u0027%s_id\u0027 % self.resource"},{"line_number":89,"context_line":"        request.context[\u0027named_items\u0027][item_name] \u003d item"},{"line_number":90,"context_line":"        return self.item_controller_class(self.resource, item), remainder"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @utils.expose(generic\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_06b71c3a","line":89,"in_reply_to":"dae33548_7edddf6f","updated":"2016-02-15 12:25:41.000000000","message":"I have some ideas but might need experimenting - I\u0027d like to generalize the concept of resource and collection that we store in the lookup process to provide a list of resources and collections traversed by the lookup process.\n\nthat, together with the primary key information in RESOURCE_ATTRIBUTE_MAP for each resource will allow us to retrieve the information we need.\n\nNevertheless, we already shave this yak too much. Improvements can come into other patches","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"17d764fc11f1fe9e5512cc7510d02ecac3c0cc67","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Store resource identifier in request context"},{"line_number":87,"context_line":"        request.context[\u0027resource_id\u0027] \u003d item"},{"line_number":88,"context_line":"        uri_identifier \u003d \u0027%s_id\u0027 % self.resource"},{"line_number":89,"context_line":"        request.context[\u0027uri_identifiers\u0027][uri_identifier] \u003d item"},{"line_number":90,"context_line":"        return self.item_controller_class(self.resource, item), remainder"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @utils.expose(generic\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_be2f6e3d","line":89,"updated":"2016-03-04 21:34:06.000000000","message":"I still am not really excited by this, but on the other hand I am guilty of not having worked to a better solution.\n\nThe reason that it does not excite me is that there\u0027s information redundancy with resource_id.\n\nBut don\u0027t worry - it\u0027s a rather small bit of technical debt to repay.\nPut it on my tab, please.","commit_id":"951e5092fb9ac279ed6328a67c4a0dd3c04af96e"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a84b574e1d45d43cadacb90d0f92990a4110b328","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Store resource identifier in request context"},{"line_number":87,"context_line":"        request.context[\u0027resource_id\u0027] \u003d item"},{"line_number":88,"context_line":"        uri_identifier \u003d \u0027%s_id\u0027 % self.resource"},{"line_number":89,"context_line":"        request.context[\u0027uri_identifiers\u0027][uri_identifier] \u003d item"},{"line_number":90,"context_line":"        return self.item_controller_class(self.resource, item), remainder"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @utils.expose(generic\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_1652b0dd","line":89,"in_reply_to":"7af24918_be2f6e3d","updated":"2016-03-06 09:08:57.000000000","message":"agreed, its definitely hacky.  However, its not that the resource_id isn\u0027t available, its that those particular controllers expect kwargs by specific names, so it\u0027s hard to genericize it.  I think you get that, though.","commit_id":"951e5092fb9ac279ed6328a67c4a0dd3c04af96e"}],"neutron/pecan_wsgi/controllers/root.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d5f9fdfc0c7d65c03cdb7477fbbadea46e794d45","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        # This is for backwards compatibility with legacy extensions that"},{"line_number":98,"context_line":"        # defined their own controllers and expected kwargs to be passed in"},{"line_number":99,"context_line":"        # with the named_items"},{"line_number":100,"context_line":"        request.context[\u0027named_items\u0027] \u003d {}"},{"line_number":101,"context_line":"        return controller, remainder"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_da7f9e64","line":100,"updated":"2016-02-04 13:01:38.000000000","message":"Looks decent to me. I think we can do better but we don\u0027t have to find the best solution now.\n\nnamed_items is not a great name - Indeed I first review the change in CollectionsController and could not figure out its purpose.\n\nI suggest something like uri_identifiers, but it\u0027s a minor point.","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"122eb8a913ceae85255762010257baeaab6144f9","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        # This is for backwards compatibility with legacy extensions that"},{"line_number":98,"context_line":"        # defined their own controllers and expected kwargs to be passed in"},{"line_number":99,"context_line":"        # with the named_items"},{"line_number":100,"context_line":"        request.context[\u0027named_items\u0027] \u003d {}"},{"line_number":101,"context_line":"        return controller, remainder"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_9e46e3bd","line":100,"in_reply_to":"5a5ae5dd_9a9e8b61","updated":"2016-02-15 08:01:47.000000000","message":"Done","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"24ac39f7c4f5a9ac58ab92a8288b6fa3e666e5bb","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        # This is for backwards compatibility with legacy extensions that"},{"line_number":98,"context_line":"        # defined their own controllers and expected kwargs to be passed in"},{"line_number":99,"context_line":"        # with the named_items"},{"line_number":100,"context_line":"        request.context[\u0027named_items\u0027] \u003d {}"},{"line_number":101,"context_line":"        return controller, remainder"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_9a9e8b61","line":100,"in_reply_to":"5a5ae5dd_da7f9e64","updated":"2016-02-08 09:16:51.000000000","message":"i suck at naming things on the first pass.  uri_identifiers is better.","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"}],"neutron/pecan_wsgi/controllers/router.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bd499264e145d90f42b62069681f205fe0ac4152","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9aed3d3a_41f3d273","line":112,"updated":"2016-02-26 05:55:31.000000000","message":"No newline at end of file","commit_id":"1f1493e298b2c1d1a8eae11d98a3104502cc045d"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"6411b3a5bfa080e9870584ef4a4384c9da746d48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9aed3d3a_1c79edc8","line":112,"in_reply_to":"9aed3d3a_41f3d273","updated":"2016-02-27 07:24:24.000000000","message":"how did these happen","commit_id":"1f1493e298b2c1d1a8eae11d98a3104502cc045d"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"17d764fc11f1fe9e5512cc7510d02ecac3c0cc67","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        super(RoutersController, self).__init__(\u0027routers\u0027, \u0027router\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class RouterMemberActionController(resource.ItemController):"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, resource, item, member_action):"},{"line_number":74,"context_line":"        super(RouterMemberActionController, self).__init__(resource, item)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_99d72ced","line":71,"updated":"2016-03-04 21:34:06.000000000","message":"The uglyness is great with this class.\n\nBut that\u0027s ok.","commit_id":"951e5092fb9ac279ed6328a67c4a0dd3c04af96e"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a84b574e1d45d43cadacb90d0f92990a4110b328","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        super(RoutersController, self).__init__(\u0027routers\u0027, \u0027router\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class RouterMemberActionController(resource.ItemController):"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, resource, item, member_action):"},{"line_number":74,"context_line":"        super(RouterMemberActionController, self).__init__(resource, item)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_7604d4c5","line":71,"in_reply_to":"7af24918_99d72ced","updated":"2016-03-06 09:08:57.000000000","message":"Actually, I have to disagree.  I think its better to let pecan controllers handle the routing of actions, rather than checking if args exist in particular method.  This is subjective though and I will concede that it does have to repeat some of the same boilerplate code of setting up a controller.","commit_id":"951e5092fb9ac279ed6328a67c4a0dd3c04af96e"}],"neutron/pecan_wsgi/controllers/utils.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d5f9fdfc0c7d65c03cdb7477fbbadea46e794d45","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        return self.controller_delete(shim_request, self.item, **named_items)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class ShimController(object):"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def __init__(self, collection, resource, controller):"},{"line_number":77,"context_line":"        self.collection \u003d collection"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_9a7366e7","line":74,"updated":"2016-02-04 13:01:38.000000000","message":"ShimCollectionController, if you want.\nOtherwise meh","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"122eb8a913ceae85255762010257baeaab6144f9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        return self.controller_delete(shim_request, self.item, **named_items)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class ShimController(object):"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def __init__(self, collection, resource, controller):"},{"line_number":77,"context_line":"        self.collection \u003d collection"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_be4927d3","line":74,"in_reply_to":"5a5ae5dd_3a843709","updated":"2016-02-15 08:01:47.000000000","message":"Done","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"24ac39f7c4f5a9ac58ab92a8288b6fa3e666e5bb","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        return self.controller_delete(shim_request, self.item, **named_items)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class ShimController(object):"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def __init__(self, collection, resource, controller):"},{"line_number":77,"context_line":"        self.collection \u003d collection"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_3a843709","line":74,"in_reply_to":"5a5ae5dd_9a7366e7","updated":"2016-02-08 09:16:51.000000000","message":"that does make better sense.","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"17d764fc11f1fe9e5512cc7510d02ecac3c0cc67","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            pecan.abort(405)"},{"line_number":105,"context_line":"        shim_request \u003d ShimRequest(request.context[\u0027neutron_context\u0027])"},{"line_number":106,"context_line":"        uri_identifiers \u003d request.context[\u0027uri_identifiers\u0027]"},{"line_number":107,"context_line":"        return self.controller_create(shim_request, request.json,"},{"line_number":108,"context_line":"                                      **uri_identifiers)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @expose()"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_9e571226","line":107,"updated":"2016-03-04 21:34:06.000000000","message":"If the controller\u0027s create method does not exist this is going to fail spectacularly.\n\nI think:\n\ntry:\n    self.controller.create(shim_request, request.json, **uri_identifiers)\nexcept AttributeError:\n    pecan.abort(405)\n\nworks better","commit_id":"951e5092fb9ac279ed6328a67c4a0dd3c04af96e"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a84b574e1d45d43cadacb90d0f92990a4110b328","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            pecan.abort(405)"},{"line_number":105,"context_line":"        shim_request \u003d ShimRequest(request.context[\u0027neutron_context\u0027])"},{"line_number":106,"context_line":"        uri_identifiers \u003d request.context[\u0027uri_identifiers\u0027]"},{"line_number":107,"context_line":"        return self.controller_create(shim_request, request.json,"},{"line_number":108,"context_line":"                                      **uri_identifiers)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @expose()"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_16e47039","line":107,"in_reply_to":"7af24918_9e571226","updated":"2016-03-06 09:08:57.000000000","message":"Doesn\u0027t L103-L104 take care of that?  Perhaps it\u0027d also be more defensive to check if its callable too, but i figured that was being too defensive.","commit_id":"951e5092fb9ac279ed6328a67c4a0dd3c04af96e"}],"neutron/pecan_wsgi/hooks/quota_enforcement.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d5f9fdfc0c7d65c03cdb7477fbbadea46e794d45","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        if state.request.method !\u003d \u0027POST\u0027 or not resource:"},{"line_number":36,"context_line":"            return"},{"line_number":37,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin_for_resource(resource)"},{"line_number":38,"context_line":"        items \u003d state.request.context.get(\u0027resources\u0027, [])"},{"line_number":39,"context_line":"        # Store requested resource amounts grouping them by tenant"},{"line_number":40,"context_line":"        deltas \u003d collections.defaultdict(int)"},{"line_number":41,"context_line":"        for item in items:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_5a02ce0c","line":38,"updated":"2016-02-04 13:01:38.000000000","message":"What\u0027s the value of the \u0027resource\u0027 context variable when the request is routed to an agent scheduler controller?","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"24ac39f7c4f5a9ac58ab92a8288b6fa3e666e5bb","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        if state.request.method !\u003d \u0027POST\u0027 or not resource:"},{"line_number":36,"context_line":"            return"},{"line_number":37,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin_for_resource(resource)"},{"line_number":38,"context_line":"        items \u003d state.request.context.get(\u0027resources\u0027, [])"},{"line_number":39,"context_line":"        # Store requested resource amounts grouping them by tenant"},{"line_number":40,"context_line":"        deltas \u003d collections.defaultdict(int)"},{"line_number":41,"context_line":"        for item in items:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_9aac4b8d","line":38,"in_reply_to":"5a5ae5dd_5a02ce0c","updated":"2016-02-08 09:16:51.000000000","message":"i\u0027ll have to check this tomorrow and get back to you.","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"122eb8a913ceae85255762010257baeaab6144f9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        if state.request.method !\u003d \u0027POST\u0027 or not resource:"},{"line_number":36,"context_line":"            return"},{"line_number":37,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin_for_resource(resource)"},{"line_number":38,"context_line":"        items \u003d state.request.context.get(\u0027resources\u0027, [])"},{"line_number":39,"context_line":"        # Store requested resource amounts grouping them by tenant"},{"line_number":40,"context_line":"        deltas \u003d collections.defaultdict(int)"},{"line_number":41,"context_line":"        for item in items:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_1e3ad336","line":38,"in_reply_to":"5a5ae5dd_9aac4b8d","updated":"2016-02-15 08:01:47.000000000","message":"So tomorrow turned into next week, but finally got time to come back to this review.  resource is \u0027agent\u0027.\n\nI now can\u0027t remember why I made this specific change though.","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"cc81e0e38e4a2ca55268d173ea86e05b2922dcd4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        if state.request.method !\u003d \u0027POST\u0027 or not resource:"},{"line_number":36,"context_line":"            return"},{"line_number":37,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin_for_resource(resource)"},{"line_number":38,"context_line":"        items \u003d state.request.context.get(\u0027resources\u0027, [])"},{"line_number":39,"context_line":"        # Store requested resource amounts grouping them by tenant"},{"line_number":40,"context_line":"        deltas \u003d collections.defaultdict(int)"},{"line_number":41,"context_line":"        for item in items:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_a6cab09f","line":38,"in_reply_to":"dae33548_1e3ad336","updated":"2016-02-15 12:25:41.000000000","message":"I see. The agent resource would crash the quota hook.\nPerhaps we can find a better way around this, but frankly this is good as well.","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"17d764fc11f1fe9e5512cc7510d02ecac3c0cc67","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        if state.request.method !\u003d \u0027POST\u0027 or not resource:"},{"line_number":36,"context_line":"            return"},{"line_number":37,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin_for_resource(resource)"},{"line_number":38,"context_line":"        items \u003d state.request.context.get(\u0027resources\u0027, [])"},{"line_number":39,"context_line":"        # Store requested resource amounts grouping them by tenant"},{"line_number":40,"context_line":"        deltas \u003d collections.Counter(map(lambda x: x[\u0027tenant_id\u0027], items))"},{"line_number":41,"context_line":"        # Perform quota enforcement"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_142481ad","line":38,"updated":"2016-03-04 21:34:06.000000000","message":"The reason I did not add a default [] is that I assumed that if there was a resource there should have been somehow resources.... which is not the case for the extensions we\u0027re treating here.\n\nI suggest to make the logic more streamline grabbing resource as it was at line 34 and then changing the condition at line 35:\n\nif state.request.method !\u003d \u0027POST\u0027 or not resources:\n\n(I just added a \u0027s\u0027 at the end)","commit_id":"951e5092fb9ac279ed6328a67c4a0dd3c04af96e"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a84b574e1d45d43cadacb90d0f92990a4110b328","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        if state.request.method !\u003d \u0027POST\u0027 or not resource:"},{"line_number":36,"context_line":"            return"},{"line_number":37,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin_for_resource(resource)"},{"line_number":38,"context_line":"        items \u003d state.request.context.get(\u0027resources\u0027, [])"},{"line_number":39,"context_line":"        # Store requested resource amounts grouping them by tenant"},{"line_number":40,"context_line":"        deltas \u003d collections.Counter(map(lambda x: x[\u0027tenant_id\u0027], items))"},{"line_number":41,"context_line":"        # Perform quota enforcement"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_1c7491fb","line":38,"in_reply_to":"7af24918_142481ad","updated":"2016-03-06 09:08:57.000000000","message":"Done for the most part.  Kept resource bc it is still needed in the line above.","commit_id":"951e5092fb9ac279ed6328a67c4a0dd3c04af96e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"ae81c2816e7a72aa44b75d1821e2f478a5951a0f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        if state.request.method !\u003d \u0027POST\u0027 or not resource:"},{"line_number":36,"context_line":"            return"},{"line_number":37,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin_for_resource(resource)"},{"line_number":38,"context_line":"        items \u003d state.request.context.get(\u0027resources\u0027, [])"},{"line_number":39,"context_line":"        # Store requested resource amounts grouping them by tenant"},{"line_number":40,"context_line":"        deltas \u003d collections.Counter(map(lambda x: x[\u0027tenant_id\u0027], items))"},{"line_number":41,"context_line":"        # Perform quota enforcement"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_77ddfd41","line":38,"in_reply_to":"7af24918_1c7491fb","updated":"2016-03-07 15:16:04.000000000","message":"yeah makes sense","commit_id":"951e5092fb9ac279ed6328a67c4a0dd3c04af96e"}],"neutron/pecan_wsgi/startup.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d5f9fdfc0c7d65c03cdb7477fbbadea46e794d45","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            if manager.NeutronManager.get_plugin_for_resource(collection):"},{"line_number":88,"context_line":"                continue"},{"line_number":89,"context_line":"            # This is an extension that has not been loaded"},{"line_number":90,"context_line":"            leftovers.append((collection, resource, controller))"},{"line_number":91,"context_line":"    for leftover in leftovers:"},{"line_number":92,"context_line":"        shim_controller \u003d utils.ShimController(*leftover)"},{"line_number":93,"context_line":"        manager.NeutronManager.set_controller_for_resource("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_6e97c890","line":90,"updated":"2016-02-04 13:01:38.000000000","message":"The \"base\" pecan controller is good enough also for many non-pecanized extensions. I\u0027m not sure why we want to use the shim controller for those, can you explain?","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"24ac39f7c4f5a9ac58ab92a8288b6fa3e666e5bb","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            if manager.NeutronManager.get_plugin_for_resource(collection):"},{"line_number":88,"context_line":"                continue"},{"line_number":89,"context_line":"            # This is an extension that has not been loaded"},{"line_number":90,"context_line":"            leftovers.append((collection, resource, controller))"},{"line_number":91,"context_line":"    for leftover in leftovers:"},{"line_number":92,"context_line":"        shim_controller \u003d utils.ShimController(*leftover)"},{"line_number":93,"context_line":"        manager.NeutronManager.set_controller_for_resource("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_facf7f53","line":90,"in_reply_to":"5a5ae5dd_6e97c890","updated":"2016-02-08 09:16:51.000000000","message":"I think in this instance I was testing out whether this could be used for any out of tree extensions that did not support pecan.  It\u0027s possible, but a bit hacky.  So is getting the agent scheduler controllers working though.","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d5f9fdfc0c7d65c03cdb7477fbbadea46e794d45","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    pecanized_exts \u003d [ext for ext in ext_mgr.extensions.values() if"},{"line_number":104,"context_line":"                      hasattr(ext, \u0027get_pecan_controllers\u0027)]"},{"line_number":105,"context_line":"    non_pecanized_exts \u003d [ext for ext in ext_mgr.extensions.values() if"},{"line_number":106,"context_line":"                          not hasattr(ext, \u0027get_pecan_controllers\u0027)]"},{"line_number":107,"context_line":"    pecan_controllers \u003d {}"},{"line_number":108,"context_line":"    for ext in pecanized_exts:"},{"line_number":109,"context_line":"        LOG.info(_LI(\"Extension %s is pecan-aware. Fetching resources \""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_8e6484e5","line":106,"updated":"2016-02-04 13:01:38.000000000","message":"you could use set logic\n\nnon_pecanized_exts \u003d set(ext_mgr.extensions.values() - set(pecanized_exts)","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"24ac39f7c4f5a9ac58ab92a8288b6fa3e666e5bb","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    pecanized_exts \u003d [ext for ext in ext_mgr.extensions.values() if"},{"line_number":104,"context_line":"                      hasattr(ext, \u0027get_pecan_controllers\u0027)]"},{"line_number":105,"context_line":"    non_pecanized_exts \u003d [ext for ext in ext_mgr.extensions.values() if"},{"line_number":106,"context_line":"                          not hasattr(ext, \u0027get_pecan_controllers\u0027)]"},{"line_number":107,"context_line":"    pecan_controllers \u003d {}"},{"line_number":108,"context_line":"    for ext in pecanized_exts:"},{"line_number":109,"context_line":"        LOG.info(_LI(\"Extension %s is pecan-aware. Fetching resources \""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_faf69f8d","line":106,"in_reply_to":"5a5ae5dd_8e6484e5","updated":"2016-02-08 09:16:51.000000000","message":"noice! will do","commit_id":"aa2330b7817180b095d02ebdd3f1e988f63ff52c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bd499264e145d90f42b62069681f205fe0ac4152","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            LOG.warn(_LW(\"No plugin found for resource:%s. API calls \""},{"line_number":138,"context_line":"                         \"may not be correctly dispatched\"), resource)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        controller \u003d pecan_controllers.pop(collection, None)"},{"line_number":141,"context_line":"        if not controller:"},{"line_number":142,"context_line":"            LOG.debug(\"Building controller for resource:%s\", resource)"},{"line_number":143,"context_line":"            controller \u003d res_ctrl.CollectionsController(collection, resource)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_61eed68c","line":140,"updated":"2016-02-26 05:55:31.000000000","message":"excuse my stupidity, but why are you popping here?","commit_id":"1f1493e298b2c1d1a8eae11d98a3104502cc045d"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"6411b3a5bfa080e9870584ef4a4384c9da746d48","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            LOG.warn(_LW(\"No plugin found for resource:%s. API calls \""},{"line_number":138,"context_line":"                         \"may not be correctly dispatched\"), resource)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        controller \u003d pecan_controllers.pop(collection, None)"},{"line_number":141,"context_line":"        if not controller:"},{"line_number":142,"context_line":"            LOG.debug(\"Building controller for resource:%s\", resource)"},{"line_number":143,"context_line":"            controller \u003d res_ctrl.CollectionsController(collection, resource)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_dca6650f","line":140,"in_reply_to":"9aed3d3a_61eed68c","updated":"2016-02-27 07:24:24.000000000","message":"I think this is an artifact of logic I was originally attempting.  You were there when our brains weren\u0027t working.","commit_id":"1f1493e298b2c1d1a8eae11d98a3104502cc045d"}],"neutron/tests/functional/pecan_wsgi/test_controllers.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bd499264e145d90f42b62069681f205fe0ac4152","unresolved":false,"context_lines":[{"line_number":232,"context_line":"# TODO(blogan): create more reusable fixtures that do not have tests defined"},{"line_number":233,"context_line":"# so that any test class that inherits them gets the helper methods but"},{"line_number":234,"context_line":"# doesn\u0027t also run the same tests over and over."},{"line_number":235,"context_line":"class ResourceControllerFixture(TestRootController):"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def setUp(self):"},{"line_number":238,"context_line":"        cfg.CONF.set_override("}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_a1e8de7d","line":235,"updated":"2016-02-26 05:55:31.000000000","message":"Sorry to nitpick, but Fixture probably isn\u0027t a good suffix because it implies that it\u0027s a resource created and destroyed by using useFixture (e.g. https://github.com/openstack/neutron/blob/master/neutron/tests/common/net_helpers.py#L481-L517). This is still just a testcase.","commit_id":"1f1493e298b2c1d1a8eae11d98a3104502cc045d"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"6411b3a5bfa080e9870584ef4a4384c9da746d48","unresolved":false,"context_lines":[{"line_number":232,"context_line":"# TODO(blogan): create more reusable fixtures that do not have tests defined"},{"line_number":233,"context_line":"# so that any test class that inherits them gets the helper methods but"},{"line_number":234,"context_line":"# doesn\u0027t also run the same tests over and over."},{"line_number":235,"context_line":"class ResourceControllerFixture(TestRootController):"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def setUp(self):"},{"line_number":238,"context_line":"        cfg.CONF.set_override("}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_bcd561ba","line":235,"in_reply_to":"9aed3d3a_a1e8de7d","updated":"2016-02-27 07:24:24.000000000","message":"good nitpick.  i was just using the generic fixture term the python unittests use, not the library fixture.","commit_id":"1f1493e298b2c1d1a8eae11d98a3104502cc045d"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bd499264e145d90f42b62069681f205fe0ac4152","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9aed3d3a_81edda8d","line":561,"updated":"2016-02-26 05:55:31.000000000","message":"No newline at end of file","commit_id":"1f1493e298b2c1d1a8eae11d98a3104502cc045d"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"6411b3a5bfa080e9870584ef4a4384c9da746d48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9aed3d3a_3ce2f19f","line":561,"in_reply_to":"9aed3d3a_81edda8d","updated":"2016-02-27 07:24:24.000000000","message":"Done","commit_id":"1f1493e298b2c1d1a8eae11d98a3104502cc045d"}]}
